Skip to contentSkip to conversation

net: efi-snp: fix mac address change when it is not supported.

PATCH Applied [email protected] 2 participants 2 messages Sep 27, 2025 – Sep 29, 2025 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: efi-snp: fix mac address change when it is not supported.

From: Chali Anis <[email protected]>

continue interface open if the efiret is unsupported since the mac address change is not always supported, this permits to not fail when the network could be used since it already has a network mac address configured, this is at least the case on qemu with certain versions of EDK2.

---
 drivers/net/efi-snp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/efi-snp.c +1 -1
index 119358b6c880..b4d2abfecf77 100644
@@ -219,7 +219,7 @@ static int efi_snp_eth_open(struct eth_device *edev)
 
 	efiret = priv->snp->station_address(priv->snp, false,
 			(struct efi_mac_address *)priv->snp->Mode->PermanentAddress.Addr );
-	if (EFI_ERROR(efiret)) {
+	if (EFI_ERROR(efiret) && efiret != EFI_UNSUPPORTED) {
 		dev_err(priv->dev, "failed to set MAC address: %s\n",
 				efi_strerror(efiret));
 		return -efi_errno(efiret);
Signature · 1 line
2.34.1
Applied
#1 lore raw
Quoted 6 lines · On Sat, 27 Sep 2025 12:33:01 -0400, [email protected] wrote:

continue interface open if the efiret is unsupported since the mac address change is not always supported, this permits to not fail when the network could be used since it already has a network mac address configured, this is at least the case on qemu with certain versions of EDK2.

Applied, thanks!

[1/1] net: efi-snp: fix mac address change when it is not supported.
https://git.pengutronix.de/cgit/barebox/commit/?id=27116afa8d38 (link may not be stable)

Best regards,

Signature · 1 line
Sascha Hauer <[email protected]>