i2c: usbio: Add ACPI device-id for MTL-CVF devices
Hans de Goede
maintainerPATCH 1/2 i2c: usbio: Add ACPI device-id for MTL-CVF devices
Add "INTC10D2" ACPI device-id for MTL-CVF devices, like the Dell Latitude 7450.
---
Note this applies on top of the addition of the new i2c-usbio driver which is being merged through gregkh/usb.git usb-next
--- drivers/i2c/busses/i2c-usbio.c | 1 + 1 file changed, 1 insertion(+)
drivers/i2c/busses/i2c-usbio.c +1 -0
@@ -27,6 +27,7 @@ static const struct acpi_device_id usbio_i2c_acpi_hids[] = { { "INTC1008" }, /* MTL */ { "INTC10B3" }, /* ARL */ { "INTC10B6" }, /* LNL */ + { "INTC10D2" }, /* MTL-CVF */ { "INTC10E3" }, /* PTL */ { } };
Signature · 1 line
2.51.0
Sakari Ailus
reviewerHi Hans,
Quoted 17 lines · Hans de Goede
Add "INTC10D2" ACPI device-id for MTL-CVF devices, like the Dell Latitude 7450.
Signed-off-by Hans de Goede <[email protected]>---
Note this applies on top of the addition of the new i2c-usbio driver which is being merged through gregkh/usb.git usb-next--- drivers/i2c/busses/i2c-usbio.c | 1 + 1 file changed, 1 insertion(+)drivers/i2c/busses/i2c-usbio.c +0
-0
drivers/i2c/busses/i2c-usbio.c static const struct acpi_device_id usbio_i2c_acpi_hids[] = { · line 30
Quoted 4 lines
drivers/i2c/busses/i2c-usbio.c +1
-0@@ -27,6 +27,7 @@ static const struct acpi_device_id usbio_i2c_acpi_hids[] = { { "INTC1008" }, /* MTL */ { "INTC10B3" }, /* ARL */ { "INTC10B6" }, /* LNL */ + { "INTC10D2" }, /* MTL-CVF */
INTC10D2 is apparently already claimed by the LJCA I²C driver. Do you have an actual system that uses USBIO and this HID?
Quoted 3 lines
drivers/i2c/busses/i2c-usbio.c +0
-0{ "INTC10E3" }, /* PTL */ { } };
Signature · 3 lines
Kind regards, Sakari Ailus
Sakari Ailus
reviewerHi Hans, Lixu,
Quoted 15 lines · Sakari Ailus
Hi Hans,
Quoted 12 lines · Hans de Goede
Add "INTC10D2" ACPI device-id for MTL-CVF devices, like the Dell Latitude 7450.
Signed-off-by Hans de Goede <[email protected]>---
Note this applies on top of the addition of the new i2c-usbio driver which is being merged through gregkh/usb.git usb-next--- drivers/i2c/busses/i2c-usbio.c | 1 + 1 file changed, 1 insertion(+)
Quoted 12 lines
drivers/i2c/busses/i2c-usbio.c static const struct acpi_device_id usbio_i2c_acpi_hids[] = { · line 30
Quoted 9 lines
drivers/i2c/busses/i2c-usbio.c +1
-0@@ -27,6 +27,7 @@ static const struct acpi_device_id usbio_i2c_acpi_hids[] = { { "INTC1008" }, /* MTL */ { "INTC10B3" }, /* ARL */ { "INTC10B6" }, /* LNL */ + { "INTC10D2" }, /* MTL-CVF */INTC10D2 is apparently already claimed by the LJCA I²C driver. Do you have an actual system that uses USBIO and this HID?
Actually it looks like i2c-ljca.c shouldn't list this HID. The same probably goes for all 10CF--10D3.
Lixu: any idea?
I thought USBIO always came with CVS but that doesn't seem to be the case here.
Quoted 5 lines
Quoted 4 lines
drivers/i2c/busses/i2c-usbio.c +0
-0{ "INTC10E3" }, /* PTL */ { } };
Signature · 3 lines
Regards, Sakari Ailus
Hans de Goede
maintainerHi,
First of all I messed up the git format-patch command, there is no second patch in this series.
(at least not for the i2c subsystem. There is a similar GPIO patch but I send that out separately)
Quoted 15 lines · Sakari Ailus
Hi Hans,
Quoted 12 lines · Hans de Goede
Add "INTC10D2" ACPI device-id for MTL-CVF devices, like the Dell Latitude 7450.
Signed-off-by Hans de Goede <[email protected]>---
Note this applies on top of the addition of the new i2c-usbio driver which is being merged through gregkh/usb.git usb-next--- drivers/i2c/busses/i2c-usbio.c | 1 + 1 file changed, 1 insertion(+)
Quoted 12 lines
drivers/i2c/busses/i2c-usbio.c static const struct acpi_device_id usbio_i2c_acpi_hids[] = { · line 30
Quoted 9 lines
drivers/i2c/busses/i2c-usbio.c +1
-0@@ -27,6 +27,7 @@ static const struct acpi_device_id usbio_i2c_acpi_hids[] = { { "INTC1008" }, /* MTL */ { "INTC10B3" }, /* ARL */ { "INTC10B6" }, /* LNL */ + { "INTC10D2" }, /* MTL-CVF */INTC10D2 is apparently already claimed by the LJCA I²C driver. Do you have an actual system that uses USBIO and this HID?
Yes, see the Closes: tag which points to a bug-report which such a system:
https://bugzilla.redhat.com/show_bug.cgi?id=2368506
Let me also reply to your other comment here:
Quoted 5 lines
Quoted 2 lines
INTC10D2 is apparently already claimed by the LJCA I²C driver. Do you have an actual system that uses USBIO and this HID?
Actually it looks like
i2c-ljca.cshouldn't list this HID. The same probably goes for all 10CF--10D3.
I would not be so sure of this, there are at least some Dell systems which use a combination of ljca and Meteor Lake and I believe these do use the "INTC10D2" HID with LJCA for the I2C part and the same goes for the GPIO / SPI parts.. One example of such a system is the Dell Precision 5490.
The way these Intel uses these HIDs is really weird they seem to simply mean "I2C" on *a* USBIO expander with this generation CPU.
Where there really seems no reason to change the HID for CPU generations, where as it would be a good reason to change the HID if the actual USBIO expander is different ...
Regards,
Hans
Sakari Ailus
reviewerHi Hans,
Quoted 46 lines · Hans de Goede
Hi,
First of all I messed up the git format-patch command, there is no second patch in this series.
(at least not for the i2c subsystem. There is a similar GPIO patch but I send that out separately)
Quoted 15 lines · Sakari Ailus
Hi Hans,
Quoted 12 lines · Hans de Goede
Add "INTC10D2" ACPI device-id for MTL-CVF devices, like the Dell Latitude 7450.
Signed-off-by Hans de Goede <[email protected]>---
Note this applies on top of the addition of the new i2c-usbio driver which is being merged through gregkh/usb.git usb-next--- drivers/i2c/busses/i2c-usbio.c | 1 + 1 file changed, 1 insertion(+)Quoted 12 lines
drivers/i2c/busses/i2c-usbio.c static const struct acpi_device_id usbio_i2c_acpi_hids[] = { · line 30
Quoted 9 lines
drivers/i2c/busses/i2c-usbio.c +1
-0@@ -27,6 +27,7 @@ static const struct acpi_device_id usbio_i2c_acpi_hids[] = { { "INTC1008" }, /* MTL */ { "INTC10B3" }, /* ARL */ { "INTC10B6" }, /* LNL */ + { "INTC10D2" }, /* MTL-CVF */INTC10D2 is apparently already claimed by the LJCA I²C driver. Do you have an actual system that uses USBIO and this HID?
Yes, see the Closes: tag which points to a bug-report which such a system:
https://bugzilla.redhat.com/show_bug.cgi?id=2368506
Let me also reply to your other comment here:
Quoted 3 lines
Quoted 2 lines
INTC10D2 is apparently already claimed by the LJCA I²C driver. Do you have an actual system that uses USBIO and this HID?
Quoted 8 lines
Quoted 2 lines
Actually it looks like
i2c-ljca.cshouldn't list this HID. The same probably goes for all 10CF--10D3.I would not be so sure of this, there are at least some Dell systems which use a combination of ljca and Meteor Lake and I believe these do use the "INTC10D2" HID with LJCA for the I2C part and the same goes for the GPIO / SPI parts.. One example of such a system is the Dell Precision 5490.
LJCA on MTL is supposed to be 1008. Do you have the *SDT so we could verify this?
Quoted 3 lines
The way these Intel uses these HIDs is really weird they seem to simply mean "I2C" on *a* USBIO expander with this generation CPU.
I can assure you I have nothing to do with this ACPI ID usage scheme. :-)
Quoted 4 lines
Where there really seems no reason to change the HID for CPU generations, where as it would be a good reason to change the HID if the actual USBIO expander is different ...
That's indeed supposed to be the case. Also the _HID should always reflect the actual device and only _CID should indicate it's compatible with something else. But that BIOS is already out there so there's little that can be done to it anyway. :-\
Signature · 3 lines
Regards, Sakari Ailus
Hans de Goede
maintainerHi,
Quoted 52 lines · Sakari Ailus
Hi Hans,
Quoted 49 lines · Hans de Goede
Hi,
First of all I messed up the git format-patch command, there is no second patch in this series.
(at least not for the i2c subsystem. There is a similar GPIO patch but I send that out separately)
Quoted 15 lines · Sakari Ailus
Hi Hans,
Quoted 12 lines · Hans de Goede
Add "INTC10D2" ACPI device-id for MTL-CVF devices, like the Dell Latitude 7450.
Signed-off-by Hans de Goede <[email protected]>---
Note this applies on top of the addition of the new i2c-usbio driver which is being merged through gregkh/usb.git usb-next--- drivers/i2c/busses/i2c-usbio.c | 1 + 1 file changed, 1 insertion(+)Quoted 12 lines
drivers/i2c/busses/i2c-usbio.c static const struct acpi_device_id usbio_i2c_acpi_hids[] = { · line 30
Quoted 9 lines
drivers/i2c/busses/i2c-usbio.c +1
-0@@ -27,6 +27,7 @@ static const struct acpi_device_id usbio_i2c_acpi_hids[] = { { "INTC1008" }, /* MTL */ { "INTC10B3" }, /* ARL */ { "INTC10B6" }, /* LNL */ + { "INTC10D2" }, /* MTL-CVF */INTC10D2 is apparently already claimed by the LJCA I²C driver. Do you have an actual system that uses USBIO and this HID?
Yes, see the Closes: tag which points to a bug-report which such a system:
https://bugzilla.redhat.com/show_bug.cgi?id=2368506
Let me also reply to your other comment here:
Quoted 5 lines
Quoted 2 lines
INTC10D2 is apparently already claimed by the LJCA I²C driver. Do you have an actual system that uses USBIO and this HID?
Actually it looks like
i2c-ljca.cshouldn't list this HID. The same probably goes for all 10CF--10D3.
Quoted 8 lines
Quoted 5 lines
I would not be so sure of this, there are at least some Dell systems which use a combination of ljca and Meteor Lake and I believe these do use the "INTC10D2" HID with LJCA for the I2C part and the same goes for the GPIO / SPI parts.. One example of such a system is the Dell Precision 5490.
LJCA on MTL is supposed to be 1008. Do you have the *SDT so we could verify this?
I only had this laptop for a short while since it was using LJCA + IVSC it was not really an interesting device to hold on to. A Red Hat colleague of mine has the laptop now.
I'll inquiry about getting ssh access to it to collect acpidumps and also to directly get the used HIDs from sysfs (SSDTs now a days are often unreadable because of them dynamically assigning HIDs based on BIOS config variables).
Quoted 6 lines
Quoted 2 lines
The way these Intel uses these HIDs is really weird they seem to simply mean "I2C" on *a* USBIO expander with this generation CPU.
I can assure you I have nothing to do with this ACPI ID usage scheme. :-)
Quoted 1 line
Quoted 8 lines
Quoted 3 lines
Where there really seems no reason to change the HID for CPU generations, where as it would be a good reason to change the HID if the actual USBIO expander is different ...
That's indeed supposed to be the case. Also the
_HIDshould always reflect the actual device and only_CIDshould indicate it's compatible with something else. But that BIOS is already out there so there's little that can be done to it anyway. :-\
Ack.
Regards,
Hans
Hans de Goede
maintainerHi,
Quoted 4 lines · Sakari Ailus
Hi Hans,
Quoted 1 line · Hans de Goede
Hi,
...
Quoted 6 lines
Quoted 6 lines
Quoted 5 lines
Quoted 2 lines
INTC10D2 is apparently already claimed by the LJCA I²C driver. Do you have an actual system that uses USBIO and this HID?
Actually it looks like
i2c-ljca.cshouldn't list this HID. The same probably goes for all 10CF--10D3.
Quoted 8 lines
Quoted 5 lines
I would not be so sure of this, there are at least some Dell systems which use a combination of ljca and Meteor Lake and I believe these do use the "INTC10D2" HID with LJCA for the I2C part and the same goes for the GPIO / SPI parts.. One example of such a system is the Dell Precision 5490.
LJCA on MTL is supposed to be 1008. Do you have the *SDT so we could verify this?
I just checked this in a ssh session to the Dell Precision 5490:
hans@prdel:~$ cd /sys/bus/auxiliary/devices/ hans@prdel:/sys/bus/auxiliary/devices$ ls intel_ipu6.isys.40 intel_vsec.telemetry.2 soundwire_intel.link.2 usb_ljca.ljca-i2c.1 intel_ipu6.psys.40 snd_sof.hda-probes.0 soundwire_intel.link.3 usb_ljca.ljca-spi.0 intel_vsec.telemetry.0 soundwire_intel.link.0 usb_ljca.ljca-gpio.0 intel_vsec.telemetry.1 soundwire_intel.link.1 usb_ljca.ljca-i2c.0 hans@prdel:/sys/bus/auxiliary/devices$ cat usb_ljca.ljca-*/firmware_node/hid INTC10D1 INTC10D2 INTC10D2 INTC10D3
So as you can see this really is using the INTC10D* HIDs and these are thus duplicate between the LJCA and USBIO IO-expanders.
Note this does not really cause problems since we have the USB driver binding by USB VID:PID first and only then the code looks for the ACPI HIDs for the GPIO/I2C/SPI children so at this point we are already in LJCA resp. USBIO specific code-paths.
I've also asked for an acpidump, do you still want that once I receive it ?
Regards,
Hans
Cepeda Lopez, Israel A
maintainerHi Hans,
LJCA and USBIO shouldn't be sharing HIDs. What is the USB IO expander in that system (lsusb)?
Quoted 67 lines
-----Original Message-----
From: Hans de Goede <[email protected]>
Sent: Thursday, October 2, 2025 6:05 AM
To: Sakari Ailus <[email protected]>
Cc: Cepeda Lopez, Israel A <[email protected]>; Andi Shyti <[email protected]>; Wolfram Sang <[email protected]>; [email protected]
Subject: Re: [PATCH 1/2] i2c: usbio: Add ACPI device-id for MTL-CVF devicesHi,
Quoted 4 lines · Sakari Ailus
Hi Hans,
Quoted 1 line · Hans de Goede
Hi,
...
Quoted 6 lines
Quoted 6 lines
Quoted 5 lines
Quoted 2 lines
INTC10D2 is apparently already claimed by the LJCA I²C driver. Do you have an actual system that uses USBIO and this HID?
Actually it looks like
i2c-ljca.cshouldn't list this HID. The same probably goes for all 10CF--10D3.Quoted 8 lines
Quoted 5 lines
I would not be so sure of this, there are at least some Dell systems which use a combination of ljca and Meteor Lake and I believe these do use the "INTC10D2" HID with LJCA for the I2C part and the same goes for the GPIO / SPI parts.. One example of such a system is the Dell Precision 5490.
LJCA on MTL is supposed to be 1008. Do you have the *SDT so we could verify this?
I just checked this in a ssh session to the Dell Precision 5490:
hans@prdel:~$ cd /sys/bus/auxiliary/devices/ hans@prdel:/sys/bus/auxiliary/devices$ ls intel_ipu6.isys.40 intel_vsec.telemetry.2 soundwire_intel.link.2 usb_ljca.ljca- i2c.1 intel_ipu6.psys.40 snd_sof.hda-probes.0 soundwire_intel.link.3 usb_ljca.ljca- spi.0 intel_vsec.telemetry.0 soundwire_intel.link.0 usb_ljca.ljca-gpio.0 intel_vsec.telemetry.1 soundwire_intel.link.1 usb_ljca.ljca-i2c.0 hans@prdel:/sys/bus/auxiliary/devices$ cat usb_ljca.ljca-*/firmware_node/hid INTC10D1 INTC10D2 INTC10D2 INTC10D3So as you can see this really is using the INTC10D* HIDs and these are thus duplicate between the LJCA and USBIO IO-expanders.
Note this does not really cause problems since we have the USB driver binding by USB VID:PID first and only then the code looks for the ACPI HIDs for the GPIO/I2C/SPI children so at this point we are already in LJCA resp. USBIO specific code-paths.
I've also asked for an acpidump, do you still want that once I receive it ?
Regards,
Hans
Hans de Goede
maintainerHi Israel,
Quoted 3 lines · Israel A
Hi Hans,
LJCA and USBIO shouldn't be sharing HIDs.
Yes in practice we have shipping hardware that is sharing HIDs and since this is hardware out there in the field there is nothing we can do about this.
Quoted 1 line
What is the USB IO expander in that system (lsusb)?
Dell Precision 5490: 8086:0b63 usb-ljca device
with INTC10D1, INTC10D2 and INTC10D3 ACPI children
Dell Latitude 7450: 2ac1:20c9 usbio device
with INTC10D1 and INTC10D2 ACPI children
As I already mentioned earlier in this thread the shared HIDs are not really a problem because we have the USB driver binding by USB VID:PID first and only then the code looks for the ACPI HIDs for the GPIO/I2C/SPI children so at this point we are already in LJCA resp. USBIO specific code-paths.
Regards,
Hans
Cepeda Lopez, Israel A
maintainerThank you Hans,
Quoted 11 lines
-----Original Message-----
From: Hans de Goede <[email protected]>
Sent: Thursday, October 2, 2025 10:49 AM
To: Cepeda Lopez, Israel A <[email protected]>; Sakari Ailus <[email protected]>
Cc: Andi Shyti <[email protected]>; Wolfram Sang <wsa+renesas@sang- engineering.com>; [email protected]
Subject: Re: [PATCH 1/2] i2c: usbio: Add ACPI device-id for MTL-CVF devicesHi Israel,
Quoted 8 lines
Quoted 3 lines · Israel A
Hi Hans,
LJCA and USBIO shouldn't be sharing HIDs.
Yes in practice we have shipping hardware that is sharing HIDs and since this is hardware out there in the field there is nothing we can do about this.
There is. DELL has to provide a new FW/BIOS update to fix the HID of the system on fault. That is the correct solution to the issue.
Quoted 6 lines
Quoted 2 lines
What is the USB IO expander in that system (lsusb)?
Dell Precision 5490: 8086:0b63 usb-ljca device
with INTC10D1, INTC10D2 and INTC10D3 ACPI children
Quoted 8 lines
Dell Latitude 7450: 2ac1:20c9 usbio device
with INTC10D1 and INTC10D2 ACPI childrenAs I already mentioned earlier in this thread the shared HIDs are not really a problem because we have the USB driver binding by USB VID:PID first and only then the code looks for the ACPI HIDs for the GPIO/I2C/SPI children so at this point we are already in LJCA resp. USBIO specific code-paths.
Agree that there is no driver problem, but it will be better to have a proper solution and avoid further confusion.
Thank you for noticing and bringing this to our attention.
Quoted 6 lines
Regards,
Hans
Hans de Goede
maintainerHi Israel,
Quoted 16 lines · Israel A
Thank you Hans,
Quoted 14 lines
-----Original Message-----
From: Hans de Goede <[email protected]>
Sent: Thursday, October 2, 2025 10:49 AM
To: Cepeda Lopez, Israel A <[email protected]>; Sakari Ailus <[email protected]>
Cc: Andi Shyti <[email protected]>; Wolfram Sang <wsa+renesas@sang- engineering.com>; [email protected]
Subject: Re: [PATCH 1/2] i2c: usbio: Add ACPI device-id for MTL-CVF devicesHi Israel,
Quoted 2 lines · Israel A
Hi Hans,
Quoted 8 lines
Quoted 5 lines
Quoted 1 line
LJCA and USBIO shouldn't be sharing HIDs.
Yes in practice we have shipping hardware that is sharing HIDs and since this is hardware out there in the field there is nothing we can do about this.
There is. DELL has to provide a new FW/BIOS update to fix the HID of the system on fault. That is the correct solution to the issue.
Even if Dell is willing to do this (which I find unlikely) it will still likely take at least 6 months for a BIOS update to show up with these changes (BIOS QA takes a lot of time in my experience).
And even then we cannot count on users to actually install BIOS updates. So we will still need the INTC10D1, INTC10D2 and INTC10D3 HIDs in both the ljca and usbio drivers to support people who are still at the older BIOS.
And if I've understood Sakari correct then the INTC10D1, INTC10D2 HIDs are indeed intended for use with the USBIO driver and the problem is that ideally they should not also be used by the LJCA driver.
Since this patch adds the HIDs to the USBIO drivers, where they belong the whole discussion of them not supposed to be in the LJCA driver is sort of offtopic and this patch is correct regardless.
As such can you please give your Acked-by or Reviewed-by for this patch and for the matching GPIO patch:
https://lore.kernel.org/linux-gpio/[email protected]/
Regards,
Hans
Hi Hans,
Quoted 42 lines
-----Original Message-----
From: Hans de Goede <[email protected]>
Sent: Saturday, October 4, 2025 7:04 AM
To: Cepeda Lopez, Israel A <[email protected]>; Sakari Ailus <[email protected]>
Cc: Andi Shyti <[email protected]>; Wolfram Sang <wsa+renesas@sang- engineering.com>; [email protected]
Subject: Re: RE: [PATCH 1/2] i2c: usbio: Add ACPI device-id for MTL-CVF devicesHi Israel,
Quoted 16 lines · Israel A
Thank you Hans,
Quoted 14 lines
-----Original Message-----
From: Hans de Goede <[email protected]>
Sent: Thursday, October 2, 2025 10:49 AM
To: Cepeda Lopez, Israel A <[email protected]>; Sakari Ailus <[email protected]>
Cc: Andi Shyti <[email protected]>; Wolfram Sang <wsa+renesas@sang- engineering.com>; [email protected]
Subject: Re: [PATCH 1/2] i2c: usbio: Add ACPI device-id for MTL-CVF devicesHi Israel,
Quoted 2 lines · Israel A
Hi Hans,
Quoted 8 lines
Quoted 5 lines
Quoted 1 line
LJCA and USBIO shouldn't be sharing HIDs.
Yes in practice we have shipping hardware that is sharing HIDs and since this is hardware out there in the field there is nothing we can do about this.
There is. DELL has to provide a new FW/BIOS update to fix the HID of the system on fault. That is the correct solution to the issue.
Even if Dell is willing to do this (which I find unlikely) it will still likely take at least 6 months for a BIOS update to show up with these changes (BIOS QA takes a lot of time in my experience).
Quoted 4 lines
And even then we cannot count on users to actually install BIOS updates. So we will still need the INTC10D1, INTC10D2 and INTC10D3 HIDs in both the ljca and usbio drivers to support people who are still at the older BIOS.
Agree. Let's proceed with change. Thanks
Quoted 6 lines
And if I've understood Sakari correct then the INTC10D1, INTC10D2 HIDs are indeed intended for use with the USBIO driver and the problem is that ideally they should not also be used by the LJCA driver.
Quoted 6 lines
Since this patch adds the HIDs to the USBIO drivers, where they belong the whole discussion of them not supposed to be in the LJCA driver is sort of offtopic and this patch is correct regardless.
As such can you please give your Acked-by or Reviewed-by for this patch and for the matching GPIO patch:
Quoted 6 lines
https://lore.kernel.org/linux-gpio/[email protected]/
Regards,
Hans
Hi Hans,
Quoted 39 lines · Hans de Goede
Hi,
Quoted 4 lines · Sakari Ailus
Hi Hans,
Quoted 1 line · Hans de Goede
Hi,
...
Quoted 6 lines
Quoted 6 lines
Quoted 5 lines
Quoted 2 lines
INTC10D2 is apparently already claimed by the LJCA I²C driver. Do you have an actual system that uses USBIO and this HID?
Actually it looks like
i2c-ljca.cshouldn't list this HID. The same probably goes for all 10CF--10D3.Quoted 8 lines
Quoted 5 lines
I would not be so sure of this, there are at least some Dell systems which use a combination of ljca and Meteor Lake and I believe these do use the "INTC10D2" HID with LJCA for the I2C part and the same goes for the GPIO / SPI parts.. One example of such a system is the Dell Precision 5490.
LJCA on MTL is supposed to be 1008. Do you have the *SDT so we could verify this?
I just checked this in a ssh session to the Dell Precision 5490:
hans@prdel:~$ cd /sys/bus/auxiliary/devices/ hans@prdel:/sys/bus/auxiliary/devices$ ls intel_ipu6.isys.40 intel_vsec.telemetry.2 soundwire_intel.link.2 usb_ljca.ljca-i2c.1 intel_ipu6.psys.40 snd_sof.hda-probes.0 soundwire_intel.link.3 usb_ljca.ljca-spi.0 intel_vsec.telemetry.0 soundwire_intel.link.0 usb_ljca.ljca-gpio.0 intel_vsec.telemetry.1 soundwire_intel.link.1 usb_ljca.ljca-i2c.0 hans@prdel:/sys/bus/auxiliary/devices$ cat usb_ljca.ljca-*/firmware_node/hid INTC10D1 INTC10D2 INTC10D2 INTC10D3
Quoted 2 lines
So as you can see this really is using the INTC10D* HIDs and these are thus duplicate between the LJCA and USBIO IO-expanders.
Thanks for confirming this. Luckily this isn't an issue as matching doesn't use ACPI HIDs. That being said, I really wonder where this stuff comes from.
Signature · 3 lines
Kind regards, Sakari Ailus
Quoted 7 lines · Hans de Goede
Add "INTC10D2" ACPI device-id for MTL-CVF devices, like the Dell Latitude 7450.
Signed-off-by Hans de Goede <[email protected]>Acked-by Sakari Ailus <[email protected]>Acked-by Israel Cepeda <[email protected]>
With dependencies upstream now, applied to for-current, thanks!