Skip to contentSkip to conversation

runqemu: remove setting of mem on kernel command line for certain systems

PATCH Superseded Jon Mason 3 participants 4 messages Oct 3, 2025 – Oct 6, 2025

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Jon Mason

author
#0 lore raw

PATCH v2 1/2 runqemu: remove setting of mem on kernel command line for certain systems

Some emulated hardware will not boot if mem is set on the kernel command line. Also, it is not necessary if the device tree file, as that _should_ have the memory size specified in it. Add a check for QB_DTB and don't set it if specified.

---
 scripts/runqemu | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
scripts/runqemu +1 -1
index 32c7a2aab3b5..a8144aa68c3d 100755
@@ -884,7 +884,7 @@ to your build configuration.
         self.set('QB_MEM', qb_mem)
 
         mach = self.get('MACHINE')
-        if not mach.startswith(('qemumips', 'qemux86', 'qemuloongarch64')):
+        if not mach.startswith(('qemumips', 'qemux86', 'qemuloongarch64')) and self.get('QB_DTB') == "":
             self.kernel_cmdline_script += ' mem=%s' % self.get('QB_MEM').replace('-m','').strip() + 'M'
 
         self.qemu_opt_script += ' %s' % self.get('QB_MEM')
Signature · 1 line
2.50.1 (Apple Git-155)
author
#1 lore raw

PATCH v2 2/2 runqemu: resize rootfs image to power of 2 for SD or pflash

QEMU requires that SD and pflash images are sized to be a power of 2 (e.g., 32M, 64M, etc). So, if the image being used is not a power of 2 and it's being used for SD or pflash, increase it to the next power of 2 size via the truncate command.

This might not be an actual spec requirement, and is being investigated in https://gitlab.com/qemu-project/qemu/-/issues/1754

---
 scripts/runqemu | 25 ++++++++++++++++++++++---
 1 file changed, 22 insertions(+), 3 deletions(-)
scripts/runqemu +22 -3
index a8144aa68c3d..21d75ad8a319 100755
@@ -421,8 +421,27 @@ class BaseConfig(object):
         else:
             raise RunQemuError("Unknown path arg %s" % p)
 
-    def uncompress_rootfs(self):
-        """Decompress ZST rootfs image if needed"""
+    def rootfs_fixups(self):
+
+        """Decompress and/or resize the rootfs image, if needed"""
+        qb_rootfs_opt = self.get('QB_ROOTFS_OPT')
+
+        # Check if sdcard size is a power of 2, as that is currently a requirement for qemu
+        # See https://gitlab.com/qemu-project/qemu/-/issues/1754
+        rootfs_size = os.path.getsize(self.rootfs)
+        rootfs_size_pwr2 = 1 << (rootfs_size - 1).bit_length()
+        if ("if=sd" in qb_rootfs_opt or "if=pflash" in qb_rootfs_opt) and rootfs_size != rootfs_size_pwr2:
+            logger.info("Using sd-card or pflash and is not power of 2. File size %d, power of 2 size %d" %(rootfs_size, rootfs_size_pwr2))
+            logger.info("Attempting to use truncate to correct this.")
+
+            # Ensure the 'truncate' tool is installed before attempting to make a power of 2.
+            if not shutil.which('truncate'):
+                raise RunQemuError(f"'truncate' is required to make {self.rootfs} a power of 2 in size but was not found in PATH")
+            try:
+                subprocess.check_call(['truncate', '-s', str(rootfs_size_pwr2), self.rootfs])
+            except subprocess.CalledProcessError as e:
+                raise RunQemuError(f"Failed to make {self.rootfs} power of 2 in size: {e}")
+
         if not self.rootfs or not self.fstype.endswith('.zst'):
             return
         
@@ -1808,7 +1827,7 @@ def main():
         config.check_args()
         config.read_qemuboot()
         config.check_and_set()
-        config.uncompress_rootfs()
+        config.rootfs_fixups()
         # Check whether the combos is valid or not
         config.validate_combos()
         config.print_config()
Signature · 1 line
2.50.1 (Apple Git-155)
#2 lore raw
In reply to Jon Mason
Quoted 2 lines · Jon Mason via lists.openembedded.org

Some emulated hardware will not boot if mem is set on the kernel command

Please replace 'some' and 'certain' with actual examples, or rewrite the commit message to remove these vague-on-purpose words altogether.

Alex

#3 lore raw
Quoted 8 lines · Alexander Kanavin via lists.openembedded.org
Quoted 2 lines · Jon Mason via lists.openembedded.org

Some emulated hardware will not boot if mem is set on the kernel command

Please replace 'some' and 'certain' with actual examples, or rewrite the commit message to remove these vague-on-purpose words altogether.

Well, this is embarrassing. Ross made that same comment and I sent that change out (see Message-ID:
<[email protected]>,
https://lists.openembedded.org/g/openembedded-core/message/224316),
but I lost that change somehow when making the v2 change. Let me pull that one off the lists and do a v3 (with this change and the comment change of v2).

Sorry and thanks,
Jon

Quoted 10 lines

Alex

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#224468): https://lists.openembedded.org/g/openembedded-core/message/224468
Mute This Topic: https://lists.openembedded.org/mt/115571450/3616920
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-