Skip to contentSkip to conversation

bcache: add "clock" cache replacement policy

PATCH Superseded Robert Pang 2 participants 3 messages Oct 6, 2025 – Oct 8, 2025 bcache (block layer cache)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 bcache: add "clock" cache replacement policy

This new policy extends the FIFO policy to approximate the classic clock policy (O(n) time complexity) by considering bucket priority, similar to the LRU policy.

This policy addresses the high IO latency (1-2 seconds) experienced on multi-terabyte cache devices when the free list is empty. The default LRU policy's O(n log n) complexity for sorting priorities for the entire bucket list causes this delay.

---
 drivers/md/bcache/alloc.c         | 34 +++++++++++++++++++++++++++----
 drivers/md/bcache/bcache_ondisk.h |  1 +
 drivers/md/bcache/sysfs.c         |  1 +
 3 files changed, 32 insertions(+), 4 deletions(-)
drivers/md/bcache/alloc.c +30 -4
index 48ce750bf70a..c65c48eab169 100644
@@ -69,7 +69,8 @@
 #include <linux/random.h>
 #include <trace/events/bcache.h>
 
-#define MAX_OPEN_BUCKETS 128
+#define MAX_OPEN_BUCKETS	128
+#define CHECK_PRIO_SLICES	16
 
 /* Bucket heap / gen */
 
@@ -211,19 +212,41 @@ static void invalidate_buckets_lru(struct cache *ca)
 	}
 }
 
-static void invalidate_buckets_fifo(struct cache *ca)
+/*
+ * When check_prio is true, this FIFO policy examines the priority of the
+ * buckets and invalidates only the ones below a threshold in the priority
+ * ladder. As it goes, the threshold will be raised if not enough buckets are
+ * invalidated. Empty buckets are also invalidated. This evaulation resembles
+ * the LRU policy, and is used to approximate the classic clock-sweep cache
+ * replacement algorithm.
+ */
+static void invalidate_buckets_fifo(struct cache *ca, bool check_prio)
 {
 	struct bucket *b;
 	size_t checked = 0;
+	size_t check_quota = 0;
+	uint16_t prio_threshold = ca->set->min_prio;
 
 	while (!fifo_full(&ca->free_inc)) {
 		if (ca->fifo_last_bucket <  ca->sb.first_bucket ||
 		    ca->fifo_last_bucket >= ca->sb.nbuckets)
 			ca->fifo_last_bucket = ca->sb.first_bucket;
 
+		if (check_prio && checked >= check_quota) {
+			BUG_ON(ca->set->min_prio > INITIAL_PRIO);
+			prio_threshold +=
+				DIV_ROUND_UP(INITIAL_PRIO - ca->set->min_prio,
+					     CHECK_PRIO_SLICES);
+			check_quota += DIV_ROUND_UP(ca->sb.nbuckets,
+						    CHECK_PRIO_SLICES);
+		}
+
 		b = ca->buckets + ca->fifo_last_bucket++;
 
-		if (bch_can_invalidate_bucket(ca, b))
+		if (bch_can_invalidate_bucket(ca, b) &&
+		    (!check_prio ||
+		     b->prio <= prio_threshold ||
+		     !GC_SECTORS_USED(b)))
 			bch_invalidate_one_bucket(ca, b);
 
 		if (++checked >= ca->sb.nbuckets) {
@@ -269,11 +292,14 @@ static void invalidate_buckets(struct cache *ca)
 		invalidate_buckets_lru(ca);
 		break;
 	case CACHE_REPLACEMENT_FIFO:
-		invalidate_buckets_fifo(ca);
+		invalidate_buckets_fifo(ca, false);
 		break;
 	case CACHE_REPLACEMENT_RANDOM:
 		invalidate_buckets_random(ca);
 		break;
+	case CACHE_REPLACEMENT_CLOCK:
+		invalidate_buckets_fifo(ca, true);
+		break;
 	}
 }
 
drivers/md/bcache/bcache_ondisk.h +1 -0
index 6620a7f8fffc..d45794e01fe1 100644
@@ -288,6 +288,7 @@ BITMASK(CACHE_REPLACEMENT,		struct cache_sb, flags, 2, 3);
 #define CACHE_REPLACEMENT_LRU		0U
 #define CACHE_REPLACEMENT_FIFO		1U
 #define CACHE_REPLACEMENT_RANDOM	2U
+#define CACHE_REPLACEMENT_CLOCK		3U
 
 BITMASK(BDEV_CACHE_MODE,		struct cache_sb, flags, 0, 4);
 #define CACHE_MODE_WRITETHROUGH		0U
drivers/md/bcache/sysfs.c +1 -0
index 826b14cae4e5..c8617bad0648 100644
@@ -45,6 +45,7 @@ static const char * const cache_replacement_policies[] = {
 	"lru",
 	"fifo",
 	"random",
+	"clock",
 	NULL
 };
 
Signature · 1 line
2.51.0.710.ga91ca5db03-goog
#1 lore raw
Quoted 4 lines · Robert Pang

This new policy extends the FIFO policy to approximate the classic clock policy (O(n) time complexity) by considering bucket priority, similar to the LRU policy.

Current bcache GC is single thread, clock is good here. BTW, could you please also add the clock entry into bcache kernel document,
- Documentation/admin-guide/bcache.rst
- Documentation/ABI/testing/sysfs-block-bcache

Quoted 1 line

This policy addresses the high IO latency (1-2 seconds) experienced on

^^^^^^^^^^^-> I assume this policy means LRU, am I correct?

Quoted 4 lines

multi-terabyte cache devices when the free list is empty. The default LRU policy's O(n log n) complexity for sorting priorities for the entire bucket list causes this delay.

Can you provide performance numbers about lock replacement algorithm and add them into the commit log?

Yes, for performance optimization, we always need to see the difference made by this improvement.

Thanks.

Coly Li

Quoted 107 lines
---
 drivers/md/bcache/alloc.c         | 34 +++++++++++++++++++++++++++----
 drivers/md/bcache/bcache_ondisk.h |  1 +
 drivers/md/bcache/sysfs.c         |  1 +
 3 files changed, 32 insertions(+), 4 deletions(-)
drivers/md/bcache/alloc.c +30 -4
index 48ce750bf70a..c65c48eab169 100644
@@ -69,7 +69,8 @@
 #include <linux/random.h>
 #include <trace/events/bcache.h>
 
-#define MAX_OPEN_BUCKETS 128
+#define MAX_OPEN_BUCKETS	128
+#define CHECK_PRIO_SLICES	16
 
 /* Bucket heap / gen */
 
@@ -211,19 +212,41 @@ static void invalidate_buckets_lru(struct cache *ca)
 	}
 }
 
-static void invalidate_buckets_fifo(struct cache *ca)
+/*
+ * When check_prio is true, this FIFO policy examines the priority of the
+ * buckets and invalidates only the ones below a threshold in the priority
+ * ladder. As it goes, the threshold will be raised if not enough buckets are
+ * invalidated. Empty buckets are also invalidated. This evaulation resembles
+ * the LRU policy, and is used to approximate the classic clock-sweep cache
+ * replacement algorithm.
+ */
+static void invalidate_buckets_fifo(struct cache *ca, bool check_prio)
 {
 	struct bucket *b;
 	size_t checked = 0;
+	size_t check_quota = 0;
+	uint16_t prio_threshold = ca->set->min_prio;
 
 	while (!fifo_full(&ca->free_inc)) {
 		if (ca->fifo_last_bucket <  ca->sb.first_bucket ||
 		    ca->fifo_last_bucket >= ca->sb.nbuckets)
 			ca->fifo_last_bucket = ca->sb.first_bucket;
 
+		if (check_prio && checked >= check_quota) {
+			BUG_ON(ca->set->min_prio > INITIAL_PRIO);
+			prio_threshold +=
+				DIV_ROUND_UP(INITIAL_PRIO - ca->set->min_prio,
+					     CHECK_PRIO_SLICES);
+			check_quota += DIV_ROUND_UP(ca->sb.nbuckets,
+						    CHECK_PRIO_SLICES);
+		}
+
 		b = ca->buckets + ca->fifo_last_bucket++;
 
-		if (bch_can_invalidate_bucket(ca, b))
+		if (bch_can_invalidate_bucket(ca, b) &&
+		    (!check_prio ||
+		     b->prio <= prio_threshold ||
+		     !GC_SECTORS_USED(b)))
 			bch_invalidate_one_bucket(ca, b);
 
 		if (++checked >= ca->sb.nbuckets) {
@@ -269,11 +292,14 @@ static void invalidate_buckets(struct cache *ca)
 		invalidate_buckets_lru(ca);
 		break;
 	case CACHE_REPLACEMENT_FIFO:
-		invalidate_buckets_fifo(ca);
+		invalidate_buckets_fifo(ca, false);
 		break;
 	case CACHE_REPLACEMENT_RANDOM:
 		invalidate_buckets_random(ca);
 		break;
+	case CACHE_REPLACEMENT_CLOCK:
+		invalidate_buckets_fifo(ca, true);
+		break;
 	}
 }
 
drivers/md/bcache/bcache_ondisk.h +1 -0
index 6620a7f8fffc..d45794e01fe1 100644
@@ -288,6 +288,7 @@ BITMASK(CACHE_REPLACEMENT,		struct cache_sb, flags, 2, 3);
 #define CACHE_REPLACEMENT_LRU		0U
 #define CACHE_REPLACEMENT_FIFO		1U
 #define CACHE_REPLACEMENT_RANDOM	2U
+#define CACHE_REPLACEMENT_CLOCK		3U
 
 BITMASK(BDEV_CACHE_MODE,		struct cache_sb, flags, 0, 4);
 #define CACHE_MODE_WRITETHROUGH		0U
drivers/md/bcache/sysfs.c +1 -0
index 826b14cae4e5..c8617bad0648 100644
@@ -45,6 +45,7 @@ static const char * const cache_replacement_policies[] = {
 	"lru",
 	"fifo",
 	"random",
+	"clock",
 	NULL
 };
 
Signature · 1 line
2.51.0.710.ga91ca5db03-goog
#2 lore raw

Hi Coly

Thank you for your quick look at this patch.

Quoted 11 lines · Coly Li
Quoted 4 lines · Robert Pang

This new policy extends the FIFO policy to approximate the classic clock policy (O(n) time complexity) by considering bucket priority, similar to the LRU policy.

Current bcache GC is single thread, clock is good here. BTW, could you please also add the clock entry into bcache kernel document,
- Documentation/admin-guide/bcache.rst
- Documentation/ABI/testing/sysfs-block-bcache

There is no reference to cache_replacement_policy in sysfs-block-bcache currently. Will add the clock entry in bcache.rst.

Quoted 2 lines
Quoted 1 line

This policy addresses the high IO latency (1-2 seconds) experienced on

^^^^^^^^^^^-> I assume this policy means LRU, am I correct?

That's correct.

Quoted 10 lines
Quoted 4 lines

multi-terabyte cache devices when the free list is empty. The default LRU policy's O(n log n) complexity for sorting priorities for the entire bucket list causes this delay.

Can you provide performance numbers about lock replacement algorithm and add them into the commit log?

Yes, for performance optimization, we always need to see the difference made by this improvement.

Will do it quickly.

Best regards
Robert Pang

Quoted 113 lines

Thanks.

Coly Li

Quoted 107 lines
---
 drivers/md/bcache/alloc.c         | 34 +++++++++++++++++++++++++++----
 drivers/md/bcache/bcache_ondisk.h |  1 +
 drivers/md/bcache/sysfs.c         |  1 +
 3 files changed, 32 insertions(+), 4 deletions(-)
drivers/md/bcache/alloc.c +30 -4
index 48ce750bf70a..c65c48eab169 100644
@@ -69,7 +69,8 @@
 #include <linux/random.h>
 #include <trace/events/bcache.h>
 
-#define MAX_OPEN_BUCKETS 128
+#define MAX_OPEN_BUCKETS     128
+#define CHECK_PRIO_SLICES    16
 
 /* Bucket heap / gen */
 
@@ -211,19 +212,41 @@ static void invalidate_buckets_lru(struct cache *ca)
      }
 }
 
-static void invalidate_buckets_fifo(struct cache *ca)
+/*
+ * When check_prio is true, this FIFO policy examines the priority of the
+ * buckets and invalidates only the ones below a threshold in the priority
+ * ladder. As it goes, the threshold will be raised if not enough buckets are
+ * invalidated. Empty buckets are also invalidated. This evaulation resembles
+ * the LRU policy, and is used to approximate the classic clock-sweep cache
+ * replacement algorithm.
+ */
+static void invalidate_buckets_fifo(struct cache *ca, bool check_prio)
 {
      struct bucket *b;
      size_t checked = 0;
+     size_t check_quota = 0;
+     uint16_t prio_threshold = ca->set->min_prio;
 
      while (!fifo_full(&ca->free_inc)) {
              if (ca->fifo_last_bucket <  ca->sb.first_bucket ||
                  ca->fifo_last_bucket >= ca->sb.nbuckets)
                      ca->fifo_last_bucket = ca->sb.first_bucket;
 
+             if (check_prio && checked >= check_quota) {
+                     BUG_ON(ca->set->min_prio > INITIAL_PRIO);
+                     prio_threshold +=
+                             DIV_ROUND_UP(INITIAL_PRIO - ca->set->min_prio,
+                                          CHECK_PRIO_SLICES);
+                     check_quota += DIV_ROUND_UP(ca->sb.nbuckets,
+                                                 CHECK_PRIO_SLICES);
+             }
+
              b = ca->buckets + ca->fifo_last_bucket++;
 
-             if (bch_can_invalidate_bucket(ca, b))
+             if (bch_can_invalidate_bucket(ca, b) &&
+                 (!check_prio ||
+                  b->prio <= prio_threshold ||
+                  !GC_SECTORS_USED(b)))
                      bch_invalidate_one_bucket(ca, b);
 
              if (++checked >= ca->sb.nbuckets) {
@@ -269,11 +292,14 @@ static void invalidate_buckets(struct cache *ca)
              invalidate_buckets_lru(ca);
              break;
      case CACHE_REPLACEMENT_FIFO:
-             invalidate_buckets_fifo(ca);
+             invalidate_buckets_fifo(ca, false);
              break;
      case CACHE_REPLACEMENT_RANDOM:
              invalidate_buckets_random(ca);
              break;
+     case CACHE_REPLACEMENT_CLOCK:
+             invalidate_buckets_fifo(ca, true);
+             break;
      }
 }
 
drivers/md/bcache/bcache_ondisk.h +1 -0
index 6620a7f8fffc..d45794e01fe1 100644
@@ -288,6 +288,7 @@ BITMASK(CACHE_REPLACEMENT,                struct cache_sb, flags, 2, 3);
 #define CACHE_REPLACEMENT_LRU                0U
 #define CACHE_REPLACEMENT_FIFO               1U
 #define CACHE_REPLACEMENT_RANDOM     2U
+#define CACHE_REPLACEMENT_CLOCK              3U
 
 BITMASK(BDEV_CACHE_MODE,             struct cache_sb, flags, 0, 4);
 #define CACHE_MODE_WRITETHROUGH              0U
drivers/md/bcache/sysfs.c +1 -1
index 826b14cae4e5..c8617bad0648 100644
@@ -45,6 +45,7 @@ static const char * const cache_replacement_policies[] = {
      "lru",
      "fifo",
      "random",
+     "clock",
      NULL
 };
 
--

2.51.0.710.ga91ca5db03-goog