tests: gpiosim: revert minimum kernel version back to v5.17.4
PATCH 1/1 tests: gpiosim: revert minimum kernel version back to v5.17.4
From: Bartosz Golaszewski <[email protected]>
Commit b4009e2e6715 ("tests: gpiosim: provide gpiosim_bank_set_line_valid()") added support for marking simulated GPIO lines as valid/invalid using a new attribute of the kernel configfs interface of the gpio-sim module. In the process it bumped the minimum kernel version required to use it to v6.17 where this feature first appeared. The test cases we added later only appear in gpiod-test which is the test suite for the core C library. However with the kernel version change in libgpiosim other test suites have also seen their minimum kernel versions implicitly increase.
Since the libgpiosim library will simply return an error in the event that the attribute in question doesn't exist when the new function is called, we can revert the required kernel version to what it was before and allow just the individual test suites to bump their respective minimums separately.
--- tests/gpiosim/gpiosim.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tests/gpiosim/gpiosim.c +1 -1
@@ -24,7 +24,7 @@#define GPIOSIM_API __attribute__((visibility("default")))#define UNUSED __attribute__((unused)) -#define MIN_KERNEL_VERSION KERNEL_VERSION(6, 17, 0) +#define MIN_KERNEL_VERSION KERNEL_VERSION(5, 17, 4)static pthread_mutex_t id_lock =PTHREAD_MUTEX_INITIALIZER ;static pthread_once_t id_init_once =PTHREAD_ONCE_INIT ;
Signature · 1 line
2.48.1
Quoted 19 lines · Bartosz Golaszewski
From: Bartosz Golaszewski <[email protected]>
Commit
b4009e2e6715("tests: gpiosim: providegpiosim_bank_set_line_valid()") added support for marking simulated GPIO lines as valid/invalid using a new attribute of the kernel configfs interface of the gpio-sim module. In the process it bumped the minimum kernel version required to use it to v6.17 where this feature first appeared. The test cases we added later only appear in gpiod-test which is the test suite for the core C library. However with the kernel version change in libgpiosim other test suites have also seen their minimum kernel versions implicitly increase.Since the libgpiosim library will simply return an error in the event that the attribute in question doesn't exist when the new function is called, we can revert the required kernel version to what it was before and allow just the individual test suites to bump their respective minimums separately.
Quoted 3 lines
Reported-by Vincent Fazio <[email protected]>Signed-off-by Bartosz Golaszewski <[email protected]>---
Ah, I forgot the tag but this is for libgpiod.
Bart
Quoted 13 lines · Bartosz Golaszewski
From: Bartosz Golaszewski <[email protected]>
Commit
b4009e2e6715("tests: gpiosim: providegpiosim_bank_set_line_valid()") added support for marking simulated GPIO lines as valid/invalid using a new attribute of the kernel configfs interface of the gpio-sim module. In the process it bumped the minimum kernel version required to use it to v6.17 where this feature first appeared. The test cases we added later only appear in gpiod-test which is the test suite for the core C library. However with the kernel version change in libgpiosim other test suites have also seen their minimum kernel versions implicitly increase.
Quoted 7 lines
Since the libgpiosim library will simply return an error in the event that the attribute in question doesn't exist when the new function is called, we can revert the required kernel version to what it was before and allow just the individual test suites to bump their respective minimums separately.
Reported-by Vincent Fazio <[email protected]>
Bartosz Golaszewski
AppliedFrom: Bartosz Golaszewski <[email protected]>
Quoted 11 lines · Bartosz Golaszewski
Commit
b4009e2e6715("tests: gpiosim: providegpiosim_bank_set_line_valid()") added support for marking simulated GPIO lines as valid/invalid using a new attribute of the kernel configfs interface of the gpio-sim module. In the process it bumped the minimum kernel version required to use it to v6.17 where this feature first appeared. The test cases we added later only appear in gpiod-test which is the test suite for the core C library. However with the kernel version change in libgpiosim other test suites have also seen their minimum kernel versions implicitly increase.[...]
Applied, thanks!
[1/1] tests: gpiosim: revert minimum kernel version back to v5.17.4
https://git.kernel.org/brgl/libgpiod/c/7a768dc5b7cd943e22713c2cb9af283a5bd023f6
Best regards,
Signature · 1 line
Bartosz Golaszewski <[email protected]>