xfs: do not tightly pack-write large files
PATCH v3 1/1 xfs: do not tightly pack-write large files
When using a zoned realtime device, tightly packing of data blocks belonging to multiple closed files into the same realtime group (RTG) is very efficient at improving write performance. This is especially true with SMR HDDs as this can reduce, and even suppress, disk head seeks.
However, such tight packing does not make sense for large files that require at least a full RTG. If tight packing placement is applied for such files, the VM writeback thread switching between inodes result in the large files to be fragmented, thus increasing the garbage collection penalty later when the RTG needs to be reclaimed.
This problem can be avoided with a simple heuristic: if the size of the inode being written back is at least equal to the RTG size, do not use tight-packing. Modify xfs_zoned_pack_tight() to always return false in this case.
With this change, a multi-writer workload writing files of 256 MB on a file system backed by an SMR HDD with 256 MB zone size as a realtime device sees all files occupying exactly one RTG (i.e. one device zone), thus completely removing the heavy fragmentation observed without this change.
---
Changes from v1:
- Improved commit message
- Improved code comments
Changes from v2:
- Fixed typos in the commit message
fs/xfs/xfs_zone_alloc.c | 19 +++++++++++++++---- 1 file changed, 15 insertions(+), 4 deletions(-)
fs/xfs/xfs_zone_alloc.c +15 -4
@@ -614,14 +614,25 @@ static inline enum rw_hint xfs_inode_write_hint(struct xfs_inode *ip) }/* -* Try to pack inodes that are written back after they were closed tight instead -* of trying to open new zones for them or spread them to the least recently -* used zone. This optimizes the data layout for workloads that untar or copy -* a lot of small files. Right now this does not separate multiple such +* Try to tightly pack small files that are written back after they were closed +* instead of trying to open new zones for them or spread them to the least +* recently used zone. This optimizes the data layout for workloads that untar +* or copy a lot of small files. Right now this does not separate multiple such * streams. */ static inline bool xfs_zoned_pack_tight (struct xfs_inode *ip) { +struct xfs_mount *mp = ip->i_mount; +size_t zone_capacity = +XFS_FSB_TO_B (mp, mp->m_groups[XG_TYPE_RTG ].blocks); + +/* +* Do not pack write files that are already using a full group (zone) +* to avoid fragmentation. +*/ +if (i_size_read (VFS_I (ip)) >= zone_capacity) +return false; +return !inode_is_open_for_write (VFS_I (ip)) && !(ip->i_diflags &XFS_DIFLAG_APPEND ); }
Signature · 1 line
2.51.0
fs/xfs/xfs_zone_alloc.c static inline enum rw_hint xfs_inode_write_hint(struct xfs_inode *ip) · line 632
Quoted 4 lines · Damien Le Moal
fs/xfs/xfs_zone_alloc.c +4
-0+/* +* Do not pack write files that are already using a full group (zone) +* to avoid fragmentation. +*/
Same nitpick as first time, please either say realtime group / RTG or zone, but this doubling up just adds confusion.
Given that the rest of this file talks about zones, zone might be the best choice, but I don't have a strict preference.