arm64: dts: qcom: x1e80100: Add '#cooling-cells' for CPU nodes
PATCH 1/1 arm64: dts: qcom: x1e80100: Add '#cooling-cells' for CPU nodes
From: Manivannan Sadhasivam <[email protected]>
Enable passive cooling for CPUs in the X1E80100 SoC by adding the '#cooling-cells' property. This will allow the OS to mitigate the CPU power dissipation with the help of SCMI DVFS.
--- arch/arm64/boot/dts/qcom/x1e80100.dtsi | 12 ++++++++++++ 1 file changed, 12 insertions(+)
arch/arm64/boot/dts/qcom/x1e80100.dtsi +12 -0
@@ -76,6 +76,7 @@ cpu0: cpu@0 { power-domains = <&cpu_pd0>, <&scmi_dvfs 0>; power-domain-names = "psci", "perf"; cpu-idle-states = <&cluster_c4>; + #cooling-cells = <2>; l2_0: l2-cache { compatible = "cache";
@@ -93,6 +94,7 @@ cpu1: cpu@100 { power-domains = <&cpu_pd1>, <&scmi_dvfs 0>; power-domain-names = "psci", "perf"; cpu-idle-states = <&cluster_c4>; + #cooling-cells = <2>; }; cpu2: cpu@200 {
@@ -104,6 +106,7 @@ cpu2: cpu@200 { power-domains = <&cpu_pd2>, <&scmi_dvfs 0>; power-domain-names = "psci", "perf"; cpu-idle-states = <&cluster_c4>; + #cooling-cells = <2>; }; cpu3: cpu@300 {
@@ -115,6 +118,7 @@ cpu3: cpu@300 { power-domains = <&cpu_pd3>, <&scmi_dvfs 0>; power-domain-names = "psci", "perf"; cpu-idle-states = <&cluster_c4>; + #cooling-cells = <2>; }; cpu4: cpu@10000 {
@@ -126,6 +130,7 @@ cpu4: cpu@10000 { power-domains = <&cpu_pd4>, <&scmi_dvfs 1>; power-domain-names = "psci", "perf"; cpu-idle-states = <&cluster_c4>; + #cooling-cells = <2>; l2_1: l2-cache { compatible = "cache";
@@ -143,6 +148,7 @@ cpu5: cpu@10100 { power-domains = <&cpu_pd5>, <&scmi_dvfs 1>; power-domain-names = "psci", "perf"; cpu-idle-states = <&cluster_c4>; + #cooling-cells = <2>; }; cpu6: cpu@10200 {
@@ -154,6 +160,7 @@ cpu6: cpu@10200 { power-domains = <&cpu_pd6>, <&scmi_dvfs 1>; power-domain-names = "psci", "perf"; cpu-idle-states = <&cluster_c4>; + #cooling-cells = <2>; }; cpu7: cpu@10300 {
@@ -165,6 +172,7 @@ cpu7: cpu@10300 { power-domains = <&cpu_pd7>, <&scmi_dvfs 1>; power-domain-names = "psci", "perf"; cpu-idle-states = <&cluster_c4>; + #cooling-cells = <2>; }; cpu8: cpu@20000 {
@@ -176,6 +184,7 @@ cpu8: cpu@20000 { power-domains = <&cpu_pd8>, <&scmi_dvfs 2>; power-domain-names = "psci", "perf"; cpu-idle-states = <&cluster_c4>; + #cooling-cells = <2>; l2_2: l2-cache { compatible = "cache";
@@ -193,6 +202,7 @@ cpu9: cpu@20100 { power-domains = <&cpu_pd9>, <&scmi_dvfs 2>; power-domain-names = "psci", "perf"; cpu-idle-states = <&cluster_c4>; + #cooling-cells = <2>; }; cpu10: cpu@20200 {
@@ -204,6 +214,7 @@ cpu10: cpu@20200 { power-domains = <&cpu_pd10>, <&scmi_dvfs 2>; power-domain-names = "psci", "perf"; cpu-idle-states = <&cluster_c4>; + #cooling-cells = <2>; }; cpu11: cpu@20300 {
@@ -215,6 +226,7 @@ cpu11: cpu@20300 { power-domains = <&cpu_pd11>, <&scmi_dvfs 2>; power-domain-names = "psci", "perf"; cpu-idle-states = <&cluster_c4>; + #cooling-cells = <2>; }; cpu-map {
Signature · 1 line
2.48.1
Quoted 5 lines · Manivannan Sadhasivam
From: Manivannan Sadhasivam <[email protected]>
Enable passive cooling for CPUs in the X1E80100 SoC by adding the '#cooling-cells' property. This will allow the OS to mitigate the CPU power dissipation with the help of SCMI DVFS.
#cooling-cells isn't enough, the devices need to be listed in the thermal maps.
Quoted 7 lines
Signed-off-by Manivannan Sadhasivam <[email protected]>Signed-off-by Manivannan Sadhasivam <[email protected]>--- arch/arm64/boot/dts/qcom/x1e80100.dtsi | 12 ++++++++++++ 1 file changed, 12 insertions(+)
Signature · 2 lines
With best wishes Dmitry
Quoted 10 lines · Dmitry Baryshkov
Quoted 5 lines · Manivannan Sadhasivam
From: Manivannan Sadhasivam <[email protected]>
Enable passive cooling for CPUs in the X1E80100 SoC by adding the '#cooling-cells' property. This will allow the OS to mitigate the CPU power dissipation with the help of SCMI DVFS.
#cooling-cells isn't enough, the devices need to be listed in the thermal maps.
Not strictly required unless the cooling device and trip points are wired in DT. But I don't want to do that yet, and just expose the cooling devices to userspace so that I can experiment with something like thermal-daemon.
- Mani
Signature · 1 line
மணிவண்ணன் சதாசிவம்
Quoted 8 lines · Manivannan Sadhasivam
Quoted 7 lines · Dmitry Baryshkov
Quoted 5 lines · Manivannan Sadhasivam
From: Manivannan Sadhasivam <[email protected]>
Enable passive cooling for CPUs in the X1E80100 SoC by adding the '#cooling-cells' property. This will allow the OS to mitigate the CPU power dissipation with the help of SCMI DVFS.
Quoted 7 lines
Quoted 3 lines
#cooling-cells isn't enough, the devices need to be listed in the thermal maps.
Not strictly required unless the cooling device and trip points are wired in DT. But I don't want to do that yet, and just expose the cooling devices to userspace so that I can experiment with something like thermal-daemon.
Rob, Krzysztof,
Would it be an overly ambitious idea to make #cooling-cells required for CPU nodes? I'd imagine some sort of cpuidle or cpufreq is desired on almost all platforms, which could be used as a cooling/throttling measure..
Konrad
Quoted 17 lines · Konrad Dybcio
Quoted 8 lines · Manivannan Sadhasivam
Quoted 7 lines · Dmitry Baryshkov
Quoted 5 lines · Manivannan Sadhasivam
From: Manivannan Sadhasivam <[email protected]>
Enable passive cooling for CPUs in the X1E80100 SoC by adding the '#cooling-cells' property. This will allow the OS to mitigate the CPU power dissipation with the help of SCMI DVFS.
Quoted 7 lines
Quoted 3 lines
#cooling-cells isn't enough, the devices need to be listed in the thermal maps.
Not strictly required unless the cooling device and trip points are wired in DT. But I don't want to do that yet, and just expose the cooling devices to userspace so that I can experiment with something like thermal-daemon.
Quoted 5 lines
Rob, Krzysztof,
Would it be an overly ambitious idea to make #cooling-cells required for CPU nodes? I'd imagine some sort of cpuidle or cpufreq is desired on almost all platforms, which could be used as a cooling/throttling measure..
Looking at my museum, i.MX devices don't have #cooling-cells before i.MX6.
Signature · 2 lines
With best wishes Dmitry
Quoted 18 lines · Dmitry Baryshkov
Quoted 17 lines · Konrad Dybcio
Quoted 15 lines · Manivannan Sadhasivam
Quoted 10 lines · Dmitry Baryshkov
Quoted 5 lines · Manivannan Sadhasivam
From: Manivannan Sadhasivam <[email protected]>
Enable passive cooling for CPUs in the X1E80100 SoC by adding the '#cooling-cells' property. This will allow the OS to mitigate the CPU power dissipation with the help of SCMI DVFS.
#cooling-cells isn't enough, the devices need to be listed in the thermal maps.
Not strictly required unless the cooling device and trip points are wired in DT. But I don't want to do that yet, and just expose the cooling devices to userspace so that I can experiment with something like thermal-daemon.
Quoted 8 lines
Quoted 5 lines
Rob, Krzysztof,
Would it be an overly ambitious idea to make #cooling-cells required for CPU nodes? I'd imagine some sort of cpuidle or cpufreq is desired on almost all platforms, which could be used as a cooling/throttling measure..
Looking at my museum, i.MX devices don't have #cooling-cells before i.MX6.
Right, but they are still arm platforms so they have the wfi instruction, meaning *some* sort of idle injection could happen as a cooling measure
I was wondering if there's any ancient platforms (probably from the 90s?) that wouldn't even feature such things (and hence it wouldn't make sense to define CPUs as cooling devices).. such old platforms would probably be single-core, so turning off auxiliary ones as a last resort wouldn't work either
Konrad