Bluetooth: btintel_pcie: Fix event packet loss issue
PATCH v2 1/1 Bluetooth: btintel_pcie: Fix event packet loss issue
In the current btintel_pcie driver implementation, when an interrupt is received, the driver checks for the alive cause before the TX/RX cause. Handling the alive cause involves resetting the TX/RX queue indices. This flow works correctly when the causes are mutually exclusive. However, if both cause bits are set simultaneously, the alive cause resets the queue indices, resulting in an event packet drop and a command timeout. To fix this issue, the driver is modified to handle all other causes before checking for the alive cause.
Test case:
Issue is seen with stress reboot scenario - 50x run
[20.337589] Bluetooth: hci0: Device revision is 0 [20.346750] Bluetooth: hci0: Secure boot is enabled [20.346752] Bluetooth: hci0: OTP lock is disabled [20.346752] Bluetooth: hci0: API lock is enabled [20.346752] Bluetooth: hci0: Debug lock is disabled [20.346753] Bluetooth: hci0: Minimum firmware build 1 week 10 2014 [20.346754] Bluetooth: hci0: Bootloader timestamp 2023.43 buildtype 1 build 11631 [20.359070] Bluetooth: hci0: Found device firmware: intel/ibt-00a0-00a1-iml.sfi [20.371499] Bluetooth: hci0: Boot Address: 0xb02ff800 [20.385769] Bluetooth: hci0: Firmware Version: 166-34.25 [20.538257] Bluetooth: hci0: Waiting for firmware download to complete [20.554424] Bluetooth: hci0: Firmware loaded in 178651 usecs [21.081588] Bluetooth: hci0: Timeout (500 ms) on tx completion [21.096541] Bluetooth: hci0: Failed to send frame (-62) [21.110240] Bluetooth: hci0: sending frame failed (-62) [21.138551] Bluetooth: hci0: Failed to send Intel Reset command [21.170153] Bluetooth: hci0: Intel Soft Reset failed (-62)
---
changes in v2:
- Update commit message with test case details and dmesg.
drivers/bluetooth/btintel_pcie.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-)
drivers/bluetooth/btintel_pcie.c +6 -5
@@ -1467,11 +1467,6 @@ static irqreturn_t btintel_pcie_irq_msix_handler(int irq, void *dev_id)if (intr_hw &BTINTEL_PCIE_MSIX_HW_INT_CAUSES_GP1 )btintel_pcie_msix_gp1_handler (data); -/* This interrupt is triggered by the firmware after updating -* boot_stage register and image_response register -*/ -if (intr_hw &BTINTEL_PCIE_MSIX_HW_INT_CAUSES_GP0 ) -btintel_pcie_msix_gp0_handler (data);/* For TX */ if (intr_fh &BTINTEL_PCIE_MSIX_FH_INT_CAUSES_0 ) {
@@ -1487,6 +1482,12 @@ static irqreturn_t btintel_pcie_irq_msix_handler(int irq, void *dev_id)btintel_pcie_msix_tx_handle (data); } +/* This interrupt is triggered by the firmware after updating +* boot_stage register and image_response register +*/ +if (intr_hw &BTINTEL_PCIE_MSIX_HW_INT_CAUSES_GP0 ) +btintel_pcie_msix_gp0_handler (data); +/* * Before sending the interrupt the HW disables it to prevent a nested * interrupt. This is done by writing 1 to the corresponding bit in
Signature · 1 line
2.43.0
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=1012156
---Test result---
Test Summary:
CheckPatch PENDING 0.32 seconds GitLint PENDING 0.23 seconds SubjectPrefix PASS 0.13 seconds BuildKernel PASS 25.32 seconds CheckAllWarning PASS 28.24 seconds CheckSparse PASS 31.36 seconds BuildKernel32 PASS 25.55 seconds TestRunnerSetup PASS 506.24 seconds TestRunner_l2cap-tester PASS 24.56 seconds TestRunner_iso-tester PASS 80.19 seconds TestRunner_bnep-tester PASS 6.32 seconds TestRunner_mgmt-tester FAIL 117.96 seconds TestRunner_rfcomm-tester PASS 11.16 seconds TestRunner_sco-tester PASS 14.53 seconds TestRunner_ioctl-tester FAIL 10.42 seconds TestRunner_mesh-tester FAIL 12.34 seconds TestRunner_smp-tester PASS 8.58 seconds TestRunner_userchan-tester PASS 6.53 seconds IncrementalBuild PENDING 0.97 seconds
Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script Output:
##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:
##############################
Test: TestRunner_mgmt-tester - FAIL
Desc: Run mgmt-tester with test-runner Output:
Total: 490, Passed: 481 (98.2%), Failed: 5, Not Run: 4
Failed Test Cases
Pair Device - Legacy Success 1 Failed 0.199 seconds Pair Device - Sec Mode 3 Success 1 Failed 0.169 seconds Pair Device - Legacy Reject 2 Failed 0.151 seconds Read Exp Feature - Success Failed 0.110 seconds LL Privacy - Add Device 3 (AL is full) Failed 0.214 seconds
##############################
Test: TestRunner_ioctl-tester - FAIL
Desc: Run ioctl-tester with test-runner Output:
Total: 28, Passed: 26 (92.9%), Failed: 2, Not Run: 0
Failed Test Cases
Connection List Failed 1.068 seconds Connection Info Failed 0.150 seconds
##############################
Test: TestRunner_mesh-tester - FAIL
Desc: Run mesh-tester with test-runner Output:
Total: 10, Passed: 8 (80.0%), Failed: 2, Not Run: 0
Failed Test Cases
Mesh - Send cancel - 1 Timed out 2.692 seconds Mesh - Send cancel - 2 Timed out 1.996 seconds
##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series Output:
---
Regards,
Linux Bluetooth
This patch was applied to bluetooth/bluetooth-next.git (master) by Luiz Augusto von Dentz <[email protected]>:
Hello:
This patch was applied to bluetooth/bluetooth-next.git (master) by Luiz Augusto von Dentz <[email protected]>:
Quoted 10 lines · On Thu, 16 Oct 2025 10:00:43 +0530 you wrote:
In the current
btintel_pciedriver implementation, when an interrupt is received, the driver checks for the alive cause before the TX/RX cause. Handling the alive cause involves resetting the TX/RX queue indices. This flow works correctly when the causes are mutually exclusive. However, if both cause bits are set simultaneously, the alive cause resets the queue indices, resulting in an event packet drop and a command timeout. To fix this issue, the driver is modified to handle all other causes before checking for the alive cause.[...]
Here is the summary with links:
- [v2] Bluetooth: btintel_pcie: Fix event packet loss issue
https://git.kernel.org/bluetooth/bluetooth-next/c/f9dce2067c2d
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html