FAILED: patch "[PATCH] pwm: berlin: Fix wrong register in suspend/resume" failed to apply to 5.4-stable tree
Subsystems (2)
[email protected]
maintainerThe patch below does not apply to the 5.4-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.
To reproduce the conflict and resubmit, you may use the following commands:
git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-5.4.y
git checkout FETCH_HEAD
git cherry-pick -x 3a4b9d027e4061766f618292df91760ea64a1fcc
# <resolve conflicts, build, test, etc.>
git commit -s
git send-email --to '<[email protected]>' --in-reply-to '2025101613-candle-babble-137f@gregkh' --subject-prefix 'PATCH 5.4.y' HEAD^..
Possible dependencies:
thanks,
greg k-h
------------------ original commit in Linus's tree ------------------
From 3a4b9d027e4061766f618292df91760ea64a1fcc Mon Sep 17 00:00:00 2001
From: Jisheng Zhang <[email protected]>
Date: Tue, 19 Aug 2025 19:42:24 +0800
Subject: [PATCH] pwm: berlin: Fix wrong register in suspend/resume
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
The 'enable' register should be BERLIN_PWM_EN rather than BERLIN_PWM_ENABLE, otherwise, the driver accesses wrong address, there will be cpu exception then kernel panic during suspend/resume.
drivers/pwm/pwm-berlin.c +2 -2
@@ -234,7 +234,7 @@ static int berlin_pwm_suspend(struct device *dev)for (i =0 ; i < chip->npwm; i++) {struct berlin_pwm_channel *channel = &bpc->channel[i]; - channel->enable =berlin_pwm_readl (bpc, i,BERLIN_PWM_ENABLE ); + channel->enable =berlin_pwm_readl (bpc, i,BERLIN_PWM_EN ); channel->ctrl =berlin_pwm_readl (bpc, i,BERLIN_PWM_CONTROL ); channel->duty =berlin_pwm_readl (bpc, i,BERLIN_PWM_DUTY ); channel->tcnt =berlin_pwm_readl (bpc, i,BERLIN_PWM_TCNT );
@@ -262,7 +262,7 @@ static int berlin_pwm_resume(struct device *dev)berlin_pwm_writel (bpc, i, channel->ctrl,BERLIN_PWM_CONTROL );berlin_pwm_writel (bpc, i, channel->duty,BERLIN_PWM_DUTY );berlin_pwm_writel (bpc, i, channel->tcnt,BERLIN_PWM_TCNT ); -berlin_pwm_writel (bpc, i, channel->enable,BERLIN_PWM_ENABLE ); +berlin_pwm_writel (bpc, i, channel->enable,BERLIN_PWM_EN ); }return 0 ;