Add pinctrl support for Sky1
Subsystems (4)
Gary Yang
maintainerv4 cover Add pinctrl support for Sky1
Patch 1: Add dt-binding doc for pinctrl on Sky1
Patch 2: Add pin-controller driver for sky1
Patch 3: Add pinctrl nodes for sky1
changes for v4:
- Pass dts build check with below commands:
make O=$OUTKNL dt_binding_check
make O=$OUTKNL dt_binding_check DT_SCHEMA_FILES=cix,sky1-pinctrl.yaml scripts/checkpatch.pl 000*.patch
make O=$OUTKNL CHECK_DTBS=y W=1 cix/sky1-orion-o6.dtb
- support driver_strength = <8> (mA)
- Fix dt-bindings style
Changes for v3:
- Pass dts build check with below commands:
make O=$OUTKNL dt_binding_check
make O=$OUTKNL dt_binding_check DT_SCHEMA_FILES=cix,sky1-pinctrl.yaml scripts/checkpatch.pl 000*.patch
make O=$OUTKNL CHECK_DTBS=y W=1 cix/sky1-orion-o6.dtb
- Re-order the patch set, and move dt-bindings to the 1st patch.
- Refine the pinctrl driver with SKY_PINFUNCTION macro
- Fix warnings when make dt_binding_check
Changes for v2:
- restructure the pinctrl driver to support pinmux=<..>
- redefine pinmux macros
- move header file from dt-bindings to dts
- fix the code-style issues
Gary Yang (3):
dt-bindings: pinctrl: Add cix,sky1-pinctrl
pinctrl: cix: Add pin-controller support for sky1
arm64: dts: cix: Add pinctrl nodes for sky1
.../bindings/pinctrl/cix,sky1-pinctrl.yaml | 94 +++ arch/arm64/boot/dts/cix/sky1-orion-o6.dts | 32 + arch/arm64/boot/dts/cix/sky1-pinfunc.h | 418 +++++++++++++ arch/arm64/boot/dts/cix/sky1.dtsi | 10 + drivers/pinctrl/Kconfig | 1 + drivers/pinctrl/Makefile | 1 + drivers/pinctrl/cix/Kconfig | 14 + drivers/pinctrl/cix/Makefile | 4 + drivers/pinctrl/cix/pinctrl-sky1-base.c | 573 ++++++++++++++++++ drivers/pinctrl/cix/pinctrl-sky1.c | 559 +++++++++++++++++ drivers/pinctrl/cix/pinctrl-sky1.h | 48 ++ 11 files changed, 1754 insertions(+) create mode 100644 Documentation/devicetree/bindings/pinctrl/cix,sky1-pinctrl.yaml create mode 100644 arch/arm64/boot/dts/cix/sky1-pinfunc.h create mode 100644 drivers/pinctrl/cix/Kconfig create mode 100644 drivers/pinctrl/cix/Makefile create mode 100644 drivers/pinctrl/cix/pinctrl-sky1-base.c create mode 100644 drivers/pinctrl/cix/pinctrl-sky1.c create mode 100644 drivers/pinctrl/cix/pinctrl-sky1.h
Signature · 1 line
2.49.0
Gary Yang
maintainerPATCH v4 1/3 dt-bindings: pinctrl: Add cix,sky1-pinctrl
The pin-controller is used to control the Soc pins. There are two pin-controllers on Cix Sky1 platform. One is used under S0 state, the other is used under S0 and S5 state.
--- .../bindings/pinctrl/cix,sky1-pinctrl.yaml | 94 +++++++++++++++++++ 1 file changed, 94 insertions(+) create mode 100644 Documentation/devicetree/bindings/pinctrl/cix,sky1-pinctrl.yaml
Documentation/devicetree/bindings/pinctrl/cix,sky1-pinctrl.yaml new file +94 -0
@@ -0,0 +1,94 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/pinctrl/cix,sky1-pinctrl.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Cix Sky1 Soc Pin Controller + +maintainers: + - Gary Yang <[email protected]> + +description: + The pin-controller is used to control Soc pins. There are two pin-controllers + on Cix Sky1 platform. one is used under S0 state, the other one is used under + S0 and S5 state. + +properties: + compatible: + enum: + - cix,sky1-iomuxc + - cix,sky1-iomuxc-s5 + + reg: + items: + - description: gpio base + +# Client device subnode's properties +patternProperties: + '-cfg$': + type: object + additionalProperties: false + + description: + A pinctrl node should contain at least one subnode representing the + pinctrl groups available on the machine. + + patternProperties: + 'pins$': + type: object + additionalProperties: false + + description: + Each subnode will list the pins it needs, and how they should + be configured, with regard to muxer configuration, bias pull, + and drive strength. + + allOf: + - $ref: pincfg-node.yaml# + - $ref: pinmux-node.yaml# + + properties: + pinmux: + description: + Values are constructed from pin number and mux setting + + bias-disable: true + + bias-pull-up: true + + bias-pull-down: true + + drive-strength: + description: + typical current when output high level. + enum: [ 2, 3, 5, 6, 8, 9, 11, 12, 13, 14, 17, 18, 20, 21, 23, + 24 ] + + + required: + - pinmux + +required: + - compatible + - reg + +additionalProperties: false + +examples: + # Pinmux controller node + - | + #define CIX_PAD_GPIO012_FUNC_GPIO012 (11 << 8 | 0x0) + #define DS_LEVEL4 (8) + iomuxc: pinctrl@4170000 { + compatible = "cix,sky1-iomuxc"; + reg = <0x4170000 0x1000>; + + wifi_vbat_gpio: wifi-vbat-gpio-cfg { + pins { + pinmux = <CIX_PAD_GPIO012_FUNC_GPIO012>; + bias-pull-up; + drive-strength = <DS_LEVEL4>; + }; + }; + };
Signature · 1 line
2.49.0
Re: [PATCH v4 1/3] dt-bindings: pinctrl: Add cix,sky1-pinctrl
Documentation/devicetree/bindings/pinctrl/cix,sky1-pinctrl.yaml
Quoted 16 lines · Gary Yang
The pin-controller is used to control the Soc pins. There are two pin-controllers on Cix Sky1 platform. One is used under S0 state, the other is used under S0 and S5 state.
Signed-off-by Gary Yang <[email protected]>--- .../bindings/pinctrl/cix,sky1-pinctrl.yaml | 94 +++++++++++++++++++ 1 file changed, 94 insertions(+) create mode 100644 Documentation/devicetree/bindings/pinctrl/cix,sky1-pinctrl.yamlDocumentation/devicetree/bindings/pinctrl/cix,sky1-pinctrl.yaml new file +0
-0
Please use a filename matching a compatible, probably the first one.
Quoted 18 lines
Documentation/devicetree/bindings/pinctrl/cix,sky1-pinctrl.yaml new file +17
-0@@ -0,0 +1,94 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/pinctrl/cix,sky1-pinctrl.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Cix Sky1 Soc Pin Controller + +maintainers: + - Gary Yang <[email protected]> + +description: + The pin-controller is used to control Soc pins. There are two pin-controllers + on Cix Sky1 platform. one is used under S0 state, the other one is used under + S0 and S5 state. + +properties:
Documentation/devicetree/bindings/pinctrl/cix,sky1-pinctrl.yaml line 27
Quoted 10 lines
Documentation/devicetree/bindings/pinctrl/cix,sky1-pinctrl.yaml new file +10
-0+ compatible: + enum: + - cix,sky1-iomuxc + - cix,sky1-iomuxc-s5 + + reg: + items: + - description: gpio base + +# Client device subnode's properties
I'd drop these comments, they're just stating what's "obvious" for bindings.
Quoted 17 lines
Documentation/devicetree/bindings/pinctrl/cix,sky1-pinctrl.yaml new file +17
-0+patternProperties: + '-cfg$': + type: object + additionalProperties: false + + description: + A pinctrl node should contain at least one subnode representing the + pinctrl groups available on the machine. + + patternProperties: + 'pins$': + type: object + additionalProperties: false + + description: + Each subnode will list the pins it needs, and how they should + be configured, with regard to muxer configuration, bias pull,
Documentation/devicetree/bindings/pinctrl/cix,sky1-pinctrl.yaml line 54
Quoted 10 lines
Documentation/devicetree/bindings/pinctrl/cix,sky1-pinctrl.yaml new file +10
-0+ and drive strength. + + allOf: + - $ref: pincfg-node.yaml# + - $ref: pinmux-node.yaml# + + properties: + pinmux: + description: + Values are constructed from pin number and mux setting
I think this should actually say how the values are constructed, one shouldn't have to reverse engineer it from a macro in the example.
Quoted 15 lines
Documentation/devicetree/bindings/pinctrl/cix,sky1-pinctrl.yaml new file +15
-0+ + bias-disable: true + + bias-pull-up: true + + bias-pull-down: true + + drive-strength: + description: + typical current when output high level. + enum: [ 2, 3, 5, 6, 8, 9, 11, 12, 13, 14, 17, 18, 20, 21, 23, + 24 ] + + + required:
Documentation/devicetree/bindings/pinctrl/cix,sky1-pinctrl.yaml line 79
Quoted 10 lines
Documentation/devicetree/bindings/pinctrl/cix,sky1-pinctrl.yaml new file +10
-0+ - pinmux + +required: + - compatible + - reg + +additionalProperties: false + +examples: + # Pinmux controller node
Drop this comment too.
Documentation/devicetree/bindings/pinctrl/cix,sky1-pinctrl.yaml line 82
Quoted 4 lines
Documentation/devicetree/bindings/pinctrl/cix,sky1-pinctrl.yaml new file +3
-0+ - | + #define CIX_PAD_GPIO012_FUNC_GPIO012 (11 << 8 | 0x0) + #define DS_LEVEL4 (8)
Delete this define entirely, it actually just obfuscates the actually amperage.
Quoted 1 line
+ iomuxc: pinctrl@4170000 {
Unused labels should be removed from binding examples.
pw-bot: changes-requested
Thanks,
Conor.
Quoted 14 lines
Documentation/devicetree/bindings/pinctrl/cix,sky1-pinctrl.yaml new file +11
-0+ compatible = "cix,sky1-iomuxc"; + reg = <0x4170000 0x1000>; + + wifi_vbat_gpio: wifi-vbat-gpio-cfg { + pins { + pinmux = <CIX_PAD_GPIO012_FUNC_GPIO012>; + bias-pull-up; + drive-strength = <DS_LEVEL4>; + }; + }; + };Signature · 1 line
2.49.0
Gary Yang
maintainerPATCH v4 2/3 pinctrl: cix: Add pin-controller support for sky1
In reply to Gary YangThere are two pin-controllers on Cix Sky1 platform.
one is used under S0 state, the other is used under S0 and S5 state.
--- drivers/pinctrl/Kconfig | 1 + drivers/pinctrl/Makefile | 1 + drivers/pinctrl/cix/Kconfig | 14 + drivers/pinctrl/cix/Makefile | 4 + drivers/pinctrl/cix/pinctrl-sky1-base.c | 573 ++++++++++++++++++++++++ drivers/pinctrl/cix/pinctrl-sky1.c | 559 +++++++++++++++++++++++ drivers/pinctrl/cix/pinctrl-sky1.h | 48 ++ 7 files changed, 1200 insertions(+) create mode 100644 drivers/pinctrl/cix/Kconfig create mode 100644 drivers/pinctrl/cix/Makefile create mode 100644 drivers/pinctrl/cix/pinctrl-sky1-base.c create mode 100644 drivers/pinctrl/cix/pinctrl-sky1.c create mode 100644 drivers/pinctrl/cix/pinctrl-sky1.h
drivers/pinctrl/Kconfig +1 -0
@@ -653,6 +653,7 @@ source "drivers/pinctrl/aspeed/Kconfig" source "drivers/pinctrl/bcm/Kconfig" source "drivers/pinctrl/berlin/Kconfig" source "drivers/pinctrl/cirrus/Kconfig" +source "drivers/pinctrl/cix/Kconfig" source "drivers/pinctrl/freescale/Kconfig" source "drivers/pinctrl/intel/Kconfig" source "drivers/pinctrl/mediatek/Kconfig"
drivers/pinctrl/Makefile +1 -0
@@ -67,6 +67,7 @@ obj-$(CONFIG_ARCH_ASPEED) += aspeed/ obj-y += bcm/ obj-$(CONFIG_PINCTRL_BERLIN) += berlin/ obj-y += cirrus/ +obj-y += cix/ obj-y += freescale/ obj-$(CONFIG_X86) += intel/ obj-y += mediatek/
drivers/pinctrl/cix/Kconfig new file +14 -0
@@ -0,0 +1,14 @@ +# SPDX-License-Identifier: GPL-2.0-only +config PINCTRL_SKY1_BASE + tristate + select GENERIC_PINCTRL_GROUPS + select GENERIC_PINMUX_FUNCTIONS + select GENERIC_PINCONF + select REGMAP + +config PINCTRL_SKY1 + tristate "Cix Sky1 pinctrl driver" + depends on ARCH_CIX || COMPILE_TEST + select PINCTRL_SKY1_BASE + help + Say Y here to enable the sky1 pinctrl driver
drivers/pinctrl/cix/Makefile new file +4 -0
@@ -0,0 +1,4 @@ +# SPDX-License-Identifier: GPL-2.0 +# Cix Sky1 pin control drivers +obj-$(CONFIG_PINCTRL_SKY1_BASE) += pinctrl-sky1-base.o +obj-$(CONFIG_PINCTRL_SKY1) += pinctrl-sky1.o
drivers/pinctrl/cix/pinctrl-sky1-base.c new file +573 -0
573 lines not on this page · raw message
drivers/pinctrl/cix/pinctrl-sky1.c new file +559 -0
559 lines not on this page · raw message
drivers/pinctrl/cix/pinctrl-sky1.h new file +48 -0
48 lines not on this page · raw message
Signature · 1 line
2.49.0
kernel test robot
build botRe: [PATCH v4 2/3] pinctrl: cix: Add pin-controller support for sky1
kernel test robot noticed the following build warnings:
Hi Gary,
kernel test robot noticed the following build warnings:
[auto build test WARNING on linusw-pinctrl/devel]
[also build test WARNING on linusw-pinctrl/for-next robh/for-next linus/master v6.18-rc1 next-20251017] [If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Gary-Yang/dt-bindings-pinctrl-Add-cix-sky1-pinctrl/20251017-155001 base: https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git devel patch link: https://lore.kernel.org/r/20251017074646.3344924-3-gary.yang%40cixtech.com patch subject: [PATCH v4 2/3] pinctrl: cix: Add pin-controller support for sky1 config: nios2-randconfig-r121-20251018 (https://download.01.org/0day-ci/archive/20251018/[email protected]/config) compiler: nios2-linux-gcc (GCC) 9.5.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251018/[email protected]/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
sparse warnings: (new ones prefixed by >>)
>> drivers/pinctrl/cix/pinctrl-sky1-base.c:289:17: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected unsigned int [usertype] *pin_reg @@ got void [noderef] __iomem * @@ drivers/pinctrl/cix/pinctrl-sky1-base.c:289:17: sparse: expected unsigned int [usertype] *pin_reg drivers/pinctrl/cix/pinctrl-sky1-base.c:289:17: sparse: got void [noderef] __iomem * >> drivers/pinctrl/cix/pinctrl-sky1-base.c:290:25: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void const volatile [noderef] __iomem *addr @@ got unsigned int [usertype] *pin_reg @@ drivers/pinctrl/cix/pinctrl-sky1-base.c:290:25: sparse: expected void const volatile [noderef] __iomem *addr drivers/pinctrl/cix/pinctrl-sky1-base.c:290:25: sparse: got unsigned int [usertype] *pin_reg >> drivers/pinctrl/cix/pinctrl-sky1-base.c:293:25: sparse: sparse: incorrect type in argument 2 (different address spaces) @@ expected void volatile [noderef] __iomem *addr @@ got unsigned int [usertype] *pin_reg @@
drivers/pinctrl/cix/pinctrl-sky1-base.c:293:25: sparse: expected void volatile [noderef] __iomem *addr
drivers/pinctrl/cix/pinctrl-sky1-base.c:293:25: sparse: got unsigned int [usertype] *pin_reg
drivers/pinctrl/cix/pinctrl-sky1-base.c:358:17: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected unsigned int [usertype] *pin_reg @@ got void [noderef] __iomem * @@
drivers/pinctrl/cix/pinctrl-sky1-base.c:358:17: sparse: expected unsigned int [usertype] *pin_reg
drivers/pinctrl/cix/pinctrl-sky1-base.c:358:17: sparse: got void [noderef] __iomem *
drivers/pinctrl/cix/pinctrl-sky1-base.c:359:25: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void const volatile [noderef] __iomem *addr @@ got unsigned int [usertype] *pin_reg @@
drivers/pinctrl/cix/pinctrl-sky1-base.c:359:25: sparse: expected void const volatile [noderef] __iomem *addr
drivers/pinctrl/cix/pinctrl-sky1-base.c:359:25: sparse: got unsigned int [usertype] *pin_reg
drivers/pinctrl/cix/pinctrl-sky1-base.c:372:25: sparse: sparse: incorrect type in argument 2 (different address spaces) @@ expected void volatile [noderef] __iomem *addr @@ got unsigned int [usertype] *pin_reg @@
drivers/pinctrl/cix/pinctrl-sky1-base.c:372:25: sparse: expected void volatile [noderef] __iomem *addr
drivers/pinctrl/cix/pinctrl-sky1-base.c:372:25: sparse: got unsigned int [usertype] *pin_reg
drivers/pinctrl/cix/pinctrl-sky1-base.c:398:17: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected unsigned int [usertype] *pin_reg @@ got void [noderef] __iomem * @@
drivers/pinctrl/cix/pinctrl-sky1-base.c:398:17: sparse: expected unsigned int [usertype] *pin_reg
drivers/pinctrl/cix/pinctrl-sky1-base.c:398:17: sparse: got void [noderef] __iomem *
drivers/pinctrl/cix/pinctrl-sky1-base.c:399:25: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void const volatile [noderef] __iomem *addr @@ got unsigned int [usertype] *pin_reg @@
drivers/pinctrl/cix/pinctrl-sky1-base.c:399:25: sparse: expected void const volatile [noderef] __iomem *addr
drivers/pinctrl/cix/pinctrl-sky1-base.c:399:25: sparse: got unsigned int [usertype] *pin_reg
drivers/pinctrl/cix/pinctrl-sky1-base.c:403:25: sparse: sparse: incorrect type in argument 2 (different address spaces) @@ expected void volatile [noderef] __iomem *addr @@ got unsigned int [usertype] *pin_reg @@
drivers/pinctrl/cix/pinctrl-sky1-base.c:403:25: sparse: expected void volatile [noderef] __iomem *addr
drivers/pinctrl/cix/pinctrl-sky1-base.c:403:25: sparse: got unsigned int [usertype] *pin_reg
vim +289 drivers/pinctrl/cix/pinctrl-sky1-base.c
282
283 static int sky1_pmx_set_one_pin(struct sky1_pinctrl *spctl,
284 unsigned int pin, unsigned char muxval)
285 {
286 u32 reg_val;
287 u32 *pin_reg;
288
> 289 pin_reg = spctl->base + pin * SKY1_PIN_SIZE; > 290 reg_val = readl(pin_reg); 291 reg_val &= ~SKY1_MUX_MASK; 292 reg_val |= muxval << SKY1_MUX_SHIFT; > 293 writel(reg_val, pin_reg);
294
295 dev_dbg(spctl->dev, "write: offset 0x%x val 0x%x\n",
296 pin * SKY1_PIN_SIZE, reg_val);
297 return 0;
298 }
299
Signature · 2 lines
0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
Gary Yang
maintainerPATCH v4 3/3 arm64: dts: cix: Add pinctrl nodes for sky1
In reply to Gary YangAdd the pin-controller nodes for Sky1 platform.
--- arch/arm64/boot/dts/cix/sky1-orion-o6.dts | 32 ++ arch/arm64/boot/dts/cix/sky1-pinfunc.h | 418 ++++++++++++++++++++++ arch/arm64/boot/dts/cix/sky1.dtsi | 10 + 3 files changed, 460 insertions(+) create mode 100644 arch/arm64/boot/dts/cix/sky1-pinfunc.h
arch/arm64/boot/dts/cix/sky1-orion-o6.dts +32 -0
@@ -7,6 +7,8 @@ /dts-v1/; #include "sky1.dtsi" +#include "sky1-pinfunc.h" + / { model = "Radxa Orion O6"; compatible = "radxa,orion-o6", "cix,sky1";
@@ -34,6 +36,36 @@ linux,cma { }; +&iomuxc { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_hog>; + + pinctrl_hog: hog-cfg { + pins { + pinmux = <CIX_PAD_GPIO144_FUNC_GPIO144>, + <CIX_PAD_GPIO145_FUNC_GPIO145>, + <CIX_PAD_GPIO146_FUNC_GPIO146>, + <CIX_PAD_GPIO147_FUNC_GPIO147>; + bias-pull-down; + drive-strength = <DS_LEVEL4>; + }; + }; +}; + +&iomuxc_s5 { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_hog_s5>; + + pinctrl_hog_s5: hog-s5-cfg { + pins { + pinmux = <CIX_PAD_GPIO014_FUNC_GPIO014>; + bias-pull-up; + drive-strength = <DS_LEVEL4>; + + }; + }; +}; + &uart2 { status = "okay"; };
arch/arm64/boot/dts/cix/sky1-pinfunc.h new file +418 -0
418 lines not on this page · raw message
arch/arm64/boot/dts/cix/sky1.dtsi +10 -0
@@ -228,6 +228,11 @@ uart3: serial@40e0000 { status = "disabled"; }; + iomuxc: pinctrl@4170000 { + compatible = "cix,sky1-iomuxc"; + reg = <0x0 0x04170000 0x0 0x1000>; + }; + mbox_ap2se: mailbox@5060000 { compatible = "cix,sky1-mbox"; reg = <0x0 0x05060000 0x0 0x10000>;
@@ -316,6 +321,11 @@ ppi_partition1: interrupt-partition-1 { }; }; }; + + iomuxc_s5: pinctrl@16007000 { + compatible = "cix,sky1-iomuxc-s5"; + reg = <0x0 0x16007000 0x0 0x1000>; + }; }; timer {
Signature · 1 line
2.49.0
Re: [PATCH v4 3/3] arm64: dts: cix: Add pinctrl nodes for sky1
Quoted 6 lines · Gary Yang
arch/arm64/boot/dts/cix/sky1-pinfunc.h new file +6
-0+#define DS_LEVEL0 2 +#define DS_LEVEL1 3 +#define DS_LEVEL2 5 +#define DS_LEVEL3 6 +#define DS_LEVEL4 8 +#define DS_LEVEL5 9
arch/arm64/boot/dts/cix/sky1-pinfunc.h line 416
Quoted 10 lines
arch/arm64/boot/dts/cix/sky1-pinfunc.h new file +10
-0+#define DS_LEVEL6 11 +#define DS_LEVEL7 12 +#define DS_LEVEL8 13 +#define DS_LEVEL9 14 +#define DS_LEVEL10 17 +#define DS_LEVEL11 18 +#define DS_LEVEL12 20 +#define DS_LEVEL13 21 +#define DS_LEVEL14 23 +#define DS_LEVEL15 24
All of these just hide the amperage, please drop them.
Hi Gary,
overall this version is starting to look really nice!
Please address Conors comments, then see about the compile error on the driver itself. The code looks good otherwise.
Looking forward to v5!
Yours,
Linus Walleij