Skip to contentSkip to conversation

ACPI: property: Fix argument order in __acpi_node_get_property_reference()

PATCH Applied Sunil V L 3 participants 3 messages Oct 17, 2025 – Oct 20, 2025 ACPI

lore
Share & tools
lore

Sunil V L

author
#0 lore raw

PATCH 1/1 ACPI: property: Fix argument order in __acpi_node_get_property_reference()

A refactoring bug introduced an argument order mistake in the call to acpi_fwnode_get_reference_args() from __acpi_node_get_property_reference(). This caused incorrect behavior when resolving ACPI property references.

Fix the issue by correcting the argument order.

Fixes e121be784d35 ("ACPI: property: Refactor acpi_fwnode_get_reference_args() to support nargs_prop")
---
 drivers/acpi/property.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/acpi/property.c +1 -1
index 1b997a5497e7..43d5e457814e 100644
@@ -1107,7 +1107,7 @@ int __acpi_node_get_property_reference(const struct fwnode_handle *fwnode,
 				       size_t num_args,
 				       struct fwnode_reference_args *args)
 {
-	return acpi_fwnode_get_reference_args(fwnode, propname, NULL, index, num_args, args);
+	return acpi_fwnode_get_reference_args(fwnode, propname, NULL, num_args, index, args);
 }
 EXPORT_SYMBOL_GPL(__acpi_node_get_property_reference);
 
Signature · 1 line
2.43.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 5 lines · Sunil V L

A refactoring bug introduced an argument order mistake in the call to acpi_fwnode_get_reference_args() from __acpi_node_get_property_reference(). This caused incorrect behavior when resolving ACPI property references.

Fix the issue by correcting the argument order.

Thanks for a fix which looks good to me,

Signature · 2 lines
With Best Regards,
Andy Shevchenko
maintainer Applied
#2 lore raw
Quoted 10 lines · Andy Shevchenko
Quoted 5 lines · Sunil V L

A refactoring bug introduced an argument order mistake in the call to acpi_fwnode_get_reference_args() from __acpi_node_get_property_reference(). This caused incorrect behavior when resolving ACPI property references.

Fix the issue by correcting the argument order.

Thanks for a fix which looks good to me,

Applied as 6.18-rc material, thanks!