Print arrays like Linux does
PATCH 1/1 Print arrays like Linux does
In Linux, trace_print_array_seq prints array elements as hexadecimal numbers, separates them with commas, and surrounds the whole thing with curly braces. Modify print_str_arg to use the same formatting.
---
src/event-parse.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-)
src/event-parse.c +7 -5
@@ -4938,18 +4938,19 @@ static void print_str_arg(struct trace_seq *s, void *data, int size, len =eval_num_arg (data, size, event, arg->int_array.count); el_size =eval_num_arg (data, size, event, arg->int_array.el_size); +trace_seq_putc (s,'{' );for (i =0 ; i < len; i++) {if (i) -trace_seq_putc (s,' ' ); +trace_seq_putc (s,',' );if (el_size ==1 ) { -trace_seq_printf (s,"%u" , *(uint8_t *)num); +trace_seq_printf (s,"0x%x" , *(uint8_t *)num); }else if (el_size ==2 ) { -trace_seq_printf (s,"%u" , *(uint16_t *)num); +trace_seq_printf (s,"0x%x" , *(uint16_t *)num); }else if (el_size ==4 ) { -trace_seq_printf (s,"%u" , *(uint32_t *)num); +trace_seq_printf (s,"0x%x" , *(uint32_t *)num); }else if (el_size ==8 ) { -trace_seq_printf (s,"%" PRIu64, *(uint64_t *)num); +trace_seq_printf (s,"0x%" PRIx64, *(uint64_t *)num); }else {trace_seq_printf (s,"BAD SIZE:%d 0x%x" , el_size, *(uint8_t *)num);
@@ -4958,6 +4959,7 @@ static void print_str_arg(struct trace_seq *s, void *data, int size, num += el_size; } +trace_seq_putc (s,'}' );break ; }case TEP_PRINT_TYPE :
Signature · 1 line
2.35.1.1320.gc452695387.dirty
Quoted 40 lines · Sean Anderson
In Linux,
trace_print_array_seqprints array elements as hexadecimal numbers, separates them with commas, and surrounds the whole thing with curly braces. Modifyprint_str_argto use the same formatting.Signed-off-by Sean Anderson <[email protected]>---
src/event-parse.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-)src/event-parse.c +6
-5@@ -4938,18 +4938,19 @@ static void print_str_arg(struct trace_seq *s, void *data, int size, len =eval_num_arg (data, size, event, arg->int_array.count); el_size =eval_num_arg (data, size, event, arg->int_array.el_size); +trace_seq_putc (s,'{' );for (i =0 ; i < len; i++) {if (i) -trace_seq_putc (s,' ' ); +trace_seq_putc (s,',' );if (el_size ==1 ) { -trace_seq_printf (s,"%u" , *(uint8_t *)num); +trace_seq_printf (s,"0x%x" , *(uint8_t *)num); }else if (el_size ==2 ) { -trace_seq_printf (s,"%u" , *(uint16_t *)num); +trace_seq_printf (s,"0x%x" , *(uint16_t *)num); }else if (el_size ==4 ) { -trace_seq_printf (s,"%u" , *(uint32_t *)num); +trace_seq_printf (s,"0x%x" , *(uint32_t *)num); }else if (el_size ==8 ) { -trace_seq_printf (s,"%" PRIu64, *(uint64_t *)num); +trace_seq_printf (s,"0x%" PRIx64, *(uint64_t *)num); }else {trace_seq_printf (s,"BAD SIZE:%d 0x%x" , el_size, *(uint8_t *)num);
src/event-parse.c static void print_str_arg(struct trace_seq *s, void *data, int size, · line 4965
Quoted 7 lines
src/event-parse.c +1
-0@@ -4958,6 +4959,7 @@ static void print_str_arg(struct trace_seq *s, void *data, int size, num += el_size; } +trace_seq_putc (s,'}' );break ; }case TEP_PRINT_TYPE :
ping
Quoted 42 lines · On Mon, 20 Oct 2025 12:17:05 -0400 Sean Anderson <[email protected]>…
Quoted 41 lines · Sean Anderson
In Linux,
trace_print_array_seqprints array elements as hexadecimal numbers, separates them with commas, and surrounds the whole thing with curly braces. Modifyprint_str_argto use the same formatting.Signed-off-by Sean Anderson <[email protected]>---
src/event-parse.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-)src/event-parse.c +6
-5@@ -4938,18 +4938,19 @@ static void print_str_arg(struct trace_seq *s, void *data, int size, len =eval_num_arg (data, size, event, arg->int_array.count); el_size =eval_num_arg (data, size, event, arg->int_array.el_size); +trace_seq_putc (s,'{' );for (i =0 ; i < len; i++) {if (i) -trace_seq_putc (s,' ' ); +trace_seq_putc (s,',' );if (el_size ==1 ) { -trace_seq_printf (s,"%u" , *(uint8_t *)num); +trace_seq_printf (s,"0x%x" , *(uint8_t *)num); }else if (el_size ==2 ) { -trace_seq_printf (s,"%u" , *(uint16_t *)num); +trace_seq_printf (s,"0x%x" , *(uint16_t *)num); }else if (el_size ==4 ) { -trace_seq_printf (s,"%u" , *(uint32_t *)num); +trace_seq_printf (s,"0x%x" , *(uint32_t *)num); }else if (el_size ==8 ) { -trace_seq_printf (s,"%" PRIu64, *(uint64_t *)num); +trace_seq_printf (s,"0x%" PRIx64, *(uint64_t *)num); }else {trace_seq_printf (s,"BAD SIZE:%d 0x%x" , el_size, *(uint8_t *)num);@@ -4958,6 +4959,7 @@ static void print_str_arg(struct trace_seq *s, void *data, int size,
Quoted 8 lines
src/event-parse.c static void print_str_arg(struct trace_seq *s, void *data, int size, · line 4965
Quoted 6 lines
src/event-parse.c +1
-0num += el_size; } +trace_seq_putc (s,'}' );break ; }case TEP_PRINT_TYPE :ping
It's been accepted:
I just haven't had time to make a new official release.
-- Steve
Quoted 54 lines · Steven Rostedt
Quoted 42 lines · On Mon, 20 Oct 2025 12:17:05 -0400 Sean Anderson <[email protected]>…
Quoted 41 lines · Sean Anderson
In Linux,
trace_print_array_seqprints array elements as hexadecimal numbers, separates them with commas, and surrounds the whole thing with curly braces. Modifyprint_str_argto use the same formatting.Signed-off-by Sean Anderson <[email protected]>---
src/event-parse.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-)src/event-parse.c +6
-5@@ -4938,18 +4938,19 @@ static void print_str_arg(struct trace_seq *s, void *data, int size, len =eval_num_arg (data, size, event, arg->int_array.count); el_size =eval_num_arg (data, size, event, arg->int_array.el_size); +trace_seq_putc (s,'{' );for (i =0 ; i < len; i++) {if (i) -trace_seq_putc (s,' ' ); +trace_seq_putc (s,',' );if (el_size ==1 ) { -trace_seq_printf (s,"%u" , *(uint8_t *)num); +trace_seq_printf (s,"0x%x" , *(uint8_t *)num); }else if (el_size ==2 ) { -trace_seq_printf (s,"%u" , *(uint16_t *)num); +trace_seq_printf (s,"0x%x" , *(uint16_t *)num); }else if (el_size ==4 ) { -trace_seq_printf (s,"%u" , *(uint32_t *)num); +trace_seq_printf (s,"0x%x" , *(uint32_t *)num); }else if (el_size ==8 ) { -trace_seq_printf (s,"%" PRIu64, *(uint64_t *)num); +trace_seq_printf (s,"0x%" PRIx64, *(uint64_t *)num); }else {trace_seq_printf (s,"BAD SIZE:%d 0x%x" , el_size, *(uint8_t *)num);@@ -4958,6 +4959,7 @@ static void print_str_arg(struct trace_seq *s, void *data, int size,Quoted 8 lines
src/event-parse.c static void print_str_arg(struct trace_seq *s, void *data, int size, · line 4965
Quoted 6 lines
src/event-parse.c +1
-0num += el_size; } +trace_seq_putc (s,'}' );break ; }case TEP_PRINT_TYPE :ping
Quoted 7 lines
It's been accepted:
I just haven't had time to make a new official release.
-- Steve
Great thanks. Just wanted to make sure this didn't get lost.
--Sean