generic/772: split and fix
cover generic/772: split and fix
Hi all,
This one add one missed file attribute flag (n). Then, the check for file_getattr/file_setattr on regular and special files is lifted to the common/ for futher test splitting. The generic/772 is split into two tests one for regular files and one for special files.
This one based on top of Darrick's "random fixes" patchset [1]
To: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
[1]: https://lore.kernel.org/fstests/176054617853.2391029.10911105763476647916.stgit@frogsfrogsfrogs/T/#t
Andrey Albershteyn (3):
common/filter: add missing file attribute
generic/772: require filesystem to support file_[g|s]etattr generic/772: split this test into 772 and 773 for regular and special
files
common/filter | 2 +- common/rc | 32 +++++++++++++++++ tests/generic/772 | 41 ++------------------- tests/generic/772.out | 14 -------- tests/generic/773 | 84 +++++++++++++++++++++++++++++++++++++++++++ tests/generic/773.out | 20 +++++++++++ tests/xfs/648 | 7 ++-- 7 files changed, 142 insertions(+), 58 deletions(-) create mode 100755 tests/generic/773 create mode 100644 tests/generic/773.out
Signature · 1 line
2.50.1
PATCH 1/3 common/filter: add missing file attribute
Add n (nosymlinks) char according to xfsprogs io/attr.c
--- common/filter | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
common/filter +1 -1
@@ -692,7 +692,7 @@ _filter_sysfs_error() _filter_file_attributes() { if [[ $1 == ~* ]]; then - regex=$(echo "[aAcCdDeEfFijmNpPsrStTuxVX]" | tr -d "$1") + regex=$(echo "[aAcCdDeEfFijmnNpPrsStTuVxX]" | tr -d "$1") else regex="$1" fi
Signature · 1 line
2.50.1
Re: [PATCH 1/3] common/filter: add missing file attribute
Quoted 3 lines · Andrey Albershteyn
Add n (nosymlinks) char according to xfsprogs
io/attr.cSigned-off-by Andrey Albershteyn <[email protected]>
The updated version of "common/filter: fix _filter_file_attributes to handle xfs file flags" that I'm about to send will fix this up by documenting that _filter_file_attributes only handles xfs attrs and then making it handle all the known flags.
--D
Quoted 21 lines
--- common/filter | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)common/filter +1
-1@@ -692,7 +692,7 @@ _filter_sysfs_error() _filter_file_attributes() { if [[ $1 == ~* ]]; then - regex=$(echo "[aAcCdDeEfFijmNpPsrStTuxVX]" | tr -d "$1") + regex=$(echo "[aAcCdDeEfFijmnNpPrsStTuVxX]" | tr -d "$1") else regex="$1" fiSignature · 1 line
2.50.1
Re: [PATCH 1/3] common/filter: add missing file attribute
Quoted 9 lines · Darrick J. Wong
Quoted 3 lines · Andrey Albershteyn
Add n (nosymlinks) char according to xfsprogs
io/attr.cSigned-off-by Andrey Albershteyn <[email protected]>The updated version of "common/filter: fix
_filter_file_attributesto handle xfs file flags" that I'm about to send will fix this up by documenting that_filter_file_attributesonly handles xfs attrs and then making it handle all the known flags.
I see, thanks, I will drop this one then
Quoted 25 lines
--D
Quoted 21 lines
--- common/filter | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)common/filter +1
-1@@ -692,7 +692,7 @@ _filter_sysfs_error() _filter_file_attributes() { if [[ $1 == ~* ]]; then - regex=$(echo "[aAcCdDeEfFijmNpPsrStTuxVX]" | tr -d "$1") + regex=$(echo "[aAcCdDeEfFijmnNpPrsStTuVxX]" | tr -d "$1") else regex="$1" fiSignature · 1 line
2.50.1
Signature · 1 line
- Andrey
PATCH 2/3 generic/772: require filesystem to support file_[g|s]etattr
In reply to Andrey AlbershteynAdd _require_* function to check that filesystem support these syscalls on regular and special files.
--- common/rc | 32 ++++++++++++++++++++++++++++++++ tests/generic/772 | 5 ++--- tests/xfs/648 | 7 +++---- 3 files changed, 37 insertions(+), 7 deletions(-)
common/rc +32 -0
@@ -5994,6 +5994,38 @@ _require_inplace_writes() fi } +# Require filesystem to support file_getattr()/file_setattr() syscalls on +# regular files +_require_file_attr() +{ + local test_file="$SCRATCH_MNT/foo" + touch $test_file + + $here/src/file_attr --set --set-nodump $SCRATCH_MNT ./foo &>/dev/null + rc=$? + rm -f "$test_file" + + if [ $rc -ne 0 ]; then + _notrun "file_getattr not supported for regular files on $FSTYP" + fi +} + +# Require filesystem to support file_getattr()/file_setattr() syscalls on +# special files (chardev, fifo...) +_require_file_attr_special() +{ + local test_file="$SCRATCH_MNT/fifo" + mkfifo $test_file + + $here/src/file_attr --set --set-nodump $SCRATCH_MNT ./fifo &>/dev/null + rc=$? + rm -f "$test_file" + + if [ $rc -ne 0 ]; then + _notrun "file_getattr not supported for special files on $FSTYP" + fi +} + ################################################################################ # make sure this script returns success /bin/true
tests/generic/772 +2 -3
@@ -20,6 +20,8 @@ _require_mknod _scratch_mkfs >>$seqres.full 2>&1 _scratch_mount +_require_file_attr +_require_file_attr_special file_attr () { $here/src/file_attr $*
@@ -43,9 +45,6 @@ touch $projectdir/bar ln -s $projectdir/bar $projectdir/broken-symlink rm -f $projectdir/bar -file_attr --get $projectdir ./fifo &>/dev/null || \ - _notrun "file_getattr not supported on $FSTYP" - echo "Error codes" # wrong AT_ flags file_attr --get --invalid-at $projectdir ./foo
tests/xfs/648 +3 -4
@@ -20,10 +20,12 @@ _require_test_program "af_unix" _require_test_program "file_attr" _require_symlinks _require_mknod - _scratch_mkfs >>$seqres.full 2>&1 _qmount_option "pquota" _scratch_mount +_require_file_attr +_require_file_attr_special + create_af_unix () { $here/src/af_unix $* || echo af_unix failed
@@ -47,9 +49,6 @@ touch $projectdir/bar ln -s $projectdir/bar $projectdir/broken-symlink rm -f $projectdir/bar -$here/src/file_attr --get $projectdir ./fifo &>/dev/null || \ - _notrun "file_getattr not supported on $FSTYP" - $XFS_QUOTA_PROG -D $tmp.projects -P $tmp.projid -x \ -c "project -sp $projectdir $id" $SCRATCH_DEV | filter_quota $XFS_QUOTA_PROG -D $tmp.projects -P $tmp.projid -x \
Signature · 1 line
2.50.1
Re: [PATCH 2/3] generic/772: require filesystem to support file_[g|s]etattr
Quoted 15 lines · Andrey Albershteyn
Add _require_* function to check that filesystem support these syscalls on regular and special files.
Signed-off-by Andrey Albershteyn <[email protected]>--- common/rc | 32 ++++++++++++++++++++++++++++++++ tests/generic/772 | 5 ++--- tests/xfs/648 | 7 +++---- 3 files changed, 37 insertions(+), 7 deletions(-)common/rc +0
-0
common/rc _require_inplace_writes() · line 6001
Quoted 8 lines
common/rc +5
-0@@ -5994,6 +5994,38 @@ _require_inplace_writes() fi } +# Require filesystem to support file_getattr()/file_setattr() syscalls on +# regular files +_require_file_attr() +{ + local test_file="$SCRATCH_MNT/foo"
Should the test file be on $TEST_DIR so that you don't have an implicit dependency on _require_scratch?
Otherwise looks fine to me.
--D
Quoted 85 lines
common/rc +27
-0+ touch $test_file + + $here/src/file_attr --set --set-nodump $SCRATCH_MNT ./foo &>/dev/null + rc=$? + rm -f "$test_file" + + if [ $rc -ne 0 ]; then + _notrun "file_getattr not supported for regular files on $FSTYP" + fi +} + +# Require filesystem to support file_getattr()/file_setattr() syscalls on +# special files (chardev, fifo...) +_require_file_attr_special() +{ + local test_file="$SCRATCH_MNT/fifo" + mkfifo $test_file + + $here/src/file_attr --set --set-nodump $SCRATCH_MNT ./fifo &>/dev/null + rc=$? + rm -f "$test_file" + + if [ $rc -ne 0 ]; then + _notrun "file_getattr not supported for special files on $FSTYP" + fi +} + ################################################################################ # make sure this script returns success /bin/truetests/generic/772 +2
-3@@ -20,6 +20,8 @@ _require_mknod _scratch_mkfs >>$seqres.full 2>&1 _scratch_mount +_require_file_attr +_require_file_attr_special file_attr () { $here/src/file_attr $*@@ -43,9 +45,6 @@ touch $projectdir/bar ln -s $projectdir/bar $projectdir/broken-symlink rm -f $projectdir/bar -file_attr --get $projectdir ./fifo &>/dev/null || \ - _notrun "file_getattr not supported on $FSTYP" - echo "Error codes" # wrong AT_ flags file_attr --get --invalid-at $projectdir ./footests/xfs/648 +3
-4@@ -20,10 +20,12 @@ _require_test_program "af_unix" _require_test_program "file_attr" _require_symlinks _require_mknod - _scratch_mkfs >>$seqres.full 2>&1 _qmount_option "pquota" _scratch_mount +_require_file_attr +_require_file_attr_special + create_af_unix () { $here/src/af_unix $* || echo af_unix failed@@ -47,9 +49,6 @@ touch $projectdir/bar ln -s $projectdir/bar $projectdir/broken-symlink rm -f $projectdir/bar -$here/src/file_attr --get $projectdir ./fifo &>/dev/null || \ - _notrun "file_getattr not supported on $FSTYP" - $XFS_QUOTA_PROG -D $tmp.projects -P $tmp.projid -x \ -c "project -sp $projectdir $id" $SCRATCH_DEV | filter_quota $XFS_QUOTA_PROG -D $tmp.projects -P $tmp.projid -x \Signature · 1 line
2.50.1
Re: [PATCH 2/3] generic/772: require filesystem to support file_[g|s]etattr
Quoted 28 lines · Darrick J. Wong
Quoted 15 lines · Andrey Albershteyn
Add _require_* function to check that filesystem support these syscalls on regular and special files.
Signed-off-by Andrey Albershteyn <[email protected]>--- common/rc | 32 ++++++++++++++++++++++++++++++++ tests/generic/772 | 5 ++--- tests/xfs/648 | 7 +++---- 3 files changed, 37 insertions(+), 7 deletions(-)common/rc +0
-0common/rc _require_inplace_writes() · line 6001
Quoted 8 lines
common/rc +5
-0@@ -5994,6 +5994,38 @@ _require_inplace_writes() fi } +# Require filesystem to support file_getattr()/file_setattr() syscalls on +# regular files +_require_file_attr() +{ + local test_file="$SCRATCH_MNT/foo"Should the test file be on $TEST_DIR so that you don't have an implicit dependency on
_require_scratch?
Quoted 1 line
Otherwise looks fine to me.
Oh right, will send v2
Quoted 89 lines
--D
Quoted 85 lines
common/rc +27
-0+ touch $test_file + + $here/src/file_attr --set --set-nodump $SCRATCH_MNT ./foo &>/dev/null + rc=$? + rm -f "$test_file" + + if [ $rc -ne 0 ]; then + _notrun "file_getattr not supported for regular files on $FSTYP" + fi +} + +# Require filesystem to support file_getattr()/file_setattr() syscalls on +# special files (chardev, fifo...) +_require_file_attr_special() +{ + local test_file="$SCRATCH_MNT/fifo" + mkfifo $test_file + + $here/src/file_attr --set --set-nodump $SCRATCH_MNT ./fifo &>/dev/null + rc=$? + rm -f "$test_file" + + if [ $rc -ne 0 ]; then + _notrun "file_getattr not supported for special files on $FSTYP" + fi +} + ################################################################################ # make sure this script returns success /bin/truetests/generic/772 +2
-3@@ -20,6 +20,8 @@ _require_mknod _scratch_mkfs >>$seqres.full 2>&1 _scratch_mount +_require_file_attr +_require_file_attr_special file_attr () { $here/src/file_attr $*@@ -43,9 +45,6 @@ touch $projectdir/bar ln -s $projectdir/bar $projectdir/broken-symlink rm -f $projectdir/bar -file_attr --get $projectdir ./fifo &>/dev/null || \ - _notrun "file_getattr not supported on $FSTYP" - echo "Error codes" # wrong AT_ flags file_attr --get --invalid-at $projectdir ./footests/xfs/648 +3
-4@@ -20,10 +20,12 @@ _require_test_program "af_unix" _require_test_program "file_attr" _require_symlinks _require_mknod - _scratch_mkfs >>$seqres.full 2>&1 _qmount_option "pquota" _scratch_mount +_require_file_attr +_require_file_attr_special + create_af_unix () { $here/src/af_unix $* || echo af_unix failed@@ -47,9 +49,6 @@ touch $projectdir/bar ln -s $projectdir/bar $projectdir/broken-symlink rm -f $projectdir/bar -$here/src/file_attr --get $projectdir ./fifo &>/dev/null || \ - _notrun "file_getattr not supported on $FSTYP" - $XFS_QUOTA_PROG -D $tmp.projects -P $tmp.projid -x \ -c "project -sp $projectdir $id" $SCRATCH_DEV | filter_quota $XFS_QUOTA_PROG -D $tmp.projects -P $tmp.projid -x \Signature · 1 line
2.50.1
Signature · 1 line
- Andrey
PATCH 3/3 generic/772: split this test into 772 and 773 for regular and special files
In reply to Andrey AlbershteynNot all filesystem support setting file attributes on special files. The syscalls would still work for regular files. Let's split this test into two to make it obvious if only special files support is missing.
--- tests/generic/772 | 38 +------------------- tests/generic/772.out | 14 -------- tests/generic/773 | 84 +++++++++++++++++++++++++++++++++++++++++++ tests/generic/773.out | 20 +++++++++++ 4 files changed, 105 insertions(+), 51 deletions(-) create mode 100755 tests/generic/773 create mode 100644 tests/generic/773.out
tests/generic/772 +1 -37
@@ -4,7 +4,7 @@ # # FS QA Test No. 772 # -# Test file_getattr/file_setattr syscalls +# Test file_getattr() and file_setattr() syscalls on regular files # . ./common/preamble _begin_fstest auto
@@ -13,7 +13,6 @@ _begin_fstest auto # Modify as appropriate. _require_scratch -_require_test_program "af_unix" _require_test_program "file_attr" _require_symlinks _require_mknod
@@ -21,29 +20,16 @@ _require_mknod _scratch_mkfs >>$seqres.full 2>&1 _scratch_mount _require_file_attr -_require_file_attr_special file_attr () { $here/src/file_attr $* } -create_af_unix () { - $here/src/af_unix $* || echo af_unix failed -} - projectdir=$SCRATCH_MNT/prj # Create normal files and special files mkdir $projectdir -mkfifo $projectdir/fifo -mknod $projectdir/chardev c 1 1 -mknod $projectdir/blockdev b 1 1 -create_af_unix $projectdir/socket touch $projectdir/foo -ln -s $projectdir/foo $projectdir/symlink -touch $projectdir/bar -ln -s $projectdir/bar $projectdir/broken-symlink -rm -f $projectdir/bar echo "Error codes" # wrong AT_ flags
@@ -59,37 +45,15 @@ file_attr --set --new-fsx-flag $projectdir ./foo echo "Initial attributes state" file_attr --get $projectdir | _filter_scratch | _filter_file_attributes ~d -file_attr --get $projectdir ./fifo | _filter_file_attributes ~d -file_attr --get $projectdir ./chardev | _filter_file_attributes ~d -file_attr --get $projectdir ./blockdev | _filter_file_attributes ~d -file_attr --get $projectdir ./socket | _filter_file_attributes ~d file_attr --get $projectdir ./foo | _filter_file_attributes ~d -file_attr --get $projectdir ./symlink | _filter_file_attributes ~d echo "Set FS_XFLAG_NODUMP (d)" file_attr --set --set-nodump $projectdir -file_attr --set --set-nodump $projectdir ./fifo -file_attr --set --set-nodump $projectdir ./chardev -file_attr --set --set-nodump $projectdir ./blockdev -file_attr --set --set-nodump $projectdir ./socket file_attr --set --set-nodump $projectdir ./foo -file_attr --set --set-nodump $projectdir ./symlink echo "Read attributes" file_attr --get $projectdir | _filter_scratch | _filter_file_attributes ~d -file_attr --get $projectdir ./fifo | _filter_file_attributes ~d -file_attr --get $projectdir ./chardev | _filter_file_attributes ~d -file_attr --get $projectdir ./blockdev | _filter_file_attributes ~d -file_attr --get $projectdir ./socket | _filter_file_attributes ~d file_attr --get $projectdir ./foo | _filter_file_attributes ~d -file_attr --get $projectdir ./symlink | _filter_file_attributes ~d - -echo "Set attribute on broken link with AT_SYMLINK_NOFOLLOW" -file_attr --set --set-nodump $projectdir ./broken-symlink -file_attr --get $projectdir ./broken-symlink - -file_attr --set --no-follow --set-nodump $projectdir ./broken-symlink -file_attr --get --no-follow $projectdir ./broken-symlink | _filter_file_attributes ~d cd $SCRATCH_MNT touch ./foo2
tests/generic/772.out +0 -14
@@ -9,25 +9,11 @@ Can not get fsxattr on ./foo: Invalid argument Can not set fsxattr on ./foo: Invalid argument Initial attributes state ----------------- SCRATCH_MNT/prj ------------------ ./fifo ------------------ ./chardev ------------------ ./blockdev ------------------ ./socket ----------------- ./foo ------------------ ./symlink Set FS_XFLAG_NODUMP (d) Read attributes ------d---------- SCRATCH_MNT/prj -------d---------- ./fifo -------d---------- ./chardev -------d---------- ./blockdev -------d---------- ./socket ------d---------- ./foo -------d---------- ./symlink -Set attribute on broken link with AT_SYMLINK_NOFOLLOW -Can not get fsxattr on ./broken-symlink: No such file or directory -Can not get fsxattr on ./broken-symlink: No such file or directory -------d---------- ./broken-symlink Initial state of foo2 ----------------- ./foo2 Set attribute relative to AT_FDCWD
tests/generic/773 new file +84 -0
84 lines not on this page · raw message
tests/generic/773.out new file +20 -0
@@ -0,0 +1,20 @@ +QA output created by 773 +Initial attributes state +----------------- SCRATCH_MNT/prj +----------------- ./fifo +----------------- ./chardev +----------------- ./blockdev +----------------- ./socket +----------------- ./symlink +Set FS_XFLAG_NODUMP (d) +Read attributes +------d---------- SCRATCH_MNT/prj +------d---------- ./fifo +------d---------- ./chardev +------d---------- ./blockdev +------d---------- ./socket +------d---------- ./symlink +Set attribute on broken link with AT_SYMLINK_NOFOLLOW +Can not get fsxattr on ./broken-symlink: No such file or directory +Can not get fsxattr on ./broken-symlink: No such file or directory +------d---------- ./broken-symlink
Signature · 1 line
2.50.1
Re: [PATCH 3/3] generic/772: split this test into 772 and 773 for regular and special files
Quoted 5 lines · Andrey Albershteyn
Not all filesystem support setting file attributes on special files. The syscalls would still work for regular files. Let's split this test into two to make it obvious if only special files support is missing.
Signed-off-by Andrey Albershteyn <[email protected]>
Looks fine to me,
--D
Quoted 248 lines
--- tests/generic/772 | 38 +------------------- tests/generic/772.out | 14 -------- tests/generic/773 | 84 +++++++++++++++++++++++++++++++++++++++++++ tests/generic/773.out | 20 +++++++++++ 4 files changed, 105 insertions(+), 51 deletions(-) create mode 100755 tests/generic/773 create mode 100644 tests/generic/773.outtests/generic/772 +1
-37@@ -4,7 +4,7 @@ # # FS QA Test No. 772 # -# Test file_getattr/file_setattr syscalls +# Test file_getattr() and file_setattr() syscalls on regular files # . ./common/preamble _begin_fstest auto@@ -13,7 +13,6 @@ _begin_fstest auto # Modify as appropriate. _require_scratch -_require_test_program "af_unix" _require_test_program "file_attr" _require_symlinks _require_mknod@@ -21,29 +20,16 @@ _require_mknod _scratch_mkfs >>$seqres.full 2>&1 _scratch_mount _require_file_attr -_require_file_attr_special file_attr () { $here/src/file_attr $* } -create_af_unix () { - $here/src/af_unix $* || echo af_unix failed -} - projectdir=$SCRATCH_MNT/prj # Create normal files and special files mkdir $projectdir -mkfifo $projectdir/fifo -mknod $projectdir/chardev c 1 1 -mknod $projectdir/blockdev b 1 1 -create_af_unix $projectdir/socket touch $projectdir/foo -ln -s $projectdir/foo $projectdir/symlink -touch $projectdir/bar -ln -s $projectdir/bar $projectdir/broken-symlink -rm -f $projectdir/bar echo "Error codes" # wrong AT_ flags@@ -59,37 +45,15 @@ file_attr --set --new-fsx-flag $projectdir ./foo echo "Initial attributes state" file_attr --get $projectdir | _filter_scratch | _filter_file_attributes ~d -file_attr --get $projectdir ./fifo | _filter_file_attributes ~d -file_attr --get $projectdir ./chardev | _filter_file_attributes ~d -file_attr --get $projectdir ./blockdev | _filter_file_attributes ~d -file_attr --get $projectdir ./socket | _filter_file_attributes ~d file_attr --get $projectdir ./foo | _filter_file_attributes ~d -file_attr --get $projectdir ./symlink | _filter_file_attributes ~d echo "Set FS_XFLAG_NODUMP (d)" file_attr --set --set-nodump $projectdir -file_attr --set --set-nodump $projectdir ./fifo -file_attr --set --set-nodump $projectdir ./chardev -file_attr --set --set-nodump $projectdir ./blockdev -file_attr --set --set-nodump $projectdir ./socket file_attr --set --set-nodump $projectdir ./foo -file_attr --set --set-nodump $projectdir ./symlink echo "Read attributes" file_attr --get $projectdir | _filter_scratch | _filter_file_attributes ~d -file_attr --get $projectdir ./fifo | _filter_file_attributes ~d -file_attr --get $projectdir ./chardev | _filter_file_attributes ~d -file_attr --get $projectdir ./blockdev | _filter_file_attributes ~d -file_attr --get $projectdir ./socket | _filter_file_attributes ~d file_attr --get $projectdir ./foo | _filter_file_attributes ~d -file_attr --get $projectdir ./symlink | _filter_file_attributes ~d - -echo "Set attribute on broken link with AT_SYMLINK_NOFOLLOW" -file_attr --set --set-nodump $projectdir ./broken-symlink -file_attr --get $projectdir ./broken-symlink - -file_attr --set --no-follow --set-nodump $projectdir ./broken-symlink -file_attr --get --no-follow $projectdir ./broken-symlink | _filter_file_attributes ~d cd $SCRATCH_MNT touch ./foo2tests/generic/772.out +0
-14@@ -9,25 +9,11 @@ Can not get fsxattr on ./foo: Invalid argument Can not set fsxattr on ./foo: Invalid argument Initial attributes state ----------------- SCRATCH_MNT/prj ------------------ ./fifo ------------------ ./chardev ------------------ ./blockdev ------------------ ./socket ----------------- ./foo ------------------ ./symlink Set FS_XFLAG_NODUMP (d) Read attributes ------d---------- SCRATCH_MNT/prj -------d---------- ./fifo -------d---------- ./chardev -------d---------- ./blockdev -------d---------- ./socket ------d---------- ./foo -------d---------- ./symlink -Set attribute on broken link with AT_SYMLINK_NOFOLLOW -Can not get fsxattr on ./broken-symlink: No such file or directory -Can not get fsxattr on ./broken-symlink: No such file or directory -------d---------- ./broken-symlink Initial state of foo2 ----------------- ./foo2 Set attribute relative to AT_FDCWDtests/generic/773 new file +84
-0@@ -0,0 +1,84 @@ +#! /bin/bash +# SPDX-License-Identifier: GPL-2.0 +# Copyright (c) 2025 Red Hat. All Rights Reserved. +# +# FS QA Test 773 +# +# Test file_getattr() and file_setattr() syscalls on special files (fifo, +# socket, chardev...) +# +. ./common/preamble +_begin_fstest quick + +# Import common functions. +. ./common/filter + +# Modify as appropriate. +_require_scratch +_require_test_program "af_unix" +_require_test_program "file_attr" +_require_symlinks +_require_mknod +_scratch_mkfs >>$seqres.full 2>&1 +_scratch_mount +_require_file_attr_special + +file_attr () { + $here/src/file_attr $* +} + +create_af_unix () { + $here/src/af_unix $* || echo af_unix failed +} + +projectdir=$SCRATCH_MNT/prj + +# Create normal files and special files +mkdir $projectdir +mkfifo $projectdir/fifo +mknod $projectdir/chardev c 1 1 +mknod $projectdir/blockdev b 1 1 +create_af_unix $projectdir/socket +touch $projectdir/foo +ln -s $projectdir/foo $projectdir/symlink +touch $projectdir/bar +ln -s $projectdir/bar $projectdir/broken-symlink +rm -f $projectdir/bar + +echo "Initial attributes state" +file_attr --get $projectdir | _filter_scratch | _filter_file_attributes ~d +file_attr --get $projectdir ./fifo | _filter_file_attributes ~d +file_attr --get $projectdir ./chardev | _filter_file_attributes ~d +file_attr --get $projectdir ./blockdev | _filter_file_attributes ~d +file_attr --get $projectdir ./socket | _filter_file_attributes ~d +file_attr --get $projectdir ./symlink | _filter_file_attributes ~d + +echo "Set FS_XFLAG_NODUMP (d)" +file_attr --set --set-nodump $projectdir +file_attr --set --set-nodump $projectdir ./fifo +file_attr --set --set-nodump $projectdir ./chardev +file_attr --set --set-nodump $projectdir ./blockdev +file_attr --set --set-nodump $projectdir ./socket +file_attr --set --set-nodump $projectdir ./symlink + +echo "Read attributes" +file_attr --get $projectdir | _filter_scratch | _filter_file_attributes ~d +file_attr --get $projectdir ./fifo | _filter_file_attributes ~d +file_attr --get $projectdir ./chardev | _filter_file_attributes ~d +file_attr --get $projectdir ./blockdev | _filter_file_attributes ~d +file_attr --get $projectdir ./socket | _filter_file_attributes ~d +file_attr --get $projectdir ./symlink | _filter_file_attributes ~d + +echo "Set attribute on broken link with AT_SYMLINK_NOFOLLOW" +file_attr --set --set-nodump $projectdir ./broken-symlink +file_attr --get $projectdir ./broken-symlink + +file_attr --set --no-follow --set-nodump $projectdir ./broken-symlink +file_attr --get --no-follow $projectdir ./broken-symlink | _filter_file_attributes ~d + +# optional stuff if your test has verbose output to help resolve problems +#echo +#echo "If failure, check $seqres.full (this) and $seqres.full.ok (reference)" + +# success, all done +_exit 0tests/generic/773.out new file +20
-0@@ -0,0 +1,20 @@ +QA output created by 773 +Initial attributes state +----------------- SCRATCH_MNT/prj +----------------- ./fifo +----------------- ./chardev +----------------- ./blockdev +----------------- ./socket +----------------- ./symlink +Set FS_XFLAG_NODUMP (d) +Read attributes +------d---------- SCRATCH_MNT/prj +------d---------- ./fifo +------d---------- ./chardev +------d---------- ./blockdev +------d---------- ./socket +------d---------- ./symlink +Set attribute on broken link with AT_SYMLINK_NOFOLLOW +Can not get fsxattr on ./broken-symlink: No such file or directory +Can not get fsxattr on ./broken-symlink: No such file or directory +------d---------- ./broken-symlinkSignature · 1 line
2.50.1