clk: qcom: gcc: Update the SDCC clock to use shared_floor_ops
Subsystems (3)
PATCH v2 1/1 clk: qcom: gcc: Update the SDCC clock to use shared_floor_ops
Fix "gcc_sdcc2_apps_clk_src: rcg didn't update its configuration" during boot. This happens due to the floor_ops tries to update the rcg configuration even if the clock is not enabled.
The shared_floor_ops ensures that the RCG is safely parked and the new parent configuration is cached in the parked_cfg when the clock is off.
Ensure to use the ops for the other SDCC clock instances as well.
---
Changes in v2:
- EDITME: describe what is new in this series revision.
- EDITME: use bulletpoints and terse descriptions.
- Link to v1: https://lore.kernel.org/r/[email protected]
--- drivers/clk/qcom/gcc-qcs615.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/clk/qcom/gcc-qcs615.c +3 -3
@@ -784,7 +784,7 @@ static struct clk_rcg2 gcc_sdcc1_apps_clk_src = { .name = "gcc_sdcc1_apps_clk_src", .parent_data = gcc_parent_data_1, .num_parents = ARRAY_SIZE(gcc_parent_data_1), - .ops = &clk_rcg2_floor_ops, + .ops = &clk_rcg2_shared_floor_ops, }, };
@@ -806,7 +806,7 @@ static struct clk_rcg2 gcc_sdcc1_ice_core_clk_src = { .name = "gcc_sdcc1_ice_core_clk_src", .parent_data = gcc_parent_data_0, .num_parents = ARRAY_SIZE(gcc_parent_data_0), - .ops = &clk_rcg2_floor_ops, + .ops = &clk_rcg2_shared_floor_ops, }, };
@@ -830,7 +830,7 @@ static struct clk_rcg2 gcc_sdcc2_apps_clk_src = { .name = "gcc_sdcc2_apps_clk_src", .parent_data = gcc_parent_data_8, .num_parents = ARRAY_SIZE(gcc_parent_data_8), - .ops = &clk_rcg2_floor_ops, + .ops = &clk_rcg2_shared_floor_ops, }, };
---
base-commit: 5c5a10f0be967a8950a2309ea965bae54251b50e
change-id: 20250804-sdcc_rcg2_shared_ops-ea6e26185fe6
Best regards,
Signature · 1 line
Taniya Das <[email protected]>
Quoted 6 lines · Taniya Das
Fix "
gcc_sdcc2_apps_clk_src: rcg didn't update its configuration" during boot. This happens due to thefloor_opstries to update the rcg configuration even if the clock is not enabled.
Theshared_floor_opsensures that the RCG is safely parked and the new parent configuration is cached in theparked_cfgwhen the clock is off.
Quoted 8 lines
Ensure to use the ops for the other SDCC clock instances as well.
Fixes 39d6dcf67fe9 ("clk: qcom: gcc: Add support for QCS615 GCC clocks")Signed-off-by Taniya Das <[email protected]>---
Changes in v2:
- EDITME: describe what is new in this series revision.
- EDITME: use bulletpoints and terse descriptions.
:(
The subject also needs to be 'gcc': -> 'gcc-qcs615:'
Konrad
Quoted 16 lines · Konrad Dybcio
Quoted 6 lines · Taniya Das
Fix "
gcc_sdcc2_apps_clk_src: rcg didn't update its configuration" during boot. This happens due to thefloor_opstries to update the rcg configuration even if the clock is not enabled.
Theshared_floor_opsensures that the RCG is safely parked and the new parent configuration is cached in theparked_cfgwhen the clock is off.Quoted 8 lines
Ensure to use the ops for the other SDCC clock instances as well.
Fixes 39d6dcf67fe9 ("clk: qcom: gcc: Add support for QCS615 GCC clocks")Signed-off-by Taniya Das <[email protected]>---
Changes in v2:
- EDITME: describe what is new in this series revision.
- EDITME: use bulletpoints and terse descriptions.
Quoted 4 lines
:(
The subject also needs to be 'gcc': -> 'gcc-qcs615:'
:( my bad. Sure, I will update the subject as well.
Signature · 2 lines
Thanks, Taniya Das
Quoted 10 lines · Taniya Das
Fix "
gcc_sdcc2_apps_clk_src: rcg didn't update its configuration" during boot. This happens due to thefloor_opstries to update the rcg configuration even if the clock is not enabled.
Theshared_floor_opsensures that the RCG is safely parked and the new parent configuration is cached in theparked_cfgwhen the clock is off.Ensure to use the ops for the other SDCC clock instances as well.
Fixes 39d6dcf67fe9 ("clk: qcom: gcc: Add support for QCS615 GCC clocks")Signed-off-by Taniya Das <[email protected]>