isofs: Add ISO9660 kernel config requirement
PATCH 1/1 isofs: Add ISO9660 kernel config requirement
The isofs test requires ISO9660 filesystem support to test mounting and accessing ISO images. Without CONFIG_ISO9660_FS enabled, the test fails with "unknown filesystem type 'iso9660'" errors during mount attempts, resulting in 140 failed test cases.
Add the CONFIG_ISO9660_FS kernel configuration requirement to ensure the test properly skips with TCONF on systems without ISO9660 support, either built-in or as a module.
--- testcases/kernel/fs/iso9660/isofs.sh | 1 + 1 file changed, 1 insertion(+)
testcases/kernel/fs/iso9660/isofs.sh +1 -0
@@ -11,6 +11,7 @@ TST_NEEDS_CMDS="mount umount" TST_NEEDS_TMPDIR=1 +TST_NEEDS_KCONFIGS="CONFIG_ISO9660_FS=y | CONFIG_ISO9660_FS=m" TST_TESTFUNC=do_test TST_CNT=3 TST_SETUP="setup"
Signature · 5 lines
2.51.0 -- Mailing list info: https://lists.linux.it/listinfo/ltp
Hi Anders,
Quoted 19 lines
The isofs test requires ISO9660 filesystem support to test mounting and accessing ISO images. Without
CONFIG_ISO9660_FSenabled, the test fails with "unknown filesystem type 'iso9660'" errors during mount attempts, resulting in 140 failed test cases.Add the
CONFIG_ISO9660_FSkernel configuration requirement to ensure the test properly skips with TCONF on systems without ISO9660 support, either built-in or as a module.Signed-off-by Anders Roxell <[email protected]>--- testcases/kernel/fs/iso9660/isofs.sh | 1 + 1 file changed, 1 insertion(+)testcases/kernel/fs/iso9660/isofs.sh +0
-0
testcases/kernel/fs/iso9660/isofs.sh line 14
Quoted 4 lines
testcases/kernel/fs/iso9660/isofs.sh +1
-0@@ -11,6 +11,7 @@ TST_NEEDS_CMDS="mount umount" TST_NEEDS_TMPDIR=1 +TST_NEEDS_KCONFIGS="CONFIG_ISO9660_FS=y | CONFIG_ISO9660_FS=m"
LGTM
Kind regards,
Petr
Quoted 3 lines
testcases/kernel/fs/iso9660/isofs.sh +0
-0TST_TESTFUNC=do_test TST_CNT=3 TST_SETUP="setup"
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
Hi!
Quoted 3 lines
TST_NEEDS_CMDS="mount umount"
TST_NEEDS_TMPDIR=1
+TST_NEEDS_KCONFIGS="CONFIG_ISO9660_FS=y |CONFIG_ISO9660_FS=m"
If you add just TST_NEEDS_KCONFIGS="CONFIG_ISO9660_FS" it will match both =y and =m I've added this shortcut to the library so that we do not need to write it as you did above.
Quoted 6 lines
TST_TESTFUNC=do_test
TST_CNT=3
TST_SETUP="setup"Signature · 1 line
2.51.0
Signature · 5 lines
Cyril Hrubis [email protected] -- Mailing list info: https://lists.linux.it/listinfo/ltp
Quoted 9 lines · Cyril Hrubis
Hi!
Quoted 3 lines
TST_NEEDS_CMDS="mount umount"
TST_NEEDS_TMPDIR=1
+TST_NEEDS_KCONFIGS="CONFIG_ISO9660_FS=y |CONFIG_ISO9660_FS=m"If you add just TST_NEEDS_KCONFIGS="CONFIG_ISO9660_FS" it will match both =y and =m I've added this shortcut to the library so that we do not need to write it as you did above.
Oh great, I didn't know. I'll send a v2 shortly.
Cheers,
Anders
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
Quoted 8 lines
Hi!
Quoted 3 lines
TST_NEEDS_CMDS="mount umount"
TST_NEEDS_TMPDIR=1
+TST_NEEDS_KCONFIGS="CONFIG_ISO9660_FS=y |CONFIG_ISO9660_FS=m"If you add just TST_NEEDS_KCONFIGS="CONFIG_ISO9660_FS" it will match both =y and =m I've added this shortcut to the library so that we do not need to write it as you did above.
Thanks for catching this, Cyril!
Kind regards,
Petr
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp