arm64: dts: rockchip: Fix audio-supply for ROCK Pi 4
Subsystems (2)
PATCH 1/1 arm64: dts: rockchip: Fix audio-supply for ROCK Pi 4
This reverts commit 8240e87f16d17 ("arm64: dts: rockchip: fix audio-supply for Rock Pi 4").
Fix the APIO5_VDD power supply to vcc_3v0 as per the schematics[1][2] [3][4][5].
This fixes the SPI-NOR flash probe failure when the blue LED is on[6], and the garbled serial console output on Linux.
The ES8316 headphone and microphone are confirmed to work correctly after this fix.
[1] https://dl.radxa.com/rockpi4/docs/hw/rockpi4/4a/ROCK_4A_V1.52_SCH.pdf p.14
[2] https://dl.radxa.com/rockpi4/docs/hw/rockpi4/4ap/radxa_rock_4ap_v1730_schematic.pdf p.14
[3] https://dl.radxa.com/rockpi4/docs/hw/rockpi4/4b/ROCK_4B_v1.52_SCH.pdf p.14
[4] https://dl.radxa.com/rockpi4/docs/hw/rockpi4/4bp/radxa_rock_4bp_v1730_schematic.pdf p.14
[5] https://dl.radxa.com/rockpi4/docs/hw/rockpi4/ROCK-4-SE-V1.53-SCH.pdf p.14
[6]
=> led blue:status off
=> sf probe
SF: Detected w25q128 with page size 256 Bytes, erase size 4 KiB, total 16 MiB => led blue:status on
=> sf probejedec_spi_nor flash@0: unrecognized JEDEC id bytes: ff, ff, ff Failed to initialize SPI flash at 1:0 (error -2)
--- arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi +1 -1
@@ -516,7 +516,7 @@ &i2s2 { }; &io_domains { - audio-supply = <&vcca1v8_codec>; + audio-supply = <&vcc_3v0>; bt656-supply = <&vcc_3v0>; gpio1830-supply = <&vcc_3v0>; sdmmc-supply = <&vcc_sdio>;
Signature · 7 lines
2.43.0 _______________________________________________ Linux-rockchip mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-rockchip
Hi Naoki,
Quoted 27 lines · FUKAUMI Naoki
This reverts commit
8240e87f16d17("arm64: dts: rockchip: fix audio-supply for Rock Pi 4").Fix the
APIO5_VDDpower supply tovcc_3v0as per the schematics[1][2] [3][4][5].This fixes the SPI-NOR flash probe failure when the blue LED is on[6], and the garbled serial console output on Linux.
The ES8316 headphone and microphone are confirmed to work correctly after this fix.
[1] https://dl.radxa.com/rockpi4/docs/hw/rockpi4/4a/ROCK_4A_V1.52_SCH.pdf p.14
[2] https://dl.radxa.com/rockpi4/docs/hw/rockpi4/4ap/radxa_rock_4ap_v1730_schematic.pdf p.14
[3] https://dl.radxa.com/rockpi4/docs/hw/rockpi4/4b/ROCK_4B_v1.52_SCH.pdf p.14
[4] https://dl.radxa.com/rockpi4/docs/hw/rockpi4/4bp/radxa_rock_4bp_v1730_schematic.pdf p.14
[5] https://dl.radxa.com/rockpi4/docs/hw/rockpi4/ROCK-4-SE-V1.53-SCH.pdf p.14[6]
=> led blue:status off
=> sf probe
SF: Detected w25q128 with page size 256 Bytes, erase size 4 KiB, total 16 MiB => led blue:status on
=> sf probejedec_spi_norflash@0: unrecognized JEDEC id bytes: ff, ff, ff Failed to initialize SPI flash at 1:0 (error -2)
Quoted 3 lines
Fixes 7ebfd4f6b52a6 ("arm64: dts: rockchip: add LED for ROCK Pi 4A/B/C/A+/B+")Fixes 8240e87f16d17 ("arm64: dts: rockchip: fix audio-supply for Rock Pi 4")Signed-off-by FUKAUMI Naoki <[email protected]>
I came to the same conclusion in https://lore.kernel.org/linux-rockchip/[email protected]/ (thanks Jonas for letting me know, should have checked before sending the revert :/), so
+Cc Heinrich who reported[1] a bug in U-Boot this patch fixes so they can give their Tested-by/Reviewed-by if they want to.
[1] https://lore.kernel.org/u-boot/[email protected]/
Thanks,
Quentin
Hi Naoki,
Quoted 15 lines · Quentin Schulz
Hi Naoki,
Quoted 12 lines · FUKAUMI Naoki
This reverts commit
8240e87f16d17("arm64: dts: rockchip: fix audio-supply for Rock Pi 4").Fix the
APIO5_VDDpower supply tovcc_3v0as per the schematics[1][2] [3][4][5].This fixes the SPI-NOR flash probe failure when the blue LED is on[6], and the garbled serial console output on Linux.
The ES8316 headphone and microphone are confirmed to work correctly after this fix.
Please test the ES8316 works when booting Linux from a U-Boot where ROCKCHIP_IODOMAIN and SPL_ROCKCHIP_IODOMAIN is *disabled*.
Having the IO domain properly configured from U-Boot may make you think that the ES8316 always work in the Linux kernel but that may not be the case depending on probe order e.g. between the IO domain driver in Linux and the ES8316 (if the original issue is indeed related to IO domain).
Cheers,
Quentin
Hi Quentin,
Quoted 12 lines · Quentin Schulz
Hi Naoki,
Quoted 9 lines · Quentin Schulz
Hi Naoki,
Quoted 6 lines · FUKAUMI Naoki
This reverts commit
8240e87f16d17("arm64: dts: rockchip: fix audio-supply for Rock Pi 4").Fix the
APIO5_VDDpower supply tovcc_3v0as per the schematics[1][2] [3][4][5].
Quoted 8 lines
Quoted 6 lines
Quoted 6 lines
This fixes the SPI-NOR flash probe failure when the blue LED is on[6], and the garbled serial console output on Linux.
The ES8316 headphone and microphone are confirmed to work correctly after this fix.
Please test the ES8316 works when booting Linux from a U-Boot where
ROCKCHIP_IODOMAINandSPL_ROCKCHIP_IODOMAINis *disabled*.
I tried below, and confirmed that ES8316 is still working.
configs/rock-pi-4-rk3399_defconfig +1 -0
@@ -53,6 +53,7 @@ CONFIG_ROCKCHIP_GPIO=y CONFIG_SYS_I2C_ROCKCHIP=y CONFIG_LED=y CONFIG_LED_GPIO=y +# CONFIG_ROCKCHIP_IODOMAIN is not set CONFIG_MMC_DW=y CONFIG_MMC_DW_ROCKCHIP=y CONFIG_MMC_SDHCI=y
dts/upstream/src/arm64/rockchip/rk3399-rock-pi-4.dtsi +2 -2
@@ -51,7 +51,7 @@ sound: sound { compatible = "audio-graph-card"; - label = "Analog"; + label = "rk3588-es8316"; dais = <&i2s0_p0>; };
@@ -516,7 +516,7 @@ }; &io_domains { - audio-supply = <&vcca1v8_codec>; + audio-supply = <&vcc_3v0>; bt656-supply = <&vcc_3v0>; gpio1830-supply = <&vcc_3v0>; sdmmc-supply = <&vcc_sdio>;
Notes:
- SPL_ROCKCHIP_IODOMAIN is not set by default
- I don't understand alsa ucm2 ;) so I modified /sound/label
Best regards,
--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.
Quoted 5 lines
Having the IO domain properly configured from U-Boot may make you think that the ES8316 always work in the Linux kernel but that may not be the case depending on probe order e.g. between the IO domain driver in Linux and the ES8316 (if the original issue is indeed related to IO domain).
Cheers,
Quentin
_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip
Hi Naoki,
Quoted 61 lines · FUKAUMI Naoki
Hi Quentin,
Quoted 12 lines · Quentin Schulz
Hi Naoki,
Quoted 9 lines · Quentin Schulz
Hi Naoki,
Quoted 6 lines · FUKAUMI Naoki
This reverts commit
8240e87f16d17("arm64: dts: rockchip: fix audio-supply for Rock Pi 4").Fix the
APIO5_VDDpower supply tovcc_3v0as per the schematics[1][2] [3][4][5].Quoted 8 lines
Quoted 6 lines
Quoted 6 lines
This fixes the SPI-NOR flash probe failure when the blue LED is on[6], and the garbled serial console output on Linux.
The ES8316 headphone and microphone are confirmed to work correctly after this fix.
Please test the ES8316 works when booting Linux from a U-Boot where
ROCKCHIP_IODOMAINandSPL_ROCKCHIP_IODOMAINis *disabled*.I tried below, and confirmed that ES8316 is still working.
configs/rock-pi-4-rk3399_defconfig +1
-0@@ -53,6 +53,7 @@ CONFIG_ROCKCHIP_GPIO=y CONFIG_SYS_I2C_ROCKCHIP=y CONFIG_LED=y CONFIG_LED_GPIO=y +# CONFIG_ROCKCHIP_IODOMAIN is not set CONFIG_MMC_DW=y CONFIG_MMC_DW_ROCKCHIP=y CONFIG_MMC_SDHCI=ydts/upstream/src/arm64/rockchip/rk3399-rock-pi-4.dtsi +2
-2@@ -51,7 +51,7 @@ sound: sound { compatible = "audio-graph-card"; - label = "Analog"; + label = "rk3588-es8316"; dais = <&i2s0_p0>; };@@ -516,7 +516,7 @@ }; &io_domains { - audio-supply = <&vcca1v8_codec>; + audio-supply = <&vcc_3v0>; bt656-supply = <&vcc_3v0>; gpio1830-supply = <&vcc_3v0>; sdmmc-supply = <&vcc_sdio>;
Quoted 4 lines
Notes:
-SPL_ROCKCHIP_IODOMAINis not set by default
- I don't understand alsa ucm2 ;) so I modified /sound/label
Thanks for testing. Let's hope the original issue doesn't appear for *some* boots (depending on probe order or some timing for example). For now I guess this will do. Adding Alex in Cc maybe they are able to reproduce the issue they had 4 years ago with their board?
Cheers,
Quentin
Hi,
Am 28.11.25 um 13:33 schrieb Quentin Schulz:
Quoted 71 lines
Hi Naoki,
Quoted 61 lines · FUKAUMI Naoki
Hi Quentin,
Quoted 12 lines · Quentin Schulz
Hi Naoki,
Quoted 9 lines · Quentin Schulz
Hi Naoki,
Quoted 6 lines · FUKAUMI Naoki
This reverts commit
8240e87f16d17("arm64: dts: rockchip: fix audio-supply for Rock Pi 4").Fix the
APIO5_VDDpower supply tovcc_3v0as per the schematics[1][2] [3][4][5].Quoted 8 lines
Quoted 6 lines
Quoted 6 lines
This fixes the SPI-NOR flash probe failure when the blue LED is on[6], and the garbled serial console output on Linux.
The ES8316 headphone and microphone are confirmed to work correctly after this fix.
Please test the ES8316 works when booting Linux from a U-Boot where
ROCKCHIP_IODOMAINandSPL_ROCKCHIP_IODOMAINis *disabled*.I tried below, and confirmed that ES8316 is still working.
configs/rock-pi-4-rk3399_defconfig +0
-0@@ -53,6 +53,7 @@ CONFIG_ROCKCHIP_GPIO=yCONFIG_SYS_I2C_ROCKCHIP=y
CONFIG_LED=y
CONFIG_LED_GPIO=y
+#CONFIG_ROCKCHIP_IODOMAINis not set
CONFIG_MMC_DW=y
CONFIG_MMC_DW_ROCKCHIP=y
CONFIG_MMC_SDHCI=ydts/upstream/src/arm64/rockchip/rk3399-rock-pi-4.dtsi +2
-2@@ -51,7 +51,7 @@ sound: sound { compatible = "audio-graph-card"; - label = "Analog"; + label = "rk3588-es8316"; dais = <&i2s0_p0>; };@@ -516,7 +516,7 @@ }; &io_domains { - audio-supply = <&vcca1v8_codec>; + audio-supply = <&vcc_3v0>; bt656-supply = <&vcc_3v0>; gpio1830-supply = <&vcc_3v0>; sdmmc-supply = <&vcc_sdio>;Quoted 4 lines
Notes:
-SPL_ROCKCHIP_IODOMAINis not set by default
- I don't understand alsa ucm2 ;) so I modified /sound/labelThanks for testing. Let's hope the original issue doesn't appear for *some* boots (depending on probe order or some timing for example). For now I guess this will do. Adding Alex in Cc maybe they are able to reproduce the issue they had 4 years ago with their board?
Quoted 2 lines
Cheers,
Quentin
I can confirm that with this change analog audio is _broken_ for me again.
I never had any issues with uart2 or spi - neither in kernel nor in u-boot (also not after io-domain driver has been added to u-boot for RK3399). Given this commit is now ~4 years in tree I'd guess that someone else would have reported that issue earlier. It's correct that this information came from a "Power Domain Map" which you call "non schematic" and the "schematic part" says something else - it would have been indeed be better to have clearer information.
Anyway: I can't neither see how this change should relate to uart2 or spi which are both in different io-domain, nor why it would happen only in u-boot. My strongest guess is, that radxa changed something along the way. Or maybe it would be worth to double-check the io-domain driver in u-boot.
Regards,
Alex
Hi Alex,
Quoted 80 lines · Alex Bee
Hi,
Am 28.11.25 um 13:33 schrieb Quentin Schulz:
Quoted 71 lines
Hi Naoki,
Quoted 61 lines · FUKAUMI Naoki
Hi Quentin,
Quoted 12 lines · Quentin Schulz
Hi Naoki,
Quoted 9 lines · Quentin Schulz
Hi Naoki,
Quoted 6 lines · FUKAUMI Naoki
This reverts commit
8240e87f16d17("arm64: dts: rockchip: fix audio-supply for Rock Pi 4").Fix the
APIO5_VDDpower supply tovcc_3v0as per the schematics[1][2] [3][4][5].Quoted 8 lines
Quoted 6 lines
Quoted 6 lines
This fixes the SPI-NOR flash probe failure when the blue LED is on[6], and the garbled serial console output on Linux.
The ES8316 headphone and microphone are confirmed to work correctly after this fix.
Please test the ES8316 works when booting Linux from a U-Boot where
ROCKCHIP_IODOMAINandSPL_ROCKCHIP_IODOMAINis *disabled*.I tried below, and confirmed that ES8316 is still working.
configs/rock-pi-4-rk3399_defconfig +0
-0@@ -53,6 +53,7 @@ CONFIG_ROCKCHIP_GPIO=yCONFIG_SYS_I2C_ROCKCHIP=y
CONFIG_LED=y
CONFIG_LED_GPIO=y
+#CONFIG_ROCKCHIP_IODOMAINis not set
CONFIG_MMC_DW=y
CONFIG_MMC_DW_ROCKCHIP=y
CONFIG_MMC_SDHCI=ydts/upstream/src/arm64/rockchip/rk3399-rock-pi-4.dtsi +2
-2@@ -51,7 +51,7 @@ sound: sound { compatible = "audio-graph-card"; - label = "Analog"; + label = "rk3588-es8316"; dais = <&i2s0_p0>; };@@ -516,7 +516,7 @@ }; &io_domains { - audio-supply = <&vcca1v8_codec>; + audio-supply = <&vcc_3v0>; bt656-supply = <&vcc_3v0>; gpio1830-supply = <&vcc_3v0>; sdmmc-supply = <&vcc_sdio>;Quoted 4 lines
Notes:
-SPL_ROCKCHIP_IODOMAINis not set by default
- I don't understand alsa ucm2 ;) so I modified /sound/labelThanks for testing. Let's hope the original issue doesn't appear for *some* boots (depending on probe order or some timing for example). For now I guess this will do. Adding Alex in Cc maybe they are able to reproduce the issue they had 4 years ago with their board?
Quoted 2 lines
Cheers,
QuentinI can confirm that with this change analog audio is _broken_ for me again.
Quoted 7 lines
I never had any issues with uart2 or spi - neither in kernel nor in u-boot (also not after io-domain driver has been added to u-boot for RK3399). Given this commit is now ~4 years in tree I'd guess that someone else would have reported that issue earlier. It's correct that this information came from a "Power Domain Map" which you call "non schematic" and the "schematic part" says something else - it would have been indeed be better to have clearer information.
We can confirm that "schematic part" is correct.
Quoted 3 lines
Anyway: I can't neither see how this change should relate to uart2 or spi which are both in different io-domain, nor why it would happen only in u-boot. My strongest guess is, that radxa changed something along the way.
I'm sorry, I can't explain the relationship between UART2/SPI and APIO5.
However, I had been seeing "the garbled serial console output on Linux" for a long time, and couldn't figure out how to fix it.
What version of your ROCK Pi 4 board do you have?
Best regards,
--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.
Quoted 8 lines
Or maybe it would be worth to double-check the io-domain driver in u-boot.
Regards,
Alex
_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip
I forgot to mention this:
https://forum.radxa.com/t/problem-using-i2s-and-spi-on-the-gpio-header-of-the-rock-pi-4b/25390/14
Best regards,
--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.
Quoted 97 lines · FUKAUMI Naoki
Hi Alex,
Quoted 80 lines · Alex Bee
Hi,
Am 28.11.25 um 13:33 schrieb Quentin Schulz:
Quoted 71 lines
Hi Naoki,
Quoted 61 lines · FUKAUMI Naoki
Hi Quentin,
Quoted 12 lines · Quentin Schulz
Hi Naoki,
Quoted 9 lines · Quentin Schulz
Hi Naoki,
Quoted 6 lines · FUKAUMI Naoki
This reverts commit
8240e87f16d17("arm64: dts: rockchip: fix audio-supply for Rock Pi 4").Fix the
APIO5_VDDpower supply tovcc_3v0as per the schematics[1][2] [3][4][5].Quoted 8 lines
Quoted 6 lines
Quoted 6 lines
This fixes the SPI-NOR flash probe failure when the blue LED is on[6], and the garbled serial console output on Linux.
The ES8316 headphone and microphone are confirmed to work correctly after this fix.
Please test the ES8316 works when booting Linux from a U-Boot where
ROCKCHIP_IODOMAINandSPL_ROCKCHIP_IODOMAINis *disabled*.I tried below, and confirmed that ES8316 is still working.
configs/rock-pi-4-rk3399_defconfig +0
-0@@ -53,6 +53,7 @@ CONFIG_ROCKCHIP_GPIO=yCONFIG_SYS_I2C_ROCKCHIP=y
CONFIG_LED=y
CONFIG_LED_GPIO=y
+#CONFIG_ROCKCHIP_IODOMAINis not set
CONFIG_MMC_DW=y
CONFIG_MMC_DW_ROCKCHIP=y
CONFIG_MMC_SDHCI=ydts/upstream/src/arm64/rockchip/rk3399-rock-pi-4.dtsi +2
-2@@ -51,7 +51,7 @@ sound: sound { compatible = "audio-graph-card"; - label = "Analog"; + label = "rk3588-es8316"; dais = <&i2s0_p0>; };@@ -516,7 +516,7 @@ }; &io_domains { - audio-supply = <&vcca1v8_codec>; + audio-supply = <&vcc_3v0>; bt656-supply = <&vcc_3v0>; gpio1830-supply = <&vcc_3v0>; sdmmc-supply = <&vcc_sdio>;Quoted 4 lines
Notes:
-SPL_ROCKCHIP_IODOMAINis not set by default
- I don't understand alsa ucm2 ;) so I modified /sound/labelThanks for testing. Let's hope the original issue doesn't appear for *some* boots (depending on probe order or some timing for example). For now I guess this will do. Adding Alex in Cc maybe they are able to reproduce the issue they had 4 years ago with their board?
Quoted 2 lines
Cheers,
QuentinI can confirm that with this change analog audio is _broken_ for me again.
Quoted 7 lines
I never had any issues with uart2 or spi - neither in kernel nor in u- boot (also not after io-domain driver has been added to u-boot for RK3399). Given this commit is now ~4 years in tree I'd guess that someone else would have reported that issue earlier. It's correct that this information came from a "Power Domain Map" which you call "non schematic" and the "schematic part" says something else - it would have been indeed be better to have clearer information.
We can confirm that "schematic part" is correct.
Quoted 3 lines
Anyway: I can't neither see how this change should relate to uart2 or spi which are both in different io-domain, nor why it would happen only in u-boot. My strongest guess is, that radxa changed something along the way.
Quoted 22 lines
I'm sorry, I can't explain the relationship between UART2/SPI and APIO5.
However, I had been seeing "the garbled serial console output on Linux" for a long time, and couldn't figure out how to fix it.
What version of your ROCK Pi 4 board do you have?
Best regards,
Signature · 2 lines
FUKAUMI Naoki Radxa Computer (Shenzhen) Co., Ltd.Quoted 8 lines
Or maybe it would be worth to double-check the io-domain driver in u- boot.
Regards,
Alex
_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip
Hi FUKAUMI,
Quoted 4 lines · FUKAUMI Naoki
I forgot to mention this:
https://forum.radxa.com/t/problem-using-i2s-and-spi-on-the-gpio-header-of-the-rock-pi-4b/25390/14
It seems that SPI5 is associated with the audio power domain in the RK3399, though
I’m not entirely certain.
Quoted 6 lines
Best regards,
--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.
Thanks
-Anand
Quoted 140 lines · FUKAUMI Naoki
Quoted 114 lines
Hi Alex,
Quoted 89 lines · Alex Bee
Hi,
Am 28.11.25 um 13:33 schrieb Quentin Schulz:
Quoted 79 lines
Hi Naoki,
Quoted 66 lines · FUKAUMI Naoki
Hi Quentin,
Quoted 17 lines · Quentin Schulz
Hi Naoki,
Quoted 14 lines · Quentin Schulz
Hi Naoki,
Quoted 11 lines · FUKAUMI Naoki
This reverts commit
8240e87f16d17("arm64: dts: rockchip: fix audio-supply for Rock Pi 4").Fix the
APIO5_VDDpower supply tovcc_3v0as per the schematics[1][2]
[3][4][5].This fixes the SPI-NOR flash probe failure when the blue LED is on[6],
and the garbled serial console output on Linux.Quoted 6 lines
Quoted 3 lines
Quoted 3 lines
The ES8316 headphone and microphone are confirmed to work correctly after this fix.
Please test the ES8316 works when booting Linux from a U-Boot where
ROCKCHIP_IODOMAINandSPL_ROCKCHIP_IODOMAINis *disabled*.I tried below, and confirmed that ES8316 is still working.
configs/rock-pi-4- renamed from configs/rock-pi-4-rk3399_defconfig +0
-0
rk3399_defconfig
index219f42bc7d4..276ca961c10100644configs/rock-pi-4-rk3399_defconfig +1
-0@@ -53,6 +53,7 @@ CONFIG_ROCKCHIP_GPIO=y CONFIG_SYS_I2C_ROCKCHIP=y CONFIG_LED=y CONFIG_LED_GPIO=y +# CONFIG_ROCKCHIP_IODOMAIN is not set CONFIG_MMC_DW=y CONFIG_MMC_DW_ROCKCHIP=y CONFIG_MMC_SDHCI=y(quoted diff) +0
-0b/
dts/upstream/src/arm64/rockchip/rk3399-rock-pi-4.dtsiindex046dbe32901..c734f7824c0100644dts/upstream/src/arm64/rockchip/rk3399-rock-pi-4.dtsi +2
-2@@ -51,7 +51,7 @@ sound: sound { compatible = "audio-graph-card"; - label = "Analog"; + label = "rk3588-es8316"; dais = <&i2s0_p0>; };@@ -516,7 +516,7 @@ }; &io_domains { - audio-supply = <&vcca1v8_codec>; + audio-supply = <&vcc_3v0>; bt656-supply = <&vcc_3v0>; gpio1830-supply = <&vcc_3v0>; sdmmc-supply = <&vcc_sdio>;Quoted 4 lines
Notes:
-SPL_ROCKCHIP_IODOMAINis not set by default
- I don't understand alsa ucm2 ;) so I modified /sound/labelThanks for testing. Let's hope the original issue doesn't appear for *some* boots (depending on probe order or some timing for example). For now I guess this will do. Adding Alex in Cc maybe they are able to reproduce the issue they had 4 years ago with their board?
Quoted 2 lines
Cheers,
QuentinI can confirm that with this change analog audio is _broken_ for me again.
Quoted 9 lines
I never had any issues with uart2 or spi - neither in kernel nor in u- boot
(also not after io-domain driver has been added to u-boot for RK3399). Given this commit is now ~4 years in tree I'd guess that someone else would have reported that issue earlier. It's correct that this information
came from a "Power Domain Map" which you call "non schematic" and the "schematic part" says something else - it would have been indeed be better to have clearer information.We can confirm that "schematic part" is correct.
Quoted 4 lines
Anyway: I can't neither see how this change should relate to uart2 or spi which are both in different io-domain, nor why it would happen only in u-boot. My strongest guess is, that radxa changed something along the way.
I'm sorry, I can't explain the relationship between UART2/SPI and APIO5.
However, I had been seeing "the garbled serial console output on Linux" for a long time, and couldn't figure out how to fix it.
Quoted 19 lines
What version of your ROCK Pi 4 board do you have?
Best regards,
--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.Quoted 9 lines
Or maybe it would be worth to double-check the io-domain driver in u- boot.
Regards,
Alex_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip
Quoted 39 lines · FUKAUMI Naoki
This reverts commit
8240e87f16d17("arm64: dts: rockchip: fix audio-supply for Rock Pi 4").Fix the
APIO5_VDDpower supply tovcc_3v0as per the schematics[1][2] [3][4][5].This fixes the SPI-NOR flash probe failure when the blue LED is on[6], and the garbled serial console output on Linux.
The ES8316 headphone and microphone are confirmed to work correctly after this fix.
[1] https://dl.radxa.com/rockpi4/docs/hw/rockpi4/4a/ROCK_4A_V1.52_SCH.pdf p.14
[2] https://dl.radxa.com/rockpi4/docs/hw/rockpi4/4ap/radxa_rock_4ap_v1730_schematic.pdf p.14
[3] https://dl.radxa.com/rockpi4/docs/hw/rockpi4/4b/ROCK_4B_v1.52_SCH.pdf p.14
[4] https://dl.radxa.com/rockpi4/docs/hw/rockpi4/4bp/radxa_rock_4bp_v1730_schematic.pdf p.14
[5] https://dl.radxa.com/rockpi4/docs/hw/rockpi4/ROCK-4-SE-V1.53-SCH.pdf p.14[6]
=> led blue:status off
=> sf probe
SF: Detected w25q128 with page size 256 Bytes, erase size 4 KiB, total 16 MiB => led blue:status on
=> sf probejedec_spi_norflash@0: unrecognized JEDEC id bytes: ff, ff, ff Failed to initialize SPI flash at 1:0 (error -2)Fixes 7ebfd4f6b52a6 ("arm64: dts: rockchip: add LED for ROCK Pi 4A/B/C/A+/B+")Fixes 8240e87f16d17 ("arm64: dts: rockchip: fix audio-supply for Rock Pi 4")Signed-off-by FUKAUMI Naoki <[email protected]>--- arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi +0
-0
arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi &i2s2 { · line 522
Quoted 8 lines
arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi +1
-1@@ -516,7 +516,7 @@ &i2s2 { }; &io_domains { - audio-supply = <&vcca1v8_codec>; + audio-supply = <&vcc_3v0>; bt656-supply = <&vcc_3v0>; gpio1830-supply = <&vcc_3v0>; sdmmc-supply = <&vcc_sdio>;
U-Boot uses the same device-tree as Linux. I applied the change in U-Boot and it fixes the following problems in U-Boot for me:
* The serial console is not usable after the supply voltages are set.
* Early initialization of the video output fails.
Hi FUKAUMI,
Quoted 28 lines · FUKAUMI Naoki
This reverts commit
8240e87f16d17("arm64: dts: rockchip: fix audio-supply for Rock Pi 4").Fix the
APIO5_VDDpower supply tovcc_3v0as per the schematics[1][2] [3][4][5].This fixes the SPI-NOR flash probe failure when the blue LED is on[6], and the garbled serial console output on Linux.
The ES8316 headphone and microphone are confirmed to work correctly after this fix.
[1] https://dl.radxa.com/rockpi4/docs/hw/rockpi4/4a/ROCK_4A_V1.52_SCH.pdf p.14
[2] https://dl.radxa.com/rockpi4/docs/hw/rockpi4/4ap/radxa_rock_4ap_v1730_schematic.pdf p.14
[3] https://dl.radxa.com/rockpi4/docs/hw/rockpi4/4b/ROCK_4B_v1.52_SCH.pdf p.14
[4] https://dl.radxa.com/rockpi4/docs/hw/rockpi4/4bp/radxa_rock_4bp_v1730_schematic.pdf p.14
[5] https://dl.radxa.com/rockpi4/docs/hw/rockpi4/ROCK-4-SE-V1.53-SCH.pdf p.14[6]
=> led blue:status off
=> sf probe
SF: Detected w25q128 with page size 256 Bytes, erase size 4 KiB, total 16 MiB => led blue:status on
=> sf probejedec_spi_norflash@0: unrecognized JEDEC id bytes: ff, ff, ff Failed to initialize SPI flash at 1:0 (error -2)
Quoted 3 lines
Fixes 7ebfd4f6b52a6 ("arm64: dts: rockchip: add LED for ROCK Pi 4A/B/C/A+/B+")Fixes 8240e87f16d17 ("arm64: dts: rockchip: fix audio-supply for Rock Pi 4")Signed-off-by FUKAUMI Naoki <[email protected]>
With this patch applied, I can get my console working.
Thanks
-Anand