misc-utils: docfdisk.c: fix potential integer underflow in partition size calculation
PATCH 1/1 misc-utils: docfdisk.c: fix potential integer underflow in partition size calculation
report of the static analyzer:
Possible integer underflow: right operand is tainted.
An integer underflow may occur due to arithmetic
operation (unsigned subtraction) between
variables 'totblocks' and 'block', where 'totblocks'
is in range { [0, 4294967295] }, and 'block' is tainted { [0, 4294967295] }
correct explained:
Added validation check before calculating remaining space for partition. The issue occurred when setting the last partition size to 0, which triggers calculation 'totblocks - block'. Without validation, if block >= totblocks, this would result in integer underflow due to unsigned arithmetic, potentially creating a partition with enormous size and leading to device corruption.
--- misc-utils/docfdisk.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)
misc-utils/docfdisk.c +6 -1
@@ -253,8 +253,13 @@ int main(int argc, char **argv)for (i =0 ; i < npart; i++) { ip = &(mh->Partitions[i]); ip->firstUnit =cpu_to_le32 (block); -if (!nblocks[i]) +if (!nblocks[i]) { +if (block >= totblocks) { +printf ("No space left on device for partition.\n" ); +return 1 ; + } nblocks[i] = totblocks - block; + } ip->virtualUnits =cpu_to_le32 (nblocks[i]); block += nblocks[i]; ip->lastUnit =cpu_to_le32 (block-1 );
Signature · 6 lines
2.39.2 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
David Oberhollenzer
AppliedApplied to mtd-utils.git master.
Thanks,
David
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/