Skip to contentSkip to conversation

scsi: block: pm: Remove redundant pm_runtime_mark_last_busy() calls

PATCH In review Sakari Ailus 2 participants 2 messages Oct 29, 2025 SCSI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 scsi: block: pm: Remove redundant pm_runtime_mark_last_busy() calls

pm_runtime_put_autosuspend(), pm_runtime_put_sync_autosuspend(), pm_runtime_autosuspend() and pm_request_autosuspend() now include a call to pm_runtime_mark_last_busy(). Remove the now-reduntant explicit call to pm_runtime_mark_last_busy().

---
 drivers/scsi/scsi_pm.c | 1 -
 1 file changed, 1 deletion(-)
drivers/scsi/scsi_pm.c +0 -1
index d581613d87c7..2652fecbfe47 100644
@@ -205,7 +205,6 @@ static int scsi_runtime_idle(struct device *dev)
 	/* Insert hooks here for targets, hosts, and transport classes */
 
 	if (scsi_is_sdev_device(dev)) {
-		pm_runtime_mark_last_busy(dev);
 		pm_runtime_autosuspend(dev);
 		return -EBUSY;
 	}
Signature · 1 line
2.47.3
#1 lore raw
Quoted 15 lines · Sakari Ailus

pm_runtime_put_autosuspend(), pm_runtime_put_sync_autosuspend(), pm_runtime_autosuspend() and pm_request_autosuspend() now include a call to pm_runtime_mark_last_busy(). Remove the now-reduntant explicit call to pm_runtime_mark_last_busy().

---
  drivers/scsi/scsi_pm.c | 1 -
  1 file changed, 1 deletion(-)
drivers/scsi/scsi_pm.c +0 -0
index d581613d87c7..2652fecbfe47 100644

drivers/scsi/scsi_pm.c static int scsi_runtime_idle(struct device *dev) · line 210

Quoted 7 lines
drivers/scsi/scsi_pm.c +0 -1
@@ -205,7 +205,6 @@ static int scsi_runtime_idle(struct device *dev)
  	/* Insert hooks here for targets, hosts, and transport classes */
 
  	if (scsi_is_sdev_device(dev)) {
-		pm_runtime_mark_last_busy(dev);
  		pm_runtime_autosuspend(dev);
  		return -EBUSY;
  	}

To me this patch looks like a duplicate of an earlier posted patch. See also
https://lore.kernel.org/linux-scsi/[email protected]/

Bart.