Skip to contentSkip to conversation

dt-bindings: clock: sprd,sc9860-clk: Allow "reg" for gate clocks

PATCH In review Rob Herring (Arm) 2 participants 5 messages Oct 29, 2025 – Nov 18, 2025

Subsystems (3)
lore
Share & tools
lore

Rob Herring (Arm)

author maintainer
#0 lore raw

PATCH 1/2 dt-bindings: clock: sprd,sc9860-clk: Allow "reg" for gate clocks

The gate bindings have an artificial split between a "syscon" and clock provider node. Allow "reg" properties so this split can be removed.

---
 .../bindings/clock/sprd,sc9860-clk.yaml       | 26 -------------------
 1 file changed, 26 deletions(-)
Documentation/devicetree/bindings/clock/sprd,sc9860-clk.yaml +0 -26
index 502cd723511f..b131390207d6 100644
@@ -114,25 +114,6 @@ allOf:
         - reg
       properties:
         sprd,syscon: false
-  - if:
-      properties:
-        compatible:
-          contains:
-            enum:
-              - sprd,sc9860-agcp-gate
-              - sprd,sc9860-aon-gate
-              - sprd,sc9860-apahb-gate
-              - sprd,sc9860-apapb-gate
-              - sprd,sc9860-cam-gate
-              - sprd,sc9860-disp-gate
-              - sprd,sc9860-pll
-              - sprd,sc9860-pmu-gate
-              - sprd,sc9860-vsp-gate
-    then:
-      required:
-        - sprd,syscon
-      properties:
-        reg: false
 
 additionalProperties: false
 
@@ -142,13 +123,6 @@ examples:
       #address-cells = <2>;
       #size-cells = <2>;
 
-      pmu-gate {
-        compatible = "sprd,sc9860-pmu-gate";
-        clocks = <&ext_26m>;
-        #clock-cells = <1>;
-        sprd,syscon = <&pmu_regs>;
-      };
-
       clock-controller@20000000 {
         compatible = "sprd,sc9860-ap-clk";
         reg = <0 0x20000000 0 0x400>;
Signature · 1 line
2.51.0
author maintainer
#1 lore raw

PATCH 2/2 arm64: dts: sprd: sc9860: Simplify clock nodes

The various "syscon" nodes in SC9860 are only referenced by clock provider nodes in a 1:1 relationship, and nothing else references the "syscon" nodes. There's no apparent reason for this split. The 2 nodes can simply be merged into 1 node. The clock driver has supported using either "reg" or "sprd,syscon" to access registers from the start, so there shouldn't be any compatibility issues.

With this, DT schema warnings for missing a specific compatible with "syscon" and non-MMIO devices on "simple-bus" are fixed.

---
 arch/arm64/boot/dts/sprd/sc9860.dtsi | 62 ----------------------------
 arch/arm64/boot/dts/sprd/whale2.dtsi | 54 ++++++++++++++++--------
 2 files changed, 36 insertions(+), 80 deletions(-)
arch/arm64/boot/dts/sprd/sc9860.dtsi +0 -62
index d2456d633c39..864ef0a17425 100644
@@ -184,20 +184,6 @@ gic: interrupt-controller@12001000 {
 						| IRQ_TYPE_LEVEL_HIGH)>;
 		};
 
-		pmu_gate: pmu-gate {
-			compatible = "sprd,sc9860-pmu-gate";
-			sprd,syscon = <&pmu_regs>; /* 0x402b0000 */
-			clocks = <&ext_26m>;
-			#clock-cells = <1>;
-		};
-
-		pll: pll {
-			compatible = "sprd,sc9860-pll";
-			sprd,syscon = <&ana_regs>; /* 0x40400000 */
-			clocks = <&pmu_gate 0>;
-			#clock-cells = <1>;
-		};
-
 		ap_clk: clock-controller@20000000 {
 			compatible = "sprd,sc9860-ap-clk";
 			reg = <0 0x20000000 0 0x400>;
@@ -214,19 +200,6 @@ aon_prediv: aon-prediv@402d0000 {
 			#clock-cells = <1>;
 		};
 
-		apahb_gate: apahb-gate {
-			compatible = "sprd,sc9860-apahb-gate";
-			sprd,syscon = <&ap_ahb_regs>; /* 0x20210000 */
-			clocks = <&aon_prediv 0>;
-			#clock-cells = <1>;
-		};
-
-		aon_gate: aon-gate {
-			compatible = "sprd,sc9860-aon-gate";
-			sprd,syscon = <&aon_regs>; /* 0x402e0000 */
-			clocks = <&aon_prediv 0>;
-			#clock-cells = <1>;
-		};
 
 		aonsecure_clk: clock-controller@40880000 {
 			compatible = "sprd,sc9860-aonsecure-clk";
@@ -235,13 +208,6 @@ aonsecure_clk: clock-controller@40880000 {
 			#clock-cells = <1>;
 		};
 
-		agcp_gate: agcp-gate {
-			compatible = "sprd,sc9860-agcp-gate";
-			sprd,syscon = <&agcp_regs>; /* 0x415e0000 */
-			clocks = <&aon_prediv 0>;
-			#clock-cells = <1>;
-		};
-
 		gpu_clk: clock-controller@60200000 {
 			compatible = "sprd,sc9860-gpu-clk";
 			reg = <0 0x60200000 0 0x400>;
@@ -256,13 +222,6 @@ vsp_clk: clock-controller@61000000 {
 			#clock-cells = <1>;
 		};
 
-		vsp_gate: vsp-gate {
-			compatible = "sprd,sc9860-vsp-gate";
-			sprd,syscon = <&vsp_regs>; /* 0x61100000 */
-			clocks = <&vsp_clk 0>;
-			#clock-cells = <1>;
-		};
-
 		cam_clk: clock-controller@62000000 {
 			compatible = "sprd,sc9860-cam-clk";
 			reg = <0 0x62000000 0 0x4000>;
@@ -270,13 +229,6 @@ cam_clk: clock-controller@62000000 {
 			#clock-cells = <1>;
 		};
 
-		cam_gate: cam-gate {
-			compatible = "sprd,sc9860-cam-gate";
-			sprd,syscon = <&cam_regs>; /* 0x62100000 */
-			clocks = <&cam_clk 0>;
-			#clock-cells = <1>;
-		};
-
 		disp_clk: clock-controller@63000000 {
 			compatible = "sprd,sc9860-disp-clk";
 			reg = <0 0x63000000 0 0x400>;
@@ -284,20 +236,6 @@ disp_clk: clock-controller@63000000 {
 			#clock-cells = <1>;
 		};
 
-		disp_gate: disp-gate {
-			compatible = "sprd,sc9860-disp-gate";
-			sprd,syscon = <&disp_regs>; /* 0x63100000 */
-			clocks = <&disp_clk 0>;
-			#clock-cells = <1>;
-		};
-
-		apapb_gate: apapb-gate {
-			compatible = "sprd,sc9860-apapb-gate";
-			sprd,syscon = <&ap_apb_regs>; /* 0x70b00000 */
-			clocks = <&ap_clk 0>;
-			#clock-cells = <1>;
-		};
-
 		funnel@10001000 { /* SoC Funnel */
 			compatible = "arm,coresight-dynamic-funnel", "arm,primecell";
 			reg = <0 0x10001000 0 0x1000>;
arch/arm64/boot/dts/sprd/whale2.dtsi +36 -18

85 lines not on this page · raw message

Signature · 1 line
2.51.0
reviewer Reviewed-by on v1 2/2
#2 lore raw

Re: [PATCH 2/2] arm64: dts: sprd: sc9860: Simplify clock nodes

Quoted 8 lines · Rob Herring (Arm)

The various "syscon" nodes in SC9860 are only referenced by clock provider nodes in a 1:1 relationship, and nothing else references the "syscon" nodes. There's no apparent reason for this split. The 2 nodes can simply be merged into 1 node. The clock driver has supported using either "reg" or "sprd,syscon" to access registers from the start, so there shouldn't be any compatibility issues.

Quoted 4 lines

With this, DT schema warnings for missing a specific compatible with "syscon" and non-MMIO devices on "simple-bus" are fixed.

Quoted 206 lines
---
 arch/arm64/boot/dts/sprd/sc9860.dtsi | 62 ----------------------------
 arch/arm64/boot/dts/sprd/whale2.dtsi | 54 ++++++++++++++++--------
 2 files changed, 36 insertions(+), 80 deletions(-)
arch/arm64/boot/dts/sprd/sc9860.dtsi +0 -62
index d2456d633c39..864ef0a17425 100644
@@ -184,20 +184,6 @@ gic: interrupt-controller@12001000 {
                                                | IRQ_TYPE_LEVEL_HIGH)>;
                };
 
-               pmu_gate: pmu-gate {
-                       compatible = "sprd,sc9860-pmu-gate";
-                       sprd,syscon = <&pmu_regs>; /* 0x402b0000 */
-                       clocks = <&ext_26m>;
-                       #clock-cells = <1>;
-               };
-
-               pll: pll {
-                       compatible = "sprd,sc9860-pll";
-                       sprd,syscon = <&ana_regs>; /* 0x40400000 */
-                       clocks = <&pmu_gate 0>;
-                       #clock-cells = <1>;
-               };
-
                ap_clk: clock-controller@20000000 {
                        compatible = "sprd,sc9860-ap-clk";
                        reg = <0 0x20000000 0 0x400>;
@@ -214,19 +200,6 @@ aon_prediv: aon-prediv@402d0000 {
                        #clock-cells = <1>;
                };
 
-               apahb_gate: apahb-gate {
-                       compatible = "sprd,sc9860-apahb-gate";
-                       sprd,syscon = <&ap_ahb_regs>; /* 0x20210000 */
-                       clocks = <&aon_prediv 0>;
-                       #clock-cells = <1>;
-               };
-
-               aon_gate: aon-gate {
-                       compatible = "sprd,sc9860-aon-gate";
-                       sprd,syscon = <&aon_regs>; /* 0x402e0000 */
-                       clocks = <&aon_prediv 0>;
-                       #clock-cells = <1>;
-               };
 
                aonsecure_clk: clock-controller@40880000 {
                        compatible = "sprd,sc9860-aonsecure-clk";
@@ -235,13 +208,6 @@ aonsecure_clk: clock-controller@40880000 {
                        #clock-cells = <1>;
                };
 
-               agcp_gate: agcp-gate {
-                       compatible = "sprd,sc9860-agcp-gate";
-                       sprd,syscon = <&agcp_regs>; /* 0x415e0000 */
-                       clocks = <&aon_prediv 0>;
-                       #clock-cells = <1>;
-               };
-
                gpu_clk: clock-controller@60200000 {
                        compatible = "sprd,sc9860-gpu-clk";
                        reg = <0 0x60200000 0 0x400>;
@@ -256,13 +222,6 @@ vsp_clk: clock-controller@61000000 {
                        #clock-cells = <1>;
                };
 
-               vsp_gate: vsp-gate {
-                       compatible = "sprd,sc9860-vsp-gate";
-                       sprd,syscon = <&vsp_regs>; /* 0x61100000 */
-                       clocks = <&vsp_clk 0>;
-                       #clock-cells = <1>;
-               };
-
                cam_clk: clock-controller@62000000 {
                        compatible = "sprd,sc9860-cam-clk";
                        reg = <0 0x62000000 0 0x4000>;
@@ -270,13 +229,6 @@ cam_clk: clock-controller@62000000 {
                        #clock-cells = <1>;
                };
 
-               cam_gate: cam-gate {
-                       compatible = "sprd,sc9860-cam-gate";
-                       sprd,syscon = <&cam_regs>; /* 0x62100000 */
-                       clocks = <&cam_clk 0>;
-                       #clock-cells = <1>;
-               };
-
                disp_clk: clock-controller@63000000 {
                        compatible = "sprd,sc9860-disp-clk";
                        reg = <0 0x63000000 0 0x400>;
@@ -284,20 +236,6 @@ disp_clk: clock-controller@63000000 {
                        #clock-cells = <1>;
                };
 
-               disp_gate: disp-gate {
-                       compatible = "sprd,sc9860-disp-gate";
-                       sprd,syscon = <&disp_regs>; /* 0x63100000 */
-                       clocks = <&disp_clk 0>;
-                       #clock-cells = <1>;
-               };
-
-               apapb_gate: apapb-gate {
-                       compatible = "sprd,sc9860-apapb-gate";
-                       sprd,syscon = <&ap_apb_regs>; /* 0x70b00000 */
-                       clocks = <&ap_clk 0>;
-                       #clock-cells = <1>;
-               };
-
                funnel@10001000 { /* SoC Funnel */
                        compatible = "arm,coresight-dynamic-funnel", "arm,primecell";
                        reg = <0 0x10001000 0 0x1000>;
arch/arm64/boot/dts/sprd/whale2.dtsi +36 -19
index a551e14ce826..dac2699a79d4 100644
@@ -18,49 +18,67 @@ soc: soc {
                #size-cells = <2>;
                ranges;
 
-               ap_ahb_regs: syscon@20210000 {
-                       compatible = "syscon";
+               apahb_gate: clock-controller@20210000 {
                        reg = <0 0x20210000 0 0x10000>;
+                       compatible = "sprd,sc9860-apahb-gate";
+                       clocks = <&aon_prediv 0>;
+                       #clock-cells = <1>;
                };
 
-               pmu_regs: syscon@402b0000 {
-                       compatible = "syscon";
+               pmu_gate: clock-controller@402b0000 {
                        reg = <0 0x402b0000 0 0x10000>;
+                               compatible = "sprd,sc9860-pmu-gate";
+                               clocks = <&ext_26m>;
+                               #clock-cells = <1>;
                };
 
-               aon_regs: syscon@402e0000 {
-                       compatible = "syscon";
+               aon_gate: clock-controller@402e0000 {
                        reg = <0 0x402e0000 0 0x10000>;
+                               compatible = "sprd,sc9860-aon-gate";
+                               clocks = <&aon_prediv 0>;
+                               #clock-cells = <1>;
                };
 
-               ana_regs: syscon@40400000 {
-                       compatible = "syscon";
+               pll: clock-controller@40400000 {
                        reg = <0 0x40400000 0 0x10000>;
+                               compatible = "sprd,sc9860-pll";
+                               clocks = <&pmu_gate 0>;
+                               #clock-cells = <1>;
                };
 
-               agcp_regs: syscon@415e0000 {
-                       compatible = "syscon";
+               agcp_gate: clock-controller@415e0000 {
                        reg = <0 0x415e0000 0 0x1000000>;
+                               compatible = "sprd,sc9860-agcp-gate";
+                               clocks = <&aon_prediv 0>;
+                               #clock-cells = <1>;
                };
 
-               vsp_regs: syscon@61100000 {
-                       compatible = "syscon";
+               vsp_gate: clock-controller@61100000 {
                        reg = <0 0x61100000 0 0x10000>;
+                               compatible = "sprd,sc9860-vsp-gate";
+                               clocks = <&vsp_clk 0>;
+                               #clock-cells = <1>;
                };
 
-               cam_regs: syscon@62100000 {
-                       compatible = "syscon";
+               cam_gate: clock-controller@62100000 {
                        reg = <0 0x62100000 0 0x10000>;
+                               compatible = "sprd,sc9860-cam-gate";
+                               clocks = <&cam_clk 0>;
+                               #clock-cells = <1>;
                };
 
-               disp_regs: syscon@63100000 {
-                       compatible = "syscon";
+               disp_gate: clock-controller@63100000 {
                        reg = <0 0x63100000 0 0x10000>;
+                               compatible = "sprd,sc9860-disp-gate";
+                               clocks = <&disp_clk 0>;
+                               #clock-cells = <1>;
                };
 
-               ap_apb_regs: syscon@70b00000 {
-                       compatible = "syscon";
+               apapb_gate: clock-controller@70b00000 {
                        reg = <0 0x70b00000 0 0x40000>;
+                               compatible = "sprd,sc9860-apapb-gate";
+                               clocks = <&ap_clk 0>;
+                               #clock-cells = <1>;
                };
 
                ap-apb@70000000 {
--

2.51.0

author maintainer
#3 lore raw
In reply to Rob Herring (Arm)
Quoted 7 lines · Rob Herring (Arm)

The gate bindings have an artificial split between a "syscon" and clock provider node. Allow "reg" properties so this split can be removed.

---
 .../bindings/clock/sprd,sc9860-clk.yaml       | 26 -------------------
 1 file changed, 26 deletions(-)

Ping!

Quoted 48 lines
Documentation/devicetree/bindings/clock/sprd,sc9860-clk.yaml +0 -26
index 502cd723511f..b131390207d6 100644
@@ -114,25 +114,6 @@ allOf:
         - reg
       properties:
         sprd,syscon: false
-  - if:
-      properties:
-        compatible:
-          contains:
-            enum:
-              - sprd,sc9860-agcp-gate
-              - sprd,sc9860-aon-gate
-              - sprd,sc9860-apahb-gate
-              - sprd,sc9860-apapb-gate
-              - sprd,sc9860-cam-gate
-              - sprd,sc9860-disp-gate
-              - sprd,sc9860-pll
-              - sprd,sc9860-pmu-gate
-              - sprd,sc9860-vsp-gate
-    then:
-      required:
-        - sprd,syscon
-      properties:
-        reg: false
 
 additionalProperties: false
 
@@ -142,13 +123,6 @@ examples:
       #address-cells = <2>;
       #size-cells = <2>;
 
-      pmu-gate {
-        compatible = "sprd,sc9860-pmu-gate";
-        clocks = <&ext_26m>;
-        #clock-cells = <1>;
-        sprd,syscon = <&pmu_regs>;
-      };
-
       clock-controller@20000000 {
         compatible = "sprd,sc9860-ap-clk";
         reg = <0 0x20000000 0 0x400>;
Signature · 1 line
2.51.0
reviewer Reviewed-by on v1 1/2
#4 lore raw
In reply to Rob Herring (Arm)

Hi Rob,

Quoted 5 lines · Rob Herring (Arm)

The gate bindings have an artificial split between a "syscon" and clock provider node. Allow "reg" properties so this split can be removed.

Quoted 51 lines
---
 .../bindings/clock/sprd,sc9860-clk.yaml       | 26 -------------------
 1 file changed, 26 deletions(-)
Documentation/devicetree/bindings/clock/sprd,sc9860-clk.yaml +0 -27
index 502cd723511f..b131390207d6 100644
@@ -114,25 +114,6 @@ allOf:
         - reg
       properties:
         sprd,syscon: false
-  - if:
-      properties:
-        compatible:
-          contains:
-            enum:
-              - sprd,sc9860-agcp-gate
-              - sprd,sc9860-aon-gate
-              - sprd,sc9860-apahb-gate
-              - sprd,sc9860-apapb-gate
-              - sprd,sc9860-cam-gate
-              - sprd,sc9860-disp-gate
-              - sprd,sc9860-pll
-              - sprd,sc9860-pmu-gate
-              - sprd,sc9860-vsp-gate
-    then:
-      required:
-        - sprd,syscon
-      properties:
-        reg: false
 
 additionalProperties: false
 
@@ -142,13 +123,6 @@ examples:
       #address-cells = <2>;
       #size-cells = <2>;
 
-      pmu-gate {
-        compatible = "sprd,sc9860-pmu-gate";
-        clocks = <&ext_26m>;
-        #clock-cells = <1>;
-        sprd,syscon = <&pmu_regs>;
-      };
-
       clock-controller@20000000 {
         compatible = "sprd,sc9860-ap-clk";
         reg = <0 0x20000000 0 0x400>;
--

2.51.0