Skip to contentSkip to conversation

ASoC: max98090/91: fixing the stream index

PATCH In review Sharique Mohammad 2 participants 2 messages Oct 29, 2025 – Oct 30, 2025

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: max98090/91: fixing the stream index

The function SND_SOC_DAPM_AIF_OUT has its third parameter as stream index. The stream index is numbered from 0 to 3 for every output interface widget but with same stream name "HiFi Capture". So, if the stream name is same, the stream index cannot be different. Also for capture, there is only one stream "HiFi Capture", so only one stream index. Therefore, with this patch changed the stream index to 0 for all the output interface widgets with stream name "HiFi Capture".

---
 sound/soc/codecs/max98090.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
sound/soc/codecs/max98090.c +3 -3
index 2e6ec2ac5327..0891ffd0e123 100644
@@ -1144,7 +1144,7 @@ static const struct snd_soc_dapm_widget max98090_dapm_widgets[] = {
 
 	SND_SOC_DAPM_AIF_OUT("AIFOUTL", "HiFi Capture", 0,
 		SND_SOC_NOPM, 0, 0),
-	SND_SOC_DAPM_AIF_OUT("AIFOUTR", "HiFi Capture", 1,
+	SND_SOC_DAPM_AIF_OUT("AIFOUTR", "HiFi Capture", 0,
 		SND_SOC_NOPM, 0, 0),
 
 	SND_SOC_DAPM_MUX("LBENL Mux", SND_SOC_NOPM,
@@ -1242,9 +1242,9 @@ static const struct snd_soc_dapm_widget max98091_dapm_widgets[] = {
 	SND_SOC_DAPM_SUPPLY("DMIC34_HPF", M98090_REG_FILTER_CONFIG,
 		M98090_FLT_DMIC34HPF_SHIFT, 0, NULL, 0),
 
-	SND_SOC_DAPM_AIF_OUT("AIFOUT2L", "HiFi Capture", 2,
+	SND_SOC_DAPM_AIF_OUT("AIFOUT2L", "HiFi Capture", 0,
 		SND_SOC_NOPM, 0, 0),
-	SND_SOC_DAPM_AIF_OUT("AIFOUT2R", "HiFi Capture", 3,
+	SND_SOC_DAPM_AIF_OUT("AIFOUT2R", "HiFi Capture", 0,
 		SND_SOC_NOPM, 0, 0),
 };
 
Signature · 1 line
2.30.5
maintainer
#1 lore raw
Quoted 10 lines · Sharique Mohammad

The function SND_SOC_DAPM_AIF_OUT has its third parameter as stream index. The stream index is numbered from 0 to 3 for every output interface widget but with same stream name "HiFi Capture". So, if the stream name is same, the stream index cannot be different. Also for capture, there is only one stream "HiFi Capture", so only one stream index. Therefore, with this patch changed the stream index to 0 for all the output interface widgets with stream name "HiFi Capture".

[...]

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: max98090/91: fixing the stream index

      commit: f1dfbc1b5cf8650ae9a0d543e5f5335fc0f478ce

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark