Skip to contentSkip to conversation

tools/perf/tests/make: use IS_64_BIT for generic lib dir

PATCH In review pgnmirror 2 participants 2 messages Oct 31, 2025 perf events

lore
Share & tools
lore

pgnmirror

author
#0 lore raw

PATCH v2 1/1 tools/perf/tests/make: use IS_64_BIT for generic lib dir

Use the IS_64_BIT flag to set the lib directory generically for all architectures. Previously, this logic was hardcoded for x86/x86_64 only.

---
 tools/perf/tests/make | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
tools/perf/tests/make +2 -3
index b650ce886..64066e011 100644
@@ -53,9 +53,8 @@ endif
 
 include $(srctree)/tools/scripts/Makefile.arch
 
-# FIXME looks like x86 is the only arch running tests ;-)
-# we need some IS_(32/64) flag to make this generic
-ifeq ($(ARCH)$(IS_64_BIT), x861)
+# use IS_64_BIT to select lib/lib64 generically for all architectures
+ifeq ($(IS_64_BIT), 1)
 lib = lib64
 else
 lib = lib
Signature · 1 line
2.51.2
maintainer
#1 lore raw
Quoted 13 lines · pgnmirror

Use the IS_64_BIT flag to set the lib directory generically for all architectures. Previously, this logic was hardcoded for x86/x86_64 only.

---
 tools/perf/tests/make | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
tools/perf/tests/make +0 -0
index b650ce886..64066e011 100644

tools/perf/tests/make endif · line 57

Quoted 8 lines
tools/perf/tests/make +2 -3
@@ -53,9 +53,8 @@ endif
 
 include $(srctree)/tools/scripts/Makefile.arch
 
-# FIXME looks like x86 is the only arch running tests ;-)
-# we need some IS_(32/64) flag to make this generic
-ifeq ($(ARCH)$(IS_64_BIT), x861)
+# use IS_64_BIT to select lib/lib64 generically for all architectures
+ifeq ($(IS_64_BIT), 1)

IIRC last time we checked this, some arch/distro didn't have lib64 directory on 64-bit systems. Are you sure if it'd work on them or do you have any real problem with this?

Thanks,
Namhyung

Quoted 6 lines
tools/perf/tests/make +0 -0
 lib = lib64
 else
 lib = lib
Signature · 1 line
2.51.2