of: fdt: Fix the len check in early_init_dt_check_for_usable_mem_range()
PATCH 1/1 of: fdt: Fix the len check in early_init_dt_check_for_usable_mem_range()
The len value is in bytes, while dt_root_addr_cells + dt_root_size_cells is in cells (4 bytes per cell).
The modulo calculation between them is incorrect, the units must be converted first.
Fixes fb319e77a0e7 ("of: fdt: Add memory for devices by DT property "linux,usable-memory-range"")
Signed-off-by Yuntao Wang <[email protected]>
--- drivers/of/fdt.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/of/fdt.c +2 -1
@@ -852,6 +852,7 @@ void __init early_init_dt_check_for_usable_mem_range(void)const __be32 *prop, *endp;int len, i;unsigned long node = chosen_node_offset; +int t_len = (dt_root_addr_cells + dt_root_size_cells) *sizeof (__be32);if ((long )node <0 )return ;
@@ -859,7 +860,7 @@ void __init early_init_dt_check_for_usable_mem_range(void)pr_debug ("Looking for usable-memory-range property... " ); prop =of_get_flat_dt_prop (node,"linux,usable-memory-range" , &len); -if (!prop || (len % (dt_root_addr_cells + dt_root_size_cells))) +if (!prop || len % t_len)return ; endp = prop + (len /sizeof (__be32));
Signature · 1 line
2.51.0