Skip to contentSkip to conversation

rust: usb: fix broken call to T::disconnect()

PATCH Applied Danilo Krummrich 5 participants 7 messages Nov 3, 2025

Subsystems (2)
USB Rust
lore
Share & tools
lore

Danilo Krummrich

author reviewer
#0 lore raw

PATCH 1/1 rust: usb: fix broken call to T::disconnect()

A refactoring of Device::drvdata_obtain() broke T::disconnect() in the USB abstractions.

"""
error[E0599]: no method named data found for struct core::pin::Pin<kbox::Box<T, Kmalloc>> in the current scope
--> rust/kernel/usb.rs:92:34

   |
92 |         T::disconnect(intf, data.data());
   |                                  ^^^^ method not found in `core::pin::Pin<kbox::Box<T, Kmalloc>>`

error: aborting due to 1 previous error

For more information about this error, try rustc --explain E0599.
make[2]: *** [rust/Makefile:553: rust/kernel.o] Error 1
make[1]: *** [/builddir/build/BUILD/kernel-6.18.0-build/kernel-next-20251103/linux-6.18.0-0.0.next.20251103.436.vanilla.fc44.x86_64/Makefile:1316: prepare] Error 2
make: *** [Makefile:256: __sub-make] Error 2
"""

This slipped through, since the USB abstractions are globally disabled. However, the USB tree recently enabled them, hence it showed up in linux-next.

Reported-by Thorsten Leemhuis <[email protected]>
Closes https://lore.kernel.org/all/[email protected]/ open here
Fixes 6bbaa93912bf ("rust: device: narrow the generic of drvdata_obtain()")
Signed-off-by Danilo Krummrich <[email protected]>
---
 rust/kernel/usb.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
rust/kernel/usb.rs +1 -1
index 92215fdc3c6a..534e3ded5442 100644
@@ -89,7 +89,7 @@ extern "C" fn disconnect_callback(intf: *mut bindings::usb_interface) {
         // and stored a `Pin<KBox<T>>`.
         let data = unsafe { dev.drvdata_obtain::<T>() };
 
-        T::disconnect(intf, data.data());
+        T::disconnect(intf, data.as_ref());
     }
 }
Signature · 1 line
2.51.0
reviewer Reviewed-by on v1 1/1
#1 lore raw
Quoted 19 lines · Danilo Krummrich

A refactoring of Device::drvdata_obtain() broke T::disconnect() in the USB abstractions.

"""
error[E0599]: no method named data found for struct core::pin::Pin<kbox::Box<T, Kmalloc>> in the current scope
--> rust/kernel/usb.rs:92:34

   |
92 |         T::disconnect(intf, data.data());
   |                                  ^^^^ method not found in `core::pin::Pin<kbox::Box<T, Kmalloc>>`

error: aborting due to 1 previous error

For more information about this error, try rustc --explain E0599.
make[2]: *** [rust/Makefile:553: rust/kernel.o] Error 1
make[1]: *** [/builddir/build/BUILD/kernel-6.18.0-build/kernel-next-20251103/linux-6.18.0-0.0.next.20251103.436.vanilla.fc44.x86_64/Makefile:1316: prepare] Error 2
make: *** [Makefile:256: __sub-make] Error 2
"""

Quoted 8 lines

This slipped through, since the USB abstractions are globally disabled. However, the USB tree recently enabled them, hence it showed up in linux-next.

Reported-by Thorsten Leemhuis <[email protected]>
Closes https://lore.kernel.org/all/[email protected]/ open here
Fixes 6bbaa93912bf ("rust: device: narrow the generic of drvdata_obtain()")
Signed-off-by Danilo Krummrich <[email protected]>
Reviewed-by Alice Ryhl <[email protected]>
Tested-by on v1 1/1
#2 lore raw
In reply to Danilo Krummrich
Quoted 9 lines · Danilo Krummrich

A refactoring of Device::drvdata_obtain() broke T::disconnect() in the USB abstractions.
[...]
This slipped through, since the USB abstractions are globally disabled. However, the USB tree recently enabled them, hence it showed up in linux-next.

Reported-by Thorsten Leemhuis <[email protected]>
Closes https://lore.kernel.org/all/[email protected]/ open here

thx, that fixed things for me:

Tested-by Thorsten Leemhuis <[email protected]>

Ciao, Thorsten

maintainer
#3 lore raw
In reply to Danilo Krummrich
Quoted 18 lines · Danilo Krummrich

A refactoring of Device::drvdata_obtain() broke T::disconnect() in the USB abstractions.

"""
error[E0599]: no method named data found for struct core::pin::Pin<kbox::Box<T, Kmalloc>> in the current scope
--> rust/kernel/usb.rs:92:34

   |
92 |         T::disconnect(intf, data.data());
   |                                  ^^^^ method not found in `core::pin::Pin<kbox::Box<T, Kmalloc>>`

error: aborting due to 1 previous error

For more information about this error, try rustc --explain E0599.
make[2]: *** [rust/Makefile:553: rust/kernel.o] Error 1
make[1]: *** [/builddir/build/BUILD/kernel-6.18.0-build/kernel-next-20251103/linux-6.18.0-0.0.next.20251103.436.vanilla.fc44.x86_64/Makefile:1316: prepare] Error 2
make: *** [Makefile:256: __sub-make] Error 2
"""

Quoted 3 lines

This slipped through, since the USB abstractions are globally disabled. However, the USB tree recently enabled them, hence it showed up in linux-next.

Sorry about this, should we also enable it in the driver-core-next tree as well, to catch these types of things?

greg k-h

author reviewer
#4 lore raw
Quoted 19 lines · Greg KH
Quoted 18 lines · Danilo Krummrich

A refactoring of Device::drvdata_obtain() broke T::disconnect() in the USB abstractions.

"""
error[E0599]: no method named data found for struct core::pin::Pin<kbox::Box<T, Kmalloc>> in the current scope
--> rust/kernel/usb.rs:92:34

   |
92 |         T::disconnect(intf, data.data());
   |                                  ^^^^ method not found in `core::pin::Pin<kbox::Box<T, Kmalloc>>`

error: aborting due to 1 previous error

For more information about this error, try rustc --explain E0599.
make[2]: *** [rust/Makefile:553: rust/kernel.o] Error 1
make[1]: *** [/builddir/build/BUILD/kernel-6.18.0-build/kernel-next-20251103/linux-6.18.0-0.0.next.20251103.436.vanilla.fc44.x86_64/Makefile:1316: prepare] Error 2
make: *** [Makefile:256: __sub-make] Error 2
"""

Quoted 6 lines
Quoted 3 lines

This slipped through, since the USB abstractions are globally disabled. However, the USB tree recently enabled them, hence it showed up in linux-next.

Sorry about this, should we also enable it in the driver-core-next tree as well, to catch these types of things?

No worries -- I actually enabled it locally, but then forgot to re-test after a rebase.

I'm fine either way, I only expect one more patch touching the USB stuff in this cycle.

author reviewer Applied
#5 lore raw
In reply to Danilo Krummrich
Quoted 18 lines · Danilo Krummrich

A refactoring of Device::drvdata_obtain() broke T::disconnect() in the USB abstractions.

"""
error[E0599]: no method named data found for struct core::pin::Pin<kbox::Box<T, Kmalloc>> in the current scope
--> rust/kernel/usb.rs:92:34

   |
92 |         T::disconnect(intf, data.data());
   |                                  ^^^^ method not found in `core::pin::Pin<kbox::Box<T, Kmalloc>>`

error: aborting due to 1 previous error

For more information about this error, try rustc --explain E0599.
make[2]: *** [rust/Makefile:553: rust/kernel.o] Error 1
make[1]: *** [/builddir/build/BUILD/kernel-6.18.0-build/kernel-next-20251103/linux-6.18.0-0.0.next.20251103.436.vanilla.fc44.x86_64/Makefile:1316: prepare] Error 2
make: *** [Makefile:256: __sub-make] Error 2
"""

Quoted 8 lines

This slipped through, since the USB abstractions are globally disabled. However, the USB tree recently enabled them, hence it showed up in linux-next.

Reported-by Thorsten Leemhuis <[email protected]>
Closes https://lore.kernel.org/all/[email protected]/ open here
Fixes 6bbaa93912bf ("rust: device: narrow the generic of drvdata_obtain()")
Signed-off-by Danilo Krummrich <[email protected]>

Applied to driver-core-next, thanks!

reviewer Reviewed-by on v1 1/1
#6 lore raw
In reply to Danilo Krummrich
Quoted 51 lines · Danilo Krummrich

A refactoring of Device::drvdata_obtain() broke T::disconnect() in the USB abstractions.

"""
error[E0599]: no method named data found for struct core::pin::Pin<kbox::Box<T, Kmalloc>> in the current scope
--> rust/kernel/usb.rs:92:34
|
92 | T::disconnect(intf, data.data());
| ^^^^ method not found in core::pin::Pin<kbox::Box<T, Kmalloc>>

error: aborting due to 1 previous error

For more information about this error, try rustc --explain E0599.
make[2]: *** [rust/Makefile:553: rust/kernel.o] Error 1
make[1]: *** [/builddir/build/BUILD/kernel-6.18.0-build/kernel-next-20251103/linux-6.18.0-0.0.next.20251103.436.vanilla.fc44.x86_64/Makefile:1316: prepare] Error 2
make: *** [Makefile:256: __sub-make] Error 2
"""

This slipped through, since the USB abstractions are globally disabled. However, the USB tree recently enabled them, hence it showed up in linux-next.

Reported-by Thorsten Leemhuis <[email protected]>
Closes https://lore.kernel.org/all/[email protected]/ open here
Fixes 6bbaa93912bf ("rust: device: narrow the generic of drvdata_obtain()")
Signed-off-by Danilo Krummrich <[email protected]>

---
rust/kernel/usb.rs | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
rust/kernel/usb.rs +1 -1
index 92215fdc3c6a..534e3ded5442 100644
@@ -89,7 +89,7 @@ extern "C" fn disconnect_callback(intf: *mut bindings::usb_interface) {
        // and stored a `Pin<KBox<T>>`.
        let data = unsafe { dev.drvdata_obtain::<T>() };
 
-        T::disconnect(intf, data.data());
+        T::disconnect(intf, data.as_ref());
    }
 }
Signature · 1 line
2.51.0
Reviewed-by Daniel Almeida <[email protected]>