Plane Color Pipeline support for Intel platforms
Subsystems (9)
v6 cover Plane Color Pipeline support for Intel platforms
This series intends to add support for Plane Color Management for Intel platforms. This is based on the design which has been agreed upon by the community. Series implementing the design for generic DRM core has been sent out by Alex Hung and Harry Wentland and is under review below:
https://patchwork.freedesktop.org/series/152970/
The base work of above series is squashed under 1 patch and support for Intel platform is added on top of it.
Any reviews on the original core design is expected to be done in Alex's series to avoid any forking of the discussion.
IGT Changes to validate the same have been implemented and can be found below:
https://patchwork.freedesktop.org/series/150455/
Follow On work:
Changes for Multi Segmented/PWL LUT's will be taken up in a separate series to align with implementation of basic color pipeline first in upstream. This is as per agreement and alignment in Hackfest discussion.
Changes in v6:
- Remove Multi Segmented LUT implementations. This will be taken up as a separate series.
- Code Refactoring and review comments addressed (Jani, Suraj, Simon)
- Propogate Plane Color changes to crtc state
- Fix DSB programming for Luts
- Add 3D Lut support
- Plane color callbacks updated to TGL+
- Rebase on AMD's Color series v12 version
Changes in v5:
- Exposing CTM as 3x4 instead of 3x3 using post offsets.
- Exposing single segmented 1D LUT color op along with multi segmented lut in 2 different color pipelines
- Add helper to extract LUT data from 32 bit samples
- Enable uapi to hardware state copy in driver
- Add DSB support to program color Luts
- Fix some miscellaneous issues
Changes in v4:
- Rebase
Changes in v3:
- Rebase on latest plane color pipeline series (v7) from AMD
- Update documentation for 3x3 CTM colorop (Dmitry)
- Fix documentation for multi segmented 1D lut (Dmitry)
- Squash changes for 1d LUT helpers (Dmitry)
Changes in v2:
- Add documentation for hardware capability detection for segmented luts
- Add documentation for lut computation in userspace based on hardware caps
- Update drm_color_lut_range data structure and handling
- Enhance the structure to avoid ambiguity and cater to varying hardware implementations of 1D Lut blocks
- Replace drm_color_lut_ext with drm_color_lut32
- Change namespace for drm_color_lut_range flags (Sebastien)
- Program super fine post csc gamma lut segment for Intel hardware
Chaitanya Kumar Borah (8):
drm/i915: Add identifiers for driver specific blocks drm/i915: Add intel_color_op
drm/i915/color: Add helper to create intel colorop drm/i915/color: Create a transfer function color pipeline drm/i915/color: Add framework to program CSC drm/i915/color: Preserve sign bit when int_bits is Zero drm/i915/display: Add registers for 3D LUT drm/i915/color: Add 3D LUT to color pipeline
Harry Wentland (1):
[NOT FOR REVIEW] drm: AMD series squashed
Uma Shankar (7):
drm/i915/color: Add plane CTM callback for D12 and beyond drm/i915: Add register definitions for Plane Degamma drm/i915/color: Add framework to program PRE/POST CSC LUT drm/i915: Add register definitions for Plane Post CSC drm/i915/color: Program Pre-CSC registers drm/i915/xelpd: Program Plane Post CSC Registers drm/i915/color: Enable Plane Color Pipelines
Documentation/gpu/drm-kms.rst | 15 + Documentation/gpu/rfc/color_pipeline.rst | 378 ++++++++ Documentation/gpu/rfc/index.rst | 3 + drivers/gpu/drm/Makefile | 1 + .../gpu/drm/amd/display/amdgpu_dm/Makefile | 3 +- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 + .../amd/display/amdgpu_dm/amdgpu_dm_color.c | 768 ++++++++++++++++- .../amd/display/amdgpu_dm/amdgpu_dm_colorop.c | 208 +++++ .../amd/display/amdgpu_dm/amdgpu_dm_colorop.h | 36 + .../amd/display/amdgpu_dm/amdgpu_dm_crtc.c | 26 +- .../amd/display/amdgpu_dm/amdgpu_dm_plane.c | 39 + drivers/gpu/drm/drm_atomic.c | 170 +++- drivers/gpu/drm/drm_atomic_helper.c | 12 + drivers/gpu/drm/drm_atomic_state_helper.c | 5 + drivers/gpu/drm/drm_atomic_uapi.c | 159 ++++ drivers/gpu/drm/drm_color_mgmt.c | 43 + drivers/gpu/drm/drm_colorop.c | 600 +++++++++++++ drivers/gpu/drm/drm_connector.c | 1 + drivers/gpu/drm/drm_crtc_internal.h | 1 + drivers/gpu/drm/drm_ioctl.c | 7 + drivers/gpu/drm/drm_mode_config.c | 7 + drivers/gpu/drm/drm_mode_object.c | 18 + drivers/gpu/drm/drm_plane.c | 59 ++ drivers/gpu/drm/i915/Makefile | 2 + drivers/gpu/drm/i915/display/intel_color.c | 314 +++++++ drivers/gpu/drm/i915/display/intel_color.h | 6 +- .../drm/i915/display/intel_color_pipeline.c | 130 +++ .../drm/i915/display/intel_color_pipeline.h | 14 + drivers/gpu/drm/i915/display/intel_colorop.c | 35 + drivers/gpu/drm/i915/display/intel_colorop.h | 15 + drivers/gpu/drm/i915/display/intel_display.c | 5 +- .../drm/i915/display/intel_display_limits.h | 9 + .../drm/i915/display/intel_display_types.h | 9 + drivers/gpu/drm/i915/display/intel_plane.c | 55 ++ .../drm/i915/display/skl_universal_plane.c | 21 + .../i915/display/skl_universal_plane_regs.h | 153 ++++ drivers/gpu/drm/tests/Makefile | 3 +- drivers/gpu/drm/tests/drm_fixp_test.c | 71 ++ drivers/gpu/drm/vkms/Makefile | 4 +- drivers/gpu/drm/vkms/tests/Makefile | 2 +- drivers/gpu/drm/vkms/tests/vkms_color_test.c | 417 +++++++++ drivers/gpu/drm/vkms/vkms_colorop.c | 120 +++ drivers/gpu/drm/vkms/vkms_composer.c | 135 ++- drivers/gpu/drm/vkms/vkms_composer.h | 28 + drivers/gpu/drm/vkms/vkms_drv.c | 1 + drivers/gpu/drm/vkms/vkms_drv.h | 7 + drivers/gpu/drm/vkms/vkms_luts.c | 811 ++++++++++++++++++ drivers/gpu/drm/vkms/vkms_luts.h | 12 + drivers/gpu/drm/vkms/vkms_plane.c | 2 + drivers/gpu/drm/xe/Makefile | 2 + include/drm/drm_atomic.h | 111 +++ include/drm/drm_atomic_uapi.h | 3 + include/drm/drm_color_mgmt.h | 29 + include/drm/drm_colorop.h | 462 ++++++++++ include/drm/drm_file.h | 7 + include/drm/drm_fixed.h | 18 + include/drm/drm_mode_config.h | 18 + include/drm/drm_plane.h | 19 + include/uapi/drm/amdgpu_drm.h | 9 - include/uapi/drm/drm.h | 15 + include/uapi/drm/drm_mode.h | 134 +++ 61 files changed, 5704 insertions(+), 67 deletions(-) create mode 100644 Documentation/gpu/rfc/color_pipeline.rst create mode 100644 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_colorop.c create mode 100644 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_colorop.h create mode 100644 drivers/gpu/drm/drm_colorop.c create mode 100644 drivers/gpu/drm/i915/display/intel_color_pipeline.c create mode 100644 drivers/gpu/drm/i915/display/intel_color_pipeline.h create mode 100644 drivers/gpu/drm/i915/display/intel_colorop.c create mode 100644 drivers/gpu/drm/i915/display/intel_colorop.h create mode 100644 drivers/gpu/drm/tests/drm_fixp_test.c create mode 100644 drivers/gpu/drm/vkms/tests/vkms_color_test.c create mode 100644 drivers/gpu/drm/vkms/vkms_colorop.c create mode 100644 drivers/gpu/drm/vkms/vkms_composer.h create mode 100644 drivers/gpu/drm/vkms/vkms_luts.c create mode 100644 drivers/gpu/drm/vkms/vkms_luts.h create mode 100644 include/drm/drm_colorop.h
Signature · 1 line
2.50.1
PATCH v6 1/16 drm: AMD series squashed
From: Harry Wentland <[email protected]>
This is a squashed patch based on a series sent out by Alex Hung and Harry wentland. It contains all the changes in the series(v12) currently under review below.
https://patchwork.freedesktop.org/series/152970/
This patch lays the ground work for incremental changes and Intel specific pipeline changes.
NOTE: This patch is not meant for review. Any review related to this patch should be done on the original series. In order not to diverge the discussion from the main series.
--- Documentation/gpu/drm-kms.rst | 15 + Documentation/gpu/rfc/color_pipeline.rst | 378 ++++++++ Documentation/gpu/rfc/index.rst | 3 + drivers/gpu/drm/Makefile | 1 + .../gpu/drm/amd/display/amdgpu_dm/Makefile | 3 +- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 + .../amd/display/amdgpu_dm/amdgpu_dm_color.c | 768 ++++++++++++++++- .../amd/display/amdgpu_dm/amdgpu_dm_colorop.c | 208 +++++ .../amd/display/amdgpu_dm/amdgpu_dm_colorop.h | 36 + .../amd/display/amdgpu_dm/amdgpu_dm_crtc.c | 26 +- .../amd/display/amdgpu_dm/amdgpu_dm_plane.c | 39 + drivers/gpu/drm/drm_atomic.c | 170 +++- drivers/gpu/drm/drm_atomic_helper.c | 12 + drivers/gpu/drm/drm_atomic_state_helper.c | 5 + drivers/gpu/drm/drm_atomic_uapi.c | 159 ++++ drivers/gpu/drm/drm_color_mgmt.c | 43 + drivers/gpu/drm/drm_colorop.c | 600 +++++++++++++ drivers/gpu/drm/drm_connector.c | 1 + drivers/gpu/drm/drm_crtc_internal.h | 1 + drivers/gpu/drm/drm_ioctl.c | 7 + drivers/gpu/drm/drm_mode_config.c | 7 + drivers/gpu/drm/drm_mode_object.c | 18 + drivers/gpu/drm/drm_plane.c | 59 ++ drivers/gpu/drm/tests/Makefile | 3 +- drivers/gpu/drm/tests/drm_fixp_test.c | 71 ++ drivers/gpu/drm/vkms/Makefile | 4 +- drivers/gpu/drm/vkms/tests/Makefile | 2 +- drivers/gpu/drm/vkms/tests/vkms_color_test.c | 417 +++++++++ drivers/gpu/drm/vkms/vkms_colorop.c | 120 +++ drivers/gpu/drm/vkms/vkms_composer.c | 135 ++- drivers/gpu/drm/vkms/vkms_composer.h | 28 + drivers/gpu/drm/vkms/vkms_drv.c | 1 + drivers/gpu/drm/vkms/vkms_drv.h | 7 + drivers/gpu/drm/vkms/vkms_luts.c | 811 ++++++++++++++++++ drivers/gpu/drm/vkms/vkms_luts.h | 12 + drivers/gpu/drm/vkms/vkms_plane.c | 2 + include/drm/drm_atomic.h | 111 +++ include/drm/drm_atomic_uapi.h | 3 + include/drm/drm_color_mgmt.h | 29 + include/drm/drm_colorop.h | 462 ++++++++++ include/drm/drm_file.h | 7 + include/drm/drm_fixed.h | 18 + include/drm/drm_mode_config.h | 18 + include/drm/drm_plane.h | 19 + include/uapi/drm/amdgpu_drm.h | 9 - include/uapi/drm/drm.h | 15 + include/uapi/drm/drm_mode.h | 134 +++ 47 files changed, 4936 insertions(+), 65 deletions(-) create mode 100644 Documentation/gpu/rfc/color_pipeline.rst create mode 100644 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_colorop.c create mode 100644 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_colorop.h create mode 100644 drivers/gpu/drm/drm_colorop.c create mode 100644 drivers/gpu/drm/tests/drm_fixp_test.c create mode 100644 drivers/gpu/drm/vkms/tests/vkms_color_test.c create mode 100644 drivers/gpu/drm/vkms/vkms_colorop.c create mode 100644 drivers/gpu/drm/vkms/vkms_composer.h create mode 100644 drivers/gpu/drm/vkms/vkms_luts.c create mode 100644 drivers/gpu/drm/vkms/vkms_luts.h create mode 100644 include/drm/drm_colorop.h
Documentation/gpu/drm-kms.rst +15 -0
@@ -413,6 +413,21 @@ Plane Panic Functions Reference .. kernel-doc:: drivers/gpu/drm/drm_panic.c :export: +Colorop Abstraction +=================== + +.. kernel-doc:: drivers/gpu/drm/drm_colorop.c + :doc: overview + +Colorop Functions Reference +--------------------------- + +.. kernel-doc:: include/drm/drm_colorop.h + :internal: + +.. kernel-doc:: drivers/gpu/drm/drm_colorop.c + :export: + Display Modes Function Reference ================================
Documentation/gpu/rfc/color_pipeline.rst new file +378 -0
379 lines not on this page · raw message
Documentation/gpu/rfc/index.rst +3 -0
@@ -35,3 +35,6 @@ host such documentation: .. toctree:: i915_vm_bind.rst + +.. toctree:: + color_pipeline.rst
drivers/gpu/drm/Makefile +1 -0
@@ -41,6 +41,7 @@ drm-y := \ drm_bridge.o \ drm_cache.o \ drm_color_mgmt.o \ + drm_colorop.o \ drm_connector.o \ drm_crtc.o \ drm_displayid.o \
drivers/gpu/drm/amd/display/amdgpu_dm/Makefile +2 -1
@@ -39,7 +39,8 @@ AMDGPUDM = \ amdgpu_dm_psr.o \ amdgpu_dm_replay.o \ amdgpu_dm_quirks.o \ - amdgpu_dm_wb.o + amdgpu_dm_wb.o \ + amdgpu_dm_colorop.o ifdef CONFIG_DRM_AMD_DC_FP AMDGPUDM += dc_fpu.o
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +4 -0
@@ -5880,6 +5880,10 @@ fill_plane_color_attributes(const struct drm_plane_state *plane_state, *color_space =COLOR_SPACE_SRGB ; +/* Ignore properties when DRM_CLIENT_CAP_PLANE_COLOR_PIPELINE is set */ +if (plane_state->state && plane_state->state->plane_color_pipeline) +return 0 ; +/* DRM color properties only affect non-RGB formats. */ if (format <SURFACE_PIXEL_FORMAT_VIDEO_BEGIN )return 0 ;
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_color.c +748 -20
849 lines not on this page · raw message
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_colorop.c new file +208 -0
208 lines not on this page · raw message
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_colorop.h new file +36 -0
@@ -0,0 +1,36 @@ +/* SPDX-License-Identifier: MIT */ +/* +* Copyright 2023 Advanced Micro Devices, Inc. +* +* Permission is hereby granted, free of charge, to any person obtaining a +* copy of this software and associated documentation files (the "Software"), +* to deal in the Software without restriction, including without limitation +* the rights to use, copy, modify, merge, publish, distribute, sublicense, +* and/or sell copies of the Software, and to permit persons to whom the +* Software is furnished to do so, subject to the following conditions: +* +* The above copyright notice and this permission notice shall be included in +* all copies or substantial portions of the Software. +* +* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR +* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, +* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL +* THE COPYRIGHT HOLDER(S) OR AUTHOR(S) BE LIABLE FOR ANY CLAIM, DAMAGES OR +* OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, +* ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR +* OTHER DEALINGS IN THE SOFTWARE. +* +* Authors: AMD +* +*/ + +#ifndef __AMDGPU_DM_COLOROP_H__ +#define __AMDGPU_DM_COLOROP_H__ + +extern const u64 amdgpu_dm_supported_degam_tfs; +extern const u64 amdgpu_dm_supported_shaper_tfs; +extern const u64 amdgpu_dm_supported_blnd_tfs; + +int amdgpu_dm_initialize_default_pipeline (struct drm_plane *plane,struct drm_prop_enum_list *list); + +#endif /* __AMDGPU_DM_COLOROP_H__*/
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crtc.c +12 -14
@@ -736,7 +736,7 @@ int amdgpu_dm_crtc_init(struct amdgpu_display_manager *dm, {struct amdgpu_crtc *acrtc =NULL ;struct drm_plane *cursor_plane; -bool is_dcn; +bool has_degamma;int res = -ENOMEM ; cursor_plane =kzalloc (sizeof (*cursor_plane),GFP_KERNEL );
@@ -775,20 +775,18 @@ int amdgpu_dm_crtc_init(struct amdgpu_display_manager *dm, dm->adev->mode_info.crtcs[crtc_index] = acrtc; -/* Don't enable DRM CRTC degamma property for DCE since it doesn't -* support programmable degamma anywhere. +/* Don't enable DRM CRTC degamma property for +* 1. Degamma is replaced by color pipeline. +* 2. DCE since it doesn't support programmable degamma anywhere. +* 3. DCN401 since pre-blending degamma LUT doesn't apply to cursor. */ - is_dcn = dm->adev->dm.dc->caps.color.dpp.dcn_arch; -/* Dont't enable DRM CRTC degamma property for DCN401 since the -* pre-blending degamma LUT doesn't apply to cursor, and therefore -* can't work similar to a post-blending degamma LUT as in other hw -* versions. -* TODO: revisit it once KMS plane color API is merged. -*/ -drm_crtc_enable_color_mgmt (&acrtc->base, - (is_dcn && - dm->adev->dm.dc->ctx->dce_version !=DCN_VERSION_4_01 ) ? -MAX_COLOR_LUT_ENTRIES :0 , +if (plane->color_pipeline_property) + has_degamma = false; +else + has_degamma = dm->adev->dm.dc->caps.color.dpp.dcn_arch && + dm->adev->dm.dc->ctx->dce_version !=DCN_VERSION_4_01 ; + +drm_crtc_enable_color_mgmt (&acrtc->base, has_degamma ?MAX_COLOR_LUT_ENTRIES :0 , true,MAX_COLOR_LUT_ENTRIES );drm_mode_crtc_set_gamma_size (&acrtc->base,MAX_COLOR_LEGACY_LUT_ENTRIES );
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c +39 -0
@@ -37,6 +37,7 @@#include "amdgpu_display.h" #include "amdgpu_dm_trace.h" #include "amdgpu_dm_plane.h" +#include "amdgpu_dm_colorop.h" #include "gc/gc_11_0_0_offset.h" #include "gc/gc_11_0_0_sh_mask.h"
@@ -1782,6 +1783,39 @@ dm_atomic_plane_get_property(struct drm_plane *plane,return 0 ; } +#else + +#define MAX_COLOR_PIPELINES 5 + +static int +dm_plane_init_colorops (struct drm_plane *plane) +{ +struct drm_prop_enum_list pipelines[MAX_COLOR_PIPELINES ]; +struct drm_device *dev = plane->dev; +struct amdgpu_device *adev =drm_to_adev (dev); +struct dc *dc = adev->dm.dc; +int len =0 ; +int ret; + +if (plane->type ==DRM_PLANE_TYPE_CURSOR ) +return 0 ; + +/* initialize pipeline */ +if (dc->ctx->dce_version >=DCN_VERSION_3_0 ) { + ret =amdgpu_dm_initialize_default_pipeline (plane, &(pipelines[len])); +if (ret) { +drm_err (plane->dev,"Failed to create color pipeline for plane %d: %d\n" , + plane->base.id, ret); +return ret; + } + len++; + +/* Create COLOR_PIPELINE property and attach */ +drm_plane_create_color_pipeline_property (plane, pipelines, len); + } + +return 0 ; +}#endif static const struct drm_plane_funcs dm_plane_funcs = {
@@ -1890,7 +1924,12 @@ int amdgpu_dm_plane_init(struct amdgpu_display_manager *dm,#ifdef AMD_PRIVATE_COLOR dm_atomic_plane_attach_color_mgmt_properties (dm, plane); +#else + res =dm_plane_init_colorops (plane); +if (res) +return res;#endif +/* Create (reset) the plane state */ if (plane->funcs->reset) plane->funcs->reset (plane);
drivers/gpu/drm/drm_atomic.c +169 -1
230 lines not on this page · raw message
drivers/gpu/drm/drm_atomic_helper.c +12 -0
@@ -3182,6 +3182,8 @@ int drm_atomic_helper_swap_state(struct drm_atomic_state *state,struct drm_crtc_state *old_crtc_state, *new_crtc_state;struct drm_plane *plane;struct drm_plane_state *old_plane_state, *new_plane_state; +struct drm_colorop *colorop; +struct drm_colorop_state *old_colorop_state, *new_colorop_state;struct drm_crtc_commit *commit;struct drm_private_obj *obj;struct drm_private_state *old_obj_state, *new_obj_state;
@@ -3259,6 +3261,16 @@ int drm_atomic_helper_swap_state(struct drm_atomic_state *state, } } +for_each_oldnew_colorop_in_state (state, colorop, old_colorop_state, new_colorop_state, i) { +WARN_ON (colorop->state != old_colorop_state); + + old_colorop_state->state = state; + new_colorop_state->state =NULL ; + + state->colorops[i].state = old_colorop_state; + colorop->state = new_colorop_state; + } +drm_panic_lock (state->dev, flags);for_each_oldnew_plane_in_state (state, plane, old_plane_state, new_plane_state, i) {WARN_ON (plane->state != old_plane_state);
drivers/gpu/drm/drm_atomic_state_helper.c +5 -0
@@ -268,6 +268,11 @@ void __drm_atomic_helper_plane_state_reset(struct drm_plane_state *plane_state, plane_state->color_range = val; } +if (plane->color_pipeline_property) { +/* default is always NULL, i.e., bypass */ + plane_state->color_pipeline =NULL ; + } + if (plane->zpos_property) { if (!drm_object_property_get_default_value(&plane->base, plane->zpos_property,
drivers/gpu/drm/drm_atomic_uapi.c +159 -0
207 lines not on this page · raw message
drivers/gpu/drm/drm_color_mgmt.c +43 -0
46 lines not on this page · raw message
drivers/gpu/drm/drm_colorop.c new file +600 -0
600 lines not on this page · raw message
drivers/gpu/drm/drm_connector.c +1 -0
@@ -3439,6 +3439,7 @@ int drm_mode_getconnector(struct drm_device *dev, void *data,* properties reflect the latest status. */ ret =drm_mode_object_get_properties (&connector->base, file_priv->atomic, + file_priv->plane_color_pipeline, (uint32_t __user *)(unsigned long )(out_resp->props_ptr), (uint64_t __user *)(unsigned long )(out_resp->prop_values_ptr), &out_resp->count_props);
drivers/gpu/drm/drm_crtc_internal.h +1 -0
@@ -163,6 +163,7 @@ struct drm_mode_object *__drm_mode_object_find(struct drm_device *dev,void drm_mode_object_unregister (struct drm_device *dev,struct drm_mode_object *object);int drm_mode_object_get_properties (struct drm_mode_object *obj,bool atomic, +bool plane_color_pipeline,uint32_t __user *prop_ptr,uint64_t __user *prop_values,uint32_t *arg_count_props);
drivers/gpu/drm/drm_ioctl.c +7 -0
@@ -373,6 +373,13 @@ drm_setclientcap(struct drm_device *dev, void *data, struct drm_file *file_priv)return -EINVAL ; file_priv->supports_virtualized_cursor_plane = req->value;break ; +case DRM_CLIENT_CAP_PLANE_COLOR_PIPELINE : +if (!file_priv->atomic) +return -EINVAL ; +if (req->value >1 ) +return -EINVAL ; + file_priv->plane_color_pipeline = req->value; +break ;default :return -EINVAL ; }
drivers/gpu/drm/drm_mode_config.c +7 -0
@@ -30,6 +30,7 @@#include <drm/drm_managed.h> #include <drm/drm_mode_config.h> #include <drm/drm_print.h> +#include <drm/drm_colorop.h> #include <linux/dma-resv.h> #include "drm_crtc_internal.h"
@@ -192,11 +193,15 @@ int drm_mode_getresources(struct drm_device *dev, void *data,void drm_mode_config_reset (struct drm_device *dev) {struct drm_crtc *crtc; +struct drm_colorop *colorop;struct drm_plane *plane;struct drm_encoder *encoder;struct drm_connector *connector;struct drm_connector_list_iter conn_iter; +drm_for_each_colorop (colorop, dev) +drm_colorop_reset (colorop); +drm_for_each_plane (plane, dev)if (plane->funcs->reset) plane->funcs->reset (plane);
@@ -437,6 +442,7 @@ int drmm_mode_config_init(struct drm_device *dev)INIT_LIST_HEAD (&dev->mode_config.property_list);INIT_LIST_HEAD (&dev->mode_config.property_blob_list);INIT_LIST_HEAD (&dev->mode_config.plane_list); +INIT_LIST_HEAD (&dev->mode_config.colorop_list);INIT_LIST_HEAD (&dev->mode_config.privobj_list);idr_init_base (&dev->mode_config.object_idr,1 );idr_init_base (&dev->mode_config.tile_idr,1 );
@@ -458,6 +464,7 @@ int drmm_mode_config_init(struct drm_device *dev) dev->mode_config.num_crtc =0 ; dev->mode_config.num_encoder =0 ; dev->mode_config.num_total_plane =0 ; + dev->mode_config.num_colorop =0 ;if (IS_ENABLED (CONFIG_LOCKDEP )) {struct drm_modeset_acquire_ctx modeset_ctx;
drivers/gpu/drm/drm_mode_object.c +18 -0
@@ -28,6 +28,7 @@#include <drm/drm_device.h> #include <drm/drm_file.h> #include <drm/drm_mode_object.h> +#include <drm/drm_plane.h> #include <drm/drm_print.h> #include "drm_crtc_internal.h"
@@ -386,6 +387,7 @@ EXPORT_SYMBOL(drm_object_property_get_default_value);/* helper for getconnector and getproperties ioctls */ int drm_mode_object_get_properties (struct drm_mode_object *obj,bool atomic, +bool plane_color_pipeline,uint32_t __user *prop_ptr,uint64_t __user *prop_values,uint32_t *arg_count_props)
@@ -399,6 +401,21 @@ int drm_mode_object_get_properties(struct drm_mode_object *obj, bool atomic,if ((prop->flags &DRM_MODE_PROP_ATOMIC ) && !atomic)continue ; +if (plane_color_pipeline && obj->type ==DRM_MODE_OBJECT_PLANE ) { +struct drm_plane *plane =obj_to_plane (obj); + +if (prop == plane->color_encoding_property || + prop == plane->color_range_property) +continue ; + } + +if (!plane_color_pipeline && obj->type ==DRM_MODE_OBJECT_PLANE ) { +struct drm_plane *plane =obj_to_plane (obj); + +if (prop == plane->color_pipeline_property) +continue ; + } +if (*arg_count_props > count) { ret =__drm_object_property_get_value (obj, prop, &val);if (ret)
@@ -457,6 +474,7 @@ int drm_mode_obj_get_properties_ioctl(struct drm_device *dev, void *data, } ret =drm_mode_object_get_properties (obj, file_priv->atomic, + file_priv->plane_color_pipeline, (uint32_t __user *)(unsigned long )(arg->props_ptr), (uint64_t __user *)(unsigned long )(arg->prop_values_ptr), &arg->count_props);
drivers/gpu/drm/drm_plane.c +59 -0
62 lines not on this page · raw message
drivers/gpu/drm/tests/Makefile +2 -1
@@ -24,6 +24,7 @@ obj-$(CONFIG_DRM_KUNIT_TEST) += \ drm_plane_helper_test.o \ drm_probe_helper_test.o \ drm_rect_test.o \ - drm_sysfb_modeset_test.o + drm_sysfb_modeset_test.o \ + drm_fixp_test.o CFLAGS_drm_mm_test.o := $(DISABLE_STRUCTLEAK_PLUGIN)
drivers/gpu/drm/tests/drm_fixp_test.c new file +71 -0
71 lines not on this page · raw message
drivers/gpu/drm/vkms/Makefile +3 -1
@@ -9,7 +9,9 @@ vkms-y := \ vkms_writeback.o \ vkms_connector.o \ vkms_config.o \ - vkms_configfs.o + vkms_configfs.o \ + vkms_colorop.o \ + vkms_luts.o obj-$(CONFIG_DRM_VKMS) += vkms.o obj-$(CONFIG_DRM_VKMS_KUNIT_TEST) += tests/
drivers/gpu/drm/vkms/tests/Makefile +1 -1
@@ -4,4 +4,4 @@ vkms-kunit-tests-y := \ vkms_config_test.o \ vkms_format_test.o
Lines of this file are not shown. View the raw message.
drivers/gpu/drm/vkms/tests/vkms_color_test.c new file +417 -0
417 lines not on this page · raw message
drivers/gpu/drm/vkms/vkms_colorop.c new file +120 -0
120 lines not on this page · raw message
drivers/gpu/drm/vkms/vkms_composer.c +118 -17
135 lines not on this page · raw message
drivers/gpu/drm/vkms/vkms_composer.h new file +28 -0
Lines of this file are not shown. View the raw message.
drivers/gpu/drm/vkms/vkms_luts.c new file +811 -0
811 lines not on this page · raw message
drivers/gpu/drm/vkms/vkms_luts.h new file +12 -0
Lines of this file are not shown. View the raw message.
include/drm/drm_atomic.h +111 -0
111 lines not on this page · raw message
include/drm/drm_colorop.h new file +462 -0
462 lines not on this page · raw message
include/uapi/drm/drm_mode.h +134 -0
134 lines not on this page · raw message
The rest of this diff is not shown. View the raw message.
Signature · 1 line
2.50.1
Part of the diff is not shown here. View the raw message.
PATCH v6 2/16 drm/i915: Add identifiers for driver specific blocks
In reply to Uma ShankarFrom: Chaitanya Kumar Borah <[email protected]>
Add macros to identify intel specific color blocks. It will help in mapping drm_color_ops to intel color HW blocks
v2:- Prefix enums with INTEL_* (Jani, Suraj)
- Remove unnecessary comments (Jani)
- Commit message improvements (Suraj)
--- drivers/gpu/drm/i915/display/intel_display_limits.h | 8 ++++++++ 1 file changed, 8 insertions(+)
drivers/gpu/drm/i915/display/intel_display_limits.h +8 -0
@@ -138,4 +138,12 @@ enum hpd_pin {HPD_NUM_PINS }; +enum intel_color_block { +INTEL_PLANE_CB_PRE_CSC_LUT , +INTEL_PLANE_CB_CSC , +INTEL_PLANE_CB_POST_CSC_LUT , + +INTEL_CB_MAX +}; +#endif /* __INTEL_DISPLAY_LIMITS_H__ */
Signature · 1 line
2.50.1
RE: [v6 02/16] drm/i915: Add identifiers for driver specific blocks
Quoted 1 line
Subject: [v6 02/16] drm/i915: Add identifiers for driver specific blocks
*drm/i915/display
With that fixed
LGTM,
Quoted 36 lines
From: Chaitanya Kumar Borah <[email protected]>
Add macros to identify intel specific color blocks. It will help in mapping
drm_color_opsto intel color HW blocksv2:- Prefix enums with INTEL_* (Jani, Suraj)
- Remove unnecessary comments (Jani)
- Commit message improvements (Suraj)Signed-off-by Chaitanya Kumar Borah <[email protected]>Signed-off-by Uma Shankar <[email protected]>--- drivers/gpu/drm/i915/display/intel_display_limits.h | 8 ++++++++ 1 file changed, 8 insertions(+)drivers/gpu/drm/i915/display/intel_display_limits.h +8
-1@@ -138,4 +138,12 @@ enum hpd_pin {HPD_NUM_PINS }; +enum intel_color_block { +INTEL_PLANE_CB_PRE_CSC_LUT , +INTEL_PLANE_CB_CSC , +INTEL_PLANE_CB_POST_CSC_LUT , + +INTEL_CB_MAX +}; +#endif /* __INTEL_DISPLAY_LIMITS_H__ */ --2.50.1
PATCH v6 3/16 drm/i915: Add intel_color_op
In reply to Uma ShankarFrom: Chaitanya Kumar Borah <[email protected]>
Add data structure to store intel specific details of colorop
v2:
- Remove dead code
- Convert macro to function (Jani)
- Remove colorop state as it is not being used
- Refactor to separate file
--- drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/display/intel_colorop.c | 10 ++++++++++ drivers/gpu/drm/i915/display/intel_colorop.h | 13 +++++++++++++ drivers/gpu/drm/i915/display/intel_display_types.h | 5 +++++ drivers/gpu/drm/xe/Makefile | 1 + 5 files changed, 30 insertions(+) create mode 100644 drivers/gpu/drm/i915/display/intel_colorop.c create mode 100644 drivers/gpu/drm/i915/display/intel_colorop.h
drivers/gpu/drm/i915/Makefile +1 -0
@@ -238,6 +238,7 @@ i915-y += \ display/intel_cdclk.o \ display/intel_cmtg.o \ display/intel_color.o \ + display/intel_colorop.o \ display/intel_combo_phy.o \ display/intel_connector.o \ display/intel_crtc.o \
drivers/gpu/drm/i915/display/intel_colorop.c new file +10 -0
@@ -0,0 +1,10 @@ +// SPDX-License-Identifier: MIT +/* +* Copyright © 2025 Intel Corporation +*/ +#include "intel_colorop.h" + +struct intel_colorop *to_intel_colorop (struct drm_colorop *colorop) +{ + return container_of(colorop, struct intel_colorop, base); +}
drivers/gpu/drm/i915/display/intel_colorop.h new file +13 -0
@@ -0,0 +1,13 @@ +/* SPDX-License-Identifier: MIT */ +/* +* Copyright © 2025 Intel Corporation +*/ + +#ifndef __INTEL_COLOROP_H__ +#define __INTEL_COLOROP_H__ + +#include "intel_display_types.h" + +struct intel_colorop *to_intel_colorop (struct drm_colorop *colorop); + +#endif /* __INTEL_COLOROP_H__ */
drivers/gpu/drm/i915/display/intel_display_types.h +5 -0
@@ -1986,6 +1986,11 @@ struct intel_dp_mst_encoder {struct intel_connector *connector; }; +struct intel_colorop { +struct drm_colorop base; +enum intel_color_block id; +}; +static inline struct intel_encoder *intel_attached_encoder (struct intel_connector *connector) {
drivers/gpu/drm/xe/Makefile +1 -0
@@ -240,6 +240,7 @@ xe-$(CONFIG_DRM_XE_DISPLAY) += \ i915-display/intel_cdclk.o \ i915-display/intel_cmtg.o \ i915-display/intel_color.o \ + i915-display/intel_colorop.o \ i915-display/intel_combo_phy.o \ i915-display/intel_connector.o \ i915-display/intel_crtc.o \
Signature · 1 line
2.50.1
RE: [v6 03/16] drm/i915: Add intel_color_op
Quoted 6 lines
Subject: [v6 03/16] drm/i915: Add
intel_color_opFrom: Chaitanya Kumar Borah <[email protected]>
Add data structure to store intel specific details of colorop
Quoted 8 lines
v2:
- Remove dead code
- Convert macro to function (Jani)
- Remove colorop state as it is not being used
- Refactor to separate fileSigned-off-by Chaitanya Kumar Borah <[email protected]>Signed-off-by Uma Shankar <[email protected]>
LGTM,
Quoted 87 lines
--- drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/display/intel_colorop.c | 10 ++++++++++ drivers/gpu/drm/i915/display/intel_colorop.h | 13 +++++++++++++ drivers/gpu/drm/i915/display/intel_display_types.h | 5 +++++ drivers/gpu/drm/xe/Makefile | 1 + 5 files changed, 30 insertions(+) create mode 100644 drivers/gpu/drm/i915/display/intel_colorop.c create mode 100644 drivers/gpu/drm/i915/display/intel_colorop.hdrivers/gpu/drm/i915/Makefile +1
-0@@ -238,6 +238,7 @@ i915-y += \ display/intel_cdclk.o \ display/intel_cmtg.o \ display/intel_color.o \ + display/intel_colorop.o \ display/intel_combo_phy.o \ display/intel_connector.o \ display/intel_crtc.o \drivers/gpu/drm/i915/display/intel_colorop.c new file +8
-0@@ -0,0 +1,10 @@ +// SPDX-License-Identifier: MIT +/* +* Copyright © 2025 Intel Corporation +*/ +#include "intel_colorop.h" + +struct intel_colorop *to_intel_colorop (struct drm_colorop *colorop) { + return container_of(colorop, struct intel_colorop, base); }drivers/gpu/drm/i915/display/intel_colorop.h new file +13
-0@@ -0,0 +1,13 @@ +/* SPDX-License-Identifier: MIT */ +/* +* Copyright © 2025 Intel Corporation +*/ + +#ifndef __INTEL_COLOROP_H__ +#define __INTEL_COLOROP_H__ + +#include "intel_display_types.h" + +struct intel_colorop *to_intel_colorop (struct drm_colorop *colorop); + +#endif /* __INTEL_COLOROP_H__ */ drivers/gpu/drm/i915/display/intel_display_types.h +5
-0@@ -1986,6 +1986,11 @@ struct intel_dp_mst_encoder {struct intel_connector *connector; }; +struct intel_colorop { +struct drm_colorop base; +enum intel_color_block id; +}; +static inline struct intel_encoder * intel_attached_encoder(struct intel_connector *connector) { diff --gita/drivers/gpu/drm/xe/Makefile b/drivers/gpu/drm/xe/Makefile index
7b4ca591a4ae..c89cafbd00fa100644drivers/gpu/drm/xe/Makefile +1
-1@@ -240,6 +240,7 @@ xe-$(CONFIG_DRM_XE_DISPLAY) += \ i915-display/intel_cdclk.o \ i915-display/intel_cmtg.o \ i915-display/intel_color.o \ + i915-display/intel_colorop.o \ i915-display/intel_combo_phy.o \ i915-display/intel_connector.o \ i915-display/intel_crtc.o \ --2.50.1
PATCH v6 4/16 drm/i915/color: Add helper to create intel colorop
In reply to Uma ShankarFrom: Chaitanya Kumar Borah <[email protected]>
Add intel colorop create helper
v2:
- Make function names consistent (Jani)
- Remove redundant code related to colorop state
- Refactor code to separate files
--- drivers/gpu/drm/i915/display/intel_colorop.c | 25 ++++++++++++++++++++ drivers/gpu/drm/i915/display/intel_colorop.h | 2 ++ 2 files changed, 27 insertions(+)
drivers/gpu/drm/i915/display/intel_colorop.c +25 -0
@@ -8,3 +8,28 @@ struct intel_colorop *to_intel_colorop(struct drm_colorop *colorop) { return container_of(colorop, struct intel_colorop, base); } + +struct intel_colorop *intel_colorop_alloc (void ) +{ +struct intel_colorop *colorop; + + colorop =kzalloc (sizeof (*colorop),GFP_KERNEL ); +if (!colorop) +return ERR_PTR (-ENOMEM ); + +return colorop; +} + +struct intel_colorop *intel_colorop_create (enum intel_color_block id) +{ +struct intel_colorop *colorop; + + colorop =intel_colorop_alloc (); + +if (IS_ERR (colorop)) +return colorop; + + colorop->id = id; + +return colorop; +}
drivers/gpu/drm/i915/display/intel_colorop.h +2 -0
@@ -9,5 +9,7 @@#include "intel_display_types.h" struct intel_colorop *to_intel_colorop (struct drm_colorop *colorop); +struct intel_colorop *intel_colorop_alloc (void ); +struct intel_colorop *intel_colorop_create (enum intel_color_block id);#endif /* __INTEL_COLOROP_H__ */
Signature · 1 line
2.50.1
RE: [v6 04/16] drm/i915/color: Add helper to create intel colorop
Quoted 6 lines
Subject: [v6 04/16] drm/i915/color: Add helper to create intel colorop
From: Chaitanya Kumar Borah <[email protected]>
Add intel colorop create helper
Quoted 7 lines
v2:
- Make function names consistent (Jani)
- Remove redundant code related to colorop state
- Refactor code to separate filesSigned-off-by Chaitanya Kumar Borah <[email protected]>Signed-off-by Uma Shankar <[email protected]>
LGTM,
Quoted 51 lines
--- drivers/gpu/drm/i915/display/intel_colorop.c | 25 ++++++++++++++++++++ drivers/gpu/drm/i915/display/intel_colorop.h | 2 ++ 2 files changed, 27 insertions(+)drivers/gpu/drm/i915/display/intel_colorop.c +23
-0@@ -8,3 +8,28 @@ struct intel_colorop *to_intel_colorop(struct drm_colorop *colorop) { return container_of(colorop, struct intel_colorop, base); } + +struct intel_colorop *intel_colorop_alloc (void ) { +struct intel_colorop *colorop; + + colorop =kzalloc (sizeof (*colorop),GFP_KERNEL ); +if (!colorop) +return ERR_PTR (-ENOMEM ); + +return colorop; +} + +struct intel_colorop *intel_colorop_create (enum intel_color_block id) { +struct intel_colorop *colorop; + + colorop =intel_colorop_alloc (); + +if (IS_ERR (colorop)) +return colorop; + + colorop->id = id; + +return colorop; +}drivers/gpu/drm/i915/display/intel_colorop.h +2
-1@@ -9,5 +9,7 @@#include "intel_display_types.h" struct intel_colorop *to_intel_colorop (struct drm_colorop *colorop); +struct intel_colorop *intel_colorop_alloc (void );struct intel_colorop +*intel_colorop_create (enum intel_color_block id);#endif /* __INTEL_COLOROP_H__ */ --2.50.1
PATCH v6 5/16 drm/i915/color: Create a transfer function color pipeline
In reply to Uma ShankarFrom: Chaitanya Kumar Borah <[email protected]>
Add a color pipeline with three colorops in the sequence
1D LUT - 3x4 CTM - 1D LUT
This pipeline can be used to do any color space conversion or HDR tone mapping
v2: Change namespace to drm_plane_colorop*
v3: Use simpler/pre-existing colorops for first iteration v4:
- s/*_tf_*/*_color_* (Jani)
- Refactor to separate files (Jani)
- Add missing space in comment (Suraj)
- Consolidate patch that adds/attaches pipeline property
--- drivers/gpu/drm/i915/Makefile | 1 + .../drm/i915/display/intel_color_pipeline.c | 101 ++++++++++++++++++ .../drm/i915/display/intel_color_pipeline.h | 13 +++ drivers/gpu/drm/xe/Makefile | 1 + 4 files changed, 116 insertions(+) create mode 100644 drivers/gpu/drm/i915/display/intel_color_pipeline.c create mode 100644 drivers/gpu/drm/i915/display/intel_color_pipeline.h
drivers/gpu/drm/i915/Makefile +1 -0
@@ -239,6 +239,7 @@ i915-y += \ display/intel_cmtg.o \ display/intel_color.o \ display/intel_colorop.o \ + display/intel_color_pipeline.o \ display/intel_combo_phy.o \ display/intel_connector.o \ display/intel_crtc.o \
drivers/gpu/drm/i915/display/intel_color_pipeline.c new file +101 -0
101 lines not on this page · raw message
drivers/gpu/drm/i915/display/intel_color_pipeline.h new file +13 -0
@@ -0,0 +1,13 @@ +/* SPDX-License-Identifier: MIT */ +/* +* Copyright © 2025 Intel Corporation +*/ + +#ifndef __INTEL_COLOR_PIPELINE_H__ +#define __INTEL_COLOR_PIPELINE_H__ + +struct drm_plane ; + +int intel_color_pipeline_plane_init (struct drm_plane *plane); + +#endif /* __INTEL_COLOR_PIPELINE_H__ */
drivers/gpu/drm/xe/Makefile +1 -0
@@ -241,6 +241,7 @@ xe-$(CONFIG_DRM_XE_DISPLAY) += \ i915-display/intel_cmtg.o \ i915-display/intel_color.o \ i915-display/intel_colorop.o \ + i915-display/intel_color_pipeline.o \ i915-display/intel_combo_phy.o \ i915-display/intel_connector.o \ i915-display/intel_crtc.o \
Signature · 1 line
2.50.1
RE: [v6 05/16] drm/i915/color: Create a transfer function color pipeline
Quoted 50 lines
Subject: [v6 05/16] drm/i915/color: Create a transfer function color pipeline
From: Chaitanya Kumar Borah <[email protected]>
Add a color pipeline with three colorops in the sequence
1D LUT - 3x4 CTM - 1D LUT
This pipeline can be used to do any color space conversion or HDR tone mapping
v2: Change namespace to drm_plane_colorop*
v3: Use simpler/pre-existing colorops for first iteration v4:
- s/*_tf_*/*_color_* (Jani)
- Refactor to separate files (Jani)
- Add missing space in comment (Suraj)
- Consolidate patch that adds/attaches pipeline propertySigned-off-by Uma Shankar <[email protected]>Signed-off-by Chaitanya Kumar Borah <[email protected]>--- drivers/gpu/drm/i915/Makefile | 1 + .../drm/i915/display/intel_color_pipeline.c | 101 ++++++++++++++++++ .../drm/i915/display/intel_color_pipeline.h | 13 +++ drivers/gpu/drm/xe/Makefile | 1 + 4 files changed, 116 insertions(+) create mode 100644 drivers/gpu/drm/i915/display/intel_color_pipeline.c create mode 100644 drivers/gpu/drm/i915/display/intel_color_pipeline.hdrivers/gpu/drm/i915/Makefile +1
-0@@ -239,6 +239,7 @@ i915-y += \ display/intel_cmtg.o \ display/intel_color.o \ display/intel_colorop.o \ + display/intel_color_pipeline.o \ display/intel_combo_phy.o \ display/intel_connector.o \ display/intel_crtc.o \drivers/gpu/drm/i915/display/intel_color_pipeline.c new file +1
-0@@ -0,0 +1,101 @@ +// SPDX-License-Identifier: MIT
drivers/gpu/drm/i915/display/intel_color_pipeline.c line 11
Quoted 10 lines
drivers/gpu/drm/i915/display/intel_color_pipeline.c new file +10
-0+/* +* Copyright © 2025 Intel Corporation +*/ +#include "intel_colorop.h" +#include "intel_color_pipeline.h" +#include "intel_de.h" +#include "intel_display_types.h" +#include "skl_universal_plane.h" + +#define MAX_COLOR_PIPELINES 5
Make this NUM_COLOR_PIPELINES 2
No point in attaching pipeline[5] when you only use also it does not Actually reflect any H/W limitations
When more pipelines are added it can be changed accordingly
Quoted 85 lines
drivers/gpu/drm/i915/display/intel_color_pipeline.c new file +14
-0+#define PLANE_DEGAMMA_SIZE 128 +#define PLANE_GAMMA_SIZE 32 + +static +int _intel_color_pipeline_plane_init (struct drm_plane *plane,struct +drm_prop_enum_list *list) { +struct intel_colorop *colorop; +struct drm_device *dev = plane->dev; +int ret; +struct drm_colorop *prev_op; + + colorop =intel_colorop_create (INTEL_PLANE_CB_PRE_CSC_LUT ); + + ret = drm_plane_colorop_curve_1d_lut_init(dev, &colorop->base,plane,
drivers/gpu/drm/i915/display/intel_color_pipeline.c new file +2
-0+ PLANE_DEGAMMA_SIZE, +
DRM_COLOROP_LUT1D_INTERPOLATION_LINEAR,
+DRM_COLOROP_FLAG_ALLOW_BYPASS);drivers/gpu/drm/i915/display/intel_color_pipeline.c new file +14
-0+ +if (ret) +return ret; + + list->type = colorop->base.base.id; + list->name =kasprintf (GFP_KERNEL ,"Color Pipeline %d" , +colorop->base.base.id); + +/* TODO: handle failures and clean up */ + prev_op = &colorop->base; + + colorop =intel_colorop_create (INTEL_PLANE_CB_CSC ); + ret = drm_plane_colorop_ctm_3x4_init(dev, &colorop->base, plane, +
DRM_COLOROP_FLAG_ALLOW_BYPASS);drivers/gpu/drm/i915/display/intel_color_pipeline.c new file +8
-0+if (ret) +return ret; + +drm_colorop_set_next_property (prev_op, &colorop->base); + prev_op = &colorop->base; + + colorop =intel_colorop_create (INTEL_PLANE_CB_POST_CSC_LUT ); + ret = drm_plane_colorop_curve_1d_lut_init(dev, &colorop->base,plane,
drivers/gpu/drm/i915/display/intel_color_pipeline.c new file +2
-0+ PLANE_GAMMA_SIZE, +
DRM_COLOROP_LUT1D_INTERPOLATION_LINEAR,
+DRM_COLOROP_FLAG_ALLOW_BYPASS);drivers/gpu/drm/i915/display/intel_color_pipeline.c new file +33
-0+if (ret) +return ret; + +drm_colorop_set_next_property (prev_op, &colorop->base); + +return 0 ; +} + +int intel_color_pipeline_plane_init (struct drm_plane *plane) { +struct drm_device *dev = plane->dev; +struct intel_display *display =to_intel_display (dev); +struct drm_property *prop; +struct drm_prop_enum_list pipelines[MAX_COLOR_PIPELINES ]; +int len =0 ; +int ret; + +/* Currently expose pipeline only for HDR planes */ +if (!icl_is_hdr_plane (display,to_intel_plane (plane)->id)) +return 0 ; + +/* Add "Bypass" (i.e. NULL) pipeline */ + pipelines[len].type =0 ; + pipelines[len].name ="Bypass" ; + len++; + +/* Add pipeline consisting of transfer functions */ + ret =_intel_color_pipeline_plane_init (plane, &pipelines[len]); +if (ret) +return ret; + len++; + +/* Create COLOR_PIPELINE property and attach */ + prop = drm_property_create_enum(dev,
DRM_MODE_PROP_ATOMIC,drivers/gpu/drm/i915/display/intel_color_pipeline.c new file +2
-0+"COLOR_PIPELINE" , + pipelines, len);
drivers/gpu/drm/i915/display/intel_color_pipeline.c line 98
Quoted 10 lines
drivers/gpu/drm/i915/display/intel_color_pipeline.c new file +10
-0+if (!prop) +return -ENOMEM ; + + plane->color_pipeline_property = prop; + +drm_object_attach_property (&plane->base, prop,0 ); + +/* TODO check if needed */ +if (plane->state) + plane->state->color_pipeline =NULL ;
I know you have added a TODO here but
I don’t get why is this added should this not be happening during some Atomic_duplicate_state or something.
Also it should be *TODO:
Regards,
Suraj Kandpal
Quoted 37 lines
drivers/gpu/drm/i915/display/intel_color_pipeline.c new file +3
-0+ +return 0 ; +}drivers/gpu/drm/i915/display/intel_color_pipeline.h new file +13
-0@@ -0,0 +1,13 @@ +/* SPDX-License-Identifier: MIT */ +/* +* Copyright © 2025 Intel Corporation +*/ + +#ifndef __INTEL_COLOR_PIPELINE_H__ +#define __INTEL_COLOR_PIPELINE_H__ + +struct drm_plane ; + +int intel_color_pipeline_plane_init (struct drm_plane *plane); + +#endif /* __INTEL_COLOR_PIPELINE_H__ */ drivers/gpu/drm/xe/Makefile +1
-1@@ -241,6 +241,7 @@ xe-$(CONFIG_DRM_XE_DISPLAY) += \ i915-display/intel_cmtg.o \ i915-display/intel_color.o \ i915-display/intel_colorop.o \ + i915-display/intel_color_pipeline.o \ i915-display/intel_combo_phy.o \ i915-display/intel_connector.o \ i915-display/intel_crtc.o \ --2.50.1
PATCH v6 6/16 drm/i915/color: Add framework to program CSC
In reply to Uma ShankarFrom: Chaitanya Kumar Borah <[email protected]>
Add framework to program CSC. It enables copying of matrix from uapi to intel plane state. Also adding helper functions which will eventually program values to hardware.
Add a crtc state variable to track plane color change.
v2:
- Add crtc_state->plane_color_changed
- Improve comments (Suraj)
- s/intel_plane_*_color/intel_plane_color_* (Suraj)
--- drivers/gpu/drm/i915/display/intel_color.c | 21 ++++++++ drivers/gpu/drm/i915/display/intel_color.h | 4 +- .../drm/i915/display/intel_display_types.h | 4 ++ drivers/gpu/drm/i915/display/intel_plane.c | 49 +++++++++++++++++++ 4 files changed, 77 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/display/intel_color.c +21 -0
@@ -87,6 +87,10 @@ struct intel_color_funcs {* Read config other than LUTs and CSCs, before them. Optional. */ void (*get_config)(struct intel_crtc_state *crtc_state); + +/* Plane CSC*/ +void (*load_plane_csc_matrix)(struct intel_dsb *dsb, +const struct intel_plane_state *plane_state); };#define CTM_COEFF_SIGN (1ULL << 63)
@@ -3962,6 +3966,23 @@ static const struct intel_color_funcs ilk_color_funcs = { .get_config = ilk_get_config, }; +static void +intel_color_load_plane_csc_matrix (struct intel_dsb *dsb, +const struct intel_plane_state *plane_state) +{ +struct intel_display *display =to_intel_display (plane_state); + +if (display->funcs.color->load_plane_csc_matrix) + display->funcs.color->load_plane_csc_matrix (dsb, plane_state); +} + +void intel_color_plane_program_pipeline (struct intel_dsb *dsb, +const struct intel_plane_state *plane_state) +{ +if (plane_state->hw.ctm) +intel_color_load_plane_csc_matrix (dsb, plane_state); +} +void intel_color_crtc_init (struct intel_crtc *crtc) {struct intel_display *display =to_intel_display (crtc);
drivers/gpu/drm/i915/display/intel_color.h +3 -1
@@ -13,6 +13,7 @@ struct intel_crtc_state;struct intel_crtc ;struct intel_display ;struct intel_dsb ; +struct intel_plane_state ;struct drm_property_blob ;void intel_color_init_hooks (struct intel_display *display);
@@ -40,5 +41,6 @@ bool intel_color_lut_equal(const struct intel_crtc_state *crtc_state,const struct drm_property_blob *blob2, bool is_pre_csc_lut);void intel_color_assert_luts (const struct intel_crtc_state *crtc_state); - +void intel_color_plane_program_pipeline (struct intel_dsb *dsb, +const struct intel_plane_state *plane_state);#endif /* __INTEL_COLOR_H__ */
drivers/gpu/drm/i915/display/intel_display_types.h +4 -0
@@ -646,6 +646,7 @@ struct intel_plane_state {enum drm_color_encoding color_encoding;enum drm_color_range color_range;enum drm_scaling_filter scaling_filter; +struct drm_property_blob *ctm; } hw;struct i915_vma *ggtt_vma;
@@ -1392,6 +1393,9 @@ struct intel_crtc_state {u8 silence_period_sym_clocks;u8 lfps_half_cycle_num_of_syms; } alpm_state; + +/* to track changes in plane color blocks */ +bool plane_color_changed; };enum intel_pipe_crc_source {
drivers/gpu/drm/i915/display/intel_plane.c +49 -0
67 lines not on this page · raw message
Signature · 1 line
2.50.1
RE: [v6 06/16] drm/i915/color: Add framework to program CSC
Quoted 5 lines
Subject: [v6 06/16] drm/i915/color: Add framework to program CSC
From: Chaitanya Kumar Borah <[email protected]>
Add framework to program CSC. It enables copying of matrix from uapi to intel
*UAPI
Quoted 1 line
plane state. Also adding helper functions which will eventually program values
*add
Quoted 165 lines
to hardware.
Add a crtc state variable to track plane color change.
v2:
- Addcrtc_state->plane_color_changed
- Improve comments (Suraj)
- s/intel_plane_*_color/intel_plane_color_* (Suraj)Signed-off-by Chaitanya Kumar Borah <[email protected]>Signed-off-by Uma Shankar <[email protected]>--- drivers/gpu/drm/i915/display/intel_color.c | 21 ++++++++ drivers/gpu/drm/i915/display/intel_color.h | 4 +- .../drm/i915/display/intel_display_types.h | 4 ++ drivers/gpu/drm/i915/display/intel_plane.c | 49 +++++++++++++++++++ 4 files changed, 77 insertions(+), 1 deletion(-)drivers/gpu/drm/i915/display/intel_color.c +4
-0@@ -87,6 +87,10 @@ struct intel_color_funcs {* Read config other than LUTs and CSCs, before them. Optional. */ void (*get_config)(struct intel_crtc_state *crtc_state); + +/* Plane CSC*/ +void (*load_plane_csc_matrix)(struct intel_dsb *dsb, +const struct intel_plane_state *plane_state); };#define
CTM_COEFF_SIGN(1ULL << 63)drivers/gpu/drm/i915/display/intel_color.c +10
-0@@ -3962,6 +3966,23 @@ static const struct intel_color_funcs ilk_color_funcs = { .get_config = ilk_get_config, }; +static void +intel_color_load_plane_csc_matrix (struct intel_dsb *dsb, +const struct intel_plane_state *plane_state) { +struct intel_display *display =to_intel_display (plane_state); + +if (display->funcs.color->load_plane_csc_matrix) + display->funcs.color->load_plane_csc_matrix (dsb, plane_state); } + +void intel_color_plane_program_pipeline (struct intel_dsb *dsb, + const struct intel_plane_state
*plane_state) {drivers/gpu/drm/i915/display/intel_color.c +3
-0+if (plane_state->hw.ctm) +intel_color_load_plane_csc_matrix (dsb, plane_state); } +void intel_color_crtc_init (struct intel_crtc *crtc) { struct intel_display *display = to_intel_display(crtc); diff --git
a/drivers/gpu/drm/i915/display/intel_color.hb/drivers/gpu/drm/i915/display/intel_color.h
indexbf7a12ce9df0..8051c827a1d8100644drivers/gpu/drm/i915/display/intel_color.h +1
-0@@ -13,6 +13,7 @@ struct intel_crtc_state; struct intel_crtc; struct intel_display;struct intel_dsb ; +struct intel_plane_state ;struct drm_property_blob ; void intel_color_init_hooks(struct intel_display *display); @@ -40,5 +41,6 @@ bool intel_color_lut_equal(const struct intel_crtc_state *crtc_state, const struct drm_property_blob *blob2,drivers/gpu/drm/i915/display/intel_color.h +2
-1bool is_pre_csc_lut);void intel_color_assert_luts (const struct intel_crtc_state *crtc_state); - +void intel_color_plane_program_pipeline (struct intel_dsb *dsb, + const struct intel_plane_state
*plane_state);
#endif /*__INTEL_COLOR_H__*/drivers/gpu/drm/i915/display/intel_display_types.h +4
-0@@ -646,6 +646,7 @@ struct intel_plane_state {enum drm_color_encoding color_encoding;enum drm_color_range color_range;enum drm_scaling_filter scaling_filter; +struct drm_property_blob *ctm; } hw;struct i915_vma *ggtt_vma;@@ -1392,6 +1393,9 @@ struct intel_crtc_state {u8 silence_period_sym_clocks;u8 lfps_half_cycle_num_of_syms; } alpm_state; + +/* to track changes in plane color blocks */ +bool plane_color_changed; };enum intel_pipe_crc_source {drivers/gpu/drm/i915/display/intel_plane.c +14
-0@@ -49,6 +49,7 @@#include "i9xx_plane_regs.h" #include "intel_cdclk.h" #include "intel_cursor.h" +#include "intel_colorop.h" #include "intel_display_rps.h" #include "intel_display_trace.h" #include "intel_display_types.h" @@ -336,6 +337,52 @@ intel_plane_copy_uapi_plane_damage(structintel_plane_state *new_plane_state, *damage =drm_plane_state_src (&new_uapi_plane_state- >uapi); } +static bool +intel_plane_colorop_replace_blob (struct intel_plane_state *plane_state, +struct intel_colorop *intel_colorop, +struct drm_property_blob *blob) +{ +if (intel_colorop->id ==INTEL_PLANE_CB_CSC ) +return drm_property_replace_blob (&plane_state->hw.ctm, blob); + +return false; +} + +static void +intel_plane_color_copy_uapi_to_hw_state(struct intel_plane_state
*plane_state,drivers/gpu/drm/i915/display/intel_plane.c +1
-0+ const struct intel_plane_state
*from_plane_state,drivers/gpu/drm/i915/display/intel_plane.c +9
-0+ struct intel_crtc *crtc) +{ +struct drm_colorop *iter_colorop, *colorop; +struct drm_colorop_state *new_colorop_state; +struct drm_atomic_state *state = plane_state->uapi.state; +struct intel_colorop *intel_colorop; +struct drm_property_blob *blob; +int i =0 ; + struct intel_atomic_state *intel_atomic_state =
to_intel_atomic_state(state);drivers/gpu/drm/i915/display/intel_plane.c +2
-0+struct intel_crtc_state *new_crtc_state = intel_atomic_state ? + intel_atomic_get_new_crtc_state(intel_atomic_state, crtc) :NULL;
drivers/gpu/drm/i915/display/intel_plane.c +6
-0+bool changed = false; + + iter_colorop = plane_state->uapi.color_pipeline; + +while (iter_colorop) { + for_each_new_colorop_in_state(state, colorop,
new_colorop_state, i) {drivers/gpu/drm/i915/display/intel_plane.c +2
-0+if (new_colorop_state->colorop == iter_colorop) { + blob = new_colorop_state->bypass ? NULL :
new_colorop_state->data;drivers/gpu/drm/i915/display/intel_plane.c +2
-0+ intel_colorop =to_intel_colorop (colorop); + changed |=intel_plane_colorop_replace_blob(plane_state,
+intel_colorop,
drivers/gpu/drm/i915/display/intel_plane.c intel_plane_copy_uapi_plane_damage(struct intel_plane_state *new_plane_state, · line 376
Quoted 1 line
drivers/gpu/drm/i915/display/intel_plane.c +1
-0+ blob);
These params need to be aligned with open braces.
Also I noticed a lot of checkpatch errors that can be resolved please run checkpatch --strict Resolve all of them then send the patches unless the warning or check is just unavoidable.
Regards,
Suraj Kandpal
Quoted 29 lines
drivers/gpu/drm/i915/display/intel_plane.c +8
-0+ } + } + iter_colorop = iter_colorop->next; + } + +if (new_crtc_state && changed) + new_crtc_state->plane_color_changed = true; } + void intel_plane_copy_uapi_to_hw_state(struct intel_plane_state
*plane_state,
const structintel_plane_state*from_plane_state,drivers/gpu/drm/i915/display/intel_plane.c +2
-0struct intel_crtc *crtc)@@ -364,6 +411,8 @@ void intel_plane_copy_uapi_to_hw_state(struct intel_plane_state *plane_state, plane_state->uapi.src =drm_plane_state_src (&from_plane_state- >uapi); plane_state->uapi.dst =drm_plane_state_dest (&from_plane_state- >uapi); + + intel_plane_color_copy_uapi_to_hw_state(plane_state,
from_plane_state,
+crtc);
}void intel_plane_copy_hw_state(struct
intel_plane_state*plane_state,
--
2.50.1
Re: [v6 06/16] drm/i915/color: Add framework to program CSC
Quoted 4 lines · Suraj
Quoted 4 lines
Subject: [v6 06/16] drm/i915/color: Add framework to program CSC
From: Chaitanya Kumar Borah <[email protected]>
Quoted 8 lines
Quoted 1 line
Add framework to program CSC. It enables copying of matrix from uapi to intel
*UAPI
Quoted 1 line
plane state. Also adding helper functions which will eventually program values
*add
Ack.
Quoted 160 lines
Quoted 160 lines
to hardware.
Add a crtc state variable to track plane color change.
v2:
- Addcrtc_state->plane_color_changed
- Improve comments (Suraj)
- s/intel_plane_*_color/intel_plane_color_* (Suraj)Signed-off-by Chaitanya Kumar Borah <[email protected]>Signed-off-by Uma Shankar <[email protected]>--- drivers/gpu/drm/i915/display/intel_color.c | 21 ++++++++ drivers/gpu/drm/i915/display/intel_color.h | 4 +- .../drm/i915/display/intel_display_types.h | 4 ++ drivers/gpu/drm/i915/display/intel_plane.c | 49 +++++++++++++++++++ 4 files changed, 77 insertions(+), 1 deletion(-)drivers/gpu/drm/i915/display/intel_color.c +4
-0@@ -87,6 +87,10 @@ struct intel_color_funcs {* Read config other than LUTs and CSCs, before them. Optional. */ void (*get_config)(struct intel_crtc_state *crtc_state); + +/* Plane CSC*/ +void (*load_plane_csc_matrix)(struct intel_dsb *dsb, +const struct intel_plane_state *plane_state); };#define CTM_COEFF_SIGN (1ULL << 63)drivers/gpu/drm/i915/display/intel_color.c +10
-0@@ -3962,6 +3966,23 @@ static const struct intel_color_funcs ilk_color_funcs = { .get_config = ilk_get_config, }; +static void +intel_color_load_plane_csc_matrix (struct intel_dsb *dsb, +const struct intel_plane_state *plane_state) { +struct intel_display *display =to_intel_display (plane_state); + +if (display->funcs.color->load_plane_csc_matrix) + display->funcs.color->load_plane_csc_matrix (dsb, plane_state); } + +void intel_color_plane_program_pipeline (struct intel_dsb *dsb, + const struct intel_plane_state
*plane_state) {drivers/gpu/drm/i915/display/intel_color.c +3
-0+if (plane_state->hw.ctm) +intel_color_load_plane_csc_matrix (dsb, plane_state); } +void intel_color_crtc_init (struct intel_crtc *crtc) { struct intel_display *display = to_intel_display(crtc); diff --git
a/drivers/gpu/drm/i915/display/intel_color.hb/drivers/gpu/drm/i915/display/intel_color.h
indexbf7a12ce9df0..8051c827a1d8100644drivers/gpu/drm/i915/display/intel_color.h +1
-0@@ -13,6 +13,7 @@ struct intel_crtc_state; struct intel_crtc; struct intel_display;struct intel_dsb ; +struct intel_plane_state ;struct drm_property_blob ; void intel_color_init_hooks(struct intel_display *display); @@ -40,5 +41,6 @@ bool intel_color_lut_equal(const struct intel_crtc_state *crtc_state, const struct drm_property_blob *blob2,bool is_pre_csc_lut); void intel_color_assert_luts(const struct intel_crtc_state *crtc_state);drivers/gpu/drm/i915/display/intel_color.h +2
-1- +void intel_color_plane_program_pipeline (struct intel_dsb *dsb, + const struct intel_plane_state
*plane_state);
#endif /*__INTEL_COLOR_H__*/drivers/gpu/drm/i915/display/intel_display_types.h +4
-0@@ -646,6 +646,7 @@ struct intel_plane_state {enum drm_color_encoding color_encoding;enum drm_color_range color_range;enum drm_scaling_filter scaling_filter; +struct drm_property_blob *ctm; } hw;struct i915_vma *ggtt_vma;@@ -1392,6 +1393,9 @@ struct intel_crtc_state {u8 silence_period_sym_clocks;u8 lfps_half_cycle_num_of_syms; } alpm_state; + +/* to track changes in plane color blocks */ +bool plane_color_changed; };enum intel_pipe_crc_source {drivers/gpu/drm/i915/display/intel_plane.c +14
-0@@ -49,6 +49,7 @@#include "i9xx_plane_regs.h" #include "intel_cdclk.h" #include "intel_cursor.h" +#include "intel_colorop.h" #include "intel_display_rps.h" #include "intel_display_trace.h" #include "intel_display_types.h" @@ -336,6 +337,52 @@ intel_plane_copy_uapi_plane_damage(structintel_plane_state *new_plane_state, *damage =drm_plane_state_src (&new_uapi_plane_state- > uapi); } +static bool +intel_plane_colorop_replace_blob (struct intel_plane_state *plane_state, +struct intel_colorop *intel_colorop, +struct drm_property_blob *blob) +{ +if (intel_colorop->id ==INTEL_PLANE_CB_CSC ) +return drm_property_replace_blob (&plane_state->hw.ctm, blob); + +return false; +} + +static void +intel_plane_color_copy_uapi_to_hw_state(struct intel_plane_state
*plane_state,drivers/gpu/drm/i915/display/intel_plane.c +1
-0+ const struct intel_plane_state
*from_plane_state,drivers/gpu/drm/i915/display/intel_plane.c +9
-0+ struct intel_crtc *crtc) +{ +struct drm_colorop *iter_colorop, *colorop; +struct drm_colorop_state *new_colorop_state; +struct drm_atomic_state *state = plane_state->uapi.state; +struct intel_colorop *intel_colorop; +struct drm_property_blob *blob; +int i =0 ; + struct intel_atomic_state *intel_atomic_state =
to_intel_atomic_state(state);drivers/gpu/drm/i915/display/intel_plane.c +2
-0+struct intel_crtc_state *new_crtc_state = intel_atomic_state ? + intel_atomic_get_new_crtc_state(intel_atomic_state, crtc) :NULL;
drivers/gpu/drm/i915/display/intel_plane.c +6
-0+bool changed = false; + + iter_colorop = plane_state->uapi.color_pipeline; + +while (iter_colorop) { + for_each_new_colorop_in_state(state, colorop,
new_colorop_state, i) {drivers/gpu/drm/i915/display/intel_plane.c +2
-0+if (new_colorop_state->colorop == iter_colorop) { + blob = new_colorop_state->bypass ? NULL :
new_colorop_state->data;
Quoted 8 lines
drivers/gpu/drm/i915/display/intel_plane.c intel_plane_copy_uapi_plane_damage(struct intel_plane_state *new_plane_state, · line 376
Quoted 6 lines
drivers/gpu/drm/i915/display/intel_plane.c +2
-0+ intel_colorop =to_intel_colorop (colorop); + changed |=intel_plane_colorop_replace_blob(plane_state,
+intel_colorop,drivers/gpu/drm/i915/display/intel_plane.c +1
-0+ blob);These params need to be aligned with open braces.
Ack.
Quoted 3 lines
Also I noticed a lot of checkpatch errors that can be resolved please run checkpatch --strict Resolve all of them then send the patches unless the warning or check is just unavoidable.
Anything you are particularly referring to in this patch?
Most of the warnings are from the squashed patch.
And then there are the register addition patches from where we should be able to fix the leading spaces ones. Will fix them in the next version.
==
Chaitanya
Quoted 33 lines
Regards,
Suraj KandpalQuoted 29 lines
drivers/gpu/drm/i915/display/intel_plane.c +8
-0+ } + } + iter_colorop = iter_colorop->next; + } + +if (new_crtc_state && changed) + new_crtc_state->plane_color_changed = true; } + void intel_plane_copy_uapi_to_hw_state(struct intel_plane_state
*plane_state,
const structintel_plane_state*from_plane_state,
structintel_crtc*crtc)drivers/gpu/drm/i915/display/intel_plane.c +2
-0@@ -364,6 +411,8 @@ void intel_plane_copy_uapi_to_hw_state(struct intel_plane_state *plane_state, plane_state->uapi.src =drm_plane_state_src (&from_plane_state- > uapi); plane_state->uapi.dst =drm_plane_state_dest (&from_plane_state- > uapi); + + intel_plane_color_copy_uapi_to_hw_state(plane_state,
from_plane_state,
+crtc);
}void intel_plane_copy_hw_state(struct
intel_plane_state*plane_state,
--
2.50.1
RE: [v6 06/16] drm/i915/color: Add framework to program CSC
Quoted 211 lines
-----Original Message-----
From: Borah, Chaitanya Kumar <[email protected]>
Sent: Tuesday, November 18, 2025 2:23 PM
To: Kandpal, Suraj <[email protected]>; Shankar, Uma <[email protected]>; [email protected]; intel- [email protected]; [email protected]
Cc: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; Sharma, Swati2 <[email protected]>; [email protected]; Nikula, Jani <[email protected]>
Subject: Re: [v6 06/16] drm/i915/color: Add framework to program CSCQuoted 7 lines · Suraj
Quoted 6 lines
Subject: [v6 06/16] drm/i915/color: Add framework to program CSC
From: Chaitanya Kumar Borah <[email protected]>
Add framework to program CSC. It enables copying of matrix from uapi to intel
Quoted 7 lines
*UAPI
Quoted 2 lines
plane state. Also adding helper functions which will eventually program values
*add
Ack.
Quoted 9 lines
Quoted 9 lines
to hardware.
Add a crtc state variable to track plane color change.
v2:
- Addcrtc_state->plane_color_changed
- Improve comments (Suraj)
- s/intel_plane_*_color/intel_plane_color_* (Suraj)Quoted 8 lines
Quoted 8 lines
Signed-off-by: Chaitanya Kumar Borah
<[email protected]>Signed-off-by Uma Shankar <[email protected]>--- drivers/gpu/drm/i915/display/intel_color.c | 21 ++++++++ drivers/gpu/drm/i915/display/intel_color.h | 4 +- .../drm/i915/display/intel_display_types.h | 4 ++ drivers/gpu/drm/i915/display/intel_plane.c | 49+++++++++++++++++++
Quoted 52 lines
Quoted 52 lines
4 files changed, 77 insertions(+), 1 deletion(-)drivers/gpu/drm/i915/display/intel_color.c +4
-0@@ -87,6 +87,10 @@ struct intel_color_funcs {* Read config other than LUTs and CSCs, before them. Optional. */ void (*get_config)(struct intel_crtc_state *crtc_state); + +/* Plane CSC*/ +void (*load_plane_csc_matrix)(struct intel_dsb *dsb, +const struct intel_plane_state *plane_state); };#define CTM_COEFF_SIGN (1ULL << 63)drivers/gpu/drm/i915/display/intel_color.c +10
-0@@ -3962,6 +3966,23 @@ static const struct intel_color_funcs ilk_color_funcs = { .get_config = ilk_get_config, }; +static void +intel_color_load_plane_csc_matrix (struct intel_dsb *dsb, +const struct intel_plane_state *plane_state) { +struct intel_display *display =to_intel_display (plane_state); + +if (display->funcs.color->load_plane_csc_matrix) + display->funcs.color->load_plane_csc_matrix (dsb, plane_state); } + +void intel_color_plane_program_pipeline (struct intel_dsb *dsb, + const struct intel_plane_state
*plane_state) {drivers/gpu/drm/i915/display/intel_color.c +3
-0+if (plane_state->hw.ctm) +intel_color_load_plane_csc_matrix (dsb, plane_state); } +void intel_color_crtc_init (struct intel_crtc *crtc) { struct intel_display *display = to_intel_display(crtc); diff --git
a/drivers/gpu/drm/i915/display/intel_color.hb/drivers/gpu/drm/i915/display/intel_color.h
indexbf7a12ce9df0..8051c827a1d8100644drivers/gpu/drm/i915/display/intel_color.h +1
-0@@ -13,6 +13,7 @@ struct intel_crtc_state; struct intel_crtc;struct intel_display ;struct intel_dsb ; +struct intel_plane_state ;struct drm_property_blob ;Quoted 2 lines
drivers/gpu/drm/i915/display/intel_color.h struct intel_crtc_state; struct intel_crtc; · line 17
Quoted 2 lines
drivers/gpu/drm/i915/display/intel_color.h +0
-1void intel_color_init_hooks(struct intel_display *display); @@ -40,5 +41,6 @@ bool intel_color_lut_equal(const struct intel_crtc_state
*crtc_state,Quoted 90 lines
Quoted 90 lines
drivers/gpu/drm/i915/display/intel_color.h +0
-0const struct drm_property_blob *blob2, bool is_pre_csc_lut); void intel_color_assert_luts(const struct intel_crtc_state
*crtc_state);drivers/gpu/drm/i915/display/intel_color.h +2
-1- +void intel_color_plane_program_pipeline (struct intel_dsb *dsb, + const struct intel_plane_state
*plane_state);
#endif /*__INTEL_COLOR_H__*/drivers/gpu/drm/i915/display/intel_display_types.h +4
-0@@ -646,6 +646,7 @@ struct intel_plane_state {enum drm_color_encoding color_encoding;enum drm_color_range color_range;enum drm_scaling_filter scaling_filter; +struct drm_property_blob *ctm; } hw;struct i915_vma *ggtt_vma;@@ -1392,6 +1393,9 @@ struct intel_crtc_state {u8 silence_period_sym_clocks;u8 lfps_half_cycle_num_of_syms; } alpm_state; + +/* to track changes in plane color blocks */ +bool plane_color_changed; };enum intel_pipe_crc_source {drivers/gpu/drm/i915/display/intel_plane.c +13
-0@@ -49,6 +49,7 @@#include "i9xx_plane_regs.h" #include "intel_cdclk.h" #include "intel_cursor.h" +#include "intel_colorop.h" #include "intel_display_rps.h" #include "intel_display_trace.h" #include "intel_display_types.h" @@ -336,6 +337,52 @@ intel_plane_copy_uapi_plane_damage(structintel_plane_state *new_plane_state, *damage =drm_plane_state_src (&new_uapi_plane_state- > uapi); } +static bool +intel_plane_colorop_replace_blob (struct intel_plane_state *plane_state, +struct intel_colorop *intel_colorop, +struct drm_property_blob *blob) { +if (intel_colorop->id ==INTEL_PLANE_CB_CSC ) +return drm_property_replace_blob (&plane_state->hw.ctm, blob); + +return false; +} + +static void +intel_plane_color_copy_uapi_to_hw_state(struct intel_plane_state
*plane_state,drivers/gpu/drm/i915/display/intel_plane.c +1
-0+ const struct intel_plane_state
*from_plane_state,drivers/gpu/drm/i915/display/intel_plane.c +9
-0+ struct intel_crtc *crtc) +{ +struct drm_colorop *iter_colorop, *colorop; +struct drm_colorop_state *new_colorop_state; +struct drm_atomic_state *state = plane_state->uapi.state; +struct intel_colorop *intel_colorop; +struct drm_property_blob *blob; +int i =0 ; + struct intel_atomic_state *intel_atomic_state =
to_intel_atomic_state(state);drivers/gpu/drm/i915/display/intel_plane.c +2
-0+struct intel_crtc_state *new_crtc_state = intel_atomic_state ? + intel_atomic_get_new_crtc_state(intel_atomic_state, crtc) :NULL;
drivers/gpu/drm/i915/display/intel_plane.c +6
-0+bool changed = false; + + iter_colorop = plane_state->uapi.color_pipeline; + +while (iter_colorop) { + for_each_new_colorop_in_state(state, colorop,
new_colorop_state, i) {drivers/gpu/drm/i915/display/intel_plane.c +2
-0+if (new_colorop_state->colorop == iter_colorop) { + blob = new_colorop_state->bypass ? NULL :
new_colorop_state->data;Quoted 8 lines
drivers/gpu/drm/i915/display/intel_plane.c intel_plane_copy_uapi_plane_damage(struct intel_plane_state *new_plane_state, · line 376
Quoted 6 lines
drivers/gpu/drm/i915/display/intel_plane.c +2
-0+ intel_colorop =to_intel_colorop (colorop); + changed |=intel_plane_colorop_replace_blob(plane_state,
+intel_colorop,drivers/gpu/drm/i915/display/intel_plane.c +1
-0+ blob);These params need to be aligned with open braces.
Ack.
Quoted 2 lines
Also I noticed a lot of checkpatch errors that can be resolved please run checkpatch --strict Resolve all of them then send the patches unless the
Quoted 7 lines
warning or check is just unavoidable.
Quoted 1 line
Anything you are particularly referring to in this patch? Most of the warnings are from the squashed patch.
And then there are the register addition patches from where we should be able to fix the leading spaces ones. Will fix them in the next version.
No not this patch but ones with your register definitions I get some macros cannot be resolved without breaking Other compliances but we need to make sure not checkpatch errors are coming up specially the trailing and leading spaces
Regards,
Suraj Kandpal
Quoted 39 lines
==
ChaitanyaQuoted 14 lines
Regards,
Suraj KandpalQuoted 11 lines
drivers/gpu/drm/i915/display/intel_plane.c +8
-0+ } + } + iter_colorop = iter_colorop->next; + } + +if (new_crtc_state && changed) + new_crtc_state->plane_color_changed = true; } + void intel_plane_copy_uapi_to_hw_state(struct intel_plane_state
*plane_state,
const structintel_plane_state
*from_plane_state,Quoted 1 line
Quoted 1 line
struct
intel_crtc*crtc) @@ -364,6 +411,8@@ void
Quoted 18 lines
Quoted 17 lines
intel_plane_copy_uapi_to_hw_state(struct
intel_plane_state*plane_state,
plane_state->uapi.src= drm_plane_state_src(&from_plane_state-Quoted 1 line
uapi);
plane_state->uapi.dst= drm_plane_state_dest(&from_plane_state-Quoted 1 line
uapi);
drivers/gpu/drm/i915/display/intel_plane.c +2
-0+ + intel_plane_color_copy_uapi_to_hw_state(plane_state,
from_plane_state,
+crtc);
}void intel_plane_copy_hw_state(struct
intel_plane_state*plane_state,
--
2.50.1
PATCH v6 7/16 drm/i915/color: Preserve sign bit when int_bits is Zero
In reply to Uma ShankarFrom: Chaitanya Kumar Borah <[email protected]>
When int_bits == 0, we lose the sign bit when we do the range check and apply the mask.
Fix this by ensuring a minimum of one integer bit, which guarantees space for the sign bit in fully fractional representations (e.g. S0.12)
--- drivers/gpu/drm/i915/display/intel_color.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/gpu/drm/i915/display/intel_color.c +2 -0
@@ -613,6 +613,8 @@ static u16 ctm_to_twos_complement(u64 coeff, int int_bits, int frac_bits)if (CTM_COEFF_NEGATIVE (coeff)) c = -c; + int_bits =max (int_bits,1 ); + c =clamp (c, -(s64 )BIT (int_bits + frac_bits -1 ), (s64)(BIT (int_bits + frac_bits -1 ) -1 ));
Signature · 1 line
2.50.1
RE: [v6 07/16] drm/i915/color: Preserve sign bit when int_bits is Zero
Quoted 4 lines
Subject: [v6 07/16] drm/i915/color: Preserve sign bit when
int_bitsis ZeroFrom: Chaitanya Kumar Borah <[email protected]>
Quoted 8 lines
When
int_bits== 0, we lose the sign bit when we do the range check and apply the mask.Fix this by ensuring a minimum of one integer bit, which guarantees space for the sign bit in fully fractional representations (e.g. S0.12)
Signed-off-by Chaitanya Kumar Borah <[email protected]>Signed-off-by Uma Shankar <[email protected]>
LGTM,
Quoted 21 lines
--- drivers/gpu/drm/i915/display/intel_color.c | 2 ++ 1 file changed, 2 insertions(+)drivers/gpu/drm/i915/display/intel_color.c +2
-1@@ -613,6 +613,8 @@ static u16 ctm_to_twos_complement(u64 coeff, int int_bits, int frac_bits)if (CTM_COEFF_NEGATIVE (coeff)) c = -c; + int_bits =max (int_bits,1 ); + c =clamp (c, -(s64 )BIT (int_bits + frac_bits -1 ), (s64)(BIT (int_bits + frac_bits -1 ) -1 )); --2.50.1
PATCH v6 8/16 drm/i915/color: Add plane CTM callback for D12 and beyond
In reply to Uma ShankarAdd callback for setting CTM block in platforms D12 and beyond
v2:
- Add dsb support
- Pass plane_state as we are now doing a uapi to hw state copy
- Add support for 3x4 matrix
v3:
- Add relevant header file
- Fix typo (Suraj)
- Add callback to TGL+ (Suraj)
--- drivers/gpu/drm/i915/display/intel_color.c | 98 ++++++++++++++++++++++ 1 file changed, 98 insertions(+)
drivers/gpu/drm/i915/display/intel_color.c +98 -0
@@ -32,6 +32,8 @@#include "intel_display_utils.h" #include "intel_dsb.h" #include "intel_vrr.h" +#include "skl_universal_plane.h" +#include "skl_universal_plane_regs.h" struct intel_color_funcs { int (*color_check)(struct intel_atomic_state *state,
@@ -3841,6 +3843,101 @@ static void icl_read_luts(struct intel_crtc_state *crtc_state) } } +static void +xelpd_load_plane_csc_matrix (struct intel_dsb *dsb, +const struct intel_plane_state *plane_state) +{ +struct intel_display *display =to_intel_display (plane_state); +const struct drm_plane_state *state = &plane_state->uapi; +enum pipe pipe =to_intel_plane (state->plane)->pipe; +enum plane_id plane =to_intel_plane (state->plane)->id; +const struct drm_property_blob *blob = plane_state->hw.ctm; +struct drm_color_ctm_3x4 *ctm; +const u64 *input; +u16 coeffs[9 ] = {}; +int i, j; + +if (!icl_is_hdr_plane (display, plane) || !blob) +return ; + + ctm = blob->data; + input = ctm->matrix; + +/* +* Convert fixed point S31.32 input to format supported by the +* hardware. +*/ +for (i =0 , j =0 ; i <ARRAY_SIZE (coeffs); i++) { +u64 abs_coeff = ((1ULL <<63 ) -1 ) & input[j]; + +/* +* Clamp input value to min/max supported by +* hardware. +*/ + abs_coeff =clamp_val (abs_coeff,0 ,CTM_COEFF_4_0 -1 ); + +/* sign bit */ +if (CTM_COEFF_NEGATIVE (input[j])) + coeffs[i] |=1 <<15 ; + +if (abs_coeff <CTM_COEFF_0_125 ) + coeffs[i] |= (3 <<12 ) | +ILK_CSC_COEFF_FP (abs_coeff,12 ); +else if (abs_coeff <CTM_COEFF_0_25 ) + coeffs[i] |= (2 <<12 ) | +ILK_CSC_COEFF_FP (abs_coeff,11 ); +else if (abs_coeff <CTM_COEFF_0_5 ) + coeffs[i] |= (1 <<12 ) | +ILK_CSC_COEFF_FP (abs_coeff,10 ); +else if (abs_coeff <CTM_COEFF_1_0 ) + coeffs[i] |=ILK_CSC_COEFF_FP (abs_coeff,9 ); +else if (abs_coeff <CTM_COEFF_2_0 ) + coeffs[i] |= (7 <<12 ) | +ILK_CSC_COEFF_FP (abs_coeff,8 ); +else + coeffs[i] |= (6 <<12 ) | +ILK_CSC_COEFF_FP (abs_coeff,7 ); + +/* Skip postoffs */ +if (!((j +2 ) %4 )) + j +=2 ; +else + j++; + } + +intel_de_write_dsb (display, dsb,PLANE_CSC_COEFF (pipe, plane,0 ), + coeffs[0 ] <<16 | coeffs[1 ]); +intel_de_write_dsb (display, dsb,PLANE_CSC_COEFF (pipe, plane,1 ), + coeffs[2 ] <<16 ); + +intel_de_write_dsb (display, dsb,PLANE_CSC_COEFF (pipe, plane,2 ), + coeffs[3 ] <<16 | coeffs[4 ]); +intel_de_write_dsb (display, dsb,PLANE_CSC_COEFF (pipe, plane,3 ), + coeffs[5 ] <<16 ); + +intel_de_write_dsb (display, dsb,PLANE_CSC_COEFF (pipe, plane,4 ), + coeffs[6 ] <<16 | coeffs[7 ]); +intel_de_write_dsb (display, dsb,PLANE_CSC_COEFF (pipe, plane,5 ), + coeffs[8 ] <<16 ); + +intel_de_write_dsb (display, dsb,PLANE_CSC_PREOFF (pipe, plane,0 ),0 ); +intel_de_write_dsb (display, dsb,PLANE_CSC_PREOFF (pipe, plane,1 ),0 ); +intel_de_write_dsb (display, dsb,PLANE_CSC_PREOFF (pipe, plane,2 ),0 ); + +/* +* Conversion from S31.32 to S0.12. BIT[12] is the signed bit +*/ +intel_de_write_dsb (display, dsb, +PLANE_CSC_POSTOFF (pipe, plane,0 ), +ctm_to_twos_complement (input[3 ],0 ,12 )); +intel_de_write_dsb (display, dsb, +PLANE_CSC_POSTOFF (pipe, plane,1 ), +ctm_to_twos_complement (input[7 ],0 ,12 )); +intel_de_write_dsb (display, dsb, +PLANE_CSC_POSTOFF (pipe, plane,2 ), +ctm_to_twos_complement (input[11 ],0 ,12 )); +} +static const struct intel_color_funcs chv_color_funcs = { .color_check = chv_color_check, .color_commit_arm = i9xx_color_commit_arm,
@@ -3888,6 +3985,7 @@ static const struct intel_color_funcs tgl_color_funcs = { .lut_equal = icl_lut_equal, .read_csc = icl_read_csc, .get_config = skl_get_config, + .load_plane_csc_matrix = xelpd_load_plane_csc_matrix, };static const struct intel_color_funcs icl_color_funcs = {
Signature · 1 line
2.50.1
PATCH v6 9/16 drm/i915: Add register definitions for Plane Degamma
In reply to Uma ShankarAdd macros to define Plane Degamma registers
BSpec: 50411, 50412, 50413, 50414
v2:
- Add BSpec links (Suraj)
--- .../i915/display/skl_universal_plane_regs.h | 53 +++++++++++++++++++ 1 file changed, 53 insertions(+)
drivers/gpu/drm/i915/display/skl_universal_plane_regs.h +53 -0
@@ -254,6 +254,7 @@#define PLANE_COLOR_PIPE_CSC_ENABLE REG_BIT(23)/* Pre-ICL */ #define PLANE_COLOR_PLANE_CSC_ENABLE REG_BIT(21)/* ICL+ */ #define PLANE_COLOR_INPUT_CSC_ENABLE REG_BIT(20)/* ICL+ */ +#define PLANE_COLOR_PRE_CSC_GAMMA_ENABLE REG_BIT(14)#define PLANE_COLOR_CSC_MODE_MASK REG_GENMASK(19, 17)#define PLANE_COLOR_CSC_MODE_BYPASS REG_FIELD_PREP(PLANE_COLOR_CSC_MODE_MASK, 0)#define PLANE_COLOR_CSC_MODE_YUV601_TO_RGB601 REG_FIELD_PREP(PLANE_COLOR_CSC_MODE_MASK, 1)
@@ -290,6 +291,58 @@ _PLANE_INPUT_CSC_POSTOFF_HI_1_A, _PLANE_INPUT_CSC_POSTOFF_HI_1_B, \ _PLANE_INPUT_CSC_POSTOFF_HI_2_A, _PLANE_INPUT_CSC_POSTOFF_HI_2_B) +#define _MMIO_PLANE_GAMC (plane, i, a, b) _MMIO(_PIPE(plane, a, b) + (i) * 4) + +/* Display13 Plane Degmma Reg */ +#define _PLANE_PRE_CSC_GAMC_INDEX_ENH_1_A 0x701d0 +#define _PLANE_PRE_CSC_GAMC_INDEX_ENH_1_B 0x711d0 +#define _PLANE_PRE_CSC_GAMC_INDEX_ENH_2_A 0x702d0 +#define _PLANE_PRE_CSC_GAMC_INDEX_ENH_2_B 0x712d0 +#define _PLANE_PRE_CSC_GAMC_INDEX_ENH_1 (pipe) _PIPE(pipe, _PLANE_PRE_CSC_GAMC_INDEX_ENH_1_A, \ + _PLANE_PRE_CSC_GAMC_INDEX_ENH_1_B) +#define _PLANE_PRE_CSC_GAMC_INDEX_ENH_2 (pipe) _PIPE(pipe, _PLANE_PRE_CSC_GAMC_INDEX_ENH_2_A, \ + _PLANE_PRE_CSC_GAMC_INDEX_ENH_2_B) +#define PLANE_PRE_CSC_GAMC_INDEX_ENH (pipe, plane, i) \ + _MMIO_PLANE_GAMC(plane, i, _PLANE_PRE_CSC_GAMC_INDEX_ENH_1(pipe), \ + _PLANE_PRE_CSC_GAMC_INDEX_ENH_2(pipe)) +#define PLANE_PAL_PREC_AUTO_INCREMENT REG_BIT(10) + +#define _PLANE_PRE_CSC_GAMC_DATA_ENH_1_A 0x701d4 +#define _PLANE_PRE_CSC_GAMC_DATA_ENH_1_B 0x711d4 +#define _PLANE_PRE_CSC_GAMC_DATA_ENH_2_A 0x702d4 +#define _PLANE_PRE_CSC_GAMC_DATA_ENH_2_B 0x712d4 +#define _PLANE_PRE_CSC_GAMC_DATA_ENH_1 (pipe) _PIPE(pipe, _PLANE_PRE_CSC_GAMC_DATA_ENH_1_A, \ + _PLANE_PRE_CSC_GAMC_DATA_ENH_1_B) +#define _PLANE_PRE_CSC_GAMC_DATA_ENH_2 (pipe) _PIPE(pipe, _PLANE_PRE_CSC_GAMC_DATA_ENH_2_A, \ + _PLANE_PRE_CSC_GAMC_DATA_ENH_2_B) +#define PLANE_PRE_CSC_GAMC_DATA_ENH (pipe, plane, i) \ + _MMIO_PLANE_GAMC(plane, i, _PLANE_PRE_CSC_GAMC_DATA_ENH_1(pipe), \ + _PLANE_PRE_CSC_GAMC_DATA_ENH_2(pipe)) + +#define _PLANE_PRE_CSC_GAMC_INDEX_1_A 0x704d0 +#define _PLANE_PRE_CSC_GAMC_INDEX_1_B 0x714d0 +#define _PLANE_PRE_CSC_GAMC_INDEX_2_A 0x705d0 +#define _PLANE_PRE_CSC_GAMC_INDEX_2_B 0x715d0 +#define _PLANE_PRE_CSC_GAMC_INDEX_1 (pipe) _PIPE(pipe, _PLANE_PRE_CSC_GAMC_INDEX_1_A, \ + _PLANE_PRE_CSC_GAMC_INDEX_1_B) +#define _PLANE_PRE_CSC_GAMC_INDEX_2 (pipe) _PIPE(pipe, _PLANE_PRE_CSC_GAMC_INDEX_2_A, \ + _PLANE_PRE_CSC_GAMC_INDEX_2_B) +#define PLANE_PRE_CSC_GAMC_INDEX (pipe, plane, i) \ + _MMIO_PLANE_GAMC(plane, i, _PLANE_PRE_CSC_GAMC_INDEX_1(pipe), \ + _PLANE_PRE_CSC_GAMC_INDEX_2(pipe)) + +#define _PLANE_PRE_CSC_GAMC_DATA_1_A 0x704d4 +#define _PLANE_PRE_CSC_GAMC_DATA_1_B 0x714d4 +#define _PLANE_PRE_CSC_GAMC_DATA_2_A 0x705d4 +#define _PLANE_PRE_CSC_GAMC_DATA_2_B 0x715d4 +#define _PLANE_PRE_CSC_GAMC_DATA_1 (pipe) _PIPE(pipe, _PLANE_PRE_CSC_GAMC_DATA_1_A, \ + _PLANE_PRE_CSC_GAMC_DATA_1_B) +#define _PLANE_PRE_CSC_GAMC_DATA_2 (pipe) _PIPE(pipe, _PLANE_PRE_CSC_GAMC_DATA_2_A, \ + _PLANE_PRE_CSC_GAMC_DATA_2_B) +#define PLANE_PRE_CSC_GAMC_DATA (pipe, plane, i) \ + _MMIO_PLANE_GAMC(plane, i, _PLANE_PRE_CSC_GAMC_DATA_1(pipe), \ + _PLANE_PRE_CSC_GAMC_DATA_2(pipe)) +#define _PLANE_CSC_RY_GY_1_A 0x70210#define _PLANE_CSC_RY_GY_2_A 0x70310#define _PLANE_CSC_RY_GY_1_B 0x71210
Signature · 1 line
2.50.1
RE: [v6 09/16] drm/i915: Add register definitions for Plane Degamma
Quoted 5 lines
Subject: [v6 09/16] drm/i915: Add register definitions for Plane Degamma
Add macros to define Plane Degamma registers
BSpec: 50411, 50412, 50413, 50414
Need to be in trailer right above the Signed-off-by
Regards,
Suraj Kandpal
Quoted 108 lines
v2:
- Add BSpec links (Suraj)Signed-off-by Uma Shankar <[email protected]>Signed-off-by Chaitanya Kumar Borah <[email protected]>--- .../i915/display/skl_universal_plane_regs.h | 53 +++++++++++++++++++ 1 file changed, 53 insertions(+)drivers/gpu/drm/i915/display/skl_universal_plane_regs.h +1
-0@@ -254,6 +254,7 @@#define PLANE_COLOR_PIPE_CSC_ENABLE REG_BIT(23)/* Pre-ICL */ #define PLANE_COLOR_PLANE_CSC_ENABLE REG_BIT(21)/* ICL+ */ #define PLANE_COLOR_INPUT_CSC_ENABLE REG_BIT(20)/* ICL+ */ +#define PLANE_COLOR_PRE_CSC_GAMMA_ENABLE REG_BIT(14)#define PLANE_COLOR_CSC_MODE_MASK REG_GENMASK(19, 17)#define
PLANE_COLOR_CSC_MODE_BYPASS
REG_FIELD_PREP(PLANE_COLOR_CSC_MODE_MASK, 0)
#definePLANE_COLOR_CSC_MODE_YUV601_TO_RGB601
REG_FIELD_PREP(PLANE_COLOR_CSC_MODE_MASK, 1)drivers/gpu/drm/i915/display/skl_universal_plane_regs.h +9
-0@@ -290,6 +291,58 @@ _PLANE_INPUT_CSC_POSTOFF_HI_1_A, _PLANE_INPUT_CSC_POSTOFF_HI_1_B, \ _PLANE_INPUT_CSC_POSTOFF_HI_2_A, _PLANE_INPUT_CSC_POSTOFF_HI_2_B) +#define _MMIO_PLANE_GAMC (plane, i, a, b) _MMIO(_PIPE(plane, a, b) + +(i) * 4) + +/* Display13 Plane Degmma Reg */ +#define _PLANE_PRE_CSC_GAMC_INDEX_ENH_1_A 0x701d0 +#define _PLANE_PRE_CSC_GAMC_INDEX_ENH_1_B 0x711d0 +#define _PLANE_PRE_CSC_GAMC_INDEX_ENH_2_A 0x702d0 +#define _PLANE_PRE_CSC_GAMC_INDEX_ENH_2_B 0x712d0 +#define _PLANE_PRE_CSC_GAMC_INDEX_ENH_1 (pipe) _PIPE(pipe,
_PLANE_PRE_CSC_GAMC_INDEX_ENH_1_A, \drivers/gpu/drm/i915/display/skl_universal_plane_regs.h +3
-0+ +_PLANE_PRE_CSC_GAMC_INDEX_ENH_1_B) +#define _PLANE_PRE_CSC_GAMC_INDEX_ENH_2 (pipe) _PIPE(pipe,
_PLANE_PRE_CSC_GAMC_INDEX_ENH_2_A, \drivers/gpu/drm/i915/display/skl_universal_plane_regs.h +3
-0+ _PLANE_PRE_CSC_GAMC_INDEX_ENH_2_B) +#define PLANE_PRE_CSC_GAMC_INDEX_ENH (pipe, plane, i) \ + _MMIO_PLANE_GAMC(plane, i,
_PLANE_PRE_CSC_GAMC_INDEX_ENH_1(pipe), \drivers/gpu/drm/i915/display/skl_universal_plane_regs.h +8
-0+ _PLANE_PRE_CSC_GAMC_INDEX_ENH_2(pipe)) +#define PLANE_PAL_PREC_AUTO_INCREMENT REG_BIT(10) + +#define _PLANE_PRE_CSC_GAMC_DATA_ENH_1_A 0x701d4 +#define _PLANE_PRE_CSC_GAMC_DATA_ENH_1_B 0x711d4 +#define _PLANE_PRE_CSC_GAMC_DATA_ENH_2_A 0x702d4 +#define _PLANE_PRE_CSC_GAMC_DATA_ENH_2_B 0x712d4 +#define _PLANE_PRE_CSC_GAMC_DATA_ENH_1 (pipe) _PIPE(pipe,
_PLANE_PRE_CSC_GAMC_DATA_ENH_1_A, \drivers/gpu/drm/i915/display/skl_universal_plane_regs.h +2
-0+ _PLANE_PRE_CSC_GAMC_DATA_ENH_1_B) +#define _PLANE_PRE_CSC_GAMC_DATA_ENH_2 (pipe) _PIPE(pipe,
_PLANE_PRE_CSC_GAMC_DATA_ENH_2_A, \drivers/gpu/drm/i915/display/skl_universal_plane_regs.h +3
-0+ _PLANE_PRE_CSC_GAMC_DATA_ENH_2_B) +#define PLANE_PRE_CSC_GAMC_DATA_ENH (pipe, plane, i) \ + _MMIO_PLANE_GAMC(plane, i,
_PLANE_PRE_CSC_GAMC_DATA_ENH_1(pipe), \drivers/gpu/drm/i915/display/skl_universal_plane_regs.h +7
-0+ _PLANE_PRE_CSC_GAMC_DATA_ENH_2(pipe)) + +#define _PLANE_PRE_CSC_GAMC_INDEX_1_A 0x704d0 #define +_PLANE_PRE_CSC_GAMC_INDEX_1_B 0x714d0 #define +_PLANE_PRE_CSC_GAMC_INDEX_2_A 0x705d0 #define +_PLANE_PRE_CSC_GAMC_INDEX_2_B 0x715d0 +#define _PLANE_PRE_CSC_GAMC_INDEX_1 (pipe) _PIPE(pipe,
_PLANE_PRE_CSC_GAMC_INDEX_1_A, \drivers/gpu/drm/i915/display/skl_universal_plane_regs.h +2
-0+ _PLANE_PRE_CSC_GAMC_INDEX_1_B) +#define _PLANE_PRE_CSC_GAMC_INDEX_2 (pipe) _PIPE(pipe,
_PLANE_PRE_CSC_GAMC_INDEX_2_A, \drivers/gpu/drm/i915/display/skl_universal_plane_regs.h +3
-0+ _PLANE_PRE_CSC_GAMC_INDEX_2_B) +#define PLANE_PRE_CSC_GAMC_INDEX (pipe, plane, i) \ + _MMIO_PLANE_GAMC(plane, i,
_PLANE_PRE_CSC_GAMC_INDEX_1(pipe), \drivers/gpu/drm/i915/display/skl_universal_plane_regs.h +7
-0+ _PLANE_PRE_CSC_GAMC_INDEX_2(pipe)) + +#define _PLANE_PRE_CSC_GAMC_DATA_1_A 0x704d4 +#define _PLANE_PRE_CSC_GAMC_DATA_1_B 0x714d4 +#define _PLANE_PRE_CSC_GAMC_DATA_2_A 0x705d4 +#define _PLANE_PRE_CSC_GAMC_DATA_2_B 0x715d4 +#define _PLANE_PRE_CSC_GAMC_DATA_1 (pipe) _PIPE(pipe,
_PLANE_PRE_CSC_GAMC_DATA_1_A, \drivers/gpu/drm/i915/display/skl_universal_plane_regs.h +2
-0+ _PLANE_PRE_CSC_GAMC_DATA_1_B) +#define _PLANE_PRE_CSC_GAMC_DATA_2 (pipe) _PIPE(pipe,
_PLANE_PRE_CSC_GAMC_DATA_2_A, \drivers/gpu/drm/i915/display/skl_universal_plane_regs.h +3
-0+ _PLANE_PRE_CSC_GAMC_DATA_2_B) +#define PLANE_PRE_CSC_GAMC_DATA (pipe, plane, i) \ + _MMIO_PLANE_GAMC(plane, i,
_PLANE_PRE_CSC_GAMC_DATA_1(pipe), \drivers/gpu/drm/i915/display/skl_universal_plane_regs.h +2
-1+ _PLANE_PRE_CSC_GAMC_DATA_2(pipe)) +#define _PLANE_CSC_RY_GY_1_A 0x70210#define _PLANE_CSC_RY_GY_2_A 0x70310#define _PLANE_CSC_RY_GY_1_B 0x71210 --2.50.1
PATCH v6 10/16 drm/i915/color: Add framework to program PRE/POST CSC LUT
In reply to Uma ShankarAdd framework that will help in loading LUT to Pre/Post CSC color blocks.
v2: Add dsb support
v3: Align enum names
v4: Propagate change in lut data to crtc_state
--- drivers/gpu/drm/i915/display/intel_color.c | 16 ++++++++++++++++ .../gpu/drm/i915/display/intel_display_types.h | 2 +- drivers/gpu/drm/i915/display/intel_plane.c | 4 ++++ 3 files changed, 21 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/display/intel_color.c +16 -0
@@ -93,6 +93,10 @@ struct intel_color_funcs {/* Plane CSC*/ void (*load_plane_csc_matrix)(struct intel_dsb *dsb,const struct intel_plane_state *plane_state); + +/* Plane Pre/Post CSC */ +void (*load_plane_luts)(struct intel_dsb *dsb, +const struct intel_plane_state *plane_state); };#define CTM_COEFF_SIGN (1ULL << 63)
@@ -4076,11 +4080,23 @@ intel_color_load_plane_csc_matrix(struct intel_dsb *dsb, display->funcs.color->load_plane_csc_matrix (dsb, plane_state); } +static void +intel_color_load_plane_luts (struct intel_dsb *dsb, +const struct intel_plane_state *plane_state) +{ +struct intel_display *display =to_intel_display (plane_state); + +if (display->funcs.color->load_plane_luts) + display->funcs.color->load_plane_luts (dsb, plane_state); +} +void intel_color_plane_program_pipeline (struct intel_dsb *dsb,const struct intel_plane_state *plane_state) {if (plane_state->hw.ctm)intel_color_load_plane_csc_matrix (dsb, plane_state); +if (plane_state->hw.degamma_lut || plane_state->hw.gamma_lut) +intel_color_load_plane_luts (dsb, plane_state); }void intel_color_crtc_init (struct intel_crtc *crtc)
drivers/gpu/drm/i915/display/intel_display_types.h +1 -1
@@ -646,7 +646,7 @@ struct intel_plane_state {enum drm_color_encoding color_encoding;enum drm_color_range color_range;enum drm_scaling_filter scaling_filter; -struct drm_property_blob *ctm; +struct drm_property_blob *ctm, *degamma_lut, *gamma_lut; } hw;struct i915_vma *ggtt_vma;
drivers/gpu/drm/i915/display/intel_plane.c +4 -0
@@ -344,6 +344,10 @@ intel_plane_colorop_replace_blob(struct intel_plane_state *plane_state, {if (intel_colorop->id ==INTEL_PLANE_CB_CSC )return drm_property_replace_blob (&plane_state->hw.ctm, blob); +else if (intel_colorop->id ==INTEL_PLANE_CB_PRE_CSC_LUT ) +return drm_property_replace_blob (&plane_state->hw.degamma_lut, blob); +else if (intel_colorop->id ==INTEL_PLANE_CB_POST_CSC_LUT ) +return drm_property_replace_blob (&plane_state->hw.gamma_lut, blob);return false; }
Signature · 1 line
2.50.1
RE: [v6 10/16] drm/i915/color: Add framework to program PRE/POST CSC LUT
Quoted 9 lines
Subject: [v6 10/16] drm/i915/color: Add framework to program PRE/POST CSC LUT
Add framework that will help in loading LUT to Pre/Post CSC color blocks.
v2: Add dsb support
v3: Align enum names
v4: Propagate change in lut data tocrtc_state
Move this patch just before the 12th patch so that the next commit introduces the Function that assigns load_plane_luts
Regards,
Suraj Kandpal
Quoted 84 lines
Signed-off-by Uma Shankar <[email protected]>Signed-off-by Chaitanya Kumar Borah <[email protected]>--- drivers/gpu/drm/i915/display/intel_color.c | 16 ++++++++++++++++ .../gpu/drm/i915/display/intel_display_types.h | 2 +- drivers/gpu/drm/i915/display/intel_plane.c | 4 ++++ 3 files changed, 21 insertions(+), 1 deletion(-)drivers/gpu/drm/i915/display/intel_color.c +4
-0@@ -93,6 +93,10 @@ struct intel_color_funcs {/* Plane CSC*/ void (*load_plane_csc_matrix)(struct intel_dsb *dsb,const struct intel_plane_state *plane_state); + +/* Plane Pre/Post CSC */ +void (*load_plane_luts)(struct intel_dsb *dsb, +const struct intel_plane_state *plane_state); };#define
CTM_COEFF_SIGN(1ULL << 63)drivers/gpu/drm/i915/display/intel_color.c +10
-0@@ -4076,11 +4080,23 @@ intel_color_load_plane_csc_matrix(struct intel_dsb *dsb, display->funcs.color->load_plane_csc_matrix (dsb, plane_state); } +static void +intel_color_load_plane_luts (struct intel_dsb *dsb, +const struct intel_plane_state *plane_state) { +struct intel_display *display =to_intel_display (plane_state); + +if (display->funcs.color->load_plane_luts) + display->funcs.color->load_plane_luts (dsb, plane_state); } +void intel_color_plane_program_pipeline (struct intel_dsb *dsb,const struct intel_plane_state *plane_state) {if (plane_state->hw.ctm)intel_color_load_plane_csc_matrix (dsb, plane_state); +if (plane_state->hw.degamma_lut || plane_state->hw.gamma_lut) +intel_color_load_plane_luts (dsb, plane_state); } void intel_color_crtc_init(struct intel_crtc *crtc) diff --git
a/drivers/gpu/drm/i915/display/intel_display_types.hb/drivers/gpu/drm/i915/display/intel_display_types.hindexd25f90ded71f..d8fe80a55601100644drivers/gpu/drm/i915/display/intel_display_types.h +1
-1@@ -646,7 +646,7 @@ struct intel_plane_state {enum drm_color_encoding color_encoding;enum drm_color_range color_range;enum drm_scaling_filter scaling_filter; -struct drm_property_blob *ctm; +struct drm_property_blob *ctm, *degamma_lut, *gamma_lut; } hw;drivers/gpu/drm/i915/display/intel_display_types.h +0
-0struct i915_vma *ggtt_vma;drivers/gpu/drm/i915/display/intel_plane.c +4
-0@@ -344,6 +344,10 @@ intel_plane_colorop_replace_blob(struct intel_plane_state *plane_state, {if (intel_colorop->id ==INTEL_PLANE_CB_CSC )return drm_property_replace_blob (&plane_state->hw.ctm, blob); +else if (intel_colorop->id ==INTEL_PLANE_CB_PRE_CSC_LUT ) +return drm_property_replace_blob (&plane_state- >hw.degamma_lut, blob); +else if (intel_colorop->id ==INTEL_PLANE_CB_POST_CSC_LUT ) +return drm_property_replace_blob (&plane_state- >hw.gamma_lut, blob);return false;
}
--
2.50.1
PATCH v6 11/16 drm/i915: Add register definitions for Plane Post CSC
In reply to Uma ShankarAdd macros to define Plane Post CSC registers
BSpec: 50403, 50404, 50405, 50406, 50409, 50410,
v2:
- Add Plane Post CSC Gamma Multi Segment Enable bit
- Add BSpec entries (Suraj)
--- .../i915/display/skl_universal_plane_regs.h | 74 +++++++++++++++++++ 1 file changed, 74 insertions(+)
drivers/gpu/drm/i915/display/skl_universal_plane_regs.h +74 -0
@@ -254,6 +254,7 @@#define PLANE_COLOR_PIPE_CSC_ENABLE REG_BIT(23)/* Pre-ICL */ #define PLANE_COLOR_PLANE_CSC_ENABLE REG_BIT(21)/* ICL+ */ #define PLANE_COLOR_INPUT_CSC_ENABLE REG_BIT(20)/* ICL+ */ +#define PLANE_COLOR_POST_CSC_GAMMA_MULTSEG_ENABLE REG_BIT(15)/* TGL+ */ #define PLANE_COLOR_PRE_CSC_GAMMA_ENABLE REG_BIT(14)#define PLANE_COLOR_CSC_MODE_MASK REG_GENMASK(19, 17)#define PLANE_COLOR_CSC_MODE_BYPASS REG_FIELD_PREP(PLANE_COLOR_CSC_MODE_MASK, 0)
@@ -293,6 +294,79 @@#define _MMIO_PLANE_GAMC (plane, i, a, b) _MMIO(_PIPE(plane, a, b) + (i) * 4) +/* Display13 Plane Gamma Reg */ +#define _PLANE_POST_CSC_GAMC_SEG0_INDEX_ENH_1_A 0x70160 +#define _PLANE_POST_CSC_GAMC_SEG0_INDEX_ENH_1_B 0x71160 +#define _PLANE_POST_CSC_GAMC_SEG0_INDEX_ENH_2_A 0x70260 +#define _PLANE_POST_CSC_GAMC_SEG0_INDEX_ENH_2_B 0x71260 +#define _PLANE_POST_CSC_GAMC_SEG0_INDEX_ENH_1 (pipe) _PIPE(pipe, _PLANE_POST_CSC_GAMC_SEG0_INDEX_ENH_1_A, \ + _PLANE_POST_CSC_GAMC_SEG0_INDEX_ENH_1_B) +#define _PLANE_POST_CSC_GAMC_SEG0_INDEX_ENH_2 (pipe) _PIPE(pipe, _PLANE_POST_CSC_GAMC_SEG0_INDEX_ENH_2_A, \ + _PLANE_POST_CSC_GAMC_SEG0_INDEX_ENH_2_B) +#define PLANE_POST_CSC_GAMC_SEG0_INDEX_ENH (pipe, plane, i) \ + _MMIO_PLANE_GAMC(plane, i, _PLANE_POST_CSC_GAMC_SEG0_INDEX_ENH_1(pipe), \ + _PLANE_POST_CSC_GAMC_SEG0_INDEX_ENH_2(pipe)) + +#define _PLANE_POST_CSC_GAMC_SEG0_DATA_ENH_1_A 0x70164 +#define _PLANE_POST_CSC_GAMC_SEG0_DATA_ENH_1_B 0x71164 +#define _PLANE_POST_CSC_GAMC_SEG0_DATA_ENH_2_A 0x70264 +#define _PLANE_POST_CSC_GAMC_SEG0_DATA_ENH_2_B 0x71264 +#define _PLANE_POST_CSC_GAMC_SEG0_DATA_ENH_1 (pipe) _PIPE(pipe, _PLANE_POST_CSC_GAMC_SEG0_DATA_ENH_1_A, \ + _PLANE_POST_CSC_GAMC_SEG0_DATA_ENH_1_B) +#define _PLANE_POST_CSC_GAMC_SEG0_DATA_ENH_2 (pipe) _PIPE(pipe, _PLANE_POST_CSC_GAMC_SEG0_DATA_ENH_2_A, \ + _PLANE_POST_CSC_GAMC_SEG0_DATA_ENH_2_B) +#define PLANE_POST_CSC_GAMC_SEG0_DATA_ENH (pipe, plane, i) \ + _MMIO_PLANE_GAMC(plane, i, _PLANE_POST_CSC_GAMC_SEG0_DATA_ENH_1(pipe), \ + _PLANE_POST_CSC_GAMC_SEG0_DATA_ENH_2(pipe)) + +#define _PLANE_POST_CSC_GAMC_INDEX_ENH_1_A 0x701d8 +#define _PLANE_POST_CSC_GAMC_INDEX_ENH_1_B 0x711d8 +#define _PLANE_POST_CSC_GAMC_INDEX_ENH_2_A 0x702d8 +#define _PLANE_POST_CSC_GAMC_INDEX_ENH_2_B 0x712d8 +#define _PLANE_POST_CSC_GAMC_INDEX_ENH_1 (pipe) _PIPE(pipe, _PLANE_POST_CSC_GAMC_INDEX_ENH_1_A, \ + _PLANE_POST_CSC_GAMC_INDEX_ENH_1_B) +#define _PLANE_POST_CSC_GAMC_INDEX_ENH_2 (pipe) _PIPE(pipe, _PLANE_POST_CSC_GAMC_INDEX_ENH_2_A, \ + _PLANE_POST_CSC_GAMC_INDEX_ENH_2_B) +#define PLANE_POST_CSC_GAMC_INDEX_ENH (pipe, plane, i) \ + _MMIO_PLANE_GAMC(plane, i, _PLANE_POST_CSC_GAMC_INDEX_ENH_1(pipe), \ + _PLANE_POST_CSC_GAMC_INDEX_ENH_2(pipe)) + +#define _PLANE_POST_CSC_GAMC_DATA_ENH_1_A 0x701dc +#define _PLANE_POST_CSC_GAMC_DATA_ENH_1_B 0x711dc +#define _PLANE_POST_CSC_GAMC_DATA_ENH_2_A 0x702dc +#define _PLANE_POST_CSC_GAMC_DATA_ENH_2_B 0x712dc +#define _PLANE_POST_CSC_GAMC_DATA_ENH_1 (pipe) _PIPE(pipe, _PLANE_POST_CSC_GAMC_DATA_ENH_1_A, \ + _PLANE_POST_CSC_GAMC_DATA_ENH_1_B) +#define _PLANE_POST_CSC_GAMC_DATA_ENH_2 (pipe) _PIPE(pipe, _PLANE_POST_CSC_GAMC_DATA_ENH_2_A, \ + _PLANE_POST_CSC_GAMC_DATA_ENH_2_B) +#define PLANE_POST_CSC_GAMC_DATA_ENH (pipe, plane, i) \ + _MMIO_PLANE_GAMC(plane, i, _PLANE_POST_CSC_GAMC_DATA_ENH_1(pipe), \ + _PLANE_POST_CSC_GAMC_DATA_ENH_2(pipe)) + +#define _PLANE_POST_CSC_GAMC_INDEX_1_A 0x704d8 +#define _PLANE_POST_CSC_GAMC_INDEX_1_B 0x714d8 +#define _PLANE_POST_CSC_GAMC_INDEX_2_A 0x705d8 +#define _PLANE_POST_CSC_GAMC_INDEX_2_B 0x715d8 +#define _PLANE_POST_CSC_GAMC_INDEX_1 (pipe) _PIPE(pipe, _PLANE_POST_CSC_GAMC_INDEX_1_A, \ + _PLANE_POST_CSC_GAMC_INDEX_1_B) +#define _PLANE_POST_CSC_GAMC_INDEX_2 (pipe) _PIPE(pipe, _PLANE_POST_CSC_GAMC_INDEX_2_A, \ + _PLANE_POST_CSC_GAMC_INDEX_2_B) +#define PLANE_POST_CSC_GAMC_INDEX (pipe, plane, i) \ + _MMIO_PLANE_GAMC(plane, i, _PLANE_POST_CSC_GAMC_INDEX_1(pipe), \ + _PLANE_POST_CSC_GAMC_INDEX_2(pipe)) + +#define _PLANE_POST_CSC_GAMC_DATA_1_A 0x704dc +#define _PLANE_POST_CSC_GAMC_DATA_1_B 0x714dc +#define _PLANE_POST_CSC_GAMC_DATA_2_A 0x705dc +#define _PLANE_POST_CSC_GAMC_DATA_2_B 0x715dc +#define _PLANE_POST_CSC_GAMC_DATA_1 (pipe) _PIPE(pipe, _PLANE_POST_CSC_GAMC_DATA_1_A, \ + _PLANE_POST_CSC_GAMC_DATA_1_B) +#define _PLANE_POST_CSC_GAMC_DATA_2 (pipe) _PIPE(pipe, _PLANE_POST_CSC_GAMC_DATA_2_A, \ + _PLANE_POST_CSC_GAMC_DATA_2_B) +#define PLANE_POST_CSC_GAMC_DATA (pipe, plane, i) \ + _MMIO_PLANE_GAMC(plane, i, _PLANE_POST_CSC_GAMC_DATA_1(pipe), \ + _PLANE_POST_CSC_GAMC_DATA_2(pipe)) +/* Display13 Plane Degmma Reg */ #define _PLANE_PRE_CSC_GAMC_INDEX_ENH_1_A 0x701d0#define _PLANE_PRE_CSC_GAMC_INDEX_ENH_1_B 0x711d0
Signature · 1 line
2.50.1
PATCH v6 12/16 drm/i915/color: Program Pre-CSC registers
In reply to Uma ShankarAdd callback to program Pre-CSC LUT for TGL and beyond
v2: Add DSB support
v3: Add support for single segment 1D LUT color op v4:
- s/drm_color_lut_32/drm_color_lut32/ (Simon)
- Change commit message (Suraj)
- Improve comments (Suraj)
- Remove multisegmented programming, to be added later
- Remove dead code for SDR planes, add when needed
--- drivers/gpu/drm/i915/display/intel_color.c | 61 ++++++++++++++++++++++ 1 file changed, 61 insertions(+)
drivers/gpu/drm/i915/display/intel_color.c +61 -0
@@ -3942,6 +3942,66 @@ xelpd_load_plane_csc_matrix(struct intel_dsb *dsb, ctm_to_twos_complement(input[11], 0, 12)); } +static void +xelpd_program_plane_pre_csc_lut (struct intel_dsb *dsb, +const struct intel_plane_state *plane_state) +{ +struct intel_display *display =to_intel_display (plane_state); +const struct drm_plane_state *state = &plane_state->uapi; +enum pipe pipe =to_intel_plane (state->plane)->pipe; +enum plane_id plane =to_intel_plane (state->plane)->id; +const struct drm_color_lut32 *pre_csc_lut = plane_state->hw.degamma_lut->data; +u32 i, lut_size; + +if (icl_is_hdr_plane (display, plane)) { + lut_size =128 ; + +intel_de_write_dsb (display, dsb, +PLANE_PRE_CSC_GAMC_INDEX_ENH (pipe, plane,0 ), +PLANE_PAL_PREC_AUTO_INCREMENT ); + +if (pre_csc_lut) { +for (i =0 ; i < lut_size; i++) { +u32 lut_val =drm_color_lut32_extract (pre_csc_lut[i].green,24 ); + +intel_de_write_dsb (display, dsb, +PLANE_PRE_CSC_GAMC_DATA_ENH (pipe, plane,0 ), + lut_val); + } + +/* Program the max register to clamp values > 1.0. */ +/* TODO: Restrict to 0x7ffffff */ +do { +intel_de_write_dsb (display, dsb, +PLANE_PRE_CSC_GAMC_DATA_ENH (pipe, plane,0 ), + (1 <<24 )); + }while (i++ >130 ); + }else { +for (i =0 ; i < lut_size; i++) { +u32 v = (i * ((1 <<24 ) -1 )) / (lut_size -1 ); + +intel_de_write_dsb (display, dsb, +PLANE_PRE_CSC_GAMC_DATA_ENH (pipe, plane,0 ), v); + } + +do { +intel_de_write_dsb (display, dsb, +PLANE_PRE_CSC_GAMC_DATA_ENH (pipe, plane,0 ), +1 <<24 ); + }while (i++ <130 ); + } + +intel_de_write_dsb (display, dsb,PLANE_PRE_CSC_GAMC_INDEX_ENH (pipe, plane,0 ),0 ); + } +} + +static void +xelpd_plane_load_luts (struct intel_dsb *dsb,const struct intel_plane_state *plane_state) +{ +if (plane_state->hw.degamma_lut) +xelpd_program_plane_pre_csc_lut (dsb, plane_state); +} +static const struct intel_color_funcs chv_color_funcs = { .color_check = chv_color_check, .color_commit_arm = i9xx_color_commit_arm,
@@ -3990,6 +4050,7 @@ static const struct intel_color_funcs tgl_color_funcs = { .read_csc = icl_read_csc, .get_config = skl_get_config, .load_plane_csc_matrix = xelpd_load_plane_csc_matrix, + .load_plane_luts = xelpd_plane_load_luts, };static const struct intel_color_funcs icl_color_funcs = {
Signature · 1 line
2.50.1
RE: [v6 12/16] drm/i915/color: Program Pre-CSC registers
Quoted 4 lines
Subject: [v6 12/16] drm/i915/color: Program Pre-CSC registers
Add callback to program Pre-CSC LUT for TGL and beyond
Quoted 9 lines
v2: Add DSB support
v3: Add support for single segment 1D LUT color op v4:
- s/drm_color_lut_32/drm_color_lut32/ (Simon)
- Change commit message (Suraj)
- Improve comments (Suraj)
- Remove multisegmented programming, to be added later
- Remove dead code for SDR planes, add when needed
Bspec link here,
also if you can provide it as a reply so that I can verify the sequence for these writes
Regards,
Suraj Kandpal
Quoted 94 lines
Signed-off-by Uma Shankar <[email protected]>Signed-off-by Chaitanya Kumar Borah <[email protected]>--- drivers/gpu/drm/i915/display/intel_color.c | 61 ++++++++++++++++++++++ 1 file changed, 61 insertions(+)drivers/gpu/drm/i915/display/intel_color.c +23
-0@@ -3942,6 +3942,66 @@ xelpd_load_plane_csc_matrix(struct intel_dsb *dsb, ctm_to_twos_complement(input[11], 0, 12)); } +static void +xelpd_program_plane_pre_csc_lut (struct intel_dsb *dsb, +const struct intel_plane_state *plane_state) { +struct intel_display *display =to_intel_display (plane_state); +const struct drm_plane_state *state = &plane_state->uapi; +enum pipe pipe =to_intel_plane (state->plane)->pipe; +enum plane_id plane =to_intel_plane (state->plane)->id; +const struct drm_color_lut32 *pre_csc_lut = plane_state- >hw.degamma_lut->data; +u32 i, lut_size; + +if (icl_is_hdr_plane (display, plane)) { + lut_size =128 ; + +intel_de_write_dsb (display, dsb, +PLANE_PRE_CSC_GAMC_INDEX_ENH (pipe, plane,0 ), +PLANE_PAL_PREC_AUTO_INCREMENT ); + +if (pre_csc_lut) { +for (i =0 ; i < lut_size; i++) { +u32 lut_val =drm_color_lut32_extract (pre_csc_lut[i].green,24 ); + + intel_de_write_dsb(display, dsb, +
PLANE_PRE_CSC_GAMC_DATA_ENH(pipe, plane, 0),drivers/gpu/drm/i915/display/intel_color.c +8
-0+ lut_val); + } + +/* Program the max register to clamp values > 1.0. */ +/* TODO: Restrict to 0x7ffffff */ + do { + intel_de_write_dsb(display, dsb, +
PLANE_PRE_CSC_GAMC_DATA_ENH(pipe, plane, 0),drivers/gpu/drm/i915/display/intel_color.c +8
-0+ (1 << 24)); + }while (i++ >130 ); + }else { +for (i =0 ; i < lut_size; i++) { +u32 v = (i * ((1 <<24 ) -1 )) / (lut_size -1 ); + + intel_de_write_dsb(display, dsb, +
PLANE_PRE_CSC_GAMC_DATA_ENH(pipe, plane, 0), v);drivers/gpu/drm/i915/display/intel_color.c +5
-0+ } + + do { + intel_de_write_dsb(display, dsb, +
PLANE_PRE_CSC_GAMC_DATA_ENH(pipe, plane, 0),drivers/gpu/drm/i915/display/intel_color.c +5
-0+ 1 << 24); + }while (i++ <130 ); + } + + intel_de_write_dsb(display, dsb,
PLANE_PRE_CSC_GAMC_INDEX_ENH(pipe, plane, 0), 0);drivers/gpu/drm/i915/display/intel_color.c +9
-0+ } +} + +static void +xelpd_plane_load_luts (struct intel_dsb *dsb,const struct +intel_plane_state *plane_state) { +if (plane_state->hw.degamma_lut) +xelpd_program_plane_pre_csc_lut (dsb, plane_state); } +static const struct intel_color_funcs chv_color_funcs = { .color_check = chv_color_check, .color_commit_arm = i9xx_color_commit_arm, @@ -3990,6 +4050,7@@ static const struct
intel_color_funcstgl_color_funcs= {drivers/gpu/drm/i915/display/intel_color.c +1
-1.read_csc = icl_read_csc, .get_config = skl_get_config, .load_plane_csc_matrix = xelpd_load_plane_csc_matrix, + .load_plane_luts = xelpd_plane_load_luts, };static const struct intel_color_funcs icl_color_funcs = { --2.50.1
Re: [v6 12/16] drm/i915/color: Program Pre-CSC registers
Quoted 5 lines · Suraj
Bspec link here,
also if you can provide it as a reply so that I can verify the sequence for these writesRegards,
Suraj Kandpal
I am not aware of any special sequence that is followed for programming these registers other than the normal behavior of double buffer registers.
As to what to write into them, you can check the spec entries already mentioned in the patch that adds them.
BSpec: 50411, 50412, 50413, 50414
==
Chaitanya
PATCH v6 13/16 drm/i915/xelpd: Program Plane Post CSC Registers
In reply to Uma ShankarExtract the LUT and program plane post csc registers.
v2: Add DSB support
v3: Add support for single segment 1D LUT
v4:
- s/drm_color_lut_32/drm_color_lut32 (Simon)
- Move declaration to beginning of the function (Suraj)
- Remove multisegmented code, add it later
- Remove dead code for SDR planes, add it later
--- drivers/gpu/drm/i915/display/intel_color.c | 59 ++++++++++++++++++++++ 1 file changed, 59 insertions(+)
drivers/gpu/drm/i915/display/intel_color.c +59 -0
@@ -3995,11 +3995,70 @@ xelpd_program_plane_pre_csc_lut(struct intel_dsb *dsb, } } +static void +xelpd_program_plane_post_csc_lut (struct intel_dsb *dsb, +const struct intel_plane_state *plane_state) +{ +struct intel_display *display =to_intel_display (plane_state); +const struct drm_plane_state *state = &plane_state->uapi; +enum pipe pipe =to_intel_plane (state->plane)->pipe; +enum plane_id plane =to_intel_plane (state->plane)->id; +const struct drm_color_lut32 *post_csc_lut = plane_state->hw.gamma_lut->data; +u32 i, j, lut_size, lut_val; + +if (icl_is_hdr_plane (display, plane)) { +intel_de_write_dsb (display, dsb,PLANE_POST_CSC_GAMC_INDEX_ENH (pipe, plane,0 ), +PLANE_PAL_PREC_AUTO_INCREMENT ); +/* TODO: Add macro */ +intel_de_write_dsb (display, dsb,PLANE_POST_CSC_GAMC_SEG0_INDEX_ENH (pipe, plane,0 ), +PLANE_PAL_PREC_AUTO_INCREMENT ); +if (post_csc_lut) { + lut_size =32 ; +for (i =0 ; i < lut_size; i++) { + lut_val =drm_color_lut32_extract (post_csc_lut[j++].green,24 ); + +intel_de_write_dsb (display, dsb, +PLANE_POST_CSC_GAMC_DATA_ENH (pipe, plane,0 ), + lut_val); + } + +/* Segment 2 */ +do { +intel_de_write_dsb (display, dsb, +PLANE_POST_CSC_GAMC_DATA_ENH (pipe, plane,0 ), + (1 <<24 )); + }while (++j <34 ); + }else { +/*TODO: Add for segment 0 */ + lut_size =32 ; +for (i =0 ; i < lut_size; i++) { +u32 v = (i * ((1 <<24 ) -1 )) / (lut_size -1 ); + +intel_de_write_dsb (display, dsb, +PLANE_POST_CSC_GAMC_DATA_ENH (pipe, plane,0 ), v); + } + +do { +intel_de_write_dsb (display, dsb, +PLANE_POST_CSC_GAMC_DATA_ENH (pipe, plane,0 ), +1 <<24 ); + }while (i++ <34 ); + } + +intel_de_write_dsb (display, dsb,PLANE_POST_CSC_GAMC_INDEX_ENH (pipe, plane,0 ),0 ); +intel_de_write_dsb (display, dsb, +PLANE_POST_CSC_GAMC_SEG0_INDEX_ENH (pipe, plane,0 ),0 ); + } +} +static void xelpd_plane_load_luts (struct intel_dsb *dsb,const struct intel_plane_state *plane_state) {if (plane_state->hw.degamma_lut)xelpd_program_plane_pre_csc_lut (dsb, plane_state); + +if (plane_state->hw.gamma_lut) +xelpd_program_plane_post_csc_lut (dsb, plane_state); }static const struct intel_color_funcs chv_color_funcs = {
Signature · 1 line
2.50.1
kernel test robot
build botRe: [v6 13/16] drm/i915/xelpd: Program Plane Post CSC Registers
kernel test robot noticed the following build warnings:
Hi Uma,
kernel test robot noticed the following build warnings:
[auto build test WARNING on next-20251105]
[cannot apply to drm-xe/drm-xe-next drm-intel/for-linux-next drm-intel/for-linux-next-fixes drm-tip/drm-tip linus/master v6.18-rc4 v6.18-rc3 v6.18-rc2 v6.18-rc4] [If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Uma-Shankar/drm-AMD-series-squashed/20251105-202623 base: next-20251105 patch link: https://lore.kernel.org/r/20251105123413.2671075-14-uma.shankar%40intel.com patch subject: [v6 13/16] drm/i915/xelpd: Program Plane Post CSC Registers config: i386-defconfig (https://download.01.org/0day-ci/archive/20251106/[email protected]/config) compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251106/[email protected]/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
All warnings (new ones prefixed by >>):
>> drivers/gpu/drm/i915/display/intel_color.c:4018:52: warning: variable 'j' is uninitialized when used here [-Wuninitialized]
4018 | lut_val = drm_color_lut32_extract(post_csc_lut[j++].green, 24);
| ^
drivers/gpu/drm/i915/display/intel_color.c:4007:10: note: initialize the variable 'j' to silence this warning
4007 | u32 i, j, lut_size, lut_val;
| ^
| = 01 warning generated.
vim +/j +4018 drivers/gpu/drm/i915/display/intel_color.c
3997
3998 static void
3999 xelpd_program_plane_post_csc_lut(struct intel_dsb *dsb,
4000 const struct intel_plane_state *plane_state)
4001 {
4002 struct intel_display *display = to_intel_display(plane_state);
4003 const struct drm_plane_state *state = &plane_state->uapi;
4004 enum pipe pipe = to_intel_plane(state->plane)->pipe;
4005 enum plane_id plane = to_intel_plane(state->plane)->id;
4006 const struct drm_color_lut32 *post_csc_lut = plane_state->hw.gamma_lut->data;
4007 u32 i, j, lut_size, lut_val;
4008
4009 if (icl_is_hdr_plane(display, plane)) {
4010 intel_de_write_dsb(display, dsb, PLANE_POST_CSC_GAMC_INDEX_ENH(pipe, plane, 0),
4011 PLANE_PAL_PREC_AUTO_INCREMENT);
4012 /* TODO: Add macro */
4013 intel_de_write_dsb(display, dsb, PLANE_POST_CSC_GAMC_SEG0_INDEX_ENH(pipe, plane, 0),
4014 PLANE_PAL_PREC_AUTO_INCREMENT);
4015 if (post_csc_lut) {
4016 lut_size = 32;
4017 for (i = 0; i < lut_size; i++) {
> 4018 lut_val = drm_color_lut32_extract(post_csc_lut[j++].green, 24);
4019
4020 intel_de_write_dsb(display, dsb,
4021 PLANE_POST_CSC_GAMC_DATA_ENH(pipe, plane, 0),
4022 lut_val);
4023 }
4024
4025 /* Segment 2 */
4026 do {
4027 intel_de_write_dsb(display, dsb,
4028 PLANE_POST_CSC_GAMC_DATA_ENH(pipe, plane, 0),
4029 (1 << 24));
4030 } while (++j < 34);
4031 } else {
4032 /*TODO: Add for segment 0 */
4033 lut_size = 32;
4034 for (i = 0; i < lut_size; i++) {
4035 u32 v = (i * ((1 << 24) - 1)) / (lut_size - 1);
4036
4037 intel_de_write_dsb(display, dsb,
4038 PLANE_POST_CSC_GAMC_DATA_ENH(pipe, plane, 0), v);
4039 }
4040
4041 do {
4042 intel_de_write_dsb(display, dsb,
4043 PLANE_POST_CSC_GAMC_DATA_ENH(pipe, plane, 0),
4044 1 << 24);
4045 } while (i++ < 34);
4046 }
4047
4048 intel_de_write_dsb(display, dsb, PLANE_POST_CSC_GAMC_INDEX_ENH(pipe, plane, 0), 0);
4049 intel_de_write_dsb(display, dsb,
4050 PLANE_POST_CSC_GAMC_SEG0_INDEX_ENH(pipe, plane, 0), 0);
4051 }
4052 }
4053
Signature · 2 lines
0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
PATCH v6 14/16 drm/i915/display: Add registers for 3D LUT
In reply to Uma ShankarFrom: Chaitanya Kumar Borah <[email protected]>
Add registers needed to program 3D LUT
BSpec: 69378, 69379, 69380
--- .../i915/display/skl_universal_plane_regs.h | 26 +++++++++++++++++++ 1 file changed, 26 insertions(+)
drivers/gpu/drm/i915/display/skl_universal_plane_regs.h +26 -0
@@ -520,6 +520,32 @@#define PLANE_MIN_DBUF_BLOCKS (val) REG_FIELD_PREP(PLANE_MIN_DBUF_BLOCKS_MASK, (val))#define PLANE_INTERIM_DBUF_BLOCKS_MASK REG_GENMASK(11, 0)#define PLANE_INTERIM_DBUF_BLOCKS (val) REG_FIELD_PREP(PLANE_INTERIM_DBUF_BLOCKS_MASK, (val)) +/* 3D LUT */ +#define _LUT_3D_CTL_A 0x490A4 +#define _LUT_3D_CTL_B 0x491A4 +#define LUT_3D_ENABLE REG_BIT(31) +#define LUT_3D_READY REG_BIT(30) +#define LUT_3D_BINDING_MASK REG_GENMASK(23, 22) +#define LUT_3D_BIND_PIPE REG_FIELD_PREP(LUT_3D_BINDING_MASK, 0) +#define LUT_3D_BIND_PLANE_1 REG_FIELD_PREP(LUT_3D_BINDING_MASK, 1) +#define LUT_3D_BIND_PLANE_2 REG_FIELD_PREP(LUT_3D_BINDING_MASK, 2) +#define LUT_3D_BIND_PLANE_3 REG_FIELD_PREP(LUT_3D_BINDING_MASK, 3) +#define _LUT_3D_INDEX_A 0x490A8 +#define _LUT_3D_INDEX_B 0x491A8 +#define LUT_3D_AUTO_INCREMENT REG_BIT(13) +#define LUT_3D_INDEX_VALUE_MASK REG_GENMASK(12, 0) +#define LUT_3D_INDEX_VALUE (x) REG_FIELD_PREP(LUT_3D_INDEX_VALUE_MASK, (x)) +#define _LUT_3D_DATA_A 0x490AC +#define _LUT_3D_DATA_B 0x491AC +#define LUT_3D_DATA_RED_MASK REG_GENMASK(29, 20) +#define LUT_3D_DATA_GREEN_MASK REG_GENMASK(19, 10) +#define LUT_3D_DATA_BLUE_MASK REG_GENMASK(9, 0) +#define LUT_3D_DATA_RED (x) REG_FIELD_PREP(LUT_3D_DATA_RED_MASK, (x)) +#define LUT_3D_DATA_GREEN (x) REG_FIELD_PREP(LUT_3D_DATA_GREEN_MASK, (x)) +#define LUT_3D_DATA_BLUE (x) REG_FIELD_PREP(LUT_3D_DATA_BLUE_MASK, (x)) +#define LUT_3D_CTL (pipe) _MMIO_PIPE(pipe, _LUT_3D_CTL_A, _LUT_3D_CTL_B) +#define LUT_3D_INDEX (pipe) _MMIO_PIPE(pipe, _LUT_3D_INDEX_A, _LUT_3D_INDEX_B) +#define LUT_3D_DATA (pipe) _MMIO_PIPE(pipe, _LUT_3D_DATA_A, _LUT_3D_DATA_B)/* tgl+ */ #define _SEL_FETCH_PLANE_CTL_1_A 0x70890
Signature · 1 line
2.50.1
Re: [v6 14/16] drm/i915/display: Add registers for 3D LUT
Quoted 36 lines · Uma Shankar
From: Chaitanya Kumar Borah <[email protected]>
Add registers needed to program 3D LUT
BSpec: 69378, 69379, 69380
Signed-off-by Chaitanya Kumar Borah <[email protected]>Signed-off-by Uma Shankar <[email protected]>--- .../i915/display/skl_universal_plane_regs.h | 26 +++++++++++++++++++ 1 file changed, 26 insertions(+)drivers/gpu/drm/i915/display/skl_universal_plane_regs.h +16
-0@@ -520,6 +520,32 @@#define PLANE_MIN_DBUF_BLOCKS (val) REG_FIELD_PREP(PLANE_MIN_DBUF_BLOCKS_MASK, (val))#define PLANE_INTERIM_DBUF_BLOCKS_MASK REG_GENMASK(11, 0)#define PLANE_INTERIM_DBUF_BLOCKS (val) REG_FIELD_PREP(PLANE_INTERIM_DBUF_BLOCKS_MASK, (val)) +/* 3D LUT */ +#define _LUT_3D_CTL_A 0x490A4 +#define _LUT_3D_CTL_B 0x491A4 +#define LUT_3D_ENABLE REG_BIT(31) +#define LUT_3D_READY REG_BIT(30) +#define LUT_3D_BINDING_MASK REG_GENMASK(23, 22) +#define LUT_3D_BIND_PIPE REG_FIELD_PREP(LUT_3D_BINDING_MASK, 0) +#define LUT_3D_BIND_PLANE_1 REG_FIELD_PREP(LUT_3D_BINDING_MASK, 1) +#define LUT_3D_BIND_PLANE_2 REG_FIELD_PREP(LUT_3D_BINDING_MASK, 2) +#define LUT_3D_BIND_PLANE_3 REG_FIELD_PREP(LUT_3D_BINDING_MASK, 3) +#define _LUT_3D_INDEX_A 0x490A8 +#define _LUT_3D_INDEX_B 0x491A8 +#define LUT_3D_AUTO_INCREMENT REG_BIT(13) +#define LUT_3D_INDEX_VALUE_MASK REG_GENMASK(12, 0) +#define LUT_3D_INDEX_VALUE (x) REG_FIELD_PREP(LUT_3D_INDEX_VALUE_MASK, (x)) +#define _LUT_3D_DATA_A 0x490AC
drivers/gpu/drm/i915/display/skl_universal_plane_regs.h line 548
Quoted 10 lines
drivers/gpu/drm/i915/display/skl_universal_plane_regs.h +10
-0+#define _LUT_3D_DATA_B 0x491AC +#define LUT_3D_DATA_RED_MASK REG_GENMASK(29, 20) +#define LUT_3D_DATA_GREEN_MASK REG_GENMASK(19, 10) +#define LUT_3D_DATA_BLUE_MASK REG_GENMASK(9, 0) +#define LUT_3D_DATA_RED (x) REG_FIELD_PREP(LUT_3D_DATA_RED_MASK, (x)) +#define LUT_3D_DATA_GREEN (x) REG_FIELD_PREP(LUT_3D_DATA_GREEN_MASK, (x)) +#define LUT_3D_DATA_BLUE (x) REG_FIELD_PREP(LUT_3D_DATA_BLUE_MASK, (x)) +#define LUT_3D_CTL (pipe) _MMIO_PIPE(pipe, _LUT_3D_CTL_A, _LUT_3D_CTL_B) +#define LUT_3D_INDEX (pipe) _MMIO_PIPE(pipe, _LUT_3D_INDEX_A, _LUT_3D_INDEX_B) +#define LUT_3D_DATA (pipe) _MMIO_PIPE(pipe, _LUT_3D_DATA_A, _LUT_3D_DATA_B)
The regs go before their contents. For the umpteenth time, please read the big comment near the top of i915_reg.h.
Quoted 3 lines
drivers/gpu/drm/i915/display/skl_universal_plane_regs.h +0
-0/* tgl+ */ #define _SEL_FETCH_PLANE_CTL_1_A 0x70890
Signature · 1 line
Jani Nikula, Intel
Re: [v6 14/16] drm/i915/display: Add registers for 3D LUT
Quoted 42 lines · Jani Nikula
Quoted 41 lines · Uma Shankar
From: Chaitanya Kumar Borah <[email protected]>
Add registers needed to program 3D LUT
BSpec: 69378, 69379, 69380
Signed-off-by Chaitanya Kumar Borah <[email protected]>Signed-off-by Uma Shankar <[email protected]>--- .../i915/display/skl_universal_plane_regs.h | 26 +++++++++++++++++++ 1 file changed, 26 insertions(+)drivers/gpu/drm/i915/display/skl_universal_plane_regs.h +21
-0@@ -520,6 +520,32 @@#define PLANE_MIN_DBUF_BLOCKS (val) REG_FIELD_PREP(PLANE_MIN_DBUF_BLOCKS_MASK, (val))#define PLANE_INTERIM_DBUF_BLOCKS_MASK REG_GENMASK(11, 0)#define PLANE_INTERIM_DBUF_BLOCKS (val) REG_FIELD_PREP(PLANE_INTERIM_DBUF_BLOCKS_MASK, (val)) +/* 3D LUT */ +#define _LUT_3D_CTL_A 0x490A4 +#define _LUT_3D_CTL_B 0x491A4 +#define LUT_3D_ENABLE REG_BIT(31) +#define LUT_3D_READY REG_BIT(30) +#define LUT_3D_BINDING_MASK REG_GENMASK(23, 22) +#define LUT_3D_BIND_PIPE REG_FIELD_PREP(LUT_3D_BINDING_MASK, 0) +#define LUT_3D_BIND_PLANE_1 REG_FIELD_PREP(LUT_3D_BINDING_MASK, 1) +#define LUT_3D_BIND_PLANE_2 REG_FIELD_PREP(LUT_3D_BINDING_MASK, 2) +#define LUT_3D_BIND_PLANE_3 REG_FIELD_PREP(LUT_3D_BINDING_MASK, 3) +#define _LUT_3D_INDEX_A 0x490A8 +#define _LUT_3D_INDEX_B 0x491A8 +#define LUT_3D_AUTO_INCREMENT REG_BIT(13) +#define LUT_3D_INDEX_VALUE_MASK REG_GENMASK(12, 0) +#define LUT_3D_INDEX_VALUE (x) REG_FIELD_PREP(LUT_3D_INDEX_VALUE_MASK, (x)) +#define _LUT_3D_DATA_A 0x490AC +#define _LUT_3D_DATA_B 0x491AC +#define LUT_3D_DATA_RED_MASK REG_GENMASK(29, 20) +#define LUT_3D_DATA_GREEN_MASK REG_GENMASK(19, 10) +#define LUT_3D_DATA_BLUE_MASK REG_GENMASK(9, 0) +#define LUT_3D_DATA_RED (x) REG_FIELD_PREP(LUT_3D_DATA_RED_MASK, (x))
Quoted 9 lines
drivers/gpu/drm/i915/display/skl_universal_plane_regs.h line 548
Quoted 5 lines
drivers/gpu/drm/i915/display/skl_universal_plane_regs.h +5
-0+#define LUT_3D_DATA_GREEN (x) REG_FIELD_PREP(LUT_3D_DATA_GREEN_MASK, (x)) +#define LUT_3D_DATA_BLUE (x) REG_FIELD_PREP(LUT_3D_DATA_BLUE_MASK, (x)) +#define LUT_3D_CTL (pipe) _MMIO_PIPE(pipe, _LUT_3D_CTL_A, _LUT_3D_CTL_B) +#define LUT_3D_INDEX (pipe) _MMIO_PIPE(pipe, _LUT_3D_INDEX_A, _LUT_3D_INDEX_B) +#define LUT_3D_DATA (pipe) _MMIO_PIPE(pipe, _LUT_3D_DATA_A, _LUT_3D_DATA_B)The regs go before their contents. For the umpteenth time, please read the big comment near the top of
i915_reg.h.
Noted, will fix in th next version. Thank you for pointing out.
Have been carrying this patch in my internal branches for a while perhaps a good time to move them to intel_color_reg.h while at it.
==
Chaitanya
Quoted 5 lines
Quoted 4 lines
drivers/gpu/drm/i915/display/skl_universal_plane_regs.h +0
-0/* tgl+ */ #define _SEL_FETCH_PLANE_CTL_1_A 0x70890
RE: [v6 14/16] drm/i915/display: Add registers for 3D LUT
In reply to Uma ShankarQuoted 8 lines
Subject: [v6 14/16] drm/i915/display: Add registers for 3D LUT
From: Chaitanya Kumar Borah <[email protected]>
Add registers needed to program 3D LUT
BSpec: 69378, 69379, 69380
No need for the extra line
Regards,
Suraj Kandpal
Quoted 60 lines
Signed-off-by Chaitanya Kumar Borah <[email protected]>Signed-off-by Uma Shankar <[email protected]>--- .../i915/display/skl_universal_plane_regs.h | 26 +++++++++++++++++++ 1 file changed, 26 insertions(+)drivers/gpu/drm/i915/display/skl_universal_plane_regs.h +7
-0@@ -520,6 +520,32 @@#define PLANE_MIN_DBUF_BLOCKS (val) REG_FIELD_PREP(PLANE_MIN_DBUF_BLOCKS_MASK, (val))#define PLANE_INTERIM_DBUF_BLOCKS_MASK REG_GENMASK(11, 0)#define PLANE_INTERIM_DBUF_BLOCKS (val)REG_FIELD_PREP (PLANE_INTERIM_DBUF_BLOCKS_MASK , (val)) +/* 3D LUT */ +#define _LUT_3D_CTL_A 0x490A4 +#define _LUT_3D_CTL_B 0x491A4 +#define LUT_3D_ENABLE REG_BIT(31) +#define LUT_3D_READY REG_BIT(30) +#define LUT_3D_BINDING_MASK REG_GENMASK(23, 22) +#define LUT_3D_BIND_PIPE REG_FIELD_PREP(LUT_3D_BINDING_MASK, 0) +#define LUT_3D_BIND_PLANE_1 REG_FIELD_PREP(LUT_3D_BINDING_MASK, 1) +#define LUT_3D_BIND_PLANE_2 REG_FIELD_PREP(LUT_3D_BINDING_MASK, 2) +#define LUT_3D_BIND_PLANE_3 REG_FIELD_PREP(LUT_3D_BINDING_MASK, 3)drivers/gpu/drm/i915/display/skl_universal_plane_regs.h +5
-0+#define _LUT_3D_INDEX_A 0x490A8 +#define _LUT_3D_INDEX_B 0x491A8 +#define LUT_3D_AUTO_INCREMENT REG_BIT(13) +#define LUT_3D_INDEX_VALUE_MASK REG_GENMASK(12, 0) +#define LUT_3D_INDEX_VALUE (x)REG_FIELD_PREP(LUT_3D_INDEX_VALUE_MASK, (x))drivers/gpu/drm/i915/display/skl_universal_plane_regs.h +6
-0+#define _LUT_3D_DATA_A 0x490AC +#define _LUT_3D_DATA_B 0x491AC +#define LUT_3D_DATA_RED_MASK REG_GENMASK(29, 20) +#define LUT_3D_DATA_GREEN_MASK REG_GENMASK(19, 10) +#define LUT_3D_DATA_BLUE_MASK REG_GENMASK(9, 0) +#define LUT_3D_DATA_RED (x)REG_FIELD_PREP(LUT_3D_DATA_RED_MASK, (x)) +#define LUT_3D_DATA_GREEN(x) REG_FIELD_PREP(LUT_3D_DATA_GREEN_MASK, (x)) +#define LUT_3D_DATA_BLUE(x) REG_FIELD_PREP(LUT_3D_DATA_BLUE_MASK, (x))+#define
LUT_3D_CTL(pipe)_MMIO_PIPE(pipe,_LUT_3D_CTL_A,_LUT_3D_CTL_B)
+#defineLUT_3D_INDEX(pipe)_MMIO_PIPE(pipe,_LUT_3D_INDEX_A,_LUT_3D_INDEX_B)
+#defineLUT_3D_DATA(pipe)_MMIO_PIPE(pipe,_LUT_3D_DATA_A,_LUT_3D_DATA_B)/* tgl+ */
#define_SEL_FETCH_PLANE_CTL_1_A0x70890
--
2.50.1
PATCH v6 15/16 drm/i915/color: Add 3D LUT to color pipeline
In reply to Uma ShankarFrom: Chaitanya Kumar Borah <[email protected]>
Add helpers to program the 3D LUT registers and arm them.
--- drivers/gpu/drm/i915/display/intel_color.c | 57 +++++++++++++++++++ drivers/gpu/drm/i915/display/intel_color.h | 2 + .../drm/i915/display/intel_color_pipeline.c | 35 +++++++++++- .../drm/i915/display/intel_color_pipeline.h | 3 +- .../drm/i915/display/intel_display_limits.h | 1 + .../drm/i915/display/intel_display_types.h | 2 +- drivers/gpu/drm/i915/display/intel_plane.c | 2 + 7 files changed, 97 insertions(+), 5 deletions(-)
drivers/gpu/drm/i915/display/intel_color.c +57 -0
@@ -4061,6 +4061,44 @@ xelpd_plane_load_luts(struct intel_dsb *dsb, const struct intel_plane_state *plaxelpd_program_plane_post_csc_lut (dsb, plane_state); } +static u32 glk_3dlut_10 (const struct drm_color_lut32 *color) +{ +return REG_FIELD_PREP (LUT_3D_DATA_RED_MASK ,drm_color_lut32_extract (color->red,10 )) | +REG_FIELD_PREP (LUT_3D_DATA_GREEN_MASK ,drm_color_lut32_extract (color->green,10 )) | +REG_FIELD_PREP (LUT_3D_DATA_BLUE_MASK ,drm_color_lut32_extract (color->blue,10 )); +} + +static void glk_load_lut_3d (struct intel_dsb *dsb, +struct intel_crtc *crtc, +const struct drm_property_blob *blob) +{ +struct intel_display *display =to_intel_display (crtc->base.dev); +const struct drm_color_lut32 *lut = blob->data; +int i, lut_size =drm_color_lut32_size (blob); +enum pipe pipe = crtc->pipe; + +WARN_ON (intel_de_read (display,LUT_3D_CTL (pipe)) &LUT_3D_READY ); +intel_de_write_dsb (display, dsb,LUT_3D_INDEX (pipe),LUT_3D_AUTO_INCREMENT ); +for (i =0 ; i < lut_size; i++) +intel_de_write_dsb (display, dsb,LUT_3D_DATA (pipe),glk_3dlut_10 (&lut[i])); +intel_de_write_dsb (display, dsb,LUT_3D_INDEX (pipe),0 ); +} + +static void glk_lut_3d_commit (struct intel_dsb *dsb,struct intel_crtc *crtc,bool enable) +{ +struct intel_display *display =to_intel_display (crtc); +enum pipe pipe = crtc->pipe; +u32 val; + +WARN_ON (intel_de_read (display,LUT_3D_CTL (pipe)) &LUT_3D_READY ); + +if (enable) + val =LUT_3D_ENABLE |LUT_3D_READY |LUT_3D_BIND_PLANE_1 ; +else + val =0 ; +intel_de_write_dsb (display, dsb,LUT_3D_CTL (pipe), val); +} +static const struct intel_color_funcs chv_color_funcs = { .color_check = chv_color_check, .color_commit_arm = i9xx_color_commit_arm,
@@ -4190,6 +4228,14 @@ static const struct intel_color_funcs ilk_color_funcs = { .get_config = ilk_get_config, }; +void intel_color_plane_commit_arm (struct intel_dsb *dsb, +const struct intel_plane_state *plane_state) +{ +struct intel_crtc *crtc =to_intel_crtc (plane_state->uapi.crtc); + +glk_lut_3d_commit (dsb, crtc, !!plane_state->hw.lut_3d); +} +static void intel_color_load_plane_csc_matrix (struct intel_dsb *dsb,const struct intel_plane_state *plane_state)
@@ -4210,6 +4256,15 @@ intel_color_load_plane_luts(struct intel_dsb *dsb, display->funcs.color->load_plane_luts (dsb, plane_state); } +static void +intel_color_load_3dlut (struct intel_dsb *dsb, +const struct intel_plane_state *plane_state) +{ +struct intel_crtc *crtc =to_intel_crtc (plane_state->uapi.crtc); + +glk_load_lut_3d (dsb, crtc, plane_state->hw.lut_3d); +} +void intel_color_plane_program_pipeline (struct intel_dsb *dsb,const struct intel_plane_state *plane_state) {
@@ -4217,6 +4272,8 @@ void intel_color_plane_program_pipeline(struct intel_dsb *dsb,intel_color_load_plane_csc_matrix (dsb, plane_state);if (plane_state->hw.degamma_lut || plane_state->hw.gamma_lut)intel_color_load_plane_luts (dsb, plane_state); +if (plane_state->hw.lut_3d) +intel_color_load_3dlut (dsb, plane_state); }void intel_color_crtc_init (struct intel_crtc *crtc)
drivers/gpu/drm/i915/display/intel_color.h +2 -0
@@ -43,4 +43,6 @@ bool intel_color_lut_equal(const struct intel_crtc_state *crtc_state,void intel_color_assert_luts (const struct intel_crtc_state *crtc_state);void intel_color_plane_program_pipeline (struct intel_dsb *dsb,const struct intel_plane_state *plane_state); +void intel_color_plane_commit_arm (struct intel_dsb *dsb, +const struct intel_plane_state *plane_state);#endif /* __INTEL_COLOR_H__ */
drivers/gpu/drm/i915/display/intel_color_pipeline.c +32 -3
@@ -12,11 +12,24 @@#define PLANE_DEGAMMA_SIZE 128#define PLANE_GAMMA_SIZE 32 +static inline bool +intel_crtc_has_lut_3d (struct intel_display *display,enum pipe pipe) +{ +if (DISPLAY_VER (display) >=12 ) +return pipe ==PIPE_A || pipe ==PIPE_B ; +else if (DISPLAY_VER (display) >=10 /*|| IS_GEMINILAKE(display)*/ ) +return pipe ==PIPE_A ; +else +return false; +} +static -int _intel_color_pipeline_plane_init (struct drm_plane *plane,struct drm_prop_enum_list *list) +int _intel_color_pipeline_plane_init (struct drm_plane *plane,struct drm_prop_enum_list *list, +enum pipe pipe) {struct intel_colorop *colorop;struct drm_device *dev = plane->dev; +struct intel_display *display =to_intel_display (dev);int ret;struct drm_colorop *prev_op;
@@ -36,6 +49,22 @@ int _intel_color_pipeline_plane_init(struct drm_plane *plane, struct drm_prop_en/* TODO: handle failures and clean up */ prev_op = &colorop->base; +if (DISPLAY_VER (display) >=35 && +intel_crtc_has_lut_3d (display, pipe) && + plane->type ==DRM_PLANE_TYPE_PRIMARY ) { + colorop =intel_colorop_create (INTEL_PLANE_CB_3DLUT ); + + ret =drm_plane_colorop_3dlut_init (dev, &colorop->base, plane,17 , +DRM_COLOROP_LUT3D_INTERPOLATION_TETRAHEDRAL , + true); +if (ret) +return ret; + +drm_colorop_set_next_property (prev_op, &colorop->base); + + prev_op = &colorop->base; + } + colorop =intel_colorop_create (INTEL_PLANE_CB_CSC ); ret =drm_plane_colorop_ctm_3x4_init (dev, &colorop->base, plane,DRM_COLOROP_FLAG_ALLOW_BYPASS );
@@ -58,7 +87,7 @@ int _intel_color_pipeline_plane_init(struct drm_plane *plane, struct drm_prop_enreturn 0 ; } -int intel_color_pipeline_plane_init (struct drm_plane *plane) +int intel_color_pipeline_plane_init (struct drm_plane *plane,enum pipe pipe) {struct drm_device *dev = plane->dev;struct intel_display *display =to_intel_display (dev);
@@ -77,7 +106,7 @@ int intel_color_pipeline_plane_init(struct drm_plane *plane) len++;/* Add pipeline consisting of transfer functions */ - ret =_intel_color_pipeline_plane_init (plane, &pipelines[len]); + ret =_intel_color_pipeline_plane_init (plane, &pipelines[len], pipe);if (ret)return ret; len++;
drivers/gpu/drm/i915/display/intel_color_pipeline.h +2 -1
@@ -7,7 +7,8 @@#define __INTEL_COLOR_PIPELINE_H__struct drm_plane ; +enum pipe ; -int intel_color_pipeline_plane_init (struct drm_plane *plane); +int intel_color_pipeline_plane_init (struct drm_plane *plane,enum pipe pipe);#endif /* __INTEL_COLOR_PIPELINE_H__ */
drivers/gpu/drm/i915/display/intel_display_limits.h +1 -0
@@ -142,6 +142,7 @@ enum intel_color_block {INTEL_PLANE_CB_PRE_CSC_LUT ,INTEL_PLANE_CB_CSC ,INTEL_PLANE_CB_POST_CSC_LUT , +INTEL_PLANE_CB_3DLUT , INTEL_CB_MAX };
drivers/gpu/drm/i915/display/intel_display_types.h +1 -1
@@ -646,7 +646,7 @@ struct intel_plane_state {enum drm_color_encoding color_encoding;enum drm_color_range color_range;enum drm_scaling_filter scaling_filter; -struct drm_property_blob *ctm, *degamma_lut, *gamma_lut; +struct drm_property_blob *ctm, *degamma_lut, *gamma_lut, *lut_3d; } hw;struct i915_vma *ggtt_vma;
drivers/gpu/drm/i915/display/intel_plane.c +2 -0
@@ -348,6 +348,8 @@ intel_plane_colorop_replace_blob(struct intel_plane_state *plane_state,return drm_property_replace_blob (&plane_state->hw.degamma_lut, blob); else if (intel_colorop->id == INTEL_PLANE_CB_POST_CSC_LUT) return drm_property_replace_blob(&plane_state->hw.gamma_lut, blob); + else if (intel_colorop->id == INTEL_PLANE_CB_3DLUT) + return drm_property_replace_blob(&plane_state->hw.lut_3d, blob);return false; }
Signature · 1 line
2.50.1
Re: [v6 15/16] drm/i915/color: Add 3D LUT to color pipeline
Quoted 31 lines · Uma Shankar
From: Chaitanya Kumar Borah <[email protected]>
Add helpers to program the 3D LUT registers and arm them.
Signed-off-by Chaitanya Kumar Borah <[email protected]>Signed-off-by Uma Shankar <[email protected]>--- drivers/gpu/drm/i915/display/intel_color.c | 57 +++++++++++++++++++ drivers/gpu/drm/i915/display/intel_color.h | 2 + .../drm/i915/display/intel_color_pipeline.c | 35 +++++++++++- .../drm/i915/display/intel_color_pipeline.h | 3 +- .../drm/i915/display/intel_display_limits.h | 1 + .../drm/i915/display/intel_display_types.h | 2 +- drivers/gpu/drm/i915/display/intel_plane.c | 2 + 7 files changed, 97 insertions(+), 5 deletions(-)drivers/gpu/drm/i915/display/intel_color.c +7
-0@@ -4061,6 +4061,44 @@ xelpd_plane_load_luts(struct intel_dsb *dsb, const struct intel_plane_state *plaxelpd_program_plane_post_csc_lut (dsb, plane_state); } +static u32 glk_3dlut_10 (const struct drm_color_lut32 *color) +{ +return REG_FIELD_PREP (LUT_3D_DATA_RED_MASK ,drm_color_lut32_extract (color->red,10 )) | +REG_FIELD_PREP (LUT_3D_DATA_GREEN_MASK ,drm_color_lut32_extract (color->green,10 )) | +REG_FIELD_PREP (LUT_3D_DATA_BLUE_MASK ,drm_color_lut32_extract (color->blue,10 )); +} +
drivers/gpu/drm/i915/display/intel_color.c xelpd_plane_load_luts(struct intel_dsb *dsb, const struct intel_plane_state *pla · line 4080
Quoted 10 lines
drivers/gpu/drm/i915/display/intel_color.c +10
-0+static void glk_load_lut_3d (struct intel_dsb *dsb, +struct intel_crtc *crtc, +const struct drm_property_blob *blob) +{ +struct intel_display *display =to_intel_display (crtc->base.dev); +const struct drm_color_lut32 *lut = blob->data; +int i, lut_size =drm_color_lut32_size (blob); +enum pipe pipe = crtc->pipe; + +WARN_ON (intel_de_read (display,LUT_3D_CTL (pipe)) &LUT_3D_READY );
Why?
drivers/gpu/drm/i915/display/intel_color.c xelpd_plane_load_luts(struct intel_dsb *dsb, const struct intel_plane_state *pla · line 4093
Quoted 13 lines
drivers/gpu/drm/i915/display/intel_color.c +13
-0+intel_de_write_dsb (display, dsb,LUT_3D_INDEX (pipe),LUT_3D_AUTO_INCREMENT ); +for (i =0 ; i < lut_size; i++) +intel_de_write_dsb (display, dsb,LUT_3D_DATA (pipe),glk_3dlut_10 (&lut[i])); +intel_de_write_dsb (display, dsb,LUT_3D_INDEX (pipe),0 ); +} + +static void glk_lut_3d_commit (struct intel_dsb *dsb,struct intel_crtc *crtc,bool enable) +{ +struct intel_display *display =to_intel_display (crtc); +enum pipe pipe = crtc->pipe; +u32 val; + +WARN_ON (intel_de_read (display,LUT_3D_CTL (pipe)) &LUT_3D_READY );
Why?
Quoted 185 lines
drivers/gpu/drm/i915/display/intel_color.c +27
-0+ +if (enable) + val =LUT_3D_ENABLE |LUT_3D_READY |LUT_3D_BIND_PLANE_1 ; +else + val =0 ; +intel_de_write_dsb (display, dsb,LUT_3D_CTL (pipe), val); +} +static const struct intel_color_funcs chv_color_funcs = { .color_check = chv_color_check, .color_commit_arm = i9xx_color_commit_arm,@@ -4190,6 +4228,14 @@ static const struct intel_color_funcs ilk_color_funcs = { .get_config = ilk_get_config, }; +void intel_color_plane_commit_arm (struct intel_dsb *dsb, +const struct intel_plane_state *plane_state) +{ +struct intel_crtc *crtc =to_intel_crtc (plane_state->uapi.crtc); + +glk_lut_3d_commit (dsb, crtc, !!plane_state->hw.lut_3d); +} +static void intel_color_load_plane_csc_matrix (struct intel_dsb *dsb,const struct intel_plane_state *plane_state)@@ -4210,6 +4256,15 @@ intel_color_load_plane_luts(struct intel_dsb *dsb, display->funcs.color->load_plane_luts (dsb, plane_state); } +static void +intel_color_load_3dlut (struct intel_dsb *dsb, +const struct intel_plane_state *plane_state) +{ +struct intel_crtc *crtc =to_intel_crtc (plane_state->uapi.crtc); + +glk_load_lut_3d (dsb, crtc, plane_state->hw.lut_3d); +} +void intel_color_plane_program_pipeline (struct intel_dsb *dsb,const struct intel_plane_state *plane_state) {@@ -4217,6 +4272,8 @@ void intel_color_plane_program_pipeline(struct intel_dsb *dsb,intel_color_load_plane_csc_matrix (dsb, plane_state);if (plane_state->hw.degamma_lut || plane_state->hw.gamma_lut)intel_color_load_plane_luts (dsb, plane_state); +if (plane_state->hw.lut_3d) +intel_color_load_3dlut (dsb, plane_state); }void intel_color_crtc_init (struct intel_crtc *crtc)drivers/gpu/drm/i915/display/intel_color.h +2
-0@@ -43,4 +43,6 @@ bool intel_color_lut_equal(const struct intel_crtc_state *crtc_state,void intel_color_assert_luts (const struct intel_crtc_state *crtc_state);void intel_color_plane_program_pipeline (struct intel_dsb *dsb,const struct intel_plane_state *plane_state); +void intel_color_plane_commit_arm (struct intel_dsb *dsb, +const struct intel_plane_state *plane_state);#endif /* __INTEL_COLOR_H__ */ drivers/gpu/drm/i915/display/intel_color_pipeline.c +32
-3@@ -12,11 +12,24 @@#define PLANE_DEGAMMA_SIZE 128#define PLANE_GAMMA_SIZE 32 +static inline bool +intel_crtc_has_lut_3d (struct intel_display *display,enum pipe pipe) +{ +if (DISPLAY_VER (display) >=12 ) +return pipe ==PIPE_A || pipe ==PIPE_B ; +else if (DISPLAY_VER (display) >=10 /*|| IS_GEMINILAKE(display)*/ ) +return pipe ==PIPE_A ; +else +return false; +} +static -int _intel_color_pipeline_plane_init (struct drm_plane *plane,struct drm_prop_enum_list *list) +int _intel_color_pipeline_plane_init (struct drm_plane *plane,struct drm_prop_enum_list *list, +enum pipe pipe) {struct intel_colorop *colorop;struct drm_device *dev = plane->dev; +struct intel_display *display =to_intel_display (dev);int ret;struct drm_colorop *prev_op;@@ -36,6 +49,22 @@ int _intel_color_pipeline_plane_init(struct drm_plane *plane, struct drm_prop_en/* TODO: handle failures and clean up */ prev_op = &colorop->base; +if (DISPLAY_VER (display) >=35 && +intel_crtc_has_lut_3d (display, pipe) && + plane->type ==DRM_PLANE_TYPE_PRIMARY ) { + colorop =intel_colorop_create (INTEL_PLANE_CB_3DLUT ); + + ret =drm_plane_colorop_3dlut_init (dev, &colorop->base, plane,17 , +DRM_COLOROP_LUT3D_INTERPOLATION_TETRAHEDRAL , + true); +if (ret) +return ret; + +drm_colorop_set_next_property (prev_op, &colorop->base); + + prev_op = &colorop->base; + } + colorop =intel_colorop_create (INTEL_PLANE_CB_CSC ); ret =drm_plane_colorop_ctm_3x4_init (dev, &colorop->base, plane,DRM_COLOROP_FLAG_ALLOW_BYPASS );@@ -58,7 +87,7 @@ int _intel_color_pipeline_plane_init(struct drm_plane *plane, struct drm_prop_enreturn 0 ; } -int intel_color_pipeline_plane_init (struct drm_plane *plane) +int intel_color_pipeline_plane_init (struct drm_plane *plane,enum pipe pipe) {struct drm_device *dev = plane->dev;struct intel_display *display =to_intel_display (dev);@@ -77,7 +106,7 @@ int intel_color_pipeline_plane_init(struct drm_plane *plane) len++;/* Add pipeline consisting of transfer functions */ - ret =_intel_color_pipeline_plane_init (plane, &pipelines[len]); + ret =_intel_color_pipeline_plane_init (plane, &pipelines[len], pipe);if (ret)return ret; len++;drivers/gpu/drm/i915/display/intel_color_pipeline.h +2
-1@@ -7,7 +7,8 @@#define __INTEL_COLOR_PIPELINE_H__struct drm_plane ; +enum pipe ; -int intel_color_pipeline_plane_init (struct drm_plane *plane); +int intel_color_pipeline_plane_init (struct drm_plane *plane,enum pipe pipe);#endif /* __INTEL_COLOR_PIPELINE_H__ */ drivers/gpu/drm/i915/display/intel_display_limits.h +1
-0@@ -142,6 +142,7 @@ enum intel_color_block {INTEL_PLANE_CB_PRE_CSC_LUT ,INTEL_PLANE_CB_CSC ,INTEL_PLANE_CB_POST_CSC_LUT , +INTEL_PLANE_CB_3DLUT , INTEL_CB_MAX };drivers/gpu/drm/i915/display/intel_display_types.h +1
-1@@ -646,7 +646,7 @@ struct intel_plane_state {enum drm_color_encoding color_encoding;enum drm_color_range color_range;enum drm_scaling_filter scaling_filter; -struct drm_property_blob *ctm, *degamma_lut, *gamma_lut; +struct drm_property_blob *ctm, *degamma_lut, *gamma_lut, *lut_3d; } hw;struct i915_vma *ggtt_vma;drivers/gpu/drm/i915/display/intel_plane.c +2
-0@@ -348,6 +348,8 @@ intel_plane_colorop_replace_blob(struct intel_plane_state *plane_state,return drm_property_replace_blob (&plane_state->hw.degamma_lut, blob); else if (intel_colorop->id == INTEL_PLANE_CB_POST_CSC_LUT) return drm_property_replace_blob(&plane_state->hw.gamma_lut, blob); + else if (intel_colorop->id == INTEL_PLANE_CB_3DLUT) + return drm_property_replace_blob(&plane_state->hw.lut_3d, blob);return false; }
Signature · 1 line
Jani Nikula, Intel
Re: [v6 15/16] drm/i915/color: Add 3D LUT to color pipeline
Quoted 45 lines · Jani Nikula
Quoted 31 lines · Uma Shankar
From: Chaitanya Kumar Borah <[email protected]>
Add helpers to program the 3D LUT registers and arm them.
Signed-off-by Chaitanya Kumar Borah <[email protected]>Signed-off-by Uma Shankar <[email protected]>--- drivers/gpu/drm/i915/display/intel_color.c | 57 +++++++++++++++++++ drivers/gpu/drm/i915/display/intel_color.h | 2 + .../drm/i915/display/intel_color_pipeline.c | 35 +++++++++++- .../drm/i915/display/intel_color_pipeline.h | 3 +- .../drm/i915/display/intel_display_limits.h | 1 + .../drm/i915/display/intel_display_types.h | 2 +- drivers/gpu/drm/i915/display/intel_plane.c | 2 + 7 files changed, 97 insertions(+), 5 deletions(-)drivers/gpu/drm/i915/display/intel_color.c +7
-0@@ -4061,6 +4061,44 @@ xelpd_plane_load_luts(struct intel_dsb *dsb, const struct intel_plane_state *plaxelpd_program_plane_post_csc_lut (dsb, plane_state); } +static u32 glk_3dlut_10 (const struct drm_color_lut32 *color) +{ +return REG_FIELD_PREP (LUT_3D_DATA_RED_MASK ,drm_color_lut32_extract (color->red,10 )) | +REG_FIELD_PREP (LUT_3D_DATA_GREEN_MASK ,drm_color_lut32_extract (color->green,10 )) | +REG_FIELD_PREP (LUT_3D_DATA_BLUE_MASK ,drm_color_lut32_extract (color->blue,10 )); +} +drivers/gpu/drm/i915/display/intel_color.c xelpd_plane_load_luts(struct intel_dsb *dsb, const struct intel_plane_state *pla · line 4080
Quoted 10 lines
drivers/gpu/drm/i915/display/intel_color.c +10
-0+static void glk_load_lut_3d (struct intel_dsb *dsb, +struct intel_crtc *crtc, +const struct drm_property_blob *blob) +{ +struct intel_display *display =to_intel_display (crtc->base.dev); +const struct drm_color_lut32 *lut = blob->data; +int i, lut_size =drm_color_lut32_size (blob); +enum pipe pipe = crtc->pipe; + +WARN_ON (intel_de_read (display,LUT_3D_CTL (pipe)) &LUT_3D_READY );Why?
...
Quoted 7 lines
Quoted 7 lines
drivers/gpu/drm/i915/display/intel_color.c +7
-0+intel_de_write_dsb (display, dsb,LUT_3D_INDEX (pipe),LUT_3D_AUTO_INCREMENT ); +for (i =0 ; i < lut_size; i++) +intel_de_write_dsb (display, dsb,LUT_3D_DATA (pipe),glk_3dlut_10 (&lut[i])); +intel_de_write_dsb (display, dsb,LUT_3D_INDEX (pipe),0 ); +} + +static void glk_lut_3d_commit (struct intel_dsb *dsb,struct intel_crtc *crtc,bool enable)
Quoted 9 lines
drivers/gpu/drm/i915/display/intel_color.c xelpd_plane_load_luts(struct intel_dsb *dsb, const struct intel_plane_state *pla · line 4093
Quoted 6 lines
drivers/gpu/drm/i915/display/intel_color.c +6
-0+{ +struct intel_display *display =to_intel_display (crtc); +enum pipe pipe = crtc->pipe; +u32 val; + +WARN_ON (intel_de_read (display,LUT_3D_CTL (pipe)) &LUT_3D_READY );Why?
LUT_3D_READY is cleared off by the HW once the LUT buffer is loaded into it's internal working RAM.
So by the time we reach here (or above) this bit should be cleared off.
This warn on was added to indicate if we are writing 3DLUT data while hardware is still processing previous values.
TOL, we should perhaps move it to the state checker in the same commit or poll on it if there are precendance for doing such thing.
==
Chaitanya
Quoted 186 lines
Quoted 185 lines
drivers/gpu/drm/i915/display/intel_color.c +27
-0+ +if (enable) + val =LUT_3D_ENABLE |LUT_3D_READY |LUT_3D_BIND_PLANE_1 ; +else + val =0 ; +intel_de_write_dsb (display, dsb,LUT_3D_CTL (pipe), val); +} +static const struct intel_color_funcs chv_color_funcs = { .color_check = chv_color_check, .color_commit_arm = i9xx_color_commit_arm,@@ -4190,6 +4228,14 @@ static const struct intel_color_funcs ilk_color_funcs = { .get_config = ilk_get_config, }; +void intel_color_plane_commit_arm (struct intel_dsb *dsb, +const struct intel_plane_state *plane_state) +{ +struct intel_crtc *crtc =to_intel_crtc (plane_state->uapi.crtc); + +glk_lut_3d_commit (dsb, crtc, !!plane_state->hw.lut_3d); +} +static void intel_color_load_plane_csc_matrix (struct intel_dsb *dsb,const struct intel_plane_state *plane_state)@@ -4210,6 +4256,15 @@ intel_color_load_plane_luts(struct intel_dsb *dsb, display->funcs.color->load_plane_luts (dsb, plane_state); } +static void +intel_color_load_3dlut (struct intel_dsb *dsb, +const struct intel_plane_state *plane_state) +{ +struct intel_crtc *crtc =to_intel_crtc (plane_state->uapi.crtc); + +glk_load_lut_3d (dsb, crtc, plane_state->hw.lut_3d); +} +void intel_color_plane_program_pipeline (struct intel_dsb *dsb,const struct intel_plane_state *plane_state) {@@ -4217,6 +4272,8 @@ void intel_color_plane_program_pipeline(struct intel_dsb *dsb,intel_color_load_plane_csc_matrix (dsb, plane_state);if (plane_state->hw.degamma_lut || plane_state->hw.gamma_lut)intel_color_load_plane_luts (dsb, plane_state); +if (plane_state->hw.lut_3d) +intel_color_load_3dlut (dsb, plane_state); }void intel_color_crtc_init (struct intel_crtc *crtc)drivers/gpu/drm/i915/display/intel_color.h +2
-0@@ -43,4 +43,6 @@ bool intel_color_lut_equal(const struct intel_crtc_state *crtc_state,void intel_color_assert_luts (const struct intel_crtc_state *crtc_state);void intel_color_plane_program_pipeline (struct intel_dsb *dsb,const struct intel_plane_state *plane_state); +void intel_color_plane_commit_arm (struct intel_dsb *dsb, +const struct intel_plane_state *plane_state);#endif /* __INTEL_COLOR_H__ */ drivers/gpu/drm/i915/display/intel_color_pipeline.c +32
-3@@ -12,11 +12,24 @@#define PLANE_DEGAMMA_SIZE 128#define PLANE_GAMMA_SIZE 32 +static inline bool +intel_crtc_has_lut_3d (struct intel_display *display,enum pipe pipe) +{ +if (DISPLAY_VER (display) >=12 ) +return pipe ==PIPE_A || pipe ==PIPE_B ; +else if (DISPLAY_VER (display) >=10 /*|| IS_GEMINILAKE(display)*/ ) +return pipe ==PIPE_A ; +else +return false; +} +static -int _intel_color_pipeline_plane_init (struct drm_plane *plane,struct drm_prop_enum_list *list) +int _intel_color_pipeline_plane_init (struct drm_plane *plane,struct drm_prop_enum_list *list, +enum pipe pipe) {struct intel_colorop *colorop;struct drm_device *dev = plane->dev; +struct intel_display *display =to_intel_display (dev);int ret;struct drm_colorop *prev_op;@@ -36,6 +49,22 @@ int _intel_color_pipeline_plane_init(struct drm_plane *plane, struct drm_prop_en/* TODO: handle failures and clean up */ prev_op = &colorop->base; +if (DISPLAY_VER (display) >=35 && +intel_crtc_has_lut_3d (display, pipe) && + plane->type ==DRM_PLANE_TYPE_PRIMARY ) { + colorop =intel_colorop_create (INTEL_PLANE_CB_3DLUT ); + + ret =drm_plane_colorop_3dlut_init (dev, &colorop->base, plane,17 , +DRM_COLOROP_LUT3D_INTERPOLATION_TETRAHEDRAL , + true); +if (ret) +return ret; + +drm_colorop_set_next_property (prev_op, &colorop->base); + + prev_op = &colorop->base; + } + colorop =intel_colorop_create (INTEL_PLANE_CB_CSC ); ret =drm_plane_colorop_ctm_3x4_init (dev, &colorop->base, plane,DRM_COLOROP_FLAG_ALLOW_BYPASS );@@ -58,7 +87,7 @@ int _intel_color_pipeline_plane_init(struct drm_plane *plane, struct drm_prop_enreturn 0 ; } -int intel_color_pipeline_plane_init (struct drm_plane *plane) +int intel_color_pipeline_plane_init (struct drm_plane *plane,enum pipe pipe) {struct drm_device *dev = plane->dev;struct intel_display *display =to_intel_display (dev);@@ -77,7 +106,7 @@ int intel_color_pipeline_plane_init(struct drm_plane *plane) len++;/* Add pipeline consisting of transfer functions */ - ret =_intel_color_pipeline_plane_init (plane, &pipelines[len]); + ret =_intel_color_pipeline_plane_init (plane, &pipelines[len], pipe);if (ret)return ret; len++;drivers/gpu/drm/i915/display/intel_color_pipeline.h +2
-1@@ -7,7 +7,8 @@#define __INTEL_COLOR_PIPELINE_H__struct drm_plane ; +enum pipe ; -int intel_color_pipeline_plane_init (struct drm_plane *plane); +int intel_color_pipeline_plane_init (struct drm_plane *plane,enum pipe pipe);#endif /* __INTEL_COLOR_PIPELINE_H__ */ drivers/gpu/drm/i915/display/intel_display_limits.h +1
-0@@ -142,6 +142,7 @@ enum intel_color_block {INTEL_PLANE_CB_PRE_CSC_LUT ,INTEL_PLANE_CB_CSC ,INTEL_PLANE_CB_POST_CSC_LUT , +INTEL_PLANE_CB_3DLUT , INTEL_CB_MAX };drivers/gpu/drm/i915/display/intel_display_types.h +1
-1@@ -646,7 +646,7 @@ struct intel_plane_state {enum drm_color_encoding color_encoding;enum drm_color_range color_range;enum drm_scaling_filter scaling_filter; -struct drm_property_blob *ctm, *degamma_lut, *gamma_lut; +struct drm_property_blob *ctm, *degamma_lut, *gamma_lut, *lut_3d; } hw;struct i915_vma *ggtt_vma;drivers/gpu/drm/i915/display/intel_plane.c +2
-0@@ -348,6 +348,8 @@ intel_plane_colorop_replace_blob(struct intel_plane_state *plane_state,return drm_property_replace_blob (&plane_state->hw.degamma_lut, blob); else if (intel_colorop->id == INTEL_PLANE_CB_POST_CSC_LUT) return drm_property_replace_blob(&plane_state->hw.gamma_lut, blob); + else if (intel_colorop->id == INTEL_PLANE_CB_3DLUT) + return drm_property_replace_blob(&plane_state->hw.lut_3d, blob);return false; }
Re: [v6 15/16] drm/i915/color: Add 3D LUT to color pipeline
Quoted 68 lines · Chaitanya Kumar
Quoted 45 lines · Jani Nikula
Quoted 31 lines · Uma Shankar
From: Chaitanya Kumar Borah <[email protected]>
Add helpers to program the 3D LUT registers and arm them.
Signed-off-by Chaitanya Kumar Borah <[email protected]>Signed-off-by Uma Shankar <[email protected]>--- drivers/gpu/drm/i915/display/intel_color.c | 57 +++++++++++++++++++ drivers/gpu/drm/i915/display/intel_color.h | 2 + .../drm/i915/display/intel_color_pipeline.c | 35 +++++++++++- .../drm/i915/display/intel_color_pipeline.h | 3 +- .../drm/i915/display/intel_display_limits.h | 1 + .../drm/i915/display/intel_display_types.h | 2 +- drivers/gpu/drm/i915/display/intel_plane.c | 2 + 7 files changed, 97 insertions(+), 5 deletions(-)drivers/gpu/drm/i915/display/intel_color.c +7
-0@@ -4061,6 +4061,44 @@ xelpd_plane_load_luts(struct intel_dsb *dsb, const struct intel_plane_state *plaxelpd_program_plane_post_csc_lut (dsb, plane_state); } +static u32 glk_3dlut_10 (const struct drm_color_lut32 *color) +{ +return REG_FIELD_PREP (LUT_3D_DATA_RED_MASK ,drm_color_lut32_extract (color->red,10 )) | +REG_FIELD_PREP (LUT_3D_DATA_GREEN_MASK ,drm_color_lut32_extract (color->green,10 )) | +REG_FIELD_PREP (LUT_3D_DATA_BLUE_MASK ,drm_color_lut32_extract (color->blue,10 )); +} +drivers/gpu/drm/i915/display/intel_color.c xelpd_plane_load_luts(struct intel_dsb *dsb, const struct intel_plane_state *pla · line 4080
Quoted 10 lines
drivers/gpu/drm/i915/display/intel_color.c +10
-0+static void glk_load_lut_3d (struct intel_dsb *dsb, +struct intel_crtc *crtc, +const struct drm_property_blob *blob) +{ +struct intel_display *display =to_intel_display (crtc->base.dev); +const struct drm_color_lut32 *lut = blob->data; +int i, lut_size =drm_color_lut32_size (blob); +enum pipe pipe = crtc->pipe; + +WARN_ON (intel_de_read (display,LUT_3D_CTL (pipe)) &LUT_3D_READY );Why?
...
Quoted 7 lines
Quoted 7 lines
drivers/gpu/drm/i915/display/intel_color.c +7
-0+intel_de_write_dsb (display, dsb,LUT_3D_INDEX (pipe),LUT_3D_AUTO_INCREMENT ); +for (i =0 ; i < lut_size; i++) +intel_de_write_dsb (display, dsb,LUT_3D_DATA (pipe),glk_3dlut_10 (&lut[i])); +intel_de_write_dsb (display, dsb,LUT_3D_INDEX (pipe),0 ); +} + +static void glk_lut_3d_commit (struct intel_dsb *dsb,struct intel_crtc *crtc,bool enable)Quoted 9 lines
drivers/gpu/drm/i915/display/intel_color.c xelpd_plane_load_luts(struct intel_dsb *dsb, const struct intel_plane_state *pla · line 4093
Quoted 6 lines
drivers/gpu/drm/i915/display/intel_color.c +6
-0+{ +struct intel_display *display =to_intel_display (crtc); +enum pipe pipe = crtc->pipe; +u32 val; + +WARN_ON (intel_de_read (display,LUT_3D_CTL (pipe)) &LUT_3D_READY );Why?
LUT_3D_READYis cleared off by the HW once the LUT buffer is loaded into it's internal working RAM.
Quoted 6 lines
So by the time we reach here (or above) this bit should be cleared off. This warn on was added to indicate if we are writing 3DLUT data while hardware is still processing previous values.
TOL, we should perhaps move it to the state checker in the same commit or poll on it if there are precendance for doing such thing.
Yeah. The thing I dislike about throwing in random assert type checks here and there is that they're incredibly long-lasting and hard to get rid of.
In some cases (though unlikely here) you get static analyzer warnings on things that are being checked as WARNs but not acted on, and then people add error handling on them. Piles and piles of code get added for reasons that become completely blurred over time. Especially so when there's not even a mention of the reason in the commit message.
BR,
Jani.
Quoted 192 lines
==
ChaitanyaQuoted 186 lines
Quoted 185 lines
drivers/gpu/drm/i915/display/intel_color.c +27
-0+ +if (enable) + val =LUT_3D_ENABLE |LUT_3D_READY |LUT_3D_BIND_PLANE_1 ; +else + val =0 ; +intel_de_write_dsb (display, dsb,LUT_3D_CTL (pipe), val); +} +static const struct intel_color_funcs chv_color_funcs = { .color_check = chv_color_check, .color_commit_arm = i9xx_color_commit_arm,@@ -4190,6 +4228,14 @@ static const struct intel_color_funcs ilk_color_funcs = { .get_config = ilk_get_config, }; +void intel_color_plane_commit_arm (struct intel_dsb *dsb, +const struct intel_plane_state *plane_state) +{ +struct intel_crtc *crtc =to_intel_crtc (plane_state->uapi.crtc); + +glk_lut_3d_commit (dsb, crtc, !!plane_state->hw.lut_3d); +} +static void intel_color_load_plane_csc_matrix (struct intel_dsb *dsb,const struct intel_plane_state *plane_state)@@ -4210,6 +4256,15 @@ intel_color_load_plane_luts(struct intel_dsb *dsb, display->funcs.color->load_plane_luts (dsb, plane_state); } +static void +intel_color_load_3dlut (struct intel_dsb *dsb, +const struct intel_plane_state *plane_state) +{ +struct intel_crtc *crtc =to_intel_crtc (plane_state->uapi.crtc); + +glk_load_lut_3d (dsb, crtc, plane_state->hw.lut_3d); +} +void intel_color_plane_program_pipeline (struct intel_dsb *dsb,const struct intel_plane_state *plane_state) {@@ -4217,6 +4272,8 @@ void intel_color_plane_program_pipeline(struct intel_dsb *dsb,intel_color_load_plane_csc_matrix (dsb, plane_state);if (plane_state->hw.degamma_lut || plane_state->hw.gamma_lut)intel_color_load_plane_luts (dsb, plane_state); +if (plane_state->hw.lut_3d) +intel_color_load_3dlut (dsb, plane_state); }void intel_color_crtc_init (struct intel_crtc *crtc)drivers/gpu/drm/i915/display/intel_color.h +2
-0@@ -43,4 +43,6 @@ bool intel_color_lut_equal(const struct intel_crtc_state *crtc_state,void intel_color_assert_luts (const struct intel_crtc_state *crtc_state);void intel_color_plane_program_pipeline (struct intel_dsb *dsb,const struct intel_plane_state *plane_state); +void intel_color_plane_commit_arm (struct intel_dsb *dsb, +const struct intel_plane_state *plane_state);#endif /* __INTEL_COLOR_H__ */ drivers/gpu/drm/i915/display/intel_color_pipeline.c +32
-3@@ -12,11 +12,24 @@#define PLANE_DEGAMMA_SIZE 128#define PLANE_GAMMA_SIZE 32 +static inline bool +intel_crtc_has_lut_3d (struct intel_display *display,enum pipe pipe) +{ +if (DISPLAY_VER (display) >=12 ) +return pipe ==PIPE_A || pipe ==PIPE_B ; +else if (DISPLAY_VER (display) >=10 /*|| IS_GEMINILAKE(display)*/ ) +return pipe ==PIPE_A ; +else +return false; +} +static -int _intel_color_pipeline_plane_init (struct drm_plane *plane,struct drm_prop_enum_list *list) +int _intel_color_pipeline_plane_init (struct drm_plane *plane,struct drm_prop_enum_list *list, +enum pipe pipe) {struct intel_colorop *colorop;struct drm_device *dev = plane->dev; +struct intel_display *display =to_intel_display (dev);int ret;struct drm_colorop *prev_op;@@ -36,6 +49,22 @@ int _intel_color_pipeline_plane_init(struct drm_plane *plane, struct drm_prop_en/* TODO: handle failures and clean up */ prev_op = &colorop->base; +if (DISPLAY_VER (display) >=35 && +intel_crtc_has_lut_3d (display, pipe) && + plane->type ==DRM_PLANE_TYPE_PRIMARY ) { + colorop =intel_colorop_create (INTEL_PLANE_CB_3DLUT ); + + ret =drm_plane_colorop_3dlut_init (dev, &colorop->base, plane,17 , +DRM_COLOROP_LUT3D_INTERPOLATION_TETRAHEDRAL , + true); +if (ret) +return ret; + +drm_colorop_set_next_property (prev_op, &colorop->base); + + prev_op = &colorop->base; + } + colorop =intel_colorop_create (INTEL_PLANE_CB_CSC ); ret =drm_plane_colorop_ctm_3x4_init (dev, &colorop->base, plane,DRM_COLOROP_FLAG_ALLOW_BYPASS );@@ -58,7 +87,7 @@ int _intel_color_pipeline_plane_init(struct drm_plane *plane, struct drm_prop_enreturn 0 ; } -int intel_color_pipeline_plane_init (struct drm_plane *plane) +int intel_color_pipeline_plane_init (struct drm_plane *plane,enum pipe pipe) {struct drm_device *dev = plane->dev;struct intel_display *display =to_intel_display (dev);@@ -77,7 +106,7 @@ int intel_color_pipeline_plane_init(struct drm_plane *plane) len++;/* Add pipeline consisting of transfer functions */ - ret =_intel_color_pipeline_plane_init (plane, &pipelines[len]); + ret =_intel_color_pipeline_plane_init (plane, &pipelines[len], pipe);if (ret)return ret; len++;drivers/gpu/drm/i915/display/intel_color_pipeline.h +2
-1@@ -7,7 +7,8 @@#define __INTEL_COLOR_PIPELINE_H__struct drm_plane ; +enum pipe ; -int intel_color_pipeline_plane_init (struct drm_plane *plane); +int intel_color_pipeline_plane_init (struct drm_plane *plane,enum pipe pipe);#endif /* __INTEL_COLOR_PIPELINE_H__ */ drivers/gpu/drm/i915/display/intel_display_limits.h +1
-0@@ -142,6 +142,7 @@ enum intel_color_block {INTEL_PLANE_CB_PRE_CSC_LUT ,INTEL_PLANE_CB_CSC ,INTEL_PLANE_CB_POST_CSC_LUT , +INTEL_PLANE_CB_3DLUT , INTEL_CB_MAX };drivers/gpu/drm/i915/display/intel_display_types.h +1
-1@@ -646,7 +646,7 @@ struct intel_plane_state {enum drm_color_encoding color_encoding;enum drm_color_range color_range;enum drm_scaling_filter scaling_filter; -struct drm_property_blob *ctm, *degamma_lut, *gamma_lut; +struct drm_property_blob *ctm, *degamma_lut, *gamma_lut, *lut_3d; } hw;struct i915_vma *ggtt_vma;drivers/gpu/drm/i915/display/intel_plane.c +2
-0@@ -348,6 +348,8 @@ intel_plane_colorop_replace_blob(struct intel_plane_state *plane_state,return drm_property_replace_blob (&plane_state->hw.degamma_lut, blob); else if (intel_colorop->id == INTEL_PLANE_CB_POST_CSC_LUT) return drm_property_replace_blob(&plane_state->hw.gamma_lut, blob); + else if (intel_colorop->id == INTEL_PLANE_CB_3DLUT) + return drm_property_replace_blob(&plane_state->hw.lut_3d, blob);return false; }
Signature · 1 line
Jani Nikula, Intel
RE: [v6 15/16] drm/i915/color: Add 3D LUT to color pipeline
In reply to Uma ShankarQuoted 126 lines
Subject: [v6 15/16] drm/i915/color: Add 3D LUT to color pipeline
From: Chaitanya Kumar Borah <[email protected]>
Add helpers to program the 3D LUT registers and arm them.
Signed-off-by Chaitanya Kumar Borah <[email protected]>Signed-off-by Uma Shankar <[email protected]>--- drivers/gpu/drm/i915/display/intel_color.c | 57 +++++++++++++++++++ drivers/gpu/drm/i915/display/intel_color.h | 2 + .../drm/i915/display/intel_color_pipeline.c | 35 +++++++++++- .../drm/i915/display/intel_color_pipeline.h | 3 +- .../drm/i915/display/intel_display_limits.h | 1 + .../drm/i915/display/intel_display_types.h | 2 +- drivers/gpu/drm/i915/display/intel_plane.c | 2 + 7 files changed, 97 insertions(+), 5 deletions(-)drivers/gpu/drm/i915/display/intel_color.c +0
-0@@ -4061,6 +4061,44 @@ xelpd_plane_load_luts(struct intel_dsb *dsb,const struct
intel_plane_state*pladrivers/gpu/drm/i915/display/intel_color.c +2
-0xelpd_program_plane_post_csc_lut (dsb, plane_state); } +static u32 glk_3dlut_10 (const struct drm_color_lut32 *color) { + return REG_FIELD_PREP(LUT_3D_DATA_RED_MASK,
drm_color_lut32_extract(color->red, 10)) |drivers/gpu/drm/i915/display/intel_color.c +1
-0+ REG_FIELD_PREP(LUT_3D_DATA_GREEN_MASK,
drm_color_lut32_extract(color->green, 10)) |drivers/gpu/drm/i915/display/intel_color.c +12
-0+REG_FIELD_PREP (LUT_3D_DATA_BLUE_MASK , +drm_color_lut32_extract (color->blue,10 )); } + +static void glk_load_lut_3d (struct intel_dsb *dsb, +struct intel_crtc *crtc, +const struct drm_property_blob *blob) { +struct intel_display *display =to_intel_display (crtc->base.dev); +const struct drm_color_lut32 *lut = blob->data; +int i, lut_size =drm_color_lut32_size (blob); +enum pipe pipe = crtc->pipe; + + WARN_ON(intel_de_read(display, LUT_3D_CTL(pipe)) &
LUT_3D_READY);drivers/gpu/drm/i915/display/intel_color.c +1
-0+ intel_de_write_dsb(display, dsb, LUT_3D_INDEX(pipe),
LUT_3D_AUTO_INCREMENT);drivers/gpu/drm/i915/display/intel_color.c +2
-0+for (i =0 ; i < lut_size; i++) + intel_de_write_dsb(display, dsb, LUT_3D_DATA(pipe),
glk_3dlut_10(&lut[i]));drivers/gpu/drm/i915/display/intel_color.c +9
-0+intel_de_write_dsb (display, dsb,LUT_3D_INDEX (pipe),0 ); } + +static void glk_lut_3d_commit (struct intel_dsb *dsb,struct intel_crtc +*crtc,bool enable) { +struct intel_display *display =to_intel_display (crtc); +enum pipe pipe = crtc->pipe; +u32 val; + + WARN_ON(intel_de_read(display, LUT_3D_CTL(pipe)) &
LUT_3D_READY);drivers/gpu/drm/i915/display/intel_color.c +3
-0+ +if (enable) + val = LUT_3D_ENABLE | LUT_3D_READY |
LUT_3D_BIND_PLANE_1;drivers/gpu/drm/i915/display/intel_color.c +4
-0+else + val =0 ; +intel_de_write_dsb (display, dsb,LUT_3D_CTL (pipe), val); } +static const struct intel_color_funcs chv_color_funcs = { .color_check = chv_color_check, .color_commit_arm = i9xx_color_commit_arm, @@ -4190,6 +4228,14@@ static const struct
intel_color_funcsilk_color_funcs= {drivers/gpu/drm/i915/display/intel_color.c +2
-0.get_config = ilk_get_config, }; +void intel_color_plane_commit_arm (struct intel_dsb *dsb, +const struct intel_plane_state *plane_state){
drivers/gpu/drm/i915/display/intel_color.c +13
-0+struct intel_crtc *crtc =to_intel_crtc (plane_state->uapi.crtc); + +glk_lut_3d_commit (dsb, crtc, !!plane_state->hw.lut_3d); } +static void intel_color_load_plane_csc_matrix (struct intel_dsb *dsb,const struct intel_plane_state *plane_state)@@ -4210,6 +4256,15 @@ intel_color_load_plane_luts(struct intel_dsb *dsb, display->funcs.color->load_plane_luts (dsb, plane_state); } +static void +intel_color_load_3dlut (struct intel_dsb *dsb, +const struct intel_plane_state *plane_state) { +struct intel_crtc *crtc =to_intel_crtc (plane_state->uapi.crtc); + +glk_load_lut_3d (dsb, crtc, plane_state->hw.lut_3d); } +void intel_color_plane_program_pipeline (struct intel_dsb *dsb,const struct intel_plane_state *plane_state) { @@ -4217,6 +4272,8 @@ voidintel_color_plane_program_pipeline (struct intel_dsb *dsb, intel_color_load_plane_csc_matrix(dsb, plane_state);if (plane_state->hw.degamma_lut || plane_state->hw.gamma_lut)intel_color_load_plane_luts (dsb, plane_state); +if (plane_state->hw.lut_3d) +intel_color_load_3dlut (dsb, plane_state); } void intel_color_crtc_init(struct intel_crtc *crtc) diff --git
a/drivers/gpu/drm/i915/display/intel_color.hb/drivers/gpu/drm/i915/display/intel_color.h
index8051c827a1d8..a70df0c2bd9a100644drivers/gpu/drm/i915/display/intel_color.h +2
-0@@ -43,4 +43,6 @@ bool intel_color_lut_equal(const struct intel_crtc_state *crtc_state, void intel_color_assert_luts(const struct intel_crtc_state *crtc_state);void intel_color_plane_program_pipeline (struct intel_dsb *dsb,const struct intel_plane_state *plane_state); +void intel_color_plane_commit_arm (struct intel_dsb *dsb, +const struct intel_plane_state *plane_state);#endif /*
__INTEL_COLOR_H__*/drivers/gpu/drm/i915/display/intel_color_pipeline.c +0
-0
drivers/gpu/drm/i915/display/intel_color_pipeline.c line 20
Quoted 9 lines
drivers/gpu/drm/i915/display/intel_color_pipeline.c +6
-0@@ -12,11 +12,24 @@#define PLANE_DEGAMMA_SIZE 128#define PLANE_GAMMA_SIZE 32 +static inline bool +intel_crtc_has_lut_3d (struct intel_display *display,enum pipe pipe) { +if (DISPLAY_VER (display) >=12 ) +return pipe ==PIPE_A || pipe ==PIPE_B ; +else if (DISPLAY_VER (display) >=10 /*|| IS_GEMINILAKE(display)*/ ) +return pipe ==PIPE_A ;
Is this required specially if this function is only used for color pipeline which Is only being exposed for DISPLAY_VER(display) >= 12 so maybe the else if part is not needed
Regards,
Suraj Kandpal
Quoted 129 lines
drivers/gpu/drm/i915/display/intel_color_pipeline.c +23
-1+else +return false; +} +static -int _intel_color_pipeline_plane_init(struct drm_plane *plane, struct drm_prop_enum_list *list) +int _intel_color_pipeline_plane_init(struct drm_plane *plane, structdrm_prop_enum_list *list, +enum pipe pipe) {struct intel_colorop *colorop;struct drm_device *dev = plane->dev; +struct intel_display *display =to_intel_display (dev);int ret;struct drm_colorop *prev_op;@@ -36,6 +49,22 @@ int _intel_color_pipeline_plane_init(struct drm_plane *plane, struct drm_prop_en/* TODO: handle failures and clean up */ prev_op = &colorop->base; +if (DISPLAY_VER (display) >=35 && +intel_crtc_has_lut_3d (display, pipe) && + plane->type ==DRM_PLANE_TYPE_PRIMARY ) { + colorop =intel_colorop_create (INTEL_PLANE_CB_3DLUT ); + + ret =drm_plane_colorop_3dlut_init (dev, &colorop->base, plane,17 , +DRM_COLOROP_LUT3D_INTERPOLATION_TETRAHEDRAL , + true); +if (ret) +return ret; + +drm_colorop_set_next_property (prev_op, &colorop->base); + + prev_op = &colorop->base; + } +drivers/gpu/drm/i915/display/intel_color_pipeline.c +0
-0colorop =intel_colorop_create (INTEL_PLANE_CB_CSC ); ret = drm_plane_colorop_ctm_3x4_init(dev, &colorop->base, plane,
DRM_COLOROP_FLAG_ALLOW_BYPASS); @@ -58,7 +87,7 @@ int _intel_color_pipeline_plane_init(structdrm_plane*plane, structdrm_prop_endrivers/gpu/drm/i915/display/intel_color_pipeline.c +2
-1return 0 ; } -int intel_color_pipeline_plane_init (struct drm_plane *plane) +int intel_color_pipeline_plane_init (struct drm_plane *plane,enum pipe +pipe) {struct drm_device *dev = plane->dev; struct intel_display *display = to_intel_display(dev); @@ -77,7 +106,7@@ int
intel_color_pipeline_plane_init(struct drm_plane *plane)drivers/gpu/drm/i915/display/intel_color_pipeline.c +1
-1len++;/* Add pipeline consisting of transfer functions */ - ret =_intel_color_pipeline_plane_init (plane, &pipelines[len]); + ret =_intel_color_pipeline_plane_init (plane, &pipelines[len], pipe);if (ret)return ret; len++;drivers/gpu/drm/i915/display/intel_color_pipeline.h +3
-1@@ -7,7 +7,8 @@#define __INTEL_COLOR_PIPELINE_H__struct drm_plane ; +enum pipe ; -int intel_color_pipeline_plane_init (struct drm_plane *plane); +int intel_color_pipeline_plane_init (struct drm_plane *plane,enum pipe +pipe); #endif /* __INTEL_COLOR_PIPELINE_H__ */ diff --git
a/drivers/gpu/drm/i915/display/intel_display_limits.hb/drivers/gpu/drm/i915/display/intel_display_limits.hindex55fd574ba313..cb3c9c665c44100644drivers/gpu/drm/i915/display/intel_display_limits.h +1
-0@@ -142,6 +142,7 @@ enum intel_color_block {INTEL_PLANE_CB_PRE_CSC_LUT ,INTEL_PLANE_CB_CSC ,INTEL_PLANE_CB_POST_CSC_LUT , +INTEL_PLANE_CB_3DLUT , INTEL_CB_MAX };drivers/gpu/drm/i915/display/intel_display_types.h +1
-1@@ -646,7 +646,7 @@ struct intel_plane_state {enum drm_color_encoding color_encoding;enum drm_color_range color_range;enum drm_scaling_filter scaling_filter; -struct drm_property_blob *ctm, *degamma_lut, *gamma_lut; +struct drm_property_blob *ctm, *degamma_lut, *gamma_lut, *lut_3d; } hw;drivers/gpu/drm/i915/display/intel_display_types.h +0
-0struct i915_vma *ggtt_vma;drivers/gpu/drm/i915/display/intel_plane.c +2
-0@@ -348,6 +348,8 @@ intel_plane_colorop_replace_blob(structintel_plane_state *plane_state, return drm_property_replace_blob(&plane_state- >hw.degamma_lut, blob); else if (intel_colorop->id == INTEL_PLANE_CB_POST_CSC_LUT) return drm_property_replace_blob(&plane_state- >hw.gamma_lut, blob); + else if (intel_colorop->id == INTEL_PLANE_CB_3DLUT) + return drm_property_replace_blob(&plane_state-Quoted 1 line
hw.lut_3d, blob);
return false;
}
--
2.50.1
Re: [v6 15/16] drm/i915/color: Add 3D LUT to color pipeline
Quoted 129 lines · Suraj
Quoted 129 lines
Subject: [v6 15/16] drm/i915/color: Add 3D LUT to color pipeline
From: Chaitanya Kumar Borah <[email protected]>
Add helpers to program the 3D LUT registers and arm them.
Signed-off-by Chaitanya Kumar Borah <[email protected]>Signed-off-by Uma Shankar <[email protected]>--- drivers/gpu/drm/i915/display/intel_color.c | 57 +++++++++++++++++++ drivers/gpu/drm/i915/display/intel_color.h | 2 + .../drm/i915/display/intel_color_pipeline.c | 35 +++++++++++- .../drm/i915/display/intel_color_pipeline.h | 3 +- .../drm/i915/display/intel_display_limits.h | 1 + .../drm/i915/display/intel_display_types.h | 2 +- drivers/gpu/drm/i915/display/intel_plane.c | 2 + 7 files changed, 97 insertions(+), 5 deletions(-)drivers/gpu/drm/i915/display/intel_color.c +0
-0@@ -4061,6 +4061,44 @@ xelpd_plane_load_luts(struct intel_dsb *dsb,const struct
intel_plane_state*pla
xelpd_program_plane_post_csc_lut(dsb, plane_state); }drivers/gpu/drm/i915/display/intel_color.c +2
-0+static u32 glk_3dlut_10 (const struct drm_color_lut32 *color) { + return REG_FIELD_PREP(LUT_3D_DATA_RED_MASK,
drm_color_lut32_extract(color->red, 10)) |drivers/gpu/drm/i915/display/intel_color.c +1
-0+ REG_FIELD_PREP(LUT_3D_DATA_GREEN_MASK,
drm_color_lut32_extract(color->green, 10)) |drivers/gpu/drm/i915/display/intel_color.c +12
-0+REG_FIELD_PREP (LUT_3D_DATA_BLUE_MASK , +drm_color_lut32_extract (color->blue,10 )); } + +static void glk_load_lut_3d (struct intel_dsb *dsb, +struct intel_crtc *crtc, +const struct drm_property_blob *blob) { +struct intel_display *display =to_intel_display (crtc->base.dev); +const struct drm_color_lut32 *lut = blob->data; +int i, lut_size =drm_color_lut32_size (blob); +enum pipe pipe = crtc->pipe; + + WARN_ON(intel_de_read(display, LUT_3D_CTL(pipe)) &
LUT_3D_READY);drivers/gpu/drm/i915/display/intel_color.c +1
-0+ intel_de_write_dsb(display, dsb, LUT_3D_INDEX(pipe),
LUT_3D_AUTO_INCREMENT);drivers/gpu/drm/i915/display/intel_color.c +2
-0+for (i =0 ; i < lut_size; i++) + intel_de_write_dsb(display, dsb, LUT_3D_DATA(pipe),
glk_3dlut_10(&lut[i]));drivers/gpu/drm/i915/display/intel_color.c +9
-0+intel_de_write_dsb (display, dsb,LUT_3D_INDEX (pipe),0 ); } + +static void glk_lut_3d_commit (struct intel_dsb *dsb,struct intel_crtc +*crtc,bool enable) { +struct intel_display *display =to_intel_display (crtc); +enum pipe pipe = crtc->pipe; +u32 val; + + WARN_ON(intel_de_read(display, LUT_3D_CTL(pipe)) &
LUT_3D_READY);drivers/gpu/drm/i915/display/intel_color.c +3
-0+ +if (enable) + val = LUT_3D_ENABLE | LUT_3D_READY |
LUT_3D_BIND_PLANE_1;drivers/gpu/drm/i915/display/intel_color.c +4
-0+else + val =0 ; +intel_de_write_dsb (display, dsb,LUT_3D_CTL (pipe), val); } +static const struct intel_color_funcs chv_color_funcs = { .color_check = chv_color_check, .color_commit_arm = i9xx_color_commit_arm, @@ -4190,6 +4228,14@@ static const struct
intel_color_funcsilk_color_funcs= {
.get_config =ilk_get_config,
};drivers/gpu/drm/i915/display/intel_color.c +2
-0+void intel_color_plane_commit_arm (struct intel_dsb *dsb, +const struct intel_plane_state *plane_state){
drivers/gpu/drm/i915/display/intel_color.c +13
-0+struct intel_crtc *crtc =to_intel_crtc (plane_state->uapi.crtc); + +glk_lut_3d_commit (dsb, crtc, !!plane_state->hw.lut_3d); } +static void intel_color_load_plane_csc_matrix (struct intel_dsb *dsb,const struct intel_plane_state *plane_state)@@ -4210,6 +4256,15 @@ intel_color_load_plane_luts(struct intel_dsb *dsb, display->funcs.color->load_plane_luts (dsb, plane_state); } +static void +intel_color_load_3dlut (struct intel_dsb *dsb, +const struct intel_plane_state *plane_state) { +struct intel_crtc *crtc =to_intel_crtc (plane_state->uapi.crtc); + +glk_load_lut_3d (dsb, crtc, plane_state->hw.lut_3d); } +void intel_color_plane_program_pipeline (struct intel_dsb *dsb,const struct intel_plane_state *plane_state) { @@ -4217,6 +4272,8 @@ voidintel_color_plane_program_pipeline (struct intel_dsb *dsb, intel_color_load_plane_csc_matrix(dsb, plane_state);if (plane_state->hw.degamma_lut || plane_state->hw.gamma_lut)intel_color_load_plane_luts (dsb, plane_state); +if (plane_state->hw.lut_3d) +intel_color_load_3dlut (dsb, plane_state); } void intel_color_crtc_init(struct intel_crtc *crtc) diff --git
a/drivers/gpu/drm/i915/display/intel_color.hb/drivers/gpu/drm/i915/display/intel_color.h
index8051c827a1d8..a70df0c2bd9a100644drivers/gpu/drm/i915/display/intel_color.h +2
-0@@ -43,4 +43,6 @@ bool intel_color_lut_equal(const struct intel_crtc_state *crtc_state, void intel_color_assert_luts(const struct intel_crtc_state *crtc_state);void intel_color_plane_program_pipeline (struct intel_dsb *dsb,const struct intel_plane_state *plane_state); +void intel_color_plane_commit_arm (struct intel_dsb *dsb, +const struct intel_plane_state *plane_state);#endif /* __INTEL_COLOR_H__ */drivers/gpu/drm/i915/display/intel_color_pipeline.c +0
-0@@ -12,11 +12,24 @@#define PLANE_DEGAMMA_SIZE 128#define PLANE_GAMMA_SIZE 32
Quoted 10 lines
drivers/gpu/drm/i915/display/intel_color_pipeline.c line 21
Quoted 6 lines
drivers/gpu/drm/i915/display/intel_color_pipeline.c +6
-0+static inline bool +intel_crtc_has_lut_3d (struct intel_display *display,enum pipe pipe) { +if (DISPLAY_VER (display) >=12 ) +return pipe ==PIPE_A || pipe ==PIPE_B ; +else if (DISPLAY_VER (display) >=10 /*|| IS_GEMINILAKE(display)*/ ) +return pipe ==PIPE_A ;Is this required specially if this function is only used for color pipeline which Is only being exposed for
DISPLAY_VER(display)>= 12 so maybe the else if part is not needed
This will be needed once we have the *PIPE* color pipeline but for now we can skip.
==
Chaitanya
Quoted 133 lines
Regards,
Suraj KandpalQuoted 129 lines
drivers/gpu/drm/i915/display/intel_color_pipeline.c +23
-1+else +return false; +} +static -int _intel_color_pipeline_plane_init(struct drm_plane *plane, struct drm_prop_enum_list *list) +int _intel_color_pipeline_plane_init(struct drm_plane *plane, structdrm_prop_enum_list *list, +enum pipe pipe) {struct intel_colorop *colorop;struct drm_device *dev = plane->dev; +struct intel_display *display =to_intel_display (dev);int ret;struct drm_colorop *prev_op;@@ -36,6 +49,22 @@ int _intel_color_pipeline_plane_init(struct drm_plane *plane, struct drm_prop_en/* TODO: handle failures and clean up */ prev_op = &colorop->base; +if (DISPLAY_VER (display) >=35 && +intel_crtc_has_lut_3d (display, pipe) && + plane->type ==DRM_PLANE_TYPE_PRIMARY ) { + colorop =intel_colorop_create (INTEL_PLANE_CB_3DLUT ); + + ret =drm_plane_colorop_3dlut_init (dev, &colorop->base, plane,17 , +DRM_COLOROP_LUT3D_INTERPOLATION_TETRAHEDRAL , + true); +if (ret) +return ret; + +drm_colorop_set_next_property (prev_op, &colorop->base); + + prev_op = &colorop->base; + } +colorop =
intel_colorop_create(INTEL_PLANE_CB_CSC); ret = drm_plane_colorop_ctm_3x4_init(dev,&colorop->base, plane,
DRM_COLOROP_FLAG_ALLOW_BYPASS); @@ -58,7 +87,7 @@ int _intel_color_pipeline_plane_init(structdrm_plane*plane, structdrm_prop_en
return 0;
}drivers/gpu/drm/i915/display/intel_color_pipeline.c +2
-1-int intel_color_pipeline_plane_init (struct drm_plane *plane) +int intel_color_pipeline_plane_init (struct drm_plane *plane,enum pipe +pipe) {struct drm_device *dev = plane->dev; struct intel_display *display = to_intel_display(dev); @@ -77,7 +106,7@@ int
intel_color_pipeline_plane_init(struct drm_plane *plane)
len++;/* Add pipeline consisting of transfer functions */
drivers/gpu/drm/i915/display/intel_color_pipeline.c +1
-1- ret =_intel_color_pipeline_plane_init (plane, &pipelines[len]); + ret =_intel_color_pipeline_plane_init (plane, &pipelines[len], pipe);if (ret)return ret; len++;drivers/gpu/drm/i915/display/intel_color_pipeline.h +3
-1@@ -7,7 +7,8 @@#define __INTEL_COLOR_PIPELINE_H__struct drm_plane ; +enum pipe ; -int intel_color_pipeline_plane_init (struct drm_plane *plane); +int intel_color_pipeline_plane_init (struct drm_plane *plane,enum pipe +pipe); #endif /* __INTEL_COLOR_PIPELINE_H__ */ diff --git
a/drivers/gpu/drm/i915/display/intel_display_limits.hb/drivers/gpu/drm/i915/display/intel_display_limits.hindex55fd574ba313..cb3c9c665c44100644drivers/gpu/drm/i915/display/intel_display_limits.h +1
-0@@ -142,6 +142,7 @@ enum intel_color_block {INTEL_PLANE_CB_PRE_CSC_LUT ,INTEL_PLANE_CB_CSC ,INTEL_PLANE_CB_POST_CSC_LUT , +INTEL_PLANE_CB_3DLUT , INTEL_CB_MAX };drivers/gpu/drm/i915/display/intel_display_types.h +1
-1@@ -646,7 +646,7 @@ struct intel_plane_state {enum drm_color_encoding color_encoding;enum drm_color_range color_range;enum drm_scaling_filter scaling_filter; -struct drm_property_blob *ctm, *degamma_lut, *gamma_lut; +struct drm_property_blob *ctm, *degamma_lut, *gamma_lut, *lut_3d; } hw;struct
i915_vma*ggtt_vma;drivers/gpu/drm/i915/display/intel_plane.c +2
-0@@ -348,6 +348,8 @@ intel_plane_colorop_replace_blob(structintel_plane_state *plane_state, return drm_property_replace_blob(&plane_state- > hw.degamma_lut, blob); else if (intel_colorop->id == INTEL_PLANE_CB_POST_CSC_LUT) return drm_property_replace_blob(&plane_state- > hw.gamma_lut, blob); + else if (intel_colorop->id == INTEL_PLANE_CB_3DLUT) + return drm_property_replace_blob(&plane_state-Quoted 1 line
hw.lut_3d, blob);
return false;
}
--
2.50.1
PATCH v6 16/16 drm/i915/color: Enable Plane Color Pipelines
In reply to Uma ShankarExpose color pipeline and add ability to program it.
v2: Set bit to enable multisegmented lut
v3: s/drm_color_lut_32/drm_color_lut32 (Simon)
v4: - Fix dsb programming
- Remove multi-segment LUT, they will be added in later patches
- Add pipeline only to TGL+
- Code Refactor
--- drivers/gpu/drm/i915/display/intel_display.c | 5 ++++- .../drm/i915/display/skl_universal_plane.c | 21 +++++++++++++++++++ 2 files changed, 25 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/display/intel_display.c +4 -1
@@ -7284,6 +7284,7 @@ static void intel_atomic_dsb_finish(struct intel_atomic_state *state,struct intel_display *display =to_intel_display (state);struct intel_crtc_state *new_crtc_state =intel_atomic_get_new_crtc_state (state, crtc); +unsigned int size = new_crtc_state->plane_color_changed ?8192 :1024 ; if (!new_crtc_state->use_flipq && !new_crtc_state->use_dsb &&
@@ -7294,10 +7295,12 @@ static void intel_atomic_dsb_finish(struct intel_atomic_state *state,* Rough estimate: * ~64 registers per each plane * 8 planes = 512 * Double that for pipe stuff and other overhead. +* ~4913 registers for 3DLUT +* ~200 color registers * 3 HDR planes */ new_crtc_state->dsb_commit =intel_dsb_prepare (state, crtc,INTEL_DSB_0 , new_crtc_state->use_dsb || - new_crtc_state->use_flipq ?1024 :16 ); + new_crtc_state->use_flipq ? size :16 );if (!new_crtc_state->dsb_commit) { new_crtc_state->use_flipq = false; new_crtc_state->use_dsb = false;
drivers/gpu/drm/i915/display/skl_universal_plane.c +21 -0
@@ -11,6 +11,8 @@#include "pxp/intel_pxp.h" #include "intel_bo.h" +#include "intel_color.h" +#include "intel_color_pipeline.h" #include "intel_de.h" #include "intel_display_irq.h" #include "intel_display_regs.h"
@@ -1276,6 +1278,18 @@ static u32 glk_plane_color_ctl(const struct intel_plane_state *plane_state)if (plane_state->force_black) plane_color_ctl |=PLANE_COLOR_PLANE_CSC_ENABLE ; +if (plane_state->hw.degamma_lut) + plane_color_ctl |=PLANE_COLOR_PRE_CSC_GAMMA_ENABLE ; + +if (plane_state->hw.ctm) + plane_color_ctl |=PLANE_COLOR_PLANE_CSC_ENABLE ; + +if (plane_state->hw.gamma_lut) { + plane_color_ctl &= ~PLANE_COLOR_PLANE_GAMMA_DISABLE ; +if (drm_color_lut32_size (plane_state->hw.gamma_lut) !=32 ) + plane_color_ctl |=PLANE_COLOR_POST_CSC_GAMMA_MULTSEG_ENABLE ; + } +return plane_color_ctl; }
@@ -1557,6 +1571,8 @@ icl_plane_update_noarm(struct intel_dsb *dsb, plane_color_ctl = plane_state->color_ctl |glk_plane_color_ctl_crtc (crtc_state); +intel_color_plane_program_pipeline (dsb, plane_state); +/* The scaler will handle the output position */ if (plane_state->scaler_id >=0 ) { crtc_x =0 ;
@@ -1658,6 +1674,8 @@ icl_plane_update_arm(struct intel_dsb *dsb,icl_plane_update_sel_fetch_arm (dsb, plane, crtc_state, plane_state); +intel_color_plane_commit_arm (dsb, plane_state); +/* * In order to have FBC for fp16 formats pixel normalizer block must be * active. Check if pixel normalizer block need to be enabled for FBC.
@@ -3001,6 +3019,9 @@ skl_universal_plane_create(struct intel_display *display,DRM_COLOR_YCBCR_BT709 , DRM_COLOR_YCBCR_LIMITED_RANGE); +if (DISPLAY_VER (display) >=12 ) +intel_color_pipeline_plane_init (&plane->base, pipe); +drm_plane_create_alpha_property (&plane->base); drm_plane_create_blend_mode_property(&plane->base, BIT(DRM_MODE_BLEND_PIXEL_NONE) |
Signature · 1 line
2.50.1
RE: [v6 16/16] drm/i915/color: Enable Plane Color Pipelines
Quoted 11 lines
Subject: [v6 16/16] drm/i915/color: Enable Plane Color Pipelines
Expose color pipeline and add ability to program it.
v2: Set bit to enable multisegmented lut
v3: s/drm_color_lut_32/drm_color_lut32 (Simon)
v4: - Fix dsb programming
- Remove multi-segment LUT, they will be added in later patches
- Add pipeline only to TGL+
- Code Refactor
Quoted 2 lines
Signed-off-by Chaitanya Kumar Borah <[email protected]>Signed-off-by Uma Shankar <[email protected]>
LGTM,
Quoted 109 lines
--- drivers/gpu/drm/i915/display/intel_display.c | 5 ++++- .../drm/i915/display/skl_universal_plane.c | 21 +++++++++++++++++++ 2 files changed, 25 insertions(+), 1 deletion(-)drivers/gpu/drm/i915/display/intel_display.c +1
-0@@ -7284,6 +7284,7 @@ static void intel_atomic_dsb_finish(structintel_atomic_state *state, struct intel_display *display = to_intel_display(state);struct intel_crtc_state *new_crtc_state =intel_atomic_get_new_crtc_state (state, crtc); +unsigned int size = new_crtc_state->plane_color_changed ?8192 :1024 ;drivers/gpu/drm/i915/display/intel_display.c +2
-0if (!new_crtc_state->use_flipq && !new_crtc_state->use_dsb &&@@ -7294,10 +7295,12 @@ static void intel_atomic_dsb_finish(structintel_atomic_state *state, * Rough estimate: * ~64 registers per each plane * 8 planes = 512 * Double that for pipe stuff and other overhead. +* ~4913 registers for 3DLUT +* ~200 color registers * 3 HDR planes */ new_crtc_state->dsb_commit =intel_dsb_prepare (state, crtc,INTEL_DSB_0 , new_crtc_state->use_dsb||
drivers/gpu/drm/i915/display/intel_display.c +0
-1- new_crtc_state-Quoted 1 line
use_flipq? 1024 : 16);drivers/gpu/drm/i915/display/intel_display.c +1
-0+ new_crtc_state-Quoted 1 line
use_flipq? size : 16);drivers/gpu/drm/i915/display/intel_display.c +0
-0if (!new_crtc_state->dsb_commit) { new_crtc_state->use_flipq = false; new_crtc_state->use_dsb = false;drivers/gpu/drm/i915/display/skl_universal_plane.c +12
-0@@ -11,6 +11,8 @@#include "pxp/intel_pxp.h" #include "intel_bo.h" +#include "intel_color.h" +#include "intel_color_pipeline.h" #include "intel_de.h" #include "intel_display_irq.h" #include "intel_display_regs.h" @@ -1276,6 +1278,18 @@ static u32 glk_plane_color_ctl(const struct intel_plane_state *plane_state)if (plane_state->force_black) plane_color_ctl |=PLANE_COLOR_PLANE_CSC_ENABLE ; +if (plane_state->hw.degamma_lut) + plane_color_ctl |=PLANE_COLOR_PRE_CSC_GAMMA_ENABLE ; + +if (plane_state->hw.ctm) + plane_color_ctl |=PLANE_COLOR_PLANE_CSC_ENABLE ; + +if (plane_state->hw.gamma_lut) { + plane_color_ctl &= ~PLANE_COLOR_PLANE_GAMMA_DISABLE ; +if (drm_color_lut32_size (plane_state->hw.gamma_lut) !=32 ) + plane_color_ctl |=
PLANE_COLOR_POST_CSC_GAMMA_MULTSEG_ENABLE;drivers/gpu/drm/i915/display/skl_universal_plane.c +9
-0+ } +return plane_color_ctl; }@@ -1557,6 +1571,8 @@ icl_plane_update_noarm(struct intel_dsb *dsb, plane_color_ctl = plane_state->color_ctl |glk_plane_color_ctl_crtc (crtc_state); +intel_color_plane_program_pipeline (dsb, plane_state); +/* The scaler will handle the output position */ if (plane_state->scaler_id >=0 ) { crtc_x =0 ;@@ -1658,6 +1674,8 @@ icl_plane_update_arm(struct intel_dsb *dsb,icl_plane_update_sel_fetch_arm (dsb, plane, crtc_state, plane_state); +intel_color_plane_commit_arm (dsb, plane_state); +/* * In order to have FBC for fp16 formats pixel normalizer block must be * active. Check if pixel normalizer block need to be enabled for FBC. @@ -3001,6 +3019,9 @@ skl_universal_plane_create(struct intel_display *display,DRM_COLOR_YCBCR_BT709 , DRM_COLOR_YCBCR_LIMITED_RANGE); +if (DISPLAY_VER (display) >=12 ) +intel_color_pipeline_plane_init (&plane->base, pipe); +drm_plane_create_alpha_property (&plane->base);drm_plane_create_blend_mode_property(&plane->base,
BIT(DRM_MODE_BLEND_PIXEL_NONE)|
--
2.50.1
Patchwork
CI✗ CI.checkpatch: warning for Plane Color Pipeline support for Intel platforms (rev5)
In reply to Uma Shankar== Series Details ==
== Series Details ==
Series: Plane Color Pipeline support for Intel platforms (rev5)
URL : https://patchwork.freedesktop.org/series/141788/
State : warning
== Summary ==
+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master f867e605613af1770f90c4b0afd4a8f06424d1f0
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 89fc3c0bfb005e4541de97f5f9786e555176c03d
Author: Uma Shankar <[email protected]> Date: Wed Nov 5 18:04:12 2025 +0530
drm/i915/color: Enable Plane Color Pipelines
Expose color pipeline and add ability to program it.
v2: Set bit to enable multisegmented lut
v3: s/drm_color_lut_32/drm_color_lut32 (Simon)
v4: - Fix dsb programming
- Remove multi-segment LUT, they will be added in later patches
- Add pipeline only to TGL+
- Code Refactor
+ /mt/dim checkpatch 8043455e28fb7b8089e55e4390547a4c3d7bd4dc drm-intel a76ac9300351 drm: AMD series squashed
-:50: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #50:
new file mode 100644
-:734: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "gamma" #734: FILE: drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_color.c:724:
+ gamma, gamma != NULL);
-:742: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "gamma" #742: FILE: drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_color.c:732:
+ res = mod_color_calculate_regamma_params(func, gamma, gamma != NULL,
-:752: CHECK:LINE_SPACING: Please don't use multiple blank lines #752: FILE: drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_color.c:742:
+
+
-:788: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "gamma" #788: FILE: drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_color.c:843:
+ res = mod_color_calculate_degamma_params(caps, func, gamma, gamma != NULL);
-:841: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #841: FILE: drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_color.c:964:
+static void __drm_3dlut32_to_dc_3dlut(const struct drm_color_lut32 *lut,
+ uint32_t lut3d_size,
-:841: CHECK:PREFER_KERNEL_TYPES: Prefer kernel type 'u32' over 'uint32_t' #841: FILE: drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_color.c:964:
+ uint32_t lut3d_size,
-:852: CHECK:LINE_SPACING: Please don't use multiple blank lines #852: FILE: drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_color.c:975:
+
+
-:893: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #893: FILE: drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_color.c:1466:
+__set_colorop_in_tf_1d_curve(struct dc_plane_state *dc_plane_state,
+ struct drm_colorop_state *colorop_state)
-:973: CHECK:SPACING: No space is necessary after a cast #973: FILE: drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_color.c:1546:
+ ctm = blob ? (struct drm_color_ctm_3x4 *) blob->data : NULL;
-:1029: CHECK:PREFER_KERNEL_TYPES: Prefer kernel type 'u32' over 'uint32_t' #1029: FILE: drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_color.c:1602:
+ uint32_t shaper_size;
-:1045: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided #1045: FILE: drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_color.c:1618:
+ tf->tf = default_tf = amdgpu_colorop_tf_to_dc_tf(colorop_state->curve_1d_type);
-:1075: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "shaper_lut" #1075: FILE: drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_color.c:1648:
+ shaper_size = shaper_lut != NULL ? shaper_size : 0;
-:1104: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #1104: FILE: drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_color.c:1677:
+static int __set_colorop_3dlut(const struct drm_color_lut32 *drm_lut3d,
+ uint32_t drm_lut3d_size,
-:1104: CHECK:PREFER_KERNEL_TYPES: Prefer kernel type 'u32' over 'uint32_t' #1104: FILE: drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_color.c:1677:
+ uint32_t drm_lut3d_size,
-:1118: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #1118: FILE: drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_color.c:1691:
+ __drm_3dlut32_to_dc_3dlut(drm_lut3d, drm_lut3d_size, &lut->lut_3d,
+ lut->lut_3d.use_tetrahedral_9, 12);
-:1135: CHECK:PREFER_KERNEL_TYPES: Prefer kernel type 'u32' over 'uint32_t' #1135: FILE: drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_color.c:1708:
+ uint32_t lut3d_size;
-:1156: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "lut3d" #1156: FILE: drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_color.c:1729:
+ lut3d_size = lut3d != NULL ? lut3d_size : 0;
-:1190: CHECK:PREFER_KERNEL_TYPES: Prefer kernel type 'u32' over 'uint32_t' #1190: FILE: drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_color.c:1763:
+ uint32_t blend_size;
-:1207: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided #1207: FILE: drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_color.c:1780:
+ tf->tf = default_tf = amdgpu_colorop_tf_to_dc_tf(colorop_state->curve_1d_type);
-:1235: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "blend_lut" #1235: FILE: drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_color.c:1808:
+ blend_size = blend_lut != NULL ? blend_size : 0;
-:1254: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #1254: FILE: drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_color.c:1870:
+amdgpu_dm_plane_set_colorop_properties(struct drm_plane_state *plane_state,
+ struct dc_plane_state *dc_plane_state)
-:1425: CHECK:ALLOC_SIZEOF_STRUCT: Prefer kzalloc(sizeof(*ops[i])...) over kzalloc(sizeof(struct drm_colorop)...) #1425: FILE: drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_colorop.c:69:
+ ops[i] = kzalloc(sizeof(struct drm_colorop), GFP_KERNEL);
-:1443: CHECK:ALLOC_SIZEOF_STRUCT: Prefer kzalloc(sizeof(*ops[i])...) over kzalloc(sizeof(struct drm_colorop)...) #1443: FILE: drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_colorop.c:87:
+ ops[i] = kzalloc(sizeof(struct drm_colorop), GFP_KERNEL);
-:1453: CHECK:SPACING: spaces preferred around that '-' (ctx:VxV) #1453: FILE: drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_colorop.c:97:
+ drm_colorop_set_next_property(ops[i-1], ops[i]);
^
-:1458: CHECK:ALLOC_SIZEOF_STRUCT: Prefer kzalloc(sizeof(*ops[i])...) over kzalloc(sizeof(struct drm_colorop)...) #1458: FILE: drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_colorop.c:102:
+ ops[i] = kzalloc(sizeof(struct drm_colorop), GFP_KERNEL);
-:1468: CHECK:SPACING: spaces preferred around that '-' (ctx:VxV) #1468: FILE: drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_colorop.c:112:
+ drm_colorop_set_next_property(ops[i-1], ops[i]);
^
-:1474: CHECK:ALLOC_SIZEOF_STRUCT: Prefer kzalloc(sizeof(*ops[i])...) over kzalloc(sizeof(struct drm_colorop)...) #1474: FILE: drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_colorop.c:118:
+ ops[i] = kzalloc(sizeof(struct drm_colorop), GFP_KERNEL);
-:1481: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #1481: FILE: drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_colorop.c:125:
+ ret = drm_plane_colorop_curve_1d_init(dev, ops[i], plane,
+ amdgpu_dm_supported_shaper_tfs,
-:1486: CHECK:SPACING: spaces preferred around that '-' (ctx:VxV) #1486: FILE: drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_colorop.c:130:
+ drm_colorop_set_next_property(ops[i-1], ops[i]);
^
-:1491: CHECK:ALLOC_SIZEOF_STRUCT: Prefer kzalloc(sizeof(*ops[i])...) over kzalloc(sizeof(struct drm_colorop)...) #1491: FILE: drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_colorop.c:135:
+ ops[i] = kzalloc(sizeof(struct drm_colorop), GFP_KERNEL);
-:1498: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #1498: FILE: drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_colorop.c:142:
+ ret = drm_plane_colorop_curve_1d_lut_init(dev, ops[i], plane, MAX_COLOR_LUT_ENTRIES,
+ DRM_COLOROP_LUT1D_INTERPOLATION_LINEAR,
-:1503: CHECK:SPACING: spaces preferred around that '-' (ctx:VxV) #1503: FILE: drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_colorop.c:147:
+ drm_colorop_set_next_property(ops[i-1], ops[i]);
^
-:1508: CHECK:ALLOC_SIZEOF_STRUCT: Prefer kzalloc(sizeof(*ops[i])...) over kzalloc(sizeof(struct drm_colorop)...) #1508: FILE: drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_colorop.c:152:
+ ops[i] = kzalloc(sizeof(struct drm_colorop), GFP_KERNEL);
-:1515: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #1515: FILE: drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_colorop.c:159:
+ ret = drm_plane_colorop_3dlut_init(dev, ops[i], plane, LUT3D_SIZE,
+ DRM_COLOROP_LUT3D_INTERPOLATION_TETRAHEDRAL,
-:1520: CHECK:SPACING: spaces preferred around that '-' (ctx:VxV) #1520: FILE: drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_colorop.c:164:
+ drm_colorop_set_next_property(ops[i-1], ops[i]);
^
-:1525: CHECK:ALLOC_SIZEOF_STRUCT: Prefer kzalloc(sizeof(*ops[i])...) over kzalloc(sizeof(struct drm_colorop)...) #1525: FILE: drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_colorop.c:169:
+ ops[i] = kzalloc(sizeof(struct drm_colorop), GFP_KERNEL);
-:1537: CHECK:SPACING: spaces preferred around that '-' (ctx:VxV) #1537: FILE: drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_colorop.c:181:
+ drm_colorop_set_next_property(ops[i-1], ops[i]);
^
-:1542: CHECK:ALLOC_SIZEOF_STRUCT: Prefer kzalloc(sizeof(*ops[i])...) over kzalloc(sizeof(struct drm_colorop)...) #1542: FILE: drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_colorop.c:186:
+ ops[i] = kzalloc(sizeof(struct drm_colorop), GFP_KERNEL);
-:1554: CHECK:SPACING: spaces preferred around that '-' (ctx:VxV) #1554: FILE: drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_colorop.c:198:
+ drm_colorop_set_next_property(ops[i-1], ops[i]);
^
-:1687: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around pipelines[len] #1687: FILE: drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c:1805:
+ ret = amdgpu_dm_initialize_default_pipeline(plane, &(pipelines[len]));
-:1773: CHECK:LINE_SPACING: Please don't use multiple blank lines #1773: FILE: drivers/gpu/drm/drm_atomic.c:595:
+
-:1830: CHECK:LINE_SPACING: Please don't use multiple blank lines #1830: FILE: drivers/gpu/drm/drm_atomic.c:784:
+
-:1833: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #1833: FILE: drivers/gpu/drm/drm_atomic.c:787:
+static void drm_atomic_colorop_print_state(struct drm_printer *p,
+ const struct drm_colorop_state *state)
-:2023: CHECK:LINE_SPACING: Please don't use multiple blank lines #2023: FILE: drivers/gpu/drm/drm_atomic_uapi.c:261:
+
-:2052: CHECK:LINE_SPACING: Please don't use multiple blank lines #2052: FILE: drivers/gpu/drm/drm_atomic_uapi.c:290:
+
+
-:2120: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #2120: FILE: drivers/gpu/drm/drm_atomic_uapi.c:728:
+static int drm_atomic_colorop_set_property(struct drm_colorop *colorop,
+ struct drm_colorop_state *state, struct drm_file *file_priv,
-:2149: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #2149: FILE: drivers/gpu/drm/drm_atomic_uapi.c:757:
+drm_atomic_colorop_get_property(struct drm_colorop *colorop,
+ const struct drm_colorop_state *state,
-:2152: WARNING:BRACES: braces {} are not necessary for any arm of this statement #2152: FILE: drivers/gpu/drm/drm_atomic_uapi.c:760:
+ if (property == colorop->type_property) {
[...]
+ } else if (property == colorop->bypass_property) {
[...]
+ } else if (property == colorop->lut1d_interpolation_property) {
[...]
+ } else if (property == colorop->curve_1d_type_property) {
[...]
+ } else if (property == colorop->multiplier_property) {
[...]
+ } else if (property == colorop->size_property) {
[...]
+ } else if (property == colorop->lut3d_interpolation_property) {
[...]
+ } else if (property == colorop->data_property) {
[...]
+ } else {
[...]
-:2189: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #2189: FILE: drivers/gpu/drm/drm_atomic_uapi.c:1056:
+ ret = drm_atomic_colorop_get_property(colorop,
+ colorop->state, property, val);
-:2213: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #2213: FILE: drivers/gpu/drm/drm_atomic_uapi.c:1270:
+ ret = drm_atomic_colorop_set_property(colorop,
+ colorop_state, file_priv,
-:2370: CHECK:LINE_SPACING: Please don't use multiple blank lines #2370: FILE: drivers/gpu/drm/drm_colorop.c:88:
+
+
-:2378: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #2378: FILE: drivers/gpu/drm/drm_colorop.c:96:
+static int drm_plane_colorop_init(struct drm_device *dev, struct drm_colorop *colorop,
+ struct drm_plane *plane, enum drm_colorop_type type, uint32_t flags)
-:2423: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #2423: FILE: drivers/gpu/drm/drm_colorop.c:141:
+ drm_object_attach_property(&colorop->base,
+ colorop->bypass_property,
-:2532: CHECK:LINE_SPACING: Please don't use multiple blank lines #2532: FILE: drivers/gpu/drm/drm_colorop.c:250:
+
+
-:2580: WARNING:LONG_LINE: line length of 102 exceeds 100 columns #2580: FILE: drivers/gpu/drm/drm_colorop.c:298:
+ enum drm_colorop_lut1d_interpolation_type lut1d_interpolation,
-:2676: CHECK:PREFER_KERNEL_TYPES: Prefer kernel type 'u32' over 'uint32_t' #2676: FILE: drivers/gpu/drm/drm_colorop.c:394:
+ uint32_t lut_size,
-:2745: CHECK:LINE_SPACING: Please don't use multiple blank lines #2745: FILE: drivers/gpu/drm/drm_colorop.c:463:
+
+
-:2770: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #2770: FILE: drivers/gpu/drm/drm_colorop.c:488:
+ drm_object_property_get_default_value(&colorop->base,
+ colorop->curve_1d_type_property,
-:3508: CHECK:LINE_SPACING: Please don't use multiple blank lines #3508: FILE: drivers/gpu/drm/vkms/tests/vkms_color_test.c:302:
+
+
-:3583: CHECK:LINE_SPACING: Please don't use multiple blank lines #3583: FILE: drivers/gpu/drm/vkms/tests/vkms_color_test.c:377:
+
+
-:3603: CHECK:BRACES: Blank lines aren't necessary before a close brace '}' #3603: FILE: drivers/gpu/drm/vkms/tests/vkms_color_test.c:397:
+
+}
-:3658: WARNING:OOM_MESSAGE: Possible unnecessary 'out of memory' message #3658: FILE: drivers/gpu/drm/vkms/vkms_colorop.c:29:
+ if (!ops[i]) {
+ drm_err(dev, "KMS: Failed to allocate colorop\n");
-:3676: WARNING:OOM_MESSAGE: Possible unnecessary 'out of memory' message #3676: FILE: drivers/gpu/drm/vkms/vkms_colorop.c:47:
+ if (!ops[i]) {
+ drm_err(dev, "KMS: Failed to allocate colorop\n");
-:3692: WARNING:OOM_MESSAGE: Possible unnecessary 'out of memory' message #3692: FILE: drivers/gpu/drm/vkms/vkms_colorop.c:63:
+ if (!ops[i]) {
+ drm_err(dev, "KMS: Failed to allocate colorop\n");
-:3708: WARNING:OOM_MESSAGE: Possible unnecessary 'out of memory' message #3708: FILE: drivers/gpu/drm/vkms/vkms_colorop.c:79:
+ if (!ops[i]) {
+ drm_err(dev, "KMS: Failed to allocate colorop\n");
-:3878: CHECK:SPACING: No space is necessary after a cast #3878: FILE: drivers/gpu/drm/vkms/vkms_composer.c:188:
+ (struct drm_color_ctm_3x4 *) colorop_state->data->data);
-:4943: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #4943: FILE: include/drm/drm_atomic.h:816:
+drm_atomic_get_old_colorop_state(struct drm_atomic_state *state,
+ struct drm_colorop *colorop)
-:4958: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #4958: FILE: include/drm/drm_atomic.h:831:
+drm_atomic_get_new_colorop_state(struct drm_atomic_state *state,
+ struct drm_colorop *colorop)
-:4992: WARNING:LONG_LINE: line length of 103 exceeds 100 columns
#4992: FILE: include/drm/drm_atomic.h:1081:
+#define for_each_oldnew_colorop_in_state(__state, colorop, old_colorop_state, new_colorop_state, __i) \
-:4992: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #4992: FILE: include/drm/drm_atomic.h:1081:
+#define for_each_oldnew_colorop_in_state(__state, colorop, old_colorop_state, new_colorop_state, __i) \
+ for ((__i) = 0; \
+ (__i) < (__state)->dev->mode_config.num_colorop; \
+ (__i)++) \
+ for_each_if ((__state)->colorops[__i].ptr && \
+ ((colorop) = (__state)->colorops[__i].ptr, \
+ (void)(colorop) /* Only to avoid unused-but-set-variable warning */, \ + (old_colorop_state) = (__state)->colorops[__i].old_state,\ + (new_colorop_state) = (__state)->colorops[__i].new_state, 1))
BUT SEE:
do {} while (0) advice is over-stated in a few situations:
The more obvious case is macros, like MODULE_PARM_DESC, invoked at file-scope, where C disallows code (it must be in functions). See $exceptions if you have one to add by name.
More troublesome is declarative macros used at top of new scope, like DECLARE_PER_CPU. These might just compile with a do-while-0 wrapper, but would be incorrect. Most of these are handled by detecting struct,union,etc declaration primitives in $exceptions.
Theres also macros called inside an if (block), which "return" an expression. These cannot do-while, and need a ({}) wrapper.
Enjoy this qualification while we work to improve our heuristics.
-:4992: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__state' - possible side-effects? #4992: FILE: include/drm/drm_atomic.h:1081:
+#define for_each_oldnew_colorop_in_state(__state, colorop, old_colorop_state, new_colorop_state, __i) \
+ for ((__i) = 0; \
+ (__i) < (__state)->dev->mode_config.num_colorop; \
+ (__i)++) \
+ for_each_if ((__state)->colorops[__i].ptr && \
+ ((colorop) = (__state)->colorops[__i].ptr, \
+ (void)(colorop) /* Only to avoid unused-but-set-variable warning */, \ + (old_colorop_state) = (__state)->colorops[__i].old_state,\ + (new_colorop_state) = (__state)->colorops[__i].new_state, 1))
-:4992: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'colorop' - possible side-effects? #4992: FILE: include/drm/drm_atomic.h:1081:
+#define for_each_oldnew_colorop_in_state(__state, colorop, old_colorop_state, new_colorop_state, __i) \
+ for ((__i) = 0; \
+ (__i) < (__state)->dev->mode_config.num_colorop; \
+ (__i)++) \
+ for_each_if ((__state)->colorops[__i].ptr && \
+ ((colorop) = (__state)->colorops[__i].ptr, \
+ (void)(colorop) /* Only to avoid unused-but-set-variable warning */, \ + (old_colorop_state) = (__state)->colorops[__i].old_state,\ + (new_colorop_state) = (__state)->colorops[__i].new_state, 1))
-:4992: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__i' - possible side-effects? #4992: FILE: include/drm/drm_atomic.h:1081:
+#define for_each_oldnew_colorop_in_state(__state, colorop, old_colorop_state, new_colorop_state, __i) \
+ for ((__i) = 0; \
+ (__i) < (__state)->dev->mode_config.num_colorop; \
+ (__i)++) \
+ for_each_if ((__state)->colorops[__i].ptr && \
+ ((colorop) = (__state)->colorops[__i].ptr, \
+ (void)(colorop) /* Only to avoid unused-but-set-variable warning */, \ + (old_colorop_state) = (__state)->colorops[__i].old_state,\ + (new_colorop_state) = (__state)->colorops[__i].new_state, 1))
-:4996: WARNING:SPACING: space prohibited between function name and open parenthesis '(' #4996: FILE: include/drm/drm_atomic.h:1085:
+ for_each_if ((__state)->colorops[__i].ptr && \
-:5002: CHECK:LINE_SPACING: Please don't use multiple blank lines #5002: FILE: include/drm/drm_atomic.h:1091:
+
+
-:5014: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #5014: FILE: include/drm/drm_atomic.h:1103:
+#define for_each_new_colorop_in_state(__state, colorop, new_colorop_state, __i) \
+ for ((__i) = 0; \
+ (__i) < (__state)->dev->mode_config.num_colorop; \
+ (__i)++) \
+ for_each_if ((__state)->colorops[__i].ptr && \
+ ((colorop) = (__state)->colorops[__i].ptr, \
+ (void)(colorop) /* Only to avoid unused-but-set-variable warning */, \
+ (new_colorop_state) = (__state)->colorops[__i].new_state, 1))
BUT SEE:
do {} while (0) advice is over-stated in a few situations:
The more obvious case is macros, like MODULE_PARM_DESC, invoked at file-scope, where C disallows code (it must be in functions). See $exceptions if you have one to add by name.
More troublesome is declarative macros used at top of new scope, like DECLARE_PER_CPU. These might just compile with a do-while-0 wrapper, but would be incorrect. Most of these are handled by detecting struct,union,etc declaration primitives in $exceptions.
Theres also macros called inside an if (block), which "return" an expression. These cannot do-while, and need a ({}) wrapper.
Enjoy this qualification while we work to improve our heuristics.
-:5014: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__state' - possible side-effects? #5014: FILE: include/drm/drm_atomic.h:1103:
+#define for_each_new_colorop_in_state(__state, colorop, new_colorop_state, __i) \
+ for ((__i) = 0; \
+ (__i) < (__state)->dev->mode_config.num_colorop; \
+ (__i)++) \
+ for_each_if ((__state)->colorops[__i].ptr && \
+ ((colorop) = (__state)->colorops[__i].ptr, \
+ (void)(colorop) /* Only to avoid unused-but-set-variable warning */, \
+ (new_colorop_state) = (__state)->colorops[__i].new_state, 1))
-:5014: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'colorop' - possible side-effects? #5014: FILE: include/drm/drm_atomic.h:1103:
+#define for_each_new_colorop_in_state(__state, colorop, new_colorop_state, __i) \
+ for ((__i) = 0; \
+ (__i) < (__state)->dev->mode_config.num_colorop; \
+ (__i)++) \
+ for_each_if ((__state)->colorops[__i].ptr && \
+ ((colorop) = (__state)->colorops[__i].ptr, \
+ (void)(colorop) /* Only to avoid unused-but-set-variable warning */, \
+ (new_colorop_state) = (__state)->colorops[__i].new_state, 1))
-:5014: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__i' - possible side-effects? #5014: FILE: include/drm/drm_atomic.h:1103:
+#define for_each_new_colorop_in_state(__state, colorop, new_colorop_state, __i) \
+ for ((__i) = 0; \
+ (__i) < (__state)->dev->mode_config.num_colorop; \
+ (__i)++) \
+ for_each_if ((__state)->colorops[__i].ptr && \
+ ((colorop) = (__state)->colorops[__i].ptr, \
+ (void)(colorop) /* Only to avoid unused-but-set-variable warning */, \
+ (new_colorop_state) = (__state)->colorops[__i].new_state, 1))
-:5018: WARNING:SPACING: space prohibited between function name and open parenthesis '(' #5018: FILE: include/drm/drm_atomic.h:1107:
+ for_each_if ((__state)->colorops[__i].ptr && \
-:5139: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV) #5139: FILE: include/drm/drm_colorop.h:35:
+#define DRM_COLOROP_FLAG_ALLOW_BYPASS (1<<0) /* Allow bypass on the drm_colorop */
^
-:5256: CHECK:LINE_SPACING: Please don't use multiple blank lines #5256: FILE: include/drm/drm_colorop.h:152:
+
+
-:5278: CHECK:PREFER_KERNEL_TYPES: Prefer kernel type 'u64' over 'uint64_t' #5278: FILE: include/drm/drm_colorop.h:174:
+ uint64_t multiplier;
-:5399: CHECK:PREFER_KERNEL_TYPES: Prefer kernel type 'u32' over 'uint32_t' #5399: FILE: include/drm/drm_colorop.h:295:
+ uint32_t size;
-:5485: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #5485: FILE: include/drm/drm_colorop.h:381:
+static inline struct drm_colorop *drm_colorop_find(struct drm_device *dev,
+ struct drm_file *file_priv,
-:5501: WARNING:LONG_LINE: line length of 102 exceeds 100 columns #5501: FILE: include/drm/drm_colorop.h:397:
+ enum drm_colorop_lut1d_interpolation_type lut1d_interpolation,
-:5509: CHECK:PREFER_KERNEL_TYPES: Prefer kernel type 'u32' over 'uint32_t' #5509: FILE: include/drm/drm_colorop.h:405:
+ uint32_t lut_size,
-:5540: CHECK:LINE_SPACING: Please don't use multiple blank lines #5540: FILE: include/drm/drm_colorop.h:436:
+
+
-:5561: WARNING:LONG_LINE: line length of 101 exceeds 100 columns
#5561: FILE: include/drm/drm_colorop.h:457:
+const char *drm_get_colorop_lut1d_interpolation_name(enum drm_colorop_lut1d_interpolation_type type);
-:5562: WARNING:LONG_LINE: line length of 101 exceeds 100 columns
#5562: FILE: include/drm/drm_colorop.h:458:
+const char *drm_get_colorop_lut3d_interpolation_name(enum drm_colorop_lut3d_interpolation_type type);
-:5609: CHECK:BRACES: Blank lines aren't necessary before a close brace '}' #5609: FILE: include/drm/drm_fixed.h:97:
+
+}
total: 2 errors, 13 warnings, 77 checks, 5563 lines checkedb9c4d876b7f2 drm/i915: Add identifiers for driver specific blocksf1258d799e26 drm/i915: Add intel_color_op
-:30: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #30:
new file mode 100644
total: 0 errors, 1 warnings, 0 checks, 48 lines checkedc12445dec322 drm/i915/color: Add helper to create intel coloropcbeeee9c9814 drm/i915/color: Create a transfer function color pipeline
-:37: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #37:
new file mode 100644
total: 0 errors, 1 warnings, 0 checks, 128 lines checked a0e1467ca506 drm/i915/color: Add framework to program CSC 61aff75af281 drm/i915/color: Preserve sign bit when int_bits is Zero f29c19f4847b drm/i915/color: Add plane CTM callback for D12 and beyond 4897859a825a drm/i915: Add register definitions for Plane Degamma -:40: ERROR:CODE_INDENT: code indent should use tabs where possible #40: FILE: drivers/gpu/drm/i915/display/skl_universal_plane_regs.h:302:
+ _PLANE_PRE_CSC_GAMC_INDEX_ENH_1_B)$
-:40: WARNING:LEADING_SPACE: please, no spaces at the start of a line #40: FILE: drivers/gpu/drm/i915/display/skl_universal_plane_regs.h:302:
+ _PLANE_PRE_CSC_GAMC_INDEX_ENH_1_B)$
-:42: ERROR:CODE_INDENT: code indent should use tabs where possible #42: FILE: drivers/gpu/drm/i915/display/skl_universal_plane_regs.h:304:
+ _PLANE_PRE_CSC_GAMC_INDEX_ENH_2_B)$
-:42: WARNING:LEADING_SPACE: please, no spaces at the start of a line #42: FILE: drivers/gpu/drm/i915/display/skl_universal_plane_regs.h:304:
+ _PLANE_PRE_CSC_GAMC_INDEX_ENH_2_B)$
-:43: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pipe' - possible side-effects? #43: FILE: drivers/gpu/drm/i915/display/skl_universal_plane_regs.h:305:
+#define PLANE_PRE_CSC_GAMC_INDEX_ENH(pipe, plane, i) \
+ _MMIO_PLANE_GAMC(plane, i, _PLANE_PRE_CSC_GAMC_INDEX_ENH_1(pipe), \
+ _PLANE_PRE_CSC_GAMC_INDEX_ENH_2(pipe))
-:44: ERROR:CODE_INDENT: code indent should use tabs where possible #44: FILE: drivers/gpu/drm/i915/display/skl_universal_plane_regs.h:306:
+ _MMIO_PLANE_GAMC(plane, i, _PLANE_PRE_CSC_GAMC_INDEX_ENH_1(pipe), \$
-:44: WARNING:LEADING_SPACE: please, no spaces at the start of a line #44: FILE: drivers/gpu/drm/i915/display/skl_universal_plane_regs.h:306:
+ _MMIO_PLANE_GAMC(plane, i, _PLANE_PRE_CSC_GAMC_INDEX_ENH_1(pipe), \$
-:45: ERROR:CODE_INDENT: code indent should use tabs where possible #45: FILE: drivers/gpu/drm/i915/display/skl_universal_plane_regs.h:307:
+ _PLANE_PRE_CSC_GAMC_INDEX_ENH_2(pipe))$
-:45: WARNING:LEADING_SPACE: please, no spaces at the start of a line #45: FILE: drivers/gpu/drm/i915/display/skl_universal_plane_regs.h:307:
+ _PLANE_PRE_CSC_GAMC_INDEX_ENH_2(pipe))$
-:53: ERROR:CODE_INDENT: code indent should use tabs where possible #53: FILE: drivers/gpu/drm/i915/display/skl_universal_plane_regs.h:315:
+ _PLANE_PRE_CSC_GAMC_DATA_ENH_1_B)$
-:53: WARNING:LEADING_SPACE: please, no spaces at the start of a line #53: FILE: drivers/gpu/drm/i915/display/skl_universal_plane_regs.h:315:
+ _PLANE_PRE_CSC_GAMC_DATA_ENH_1_B)$
-:55: ERROR:CODE_INDENT: code indent should use tabs where possible #55: FILE: drivers/gpu/drm/i915/display/skl_universal_plane_regs.h:317:
+ _PLANE_PRE_CSC_GAMC_DATA_ENH_2_B)$
-:55: WARNING:LEADING_SPACE: please, no spaces at the start of a line #55: FILE: drivers/gpu/drm/i915/display/skl_universal_plane_regs.h:317:
+ _PLANE_PRE_CSC_GAMC_DATA_ENH_2_B)$
-:56: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pipe' - possible side-effects? #56: FILE: drivers/gpu/drm/i915/display/skl_universal_plane_regs.h:318:
+#define PLANE_PRE_CSC_GAMC_DATA_ENH(pipe, plane, i) \
+ _MMIO_PLANE_GAMC(plane, i, _PLANE_PRE_CSC_GAMC_DATA_ENH_1(pipe), \
+ _PLANE_PRE_CSC_GAMC_DATA_ENH_2(pipe))
-:57: ERROR:CODE_INDENT: code indent should use tabs where possible #57: FILE: drivers/gpu/drm/i915/display/skl_universal_plane_regs.h:319:
+ _MMIO_PLANE_GAMC(plane, i, _PLANE_PRE_CSC_GAMC_DATA_ENH_1(pipe), \$
-:57: WARNING:LEADING_SPACE: please, no spaces at the start of a line #57: FILE: drivers/gpu/drm/i915/display/skl_universal_plane_regs.h:319:
+ _MMIO_PLANE_GAMC(plane, i, _PLANE_PRE_CSC_GAMC_DATA_ENH_1(pipe), \$
-:58: ERROR:CODE_INDENT: code indent should use tabs where possible #58: FILE: drivers/gpu/drm/i915/display/skl_universal_plane_regs.h:320:
+ _PLANE_PRE_CSC_GAMC_DATA_ENH_2(pipe))$
-:58: WARNING:LEADING_SPACE: please, no spaces at the start of a line #58: FILE: drivers/gpu/drm/i915/display/skl_universal_plane_regs.h:320:
+ _PLANE_PRE_CSC_GAMC_DATA_ENH_2(pipe))$
-:65: ERROR:CODE_INDENT: code indent should use tabs where possible #65: FILE: drivers/gpu/drm/i915/display/skl_universal_plane_regs.h:327:
+ _PLANE_PRE_CSC_GAMC_INDEX_1_B)$
-:65: WARNING:LEADING_SPACE: please, no spaces at the start of a line #65: FILE: drivers/gpu/drm/i915/display/skl_universal_plane_regs.h:327:
+ _PLANE_PRE_CSC_GAMC_INDEX_1_B)$
-:67: ERROR:CODE_INDENT: code indent should use tabs where possible #67: FILE: drivers/gpu/drm/i915/display/skl_universal_plane_regs.h:329:
+ _PLANE_PRE_CSC_GAMC_INDEX_2_B)$
-:67: WARNING:LEADING_SPACE: please, no spaces at the start of a line #67: FILE: drivers/gpu/drm/i915/display/skl_universal_plane_regs.h:329:
+ _PLANE_PRE_CSC_GAMC_INDEX_2_B)$
-:68: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pipe' - possible side-effects? #68: FILE: drivers/gpu/drm/i915/display/skl_universal_plane_regs.h:330:
+#define PLANE_PRE_CSC_GAMC_INDEX(pipe, plane, i) \
+ _MMIO_PLANE_GAMC(plane, i, _PLANE_PRE_CSC_GAMC_INDEX_1(pipe), \
+ _PLANE_PRE_CSC_GAMC_INDEX_2(pipe))
-:69: ERROR:CODE_INDENT: code indent should use tabs where possible #69: FILE: drivers/gpu/drm/i915/display/skl_universal_plane_regs.h:331:
+ _MMIO_PLANE_GAMC(plane, i, _PLANE_PRE_CSC_GAMC_INDEX_1(pipe), \$
-:69: WARNING:LEADING_SPACE: please, no spaces at the start of a line #69: FILE: drivers/gpu/drm/i915/display/skl_universal_plane_regs.h:331:
+ _MMIO_PLANE_GAMC(plane, i, _PLANE_PRE_CSC_GAMC_INDEX_1(pipe), \$
-:70: ERROR:CODE_INDENT: code indent should use tabs where possible #70: FILE: drivers/gpu/drm/i915/display/skl_universal_plane_regs.h:332:
+ _PLANE_PRE_CSC_GAMC_INDEX_2(pipe))$
-:70: WARNING:LEADING_SPACE: please, no spaces at the start of a line #70: FILE: drivers/gpu/drm/i915/display/skl_universal_plane_regs.h:332:
+ _PLANE_PRE_CSC_GAMC_INDEX_2(pipe))$
-:77: ERROR:CODE_INDENT: code indent should use tabs where possible #77: FILE: drivers/gpu/drm/i915/display/skl_universal_plane_regs.h:339:
+ _PLANE_PRE_CSC_GAMC_DATA_1_B)$
-:77: WARNING:LEADING_SPACE: please, no spaces at the start of a line #77: FILE: drivers/gpu/drm/i915/display/skl_universal_plane_regs.h:339:
+ _PLANE_PRE_CSC_GAMC_DATA_1_B)$
-:79: ERROR:CODE_INDENT: code indent should use tabs where possible #79: FILE: drivers/gpu/drm/i915/display/skl_universal_plane_regs.h:341:
+ _PLANE_PRE_CSC_GAMC_DATA_2_B)$
-:79: WARNING:LEADING_SPACE: please, no spaces at the start of a line #79: FILE: drivers/gpu/drm/i915/display/skl_universal_plane_regs.h:341:
+ _PLANE_PRE_CSC_GAMC_DATA_2_B)$
-:80: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pipe' - possible side-effects? #80: FILE: drivers/gpu/drm/i915/display/skl_universal_plane_regs.h:342:
+#define PLANE_PRE_CSC_GAMC_DATA(pipe, plane, i) \
+ _MMIO_PLANE_GAMC(plane, i, _PLANE_PRE_CSC_GAMC_DATA_1(pipe), \
+ _PLANE_PRE_CSC_GAMC_DATA_2(pipe))
-:81: ERROR:CODE_INDENT: code indent should use tabs where possible #81: FILE: drivers/gpu/drm/i915/display/skl_universal_plane_regs.h:343:
+ _MMIO_PLANE_GAMC(plane, i, _PLANE_PRE_CSC_GAMC_DATA_1(pipe), \$
-:81: WARNING:LEADING_SPACE: please, no spaces at the start of a line #81: FILE: drivers/gpu/drm/i915/display/skl_universal_plane_regs.h:343:
+ _MMIO_PLANE_GAMC(plane, i, _PLANE_PRE_CSC_GAMC_DATA_1(pipe), \$
-:82: ERROR:CODE_INDENT: code indent should use tabs where possible #82: FILE: drivers/gpu/drm/i915/display/skl_universal_plane_regs.h:344:
+ _PLANE_PRE_CSC_GAMC_DATA_2(pipe))$
-:82: WARNING:LEADING_SPACE: please, no spaces at the start of a line #82: FILE: drivers/gpu/drm/i915/display/skl_universal_plane_regs.h:344:
+ _PLANE_PRE_CSC_GAMC_DATA_2(pipe))$
total: 16 errors, 16 warnings, 4 checks, 65 lines checked f491f862b0ad drm/i915/color: Add framework to program PRE/POST CSC LUT 41a5e4fc9570 drm/i915: Add register definitions for Plane Post CSC -:38: WARNING:LONG_LINE: line length of 109 exceeds 100 columns #38: FILE: drivers/gpu/drm/i915/display/skl_universal_plane_regs.h:302:
+#define _PLANE_POST_CSC_GAMC_SEG0_INDEX_ENH_1(pipe) _PIPE(pipe, _PLANE_POST_CSC_GAMC_SEG0_INDEX_ENH_1_A, \
-:39: ERROR:CODE_INDENT: code indent should use tabs where possible #39: FILE: drivers/gpu/drm/i915/display/skl_universal_plane_regs.h:303:
+ _PLANE_POST_CSC_GAMC_SEG0_INDEX_ENH_1_B)$
-:39: WARNING:LEADING_SPACE: please, no spaces at the start of a line #39: FILE: drivers/gpu/drm/i915/display/skl_universal_plane_regs.h:303:
+ _PLANE_POST_CSC_GAMC_SEG0_INDEX_ENH_1_B)$
-:40: WARNING:LONG_LINE: line length of 109 exceeds 100 columns #40: FILE: drivers/gpu/drm/i915/display/skl_universal_plane_regs.h:304:
+#define _PLANE_POST_CSC_GAMC_SEG0_INDEX_ENH_2(pipe) _PIPE(pipe, _PLANE_POST_CSC_GAMC_SEG0_INDEX_ENH_2_A, \
-:41: ERROR:CODE_INDENT: code indent should use tabs where possible #41: FILE: drivers/gpu/drm/i915/display/skl_universal_plane_regs.h:305:
+ _PLANE_POST_CSC_GAMC_SEG0_INDEX_ENH_2_B)$
-:41: WARNING:LEADING_SPACE: please, no spaces at the start of a line #41: FILE: drivers/gpu/drm/i915/display/skl_universal_plane_regs.h:305:
+ _PLANE_POST_CSC_GAMC_SEG0_INDEX_ENH_2_B)$
-:42: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pipe' - possible side-effects? #42: FILE: drivers/gpu/drm/i915/display/skl_universal_plane_regs.h:306:
+#define PLANE_POST_CSC_GAMC_SEG0_INDEX_ENH(pipe, plane, i) \
+ _MMIO_PLANE_GAMC(plane, i, _PLANE_POST_CSC_GAMC_SEG0_INDEX_ENH_1(pipe), \
+ _PLANE_POST_CSC_GAMC_SEG0_INDEX_ENH_2(pipe))
-:43: ERROR:CODE_INDENT: code indent should use tabs where possible #43: FILE: drivers/gpu/drm/i915/display/skl_universal_plane_regs.h:307:
+ _MMIO_PLANE_GAMC(plane, i, _PLANE_POST_CSC_GAMC_SEG0_INDEX_ENH_1(pipe), \$
-:43: WARNING:LEADING_SPACE: please, no spaces at the start of a line #43: FILE: drivers/gpu/drm/i915/display/skl_universal_plane_regs.h:307:
+ _MMIO_PLANE_GAMC(plane, i, _PLANE_POST_CSC_GAMC_SEG0_INDEX_ENH_1(pipe), \$
-:44: ERROR:CODE_INDENT: code indent should use tabs where possible #44: FILE: drivers/gpu/drm/i915/display/skl_universal_plane_regs.h:308:
+ _PLANE_POST_CSC_GAMC_SEG0_INDEX_ENH_2(pipe))$
-:44: WARNING:LEADING_SPACE: please, no spaces at the start of a line #44: FILE: drivers/gpu/drm/i915/display/skl_universal_plane_regs.h:308:
+ _PLANE_POST_CSC_GAMC_SEG0_INDEX_ENH_2(pipe))$
-:50: WARNING:LONG_LINE: line length of 108 exceeds 100 columns #50: FILE: drivers/gpu/drm/i915/display/skl_universal_plane_regs.h:314:
+#define _PLANE_POST_CSC_GAMC_SEG0_DATA_ENH_1(pipe) _PIPE(pipe, _PLANE_POST_CSC_GAMC_SEG0_DATA_ENH_1_A, \
-:51: ERROR:CODE_INDENT: code indent should use tabs where possible #51: FILE: drivers/gpu/drm/i915/display/skl_universal_plane_regs.h:315:
+ _PLANE_POST_CSC_GAMC_SEG0_DATA_ENH_1_B)$
-:51: WARNING:LEADING_SPACE: please, no spaces at the start of a line #51: FILE: drivers/gpu/drm/i915/display/skl_universal_plane_regs.h:315:
+ _PLANE_POST_CSC_GAMC_SEG0_DATA_ENH_1_B)$
-:52: WARNING:LONG_LINE: line length of 108 exceeds 100 columns #52: FILE: drivers/gpu/drm/i915/display/skl_universal_plane_regs.h:316:
+#define _PLANE_POST_CSC_GAMC_SEG0_DATA_ENH_2(pipe) _PIPE(pipe, _PLANE_POST_CSC_GAMC_SEG0_DATA_ENH_2_A, \
-:53: ERROR:CODE_INDENT: code indent should use tabs where possible #53: FILE: drivers/gpu/drm/i915/display/skl_universal_plane_regs.h:317:
+ _PLANE_POST_CSC_GAMC_SEG0_DATA_ENH_2_B)$
-:53: WARNING:LEADING_SPACE: please, no spaces at the start of a line #53: FILE: drivers/gpu/drm/i915/display/skl_universal_plane_regs.h:317:
+ _PLANE_POST_CSC_GAMC_SEG0_DATA_ENH_2_B)$
-:54: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pipe' - possible side-effects? #54: FILE: drivers/gpu/drm/i915/display/skl_universal_plane_regs.h:318:
+#define PLANE_POST_CSC_GAMC_SEG0_DATA_ENH(pipe, plane, i) \
+ _MMIO_PLANE_GAMC(plane, i, _PLANE_POST_CSC_GAMC_SEG0_DATA_ENH_1(pipe), \
+ _PLANE_POST_CSC_GAMC_SEG0_DATA_ENH_2(pipe))
-:55: ERROR:CODE_INDENT: code indent should use tabs where possible #55: FILE: drivers/gpu/drm/i915/display/skl_universal_plane_regs.h:319:
+ _MMIO_PLANE_GAMC(plane, i, _PLANE_POST_CSC_GAMC_SEG0_DATA_ENH_1(pipe), \$
-:55: WARNING:LEADING_SPACE: please, no spaces at the start of a line #55: FILE: drivers/gpu/drm/i915/display/skl_universal_plane_regs.h:319:
+ _MMIO_PLANE_GAMC(plane, i, _PLANE_POST_CSC_GAMC_SEG0_DATA_ENH_1(pipe), \$
-:56: ERROR:CODE_INDENT: code indent should use tabs where possible #56: FILE: drivers/gpu/drm/i915/display/skl_universal_plane_regs.h:320:
+ _PLANE_POST_CSC_GAMC_SEG0_DATA_ENH_2(pipe))$
-:56: WARNING:LEADING_SPACE: please, no spaces at the start of a line #56: FILE: drivers/gpu/drm/i915/display/skl_universal_plane_regs.h:320:
+ _PLANE_POST_CSC_GAMC_SEG0_DATA_ENH_2(pipe))$
-:63: ERROR:CODE_INDENT: code indent should use tabs where possible #63: FILE: drivers/gpu/drm/i915/display/skl_universal_plane_regs.h:327:
+ _PLANE_POST_CSC_GAMC_INDEX_ENH_1_B)$
-:63: WARNING:LEADING_SPACE: please, no spaces at the start of a line #63: FILE: drivers/gpu/drm/i915/display/skl_universal_plane_regs.h:327:
+ _PLANE_POST_CSC_GAMC_INDEX_ENH_1_B)$
-:65: ERROR:CODE_INDENT: code indent should use tabs where possible #65: FILE: drivers/gpu/drm/i915/display/skl_universal_plane_regs.h:329:
+ _PLANE_POST_CSC_GAMC_INDEX_ENH_2_B)$
-:65: WARNING:LEADING_SPACE: please, no spaces at the start of a line #65: FILE: drivers/gpu/drm/i915/display/skl_universal_plane_regs.h:329:
+ _PLANE_POST_CSC_GAMC_INDEX_ENH_2_B)$
-:66: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pipe' - possible side-effects? #66: FILE: drivers/gpu/drm/i915/display/skl_universal_plane_regs.h:330:
+#define PLANE_POST_CSC_GAMC_INDEX_ENH(pipe, plane, i) \
+ _MMIO_PLANE_GAMC(plane, i, _PLANE_POST_CSC_GAMC_INDEX_ENH_1(pipe), \
+ _PLANE_POST_CSC_GAMC_INDEX_ENH_2(pipe))
-:67: ERROR:CODE_INDENT: code indent should use tabs where possible #67: FILE: drivers/gpu/drm/i915/display/skl_universal_plane_regs.h:331:
+ _MMIO_PLANE_GAMC(plane, i, _PLANE_POST_CSC_GAMC_INDEX_ENH_1(pipe), \$
-:67: WARNING:LEADING_SPACE: please, no spaces at the start of a line #67: FILE: drivers/gpu/drm/i915/display/skl_universal_plane_regs.h:331:
+ _MMIO_PLANE_GAMC(plane, i, _PLANE_POST_CSC_GAMC_INDEX_ENH_1(pipe), \$
-:68: ERROR:CODE_INDENT: code indent should use tabs where possible #68: FILE: drivers/gpu/drm/i915/display/skl_universal_plane_regs.h:332:
+ _PLANE_POST_CSC_GAMC_INDEX_ENH_2(pipe))$
-:68: WARNING:LEADING_SPACE: please, no spaces at the start of a line #68: FILE: drivers/gpu/drm/i915/display/skl_universal_plane_regs.h:332:
+ _PLANE_POST_CSC_GAMC_INDEX_ENH_2(pipe))$
-:75: ERROR:CODE_INDENT: code indent should use tabs where possible #75: FILE: drivers/gpu/drm/i915/display/skl_universal_plane_regs.h:339:
+ _PLANE_POST_CSC_GAMC_DATA_ENH_1_B)$
-:75: WARNING:LEADING_SPACE: please, no spaces at the start of a line #75: FILE: drivers/gpu/drm/i915/display/skl_universal_plane_regs.h:339:
+ _PLANE_POST_CSC_GAMC_DATA_ENH_1_B)$
-:77: ERROR:CODE_INDENT: code indent should use tabs where possible #77: FILE: drivers/gpu/drm/i915/display/skl_universal_plane_regs.h:341:
+ _PLANE_POST_CSC_GAMC_DATA_ENH_2_B)$
-:77: WARNING:LEADING_SPACE: please, no spaces at the start of a line #77: FILE: drivers/gpu/drm/i915/display/skl_universal_plane_regs.h:341:
+ _PLANE_POST_CSC_GAMC_DATA_ENH_2_B)$
-:78: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pipe' - possible side-effects? #78: FILE: drivers/gpu/drm/i915/display/skl_universal_plane_regs.h:342:
+#define PLANE_POST_CSC_GAMC_DATA_ENH(pipe, plane, i) \
+ _MMIO_PLANE_GAMC(plane, i, _PLANE_POST_CSC_GAMC_DATA_ENH_1(pipe), \
+ _PLANE_POST_CSC_GAMC_DATA_ENH_2(pipe))
-:79: ERROR:CODE_INDENT: code indent should use tabs where possible #79: FILE: drivers/gpu/drm/i915/display/skl_universal_plane_regs.h:343:
+ _MMIO_PLANE_GAMC(plane, i, _PLANE_POST_CSC_GAMC_DATA_ENH_1(pipe), \$
-:79: WARNING:LEADING_SPACE: please, no spaces at the start of a line #79: FILE: drivers/gpu/drm/i915/display/skl_universal_plane_regs.h:343:
+ _MMIO_PLANE_GAMC(plane, i, _PLANE_POST_CSC_GAMC_DATA_ENH_1(pipe), \$
-:80: ERROR:CODE_INDENT: code indent should use tabs where possible #80: FILE: drivers/gpu/drm/i915/display/skl_universal_plane_regs.h:344:
+ _PLANE_POST_CSC_GAMC_DATA_ENH_2(pipe))$
-:80: WARNING:LEADING_SPACE: please, no spaces at the start of a line #80: FILE: drivers/gpu/drm/i915/display/skl_universal_plane_regs.h:344:
+ _PLANE_POST_CSC_GAMC_DATA_ENH_2(pipe))$
-:87: ERROR:CODE_INDENT: code indent should use tabs where possible #87: FILE: drivers/gpu/drm/i915/display/skl_universal_plane_regs.h:351:
+ _PLANE_POST_CSC_GAMC_INDEX_1_B)$
-:87: WARNING:LEADING_SPACE: please, no spaces at the start of a line #87: FILE: drivers/gpu/drm/i915/display/skl_universal_plane_regs.h:351:
+ _PLANE_POST_CSC_GAMC_INDEX_1_B)$
-:89: ERROR:CODE_INDENT: code indent should use tabs where possible #89: FILE: drivers/gpu/drm/i915/display/skl_universal_plane_regs.h:353:
+ _PLANE_POST_CSC_GAMC_INDEX_2_B)$
-:89: WARNING:LEADING_SPACE: please, no spaces at the start of a line #89: FILE: drivers/gpu/drm/i915/display/skl_universal_plane_regs.h:353:
+ _PLANE_POST_CSC_GAMC_INDEX_2_B)$
-:90: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pipe' - possible side-effects? #90: FILE: drivers/gpu/drm/i915/display/skl_universal_plane_regs.h:354:
+#define PLANE_POST_CSC_GAMC_INDEX(pipe, plane, i) \
+ _MMIO_PLANE_GAMC(plane, i, _PLANE_POST_CSC_GAMC_INDEX_1(pipe), \
+ _PLANE_POST_CSC_GAMC_INDEX_2(pipe))
-:91: ERROR:CODE_INDENT: code indent should use tabs where possible #91: FILE: drivers/gpu/drm/i915/display/skl_universal_plane_regs.h:355:
+ _MMIO_PLANE_GAMC(plane, i, _PLANE_POST_CSC_GAMC_INDEX_1(pipe), \$
-:91: WARNING:LEADING_SPACE: please, no spaces at the start of a line #91: FILE: drivers/gpu/drm/i915/display/skl_universal_plane_regs.h:355:
+ _MMIO_PLANE_GAMC(plane, i, _PLANE_POST_CSC_GAMC_INDEX_1(pipe), \$
-:92: ERROR:CODE_INDENT: code indent should use tabs where possible #92: FILE: drivers/gpu/drm/i915/display/skl_universal_plane_regs.h:356:
+ _PLANE_POST_CSC_GAMC_INDEX_2(pipe))$
-:92: WARNING:LEADING_SPACE: please, no spaces at the start of a line #92: FILE: drivers/gpu/drm/i915/display/skl_universal_plane_regs.h:356:
+ _PLANE_POST_CSC_GAMC_INDEX_2(pipe))$
-:99: ERROR:CODE_INDENT: code indent should use tabs where possible #99: FILE: drivers/gpu/drm/i915/display/skl_universal_plane_regs.h:363:
+ _PLANE_POST_CSC_GAMC_DATA_1_B)$
-:99: WARNING:LEADING_SPACE: please, no spaces at the start of a line #99: FILE: drivers/gpu/drm/i915/display/skl_universal_plane_regs.h:363:
+ _PLANE_POST_CSC_GAMC_DATA_1_B)$
-:101: ERROR:CODE_INDENT: code indent should use tabs where possible #101: FILE: drivers/gpu/drm/i915/display/skl_universal_plane_regs.h:365:
+ _PLANE_POST_CSC_GAMC_DATA_2_B)$
-:101: WARNING:LEADING_SPACE: please, no spaces at the start of a line #101: FILE: drivers/gpu/drm/i915/display/skl_universal_plane_regs.h:365:
+ _PLANE_POST_CSC_GAMC_DATA_2_B)$
-:102: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pipe' - possible side-effects? #102: FILE: drivers/gpu/drm/i915/display/skl_universal_plane_regs.h:366:
+#define PLANE_POST_CSC_GAMC_DATA(pipe, plane, i) \
+ _MMIO_PLANE_GAMC(plane, i, _PLANE_POST_CSC_GAMC_DATA_1(pipe), \
+ _PLANE_POST_CSC_GAMC_DATA_2(pipe))
-:103: ERROR:CODE_INDENT: code indent should use tabs where possible #103: FILE: drivers/gpu/drm/i915/display/skl_universal_plane_regs.h:367:
+ _MMIO_PLANE_GAMC(plane, i, _PLANE_POST_CSC_GAMC_DATA_1(pipe), \$
-:103: WARNING:LEADING_SPACE: please, no spaces at the start of a line #103: FILE: drivers/gpu/drm/i915/display/skl_universal_plane_regs.h:367:
+ _MMIO_PLANE_GAMC(plane, i, _PLANE_POST_CSC_GAMC_DATA_1(pipe), \$
-:104: ERROR:CODE_INDENT: code indent should use tabs where possible #104: FILE: drivers/gpu/drm/i915/display/skl_universal_plane_regs.h:368:
+ _PLANE_POST_CSC_GAMC_DATA_2(pipe))$
-:104: WARNING:LEADING_SPACE: please, no spaces at the start of a line #104: FILE: drivers/gpu/drm/i915/display/skl_universal_plane_regs.h:368:
+ _PLANE_POST_CSC_GAMC_DATA_2(pipe))$
total: 24 errors, 28 warnings, 6 checks, 86 lines checked 711606a23e06 drm/i915/color: Program Pre-CSC registers 8f966c300b32 drm/i915/xelpd: Program Plane Post CSC Registers b70762f851a3 drm/i915/display: Add registers for 3D LUT 7898b6c5a91d drm/i915/color: Add 3D LUT to color pipeline 89fc3c0bfb00 drm/i915/color: Enable Plane Color Pipelines
Patchwork
CI✓ CI.KUnit: success for Plane Color Pipeline support for Intel platforms (rev5)
In reply to Uma Shankar== Series Details ==
== Series Details ==
Series: Plane Color Pipeline support for Intel platforms (rev5)
URL : https://patchwork.freedesktop.org/series/141788/
State : success
== Summary ==
+ trap cleanup EXIT
+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/xe/.kunitconfig [12:36:29] Configuring KUnit Kernel ...
Generating .config ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig [12:36:34] Building KUnit Kernel ... Populating config with: $ make ARCH=um O=.kunit olddefconfig Building with: $ make all compile_commands.json scripts_gdb ARCH=um O=.kunit --jobs=48 [12:37:04] Starting KUnit Kernel (1/1)... [12:37:04] ============================================================ Running tests with: $ .kunit/linux kunit.enable=1 mem=1G console=tty kunit_shutdown=halt [12:37:04] ================== guc_buf (11 subtests) =================== [12:37:04] [PASSED] test_smallest [12:37:04] [PASSED] test_largest [12:37:04] [PASSED] test_granular [12:37:04] [PASSED] test_unique [12:37:04] [PASSED] test_overlap [12:37:04] [PASSED] test_reusable [12:37:04] [PASSED] test_too_big [12:37:04] [PASSED] test_flush [12:37:04] [PASSED] test_lookup [12:37:04] [PASSED] test_data [12:37:04] [PASSED] test_class [12:37:04] ===================== [PASSED] guc_buf ===================== [12:37:04] =================== guc_dbm (7 subtests) =================== [12:37:04] [PASSED] test_empty [12:37:04] [PASSED] test_default [12:37:04] ======================== test_size ======================== [12:37:04] [PASSED] 4 [12:37:04] [PASSED] 8 [12:37:04] [PASSED] 32 [12:37:04] [PASSED] 256 [12:37:04] ==================== [PASSED] test_size ==================== [12:37:04] ======================= test_reuse ======================== [12:37:04] [PASSED] 4 [12:37:04] [PASSED] 8 [12:37:04] [PASSED] 32 [12:37:04] [PASSED] 256 [12:37:04] =================== [PASSED] test_reuse ==================== [12:37:04] =================== test_range_overlap ==================== [12:37:04] [PASSED] 4 [12:37:04] [PASSED] 8 [12:37:04] [PASSED] 32 [12:37:04] [PASSED] 256 [12:37:04] =============== [PASSED] test_range_overlap ================ [12:37:04] =================== test_range_compact ==================== [12:37:04] [PASSED] 4 [12:37:04] [PASSED] 8 [12:37:04] [PASSED] 32 [12:37:04] [PASSED] 256 [12:37:04] =============== [PASSED] test_range_compact ================ [12:37:04] ==================== test_range_spare ===================== [12:37:04] [PASSED] 4 [12:37:04] [PASSED] 8 [12:37:04] [PASSED] 32 [12:37:04] [PASSED] 256 [12:37:04] ================ [PASSED] test_range_spare ================= [12:37:04] ===================== [PASSED] guc_dbm ===================== [12:37:04] =================== guc_idm (6 subtests) =================== [12:37:04] [PASSED] bad_init [12:37:04] [PASSED] no_init [12:37:04] [PASSED] init_fini [12:37:04] [PASSED] check_used [12:37:04] [PASSED] check_quota [12:37:04] [PASSED] check_all [12:37:04] ===================== [PASSED] guc_idm ===================== [12:37:04] ================== no_relay (3 subtests) =================== [12:37:04] [PASSED] xe_drops_guc2pf_if_not_ready [12:37:04] [PASSED] xe_drops_guc2vf_if_not_ready [12:37:04] [PASSED] xe_rejects_send_if_not_ready [12:37:04] ==================== [PASSED] no_relay ===================== [12:37:04] ================== pf_relay (14 subtests) ================== [12:37:04] [PASSED] pf_rejects_guc2pf_too_short [12:37:04] [PASSED] pf_rejects_guc2pf_too_long [12:37:04] [PASSED] pf_rejects_guc2pf_no_payload [12:37:04] [PASSED] pf_fails_no_payload [12:37:04] [PASSED] pf_fails_bad_origin [12:37:04] [PASSED] pf_fails_bad_type [12:37:04] [PASSED] pf_txn_reports_error [12:37:04] [PASSED] pf_txn_sends_pf2guc [12:37:04] [PASSED] pf_sends_pf2guc [12:37:04] [SKIPPED] pf_loopback_nop [12:37:04] [SKIPPED] pf_loopback_echo [12:37:04] [SKIPPED] pf_loopback_fail [12:37:04] [SKIPPED] pf_loopback_busy [12:37:04] [SKIPPED] pf_loopback_retry [12:37:04] ==================== [PASSED] pf_relay ===================== [12:37:04] ================== vf_relay (3 subtests) =================== [12:37:04] [PASSED] vf_rejects_guc2vf_too_short [12:37:04] [PASSED] vf_rejects_guc2vf_too_long [12:37:04] [PASSED] vf_rejects_guc2vf_no_payload [12:37:04] ==================== [PASSED] vf_relay ===================== [12:37:04] ===================== lmtt (1 subtest) ===================== [12:37:04] ======================== test_ops ========================= [12:37:04] [PASSED] 2-level [12:37:04] [PASSED] multi-level [12:37:04] ==================== [PASSED] test_ops ===================== [12:37:04] ====================== [PASSED] lmtt ======================= [12:37:04] ================= pf_service (11 subtests) ================= [12:37:04] [PASSED] pf_negotiate_any [12:37:04] [PASSED] pf_negotiate_base_match [12:37:04] [PASSED] pf_negotiate_base_newer [12:37:04] [PASSED] pf_negotiate_base_next [12:37:04] [SKIPPED] pf_negotiate_base_older [12:37:04] [PASSED] pf_negotiate_base_prev [12:37:04] [PASSED] pf_negotiate_latest_match [12:37:04] [PASSED] pf_negotiate_latest_newer [12:37:04] [PASSED] pf_negotiate_latest_next [12:37:04] [SKIPPED] pf_negotiate_latest_older [12:37:04] [SKIPPED] pf_negotiate_latest_prev [12:37:04] =================== [PASSED] pf_service ==================== [12:37:04] ================= xe_guc_g2g (2 subtests) ================== [12:37:04] ============== xe_live_guc_g2g_kunit_default ============== [12:37:04] ========= [SKIPPED] xe_live_guc_g2g_kunit_default ========== [12:37:04] ============== xe_live_guc_g2g_kunit_allmem =============== [12:37:04] ========== [SKIPPED] xe_live_guc_g2g_kunit_allmem ========== [12:37:04] =================== [SKIPPED] xe_guc_g2g =================== [12:37:04] =================== xe_mocs (2 subtests) =================== [12:37:04] ================ xe_live_mocs_kernel_kunit ================ [12:37:04] =========== [SKIPPED] xe_live_mocs_kernel_kunit ============ [12:37:04] ================ xe_live_mocs_reset_kunit ================= [12:37:04] ============ [SKIPPED] xe_live_mocs_reset_kunit ============ [12:37:04] ==================== [SKIPPED] xe_mocs ===================== [12:37:04] ================= xe_migrate (2 subtests) ================== [12:37:04] ================= xe_migrate_sanity_kunit ================= [12:37:04] ============ [SKIPPED] xe_migrate_sanity_kunit ============= [12:37:04] ================== xe_validate_ccs_kunit ================== [12:37:04] ============= [SKIPPED] xe_validate_ccs_kunit ============== [12:37:04] =================== [SKIPPED] xe_migrate =================== [12:37:04] ================== xe_dma_buf (1 subtest) ================== [12:37:04] ==================== xe_dma_buf_kunit ===================== [12:37:04] ================ [SKIPPED] xe_dma_buf_kunit ================ [12:37:04] =================== [SKIPPED] xe_dma_buf =================== [12:37:04] ================= xe_bo_shrink (1 subtest) ================= [12:37:04] =================== xe_bo_shrink_kunit ==================== [12:37:04] =============== [SKIPPED] xe_bo_shrink_kunit =============== [12:37:04] ================== [SKIPPED] xe_bo_shrink ================== [12:37:04] ==================== xe_bo (2 subtests) ==================== [12:37:04] ================== xe_ccs_migrate_kunit =================== [12:37:04] ============== [SKIPPED] xe_ccs_migrate_kunit ============== [12:37:04] ==================== xe_bo_evict_kunit ==================== [12:37:04] =============== [SKIPPED] xe_bo_evict_kunit ================ [12:37:04] ===================== [SKIPPED] xe_bo ====================== [12:37:04] ==================== args (11 subtests) ==================== [12:37:04] [PASSED] count_args_test [12:37:04] [PASSED] call_args_example [12:37:04] [PASSED] call_args_test [12:37:04] [PASSED] drop_first_arg_example [12:37:04] [PASSED] drop_first_arg_test [12:37:04] [PASSED] first_arg_example [12:37:04] [PASSED] first_arg_test [12:37:04] [PASSED] last_arg_example [12:37:04] [PASSED] last_arg_test [12:37:04] [PASSED] pick_arg_example [12:37:04] [PASSED] sep_comma_example [12:37:04] ====================== [PASSED] args ======================= [12:37:04] =================== xe_pci (3 subtests) ==================== [12:37:04] ==================== check_graphics_ip ==================== [12:37:04] [PASSED] 12.00 Xe_LP [12:37:04] [PASSED] 12.10 Xe_LP+ [12:37:04] [PASSED] 12.55 Xe_HPG [12:37:04] [PASSED] 12.60 Xe_HPC [12:37:04] [PASSED] 12.70 Xe_LPG [12:37:04] [PASSED] 12.71 Xe_LPG [12:37:04] [PASSED] 12.74 Xe_LPG+ [12:37:04] [PASSED] 20.01 Xe2_HPG [12:37:04] [PASSED] 20.02 Xe2_HPG [12:37:04] [PASSED] 20.04 Xe2_LPG [12:37:04] [PASSED] 30.00 Xe3_LPG [12:37:04] [PASSED] 30.01 Xe3_LPG [12:37:04] [PASSED] 30.03 Xe3_LPG [12:37:04] [PASSED] 30.04 Xe3_LPG [12:37:04] [PASSED] 30.05 Xe3_LPG [12:37:04] [PASSED] 35.11 Xe3p_XPC [12:37:04] ================ [PASSED] check_graphics_ip ================ [12:37:04] ===================== check_media_ip ====================== [12:37:04] [PASSED] 12.00 Xe_M [12:37:04] [PASSED] 12.55 Xe_HPM [12:37:04] [PASSED] 13.00 Xe_LPM+ [12:37:04] [PASSED] 13.01 Xe2_HPM [12:37:04] [PASSED] 20.00 Xe2_LPM [12:37:04] [PASSED] 30.00 Xe3_LPM [12:37:04] [PASSED] 30.02 Xe3_LPM [12:37:04] [PASSED] 35.00 Xe3p_LPM [12:37:04] [PASSED] 35.03 Xe3p_HPM [12:37:04] ================= [PASSED] check_media_ip ================== [12:37:04] =================== check_platform_desc =================== [12:37:04] [PASSED] 0x9A60 (TIGERLAKE) [12:37:04] [PASSED] 0x9A68 (TIGERLAKE) [12:37:04] [PASSED] 0x9A70 (TIGERLAKE) [12:37:04] [PASSED] 0x9A40 (TIGERLAKE) [12:37:04] [PASSED] 0x9A49 (TIGERLAKE) [12:37:04] [PASSED] 0x9A59 (TIGERLAKE) [12:37:04] [PASSED] 0x9A78 (TIGERLAKE) [12:37:04] [PASSED] 0x9AC0 (TIGERLAKE) [12:37:04] [PASSED] 0x9AC9 (TIGERLAKE) [12:37:04] [PASSED] 0x9AD9 (TIGERLAKE) [12:37:04] [PASSED] 0x9AF8 (TIGERLAKE) [12:37:04] [PASSED] 0x4C80 (ROCKETLAKE) [12:37:04] [PASSED] 0x4C8A (ROCKETLAKE) [12:37:04] [PASSED] 0x4C8B (ROCKETLAKE) [12:37:04] [PASSED] 0x4C8C (ROCKETLAKE) [12:37:04] [PASSED] 0x4C90 (ROCKETLAKE) [12:37:04] [PASSED] 0x4C9A (ROCKETLAKE) [12:37:04] [PASSED] 0x4680 (ALDERLAKE_S) [12:37:04] [PASSED] 0x4682 (ALDERLAKE_S) [12:37:04] [PASSED] 0x4688 (ALDERLAKE_S) [12:37:04] [PASSED] 0x468A (ALDERLAKE_S) [12:37:04] [PASSED] 0x468B (ALDERLAKE_S) [12:37:04] [PASSED] 0x4690 (ALDERLAKE_S) [12:37:04] [PASSED] 0x4692 (ALDERLAKE_S) [12:37:04] [PASSED] 0x4693 (ALDERLAKE_S) [12:37:04] [PASSED] 0x46A0 (ALDERLAKE_P) [12:37:04] [PASSED] 0x46A1 (ALDERLAKE_P) [12:37:04] [PASSED] 0x46A2 (ALDERLAKE_P) [12:37:04] [PASSED] 0x46A3 (ALDERLAKE_P) [12:37:04] [PASSED] 0x46A6 (ALDERLAKE_P) [12:37:04] [PASSED] 0x46A8 (ALDERLAKE_P) [12:37:04] [PASSED] 0x46AA (ALDERLAKE_P) [12:37:04] [PASSED] 0x462A (ALDERLAKE_P) [12:37:04] [PASSED] 0x4626 (ALDERLAKE_P) [12:37:04] [PASSED] 0x4628 (ALDERLAKE_P) [12:37:04] [PASSED] 0x46B0 (ALDERLAKE_P) [12:37:04] [PASSED] 0x46B1 (ALDERLAKE_P) [12:37:04] [PASSED] 0x46B2 (ALDERLAKE_P) [12:37:04] [PASSED] 0x46B3 (ALDERLAKE_P) [12:37:04] [PASSED] 0x46C0 (ALDERLAKE_P) [12:37:04] [PASSED] 0x46C1 (ALDERLAKE_P) [12:37:04] [PASSED] 0x46C2 (ALDERLAKE_P) [12:37:04] [PASSED] 0x46C3 (ALDERLAKE_P) [12:37:04] [PASSED] 0x46D0 (ALDERLAKE_N) [12:37:04] [PASSED] 0x46D1 (ALDERLAKE_N) [12:37:04] [PASSED] 0x46D2 (ALDERLAKE_N) [12:37:04] [PASSED] 0x46D3 (ALDERLAKE_N) [12:37:04] [PASSED] 0x46D4 (ALDERLAKE_N) [12:37:04] [PASSED] 0xA721 (ALDERLAKE_P) [12:37:04] [PASSED] 0xA7A1 (ALDERLAKE_P) [12:37:04] [PASSED] 0xA7A9 (ALDERLAKE_P) [12:37:04] [PASSED] 0xA7AC (ALDERLAKE_P) [12:37:04] [PASSED] 0xA7AD (ALDERLAKE_P) [12:37:04] [PASSED] 0xA720 (ALDERLAKE_P) [12:37:04] [PASSED] 0xA7A0 (ALDERLAKE_P) [12:37:04] [PASSED] 0xA7A8 (ALDERLAKE_P) [12:37:04] [PASSED] 0xA7AA (ALDERLAKE_P) [12:37:04] [PASSED] 0xA7AB (ALDERLAKE_P) [12:37:04] [PASSED] 0xA780 (ALDERLAKE_S) [12:37:04] [PASSED] 0xA781 (ALDERLAKE_S) [12:37:04] [PASSED] 0xA782 (ALDERLAKE_S) [12:37:04] [PASSED] 0xA783 (ALDERLAKE_S) [12:37:04] [PASSED] 0xA788 (ALDERLAKE_S) [12:37:04] [PASSED] 0xA789 (ALDERLAKE_S) [12:37:04] [PASSED] 0xA78A (ALDERLAKE_S) [12:37:04] [PASSED] 0xA78B (ALDERLAKE_S) [12:37:04] [PASSED] 0x4905 (DG1) [12:37:04] [PASSED] 0x4906 (DG1) [12:37:04] [PASSED] 0x4907 (DG1) [12:37:04] [PASSED] 0x4908 (DG1) [12:37:04] [PASSED] 0x4909 (DG1) [12:37:04] [PASSED] 0x56C0 (DG2) [12:37:04] [PASSED] 0x56C2 (DG2) [12:37:04] [PASSED] 0x56C1 (DG2) [12:37:04] [PASSED] 0x7D51 (METEORLAKE) [12:37:04] [PASSED] 0x7DD1 (METEORLAKE) [12:37:04] [PASSED] 0x7D41 (METEORLAKE) [12:37:04] [PASSED] 0x7D67 (METEORLAKE) [12:37:04] [PASSED] 0xB640 (METEORLAKE) [12:37:04] [PASSED] 0x56A0 (DG2) [12:37:04] [PASSED] 0x56A1 (DG2) [12:37:04] [PASSED] 0x56A2 (DG2) [12:37:04] [PASSED] 0x56BE (DG2) [12:37:04] [PASSED] 0x56BF (DG2) [12:37:04] [PASSED] 0x5690 (DG2) [12:37:04] [PASSED] 0x5691 (DG2) [12:37:04] [PASSED] 0x5692 (DG2) [12:37:04] [PASSED] 0x56A5 (DG2) [12:37:04] [PASSED] 0x56A6 (DG2) [12:37:04] [PASSED] 0x56B0 (DG2) [12:37:04] [PASSED] 0x56B1 (DG2) [12:37:04] [PASSED] 0x56BA (DG2) [12:37:04] [PASSED] 0x56BB (DG2) [12:37:04] [PASSED] 0x56BC (DG2) [12:37:04] [PASSED] 0x56BD (DG2) [12:37:04] [PASSED] 0x5693 (DG2) [12:37:04] [PASSED] 0x5694 (DG2) [12:37:04] [PASSED] 0x5695 (DG2) [12:37:04] [PASSED] 0x56A3 (DG2) [12:37:04] [PASSED] 0x56A4 (DG2) [12:37:04] [PASSED] 0x56B2 (DG2) [12:37:04] [PASSED] 0x56B3 (DG2) [12:37:04] [PASSED] 0x5696 (DG2) [12:37:04] [PASSED] 0x5697 (DG2) [12:37:04] [PASSED] 0xB69 (PVC) [12:37:04] [PASSED] 0xB6E (PVC) [12:37:04] [PASSED] 0xBD4 (PVC) [12:37:04] [PASSED] 0xBD5 (PVC) [12:37:04] [PASSED] 0xBD6 (PVC) [12:37:04] [PASSED] 0xBD7 (PVC) [12:37:04] [PASSED] 0xBD8 (PVC) [12:37:04] [PASSED] 0xBD9 (PVC) [12:37:04] [PASSED] 0xBDA (PVC) [12:37:04] [PASSED] 0xBDB (PVC) [12:37:04] [PASSED] 0xBE0 (PVC) [12:37:04] [PASSED] 0xBE1 (PVC) [12:37:04] [PASSED] 0xBE5 (PVC) [12:37:04] [PASSED] 0x7D40 (METEORLAKE) [12:37:04] [PASSED] 0x7D45 (METEORLAKE) [12:37:04] [PASSED] 0x7D55 (METEORLAKE) [12:37:04] [PASSED] 0x7D60 (METEORLAKE) [12:37:04] [PASSED] 0x7DD5 (METEORLAKE) [12:37:04] [PASSED] 0x6420 (LUNARLAKE) [12:37:04] [PASSED] 0x64A0 (LUNARLAKE) [12:37:04] [PASSED] 0x64B0 (LUNARLAKE) [12:37:04] [PASSED] 0xE202 (BATTLEMAGE) [12:37:04] [PASSED] 0xE209 (BATTLEMAGE) [12:37:04] [PASSED] 0xE20B (BATTLEMAGE) [12:37:04] [PASSED] 0xE20C (BATTLEMAGE) [12:37:04] [PASSED] 0xE20D (BATTLEMAGE) [12:37:04] [PASSED] 0xE210 (BATTLEMAGE) [12:37:04] [PASSED] 0xE211 (BATTLEMAGE) [12:37:04] [PASSED] 0xE212 (BATTLEMAGE) [12:37:04] [PASSED] 0xE216 (BATTLEMAGE) [12:37:04] [PASSED] 0xE220 (BATTLEMAGE) [12:37:04] [PASSED] 0xE221 (BATTLEMAGE) [12:37:04] [PASSED] 0xE222 (BATTLEMAGE) [12:37:04] [PASSED] 0xE223 (BATTLEMAGE) [12:37:04] [PASSED] 0xB080 (PANTHERLAKE) [12:37:04] [PASSED] 0xB081 (PANTHERLAKE) [12:37:04] [PASSED] 0xB082 (PANTHERLAKE) [12:37:04] [PASSED] 0xB083 (PANTHERLAKE) [12:37:04] [PASSED] 0xB084 (PANTHERLAKE) [12:37:04] [PASSED] 0xB085 (PANTHERLAKE) [12:37:04] [PASSED] 0xB086 (PANTHERLAKE) [12:37:04] [PASSED] 0xB087 (PANTHERLAKE) [12:37:04] [PASSED] 0xB08F (PANTHERLAKE) [12:37:04] [PASSED] 0xB090 (PANTHERLAKE) [12:37:04] [PASSED] 0xB0A0 (PANTHERLAKE) [12:37:04] [PASSED] 0xB0B0 (PANTHERLAKE) [12:37:04] [PASSED] 0xD740 (NOVALAKE_S) [12:37:04] [PASSED] 0xD741 (NOVALAKE_S) [12:37:04] [PASSED] 0xD742 (NOVALAKE_S) [12:37:04] [PASSED] 0xD743 (NOVALAKE_S) [12:37:04] [PASSED] 0xD744 (NOVALAKE_S) [12:37:04] [PASSED] 0xD745 (NOVALAKE_S) [12:37:04] [PASSED] 0x674C (CRESCENTISLAND) [12:37:04] [PASSED] 0xFD80 (PANTHERLAKE) [12:37:04] [PASSED] 0xFD81 (PANTHERLAKE) [12:37:04] =============== [PASSED] check_platform_desc =============== [12:37:04] ===================== [PASSED] xe_pci ====================== [12:37:04] =================== xe_rtp (2 subtests) ==================== [12:37:04] =============== xe_rtp_process_to_sr_tests ================ [12:37:04] [PASSED] coalesce-same-reg [12:37:04] [PASSED] no-match-no-add [12:37:04] [PASSED] match-or [12:37:04] [PASSED] match-or-xfail [12:37:04] [PASSED] no-match-no-add-multiple-rules [12:37:04] [PASSED] two-regs-two-entries [12:37:04] [PASSED] clr-one-set-other [12:37:04] [PASSED] set-field [12:37:04] [PASSED] conflict-duplicate [12:37:04] [PASSED] conflict-not-disjoint [12:37:04] [PASSED] conflict-reg-type [12:37:04] =========== [PASSED] xe_rtp_process_to_sr_tests ============ [12:37:04] ================== xe_rtp_process_tests =================== [12:37:04] [PASSED] active1 [12:37:04] [PASSED] active2 [12:37:04] [PASSED] active-inactive [12:37:04] [PASSED] inactive-active [12:37:04] [PASSED] inactive-1st_or_active-inactive [12:37:04] [PASSED] inactive-2nd_or_active-inactive [12:37:04] [PASSED] inactive-last_or_active-inactive stty: 'standard input': Inappropriate ioctl for device [12:37:04] [PASSED] inactive-no_or_active-inactive [12:37:04] ============== [PASSED] xe_rtp_process_tests =============== [12:37:04] ===================== [PASSED] xe_rtp ====================== [12:37:04] ==================== xe_wa (1 subtest) ===================== [12:37:04] ======================== xe_wa_gt ========================= [12:37:04] [PASSED] TIGERLAKE B0 [12:37:04] [PASSED] DG1 A0 [12:37:04] [PASSED] DG1 B0 [12:37:04] [PASSED] ALDERLAKE_S A0 [12:37:04] [PASSED] ALDERLAKE_S B0 [12:37:04] [PASSED] ALDERLAKE_S C0 [12:37:04] [PASSED] ALDERLAKE_S D0 [12:37:04] [PASSED] ALDERLAKE_P A0 [12:37:04] [PASSED] ALDERLAKE_P B0 [12:37:04] [PASSED] ALDERLAKE_P C0 [12:37:04] [PASSED] ALDERLAKE_S RPLS D0 [12:37:04] [PASSED] ALDERLAKE_P RPLU E0 [12:37:04] [PASSED] DG2 G10 C0 [12:37:04] [PASSED] DG2 G11 B1 [12:37:04] [PASSED] DG2 G12 A1 [12:37:04] [PASSED] METEORLAKE 12.70(Xe_LPG) A0 13.00(Xe_LPM+) A0 [12:37:04] [PASSED] METEORLAKE 12.71(Xe_LPG) A0 13.00(Xe_LPM+) A0 [12:37:04] [PASSED] METEORLAKE 12.74(Xe_LPG+) A0 13.00(Xe_LPM+) A0 [12:37:04] [PASSED] LUNARLAKE 20.04(Xe2_LPG) A0 20.00(Xe2_LPM) A0 [12:37:04] [PASSED] LUNARLAKE 20.04(Xe2_LPG) B0 20.00(Xe2_LPM) A0 [12:37:04] [PASSED] BATTLEMAGE 20.01(Xe2_HPG) A0 13.01(Xe2_HPM) A1 [12:37:04] [PASSED] PANTHERLAKE 30.00(Xe3_LPG) A0 30.00(Xe3_LPM) A0 [12:37:04] ==================== [PASSED] xe_wa_gt ===================== [12:37:04] ====================== [PASSED] xe_wa ====================== [12:37:04] ============================================================ [12:37:04] Testing complete. Ran 318 tests: passed: 300, skipped: 18 [12:37:04] Elapsed time: 35.056s total, 4.279s configuring, 30.410s building, 0.340s running
+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/tests/.kunitconfig [12:37:05] Configuring KUnit Kernel ...
Regenerating .config ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig [12:37:06] Building KUnit Kernel ... Populating config with: $ make ARCH=um O=.kunit olddefconfig Building with: $ make all compile_commands.json scripts_gdb ARCH=um O=.kunit --jobs=48 [12:37:31] Starting KUnit Kernel (1/1)... [12:37:31] ============================================================ Running tests with: $ .kunit/linux kunit.enable=1 mem=1G console=tty kunit_shutdown=halt [12:37:32] ============ drm_test_pick_cmdline (2 subtests) ============ [12:37:32] [PASSED] drm_test_pick_cmdline_res_1920_1080_60 [12:37:32] =============== drm_test_pick_cmdline_named =============== [12:37:32] [PASSED] NTSC [12:37:32] [PASSED] NTSC-J [12:37:32] [PASSED] PAL [12:37:32] [PASSED] PAL-M [12:37:32] =========== [PASSED] drm_test_pick_cmdline_named =========== [12:37:32] ============== [PASSED] drm_test_pick_cmdline ============== [12:37:32] == drm_test_atomic_get_connector_for_encoder (1 subtest) === [12:37:32] [PASSED] drm_test_drm_atomic_get_connector_for_encoder [12:37:32] ==== [PASSED] drm_test_atomic_get_connector_for_encoder ==== [12:37:32] =========== drm_validate_clone_mode (2 subtests) =========== [12:37:32] ============== drm_test_check_in_clone_mode =============== [12:37:32] [PASSED] in_clone_mode [12:37:32] [PASSED] not_in_clone_mode [12:37:32] ========== [PASSED] drm_test_check_in_clone_mode =========== [12:37:32] =============== drm_test_check_valid_clones =============== [12:37:32] [PASSED] not_in_clone_mode [12:37:32] [PASSED] valid_clone [12:37:32] [PASSED] invalid_clone [12:37:32] =========== [PASSED] drm_test_check_valid_clones =========== [12:37:32] ============= [PASSED] drm_validate_clone_mode ============= [12:37:32] ============= drm_validate_modeset (1 subtest) ============= [12:37:32] [PASSED] drm_test_check_connector_changed_modeset [12:37:32] ============== [PASSED] drm_validate_modeset =============== [12:37:32] ====== drm_test_bridge_get_current_state (2 subtests) ====== [12:37:32] [PASSED] drm_test_drm_bridge_get_current_state_atomic [12:37:32] [PASSED] drm_test_drm_bridge_get_current_state_legacy [12:37:32] ======== [PASSED] drm_test_bridge_get_current_state ======== [12:37:32] ====== drm_test_bridge_helper_reset_crtc (3 subtests) ====== [12:37:32] [PASSED] drm_test_drm_bridge_helper_reset_crtc_atomic [12:37:32] [PASSED] drm_test_drm_bridge_helper_reset_crtc_atomic_disabled [12:37:32] [PASSED] drm_test_drm_bridge_helper_reset_crtc_legacy [12:37:32] ======== [PASSED] drm_test_bridge_helper_reset_crtc ======== [12:37:32] ============== drm_bridge_alloc (2 subtests) =============== [12:37:32] [PASSED] drm_test_drm_bridge_alloc_basic [12:37:32] [PASSED] drm_test_drm_bridge_alloc_get_put [12:37:32] ================ [PASSED] drm_bridge_alloc ================= [12:37:32] ================== drm_buddy (8 subtests) ================== [12:37:32] [PASSED] drm_test_buddy_alloc_limit [12:37:32] [PASSED] drm_test_buddy_alloc_optimistic [12:37:32] [PASSED] drm_test_buddy_alloc_pessimistic [12:37:32] [PASSED] drm_test_buddy_alloc_pathological [12:37:32] [PASSED] drm_test_buddy_alloc_contiguous [12:37:32] [PASSED] drm_test_buddy_alloc_clear [12:37:32] [PASSED] drm_test_buddy_alloc_range_bias [12:37:32] [PASSED] drm_test_buddy_fragmentation_performance [12:37:32] ==================== [PASSED] drm_buddy ==================== [12:37:32] ============= drm_cmdline_parser (40 subtests) ============= [12:37:32] [PASSED] drm_test_cmdline_force_d_only [12:37:32] [PASSED] drm_test_cmdline_force_D_only_dvi [12:37:32] [PASSED] drm_test_cmdline_force_D_only_hdmi [12:37:32] [PASSED] drm_test_cmdline_force_D_only_not_digital [12:37:32] [PASSED] drm_test_cmdline_force_e_only [12:37:32] [PASSED] drm_test_cmdline_res [12:37:32] [PASSED] drm_test_cmdline_res_vesa [12:37:32] [PASSED] drm_test_cmdline_res_vesa_rblank [12:37:32] [PASSED] drm_test_cmdline_res_rblank [12:37:32] [PASSED] drm_test_cmdline_res_bpp [12:37:32] [PASSED] drm_test_cmdline_res_refresh [12:37:32] [PASSED] drm_test_cmdline_res_bpp_refresh [12:37:32] [PASSED] drm_test_cmdline_res_bpp_refresh_interlaced [12:37:32] [PASSED] drm_test_cmdline_res_bpp_refresh_margins [12:37:32] [PASSED] drm_test_cmdline_res_bpp_refresh_force_off [12:37:32] [PASSED] drm_test_cmdline_res_bpp_refresh_force_on [12:37:32] [PASSED] drm_test_cmdline_res_bpp_refresh_force_on_analog [12:37:32] [PASSED] drm_test_cmdline_res_bpp_refresh_force_on_digital [12:37:32] [PASSED] drm_test_cmdline_res_bpp_refresh_interlaced_margins_force_on [12:37:32] [PASSED] drm_test_cmdline_res_margins_force_on [12:37:32] [PASSED] drm_test_cmdline_res_vesa_margins [12:37:32] [PASSED] drm_test_cmdline_name [12:37:32] [PASSED] drm_test_cmdline_name_bpp [12:37:32] [PASSED] drm_test_cmdline_name_option [12:37:32] [PASSED] drm_test_cmdline_name_bpp_option [12:37:32] [PASSED] drm_test_cmdline_rotate_0 [12:37:32] [PASSED] drm_test_cmdline_rotate_90 [12:37:32] [PASSED] drm_test_cmdline_rotate_180 [12:37:32] [PASSED] drm_test_cmdline_rotate_270 [12:37:32] [PASSED] drm_test_cmdline_hmirror [12:37:32] [PASSED] drm_test_cmdline_vmirror [12:37:32] [PASSED] drm_test_cmdline_margin_options [12:37:32] [PASSED] drm_test_cmdline_multiple_options [12:37:32] [PASSED] drm_test_cmdline_bpp_extra_and_option [12:37:32] [PASSED] drm_test_cmdline_extra_and_option [12:37:32] [PASSED] drm_test_cmdline_freestanding_options [12:37:32] [PASSED] drm_test_cmdline_freestanding_force_e_and_options [12:37:32] [PASSED] drm_test_cmdline_panel_orientation [12:37:32] ================ drm_test_cmdline_invalid ================= [12:37:32] [PASSED] margin_only [12:37:32] [PASSED] interlace_only [12:37:32] [PASSED] res_missing_x [12:37:32] [PASSED] res_missing_y [12:37:32] [PASSED] res_bad_y [12:37:32] [PASSED] res_missing_y_bpp [12:37:32] [PASSED] res_bad_bpp [12:37:32] [PASSED] res_bad_refresh [12:37:32] [PASSED] res_bpp_refresh_force_on_off [12:37:32] [PASSED] res_invalid_mode [12:37:32] [PASSED] res_bpp_wrong_place_mode [12:37:32] [PASSED] name_bpp_refresh [12:37:32] [PASSED] name_refresh [12:37:32] [PASSED] name_refresh_wrong_mode [12:37:32] [PASSED] name_refresh_invalid_mode [12:37:32] [PASSED] rotate_multiple [12:37:32] [PASSED] rotate_invalid_val [12:37:32] [PASSED] rotate_truncated [12:37:32] [PASSED] invalid_option [12:37:32] [PASSED] invalid_tv_option [12:37:32] [PASSED] truncated_tv_option [12:37:32] ============ [PASSED] drm_test_cmdline_invalid ============= [12:37:32] =============== drm_test_cmdline_tv_options =============== [12:37:32] [PASSED] NTSC [12:37:32] [PASSED] NTSC_443 [12:37:32] [PASSED] NTSC_J [12:37:32] [PASSED] PAL [12:37:32] [PASSED] PAL_M [12:37:32] [PASSED] PAL_N [12:37:32] [PASSED] SECAM [12:37:32] [PASSED] MONO_525 [12:37:32] [PASSED] MONO_625 [12:37:32] =========== [PASSED] drm_test_cmdline_tv_options =========== [12:37:32] =============== [PASSED] drm_cmdline_parser ================ [12:37:32] ========== drmm_connector_hdmi_init (20 subtests) ========== [12:37:32] [PASSED] drm_test_connector_hdmi_init_valid [12:37:32] [PASSED] drm_test_connector_hdmi_init_bpc_8 [12:37:32] [PASSED] drm_test_connector_hdmi_init_bpc_10 [12:37:32] [PASSED] drm_test_connector_hdmi_init_bpc_12 [12:37:32] [PASSED] drm_test_connector_hdmi_init_bpc_invalid [12:37:32] [PASSED] drm_test_connector_hdmi_init_bpc_null [12:37:32] [PASSED] drm_test_connector_hdmi_init_formats_empty [12:37:32] [PASSED] drm_test_connector_hdmi_init_formats_no_rgb [12:37:32] === drm_test_connector_hdmi_init_formats_yuv420_allowed === [12:37:32] [PASSED] supported_formats=0x9 yuv420_allowed=1 [12:37:32] [PASSED] supported_formats=0x9 yuv420_allowed=0 [12:37:32] [PASSED] supported_formats=0x3 yuv420_allowed=1 [12:37:32] [PASSED] supported_formats=0x3 yuv420_allowed=0 [12:37:32] === [PASSED] drm_test_connector_hdmi_init_formats_yuv420_allowed === [12:37:32] [PASSED] drm_test_connector_hdmi_init_null_ddc [12:37:32] [PASSED] drm_test_connector_hdmi_init_null_product [12:37:32] [PASSED] drm_test_connector_hdmi_init_null_vendor [12:37:32] [PASSED] drm_test_connector_hdmi_init_product_length_exact [12:37:32] [PASSED] drm_test_connector_hdmi_init_product_length_too_long [12:37:32] [PASSED] drm_test_connector_hdmi_init_product_valid [12:37:32] [PASSED] drm_test_connector_hdmi_init_vendor_length_exact [12:37:32] [PASSED] drm_test_connector_hdmi_init_vendor_length_too_long [12:37:32] [PASSED] drm_test_connector_hdmi_init_vendor_valid [12:37:32] ========= drm_test_connector_hdmi_init_type_valid ========= [12:37:32] [PASSED] HDMI-A [12:37:32] [PASSED] HDMI-B [12:37:32] ===== [PASSED] drm_test_connector_hdmi_init_type_valid ===== [12:37:32] ======== drm_test_connector_hdmi_init_type_invalid ======== [12:37:32] [PASSED] Unknown [12:37:32] [PASSED] VGA [12:37:32] [PASSED] DVI-I [12:37:32] [PASSED] DVI-D [12:37:32] [PASSED] DVI-A [12:37:32] [PASSED] Composite [12:37:32] [PASSED] SVIDEO [12:37:32] [PASSED] LVDS [12:37:32] [PASSED] Component [12:37:32] [PASSED] DIN [12:37:32] [PASSED] DP [12:37:32] [PASSED] TV [12:37:32] [PASSED] eDP [12:37:32] [PASSED] Virtual [12:37:32] [PASSED] DSI [12:37:32] [PASSED] DPI [12:37:32] [PASSED] Writeback [12:37:32] [PASSED] SPI [12:37:32] [PASSED] USB [12:37:32] ==== [PASSED] drm_test_connector_hdmi_init_type_invalid ==== [12:37:32] ============ [PASSED] drmm_connector_hdmi_init ============= [12:37:32] ============= drmm_connector_init (3 subtests) ============= [12:37:32] [PASSED] drm_test_drmm_connector_init [12:37:32] [PASSED] drm_test_drmm_connector_init_null_ddc [12:37:32] ========= drm_test_drmm_connector_init_type_valid ========= [12:37:32] [PASSED] Unknown [12:37:32] [PASSED] VGA [12:37:32] [PASSED] DVI-I [12:37:32] [PASSED] DVI-D [12:37:32] [PASSED] DVI-A [12:37:32] [PASSED] Composite [12:37:32] [PASSED] SVIDEO [12:37:32] [PASSED] LVDS [12:37:32] [PASSED] Component [12:37:32] [PASSED] DIN [12:37:32] [PASSED] DP [12:37:32] [PASSED] HDMI-A [12:37:32] [PASSED] HDMI-B [12:37:32] [PASSED] TV [12:37:32] [PASSED] eDP [12:37:32] [PASSED] Virtual [12:37:32] [PASSED] DSI [12:37:32] [PASSED] DPI [12:37:32] [PASSED] Writeback [12:37:32] [PASSED] SPI [12:37:32] [PASSED] USB [12:37:32] ===== [PASSED] drm_test_drmm_connector_init_type_valid ===== [12:37:32] =============== [PASSED] drmm_connector_init =============== [12:37:32] ========= drm_connector_dynamic_init (6 subtests) ========== [12:37:32] [PASSED] drm_test_drm_connector_dynamic_init [12:37:32] [PASSED] drm_test_drm_connector_dynamic_init_null_ddc [12:37:32] [PASSED] drm_test_drm_connector_dynamic_init_not_added [12:37:32] [PASSED] drm_test_drm_connector_dynamic_init_properties [12:37:32] ===== drm_test_drm_connector_dynamic_init_type_valid ====== [12:37:32] [PASSED] Unknown [12:37:32] [PASSED] VGA [12:37:32] [PASSED] DVI-I [12:37:32] [PASSED] DVI-D [12:37:32] [PASSED] DVI-A [12:37:32] [PASSED] Composite [12:37:32] [PASSED] SVIDEO [12:37:32] [PASSED] LVDS [12:37:32] [PASSED] Component [12:37:32] [PASSED] DIN [12:37:32] [PASSED] DP [12:37:32] [PASSED] HDMI-A [12:37:32] [PASSED] HDMI-B [12:37:32] [PASSED] TV [12:37:32] [PASSED] eDP [12:37:32] [PASSED] Virtual [12:37:32] [PASSED] DSI [12:37:32] [PASSED] DPI [12:37:32] [PASSED] Writeback [12:37:32] [PASSED] SPI [12:37:32] [PASSED] USB [12:37:32] = [PASSED] drm_test_drm_connector_dynamic_init_type_valid == [12:37:32] ======== drm_test_drm_connector_dynamic_init_name ========= [12:37:32] [PASSED] Unknown [12:37:32] [PASSED] VGA [12:37:32] [PASSED] DVI-I [12:37:32] [PASSED] DVI-D [12:37:32] [PASSED] DVI-A [12:37:32] [PASSED] Composite [12:37:32] [PASSED] SVIDEO [12:37:32] [PASSED] LVDS [12:37:32] [PASSED] Component [12:37:32] [PASSED] DIN [12:37:32] [PASSED] DP [12:37:32] [PASSED] HDMI-A [12:37:32] [PASSED] HDMI-B [12:37:32] [PASSED] TV [12:37:32] [PASSED] eDP [12:37:32] [PASSED] Virtual [12:37:32] [PASSED] DSI [12:37:32] [PASSED] DPI [12:37:32] [PASSED] Writeback [12:37:32] [PASSED] SPI [12:37:32] [PASSED] USB [12:37:32] ==== [PASSED] drm_test_drm_connector_dynamic_init_name ===== [12:37:32] =========== [PASSED] drm_connector_dynamic_init ============ [12:37:32] ==== drm_connector_dynamic_register_early (4 subtests) ===== [12:37:32] [PASSED] drm_test_drm_connector_dynamic_register_early_on_list [12:37:32] [PASSED] drm_test_drm_connector_dynamic_register_early_defer [12:37:32] [PASSED] drm_test_drm_connector_dynamic_register_early_no_init [12:37:32] [PASSED] drm_test_drm_connector_dynamic_register_early_no_mode_object [12:37:32] ====== [PASSED] drm_connector_dynamic_register_early ======= [12:37:32] ======= drm_connector_dynamic_register (7 subtests) ======== [12:37:32] [PASSED] drm_test_drm_connector_dynamic_register_on_list [12:37:32] [PASSED] drm_test_drm_connector_dynamic_register_no_defer [12:37:32] [PASSED] drm_test_drm_connector_dynamic_register_no_init [12:37:32] [PASSED] drm_test_drm_connector_dynamic_register_mode_object [12:37:32] [PASSED] drm_test_drm_connector_dynamic_register_sysfs [12:37:32] [PASSED] drm_test_drm_connector_dynamic_register_sysfs_name [12:37:32] [PASSED] drm_test_drm_connector_dynamic_register_debugfs [12:37:32] ========= [PASSED] drm_connector_dynamic_register ========== [12:37:32] = drm_connector_attach_broadcast_rgb_property (2 subtests) = [12:37:32] [PASSED] drm_test_drm_connector_attach_broadcast_rgb_property [12:37:32] [PASSED] drm_test_drm_connector_attach_broadcast_rgb_property_hdmi_connector [12:37:32] === [PASSED] drm_connector_attach_broadcast_rgb_property === [12:37:32] ========== drm_get_tv_mode_from_name (2 subtests) ========== [12:37:32] ========== drm_test_get_tv_mode_from_name_valid =========== [12:37:32] [PASSED] NTSC [12:37:32] [PASSED] NTSC-443 [12:37:32] [PASSED] NTSC-J [12:37:32] [PASSED] PAL [12:37:32] [PASSED] PAL-M [12:37:32] [PASSED] PAL-N [12:37:32] [PASSED] SECAM [12:37:32] [PASSED] Mono [12:37:32] ====== [PASSED] drm_test_get_tv_mode_from_name_valid ======= [12:37:32] [PASSED] drm_test_get_tv_mode_from_name_truncated [12:37:32] ============ [PASSED] drm_get_tv_mode_from_name ============ [12:37:32] = drm_test_connector_hdmi_compute_mode_clock (12 subtests) = [12:37:32] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb [12:37:32] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_10bpc [12:37:32] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_10bpc_vic_1 [12:37:32] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_12bpc [12:37:32] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_12bpc_vic_1 [12:37:32] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_double [12:37:32] = drm_test_connector_hdmi_compute_mode_clock_yuv420_valid = [12:37:32] [PASSED] VIC 96 [12:37:32] [PASSED] VIC 97 [12:37:32] [PASSED] VIC 101 [12:37:32] [PASSED] VIC 102 [12:37:32] [PASSED] VIC 106 [12:37:32] [PASSED] VIC 107 [12:37:32] === [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv420_valid === [12:37:32] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv420_10_bpc [12:37:32] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv420_12_bpc [12:37:32] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv422_8_bpc [12:37:32] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv422_10_bpc [12:37:32] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv422_12_bpc [12:37:32] === [PASSED] drm_test_connector_hdmi_compute_mode_clock ==== [12:37:32] == drm_hdmi_connector_get_broadcast_rgb_name (2 subtests) == [12:37:32] === drm_test_drm_hdmi_connector_get_broadcast_rgb_name ==== [12:37:32] [PASSED] Automatic [12:37:32] [PASSED] Full [12:37:32] [PASSED] Limited 16:235 [12:37:32] === [PASSED] drm_test_drm_hdmi_connector_get_broadcast_rgb_name === [12:37:32] [PASSED] drm_test_drm_hdmi_connector_get_broadcast_rgb_name_invalid [12:37:32] ==== [PASSED] drm_hdmi_connector_get_broadcast_rgb_name ==== [12:37:32] == drm_hdmi_connector_get_output_format_name (2 subtests) == [12:37:32] === drm_test_drm_hdmi_connector_get_output_format_name ==== [12:37:32] [PASSED] RGB [12:37:32] [PASSED] YUV 4:2:0 [12:37:32] [PASSED] YUV 4:2:2 [12:37:32] [PASSED] YUV 4:4:4 [12:37:32] === [PASSED] drm_test_drm_hdmi_connector_get_output_format_name === [12:37:32] [PASSED] drm_test_drm_hdmi_connector_get_output_format_name_invalid [12:37:32] ==== [PASSED] drm_hdmi_connector_get_output_format_name ==== [12:37:32] ============= drm_damage_helper (21 subtests) ============== [12:37:32] [PASSED] drm_test_damage_iter_no_damage [12:37:32] [PASSED] drm_test_damage_iter_no_damage_fractional_src [12:37:32] [PASSED] drm_test_damage_iter_no_damage_src_moved [12:37:32] [PASSED] drm_test_damage_iter_no_damage_fractional_src_moved [12:37:32] [PASSED] drm_test_damage_iter_no_damage_not_visible [12:37:32] [PASSED] drm_test_damage_iter_no_damage_no_crtc [12:37:32] [PASSED] drm_test_damage_iter_no_damage_no_fb [12:37:32] [PASSED] drm_test_damage_iter_simple_damage [12:37:32] [PASSED] drm_test_damage_iter_single_damage [12:37:32] [PASSED] drm_test_damage_iter_single_damage_intersect_src [12:37:32] [PASSED] drm_test_damage_iter_single_damage_outside_src [12:37:32] [PASSED] drm_test_damage_iter_single_damage_fractional_src [12:37:32] [PASSED] drm_test_damage_iter_single_damage_intersect_fractional_src [12:37:32] [PASSED] drm_test_damage_iter_single_damage_outside_fractional_src [12:37:32] [PASSED] drm_test_damage_iter_single_damage_src_moved [12:37:32] [PASSED] drm_test_damage_iter_single_damage_fractional_src_moved [12:37:32] [PASSED] drm_test_damage_iter_damage [12:37:32] [PASSED] drm_test_damage_iter_damage_one_intersect [12:37:32] [PASSED] drm_test_damage_iter_damage_one_outside [12:37:32] [PASSED] drm_test_damage_iter_damage_src_moved [12:37:32] [PASSED] drm_test_damage_iter_damage_not_visible [12:37:32] ================ [PASSED] drm_damage_helper ================ [12:37:32] ============== drm_dp_mst_helper (3 subtests) ============== [12:37:32] ============== drm_test_dp_mst_calc_pbn_mode ============== [12:37:32] [PASSED] Clock 154000 BPP 30 DSC disabled [12:37:32] [PASSED] Clock 234000 BPP 30 DSC disabled [12:37:32] [PASSED] Clock 297000 BPP 24 DSC disabled [12:37:32] [PASSED] Clock 332880 BPP 24 DSC enabled [12:37:32] [PASSED] Clock 324540 BPP 24 DSC enabled [12:37:32] ========== [PASSED] drm_test_dp_mst_calc_pbn_mode ========== [12:37:32] ============== drm_test_dp_mst_calc_pbn_div =============== [12:37:32] [PASSED] Link rate 2000000 lane count 4 [12:37:32] [PASSED] Link rate 2000000 lane count 2 [12:37:32] [PASSED] Link rate 2000000 lane count 1 [12:37:32] [PASSED] Link rate 1350000 lane count 4 [12:37:32] [PASSED] Link rate 1350000 lane count 2 [12:37:32] [PASSED] Link rate 1350000 lane count 1 [12:37:32] [PASSED] Link rate 1000000 lane count 4 [12:37:32] [PASSED] Link rate 1000000 lane count 2 [12:37:32] [PASSED] Link rate 1000000 lane count 1 [12:37:32] [PASSED] Link rate 810000 lane count 4 [12:37:32] [PASSED] Link rate 810000 lane count 2 [12:37:32] [PASSED] Link rate 810000 lane count 1 [12:37:32] [PASSED] Link rate 540000 lane count 4 [12:37:32] [PASSED] Link rate 540000 lane count 2 [12:37:32] [PASSED] Link rate 540000 lane count 1 [12:37:32] [PASSED] Link rate 270000 lane count 4 [12:37:32] [PASSED] Link rate 270000 lane count 2 [12:37:32] [PASSED] Link rate 270000 lane count 1 [12:37:32] [PASSED] Link rate 162000 lane count 4 [12:37:32] [PASSED] Link rate 162000 lane count 2 [12:37:32] [PASSED] Link rate 162000 lane count 1 [12:37:32] ========== [PASSED] drm_test_dp_mst_calc_pbn_div =========== [12:37:32] ========= drm_test_dp_mst_sideband_msg_req_decode ========= [12:37:32] [PASSED] DP_ENUM_PATH_RESOURCES with port number [12:37:32] [PASSED] DP_POWER_UP_PHY with port number [12:37:32] [PASSED] DP_POWER_DOWN_PHY with port number [12:37:32] [PASSED] DP_ALLOCATE_PAYLOAD with SDP stream sinks [12:37:32] [PASSED] DP_ALLOCATE_PAYLOAD with port number [12:37:32] [PASSED] DP_ALLOCATE_PAYLOAD with VCPI [12:37:32] [PASSED] DP_ALLOCATE_PAYLOAD with PBN [12:37:32] [PASSED] DP_QUERY_PAYLOAD with port number [12:37:32] [PASSED] DP_QUERY_PAYLOAD with VCPI [12:37:32] [PASSED] DP_REMOTE_DPCD_READ with port number [12:37:32] [PASSED] DP_REMOTE_DPCD_READ with DPCD address [12:37:32] [PASSED] DP_REMOTE_DPCD_READ with max number of bytes [12:37:32] [PASSED] DP_REMOTE_DPCD_WRITE with port number [12:37:32] [PASSED] DP_REMOTE_DPCD_WRITE with DPCD address [12:37:32] [PASSED] DP_REMOTE_DPCD_WRITE with data array [12:37:32] [PASSED] DP_REMOTE_I2C_READ with port number [12:37:32] [PASSED] DP_REMOTE_I2C_READ with I2C device ID [12:37:32] [PASSED] DP_REMOTE_I2C_READ with transactions array [12:37:32] [PASSED] DP_REMOTE_I2C_WRITE with port number [12:37:32] [PASSED] DP_REMOTE_I2C_WRITE with I2C device ID [12:37:32] [PASSED] DP_REMOTE_I2C_WRITE with data array [12:37:32] [PASSED] DP_QUERY_STREAM_ENC_STATUS with stream ID [12:37:32] [PASSED] DP_QUERY_STREAM_ENC_STATUS with client ID [12:37:32] [PASSED] DP_QUERY_STREAM_ENC_STATUS with stream event [12:37:32] [PASSED] DP_QUERY_STREAM_ENC_STATUS with valid stream event [12:37:32] [PASSED] DP_QUERY_STREAM_ENC_STATUS with stream behavior [12:37:32] [PASSED] DP_QUERY_STREAM_ENC_STATUS with a valid stream behavior [12:37:32] ===== [PASSED] drm_test_dp_mst_sideband_msg_req_decode ===== [12:37:32] ================ [PASSED] drm_dp_mst_helper ================ [12:37:32] ================== drm_exec (7 subtests) =================== [12:37:32] [PASSED] sanitycheck [12:37:32] [PASSED] test_lock [12:37:32] [PASSED] test_lock_unlock [12:37:32] [PASSED] test_duplicates [12:37:32] [PASSED] test_prepare [12:37:32] [PASSED] test_prepare_array [12:37:32] [PASSED] test_multiple_loops [12:37:32] ==================== [PASSED] drm_exec ===================== [12:37:32] =========== drm_format_helper_test (17 subtests) =========== [12:37:32] ============== drm_test_fb_xrgb8888_to_gray8 ============== [12:37:32] [PASSED] single_pixel_source_buffer [12:37:32] [PASSED] single_pixel_clip_rectangle [12:37:32] [PASSED] well_known_colors [12:37:32] [PASSED] destination_pitch [12:37:32] ========== [PASSED] drm_test_fb_xrgb8888_to_gray8 ========== [12:37:32] ============= drm_test_fb_xrgb8888_to_rgb332 ============== [12:37:32] [PASSED] single_pixel_source_buffer [12:37:32] [PASSED] single_pixel_clip_rectangle [12:37:32] [PASSED] well_known_colors [12:37:32] [PASSED] destination_pitch [12:37:32] ========= [PASSED] drm_test_fb_xrgb8888_to_rgb332 ========== [12:37:32] ============= drm_test_fb_xrgb8888_to_rgb565 ============== [12:37:32] [PASSED] single_pixel_source_buffer [12:37:32] [PASSED] single_pixel_clip_rectangle [12:37:32] [PASSED] well_known_colors [12:37:32] [PASSED] destination_pitch [12:37:32] ========= [PASSED] drm_test_fb_xrgb8888_to_rgb565 ========== [12:37:32] ============ drm_test_fb_xrgb8888_to_xrgb1555 ============= [12:37:32] [PASSED] single_pixel_source_buffer [12:37:32] [PASSED] single_pixel_clip_rectangle [12:37:32] [PASSED] well_known_colors [12:37:32] [PASSED] destination_pitch [12:37:32] ======== [PASSED] drm_test_fb_xrgb8888_to_xrgb1555 ========= [12:37:32] ============ drm_test_fb_xrgb8888_to_argb1555 ============= [12:37:32] [PASSED] single_pixel_source_buffer [12:37:32] [PASSED] single_pixel_clip_rectangle [12:37:32] [PASSED] well_known_colors [12:37:32] [PASSED] destination_pitch [12:37:32] ======== [PASSED] drm_test_fb_xrgb8888_to_argb1555 ========= [12:37:32] ============ drm_test_fb_xrgb8888_to_rgba5551 ============= [12:37:32] [PASSED] single_pixel_source_buffer [12:37:32] [PASSED] single_pixel_clip_rectangle [12:37:32] [PASSED] well_known_colors [12:37:32] [PASSED] destination_pitch [12:37:32] ======== [PASSED] drm_test_fb_xrgb8888_to_rgba5551 ========= [12:37:32] ============= drm_test_fb_xrgb8888_to_rgb888 ============== [12:37:32] [PASSED] single_pixel_source_buffer [12:37:32] [PASSED] single_pixel_clip_rectangle [12:37:32] [PASSED] well_known_colors [12:37:32] [PASSED] destination_pitch [12:37:32] ========= [PASSED] drm_test_fb_xrgb8888_to_rgb888 ========== [12:37:32] ============= drm_test_fb_xrgb8888_to_bgr888 ============== [12:37:32] [PASSED] single_pixel_source_buffer [12:37:32] [PASSED] single_pixel_clip_rectangle [12:37:32] [PASSED] well_known_colors [12:37:32] [PASSED] destination_pitch [12:37:32] ========= [PASSED] drm_test_fb_xrgb8888_to_bgr888 ========== [12:37:32] ============ drm_test_fb_xrgb8888_to_argb8888 ============= [12:37:32] [PASSED] single_pixel_source_buffer [12:37:32] [PASSED] single_pixel_clip_rectangle [12:37:32] [PASSED] well_known_colors [12:37:32] [PASSED] destination_pitch [12:37:32] ======== [PASSED] drm_test_fb_xrgb8888_to_argb8888 ========= [12:37:32] =========== drm_test_fb_xrgb8888_to_xrgb2101010 =========== [12:37:32] [PASSED] single_pixel_source_buffer [12:37:32] [PASSED] single_pixel_clip_rectangle [12:37:32] [PASSED] well_known_colors [12:37:32] [PASSED] destination_pitch [12:37:32] ======= [PASSED] drm_test_fb_xrgb8888_to_xrgb2101010 ======= [12:37:32] =========== drm_test_fb_xrgb8888_to_argb2101010 =========== [12:37:32] [PASSED] single_pixel_source_buffer [12:37:32] [PASSED] single_pixel_clip_rectangle [12:37:32] [PASSED] well_known_colors [12:37:32] [PASSED] destination_pitch [12:37:32] ======= [PASSED] drm_test_fb_xrgb8888_to_argb2101010 ======= [12:37:32] ============== drm_test_fb_xrgb8888_to_mono =============== [12:37:32] [PASSED] single_pixel_source_buffer [12:37:32] [PASSED] single_pixel_clip_rectangle [12:37:32] [PASSED] well_known_colors [12:37:32] [PASSED] destination_pitch [12:37:32] ========== [PASSED] drm_test_fb_xrgb8888_to_mono =========== [12:37:32] ==================== drm_test_fb_swab ===================== [12:37:32] [PASSED] single_pixel_source_buffer [12:37:32] [PASSED] single_pixel_clip_rectangle [12:37:32] [PASSED] well_known_colors [12:37:32] [PASSED] destination_pitch [12:37:32] ================ [PASSED] drm_test_fb_swab ================= [12:37:32] ============ drm_test_fb_xrgb8888_to_xbgr8888 ============= [12:37:32] [PASSED] single_pixel_source_buffer [12:37:32] [PASSED] single_pixel_clip_rectangle [12:37:32] [PASSED] well_known_colors [12:37:32] [PASSED] destination_pitch [12:37:32] ======== [PASSED] drm_test_fb_xrgb8888_to_xbgr8888 ========= [12:37:32] ============ drm_test_fb_xrgb8888_to_abgr8888 ============= [12:37:32] [PASSED] single_pixel_source_buffer [12:37:32] [PASSED] single_pixel_clip_rectangle [12:37:32] [PASSED] well_known_colors [12:37:32] [PASSED] destination_pitch [12:37:32] ======== [PASSED] drm_test_fb_xrgb8888_to_abgr8888 ========= [12:37:32] ================= drm_test_fb_clip_offset ================= [12:37:32] [PASSED] pass through [12:37:32] [PASSED] horizontal offset [12:37:32] [PASSED] vertical offset [12:37:32] [PASSED] horizontal and vertical offset [12:37:32] [PASSED] horizontal offset (custom pitch) [12:37:32] [PASSED] vertical offset (custom pitch) [12:37:32] [PASSED] horizontal and vertical offset (custom pitch) [12:37:32] ============= [PASSED] drm_test_fb_clip_offset ============= [12:37:32] =================== drm_test_fb_memcpy ==================== [12:37:32] [PASSED] single_pixel_source_buffer: XR24 little-endian (0x34325258) [12:37:32] [PASSED] single_pixel_source_buffer: XRA8 little-endian (0x38415258) [12:37:32] [PASSED] single_pixel_source_buffer: YU24 little-endian (0x34325559) [12:37:32] [PASSED] single_pixel_clip_rectangle: XB24 little-endian (0x34324258) [12:37:32] [PASSED] single_pixel_clip_rectangle: XRA8 little-endian (0x38415258) [12:37:32] [PASSED] single_pixel_clip_rectangle: YU24 little-endian (0x34325559) [12:37:32] [PASSED] well_known_colors: XB24 little-endian (0x34324258) [12:37:32] [PASSED] well_known_colors: XRA8 little-endian (0x38415258) [12:37:32] [PASSED] well_known_colors: YU24 little-endian (0x34325559) [12:37:32] [PASSED] destination_pitch: XB24 little-endian (0x34324258) [12:37:32] [PASSED] destination_pitch: XRA8 little-endian (0x38415258) [12:37:32] [PASSED] destination_pitch: YU24 little-endian (0x34325559) [12:37:32] =============== [PASSED] drm_test_fb_memcpy ================ [12:37:32] ============= [PASSED] drm_format_helper_test ============== [12:37:32] ================= drm_format (18 subtests) ================= [12:37:32] [PASSED] drm_test_format_block_width_invalid [12:37:32] [PASSED] drm_test_format_block_width_one_plane [12:37:32] [PASSED] drm_test_format_block_width_two_plane [12:37:32] [PASSED] drm_test_format_block_width_three_plane [12:37:32] [PASSED] drm_test_format_block_width_tiled [12:37:32] [PASSED] drm_test_format_block_height_invalid [12:37:32] [PASSED] drm_test_format_block_height_one_plane [12:37:32] [PASSED] drm_test_format_block_height_two_plane [12:37:32] [PASSED] drm_test_format_block_height_three_plane [12:37:32] [PASSED] drm_test_format_block_height_tiled [12:37:32] [PASSED] drm_test_format_min_pitch_invalid [12:37:32] [PASSED] drm_test_format_min_pitch_one_plane_8bpp [12:37:32] [PASSED] drm_test_format_min_pitch_one_plane_16bpp [12:37:32] [PASSED] drm_test_format_min_pitch_one_plane_24bpp [12:37:32] [PASSED] drm_test_format_min_pitch_one_plane_32bpp [12:37:32] [PASSED] drm_test_format_min_pitch_two_plane [12:37:32] [PASSED] drm_test_format_min_pitch_three_plane_8bpp [12:37:32] [PASSED] drm_test_format_min_pitch_tiled [12:37:32] =================== [PASSED] drm_format ==================== [12:37:32] ============== drm_framebuffer (10 subtests) =============== [12:37:32] ========== drm_test_framebuffer_check_src_coords ========== [12:37:32] [PASSED] Success: source fits into fb [12:37:32] [PASSED] Fail: overflowing fb with x-axis coordinate [12:37:32] [PASSED] Fail: overflowing fb with y-axis coordinate [12:37:32] [PASSED] Fail: overflowing fb with source width [12:37:32] [PASSED] Fail: overflowing fb with source height [12:37:32] ====== [PASSED] drm_test_framebuffer_check_src_coords ====== [12:37:32] [PASSED] drm_test_framebuffer_cleanup [12:37:32] =============== drm_test_framebuffer_create =============== [12:37:32] [PASSED] ABGR8888 normal sizes [12:37:32] [PASSED] ABGR8888 max sizes [12:37:32] [PASSED] ABGR8888 pitch greater than min required [12:37:32] [PASSED] ABGR8888 pitch less than min required [12:37:32] [PASSED] ABGR8888 Invalid width [12:37:32] [PASSED] ABGR8888 Invalid buffer handle [12:37:32] [PASSED] No pixel format [12:37:32] [PASSED] ABGR8888 Width 0 [12:37:32] [PASSED] ABGR8888 Height 0 [12:37:32] [PASSED] ABGR8888 Out of bound height * pitch combination [12:37:32] [PASSED] ABGR8888 Large buffer offset [12:37:32] [PASSED] ABGR8888 Buffer offset for inexistent plane [12:37:32] [PASSED] ABGR8888 Invalid flag [12:37:32] [PASSED] ABGR8888 Set DRM_MODE_FB_MODIFIERS without modifiers [12:37:32] [PASSED] ABGR8888 Valid buffer modifier [12:37:32] [PASSED] ABGR8888 Invalid buffer modifier(DRM_FORMAT_MOD_SAMSUNG_64_32_TILE) [12:37:32] [PASSED] ABGR8888 Extra pitches without DRM_MODE_FB_MODIFIERS [12:37:32] [PASSED] ABGR8888 Extra pitches with DRM_MODE_FB_MODIFIERS [12:37:32] [PASSED] NV12 Normal sizes [12:37:32] [PASSED] NV12 Max sizes [12:37:32] [PASSED] NV12 Invalid pitch [12:37:32] [PASSED] NV12 Invalid modifier/missing DRM_MODE_FB_MODIFIERS flag [12:37:32] [PASSED] NV12 different modifier per-plane [12:37:32] [PASSED] NV12 with DRM_FORMAT_MOD_SAMSUNG_64_32_TILE [12:37:32] [PASSED] NV12 Valid modifiers without DRM_MODE_FB_MODIFIERS [12:37:32] [PASSED] NV12 Modifier for inexistent plane [12:37:32] [PASSED] NV12 Handle for inexistent plane [12:37:32] [PASSED] NV12 Handle for inexistent plane without DRM_MODE_FB_MODIFIERS [12:37:32] [PASSED] YVU420 DRM_MODE_FB_MODIFIERS set without modifier [12:37:32] [PASSED] YVU420 Normal sizes [12:37:32] [PASSED] YVU420 Max sizes [12:37:32] [PASSED] YVU420 Invalid pitch [12:37:32] [PASSED] YVU420 Different pitches [12:37:32] [PASSED] YVU420 Different buffer offsets/pitches [12:37:32] [PASSED] YVU420 Modifier set just for plane 0, without DRM_MODE_FB_MODIFIERS [12:37:32] [PASSED] YVU420 Modifier set just for planes 0, 1, without DRM_MODE_FB_MODIFIERS [12:37:32] [PASSED] YVU420 Modifier set just for plane 0, 1, with DRM_MODE_FB_MODIFIERS [12:37:32] [PASSED] YVU420 Valid modifier [12:37:32] [PASSED] YVU420 Different modifiers per plane [12:37:32] [PASSED] YVU420 Modifier for inexistent plane [12:37:32] [PASSED] YUV420_10BIT Invalid modifier(DRM_FORMAT_MOD_LINEAR) [12:37:32] [PASSED] X0L2 Normal sizes [12:37:32] [PASSED] X0L2 Max sizes [12:37:32] [PASSED] X0L2 Invalid pitch [12:37:32] [PASSED] X0L2 Pitch greater than minimum required [12:37:32] [PASSED] X0L2 Handle for inexistent plane [12:37:32] [PASSED] X0L2 Offset for inexistent plane, without DRM_MODE_FB_MODIFIERS set [12:37:32] [PASSED] X0L2 Modifier without DRM_MODE_FB_MODIFIERS set [12:37:32] [PASSED] X0L2 Valid modifier [12:37:32] [PASSED] X0L2 Modifier for inexistent plane [12:37:32] =========== [PASSED] drm_test_framebuffer_create =========== [12:37:32] [PASSED] drm_test_framebuffer_free [12:37:32] [PASSED] drm_test_framebuffer_init [12:37:32] [PASSED] drm_test_framebuffer_init_bad_format [12:37:32] [PASSED] drm_test_framebuffer_init_dev_mismatch [12:37:32] [PASSED] drm_test_framebuffer_lookup [12:37:32] [PASSED] drm_test_framebuffer_lookup_inexistent [12:37:32] [PASSED] drm_test_framebuffer_modifiers_not_supported [12:37:32] ================= [PASSED] drm_framebuffer ================= [12:37:32] ================ drm_gem_shmem (8 subtests) ================ [12:37:32] [PASSED] drm_gem_shmem_test_obj_create [12:37:32] [PASSED] drm_gem_shmem_test_obj_create_private [12:37:32] [PASSED] drm_gem_shmem_test_pin_pages [12:37:32] [PASSED] drm_gem_shmem_test_vmap [12:37:32] [PASSED] drm_gem_shmem_test_get_pages_sgt [12:37:32] [PASSED] drm_gem_shmem_test_get_sg_table [12:37:32] [PASSED] drm_gem_shmem_test_madvise [12:37:32] [PASSED] drm_gem_shmem_test_purge [12:37:32] ================== [PASSED] drm_gem_shmem ================== [12:37:32] === drm_atomic_helper_connector_hdmi_check (27 subtests) === [12:37:32] [PASSED] drm_test_check_broadcast_rgb_auto_cea_mode [12:37:32] [PASSED] drm_test_check_broadcast_rgb_auto_cea_mode_vic_1 [12:37:32] [PASSED] drm_test_check_broadcast_rgb_full_cea_mode [12:37:32] [PASSED] drm_test_check_broadcast_rgb_full_cea_mode_vic_1 [12:37:32] [PASSED] drm_test_check_broadcast_rgb_limited_cea_mode [12:37:32] [PASSED] drm_test_check_broadcast_rgb_limited_cea_mode_vic_1 [12:37:32] ====== drm_test_check_broadcast_rgb_cea_mode_yuv420 ======= [12:37:32] [PASSED] Automatic [12:37:32] [PASSED] Full [12:37:32] [PASSED] Limited 16:235 [12:37:32] == [PASSED] drm_test_check_broadcast_rgb_cea_mode_yuv420 === [12:37:32] [PASSED] drm_test_check_broadcast_rgb_crtc_mode_changed [12:37:32] [PASSED] drm_test_check_broadcast_rgb_crtc_mode_not_changed [12:37:32] [PASSED] drm_test_check_disable_connector [12:37:32] [PASSED] drm_test_check_hdmi_funcs_reject_rate [12:37:32] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_rgb [12:37:32] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_yuv420 [12:37:32] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_ignore_yuv422 [12:37:32] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_ignore_yuv420 [12:37:32] [PASSED] drm_test_check_driver_unsupported_fallback_yuv420 [12:37:32] [PASSED] drm_test_check_output_bpc_crtc_mode_changed [12:37:32] [PASSED] drm_test_check_output_bpc_crtc_mode_not_changed [12:37:32] [PASSED] drm_test_check_output_bpc_dvi [12:37:32] [PASSED] drm_test_check_output_bpc_format_vic_1 [12:37:32] [PASSED] drm_test_check_output_bpc_format_display_8bpc_only [12:37:32] [PASSED] drm_test_check_output_bpc_format_display_rgb_only [12:37:32] [PASSED] drm_test_check_output_bpc_format_driver_8bpc_only [12:37:32] [PASSED] drm_test_check_output_bpc_format_driver_rgb_only [12:37:32] [PASSED] drm_test_check_tmds_char_rate_rgb_8bpc [12:37:32] [PASSED] drm_test_check_tmds_char_rate_rgb_10bpc [12:37:32] [PASSED] drm_test_check_tmds_char_rate_rgb_12bpc [12:37:32] ===== [PASSED] drm_atomic_helper_connector_hdmi_check ====== [12:37:32] === drm_atomic_helper_connector_hdmi_reset (6 subtests) ==== [12:37:32] [PASSED] drm_test_check_broadcast_rgb_value [12:37:32] [PASSED] drm_test_check_bpc_8_value [12:37:32] [PASSED] drm_test_check_bpc_10_value [12:37:32] [PASSED] drm_test_check_bpc_12_value [12:37:32] [PASSED] drm_test_check_format_value [12:37:32] [PASSED] drm_test_check_tmds_char_value [12:37:32] ===== [PASSED] drm_atomic_helper_connector_hdmi_reset ====== [12:37:32] = drm_atomic_helper_connector_hdmi_mode_valid (4 subtests) = [12:37:32] [PASSED] drm_test_check_mode_valid [12:37:32] [PASSED] drm_test_check_mode_valid_reject [12:37:32] [PASSED] drm_test_check_mode_valid_reject_rate [12:37:32] [PASSED] drm_test_check_mode_valid_reject_max_clock [12:37:32] === [PASSED] drm_atomic_helper_connector_hdmi_mode_valid === [12:37:32] ================= drm_managed (2 subtests) ================= [12:37:32] [PASSED] drm_test_managed_release_action [12:37:32] [PASSED] drm_test_managed_run_action [12:37:32] =================== [PASSED] drm_managed =================== [12:37:32] =================== drm_mm (6 subtests) ==================== [12:37:32] [PASSED] drm_test_mm_init [12:37:32] [PASSED] drm_test_mm_debug [12:37:32] [PASSED] drm_test_mm_align32 [12:37:32] [PASSED] drm_test_mm_align64 [12:37:32] [PASSED] drm_test_mm_lowest [12:37:32] [PASSED] drm_test_mm_highest [12:37:32] ===================== [PASSED] drm_mm ====================== [12:37:32] ============= drm_modes_analog_tv (5 subtests) ============= [12:37:32] [PASSED] drm_test_modes_analog_tv_mono_576i [12:37:32] [PASSED] drm_test_modes_analog_tv_ntsc_480i [12:37:32] [PASSED] drm_test_modes_analog_tv_ntsc_480i_inlined [12:37:32] [PASSED] drm_test_modes_analog_tv_pal_576i [12:37:32] [PASSED] drm_test_modes_analog_tv_pal_576i_inlined [12:37:32] =============== [PASSED] drm_modes_analog_tv =============== [12:37:32] ============== drm_plane_helper (2 subtests) =============== [12:37:32] =============== drm_test_check_plane_state ================ [12:37:32] [PASSED] clipping_simple [12:37:32] [PASSED] clipping_rotate_reflect [12:37:32] [PASSED] positioning_simple [12:37:32] [PASSED] upscaling [12:37:32] [PASSED] downscaling [12:37:32] [PASSED] rounding1 [12:37:32] [PASSED] rounding2 [12:37:32] [PASSED] rounding3 [12:37:32] [PASSED] rounding4 [12:37:32] =========== [PASSED] drm_test_check_plane_state ============ [12:37:32] =========== drm_test_check_invalid_plane_state ============ [12:37:32] [PASSED] positioning_invalid [12:37:32] [PASSED] upscaling_invalid [12:37:32] [PASSED] downscaling_invalid [12:37:32] ======= [PASSED] drm_test_check_invalid_plane_state ======== [12:37:32] ================ [PASSED] drm_plane_helper ================= [12:37:32] ====== drm_connector_helper_tv_get_modes (1 subtest) ======= [12:37:32] ====== drm_test_connector_helper_tv_get_modes_check ======= [12:37:32] [PASSED] None [12:37:32] [PASSED] PAL [12:37:32] [PASSED] NTSC [12:37:32] [PASSED] Both, NTSC Default [12:37:32] [PASSED] Both, PAL Default [12:37:32] [PASSED] Both, NTSC Default, with PAL on command-line [12:37:32] [PASSED] Both, PAL Default, with NTSC on command-line [12:37:32] == [PASSED] drm_test_connector_helper_tv_get_modes_check === [12:37:32] ======== [PASSED] drm_connector_helper_tv_get_modes ======== [12:37:32] ================== drm_rect (9 subtests) =================== [12:37:32] [PASSED] drm_test_rect_clip_scaled_div_by_zero [12:37:32] [PASSED] drm_test_rect_clip_scaled_not_clipped [12:37:32] [PASSED] drm_test_rect_clip_scaled_clipped [12:37:32] [PASSED] drm_test_rect_clip_scaled_signed_vs_unsigned [12:37:32] ================= drm_test_rect_intersect ================= [12:37:32] [PASSED] top-left x bottom-right: 2x2+1+1 x 2x2+0+0 [12:37:32] [PASSED] top-right x bottom-left: 2x2+0+0 x 2x2+1-1 [12:37:32] [PASSED] bottom-left x top-right: 2x2+1-1 x 2x2+0+0 [12:37:32] [PASSED] bottom-right x top-left: 2x2+0+0 x 2x2+1+1 [12:37:32] [PASSED] right x left: 2x1+0+0 x 3x1+1+0 [12:37:32] [PASSED] left x right: 3x1+1+0 x 2x1+0+0 [12:37:32] [PASSED] up x bottom: 1x2+0+0 x 1x3+0-1 [12:37:32] [PASSED] bottom x up: 1x3+0-1 x 1x2+0+0 [12:37:32] [PASSED] touching corner: 1x1+0+0 x 2x2+1+1 [12:37:32] [PASSED] touching side: 1x1+0+0 x 1x1+1+0 [12:37:32] [PASSED] equal rects: 2x2+0+0 x 2x2+0+0 [12:37:32] [PASSED] inside another: 2x2+0+0 x 1x1+1+1 [12:37:32] [PASSED] far away: 1x1+0+0 x 1x1+3+6 [12:37:32] [PASSED] points intersecting: 0x0+5+10 x 0x0+5+10 [12:37:32] [PASSED] points not intersecting: 0x0+0+0 x 0x0+5+10 [12:37:32] ============= [PASSED] drm_test_rect_intersect ============= [12:37:32] ================ drm_test_rect_calc_hscale ================ [12:37:32] [PASSED] normal use [12:37:32] [PASSED] out of max range [12:37:32] [PASSED] out of min range [12:37:32] [PASSED] zero dst [12:37:32] [PASSED] negative src [12:37:32] [PASSED] negative dst [12:37:32] ============ [PASSED] drm_test_rect_calc_hscale ============ [12:37:32] ================ drm_test_rect_calc_vscale ================ [12:37:32] [PASSED] normal use stty: 'standard input': Inappropriate ioctl for device [12:37:32] [PASSED] out of max range [12:37:32] [PASSED] out of min range [12:37:32] [PASSED] zero dst [12:37:32] [PASSED] negative src [12:37:32] [PASSED] negative dst [12:37:32] ============ [PASSED] drm_test_rect_calc_vscale ============ [12:37:32] ================== drm_test_rect_rotate =================== [12:37:32] [PASSED] reflect-x [12:37:32] [PASSED] reflect-y [12:37:32] [PASSED] rotate-0 [12:37:32] [PASSED] rotate-90 [12:37:32] [PASSED] rotate-180 [12:37:32] [PASSED] rotate-270 [12:37:32] ============== [PASSED] drm_test_rect_rotate =============== [12:37:32] ================ drm_test_rect_rotate_inv ================= [12:37:32] [PASSED] reflect-x [12:37:32] [PASSED] reflect-y [12:37:32] [PASSED] rotate-0 [12:37:32] [PASSED] rotate-90 [12:37:32] [PASSED] rotate-180 [12:37:32] [PASSED] rotate-270 [12:37:32] ============ [PASSED] drm_test_rect_rotate_inv ============= [12:37:32] ==================== [PASSED] drm_rect ===================== [12:37:32] ============ drm_sysfb_modeset_test (1 subtest) ============ [12:37:32] ============ drm_test_sysfb_build_fourcc_list ============= [12:37:32] [PASSED] no native formats [12:37:32] [PASSED] XRGB8888 as native format [12:37:32] [PASSED] remove duplicates [12:37:32] [PASSED] convert alpha formats [12:37:32] [PASSED] random formats [12:37:32] ======== [PASSED] drm_test_sysfb_build_fourcc_list ========= [12:37:32] ============= [PASSED] drm_sysfb_modeset_test ============== [12:37:32] ================== drm_fixp (2 subtests) =================== [12:37:32] [PASSED] drm_test_int2fixp [12:37:32] [PASSED] drm_test_sm2fixp [12:37:32] ==================== [PASSED] drm_fixp ===================== [12:37:32] ============================================================ [12:37:32] Testing complete. Ran 624 tests: passed: 624 [12:37:32] Elapsed time: 27.293s total, 1.696s configuring, 25.177s building, 0.378s running
+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/ttm/tests/.kunitconfig [12:37:32] Configuring KUnit Kernel ...
Regenerating .config ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig [12:37:34] Building KUnit Kernel ... Populating config with: $ make ARCH=um O=.kunit olddefconfig Building with: $ make all compile_commands.json scripts_gdb ARCH=um O=.kunit --jobs=48 [12:37:43] Starting KUnit Kernel (1/1)... [12:37:43] ============================================================ Running tests with: $ .kunit/linux kunit.enable=1 mem=1G console=tty kunit_shutdown=halt [12:37:43] ================= ttm_device (5 subtests) ================== [12:37:43] [PASSED] ttm_device_init_basic [12:37:43] [PASSED] ttm_device_init_multiple [12:37:43] [PASSED] ttm_device_fini_basic [12:37:43] [PASSED] ttm_device_init_no_vma_man [12:37:43] ================== ttm_device_init_pools ================== [12:37:43] [PASSED] No DMA allocations, no DMA32 required [12:37:43] [PASSED] DMA allocations, DMA32 required [12:37:43] [PASSED] No DMA allocations, DMA32 required [12:37:43] [PASSED] DMA allocations, no DMA32 required [12:37:43] ============== [PASSED] ttm_device_init_pools ============== [12:37:43] =================== [PASSED] ttm_device ==================== [12:37:43] ================== ttm_pool (8 subtests) =================== [12:37:43] ================== ttm_pool_alloc_basic =================== [12:37:43] [PASSED] One page [12:37:43] [PASSED] More than one page [12:37:43] [PASSED] Above the allocation limit [12:37:43] [PASSED] One page, with coherent DMA mappings enabled [12:37:43] [PASSED] Above the allocation limit, with coherent DMA mappings enabled [12:37:43] ============== [PASSED] ttm_pool_alloc_basic =============== [12:37:43] ============== ttm_pool_alloc_basic_dma_addr ============== [12:37:43] [PASSED] One page [12:37:43] [PASSED] More than one page [12:37:43] [PASSED] Above the allocation limit [12:37:43] [PASSED] One page, with coherent DMA mappings enabled [12:37:43] [PASSED] Above the allocation limit, with coherent DMA mappings enabled [12:37:43] ========== [PASSED] ttm_pool_alloc_basic_dma_addr ========== [12:37:43] [PASSED] ttm_pool_alloc_order_caching_match [12:37:43] [PASSED] ttm_pool_alloc_caching_mismatch [12:37:43] [PASSED] ttm_pool_alloc_order_mismatch [12:37:43] [PASSED] ttm_pool_free_dma_alloc [12:37:43] [PASSED] ttm_pool_free_no_dma_alloc [12:37:43] [PASSED] ttm_pool_fini_basic [12:37:43] ==================== [PASSED] ttm_pool ===================== [12:37:43] ================ ttm_resource (8 subtests) ================= [12:37:43] ================= ttm_resource_init_basic ================= [12:37:43] [PASSED] Init resource in TTM_PL_SYSTEM [12:37:43] [PASSED] Init resource in TTM_PL_VRAM [12:37:43] [PASSED] Init resource in a private placement [12:37:43] [PASSED] Init resource in TTM_PL_SYSTEM, set placement flags [12:37:43] ============= [PASSED] ttm_resource_init_basic ============= [12:37:43] [PASSED] ttm_resource_init_pinned [12:37:43] [PASSED] ttm_resource_fini_basic [12:37:43] [PASSED] ttm_resource_manager_init_basic [12:37:43] [PASSED] ttm_resource_manager_usage_basic [12:37:43] [PASSED] ttm_resource_manager_set_used_basic [12:37:43] [PASSED] ttm_sys_man_alloc_basic [12:37:43] [PASSED] ttm_sys_man_free_basic [12:37:43] ================== [PASSED] ttm_resource =================== [12:37:43] =================== ttm_tt (15 subtests) =================== [12:37:43] ==================== ttm_tt_init_basic ==================== [12:37:43] [PASSED] Page-aligned size [12:37:43] [PASSED] Extra pages requested [12:37:43] ================ [PASSED] ttm_tt_init_basic ================ [12:37:43] [PASSED] ttm_tt_init_misaligned [12:37:43] [PASSED] ttm_tt_fini_basic [12:37:43] [PASSED] ttm_tt_fini_sg [12:37:43] [PASSED] ttm_tt_fini_shmem [12:37:43] [PASSED] ttm_tt_create_basic [12:37:43] [PASSED] ttm_tt_create_invalid_bo_type [12:37:43] [PASSED] ttm_tt_create_ttm_exists [12:37:43] [PASSED] ttm_tt_create_failed [12:37:43] [PASSED] ttm_tt_destroy_basic [12:37:43] [PASSED] ttm_tt_populate_null_ttm [12:37:43] [PASSED] ttm_tt_populate_populated_ttm [12:37:43] [PASSED] ttm_tt_unpopulate_basic [12:37:43] [PASSED] ttm_tt_unpopulate_empty_ttm [12:37:43] [PASSED] ttm_tt_swapin_basic [12:37:43] ===================== [PASSED] ttm_tt ====================== [12:37:43] =================== ttm_bo (14 subtests) =================== [12:37:43] =========== ttm_bo_reserve_optimistic_no_ticket =========== [12:37:43] [PASSED] Cannot be interrupted and sleeps [12:37:43] [PASSED] Cannot be interrupted, locks straight away [12:37:43] [PASSED] Can be interrupted, sleeps [12:37:43] ======= [PASSED] ttm_bo_reserve_optimistic_no_ticket ======= [12:37:43] [PASSED] ttm_bo_reserve_locked_no_sleep [12:37:43] [PASSED] ttm_bo_reserve_no_wait_ticket [12:37:43] [PASSED] ttm_bo_reserve_double_resv [12:37:43] [PASSED] ttm_bo_reserve_interrupted [12:37:43] [PASSED] ttm_bo_reserve_deadlock [12:37:43] [PASSED] ttm_bo_unreserve_basic [12:37:43] [PASSED] ttm_bo_unreserve_pinned [12:37:43] [PASSED] ttm_bo_unreserve_bulk [12:37:43] [PASSED] ttm_bo_fini_basic [12:37:43] [PASSED] ttm_bo_fini_shared_resv [12:37:43] [PASSED] ttm_bo_pin_basic [12:37:43] [PASSED] ttm_bo_pin_unpin_resource [12:37:43] [PASSED] ttm_bo_multiple_pin_one_unpin [12:37:43] ===================== [PASSED] ttm_bo ====================== [12:37:43] ============== ttm_bo_validate (21 subtests) =============== [12:37:43] ============== ttm_bo_init_reserved_sys_man =============== [12:37:43] [PASSED] Buffer object for userspace [12:37:43] [PASSED] Kernel buffer object [12:37:43] [PASSED] Shared buffer object [12:37:43] ========== [PASSED] ttm_bo_init_reserved_sys_man =========== [12:37:43] ============== ttm_bo_init_reserved_mock_man ============== [12:37:43] [PASSED] Buffer object for userspace [12:37:43] [PASSED] Kernel buffer object [12:37:43] [PASSED] Shared buffer object [12:37:43] ========== [PASSED] ttm_bo_init_reserved_mock_man ========== [12:37:43] [PASSED] ttm_bo_init_reserved_resv [12:37:43] ================== ttm_bo_validate_basic ================== [12:37:43] [PASSED] Buffer object for userspace [12:37:43] [PASSED] Kernel buffer object [12:37:43] [PASSED] Shared buffer object [12:37:43] ============== [PASSED] ttm_bo_validate_basic ============== [12:37:43] [PASSED] ttm_bo_validate_invalid_placement [12:37:43] ============= ttm_bo_validate_same_placement ============== [12:37:43] [PASSED] System manager [12:37:43] [PASSED] VRAM manager [12:37:43] ========= [PASSED] ttm_bo_validate_same_placement ========== [12:37:43] [PASSED] ttm_bo_validate_failed_alloc [12:37:43] [PASSED] ttm_bo_validate_pinned [12:37:43] [PASSED] ttm_bo_validate_busy_placement [12:37:43] ================ ttm_bo_validate_multihop ================= [12:37:43] [PASSED] Buffer object for userspace [12:37:43] [PASSED] Kernel buffer object [12:37:43] [PASSED] Shared buffer object [12:37:43] ============ [PASSED] ttm_bo_validate_multihop ============= [12:37:43] ========== ttm_bo_validate_no_placement_signaled ========== [12:37:43] [PASSED] Buffer object in system domain, no page vector [12:37:43] [PASSED] Buffer object in system domain with an existing page vector [12:37:43] ====== [PASSED] ttm_bo_validate_no_placement_signaled ====== [12:37:43] ======== ttm_bo_validate_no_placement_not_signaled ======== [12:37:43] [PASSED] Buffer object for userspace [12:37:43] [PASSED] Kernel buffer object [12:37:43] [PASSED] Shared buffer object [12:37:43] ==== [PASSED] ttm_bo_validate_no_placement_not_signaled ==== [12:37:43] [PASSED] ttm_bo_validate_move_fence_signaled [12:37:43] ========= ttm_bo_validate_move_fence_not_signaled ========= [12:37:43] [PASSED] Waits for GPU [12:37:43] [PASSED] Tries to lock straight away [12:37:43] ===== [PASSED] ttm_bo_validate_move_fence_not_signaled ===== [12:37:43] [PASSED] ttm_bo_validate_happy_evict [12:37:43] [PASSED] ttm_bo_validate_all_pinned_evict [12:37:43] [PASSED] ttm_bo_validate_allowed_only_evict [12:37:43] [PASSED] ttm_bo_validate_deleted_evict [12:37:43] [PASSED] ttm_bo_validate_busy_domain_evict [12:37:43] [PASSED] ttm_bo_validate_evict_gutting [12:37:43] [PASSED] ttm_bo_validate_recrusive_evict stty: 'standard input': Inappropriate ioctl for device [12:37:43] ================= [PASSED] ttm_bo_validate ================= [12:37:43] ============================================================ [12:37:43] Testing complete. Ran 101 tests: passed: 101 [12:37:43] Elapsed time: 11.335s total, 1.636s configuring, 9.483s building, 0.179s running
+ cleanup
++ stat -c %u:%g /kernel
+ chown -R 1003:1003 /kernel
Patchwork
CI✗ CI.checksparse: warning for Plane Color Pipeline support for Intel platforms (rev5)
In reply to Uma Shankar== Series Details ==
== Series Details ==
Series: Plane Color Pipeline support for Intel platforms (rev5)
URL : https://patchwork.freedesktop.org/series/141788/
State : warning
== Summary ==
+ trap cleanup EXIT
+ KERNEL=/kernel
+ MT=/root/linux/maintainer-tools
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools /root/linux/maintainer-tools
Cloning into '/root/linux/maintainer-tools'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ make -C /root/linux/maintainer-tools
make: Entering directory '/root/linux/maintainer-tools'
cc -O2 -g -Wextra -o remap-log remap-log.c
make: Leaving directory '/root/linux/maintainer-tools'
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ /root/linux/maintainer-tools/dim sparse --fast 8043455e28fb7b8089e55e4390547a4c3d7bd4dc
Sparse version: 0.6.4 (Ubuntu: 0.6.4-4ubuntu3)
Fast mode used, each commit won't be checked separately.
-+drivers/gpu/drm/drm_drv.c:449:6: warning: context imbalance in 'drm_dev_enter' - different lock contexts for basic block+drivers/gpu/drm/drm_drv.c: note: in included file (through include/linux/notifier.h, arch/x86/include/asm/uprobes.h, include/linux/uprobes.h, include/linux/mm_types.h, include/linux/mmzone.h, include/linux/gfp.h, ...):+drivers/gpu/drm/drm_plane.c:213:24: warning: Using plain integer as NULL pointer+drivers/gpu/drm/i915/display/intel_alpm.c: note: in included file:+drivers/gpu/drm/i915/display/intel_casf.c:147:21: error: too long token expansion+drivers/gpu/drm/i915/display/intel_cdclk.c: note: in included file:+drivers/gpu/drm/i915/display/intel_ddi.c: note: in included file:+drivers/gpu/drm/i915/display/intel_display_types.h:2082:24: warning: unreplaced symbol '<noident>'+drivers/gpu/drm/i915/display/intel_display_types.h:2082:24: warning: unreplaced symbol '<noident>'+drivers/gpu/drm/i915/display/intel_display_types.h:2082:24: warning: unreplaced symbol '<noident>'+drivers/gpu/drm/i915/display/intel_display_types.h:2082:24: warning: unreplaced symbol '<noident>'+drivers/gpu/drm/i915/display/intel_display_types.h:2082:24: warning: unreplaced symbol '<noident>'+drivers/gpu/drm/i915/display/intel_display_types.h:2082:24: warning: unreplaced symbol '<noident>'+drivers/gpu/drm/i915/display/intel_display_types.h:2082:24: warning: unreplaced symbol '<noident>'+drivers/gpu/drm/i915/display/intel_display_types.h:2082:24: warning: unreplaced symbol '<noident>'+drivers/gpu/drm/i915/display/intel_display_types.h:2082:24: warning: unreplaced symbol '<noident>'+drivers/gpu/drm/i915/display/intel_display_types.h:2082:24: warning: unreplaced symbol '<noident>'+drivers/gpu/drm/i915/display/intel_display_types.h:2082:24: warning: unreplaced symbol '<noident>'+drivers/gpu/drm/i915/display/intel_display_types.h:2082:24: warning: unreplaced symbol '<noident>'+drivers/gpu/drm/i915/display/intel_display_types.h:2082:24: warning: unreplaced symbol '<noident>'+drivers/gpu/drm/i915/display/intel_display_types.h:2082:24: warning: unreplaced symbol '<noident>'+drivers/gpu/drm/i915/display/intel_display_types.h:2082:24: warning: unreplaced symbol '<noident>'+drivers/gpu/drm/i915/display/intel_display_types.h:2082:24: warning: unreplaced symbol '<noident>'+drivers/gpu/drm/i915/display/intel_display_types.h:2095:24: warning: unreplaced symbol '<noident>'+drivers/gpu/drm/i915/display/intel_display_types.h:2095:24: warning: unreplaced symbol '<noident>'+drivers/gpu/drm/i915/display/intel_display_types.h:2095:24: warning: unreplaced symbol '<noident>'+drivers/gpu/drm/i915/display/intel_hdcp.c: note: in included file:+drivers/gpu/drm/i915/display/intel_hotplug.c: note: in included file:+drivers/gpu/drm/i915/display/intel_lt_phy.c:1605:35: warning: Using plain integer as NULL pointer+drivers/gpu/drm/i915/display/intel_pps.c: note: in included file:+drivers/gpu/drm/i915/display/intel_psr.c: note: in included file:+drivers/gpu/drm/i915/gt/intel_reset.c:1569:12: warning: context imbalance in '_intel_gt_reset_lock' - different lock contexts for basic block +drivers/gpu/drm/i915/gt/intel_sseu.c:600:17: error: too long token expansion+drivers/gpu/drm/i915/i915_active.c:1062:16: warning: context imbalance in '__i915_active_fence_set' - different lock contexts for basic block +drivers/gpu/drm/i915/i915_drm_client.c:92:9: error: incompatible types in comparison expression (different address spaces):+drivers/gpu/drm/i915/i915_drm_client.c:92:9: error: incompatible types in comparison expression (different address spaces):
+drivers/gpu/drm/i915/i915_drm_client.c:92:9: expected struct list_head const *list +drivers/gpu/drm/i915/i915_drm_client.c:92:9: got struct list_head [noderef] __rcu *pos +drivers/gpu/drm/i915/i915_drm_client.c:92:9: struct list_head * +drivers/gpu/drm/i915/i915_drm_client.c:92:9: struct list_head * +drivers/gpu/drm/i915/i915_drm_client.c:92:9: struct list_head [noderef] __rcu * +drivers/gpu/drm/i915/i915_drm_client.c:92:9: struct list_head [noderef] __rcu *
+drivers/gpu/drm/i915/i915_drm_client.c:92:9: warning: incorrect type in argument 1 (different address spaces) +drivers/gpu/drm/i915/i915_gpu_error.c:692:3: warning: symbol 'guc_hw_reg_state' was not declared. Should it be static? +drivers/gpu/drm/i915/i915_irq.c:466:9: warning: unreplaced symbol '<noident>' +drivers/gpu/drm/i915/i915_irq.c:466:9: warning: unreplaced symbol '<noident>' +drivers/gpu/drm/i915/i915_irq.c:474:16: warning: unreplaced symbol '<noident>' +drivers/gpu/drm/i915/i915_irq.c:474:16: warning: unreplaced symbol '<noident>' +drivers/gpu/drm/i915/i915_irq.c:479:9: warning: unreplaced symbol '<noident>' +drivers/gpu/drm/i915/i915_irq.c:479:9: warning: unreplaced symbol '<noident>' +drivers/gpu/drm/i915/i915_irq.c:479:9: warning: unreplaced symbol '<noident>' +drivers/gpu/drm/i915/i915_irq.c:517:9: warning: unreplaced symbol '<noident>' +drivers/gpu/drm/i915/i915_irq.c:517:9: warning: unreplaced symbol '<noident>' +drivers/gpu/drm/i915/i915_irq.c:525:16: warning: unreplaced symbol '<noident>' +drivers/gpu/drm/i915/i915_irq.c:525:16: warning: unreplaced symbol '<noident>' +drivers/gpu/drm/i915/i915_irq.c:530:9: warning: unreplaced symbol '<noident>' +drivers/gpu/drm/i915/i915_irq.c:530:9: warning: unreplaced symbol '<noident>' +drivers/gpu/drm/i915/i915_irq.c:530:9: warning: unreplaced symbol '<noident>' +drivers/gpu/drm/i915/i915_irq.c:574:9: warning: unreplaced symbol '<noident>' +drivers/gpu/drm/i915/i915_irq.c:574:9: warning: unreplaced symbol '<noident>' +drivers/gpu/drm/i915/i915_irq.c:577:15: warning: unreplaced symbol '<noident>' +drivers/gpu/drm/i915/i915_irq.c:577:15: warning: unreplaced symbol '<noident>' +drivers/gpu/drm/i915/i915_irq.c:581:9: warning: unreplaced symbol '<noident>' +drivers/gpu/drm/i915/i915_irq.c:581:9: warning: unreplaced symbol '<noident>' +drivers/gpu/drm/i915/i915_irq.c:588:9: warning: unreplaced symbol '<noident>' +drivers/gpu/drm/i915/i915_irq.c:588:9: warning: unreplaced symbol '<noident>' +drivers/gpu/drm/i915/i915_irq.c:588:9: warning: unreplaced symbol '<noident>' +drivers/gpu/drm/i915/i915_irq.c:588:9: warning: unreplaced symbol '<noident>' +drivers/gpu/drm/i915/intel_uncore.c:1930:1: warning: context imbalance in 'fwtable_read8' - unexpected unlock +drivers/gpu/drm/i915/intel_uncore.c:1931:1: warning: context imbalance in 'fwtable_read16' - unexpected unlock +drivers/gpu/drm/i915/intel_uncore.c:1932:1: warning: context imbalance in 'fwtable_read32' - unexpected unlock +drivers/gpu/drm/i915/intel_uncore.c:1933:1: warning: context imbalance in 'fwtable_read64' - unexpected unlock +drivers/gpu/drm/i915/intel_uncore.c:1998:1: warning: context imbalance in 'gen6_write8' - unexpected unlock +drivers/gpu/drm/i915/intel_uncore.c:1999:1: warning: context imbalance in 'gen6_write16' - unexpected unlock +drivers/gpu/drm/i915/intel_uncore.c:2000:1: warning: context imbalance in 'gen6_write32' - unexpected unlock +drivers/gpu/drm/i915/intel_uncore.c:2020:1: warning: context imbalance in 'fwtable_write8' - unexpected unlock +drivers/gpu/drm/i915/intel_uncore.c:2021:1: warning: context imbalance in 'fwtable_write16' - unexpected unlock +drivers/gpu/drm/i915/intel_uncore.c:2022:1: warning: context imbalance in 'fwtable_write32' - unexpected unlock +drivers/gpu/drm/i915/intel_wakeref.c:148:19: warning: context imbalance in 'wakeref_auto_timeout' - unexpected unlock +drivers/gpu/drm/ttm/ttm_bo.c:1201:31: warning: symbol 'ttm_swap_ops' was not declared. Should it be static? +./include/linux/srcu.h:389:9: warning: context imbalance in 'drm_dev_exit' - unexpected unlock
+ cleanup
++ stat -c %u:%g /kernel
+ chown -R 1003:1003 /kernel
Patchwork
CI✗ i915.CI.BAT: failure for Plane Color Pipeline support for Intel platforms (rev6)
In reply to Uma Shankar== Series Details ==
== Series Details ==
Series: Plane Color Pipeline support for Intel platforms (rev6)
URL : https://patchwork.freedesktop.org/series/129811/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_17489 -> Patchwork_129811v6
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_129811v6 absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_129811v6, please notify your bug team ([email protected]) to allow them to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_129811v6/index.html
Participating hosts (45 -> 44)
------------------------------
Missing (1): fi-snb-2520m
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_129811v6:
### IGT changes ###
#### Possible regressions ####
* igt@i915_module_load@load:
- bat-mtlp-9: [PASS][1] -> [ABORT][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17489/bat-mtlp-9/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_129811v6/bat-mtlp-9/igt@[email protected]
* igt@kms_dsc@dsc-basic:
- bat-dg2-9: [PASS][3] -> [ABORT][4] +1 other test abort
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17489/bat-dg2-9/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_129811v6/bat-dg2-9/igt@[email protected]
- bat-adlp-6: [PASS][5] -> [ABORT][6] +1 other test abort
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17489/bat-adlp-6/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_129811v6/bat-adlp-6/igt@[email protected]
* igt@kms_dsc@dsc-basic@pipe-d-dp-1:
- bat-dg2-9: [PASS][7] -> [DMESG-WARN][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17489/bat-dg2-9/igt@kms_dsc@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_129811v6/bat-dg2-9/igt@kms_dsc@[email protected]
* igt@kms_dsc@dsc-basic@pipe-d-dp-3:
- bat-adlp-6: [PASS][9] -> [DMESG-WARN][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17489/bat-adlp-6/igt@kms_dsc@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_129811v6/bat-adlp-6/igt@kms_dsc@[email protected]
* igt@kms_flip@basic-flip-vs-dpms:
- bat-arls-6: [PASS][11] -> [ABORT][12] +1 other test abort
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17489/bat-arls-6/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_129811v6/bat-arls-6/igt@[email protected]
- bat-adls-6: [PASS][13] -> [ABORT][14] +1 other test abort
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17489/bat-adls-6/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_129811v6/bat-adls-6/igt@[email protected]
- bat-arls-5: [PASS][15] -> [ABORT][16] +1 other test abort
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17489/bat-arls-5/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_129811v6/bat-arls-5/igt@[email protected]
- bat-arlh-3: [PASS][17] -> [ABORT][18] +1 other test abort
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17489/bat-arlh-3/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_129811v6/bat-arlh-3/igt@[email protected]
* igt@kms_flip@basic-flip-vs-dpms@b-edp1:
- bat-jsl-1: [PASS][19] -> [ABORT][20] +1 other test abort
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17489/bat-jsl-1/igt@kms_flip@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_129811v6/bat-jsl-1/igt@kms_flip@[email protected]
* igt@kms_flip@basic-flip-vs-dpms@b-hdmi-a1:
- bat-jsl-5: [PASS][21] -> [ABORT][22] +1 other test abort
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17489/bat-jsl-5/igt@kms_flip@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_129811v6/bat-jsl-5/igt@kms_flip@[email protected]
* igt@kms_flip@basic-flip-vs-dpms@c-dp1:
- bat-adlp-9: [PASS][23] -> [ABORT][24] +1 other test abort
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17489/bat-adlp-9/igt@kms_flip@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_129811v6/bat-adlp-9/igt@kms_flip@[email protected]
- bat-rpls-4: [PASS][25] -> [ABORT][26] +1 other test abort
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17489/bat-rpls-4/igt@kms_flip@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_129811v6/bat-rpls-4/igt@kms_flip@[email protected]
* igt@kms_flip@basic-flip-vs-dpms@c-edp1:
- bat-mtlp-8: [PASS][27] -> [ABORT][28] +1 other test abort
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17489/bat-mtlp-8/igt@kms_flip@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_129811v6/bat-mtlp-8/igt@kms_flip@[email protected]
- bat-jsl-1: [PASS][29] -> [DMESG-WARN][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17489/bat-jsl-1/igt@kms_flip@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_129811v6/bat-jsl-1/igt@kms_flip@[email protected]
- bat-twl-1: [PASS][31] -> [ABORT][32] +1 other test abort
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17489/bat-twl-1/igt@kms_flip@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_129811v6/bat-twl-1/igt@kms_flip@[email protected]
- bat-rplp-1: [PASS][33] -> [ABORT][34] +1 other test abort
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17489/bat-rplp-1/igt@kms_flip@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_129811v6/bat-rplp-1/igt@kms_flip@[email protected]
* igt@kms_flip@basic-flip-vs-dpms@c-hdmi-a1:
- bat-jsl-5: [PASS][35] -> [DMESG-WARN][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17489/bat-jsl-5/igt@kms_flip@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_129811v6/bat-jsl-5/igt@kms_flip@[email protected]
- fi-tgl-1115g4: [PASS][37] -> [ABORT][38] +1 other test abort
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17489/fi-tgl-1115g4/igt@kms_flip@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_129811v6/fi-tgl-1115g4/igt@kms_flip@[email protected]
* igt@kms_flip@basic-flip-vs-dpms@c-hdmi-a2:
- bat-dg2-11: [PASS][39] -> [ABORT][40] +1 other test abort
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17489/bat-dg2-11/igt@kms_flip@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_129811v6/bat-dg2-11/igt@kms_flip@[email protected]
- bat-dg2-14: [PASS][41] -> [ABORT][42] +1 other test abort
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17489/bat-dg2-14/igt@kms_flip@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_129811v6/bat-dg2-14/igt@kms_flip@[email protected]
- bat-dg1-7: [PASS][43] -> [ABORT][44] +1 other test abort
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17489/bat-dg1-7/igt@kms_flip@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_129811v6/bat-dg1-7/igt@kms_flip@[email protected]
* igt@kms_flip@basic-flip-vs-dpms@d-dp1:
- bat-adlp-9: [PASS][45] -> [DMESG-WARN][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17489/bat-adlp-9/igt@kms_flip@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_129811v6/bat-adlp-9/igt@kms_flip@[email protected]
- bat-rpls-4: [PASS][47] -> [DMESG-WARN][48] +2 other tests dmesg-warn
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17489/bat-rpls-4/igt@kms_flip@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_129811v6/bat-rpls-4/igt@kms_flip@[email protected]
* igt@kms_flip@basic-flip-vs-dpms@d-dp2:
- bat-dg2-14: [PASS][49] -> [DMESG-WARN][50] +2 other tests dmesg-warn
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17489/bat-dg2-14/igt@kms_flip@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_129811v6/bat-dg2-14/igt@kms_flip@[email protected]
* igt@kms_flip@basic-flip-vs-dpms@d-dp3:
- bat-arls-5: [PASS][51] -> [DMESG-WARN][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17489/bat-arls-5/igt@kms_flip@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_129811v6/bat-arls-5/igt@kms_flip@[email protected]
* igt@kms_flip@basic-flip-vs-dpms@d-edp1:
- bat-mtlp-8: [PASS][53] -> [DMESG-WARN][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17489/bat-mtlp-8/igt@kms_flip@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_129811v6/bat-mtlp-8/igt@kms_flip@[email protected]
- bat-arlh-3: [PASS][55] -> [DMESG-WARN][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17489/bat-arlh-3/igt@kms_flip@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_129811v6/bat-arlh-3/igt@kms_flip@[email protected]
- bat-rplp-1: [PASS][57] -> [DMESG-WARN][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17489/bat-rplp-1/igt@kms_flip@[email protected]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_129811v6/bat-rplp-1/igt@kms_flip@[email protected]
* igt@kms_flip@basic-flip-vs-dpms@d-hdmi-a1:
- bat-adls-6: [PASS][59] -> [DMESG-WARN][60]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17489/bat-adls-6/igt@kms_flip@[email protected]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_129811v6/bat-adls-6/igt@kms_flip@[email protected]
- fi-tgl-1115g4: [PASS][61] -> [DMESG-WARN][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17489/fi-tgl-1115g4/igt@kms_flip@[email protected]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_129811v6/fi-tgl-1115g4/igt@kms_flip@[email protected]
* igt@kms_flip@basic-flip-vs-dpms@d-hdmi-a2:
- bat-dg2-11: [PASS][63] -> [DMESG-WARN][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17489/bat-dg2-11/igt@kms_flip@[email protected]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_129811v6/bat-dg2-11/igt@kms_flip@[email protected]
- bat-arls-6: [PASS][65] -> [DMESG-WARN][66]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17489/bat-arls-6/igt@kms_flip@[email protected]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_129811v6/bat-arls-6/igt@kms_flip@[email protected]
- bat-dg1-7: [PASS][67] -> [DMESG-WARN][68]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17489/bat-dg1-7/igt@kms_flip@[email protected]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_129811v6/bat-dg1-7/igt@kms_flip@[email protected]
Known issues
------------
Here are the changes found in Patchwork_129811v6 that come from known issues:
### IGT changes ###
#### Warnings ####
* igt@dmabuf@all-tests@dma_fence_chain:
- fi-bsw-n3050: [ABORT][69] ([i915#12904]) -> [INCOMPLETE][70] ([i915#12904]) +1 other test incomplete
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17489/fi-bsw-n3050/igt@dmabuf@all-tests@dma_fence_chain.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_129811v6/fi-bsw-n3050/igt@dmabuf@all-tests@dma_fence_chain.html
[i915#12904]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12904
Build changes
-------------
* Linux: CI_DRM_17489 -> Patchwork_129811v6
CI-20190529: 20190529
CI_DRM_17489: 8043455e28fb7b8089e55e4390547a4c3d7bd4dc @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_8607: 8607
Patchwork_129811v6: 8043455e28fb7b8089e55e4390547a4c3d7bd4dc @ git://anongit.freedesktop.org/gfx-ci/linux
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_129811v6/index.html
Patchwork
CI✗ Xe.CI.BAT: failure for Plane Color Pipeline support for Intel platforms (rev5)
In reply to Uma Shankar== Series Details ==
== Series Details ==
Series: Plane Color Pipeline support for Intel platforms (rev5)
URL : https://patchwork.freedesktop.org/series/141788/
State : failure
== Summary ==
CI Bug Log - changes from xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0_BAT -> xe-pw-141788v5_BAT
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with xe-pw-141788v5_BAT absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes
introduced in xe-pw-141788v5_BAT, please notify your bug team ([email protected]) to allow them to document this new failure mode, which will reduce false positives in CI.
Participating hosts (12 -> 12)
------------------------------
No changes in participating hosts
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in xe-pw-141788v5_BAT:
### IGT changes ###
#### Possible regressions ####
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12:
- bat-ptl-2: [PASS][1] -> [ABORT][2] +1 other test abort
[1]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0/bat-ptl-2/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/bat-ptl-2/igt@[email protected]
- bat-dg2-oem2: [PASS][3] -> [ABORT][4] +1 other test abort
[3]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0/bat-dg2-oem2/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/bat-dg2-oem2/igt@[email protected]
- bat-lnl-1: [PASS][5] -> [ABORT][6] +1 other test abort
[5]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0/bat-lnl-1/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/bat-lnl-1/igt@[email protected]
- bat-adlp-7: [PASS][7] -> [ABORT][8] +1 other test abort
[7]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0/bat-adlp-7/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/bat-adlp-7/igt@[email protected]
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-a-hdmi-a-3:
- bat-bmg-1: [PASS][9] -> [ABORT][10] +1 other test abort
[9]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0/bat-bmg-1/igt@kms_pipe_crc_basic@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/bat-bmg-1/igt@kms_pipe_crc_basic@[email protected]
Known issues
------------
Here are the changes found in xe-pw-141788v5_BAT that come from known issues:
### IGT changes ###
#### Possible fixes ####
* igt@kms_flip@basic-plain-flip@c-edp1:
- bat-adlp-7: [DMESG-WARN][11] ([Intel XE#4543]) -> [PASS][12] +1 other test pass
[11]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0/bat-adlp-7/igt@kms_flip@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/bat-adlp-7/igt@kms_flip@[email protected]
[Intel XE#4543]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4543
Build changes
-------------
* Linux: xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0 -> xe-pw-141788v5
IGT_8607: 8607
xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0: 14d34ac35158252e94860f96b92b6778f95df1e0
xe-pw-141788v5: 141788v5
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/index.html
Patchwork
CI✗ Xe.CI.Full: failure for Plane Color Pipeline support for Intel platforms (rev5)
In reply to Uma Shankar== Series Details ==
== Series Details ==
Series: Plane Color Pipeline support for Intel platforms (rev5)
URL : https://patchwork.freedesktop.org/series/141788/
State : failure
== Summary ==
CI Bug Log - changes from xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0_FULL -> xe-pw-141788v5_FULL
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with xe-pw-141788v5_FULL absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes
introduced in xe-pw-141788v5_FULL, please notify your bug team ([email protected]) to allow them to document this new failure mode, which will reduce false positives in CI.
Participating hosts (4 -> 4)
------------------------------
No changes in participating hosts
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in xe-pw-141788v5_FULL:
### IGT changes ###
#### Possible regressions ####
* igt@kms_ccs@crc-primary-rotation-180-4-tiled-bmg-ccs@pipe-a-hdmi-a-3:
- shard-bmg: [PASS][1] -> [ABORT][2] +20 other tests abort
[1]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0/shard-bmg-6/igt@kms_ccs@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-bmg-6/igt@kms_ccs@[email protected]
* igt@kms_ccs@crc-primary-rotation-180-4-tiled-dg2-mc-ccs@pipe-a-hdmi-a-6:
- shard-dg2-set2: [PASS][3] -> [ABORT][4] +18 other tests abort
[3]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0/shard-dg2-464/igt@kms_ccs@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-dg2-464/igt@kms_ccs@[email protected]
* igt@kms_plane_scaling@plane-downscale-factor-0-75-with-pixel-format:
- shard-dg2-set2: NOTRUN -> [ABORT][5] +1 other test abort
[5]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-dg2-436/igt@kms_plane_scaling@plane-downscale-factor-0-75-with-pixel-format.html
* igt@kms_plane_scaling@plane-scaler-unity-scaling-with-pixel-format@pipe-a:
- shard-lnl: [PASS][6] -> [ABORT][7] +20 other tests abort
[6]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0/shard-lnl-7/igt@kms_plane_scaling@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-lnl-3/igt@kms_plane_scaling@[email protected]
* igt@kms_rotation_crc@multiplane-rotation:
- shard-adlp: [PASS][8] -> [ABORT][9] +14 other tests abort
[8]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0/shard-adlp-8/igt@[email protected]
[9]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-adlp-6/igt@[email protected]
New tests
---------
New tests have been introduced between xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0_FULL and xe-pw-141788v5_FULL:
### New IGT tests (10) ###
* igt@kms_pm_rpm@legacy-planes-dpms@plane-123:
- Statuses : 3 pass(s)
- Exec time: [2.60, 17.49] s
* igt@kms_pm_rpm@legacy-planes-dpms@plane-133:
- Statuses : 3 pass(s)
- Exec time: [2.52, 17.37] s
* igt@kms_pm_rpm@legacy-planes@plane-123:
- Statuses : 3 pass(s)
- Exec time: [3.90, 17.57] s
* igt@kms_pm_rpm@legacy-planes@plane-133:
- Statuses : 3 pass(s)
- Exec time: [3.19, 17.66] s
* igt@kms_pm_rpm@universal-planes-dpms@plane-123:
- Statuses : 4 pass(s)
- Exec time: [2.78, 16.06] s
* igt@kms_pm_rpm@universal-planes-dpms@plane-133:
- Statuses : 4 pass(s)
- Exec time: [2.88, 17.50] s
* igt@kms_pm_rpm@universal-planes-dpms@plane-143:
- Statuses : 4 pass(s)
- Exec time: [2.88, 16.21] s
* igt@kms_pm_rpm@universal-planes@plane-123:
- Statuses : 4 pass(s)
- Exec time: [2.52, 17.54] s
* igt@kms_pm_rpm@universal-planes@plane-133:
- Statuses : 4 pass(s)
- Exec time: [2.52, 17.55] s
* igt@kms_pm_rpm@universal-planes@plane-143:
- Statuses : 4 pass(s)
- Exec time: [2.64, 16.11] s
Known issues
------------
Here are the changes found in xe-pw-141788v5_FULL that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@core_hotunplug@hotreplug:
- shard-bmg: [PASS][10] -> [DMESG-WARN][11] ([Intel XE#3428]) +5 other tests dmesg-warn
[10]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0/shard-bmg-1/igt@[email protected]
[11]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-bmg-6/igt@[email protected]
* igt@kms_atomic_transition@plane-all-modeset-transition-internal-panels:
- shard-bmg: NOTRUN -> [SKIP][12] ([Intel XE#2370])
[12]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-bmg-2/igt@kms_atomic_transition@plane-all-modeset-transition-internal-panels.html
* igt@kms_big_fb@linear-8bpp-rotate-90:
- shard-dg2-set2: NOTRUN -> [SKIP][13] ([Intel XE#316])
[13]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-dg2-436/igt@[email protected]
* igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-0-async-flip:
- shard-adlp: [PASS][14] -> [DMESG-FAIL][15] ([Intel XE#4543])
[14]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0/shard-adlp-2/igt@[email protected]
[15]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-adlp-9/igt@[email protected]
* igt@kms_ccs@crc-sprite-planes-basic-4-tiled-mtl-rc-ccs@pipe-d-dp-4:
- shard-dg2-set2: NOTRUN -> [SKIP][16] ([Intel XE#455] / [Intel XE#787]) +1 other test skip
[16]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-dg2-436/igt@kms_ccs@[email protected]
* igt@kms_ccs@crc-sprite-planes-basic-4-tiled-mtl-rc-ccs@pipe-d-hdmi-a-6:
- shard-dg2-set2: NOTRUN -> [SKIP][17] ([Intel XE#787]) +6 other tests skip
[17]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-dg2-436/igt@kms_ccs@[email protected]
* igt@kms_cursor_crc@cursor-rapid-movement-512x512:
- shard-dg2-set2: NOTRUN -> [SKIP][18] ([Intel XE#308])
[18]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-dg2-436/igt@[email protected]
* igt@kms_cursor_legacy@2x-flip-vs-cursor-legacy:
- shard-bmg: [PASS][19] -> [SKIP][20] ([Intel XE#2291]) +2 other tests skip
[19]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0/shard-bmg-1/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-bmg-6/igt@[email protected]
* igt@kms_flip@2x-flip-vs-panning-interruptible:
- shard-bmg: [PASS][21] -> [SKIP][22] ([Intel XE#2316])
[21]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0/shard-bmg-1/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-bmg-6/igt@[email protected]
* igt@kms_flip@basic-flip-vs-dpms@c-hdmi-a1:
- shard-adlp: [PASS][23] -> [DMESG-WARN][24] ([Intel XE#4543]) +1 other test dmesg-warn
[23]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0/shard-adlp-3/igt@kms_flip@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-adlp-2/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1:
- shard-lnl: [PASS][25] -> [FAIL][26] ([Intel XE#301] / [Intel XE#3149])
[25]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0/shard-lnl-2/igt@kms_flip@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-lnl-4/igt@kms_flip@[email protected]
* igt@kms_frontbuffer_tracking@fbcdrrs-1p-primscrn-cur-indfb-draw-render:
- shard-dg2-set2: NOTRUN -> [SKIP][27] ([Intel XE#651]) +1 other test skip
[27]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-dg2-436/igt@kms_frontbuffer_tracking@fbcdrrs-1p-primscrn-cur-indfb-draw-render.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-shrfb-draw-render:
- shard-dg2-set2: NOTRUN -> [SKIP][28] ([Intel XE#653]) +2 other tests skip
[28]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-dg2-436/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-shrfb-draw-render.html
* igt@kms_lease@lease-uevent:
- shard-adlp: [PASS][29] -> [DMESG-WARN][30] ([Intel XE#2953] / [Intel XE#4173]) +1 other test dmesg-warn
[29]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0/shard-adlp-9/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-adlp-1/igt@[email protected]
* igt@kms_plane_multiple@2x-tiling-4:
- shard-bmg: [PASS][31] -> [DMESG-WARN][32] ([Intel XE#5175])
[31]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0/shard-bmg-6/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-bmg-6/igt@[email protected]
* igt@kms_psr@psr2-dpms:
- shard-dg2-set2: NOTRUN -> [SKIP][33] ([Intel XE#1406] / [Intel XE#2850] / [Intel XE#929])
[33]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-dg2-436/igt@[email protected]
* igt@xe_exec_fault_mode@once-rebind-imm:
- shard-dg2-set2: NOTRUN -> [SKIP][34] ([Intel XE#288]) +1 other test skip
[34]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-dg2-436/igt@[email protected]
* igt@xe_exec_system_allocator@pat-index-madvise-pat-idx-uc-multi-vma:
- shard-lnl: [PASS][35] -> [FAIL][36] ([Intel XE#5625])
[35]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0/shard-lnl-4/igt@xe_exec_system_allocator@pat-index-madvise-pat-idx-uc-multi-vma.html
[36]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-lnl-3/igt@xe_exec_system_allocator@pat-index-madvise-pat-idx-uc-multi-vma.html
* igt@xe_exec_system_allocator@threads-shared-vm-many-large-execqueues-new-bo-map:
- shard-dg2-set2: NOTRUN -> [SKIP][37] ([Intel XE#4915]) +9 other tests skip
[37]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-dg2-436/igt@xe_exec_system_allocator@threads-shared-vm-many-large-execqueues-new-bo-map.html
* igt@xe_module_load@load:
- shard-dg2-set2: ([PASS][38], [PASS][39], [PASS][40], [PASS][41], [PASS][42], [PASS][43], [PASS][44], [PASS][45], [PASS][46], [PASS][47], [PASS][48], [PASS][49], [PASS][50], [PASS][51], [PASS][52], [PASS][53], [PASS][54], [PASS][55], [PASS][56], [PASS][57], [PASS][58], [PASS][59], [PASS][60], [PASS][61], [PASS][62]) -> ([PASS][63], [PASS][64], [PASS][65], [PASS][66], [PASS][67], [PASS][68], [PASS][69], [PASS][70], [PASS][71], [PASS][72], [PASS][73], [PASS][74], [PASS][75], [PASS][76], [PASS][77], [PASS][78], [PASS][79], [PASS][80], [SKIP][81], [PASS][82], [PASS][83], [PASS][84], [PASS][85], [PASS][86], [PASS][87], [PASS][88]) ([Intel XE#378])
[38]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0/shard-dg2-433/igt@[email protected]
[39]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0/shard-dg2-433/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0/shard-dg2-432/igt@[email protected]
[41]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0/shard-dg2-432/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0/shard-dg2-434/igt@[email protected]
[43]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0/shard-dg2-434/igt@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0/shard-dg2-434/igt@[email protected]
[45]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0/shard-dg2-466/igt@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0/shard-dg2-466/igt@[email protected]
[47]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0/shard-dg2-463/igt@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0/shard-dg2-463/igt@[email protected]
[49]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0/shard-dg2-463/igt@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0/shard-dg2-464/igt@[email protected]
[51]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0/shard-dg2-464/igt@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0/shard-dg2-433/igt@[email protected]
[53]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0/shard-dg2-435/igt@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0/shard-dg2-435/igt@[email protected]
[55]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0/shard-dg2-464/igt@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0/shard-dg2-434/igt@[email protected]
[57]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0/shard-dg2-435/igt@[email protected]
[58]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0/shard-dg2-435/igt@[email protected]
[59]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0/shard-dg2-433/igt@[email protected]
[60]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0/shard-dg2-436/igt@[email protected]
[61]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0/shard-dg2-436/igt@[email protected]
[62]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0/shard-dg2-432/igt@[email protected]
[63]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-dg2-436/igt@[email protected]
[64]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-dg2-436/igt@[email protected]
[65]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-dg2-436/igt@[email protected]
[66]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-dg2-464/igt@[email protected]
[67]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-dg2-433/igt@[email protected]
[68]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-dg2-464/igt@[email protected]
[69]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-dg2-433/igt@[email protected]
[70]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-dg2-463/igt@[email protected]
[71]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-dg2-463/igt@[email protected]
[72]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-dg2-464/igt@[email protected]
[73]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-dg2-466/igt@[email protected]
[74]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-dg2-433/igt@[email protected]
[75]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-dg2-432/igt@[email protected]
[76]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-dg2-463/igt@[email protected]
[77]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-dg2-432/igt@[email protected]
[78]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-dg2-466/igt@[email protected]
[79]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-dg2-432/igt@[email protected]
[80]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-dg2-434/igt@[email protected]
[81]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-dg2-436/igt@[email protected]
[82]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-dg2-434/igt@[email protected]
[83]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-dg2-435/igt@[email protected]
[84]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-dg2-466/igt@[email protected]
[85]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-dg2-435/igt@[email protected]
[86]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-dg2-434/igt@[email protected]
[87]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-dg2-434/igt@[email protected]
[88]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-dg2-435/igt@[email protected]
* igt@xe_oa@rc6-disable:
- shard-dg2-set2: NOTRUN -> [SKIP][89] ([Intel XE#3573])
[89]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-dg2-436/igt@[email protected]
* igt@xe_pmu@engine-activity-accuracy-90@engine-drm_xe_engine_class_video_decode0:
- shard-lnl: [PASS][90] -> [FAIL][91] ([Intel XE#6251]) +3 other tests fail
[90]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0/shard-lnl-8/igt@xe_pmu@engine-activity-accuracy-90@engine-drm_xe_engine_class_video_decode0.html
[91]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-lnl-7/igt@xe_pmu@engine-activity-accuracy-90@engine-drm_xe_engine_class_video_decode0.html
* igt@xe_pxp@pxp-stale-queue-post-suspend:
- shard-dg2-set2: NOTRUN -> [SKIP][92] ([Intel XE#4733])
[92]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-dg2-436/igt@[email protected]
#### Possible fixes ####
* igt@kms_async_flips@invalid-async-flip:
- shard-adlp: [DMESG-WARN][93] ([Intel XE#2953] / [Intel XE#4173]) -> [PASS][94] +1 other test pass
[93]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0/shard-adlp-1/igt@[email protected]
[94]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-adlp-8/igt@[email protected]
* igt@kms_atomic_transition@modeset-transition-nonblocking@2x-outputs:
- shard-bmg: [DMESG-WARN][95] ([Intel XE#3428]) -> [PASS][96] +3 other tests pass
[95]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0/shard-bmg-6/igt@kms_atomic_transition@[email protected]
[96]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-bmg-5/igt@kms_atomic_transition@[email protected]
* igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-0-hflip-async-flip:
- shard-adlp: [DMESG-FAIL][97] ([Intel XE#4543]) -> [PASS][98]
[97]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0/shard-adlp-2/igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-0-hflip-async-flip.html
[98]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-adlp-9/igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-0-hflip-async-flip.html
* igt@kms_cursor_legacy@cursorb-vs-flipb-atomic-transitions-varying-size:
- shard-bmg: [SKIP][99] ([Intel XE#2291]) -> [PASS][100] +1 other test pass
[99]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0/shard-bmg-6/igt@kms_cursor_legacy@cursorb-vs-flipb-atomic-transitions-varying-size.html
[100]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-bmg-8/igt@kms_cursor_legacy@cursorb-vs-flipb-atomic-transitions-varying-size.html
* igt@kms_dither@fb-8bpc-vs-panel-6bpc:
- shard-bmg: [SKIP][101] ([Intel XE#1340]) -> [PASS][102]
[101]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0/shard-bmg-6/igt@[email protected]
[102]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-bmg-8/igt@[email protected]
* igt@kms_dp_aux_dev:
- shard-bmg: [SKIP][103] ([Intel XE#3009]) -> [PASS][104]
[103]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0/shard-bmg-6/igt@kms_dp_aux_dev.html
[104]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-bmg-1/igt@kms_dp_aux_dev.html
* igt@kms_flip@2x-wf_vblank-ts-check-interruptible:
- shard-bmg: [SKIP][105] ([Intel XE#2316]) -> [PASS][106] +2 other tests pass
[105]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0/shard-bmg-6/igt@kms_flip@2x-wf_vblank-ts-check-interruptible.html
[106]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-bmg-1/igt@kms_flip@2x-wf_vblank-ts-check-interruptible.html
* igt@kms_flip@dpms-off-confusion@c-hdmi-a1:
- shard-adlp: [DMESG-WARN][107] ([Intel XE#4543]) -> [PASS][108] +4 other tests pass
[107]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0/shard-adlp-6/igt@kms_flip@[email protected]
[108]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-adlp-4/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-rmfb-interruptible:
- shard-adlp: [DMESG-WARN][109] ([Intel XE#4543] / [Intel XE#5208]) -> [PASS][110]
[109]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0/shard-adlp-9/igt@[email protected]
[110]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-adlp-4/igt@[email protected]
* igt@kms_hdr@static-toggle-dpms:
- shard-bmg: [SKIP][111] ([Intel XE#1503]) -> [PASS][112]
[111]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0/shard-bmg-6/igt@[email protected]
[112]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-bmg-1/igt@[email protected]
* igt@kms_plane_multiple@2x-tiling-x:
- shard-bmg: [SKIP][113] ([Intel XE#4596]) -> [PASS][114]
[113]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0/shard-bmg-6/igt@[email protected]
[114]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-bmg-1/igt@[email protected]
* igt@kms_plane_scaling@plane-upscale-20x20-with-rotation@pipe-a:
- shard-bmg: [DMESG-WARN][115] -> [PASS][116] +1 other test pass
[115]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0/shard-bmg-6/igt@kms_plane_scaling@[email protected]
[116]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-bmg-8/igt@kms_plane_scaling@[email protected]
* igt@xe_fault_injection@vm-create-fail-xe_exec_queue_create_bind:
- shard-bmg: [ABORT][117] -> [PASS][118]
[117]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0/shard-bmg-8/igt@xe_fault_injection@vm-create-fail-xe_exec_queue_create_bind.html
[118]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-bmg-2/igt@xe_fault_injection@vm-create-fail-xe_exec_queue_create_bind.html
* igt@xe_module_load@load:
- shard-lnl: ([PASS][119], [PASS][120], [SKIP][121], [PASS][122], [PASS][123], [PASS][124], [PASS][125], [PASS][126], [PASS][127], [PASS][128], [PASS][129], [PASS][130], [PASS][131], [PASS][132], [PASS][133], [PASS][134], [PASS][135], [PASS][136], [PASS][137], [PASS][138], [PASS][139], [PASS][140], [PASS][141], [PASS][142], [PASS][143], [PASS][144]) ([Intel XE#378]) -> ([PASS][145], [PASS][146], [PASS][147], [PASS][148], [PASS][149], [PASS][150], [PASS][151], [PASS][152], [PASS][153], [PASS][154], [PASS][155], [PASS][156], [PASS][157], [PASS][158], [PASS][159], [PASS][160], [PASS][161], [PASS][162], [PASS][163], [PASS][164], [PASS][165], [PASS][166], [PASS][167], [PASS][168], [PASS][169])
[119]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0/shard-lnl-1/igt@[email protected]
[120]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0/shard-lnl-1/igt@[email protected]
[121]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0/shard-lnl-5/igt@[email protected]
[122]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0/shard-lnl-2/igt@[email protected]
[123]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0/shard-lnl-7/igt@[email protected]
[124]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0/shard-lnl-2/igt@[email protected]
[125]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0/shard-lnl-5/igt@[email protected]
[126]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0/shard-lnl-8/igt@[email protected]
[127]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0/shard-lnl-8/igt@[email protected]
[128]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0/shard-lnl-8/igt@[email protected]
[129]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0/shard-lnl-4/igt@[email protected]
[130]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0/shard-lnl-4/igt@[email protected]
[131]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0/shard-lnl-4/igt@[email protected]
[132]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0/shard-lnl-7/igt@[email protected]
[133]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0/shard-lnl-5/igt@[email protected]
[134]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0/shard-lnl-3/igt@[email protected]
[135]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0/shard-lnl-3/igt@[email protected]
[136]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0/shard-lnl-3/igt@[email protected]
[137]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0/shard-lnl-3/igt@[email protected]
[138]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0/shard-lnl-5/igt@[email protected]
[139]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0/shard-lnl-7/igt@[email protected]
[140]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0/shard-lnl-2/igt@[email protected]
[141]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0/shard-lnl-2/igt@[email protected]
[142]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0/shard-lnl-1/igt@[email protected]
[143]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0/shard-lnl-8/igt@[email protected]
[144]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0/shard-lnl-1/igt@[email protected]
[145]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-lnl-1/igt@[email protected]
[146]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-lnl-2/igt@[email protected]
[147]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-lnl-3/igt@[email protected]
[148]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-lnl-7/igt@[email protected]
[149]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-lnl-4/igt@[email protected]
[150]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-lnl-7/igt@[email protected]
[151]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-lnl-7/igt@[email protected]
[152]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-lnl-1/igt@[email protected]
[153]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-lnl-4/igt@[email protected]
[154]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-lnl-4/igt@[email protected]
[155]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-lnl-8/igt@[email protected]
[156]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-lnl-8/igt@[email protected]
[157]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-lnl-8/igt@[email protected]
[158]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-lnl-5/igt@[email protected]
[159]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-lnl-5/igt@[email protected]
[160]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-lnl-5/igt@[email protected]
[161]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-lnl-3/igt@[email protected]
[162]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-lnl-1/igt@[email protected]
[163]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-lnl-2/igt@[email protected]
[164]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-lnl-1/igt@[email protected]
[165]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-lnl-2/igt@[email protected]
[166]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-lnl-2/igt@[email protected]
[167]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-lnl-7/igt@[email protected]
[168]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-lnl-3/igt@[email protected]
[169]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-lnl-3/igt@[email protected]
* igt@xe_pm_residency@gt-c6-freeze@gt1:
- shard-bmg: [DMESG-WARN][170] ([Intel XE#3088] / [Intel XE#3428]) -> [PASS][171] +1 other test pass
[170]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0/shard-bmg-6/igt@xe_pm_residency@[email protected]
[171]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-bmg-8/igt@xe_pm_residency@[email protected]
* igt@xe_sriov_scheduling@nonpreempt-engine-resets@numvfs-random:
- shard-adlp: [DMESG-FAIL][172] ([Intel XE#3868] / [Intel XE#5213]) -> [PASS][173] +1 other test pass
[172]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0/shard-adlp-6/igt@xe_sriov_scheduling@[email protected]
[173]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-adlp-4/igt@xe_sriov_scheduling@[email protected]
#### Warnings ####
* igt@kms_flip@flip-vs-expired-vblank-interruptible:
- shard-lnl: [FAIL][174] ([Intel XE#301]) -> [FAIL][175] ([Intel XE#301] / [Intel XE#3149])
[174]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0/shard-lnl-2/igt@[email protected]
[175]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-lnl-4/igt@[email protected]
* igt@kms_frontbuffer_tracking@drrs-2p-primscrn-indfb-pgflip-blt:
- shard-bmg: [SKIP][176] ([Intel XE#2312]) -> [SKIP][177] ([Intel XE#2311]) +5 other tests skip
[176]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0/shard-bmg-6/igt@[email protected]
[177]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-bmg-8/igt@[email protected]
* igt@kms_frontbuffer_tracking@drrs-2p-scndscrn-cur-indfb-draw-render:
- shard-bmg: [SKIP][178] ([Intel XE#2311]) -> [SKIP][179] ([Intel XE#2312]) +1 other test skip
[178]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0/shard-bmg-1/igt@kms_frontbuffer_tracking@drrs-2p-scndscrn-cur-indfb-draw-render.html
[179]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-bmg-6/igt@kms_frontbuffer_tracking@drrs-2p-scndscrn-cur-indfb-draw-render.html
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-mmap-wc:
- shard-bmg: [SKIP][180] ([Intel XE#2312]) -> [SKIP][181] ([Intel XE#5390]) +5 other tests skip
[180]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0/shard-bmg-6/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-mmap-wc.html
[181]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-bmg-1/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-mmap-wc.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-shrfb-draw-render:
- shard-bmg: [SKIP][182] ([Intel XE#2313]) -> [SKIP][183] ([Intel XE#2312]) +3 other tests skip
[182]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0/shard-bmg-1/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-shrfb-draw-render.html
[183]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-bmg-6/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-shrfb-draw-render.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-shrfb-pgflip-blt:
- shard-bmg: [SKIP][184] ([Intel XE#2312]) -> [SKIP][185] ([Intel XE#2313]) +4 other tests skip
[184]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0/shard-bmg-6/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-shrfb-pgflip-blt.html
[185]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-bmg-8/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-shrfb-pgflip-blt.html
* igt@kms_tiled_display@basic-test-pattern:
- shard-bmg: [SKIP][186] ([Intel XE#2426]) -> [FAIL][187] ([Intel XE#1729])
[186]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0/shard-bmg-6/igt@[email protected]
[187]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-bmg-5/igt@[email protected]
- shard-dg2-set2: [FAIL][188] ([Intel XE#1729]) -> [SKIP][189] ([Intel XE#362])
[188]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0/shard-dg2-434/igt@[email protected]
[189]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/shard-dg2-463/igt@[email protected]
[Intel XE#1340]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1340
[Intel XE#1406]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1406
[Intel XE#1503]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1503
[Intel XE#1729]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1729
[Intel XE#2291]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2291
[Intel XE#2311]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2311
[Intel XE#2312]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2312
[Intel XE#2313]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2313
[Intel XE#2316]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2316
[Intel XE#2370]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2370
[Intel XE#2426]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2426
[Intel XE#2850]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2850
[Intel XE#288]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/288
[Intel XE#2953]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2953
[Intel XE#3009]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/3009
[Intel XE#301]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/301
[Intel XE#308]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/308
[Intel XE#3088]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/3088
[Intel XE#3149]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/3149
[Intel XE#316]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/316
[Intel XE#3428]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/3428
[Intel XE#3573]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/3573
[Intel XE#362]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/362
[Intel XE#378]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/378
[Intel XE#3868]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/3868
[Intel XE#4173]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4173
[Intel XE#4543]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4543
[Intel XE#455]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/455
[Intel XE#4596]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4596
[Intel XE#4733]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4733
[Intel XE#4915]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4915
[Intel XE#5175]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5175
[Intel XE#5208]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5208
[Intel XE#5213]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5213
[Intel XE#5390]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5390
[Intel XE#5625]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5625
[Intel XE#6251]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6251
[Intel XE#651]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/651
[Intel XE#653]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/653
[Intel XE#787]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/787
[Intel XE#929]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/929
Build changes
-------------
* Linux: xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0 -> xe-pw-141788v5
IGT_8607: 8607
xe-4047-14d34ac35158252e94860f96b92b6778f95df1e0: 14d34ac35158252e94860f96b92b6778f95df1e0
xe-pw-141788v5: 141788v5
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-141788v5/index.html