mod_devicetable: Bump auxiliary_device_id name size
Subsystems (2)
PATCH v2 1/1 mod_devicetable: Bump auxiliary_device_id name size
We have an upcoming driver named "intel_ehl_pse_io". This creates an auxiliary child device for it's GPIO sub-functionality, which matches against "intel_ehl_pse_io.gpio-elkhartlake" and overshoots the current maximum limit of 32 bytes for auxiliary device id string. Bump the size to 40 bytes to satisfy such cases.
---
v2: Describe the use case (Greg, Andy)
Triggered by [1].
[1] https://lore.kernel.org/r/[email protected]
include/linux/mod_devicetable.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/mod_devicetable.h +1 -1
@@ -867,7 +867,7 @@ struct mhi_device_id {kernel_ulong_t driver_data; }; -#define AUXILIARY_NAME_SIZE 32 +#define AUXILIARY_NAME_SIZE 40#define AUXILIARY_MODULE_PREFIX "auxiliary:"struct auxiliary_device_id {
Signature · 1 line
2.34.1
Quoted 3 lines · Raag Jadav
We have an upcoming driver named "
intel_ehl_pse_io". This creates an auxiliary child device for it's GPIO sub-functionality, which matches against "intel_ehl_pse_io.gpio-elkhartlake" and overshoots the current
Looking at the name there is another question: Why do we need 'elkhartlake in the GPIO driver's name now? It's a dup to 'ehl' in the first part.
Quoted 5 lines
maximum limit of 32 bytes for auxiliary device id string. Bump the size to 40 bytes to satisfy such cases.
---
v2: Describe the use case (Greg, Andy)
Thanks for the update!
Signature · 2 lines
With Best Regards, Andy Shevchenko
Quoted 7 lines · Andy Shevchenko
Quoted 3 lines · Raag Jadav
We have an upcoming driver named "
intel_ehl_pse_io". This creates an auxiliary child device for it's GPIO sub-functionality, which matches against "intel_ehl_pse_io.gpio-elkhartlake" and overshoots the currentLooking at the name there is another question: Why do we need 'elkhartlake in the GPIO driver's name now? It's a dup to 'ehl' in the first part.
Just kept it for historic consistency and I'm a bit terrible at naming.
Perhaps "gpio-aux"? But that's too generic from subsystem POV.
Open to suggestions.
Raag
Quoted 7 lines
Quoted 5 lines
maximum limit of 32 bytes for auxiliary device id string. Bump the size to 40 bytes to satisfy such cases.
---
v2: Describe the use case (Greg, Andy)Thanks for the update!
Quoted 10 lines · Raag Jadav
Quoted 7 lines · Andy Shevchenko
Quoted 3 lines · Raag Jadav
We have an upcoming driver named "
intel_ehl_pse_io". This creates an auxiliary child device for it's GPIO sub-functionality, which matches against "intel_ehl_pse_io.gpio-elkhartlake" and overshoots the currentLooking at the name there is another question: Why do we need 'elkhartlake in the GPIO driver's name now? It's a dup to 'ehl' in the first part.
Just kept it for historic consistency and I'm a bit terrible at naming.
I am afraid this alone wouldn't be enough to justify the bump.
Quoted 1 line
Perhaps "gpio-aux"? But that's too generic from subsystem POV.
From the above the simple 'gpio' would suffice (as long as this driver won't be used by name directly, also makes sense to check the sysfs file / folder list to see where it may appear and may or may not clash with the similar driver from other AUX bucket).
Quoted 1 line
Open to suggestions.
Signature · 2 lines
With Best Regards, Andy Shevchenko