regulator: irq_helper: replace use of system_wq with system_dfl_wq
PATCH v2 1/1 regulator: irq_helper: replace use of system_wq with system_dfl_wq
Currently if a user enqueues a work item using schedule_delayed_work() the used wq is "system_wq" (per-cpu wq) while queue_delayed_work() use WORK_CPU_UNBOUND (used when a cpu is not specified). The same applies to schedule_work() that is using system_wq and queue_work(), that makes use again of WORK_CPU_UNBOUND.
This lack of consistency cannot be addressed without refactoring the API.
This continues the effort to refactor worqueue APIs, which has begun with the change introducing new workqueues and a new alloc_workqueue flag:
commit 128ea9f6ccfb ("workqueue: Add system_percpu_wq and system_dfl_wq") commit 930c2ea566af ("workqueue: Add new WQ_PERCPU flag")
This specific workload do not benefit from a per-cpu workqueue, so use the default unbound workqueue (system_dfl_wq) instead.
--- drivers/regulator/irq_helpers.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/regulator/irq_helpers.c +1 -1
@@ -146,7 +146,7 @@ static void regulator_notifier_isr_work(struct work_struct *work) reschedule:if (!d->high_prio) -mod_delayed_work (system_wq, &h->isr_work, +mod_delayed_work (system_dfl_wq, &h->isr_work,msecs_to_jiffies (tmo));else mod_delayed_work(system_highpri_wq, &h->isr_work,
Signature · 1 line
2.51.1
Mark Brown
maintainerQuoted 9 lines · Marco Crivellari
Currently if a user enqueues a work item using
schedule_delayed_work()the used wq is "system_wq" (per-cpu wq) whilequeue_delayed_work()useWORK_CPU_UNBOUND(used when a cpu is not specified). The same applies toschedule_work()that is usingsystem_wqandqueue_work(), that makes use again ofWORK_CPU_UNBOUND.This lack of consistency cannot be addressed without refactoring the API.
[...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next
Thanks!
[1/1] regulator: irq_helper: replace use of system_wq with system_dfl_wq
commit: b6f4bd64f453183954184ffbc2b89d73ed8fb135
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark
Quoted 10 lines · Mark Brown
[...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next
Thanks!
[1/1] regulator:
irq_helper: replace use ofsystem_wqwithsystem_dfl_wqcommit: b6f4bd64f453183954184ffbc2b89d73ed8fb135
Many thanks, Mark!
Signature · 3 lines
Marco Crivellari L3 Support Engineer, Technology & Product