Skip to contentSkip to conversation

libclc: Add misssing quotes around target list

PATCH Superseded Khem Raj 2 participants 3 messages Nov 6, 2025

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Khem Raj

author
#0 lore raw

PATCH 1/1 libclc: Add misssing quotes around target list

Defualt for LIBCLC_TARGETS is all so a single target is ok but when its overidden with a semi-colon separated list to use a subset of targets, e.g.

LIBCLC_TARGETS:class-nativesdk = "amdgcn--;amdgcn--amdhsa;nvptx--;nvptx64--;nvptx--nvidiacl;nvptx64--nvidiacl"

cmake rejects it.

---
 meta/recipes-devtools/clang/libclc_git.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-devtools/clang/libclc_git.bb +1 -1
index 60909339e70..c4b4881542f 100644
@@ -21,7 +21,7 @@ B_NATIVE = "${B}-native"
 # Semicolon-separated list of targets to build
 LIBCLC_TARGETS ?= "all"
 
-EXTRA_OECMAKE += "-DLIBCLC_TARGETS_TO_BUILD=${LIBCLC_TARGETS}"
+EXTRA_OECMAKE += "-DLIBCLC_TARGETS_TO_BUILD='${LIBCLC_TARGETS}'"
 EXTRA_OECMAKE:append:class-target = " -DPREPARE_BUILTINS=${B_NATIVE}/prepare_builtins"
 EXTRA_OECMAKE:append:class-nativesdk = " -DPREPARE_BUILTINS=${B_NATIVE}/prepare_builtins"
 
#1 lore raw
Quoted 2 lines · Khem Raj via lists.openembedded.org

Defualt for LIBCLC_TARGETS is all so a single

there is a typo -> "Defualt"

Quoted 34 lines

target is ok but when its overidden with a semi-colon separated list to use a subset of targets, e.g.

LIBCLC_TARGETS:class-nativesdk = "amdgcn--;amdgcn--amdhsa;nvptx--;nvptx64--;nvptx--nvidiacl;nvptx64--nvidiacl"

cmake rejects it.

---
 meta/recipes-devtools/clang/libclc_git.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-devtools/clang/libclc_git.bb +1 -2
index 60909339e70..c4b4881542f 100644
@@ -21,7 +21,7 @@ B_NATIVE = "${B}-native"
 # Semicolon-separated list of targets to build
 LIBCLC_TARGETS ?= "all"
 
-EXTRA_OECMAKE += "-DLIBCLC_TARGETS_TO_BUILD=${LIBCLC_TARGETS}"
+EXTRA_OECMAKE += "-DLIBCLC_TARGETS_TO_BUILD='${LIBCLC_TARGETS}'"
 EXTRA_OECMAKE:append:class-target = " -DPREPARE_BUILTINS=${B_NATIVE}/prepare_builtins"
 EXTRA_OECMAKE:append:class-nativesdk = " -DPREPARE_BUILTINS=${B_NATIVE}/prepare_builtins"
 
 
-=-=-=-=-=-=-=-=-=-=-=-

Links: You receive all messages sent to this group.
View/Reply Online (#225985): https://lists.openembedded.org/g/openembedded-core/message/225985
Mute This Topic: https://lists.openembedded.org/mt/116157847/3619737
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

author
#2 lore raw
Quoted 7 lines · Ankur Tyagi
Quoted 2 lines · Khem Raj via lists.openembedded.org

Defualt for LIBCLC_TARGETS is all so a single

there is a typo -> "Defualt"

indeed. Thanks

Quoted 42 lines
Quoted 5 lines

target is ok but when its overidden with a semi-colon separated list to use a subset of targets, e.g.

LIBCLC_TARGETS:class-nativesdk =

"amdgcn--;amdgcn--amdhsa;nvptx--;nvptx64--;nvptx--nvidiacl;nvptx64--nvidiacl"

Review

Quoted 9 lines

cmake rejects it.

---
 meta/recipes-devtools/clang/libclc_git.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
(quoted diff) +0 -0

b/meta/recipes-devtools/clang/libclc_git.bb

meta/recipes-devtools/clang/libclc_git.bb B_NATIVE = "${B}-native" · line 25

Quoted 10 lines

index 60909339e70..c4b4881542f 100644

meta/recipes-devtools/clang/libclc_git.bb +1 -1
@@ -21,7 +21,7 @@ B_NATIVE = "${B}-native"
 # Semicolon-separated list of targets to build
 LIBCLC_TARGETS ?= "all"
 
-EXTRA_OECMAKE += "-DLIBCLC_TARGETS_TO_BUILD=${LIBCLC_TARGETS}"
+EXTRA_OECMAKE += "-DLIBCLC_TARGETS_TO_BUILD='${LIBCLC_TARGETS}'"
 EXTRA_OECMAKE:append:class-target = "

-DPREPARE_BUILTINS=${B_NATIVE}/prepare_builtins"

meta/recipes-devtools/clang/libclc_git.bb B_NATIVE = "${B}-native" · line 26

Quoted 1 line
meta/recipes-devtools/clang/libclc_git.bb +0 -0
 EXTRA_OECMAKE:append:class-nativesdk = "

-DPREPARE_BUILTINS=${B_NATIVE}/prepare_builtins"

Quoted 5 lines
meta/recipes-devtools/clang/libclc_git.bb +0 -1
-=-=-=-=-=-=-=-=-=-=-=-

Links: You receive all messages sent to this group. View/Reply Online (#225985):

https://lists.openembedded.org/g/openembedded-core/message/225985

Quoted 3 lines

Mute This Topic: https://lists.openembedded.org/mt/116157847/3619737
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [

[email protected]]

Quoted 2 lines

-=-=-=-=-=-=-=-=-=-=-=-