arm64: dts: rockchip: Turn all LEDs on at boot for Radxa boards
Subsystems (2)
PATCH 1/1 arm64: dts: rockchip: Turn all LEDs on at boot for Radxa boards
Radxa's boards turn all LEDs on at boot(loader), but some boards, e.g. ROCK Pi E don't have default-state property in Linux kernel tree but have it in U-Boot tree[1] instead.
This patch adds default-state = "on" for (almost) all LEDs (with a few exceptions which should be "off" such as RGB LEDs on E25 and LAN/ WAN LEDs on E20C/E52C).
Also, remove following redundant properties:
linux,default-trigger = "default-on"; // use default-state = "on" default-state = "off"; // default is "off"
--- arch/arm64/boot/dts/rockchip/rk3308-rock-pi-s.dts | 1 - arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e.dts | 1 + arch/arm64/boot/dts/rockchip/rk3399-rock-4c-plus.dts | 3 ++- arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi | 1 + arch/arm64/boot/dts/rockchip/rk3528-radxa-e20c.dts | 2 -- arch/arm64/boot/dts/rockchip/rk3528-rock-2a.dts | 1 - arch/arm64/boot/dts/rockchip/rk3566-radxa-cm3-io.dts | 1 + arch/arm64/boot/dts/rockchip/rk3566-rock-3c.dts | 1 + arch/arm64/boot/dts/rockchip/rk3568-radxa-cm3i.dtsi | 1 + arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts | 1 + arch/arm64/boot/dts/rockchip/rk3576-rock-4d.dts | 3 ++- arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts | 2 -- arch/arm64/boot/dts/rockchip/rk3588-rock-5-itx.dts | 3 ++- arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dtsi | 1 + arch/arm64/boot/dts/rockchip/rk3588-rock-5t.dts | 1 + arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts | 3 ++- 16 files changed, 16 insertions(+), 10 deletions(-)
arch/arm64/boot/dts/rockchip/rk3308-rock-pi-s.dts +0 -1
@@ -35,7 +35,6 @@ green-led { function = LED_FUNCTION_POWER; gpios = <&gpio0 RK_PA6 GPIO_ACTIVE_HIGH>; label = "rockpis:green:power"; - linux,default-trigger = "default-on"; }; blue-led {
arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e.dts +1 -0
@@ -59,6 +59,7 @@ leds { led-0 { color = <LED_COLOR_ID_BLUE>; + default-state = "on"; gpios = <&gpio3 RK_PA5 GPIO_ACTIVE_LOW>; linux,default-trigger = "heartbeat"; };
arch/arm64/boot/dts/rockchip/rk3399-rock-4c-plus.dts +2 -1
@@ -39,14 +39,15 @@ leds { led-0 { function = LED_FUNCTION_POWER; color = <LED_COLOR_ID_GREEN>; + default-state = "on"; gpios = <&gpio3 RK_PD4 GPIO_ACTIVE_LOW>; - linux,default-trigger = "default-on"; }; /* USER_LED2 */ led-1 { function = LED_FUNCTION_STATUS; color = <LED_COLOR_ID_BLUE>; + default-state = "on"; gpios = <&gpio3 RK_PD5 GPIO_ACTIVE_HIGH>; linux,default-trigger = "heartbeat"; };
arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi +1 -0
@@ -35,6 +35,7 @@ leds { led-0 { function = LED_FUNCTION_STATUS; color = <LED_COLOR_ID_BLUE>; + default-state = "on"; gpios = <&gpio3 RK_PD5 GPIO_ACTIVE_HIGH>; linux,default-trigger = "heartbeat"; };
arch/arm64/boot/dts/rockchip/rk3528-radxa-e20c.dts +0 -2
@@ -62,7 +62,6 @@ leds { led-lan { color = <LED_COLOR_ID_GREEN>; - default-state = "off"; function = LED_FUNCTION_LAN; gpios = <&gpio4 RK_PB5 GPIO_ACTIVE_HIGH>; linux,default-trigger = "netdev";
@@ -78,7 +77,6 @@ led-sys { led-wan { color = <LED_COLOR_ID_GREEN>; - default-state = "off"; function = LED_FUNCTION_WAN; gpios = <&gpio4 RK_PC0 GPIO_ACTIVE_HIGH>; linux,default-trigger = "netdev";
arch/arm64/boot/dts/rockchip/rk3528-rock-2a.dts +0 -1
@@ -45,7 +45,6 @@ led-1 { default-state = "on"; function = LED_FUNCTION_STATUS; gpios = <&gpio3 RK_PC1 GPIO_ACTIVE_LOW>; - linux,default-trigger = "default-on"; }; };
arch/arm64/boot/dts/rockchip/rk3566-radxa-cm3-io.dts +1 -0
@@ -46,6 +46,7 @@ leds { led-1 { gpios = <&gpio4 RK_PA4 GPIO_ACTIVE_LOW>; color = <LED_COLOR_ID_GREEN>; + default-state = "on"; function = LED_FUNCTION_ACTIVITY; linux,default-trigger = "heartbeat"; pinctrl-names = "default";
arch/arm64/boot/dts/rockchip/rk3566-rock-3c.dts +1 -0
@@ -47,6 +47,7 @@ led-0 { gpios = <&gpio0 RK_PA0 GPIO_ACTIVE_HIGH>; function = LED_FUNCTION_HEARTBEAT; color = <LED_COLOR_ID_BLUE>; + default-state = "on"; linux,default-trigger = "heartbeat"; pinctrl-names = "default"; pinctrl-0 = <&user_led2>;
arch/arm64/boot/dts/rockchip/rk3568-radxa-cm3i.dtsi +1 -0
@@ -23,6 +23,7 @@ led_user: led-0 { gpios = <&gpio0 RK_PA6 GPIO_ACTIVE_HIGH>; function = LED_FUNCTION_HEARTBEAT; color = <LED_COLOR_ID_GREEN>; + default-state = "on"; linux,default-trigger = "heartbeat"; pinctrl-names = "default"; pinctrl-0 = <&led_user_en>;
arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts +1 -0
@@ -47,6 +47,7 @@ led_user: led-0 { gpios = <&gpio0 RK_PB7 GPIO_ACTIVE_HIGH>; function = LED_FUNCTION_HEARTBEAT; color = <LED_COLOR_ID_BLUE>; + default-state = "on"; linux,default-trigger = "heartbeat"; pinctrl-names = "default"; pinctrl-0 = <&led_user_en>;
arch/arm64/boot/dts/rockchip/rk3576-rock-4d.dts +2 -1
@@ -52,13 +52,14 @@ leds: leds { power-led { color = <LED_COLOR_ID_GREEN>; + default-state = "on"; function = LED_FUNCTION_STATUS; gpios = <&gpio0 RK_PB4 GPIO_ACTIVE_HIGH>; - linux,default-trigger = "default-on"; }; user-led { color = <LED_COLOR_ID_BLUE>; + default-state = "on"; function = LED_FUNCTION_HEARTBEAT; gpios = <&gpio0 RK_PC4 GPIO_ACTIVE_LOW>; linux,default-trigger = "heartbeat";
arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts +0 -2
@@ -71,7 +71,6 @@ leds-1 { led-1 { color = <LED_COLOR_ID_GREEN>; - default-state = "off"; function = LED_FUNCTION_LAN; linux,default-trigger = "netdev"; pwms = <&pwm14 0 1000000 PWM_POLARITY_INVERTED>;
@@ -80,7 +79,6 @@ led-1 { led-2 { color = <LED_COLOR_ID_GREEN>; - default-state = "off"; function = LED_FUNCTION_WAN; linux,default-trigger = "netdev"; pwms = <&pwm11 0 1000000 PWM_POLARITY_INVERTED>;
arch/arm64/boot/dts/rockchip/rk3588-rock-5-itx.dts +2 -1
@@ -88,11 +88,12 @@ gpio-leds { pinctrl-0 = <&led_pins>; power-led1 { + default-state = "on"; gpios = <&gpio0 RK_PB7 GPIO_ACTIVE_HIGH>; - linux,default-trigger = "default-on"; }; hdd-led2 { + default-state = "on"; gpios = <&gpio0 RK_PC0 GPIO_ACTIVE_HIGH>; linux,default-trigger = "disk-activity"; };
arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dtsi +1 -0
@@ -30,6 +30,7 @@ leds { led_rgb_b { function = LED_FUNCTION_STATUS; color = <LED_COLOR_ID_BLUE>; + default-state = "on"; gpios = <&gpio0 RK_PB7 GPIO_ACTIVE_HIGH>; linux,default-trigger = "heartbeat"; };
arch/arm64/boot/dts/rockchip/rk3588-rock-5t.dts +1 -0
@@ -33,6 +33,7 @@ leds { led_rgb_b { function = LED_FUNCTION_STATUS; color = <LED_COLOR_ID_BLUE>; + default-state = "on"; gpios = <&gpio0 RK_PA0 GPIO_ACTIVE_HIGH>; linux,default-trigger = "heartbeat"; };
arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts +2 -1
@@ -54,6 +54,7 @@ leds { io-led { color = <LED_COLOR_ID_BLUE>; + default-state = "on"; function = LED_FUNCTION_STATUS; gpios = <&gpio3 RK_PD5 GPIO_ACTIVE_HIGH>; linux,default-trigger = "heartbeat";
@@ -61,9 +62,9 @@ io-led { power-led { color = <LED_COLOR_ID_GREEN>; + default-state = "on"; function = LED_FUNCTION_POWER; gpios = <&gpio3 RK_PC4 GPIO_ACTIVE_HIGH>; - linux,default-trigger = "default-on"; }; };
Signature · 7 lines
2.43.0 _______________________________________________ Linux-rockchip mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-rockchip
Hi,
Quoted 8 lines · FUKAUMI Naoki
Radxa's boards turn all LEDs on at boot(loader), but some boards, e.g. ROCK Pi E don't have
default-stateproperty in Linux kernel tree but have it in U-Boot tree[1] instead.This patch adds
default-state = "on"for (almost) all LEDs (with a few exceptions which should be "off" such as RGB LEDs on E25 and LAN/ WAN LEDs on E20C/E52C).
Quoted 5 lines
Also, remove following redundant properties:
linux,default-trigger = "default-on"; // use default-state = "on" default-state = "off"; // default is "off"
I'll add the following as a reference:
https://source.denx.de/u-boot/u-boot/-/blob/v2025.10/arch/arm/dts/rk3399-rock-4c-plus-u-boot.dtsi#L11-17
https://source.denx.de/u-boot/u-boot/-/blob/v2025.10/arch/arm/dts/rk3399-rock-pi-4-u-boot.dtsi#L11-13
https://source.denx.de/u-boot/u-boot/-/blob/v2025.10/arch/arm/dts/rk3566-radxa-cm3-io-u-boot.dtsi#L10-12
https://source.denx.de/u-boot/u-boot/-/blob/v2025.10/arch/arm/dts/rk3566-rock-3c-u-boot.dtsi#L14-16
https://source.denx.de/u-boot/u-boot/-/blob/v2025.10/arch/arm/dts/rk3568-radxa-e25-u-boot.dtsi#L7-24
https://source.denx.de/u-boot/u-boot/-/blob/v2025.10/arch/arm/dts/rk3568-rock-3a-u-boot.dtsi#L11-13
https://source.denx.de/u-boot/u-boot/-/blob/v2025.10/arch/arm/dts/rk3588-rock-5b-u-boot.dtsi#L11-13
https://source.denx.de/u-boot/u-boot/-/blob/v2025.10/arch/arm/dts/rk3588-rock-5b-u-boot.dtsi#L11-13
Best regards,
--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.
Quoted 262 lines
Signed-off-by FUKAUMI Naoki <[email protected]>--- arch/arm64/boot/dts/rockchip/rk3308-rock-pi-s.dts | 1 - arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e.dts | 1 + arch/arm64/boot/dts/rockchip/rk3399-rock-4c-plus.dts | 3 ++- arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi | 1 + arch/arm64/boot/dts/rockchip/rk3528-radxa-e20c.dts | 2 -- arch/arm64/boot/dts/rockchip/rk3528-rock-2a.dts | 1 - arch/arm64/boot/dts/rockchip/rk3566-radxa-cm3-io.dts | 1 + arch/arm64/boot/dts/rockchip/rk3566-rock-3c.dts | 1 + arch/arm64/boot/dts/rockchip/rk3568-radxa-cm3i.dtsi | 1 + arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts | 1 + arch/arm64/boot/dts/rockchip/rk3576-rock-4d.dts | 3 ++- arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts | 2 -- arch/arm64/boot/dts/rockchip/rk3588-rock-5-itx.dts | 3 ++- arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dtsi | 1 + arch/arm64/boot/dts/rockchip/rk3588-rock-5t.dts | 1 + arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts | 3 ++- 16 files changed, 16 insertions(+), 10 deletions(-)arch/arm64/boot/dts/rockchip/rk3308-rock-pi-s.dts +0
-1@@ -35,7 +35,6 @@ green-led { function = LED_FUNCTION_POWER; gpios = <&gpio0 RK_PA6 GPIO_ACTIVE_HIGH>; label = "rockpis:green:power"; - linux,default-trigger = "default-on"; }; blue-led {arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e.dts +1
-0@@ -59,6 +59,7 @@ leds { led-0 { color = <LED_COLOR_ID_BLUE>; + default-state = "on"; gpios = <&gpio3 RK_PA5 GPIO_ACTIVE_LOW>; linux,default-trigger = "heartbeat"; };arch/arm64/boot/dts/rockchip/rk3399-rock-4c-plus.dts +2
-1@@ -39,14 +39,15 @@ leds { led-0 { function = LED_FUNCTION_POWER; color = <LED_COLOR_ID_GREEN>; + default-state = "on"; gpios = <&gpio3 RK_PD4 GPIO_ACTIVE_LOW>; - linux,default-trigger = "default-on"; }; /* USER_LED2 */ led-1 { function = LED_FUNCTION_STATUS; color = <LED_COLOR_ID_BLUE>; + default-state = "on"; gpios = <&gpio3 RK_PD5 GPIO_ACTIVE_HIGH>; linux,default-trigger = "heartbeat"; };arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi +1
-0@@ -35,6 +35,7 @@ leds { led-0 { function = LED_FUNCTION_STATUS; color = <LED_COLOR_ID_BLUE>; + default-state = "on"; gpios = <&gpio3 RK_PD5 GPIO_ACTIVE_HIGH>; linux,default-trigger = "heartbeat"; };arch/arm64/boot/dts/rockchip/rk3528-radxa-e20c.dts +0
-2@@ -62,7 +62,6 @@ leds { led-lan { color = <LED_COLOR_ID_GREEN>; - default-state = "off"; function = LED_FUNCTION_LAN; gpios = <&gpio4 RK_PB5 GPIO_ACTIVE_HIGH>; linux,default-trigger = "netdev";@@ -78,7 +77,6 @@ led-sys { led-wan { color = <LED_COLOR_ID_GREEN>; - default-state = "off"; function = LED_FUNCTION_WAN; gpios = <&gpio4 RK_PC0 GPIO_ACTIVE_HIGH>; linux,default-trigger = "netdev";arch/arm64/boot/dts/rockchip/rk3528-rock-2a.dts +0
-1@@ -45,7 +45,6 @@ led-1 { default-state = "on"; function = LED_FUNCTION_STATUS; gpios = <&gpio3 RK_PC1 GPIO_ACTIVE_LOW>; - linux,default-trigger = "default-on"; }; };arch/arm64/boot/dts/rockchip/rk3566-radxa-cm3-io.dts +1
-0@@ -46,6 +46,7 @@ leds { led-1 { gpios = <&gpio4 RK_PA4 GPIO_ACTIVE_LOW>; color = <LED_COLOR_ID_GREEN>; + default-state = "on"; function = LED_FUNCTION_ACTIVITY; linux,default-trigger = "heartbeat"; pinctrl-names = "default";arch/arm64/boot/dts/rockchip/rk3566-rock-3c.dts +1
-0@@ -47,6 +47,7 @@ led-0 { gpios = <&gpio0 RK_PA0 GPIO_ACTIVE_HIGH>; function = LED_FUNCTION_HEARTBEAT; color = <LED_COLOR_ID_BLUE>; + default-state = "on"; linux,default-trigger = "heartbeat"; pinctrl-names = "default"; pinctrl-0 = <&user_led2>;arch/arm64/boot/dts/rockchip/rk3568-radxa-cm3i.dtsi +1
-0@@ -23,6 +23,7 @@ led_user: led-0 { gpios = <&gpio0 RK_PA6 GPIO_ACTIVE_HIGH>; function = LED_FUNCTION_HEARTBEAT; color = <LED_COLOR_ID_GREEN>; + default-state = "on"; linux,default-trigger = "heartbeat"; pinctrl-names = "default"; pinctrl-0 = <&led_user_en>;arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts +1
-0@@ -47,6 +47,7 @@ led_user: led-0 { gpios = <&gpio0 RK_PB7 GPIO_ACTIVE_HIGH>; function = LED_FUNCTION_HEARTBEAT; color = <LED_COLOR_ID_BLUE>; + default-state = "on"; linux,default-trigger = "heartbeat"; pinctrl-names = "default"; pinctrl-0 = <&led_user_en>;arch/arm64/boot/dts/rockchip/rk3576-rock-4d.dts +2
-1@@ -52,13 +52,14 @@ leds: leds { power-led { color = <LED_COLOR_ID_GREEN>; + default-state = "on"; function = LED_FUNCTION_STATUS; gpios = <&gpio0 RK_PB4 GPIO_ACTIVE_HIGH>; - linux,default-trigger = "default-on"; }; user-led { color = <LED_COLOR_ID_BLUE>; + default-state = "on"; function = LED_FUNCTION_HEARTBEAT; gpios = <&gpio0 RK_PC4 GPIO_ACTIVE_LOW>; linux,default-trigger = "heartbeat";arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts +0
-2@@ -71,7 +71,6 @@ leds-1 { led-1 { color = <LED_COLOR_ID_GREEN>; - default-state = "off"; function = LED_FUNCTION_LAN; linux,default-trigger = "netdev"; pwms = <&pwm14 0 1000000 PWM_POLARITY_INVERTED>;@@ -80,7 +79,6 @@ led-1 { led-2 { color = <LED_COLOR_ID_GREEN>; - default-state = "off"; function = LED_FUNCTION_WAN; linux,default-trigger = "netdev"; pwms = <&pwm11 0 1000000 PWM_POLARITY_INVERTED>;arch/arm64/boot/dts/rockchip/rk3588-rock-5-itx.dts +2
-1@@ -88,11 +88,12 @@ gpio-leds { pinctrl-0 = <&led_pins>; power-led1 { + default-state = "on"; gpios = <&gpio0 RK_PB7 GPIO_ACTIVE_HIGH>; - linux,default-trigger = "default-on"; }; hdd-led2 { + default-state = "on"; gpios = <&gpio0 RK_PC0 GPIO_ACTIVE_HIGH>; linux,default-trigger = "disk-activity"; };arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dtsi +1
-0@@ -30,6 +30,7 @@ leds { led_rgb_b { function = LED_FUNCTION_STATUS; color = <LED_COLOR_ID_BLUE>; + default-state = "on"; gpios = <&gpio0 RK_PB7 GPIO_ACTIVE_HIGH>; linux,default-trigger = "heartbeat"; };arch/arm64/boot/dts/rockchip/rk3588-rock-5t.dts +1
-0@@ -33,6 +33,7 @@ leds { led_rgb_b { function = LED_FUNCTION_STATUS; color = <LED_COLOR_ID_BLUE>; + default-state = "on"; gpios = <&gpio0 RK_PA0 GPIO_ACTIVE_HIGH>; linux,default-trigger = "heartbeat"; };arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts +2
-1@@ -54,6 +54,7 @@ leds { io-led { color = <LED_COLOR_ID_BLUE>; + default-state = "on"; function = LED_FUNCTION_STATUS; gpios = <&gpio3 RK_PD5 GPIO_ACTIVE_HIGH>; linux,default-trigger = "heartbeat";@@ -61,9 +62,9 @@ io-led { power-led { color = <LED_COLOR_ID_GREEN>; + default-state = "on"; function = LED_FUNCTION_POWER; gpios = <&gpio3 RK_PC4 GPIO_ACTIVE_HIGH>; - linux,default-trigger = "default-on"; }; };