mm-huge_memory-preserve-pg_has_hwpoisoned-if-a-folio-is-split-to-0-order.patch removed from -mm tree
The quilt patch titled
Subject: mm/huge_memory: preserve PG_has_hwpoisoned if a folio is split to >0 order
has been removed from the -mm tree. Its filename was
mm-huge_memory-preserve-pg_has_hwpoisoned-if-a-folio-is-split-to-0-order.patch
This patch was dropped because it was merged into the mm-hotfixes-stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
------------------------------------------------------
From: Zi Yan <[email protected]>
Subject: mm/huge_memory: preserve PG_has_hwpoisoned if a folio is split to >0 order
Date: Wed, 22 Oct 2025 23:05:21 -0400
folio split clears PG_has_hwpoisoned, but the flag should be preserved in after-split folios containing pages with PG_hwpoisoned flag if the folio is split to >0 order folios. Scan all pages in a to-be-split folio to determine which after-split folios need the flag.
An alternatives is to change PG_has_hwpoisoned to PG_maybe_hwpoisoned to avoid the scan and set it on all after-split folios, but resulting false positive has undesirable negative impact. To remove false positive, caller of folio_test_has_hwpoisoned() and folio_contain_hwpoisoned_page() needs to do the scan. That might be causing a hassle for current and future callers and more costly than doing the scan in the split code. More details are discussed in [1].
This issue can be exposed via:
1. splitting a has_hwpoisoned folio to >0 order from debugfs interface;
2. truncating part of a has_hwpoisoned folio in truncate_inode_partial_folio().
And later accesses to a hwpoisoned page could be possible due to the missing has_hwpoisoned folio flag. This will lead to MCE errors.
---
mm/huge_memory.c | 23 ++++++++++++++++++++--- 1 file changed, 20 insertions(+), 3 deletions(-)
mm/huge_memory.c renamed from mm/huge_memory.c~mm-huge_memory-preserve-pg_has_hwpoisoned-if-a-folio-is-split-to-0-order +20 -3
@@ -3263,6 +3263,14 @@ bool can_split_folio(struct folio *folio caller_pins; } +static bool page_range_has_hwpoisoned (struct page *page,long nr_pages) +{ +for (; nr_pages; page++, nr_pages--) +if (PageHWPoison (page)) +return true; +return false; +} +/* * It splits @folio into @new_order folios and copies the @folio metadata to * all the resulting folios.
@@ -3270,17 +3278,24 @@ bool can_split_folio(struct folio *foliostatic void __split_folio_to_order (struct folio *folio,int old_order,int new_order) { +/* Scan poisoned pages when split a poisoned folio to large folios */ +const bool handle_hwpoison =folio_test_has_hwpoisoned (folio) && new_order;long new_nr_pages =1 << new_order;long nr_pages =1 << old_order;long i; +folio_clear_has_hwpoisoned (folio); + +/* Check first new_nr_pages since the loop below skips them */ +if (handle_hwpoison && +page_range_has_hwpoisoned (folio_page (folio,0 ), new_nr_pages)) +folio_set_has_hwpoisoned (folio);/* * Skip the first new_nr_pages, since the new folio from them have all * the flags from the original folio. */ for (i = new_nr_pages; i < nr_pages; i += new_nr_pages) {struct page *new_head = &folio->page + i; -/* * Careful: new_folio is not a "real" folio before we cleared PageTail. * Don't pass it around before clear_compound_head().
@@ -3322,6 +3337,10 @@ static void __split_folio_to_order(struc (1L << PG_dirty) | LRU_GEN_MASK | LRU_REFS_MASK)); +if (handle_hwpoison && +page_range_has_hwpoisoned (new_head, new_nr_pages)) +folio_set_has_hwpoisoned (new_folio); + new_folio->mapping = folio->mapping; new_folio->index = folio->index + i;
@@ -3422,8 +3441,6 @@ static int __split_unmapped_folio(structif (folio_test_anon (folio))mod_mthp_stat (order,MTHP_STAT_NR_ANON ,-1 ); -folio_clear_has_hwpoisoned (folio); -/* * split to new_order one order at a time. For uniform split, * folio is split to new_order directly.
_
Patches currently in -mm which might be from [email protected] are
mm-huge_memory-fix-folio-split-check-for-anon-folios-in-swapcache.patch mm-huge_memory-add-split_huge_page_to_order.patch mm-memory-failure-improve-large-block-size-folio-handling.patch mm-huge_memory-fix-kernel-doc-comments-for-folio_split-and-related.patch mm-huge_memory-fix-kernel-doc-comments-for-folio_split-and-related-fix.patch mm-huge_memory-fix-kernel-doc-comments-for-folio_split-and-related-fix-2.patch migrate-optimise-alloc_migration_target-fix.patch