mm: vmstat: correct the comment above preempt_disable_nested()
Subsystems (2)
PATCH 1/1 mm: vmstat: correct the comment above preempt_disable_nested()
From: Qi Zheng <[email protected]>
The comment explaining why these parts use preempt_disable_nested() is in __mod_zone_page_state(), not in __mod_node_page_state(), so we should see __mod_zone_page_state(). Just correct it.
--- mm/vmstat.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
mm/vmstat.c +5 -5
@@ -392,7 +392,7 @@ void __mod_node_page_state(struct pglist_data *pgdat, enum node_stat_item item, delta >>=PAGE_SHIFT ; } -/* See __mod_node_page_state */ +/* See __mod_zone_page_state() */ preempt_disable_nested (); x = delta +__this_cpu_read (*p);
@@ -438,7 +438,7 @@ void __inc_zone_state(struct zone *zone, enum zone_stat_item item)s8 __percpu *p = pcp->vm_stat_diff + item;s8 v, t; -/* See __mod_node_page_state */ +/* See __mod_zone_page_state() */ preempt_disable_nested (); v =__this_cpu_inc_return (*p);
@@ -461,7 +461,7 @@ void __inc_node_state(struct pglist_data *pgdat, enum node_stat_item item)VM_WARN_ON_ONCE (vmstat_item_in_bytes (item)); -/* See __mod_node_page_state */ +/* See __mod_zone_page_state() */ preempt_disable_nested (); v =__this_cpu_inc_return (*p);
@@ -494,7 +494,7 @@ void __dec_zone_state(struct zone *zone, enum zone_stat_item item)s8 __percpu *p = pcp->vm_stat_diff + item;s8 v, t; -/* See __mod_node_page_state */ +/* See __mod_zone_page_state() */ preempt_disable_nested (); v =__this_cpu_dec_return (*p);
@@ -517,7 +517,7 @@ void __dec_node_state(struct pglist_data *pgdat, enum node_stat_item item)VM_WARN_ON_ONCE (vmstat_item_in_bytes (item)); -/* See __mod_node_page_state */ +/* See __mod_zone_page_state() */ preempt_disable_nested (); v =__this_cpu_dec_return (*p);
Signature · 1 line
2.20.1
Quoted 7 lines · Qi Zheng
From: Qi Zheng <[email protected]>
The comment explaining why these parts use
preempt_disable_nested()is in__mod_zone_page_state(), not in__mod_node_page_state(), so we should see__mod_zone_page_state(). Just correct it.Signed-off-by Qi Zheng <[email protected]>
Quoted 53 lines
--- mm/vmstat.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)mm/vmstat.c +5
-5@@ -392,7 +392,7 @@ void __mod_node_page_state(struct pglist_data *pgdat, enum node_stat_item item, delta >>=PAGE_SHIFT ; } -/* See __mod_node_page_state */ +/* See __mod_zone_page_state() */ preempt_disable_nested (); x = delta +__this_cpu_read (*p);@@ -438,7 +438,7 @@ void __inc_zone_state(struct zone *zone, enum zone_stat_item item)s8 __percpu *p = pcp->vm_stat_diff + item;s8 v, t; -/* See __mod_node_page_state */ +/* See __mod_zone_page_state() */ preempt_disable_nested (); v =__this_cpu_inc_return (*p);@@ -461,7 +461,7 @@ void __inc_node_state(struct pglist_data *pgdat, enum node_stat_item item)VM_WARN_ON_ONCE (vmstat_item_in_bytes (item)); -/* See __mod_node_page_state */ +/* See __mod_zone_page_state() */ preempt_disable_nested (); v =__this_cpu_inc_return (*p);@@ -494,7 +494,7 @@ void __dec_zone_state(struct zone *zone, enum zone_stat_item item)s8 __percpu *p = pcp->vm_stat_diff + item;s8 v, t; -/* See __mod_node_page_state */ +/* See __mod_zone_page_state() */ preempt_disable_nested (); v =__this_cpu_dec_return (*p);@@ -517,7 +517,7 @@ void __dec_node_state(struct pglist_data *pgdat, enum node_stat_item item)VM_WARN_ON_ONCE (vmstat_item_in_bytes (item)); -/* See __mod_node_page_state */ +/* See __mod_zone_page_state() */ preempt_disable_nested (); v =__this_cpu_dec_return (*p);
Quoted 8 lines · Qi Zheng
From: Qi Zheng <[email protected]>
The comment explaining why these parts use
preempt_disable_nested()is in__mod_zone_page_state(), not in__mod_node_page_state(), so we should see__mod_zone_page_state(). Just correct it.Signed-off-by Qi Zheng <[email protected]>---
Yeah I was confused when all these comments says "See __mod_node_page_state()" But even in the function it says "See __mod_node_page_state()" :)
Thanks for fixing it!
Signature · 2 lines
Cheers, Harry / Hyeonggon