arm64: dts: rockchip: Fix eeprom description for Radxa ROCK 3C/5A/5C
Subsystems (2)
cover arm64: dts: rockchip: Fix eeprom description for Radxa ROCK 3C/5A/5C
This patch series fixes incorrect or missing entries related to the eeprom on the Radxa ROCK 3C, 5A, and 5C.
FUKAUMI Naoki (4):
arm64: dts: rockchip: Move eeprom correct bus for Radxa ROCK 5A
arm64: dts: rockchip: Add eeprom vcc-supply for Radxa ROCK 5A
arm64: dts: rockchip: Add eeprom vcc-supply for Radxa ROCK 3C
arm64: dts: rockchip: Make eeprom read-only for Radxa ROCK 3C/5A/5C
arch/arm64/boot/dts/rockchip/rk3566-rock-3c.dts | 2 ++ arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts | 16 +++++++++------- arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts | 1 + 3 files changed, 12 insertions(+), 7 deletions(-)
Signature · 7 lines
2.43.0 _______________________________________________ Linux-rockchip mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-rockchip
PATCH 1/4 arm64: dts: rockchip: Move eeprom correct bus for Radxa ROCK 5A
BL24C16 EEPROM chip found on Radxa ROCK 5A is connected on i2c0 bus. Move eeprom node from i2c2 to i2c0.
--- arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts +6 -6
@@ -228,6 +228,12 @@ regulator-state-mem { regulator-off-in-suspend; }; }; + + eeprom: eeprom@50 { + compatible = "belling,bl24c16a", "atmel,24c16"; + reg = <0x50>; + pagesize = <16>; + }; }; &i2c2 {
@@ -249,12 +255,6 @@ regulator-state-mem { regulator-off-in-suspend; }; }; - - eeprom: eeprom@50 { - compatible = "belling,bl24c16a", "atmel,24c16"; - reg = <0x50>; - pagesize = <16>; - }; }; &i2c3 {
Signature · 7 lines
2.43.0 _______________________________________________ Linux-rockchip mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-rockchip
Re: [PATCH 1/4] arm64: dts: rockchip: Move eeprom correct bus for Radxa ROCK 5A
Hello Naoki,
Thanks for this patch. Please, see a couple of remarks below.
Quoted 2 lines · FUKAUMI Naoki
BL24C16 EEPROM chip found on Radxa ROCK 5A is connected on i2c0 bus. Move eeprom node from i2c2 to i2c0.
I'd suggest that the patch subject is reworded a bit like this:
arm64: dts: rockchip: Move the EEPROM to correct I2C bus on Radxa ROCK 5A
Also, the patch description would benefit from becoming reworded like this:
The BL24C16 EEPROM chip found on Radxa ROCK 5A is connected to the i2c0 bus, [1] so move the eeprom node from the i2c2 bus to the i2c0 bus.
[1] https://dl.radxa.com/rock5/5a/docs/hw/radxa_rock5a_V1.1_sch.pdf, pp. 19
Quoted 2 lines
Fixes 89c880808cff8 ("arm64: dts: rockchip: add I2C EEPROM to rock-5a")
The suggestion above also shows how it would be better to use explicitly placed references, instead of just placing them into the Links lines, because that places the refernces closer to the backed contents. This isn't critical in this case, because there isn't much contents, but it's a good practice nonetheless.
Quoted 35 lines
Signed-off-by FUKAUMI Naoki <[email protected]>--- arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts +6
-6@@ -228,6 +228,12 @@ regulator-state-mem { regulator-off-in-suspend; }; }; + + eeprom: eeprom@50 { + compatible = "belling,bl24c16a", "atmel,24c16"; + reg = <0x50>; + pagesize = <16>; + }; }; &i2c2 {@@ -249,12 +255,6 @@ regulator-state-mem { regulator-off-in-suspend; }; }; - - eeprom: eeprom@50 { - compatible = "belling,bl24c16a", "atmel,24c16"; - reg = <0x50>; - pagesize = <16>; - }; }; &i2c3 {
PATCH 2/4 arm64: dts: rockchip: Add eeprom vcc-supply for Radxa ROCK 5A
In reply to FUKAUMI NaokiThe VCC supply for the BL24C16 EEPROM chip found on Radxa ROCK 5A is vcc_3v3_pmu, which is routed to vcc_3v3_s3 via a zero-ohm resistor. Describe this supply.
--- arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts +2 -1
@@ -233,6 +233,7 @@ eeprom: eeprom@50 { compatible = "belling,bl24c16a", "atmel,24c16"; reg = <0x50>; pagesize = <16>; + vcc-supply = <&vcc_3v3_pmu>; }; };
@@ -600,7 +601,7 @@ regulator-state-mem { }; }; - vcc_3v3_s3: dcdc-reg8 { + vcc_3v3_pmu: vcc_3v3_s3: dcdc-reg8 { regulator-name = "vcc_3v3_s3"; regulator-always-on; regulator-boot-on;
Signature · 7 lines
2.43.0 _______________________________________________ Linux-rockchip mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-rockchip
Re: [PATCH 2/4] arm64: dts: rockchip: Add eeprom vcc-supply for Radxa ROCK 5A
Hello Naoki,
Thanks for this patch. Please, see one remark below.
Quoted 6 lines · FUKAUMI Naoki
The VCC supply for the BL24C16 EEPROM chip found on Radxa ROCK 5A is
vcc_3v3_pmu, which is routed tovcc_3v3_s3via a zero-ohm resistor. Describe this supply.Fixes 89c880808cff8 ("arm64: dts: rockchip: add I2C EEPROM to rock-5a")
The same suggestion about using explicitly placed references, from the patch 1/4 in this series, applies here as well.
Quoted 26 lines
Signed-off-by FUKAUMI Naoki <[email protected]>--- arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts +2
-1@@ -233,6 +233,7 @@ eeprom: eeprom@50 { compatible = "belling,bl24c16a", "atmel,24c16"; reg = <0x50>; pagesize = <16>; + vcc-supply = <&vcc_3v3_pmu>; }; };@@ -600,7 +601,7 @@ regulator-state-mem { }; }; - vcc_3v3_s3: dcdc-reg8 { + vcc_3v3_pmu: vcc_3v3_s3: dcdc-reg8 { regulator-name = "vcc_3v3_s3"; regulator-always-on; regulator-boot-on;
PATCH 3/4 arm64: dts: rockchip: Add eeprom vcc-supply for Radxa ROCK 3C
In reply to FUKAUMI NaokiThe VCC supply for the BL24C16 EEPROM chip found on Radxa ROCK 3C is vcca1v8_pmu.
Describe this supply.
--- arch/arm64/boot/dts/rockchip/rk3566-rock-3c.dts | 1 + 1 file changed, 1 insertion(+)
arch/arm64/boot/dts/rockchip/rk3566-rock-3c.dts +1 -0
@@ -466,6 +466,7 @@ eeprom: eeprom@50 { compatible = "belling,bl24c16a", "atmel,24c16"; reg = <0x50>; pagesize = <16>; + vcc-supply = <&vcca1v8_pmu>; }; };
Signature · 7 lines
2.43.0 _______________________________________________ Linux-rockchip mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-rockchip
Re: [PATCH 3/4] arm64: dts: rockchip: Add eeprom vcc-supply for Radxa ROCK 3C
Hello Naoki,
Thanks for this patch. Please, see a couple of remarks below.
Quoted 2 lines · FUKAUMI Naoki
The VCC supply for the BL24C16 EEPROM chip found on Radxa ROCK 3C is
vcca1v8_pmu.
There's no need for a line break here.
Quoted 4 lines
Describe this supply.
Fixes ee219017ddb50 ("arm64: dts: rockchip: Add Radxa ROCK 3C")
The same suggestion about using explicitly placed references, from the patch 1/4 in this series, applies here as well.
Quoted 16 lines
Signed-off-by FUKAUMI Naoki <[email protected]>--- arch/arm64/boot/dts/rockchip/rk3566-rock-3c.dts | 1 + 1 file changed, 1 insertion(+)arch/arm64/boot/dts/rockchip/rk3566-rock-3c.dts +1
-0@@ -466,6 +466,7 @@ eeprom: eeprom@50 { compatible = "belling,bl24c16a", "atmel,24c16"; reg = <0x50>; pagesize = <16>; + vcc-supply = <&vcca1v8_pmu>; }; };
PATCH 4/4 arm64: dts: rockchip: Make eeprom read-only for Radxa ROCK 3C/5A/5C
In reply to FUKAUMI NaokiMake the BL24C16 EEPROM chips found on Radxa ROCK 3C, 5A and 5C SBCs read-only, because they contain factory-programmed data that isn't supposed to be modified by the end users.
--- arch/arm64/boot/dts/rockchip/rk3566-rock-3c.dts | 1 + arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts | 1 + arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts | 1 + 3 files changed, 3 insertions(+)
arch/arm64/boot/dts/rockchip/rk3566-rock-3c.dts +1 -0
@@ -466,6 +466,7 @@ eeprom: eeprom@50 { compatible = "belling,bl24c16a", "atmel,24c16"; reg = <0x50>; pagesize = <16>; + read-only; vcc-supply = <&vcca1v8_pmu>; }; };
arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts +1 -0
@@ -233,6 +233,7 @@ eeprom: eeprom@50 { compatible = "belling,bl24c16a", "atmel,24c16"; reg = <0x50>; pagesize = <16>; + read-only; vcc-supply = <&vcc_3v3_pmu>; }; };
arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts +1 -0
@@ -325,6 +325,7 @@ eeprom@50 { compatible = "belling,bl24c16a", "atmel,24c16"; reg = <0x50>; pagesize = <16>; + read-only; vcc-supply = <&vcc_3v3_pmu>; }; };
Signature · 7 lines
2.43.0 _______________________________________________ Linux-rockchip mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-rockchip
Re: [PATCH 4/4] arm64: dts: rockchip: Make eeprom read-only for Radxa ROCK 3C/5A/5C
Hello Naoki,
Thanks for this patch. Please, see one remark below.
Quoted 11 lines · FUKAUMI Naoki
Make the BL24C16 EEPROM chips found on Radxa ROCK 3C, 5A and 5C SBCs read-only, because they contain factory-programmed data that isn't supposed to be modified by the end users.
Fixes ee219017ddb50 ("arm64: dts: rockchip: Add Radxa ROCK 3C")Fixes 89c880808cff8 ("arm64: dts: rockchip: add I2C EEPROM to rock-5a")Fixes 3ddf5cdb77e6e ("arm64: dts: rockchip: add Radxa ROCK 5C")
The same suggestion about using explicitly placed references, from the patch 1/4 in this series, applies here as well.
Quoted 43 lines
Signed-off-by FUKAUMI Naoki <[email protected]>--- arch/arm64/boot/dts/rockchip/rk3566-rock-3c.dts | 1 + arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts | 1 + arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts | 1 + 3 files changed, 3 insertions(+)arch/arm64/boot/dts/rockchip/rk3566-rock-3c.dts +1
-0@@ -466,6 +466,7 @@ eeprom: eeprom@50 { compatible = "belling,bl24c16a", "atmel,24c16"; reg = <0x50>; pagesize = <16>; + read-only; vcc-supply = <&vcca1v8_pmu>; }; };arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts +1
-0@@ -233,6 +233,7 @@ eeprom: eeprom@50 { compatible = "belling,bl24c16a", "atmel,24c16"; reg = <0x50>; pagesize = <16>; + read-only; vcc-supply = <&vcc_3v3_pmu>; }; };arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts +1
-0@@ -325,6 +325,7 @@ eeprom@50 { compatible = "belling,bl24c16a", "atmel,24c16"; reg = <0x50>; pagesize = <16>; + read-only; vcc-supply = <&vcc_3v3_pmu>; }; };
Hello Naoki,
Quoted 2 lines · FUKAUMI Naoki
This patch series fixes incorrect or missing entries related to the eeprom on the Radxa ROCK 3C, 5A, and 5C.
In general, there's no need for the standard prefixes in the subjects of cover letters. Thus, in this case the subject could be reworded like this:
Fix and improve EEPROM chip descriptions for Radxa ROCK 3C, 5A and 5C
Quoted 14 lines
FUKAUMI Naoki (4):
arm64: dts: rockchip: Move eeprom correct bus for Radxa ROCK 5A
arm64: dts: rockchip: Add eeprom vcc-supply for Radxa ROCK 5A
arm64: dts: rockchip: Add eeprom vcc-supply for Radxa ROCK 3C
arm64: dts: rockchip: Make eeprom read-only for Radxa ROCK 3C/5A/5Carch/arm64/boot/dts/rockchip/rk3566-rock-3c.dts | 2 ++ arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts | 16 +++++++++------- arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts | 1 + 3 files changed, 12 insertions(+), 7 deletions(-)Signature · 1 line
2.43.0