Skip to contentSkip to conversation

ASoC: SOF: sof-client-probes: Replace snprintf() with scnprintf()

PATCH In review [email protected] 2 participants 2 messages Nov 11, 2025 – Nov 19, 2025

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: SOF: sof-client-probes: Replace snprintf() with scnprintf()

From: HariKrishna Sagala <[email protected]>

As per the C99 standard snprintf() returns the length of the data that *would have been* written if there were enough space for it. It's generally considered safer to use the scnprintf() variant.

---
This patch replaces snprintf() varaint with scnprintf() in scenario to know the actual length of the data rather than *would have been* written data of snprintf().
No functional changes intended.
Reference Links:
https://lwn.net/Articles/69419/
https://www.kernel.org/doc/html/latest/core-api/kernel-api.html#c.snprintf

Note:
*Compile & boot* tested.(CONFIG_SND_SOC_SOF_IPC4=y)

Thank you.

 sound/soc/sof/sof-client-probes-ipc4.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/sof/sof-client-probes-ipc4.c +1 -1
index 758a56d271d7..d3fa37106b64 100644
@@ -289,7 +289,7 @@ static int ipc4_probes_point_print(struct sof_client_dev *cdev, char *buf, size_
 			__func__, SOF_IPC4_MOD_ID_GET(desc->buffer_id),
 			SOF_IPC4_MOD_INSTANCE_GET(desc->buffer_id));
 
-	ret = snprintf(buf, size, "%#x,%#x,%#x\t%s %s buf idx %lu %s\n",
+	ret = scnprintf(buf, size, "%#x,%#x,%#x\t%s %s buf idx %lu %s\n",
 		       desc->buffer_id, desc->purpose, desc->stream_tag,
 		       swidget ? swidget->widget->name : "<unknown>",
 		       sof_probe_ipc4_type_string(SOF_IPC4_PROBE_TYPE_GET(desc->buffer_id)),

base-commit: 4427259cc7f7571a157fbc9b5011e1ef6fe0a4a8

Signature · 1 line
2.43.0
maintainer
#1 lore raw
Quoted 5 lines · On Tue, 11 Nov 2025 10:59:21 +0530, [email protected] wrote:

As per the C99 standard snprintf() returns the length of the data that *would have been* written if there were enough space for it. It's generally considered safer to use the scnprintf() variant.

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: SOF: sof-client-probes: Replace snprintf() with scnprintf()

      commit: e45979641a9a9dbb48fc77c5b36a5091a92e7227

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark