Fix and improve EEPROM chip descriptions for Radxa ROCK 3C, 5A and 5C
Subsystems (2)
v2 cover Fix and improve EEPROM chip descriptions for Radxa ROCK 3C, 5A and 5C
This patch series fixes incorrect or missing entries related to the eeprom on the Radxa ROCK 3C, 5A, and 5C.
FUKAUMI Naoki (4):
arm64: dts: rockchip: Move the EEPROM to correct I2C bus on Radxa ROCK
5A
arm64: dts: rockchip: Add eeprom vcc-supply for Radxa ROCK 5A
arm64: dts: rockchip: Add eeprom vcc-supply for Radxa ROCK 3C
arm64: dts: rockchip: Make eeprom read-only for Radxa ROCK 3C/5A/5C
arch/arm64/boot/dts/rockchip/rk3566-rock-3c.dts | 2 ++ arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts | 16 +++++++++------- arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts | 1 + 3 files changed, 12 insertions(+), 7 deletions(-)
Signature · 7 lines
2.43.0 _______________________________________________ Linux-rockchip mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-rockchip
PATCH v2 1/4 arm64: dts: rockchip: Move the EEPROM to correct I2C bus on Radxa ROCK 5A
The BL24C16 EEPROM chip found on Radxa ROCK 5A is connected to the i2c0 bus, [1] so move the eeprom node from the i2c2 bus to the i2c0 bus.
[1] Link: https://dl.radxa.com/rock5/5a/docs/hw/radxa_rock5a_V1.1_sch.pdf p.19
---
Changes in v2:
- Reword commit message (Dragan Simic)
--- arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts +6 -6
@@ -228,6 +228,12 @@ regulator-state-mem { regulator-off-in-suspend; }; }; + + eeprom: eeprom@50 { + compatible = "belling,bl24c16a", "atmel,24c16"; + reg = <0x50>; + pagesize = <16>; + }; }; &i2c2 {
@@ -249,12 +255,6 @@ regulator-state-mem { regulator-off-in-suspend; }; }; - - eeprom: eeprom@50 { - compatible = "belling,bl24c16a", "atmel,24c16"; - reg = <0x50>; - pagesize = <16>; - }; }; &i2c3 {
Signature · 7 lines
2.43.0 _______________________________________________ Linux-rockchip mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-rockchip
PATCH v2 2/4 arm64: dts: rockchip: Add eeprom vcc-supply for Radxa ROCK 5A
In reply to FUKAUMI NaokiThe VCC supply for the BL24C16 EEPROM chip found on Radxa ROCK 5A is vcc_3v3_pmu, which is routed to vcc_3v3_s3 via a zero-ohm resistor. [1] Describe this supply.
[1] https://dl.radxa.com/rock5/5a/docs/hw/radxa_rock5a_V1.1_sch.pdf p.4, p.19
---
Changes in v2:
- Reword commit message (Dragan Simic)
--- arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts +2 -1
@@ -233,6 +233,7 @@ eeprom: eeprom@50 { compatible = "belling,bl24c16a", "atmel,24c16"; reg = <0x50>; pagesize = <16>; + vcc-supply = <&vcc_3v3_pmu>; }; };
@@ -600,7 +601,7 @@ regulator-state-mem { }; }; - vcc_3v3_s3: dcdc-reg8 { + vcc_3v3_pmu: vcc_3v3_s3: dcdc-reg8 { regulator-name = "vcc_3v3_s3"; regulator-always-on; regulator-boot-on;
Signature · 7 lines
2.43.0 _______________________________________________ Linux-rockchip mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-rockchip
PATCH v2 3/4 arm64: dts: rockchip: Add eeprom vcc-supply for Radxa ROCK 3C
In reply to FUKAUMI NaokiThe VCC supply for the BL24C16 EEPROM chip found on Radxa ROCK 3C is vcca1v8_pmu. [1] Describe this supply.
[1] https://dl.radxa.com/rock3/docs/hw/3c/v1400/radxa_rock_3c_v1400_schematic.pdf p.13
---
Changes in v2:
- Reword commit message (Dragan Simic)
--- arch/arm64/boot/dts/rockchip/rk3566-rock-3c.dts | 1 + 1 file changed, 1 insertion(+)
arch/arm64/boot/dts/rockchip/rk3566-rock-3c.dts +1 -0
@@ -466,6 +466,7 @@ eeprom: eeprom@50 { compatible = "belling,bl24c16a", "atmel,24c16"; reg = <0x50>; pagesize = <16>; + vcc-supply = <&vcca1v8_pmu>; }; };
Signature · 7 lines
2.43.0 _______________________________________________ Linux-rockchip mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-rockchip
PATCH v2 4/4 arm64: dts: rockchip: Make eeprom read-only for Radxa ROCK 3C/5A/5C
In reply to FUKAUMI NaokiMake the BL24C16 EEPROM chips found on Radxa ROCK 3C, 5A and 5C SBCs read-only, [1] [2] [3] because they contain factory-programmed data that isn't supposed to be modified by the end users. [4]
[1] https://dl.radxa.com/rock3/docs/hw/3c/v1400/radxa_rock_3c_v1400_schematic.pdf p.13
[2] https://dl.radxa.com/rock5/5a/docs/hw/radxa_rock5a_V1.1_sch.pdf p.19
[3] https://dl.radxa.com/rock5/5c/docs/hw/v1100/radxa_rock_5c_schematic_v1100.pdf p.18
[4] https://github.com/radxa/u-boot/blob/next-dev-v2024.10/drivers/misc/radxa-i2c-eeprom.c
---
Changes in v2:
- Reword commit message (Dragan Simic)
--- arch/arm64/boot/dts/rockchip/rk3566-rock-3c.dts | 1 + arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts | 1 + arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts | 1 + 3 files changed, 3 insertions(+)
arch/arm64/boot/dts/rockchip/rk3566-rock-3c.dts +1 -0
@@ -466,6 +466,7 @@ eeprom: eeprom@50 { compatible = "belling,bl24c16a", "atmel,24c16"; reg = <0x50>; pagesize = <16>; + read-only; vcc-supply = <&vcca1v8_pmu>; }; };
arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts +1 -0
@@ -233,6 +233,7 @@ eeprom: eeprom@50 { compatible = "belling,bl24c16a", "atmel,24c16"; reg = <0x50>; pagesize = <16>; + read-only; vcc-supply = <&vcc_3v3_pmu>; }; };
arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts +1 -0
@@ -325,6 +325,7 @@ eeprom@50 { compatible = "belling,bl24c16a", "atmel,24c16"; reg = <0x50>; pagesize = <16>; + read-only; vcc-supply = <&vcc_3v3_pmu>; }; };
Signature · 7 lines
2.43.0 _______________________________________________ Linux-rockchip mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-rockchip
Re: [PATCH v2 4/4] arm64: dts: rockchip: Make eeprom read-only for Radxa ROCK 3C/5A/5C
Hi,
Quoted 3 lines
Make the BL24C16 EEPROM chips found on Radxa ROCK 3C, 5A and 5C SBCs read-only, [1] [2] [3] because they contain factory-programmed data that isn't supposed to be modified by the end users. [4]
Is this true? I confirmed that the EEPROM was empty when I submitted the ROCK 3C support. Based on the Radxa boards I purchased, it seems that only the "Network Computer" series SBC (E20C, E24C, E52C, E54C) have production information in their EEPROM.
Thanks,
Chukun
Re: [PATCH v2 4/4] arm64: dts: rockchip: Make eeprom read-only for Radxa ROCK 3C/5A/5C
Hi Chukun,
Quoted 10 lines · Chukun Pan
Hi,
Quoted 3 lines
Make the BL24C16 EEPROM chips found on Radxa ROCK 3C, 5A and 5C SBCs read-only, [1] [2] [3] because they contain factory-programmed data that isn't supposed to be modified by the end users. [4]
Is this true? I confirmed that the EEPROM was empty when I submitted the ROCK 3C support. Based on the Radxa boards I purchased, it seems that only the "Network Computer" series SBC (E20C, E24C, E52C, E54C) have production information in their EEPROM.
I have confirmed with the Radxa internal team, and it is clear that for "all" products, the EEPROM (regardless of whether data has been written or not) is designated as: "The EEPROM is for factory data; users can read it, but they are not expected to write to it." This confirms that defining a read-only property is appropriate.
I will be submitting a series of patches to add eeprom nodes for several Radxa boards, and all of them will include the read-only property.
Best regards,
--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.
Quoted 3 lines
Thanks,
Chukun
_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip
Re: (subset) [PATCH v2 0/4] Fix and improve EEPROM chip descriptions for Radxa ROCK 3C, 5A and 5C
In reply to FUKAUMI NaokiQuoted 11 lines · FUKAUMI Naoki
This patch series fixes incorrect or missing entries related to the eeprom on the Radxa ROCK 3C, 5A, and 5C.
FUKAUMI Naoki (4):
arm64: dts: rockchip: Move the EEPROM to correct I2C bus on Radxa ROCK5Aarm64: dts: rockchip: Add eeprom vcc-supply for Radxa ROCK 5A
arm64: dts: rockchip: Add eeprom vcc-supply for Radxa ROCK 3C
arm64: dts: rockchip: Make eeprom read-only for Radxa ROCK 3C/5A/5C[...]
Applied, thanks!
[1/4] arm64: dts: rockchip: Move the EEPROM to correct I2C bus on Radxa ROCK 5A
commit: 92e6e0b0e595afdda6296c760551ad3ffe9d5231
[2/4] arm64: dts: rockchip: Add eeprom vcc-supply for Radxa ROCK 5A
commit: 3069ff1930aa71e125874c780ffaa6caeda5800a
[3/4] arm64: dts: rockchip: Add eeprom vcc-supply for Radxa ROCK 3C
commit: 260316d35cf8f8606c5ed7a349cc92e1e71d8150Best regards,
Signature · 1 line
Heiko Stuebner <[email protected]>