PM / devfreq: tegra30: use min to simplify actmon_cpu_to_emc_rate
Subsystems (3)
PATCH RESEND 1/1 PM / devfreq: tegra30: use min to simplify actmon_cpu_to_emc_rate
Use min() to improve the readability of actmon_cpu_to_emc_rate() and remove any unnecessary curly braces.
Reviewed-by Dmitry Osipenko <[email protected]>
Signed-off-by Thorsten Blum <[email protected]>
--- drivers/devfreq/tegra30-devfreq.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-)
drivers/devfreq/tegra30-devfreq.c +4 -8
@@ -12,6 +12,7 @@#include <linux/interrupt.h> #include <linux/io.h> #include <linux/irq.h> +#include <linux/minmax.h> #include <linux/module.h> #include <linux/of.h> #include <linux/platform_device.h>
@@ -326,14 +327,9 @@ static unsigned long actmon_cpu_to_emc_rate(struct tegra_devfreq *tegra,unsigned int i;const struct tegra_actmon_emc_ratio *ratio = actmon_emc_ratios; -for (i =0 ; i <ARRAY_SIZE (actmon_emc_ratios); i++, ratio++) { -if (cpu_freq >= ratio->cpu_freq) { -if (ratio->emc_freq >= tegra->max_freq) -return tegra->max_freq; -else -return ratio->emc_freq; - } - } +for (i =0 ; i <ARRAY_SIZE (actmon_emc_ratios); i++, ratio++) +if (cpu_freq >= ratio->cpu_freq) +return min (ratio->emc_freq, tegra->max_freq);return 0 ; }
Signature · 1 line
2.51.1
Quoted 8 lines · Thorsten Blum
Use
min()to improve the readability ofactmon_cpu_to_emc_rate()and remove any unnecessary curly braces.Reviewed-by Dmitry Osipenko <[email protected]>Signed-off-by Thorsten Blum <[email protected]>--- drivers/devfreq/tegra30-devfreq.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-)
Acked-by Thierry Reding <[email protected]>
Chanwoo Choi
AppliedHi,
Applied it. Thanks,
25. 11. 13. 02:21에 Thorsten Blum 이(가) 쓴 글:
Quoted 39 lines
Use
min()to improve the readability ofactmon_cpu_to_emc_rate()and remove any unnecessary curly braces.Reviewed-by Dmitry Osipenko <[email protected]>Signed-off-by Thorsten Blum <[email protected]>--- drivers/devfreq/tegra30-devfreq.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-)drivers/devfreq/tegra30-devfreq.c +4
-8@@ -12,6 +12,7 @@#include <linux/interrupt.h> #include <linux/io.h> #include <linux/irq.h> +#include <linux/minmax.h> #include <linux/module.h> #include <linux/of.h> #include <linux/platform_device.h> @@ -326,14 +327,9 @@ static unsigned long actmon_cpu_to_emc_rate(struct tegra_devfreq *tegra,unsigned int i;const struct tegra_actmon_emc_ratio *ratio = actmon_emc_ratios; -for (i =0 ; i <ARRAY_SIZE (actmon_emc_ratios); i++, ratio++) { -if (cpu_freq >= ratio->cpu_freq) { -if (ratio->emc_freq >= tegra->max_freq) -return tegra->max_freq; -else -return ratio->emc_freq; - } - } +for (i =0 ; i <ARRAY_SIZE (actmon_emc_ratios); i++, ratio++) +if (cpu_freq >= ratio->cpu_freq) +return min (ratio->emc_freq, tegra->max_freq);return 0 ; }
Signature · 3 lines
Best Regards, Samsung Electronics Chanwoo Choi