Skip to contentSkip to conversation

spi: dt-bindings: nuvoton,npcm-fiu: Convert to DT schema

PATCH In review Tomer Maimon 3 participants 4 messages Nov 12, 2025 – Nov 13, 2025

Subsystems (3)
lore
Share & tools
lore

Tomer Maimon

author maintainer
#0 lore raw

PATCH 1/1 spi: dt-bindings: nuvoton,npcm-fiu: Convert to DT schema

Convert the Nuvoton NPCM FIU binding to DT schema format.

---
 .../bindings/spi/nuvoton,npcm-fiu.txt         | 58 -------------
 .../bindings/spi/nuvoton,npcm-fiu.yaml        | 87 +++++++++++++++++++
 2 files changed, 87 insertions(+), 58 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/spi/nuvoton,npcm-fiu.txt
 create mode 100644 Documentation/devicetree/bindings/spi/nuvoton,npcm-fiu.yaml
Documentation/devicetree/bindings/spi/nuvoton,npcm-fiu.txt deleted +0 -58
deleted file mode 100644
index fb38e96d395f..000000000000
@@ -1,58 +0,0 @@
-* Nuvoton FLASH Interface Unit (FIU) SPI Controller
-
-NPCM FIU supports single, dual and quad communication interface.
-
-The NPCM7XX supports three FIU modules,
-FIU0 and FIUx supports two chip selects,
-FIU3 support four chip select.
-
-The NPCM8XX supports four FIU modules,
-FIU0 and FIUx supports two chip selects,
-FIU1 and FIU3 supports four chip selects.
-
-Required properties:
-  - compatible : "nuvoton,npcm750-fiu" for Poleg NPCM7XX BMC
-			     "nuvoton,npcm845-fiu" for Arbel NPCM8XX BMC
-  - #address-cells : should be 1.
-  - #size-cells : should be 0.
-  - reg : the first contains the register location and length,
-          the second contains the memory mapping address and length
-  - reg-names: Should contain the reg names "control" and "memory"
-  - clocks : phandle of FIU reference clock.
-
-Required properties in case the pins can be muxed:
-  - pinctrl-names : a pinctrl state named "default" must be defined.
-  - pinctrl-0 : phandle referencing pin configuration of the device.
-
-Optional property:
-  - nuvoton,spix-mode: enable spix-mode for an expansion bus to an ASIC or CPLD.
-
-Aliases:
-- All the FIU controller nodes should be represented in the aliases node using
-  the following format 'fiu{n}' where n is a unique number for the alias.
-  In the NPCM7XX BMC:
-  		fiu0 represent fiu 0 controller
-  		fiu1 represent fiu 3 controller
-  		fiu2 represent fiu x controller
-
-  In the NPCM8XX BMC:
-  		fiu0 represent fiu 0 controller
-  		fiu1 represent fiu 1 controller
-  		fiu2 represent fiu 3 controller
-  		fiu3 represent fiu x controller
-
-Example:
-fiu3: spi@c00000000 {
-	compatible = "nuvoton,npcm750-fiu";
-	#address-cells = <1>;
-	#size-cells = <0>;
-	reg = <0xfb000000 0x1000>, <0x80000000 0x10000000>;
-	reg-names = "control", "memory";
-	clocks = <&clk NPCM7XX_CLK_AHB>;
-	pinctrl-names = "default";
-	pinctrl-0 = <&spi3_pins>;
-	flash@0 {
-			...
-	};
-};
-
Documentation/devicetree/bindings/spi/nuvoton,npcm-fiu.yaml new file +87 -0

87 lines not on this page · raw message

Signature · 1 line
2.34.1
#1 lore raw
Quoted 11 lines · Tomer Maimon
Documentation/devicetree/bindings/spi/nuvoton,npcm-fiu.yaml new file +11 -0
+  The NPCM7XX supports three FIU modules:
+    FIU0 and FIUx support two chip selects
+    FIU3 supports four chip selects.
+
+  The NPCM8XX supports four FIU modules:
+    FIU0 and FIUx support two chip selects
+    FIU1 and FIU3 support four chip selects.
+
+  Alias convention:
+    The '/aliases' node should define:
+      For NPCM7xx:  fiu0=&fiu0; fiu1=&fiu3; fiu2=&fiux;

Documentation/devicetree/bindings/spi/nuvoton,npcm-fiu.yaml line 38

Quoted 10 lines
Documentation/devicetree/bindings/spi/nuvoton,npcm-fiu.yaml new file +10 -0
+      For NPCM8xx:  fiu0=&fiu0; fiu1=&fiu3; fiu2=&fiux; fiu3=&fiu1;
+
+properties:
+  compatible:
+    enum:
+      - nuvoton,npcm750-fiu # Poleg NPCM7XX
+      - nuvoton,npcm845-fiu # Arbel NPCM8XX
+
+  reg:
+    minItems: 1

It wasn't flexible in the original binding. Your DTS being absolute mess and defining one 'reg' entry but two 'reg-names' (!!!) does not help at all.

Anyway, address space is rarely optional, so I have doubts you would have proper justification for this change.

Documentation/devicetree/bindings/spi/nuvoton,npcm-fiu.yaml line 49

Quoted 11 lines
Documentation/devicetree/bindings/spi/nuvoton,npcm-fiu.yaml new file +11 -0
+    items:
+      - description: FIU registers
+      - description: Memory-mapped flash contents (optional)
+
+  reg-names:
+    minItems: 1
+    items:
+      - const: control
+      - const: memory
+
+  interrupts:

Wasn't in the old binding. I asked last time - you need to explain each changen done to the binding from pure conversion.

Quoted 11 lines
Documentation/devicetree/bindings/spi/nuvoton,npcm-fiu.yaml new file +11 -0
+    maxItems: 1
+
+  clocks:
+    maxItems: 1
+
+  nuvoton,spix-mode:
+    type: boolean
+    description: Enable SPIX mode for an expansion bus to an ASIC or CPLD.
+
+required:
+  - compatible

Documentation/devicetree/bindings/spi/nuvoton,npcm-fiu.yaml line 70

Quoted 10 lines
Documentation/devicetree/bindings/spi/nuvoton,npcm-fiu.yaml new file +10 -0
+  - reg
+  - reg-names
+  - clocks
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/clock/nuvoton,npcm7xx-clock.h>
+    fiu3: spi@c0000000 {

Drop unused label.

Documentation/devicetree/bindings/spi/nuvoton,npcm-fiu.yaml line 75

Quoted 5 lines
Documentation/devicetree/bindings/spi/nuvoton,npcm-fiu.yaml new file +5 -0
+        compatible = "nuvoton,npcm750-fiu";
+        #address-cells = <1>;
+        #size-cells = <0>;
+        reg = <0xfb000000 0x1000>,
+              <0x80000000 0x10000000>;

Keep reg as the second property, followed by reg-names.

Documentation/devicetree/bindings/spi/nuvoton,npcm-fiu.yaml line 79

Quoted 4 lines
Documentation/devicetree/bindings/spi/nuvoton,npcm-fiu.yaml new file +4 -0
+        reg-names = "control", "memory";
+        clocks = <&clk NPCM7XX_CLK_AHB>;
+        pinctrl-names = "default";
+        pinctrl-0 = <&spi3_pins>;

Best regards,
Krzysztof

maintainer
#2 lore raw
Quoted 2 lines · Krzysztof Kozlowski

Anyway, address space is rarely optional, so I have doubts you would have proper justification for this change.

IIRC I have seen some of the controllers with memory mapped flash support where the address range for the memory mapping was optional since it could be configured out of the IP when wiring it into the platform. No idea if that's what's going on here.

author maintainer
#3 lore raw

Hi,

Thanks for your comments

Quoted 10 lines · Mark Brown
Quoted 2 lines · Krzysztof Kozlowski

Anyway, address space is rarely optional, so I have doubts you would have proper justification for this change.

IIRC I have seen some of the controllers with memory mapped flash support where the address range for the memory mapping was optional since it could be configured out of the IP when wiring it into the platform. No idea if that's what's going on here.

In the NPCM FIU driver:

- When the flash device is not memory-mapped, flash reads are performed using dedicated SPI flash read commands.
- When the flash device is memory-mapped, reads are done directly through the memory window, with the FIU hardware automatically handling the necessary flash read commands in the background.

I will remove the unnecessary reg-names from npcm7xx dtsi file.

Thanks,

Tomer