ALSA: core: Fix style issues in sound/core/device.c
PATCH 1/1 ALSA: core: Fix style issues in sound/core/device.c
This patch fixes blank line and trailing whitespace issues in sound/core/device.c as reported by checkpatch.pl.
Signed-off-by jempty.liang <[email protected]>
--- sound/core/device.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
sound/core/device.c +4 -2
@@ -47,6 +47,7 @@ int snd_device_new(struct snd_card *card, enum snd_device_type type,/* insert the entry in an incrementally sorted list */ list_for_each_prev (p, &card->devices) { struct snd_device *pdev = list_entry(p, struct snd_device, list); +if ((unsigned int )pdev->type <= (unsigned int )type)break ; }
@@ -130,7 +131,7 @@ EXPORT_SYMBOL_GPL(snd_device_disconnect);void snd_device_free (struct snd_card *card,void *device_data) {struct snd_device *dev; - +if (snd_BUG_ON (!card || !device_data))return ; dev =look_for_dev (card, device_data);
@@ -147,6 +148,7 @@ static int __snd_device_register(struct snd_device *dev)if (dev->state ==SNDRV_DEV_BUILD ) {if (dev->ops->dev_register) {int err = dev->ops->dev_register (dev); +if (err <0 )return err; }
@@ -190,7 +192,7 @@ int snd_device_register_all(struct snd_card *card) {struct snd_device *dev;int err; - +if (snd_BUG_ON (!card))return -ENXIO ;list_for_each_entry (dev, &card->devices, list) {
Signature · 1 line
2.25.1
Quoted 5 lines · jempty.liang
This patch fixes blank line and trailing whitespace issues in
sound/core/device.cas reported by checkpatch.pl.Signed-off-by jempty.liang <[email protected]>
Thanks for the patch. We don't apply a coding-only fix (especially about only white-space) unless it's tied with some other real fix or changes, because it'd bright merely more noises in the history.
That said, if you have more fix or a code change patch that is applied to the code path, put such a cleanup as a preliminary work in the series, and we'll happily take it together.
thanks,
Takashi