virtio-gpu-virgl: fix error handling in virgl_cmd_resource_create_blob
PATCH v2 1/1 virtio-gpu-virgl: fix error handling in virgl_cmd_resource_create_blob
The error handling logic was incorrect. virtio_gpu_create_mapping_iov() returns 0 on success and non-zero on failure, but the code was checking whether to set the error response.
The fix changes the condition from 'if (!ret)' to 'if (ret != 0)' to properly handle the return value, consistent with other usage patterns in the same codebase (see virtio-gpu.c:932 and virtio-gpu.c:354).
Fixes 7c092f17ccee ("virtio-gpu: Handle resource blob commands")
Signed-off-by Honglei Huang <[email protected]>
Reviewed-by Akihiko Odaki <[email protected]>
--- hw/display/virtio-gpu-virgl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
hw/display/virtio-gpu-virgl.c +1 -1
@@ -701,7 +701,7 @@ static void virgl_cmd_resource_create_blob(VirtIOGPU *g, ret =virtio_gpu_create_mapping_iov (g, cblob.nr_entries,sizeof (cblob), cmd, &res->base.addrs, &res->base.iov, &res->base.iov_cnt); -if (!ret) { +if (ret !=0 ) { cmd->error =VIRTIO_GPU_RESP_ERR_UNSPEC ;return ; }
Signature · 1 line
2.34.1