arm64: dts: rockchip: add Tinker Board 3 and 3S device tree
Subsystems (2)
v3 cover arm64: dts: rockchip: add Tinker Board 3 and 3S device tree
Add initial device tree support for Asus Tinker Board 3 [1] and 3S [2], which are SBCs based on the Rockchip 3566 SoC.
The "3S" version ("S" for "storage") is just a regular Tinker Board 3 fitted with a 16 GB eMMC and a "mask ROM" DIP switch
(to mask the eMMC and enter "Mask ROM" mode for recovery).
This adds support for:
- Debug UART (/dev/ttyS2)
- SD card (/dev/mmcblk1)
- eMMC (/dev/mmcblk0, only on Tinker Board 3S)
- I2C:
- i2c0 (internal bus with a PMIC and regulators)
- i2c2 (internal bus with an at24 eeprom and an RTC device)
- USB 2.0 ports
- 2 GPIO LEDS
This code was tested on Tinker Board 3S using the "master" branch of the Linux kernel.
[1] https://tinker-board.asus.com/series/tinker-board-3.html
[2] https://tinker-board.asus.com/series/tinker-board-3s.html
Changes in V3:
- rockchip.yaml: group Tinker Board 3/3S in the same section
- Remove this Acked-by as the code changed substantially:
- Remove "asus,rk3566-tinker-board-3" from rk3566-tinker-board-3s.dts, which conflicted with the change in rockchip.yaml and could create an issue if some code unexpectedly turns out to be compatible with 3 but not 3S.
If you don't agree, than we can keep V2.
Changes in V2:
- Rename "Tinker board" to "Tinker Board"
in commit messages and DT code
- Insert "-board" in DT file names
- Insert "-board" in new compatible string too
- Commit messages: change the way the references are introduced ("[1] https://..." instead of "Link: https://... [1]")
- Reorder alias properties and node names
- Add missing "cpu-supply" property to cpu nodes
- Use standard "eeprom@addr" node name for at24 eeprom
- DT commit message: add missing "Asus" before "Tinker"
Michael Opdenacker (2):
dt-bindings: arm: rockchip: Add Asus Tinker Board 3 and 3S
arm64: dts: rockchip: Add Asus Tinker Board 3 and 3S device tree
.../devicetree/bindings/arm/rockchip.yaml | 11 +
arch/arm64/boot/dts/rockchip/Makefile | 2 + .../dts/rockchip/rk3566-tinker-board-3.dts | 14 + .../dts/rockchip/rk3566-tinker-board-3.dtsi | 280 ++++++++++++++++++ .../dts/rockchip/rk3566-tinker-board-3s.dts | 30 ++ 5 files changed, 337 insertions(+) create mode 100644 arch/arm64/boot/dts/rockchip/rk3566-tinker-board-3.dts create mode 100644 arch/arm64/boot/dts/rockchip/rk3566-tinker-board-3.dtsi create mode 100644 arch/arm64/boot/dts/rockchip/rk3566-tinker-board-3s.dts
---
Michael Opdenacker (2):
dt-bindings: arm: rockchip: Add Asus Tinker Board 3/3S
arm64: dts: rockchip: Add Asus Tinker Board 3 and 3S device tree
.../devicetree/bindings/arm/rockchip.yaml | 7 + arch/arm64/boot/dts/rockchip/Makefile | 2 + .../boot/dts/rockchip/rk3566-tinker-board-3.dts | 14 ++ .../boot/dts/rockchip/rk3566-tinker-board-3.dtsi | 280 +++++++++++++++++++++ .../boot/dts/rockchip/rk3566-tinker-board-3s.dts | 30 +++ 5 files changed, 333 insertions(+)
---
base-commit: e7c375b181600caf135cfd03eadbc45eb530f2cb
change-id: 20251117-tinker3-88e32dfa9138
Best regards,
Signature · 7 lines
Michael Opdenacker <[email protected]> _______________________________________________ Linux-rockchip mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-rockchip
PATCH v3 1/2 dt-bindings: arm: rockchip: Add Asus Tinker Board 3/3S
Document the compatible strings for Asus Tinker Board 3 [1] and 3S [2], which are SBCs based on the Rockchip 3566 SoC.
The "3S" version ("S" for "storage") just adds a 16 GB eMMC and a "mask ROM" DIP switch to the "3" version.
[1] https://tinker-board.asus.com/series/tinker-board-3.html
[2] https://tinker-board.asus.com/series/tinker-board-3s.html
---
Changes in V3:
- Remove this Acked-by as the binding code changed substantially:
--- Documentation/devicetree/bindings/arm/rockchip.yaml | 7 +++++++ 1 file changed, 7 insertions(+)
Documentation/devicetree/bindings/arm/rockchip.yaml +7 -0
@@ -86,6 +86,13 @@ properties: - const: asus,rk3288-tinker-s - const: rockchip,rk3288 + - description: Asus Tinker Board 3/3S + items: + - enum: + - asus,rk3566-tinker-board-3 + - asus,rk3566-tinker-board-3s + - const: rockchip,rk3566 + - description: Beelink A1 items: - const: azw,beelink-a1
Signature · 1 line
2.43.0
Re: [PATCH v3 1/2] dt-bindings: arm: rockchip: Add Asus Tinker Board 3/3S
Quoted 9 lines · Michael Opdenacker
Document the compatible strings for Asus Tinker Board 3 [1] and 3S [2], which are SBCs based on the Rockchip 3566 SoC.
The "3S" version ("S" for "storage") just adds a 16 GB eMMC and a "mask ROM" DIP switch to the "3" version.
[1] https://tinker-board.asus.com/series/tinker-board-3.html
[2] https://tinker-board.asus.com/series/tinker-board-3s.html
Quoted 8 lines
Signed-off-by Michael Opdenacker <[email protected]>---
Changes in V3:
- Remove this Acked-by as the binding code changed substantially:
Above commit msg and DTS suggests they are pretty compatible with each other, so I don't quite get why this changed. Your changelog says "unexpectedly turns out to be compatible with 3 but not 3S.", but is this real or are you just guessing? I think you were tricked to change correct code into this.
Anyway, however odd this is, I don't care enough to stop this patchset, so:
Best regards,
Krzysztof
Re: [PATCH v3 1/2] dt-bindings: arm: rockchip: Add Asus Tinker Board 3/3S
Hi Krzysztof
Thanks for the new review!
Quoted 16 lines · Krzysztof Kozlowski
Quoted 15 lines · Michael Opdenacker
Document the compatible strings for Asus Tinker Board 3 [1] and 3S [2], which are SBCs based on the Rockchip 3566 SoC.
The "3S" version ("S" for "storage") just adds a 16 GB eMMC and a "mask ROM" DIP switch to the "3" version.
[1] https://tinker-board.asus.com/series/tinker-board-3.html
[2] https://tinker-board.asus.com/series/tinker-board-3s.htmlSigned-off-by Michael Opdenacker <[email protected]>---
Changes in V3:
Quoted 7 lines
Quoted 2 lines
- Remove this Acked-by as the binding code changed substantially:
Above commit msg and DTS suggests they are pretty compatible with each other, so I don't quite get why this changed. Your changelog says "unexpectedly turns out to be compatible with 3 but not 3S.", but is this real or are you just guessing? I think you were tricked to change correct code into this.
I was just guessing. The likelihood that something working on 3 doesn't work on 3s looks very small indeed, but I'm not the manufacturer to completely rule this out.
Quoted 4 lines
Anyway, however odd this is, I don't care enough to stop this patchset, so:
Thanks again!
Cheers
Michael.
Signature · 10 lines
Michael Opdenacker Root Commit Yocto Project and OpenEmbedded Training course - Learn by doing: https://rootcommit.com/training/yocto/ _______________________________________________ Linux-rockchip mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-rockchip
Re: [PATCH v3 1/2] dt-bindings: arm: rockchip: Add Asus Tinker Board 3/3S
In reply to Michael OpdenackerHello Michael,
Quoted 29 lines · Michael Opdenacker
Document the compatible strings for Asus Tinker Board 3 [1] and 3S [2], which are SBCs based on the Rockchip 3566 SoC.
The "3S" version ("S" for "storage") just adds a 16 GB eMMC and a "mask ROM" DIP switch to the "3" version.
[1] https://tinker-board.asus.com/series/tinker-board-3.html
[2] https://tinker-board.asus.com/series/tinker-board-3s.htmlSigned-off-by Michael Opdenacker <[email protected]>---
Changes in V3:
- Remove this Acked-by as the binding code changed substantially:
--- Documentation/devicetree/bindings/arm/rockchip.yaml | 7 +++++++ 1 file changed, 7 insertions(+)Documentation/devicetree/bindings/arm/rockchip.yaml +0
-0@@ -86,6 +86,13 @@ properties: - const: asus,rk3288-tinker-s - const: rockchip,rk3288
Documentation/devicetree/bindings/arm/rockchip.yaml properties: · line 98
Quoted 10 lines
Documentation/devicetree/bindings/arm/rockchip.yaml +7
-0+ - description: Asus Tinker Board 3/3S + items: + - enum: + - asus,rk3566-tinker-board-3 + - asus,rk3566-tinker-board-3s + - const: rockchip,rk3566 + - description: Beelink A1 items: - const: azw,beelink-a1
Please see my delayed response in the v2. [1] I think that would be a better approach.
[1] https://lore.kernel.org/linux-rockchip/[email protected]/
Re: [PATCH v3 1/2] dt-bindings: arm: rockchip: Add Asus Tinker Board 3/3S
Quoted 46 lines · Dragan Simic
Hello Michael,
Quoted 29 lines · Michael Opdenacker
Document the compatible strings for Asus Tinker Board 3 [1] and 3S [2], which are SBCs based on the Rockchip 3566 SoC.
The "3S" version ("S" for "storage") just adds a 16 GB eMMC and a "mask ROM" DIP switch to the "3" version.
[1] https://tinker-board.asus.com/series/tinker-board-3.html
[2] https://tinker-board.asus.com/series/tinker-board-3s.htmlSigned-off-by Michael Opdenacker <[email protected]>---
Changes in V3:
- Remove this Acked-by as the binding code changed substantially:
--- Documentation/devicetree/bindings/arm/rockchip.yaml | 7 +++++++ 1 file changed, 7 insertions(+)Documentation/devicetree/bindings/arm/rockchip.yaml +0
-0@@ -86,6 +86,13 @@ properties: - const: asus,rk3288-tinker-s - const: rockchip,rk3288Documentation/devicetree/bindings/arm/rockchip.yaml properties: · line 98
Quoted 10 lines
Documentation/devicetree/bindings/arm/rockchip.yaml +7
-0+ - description: Asus Tinker Board 3/3S + items: + - enum: + - asus,rk3566-tinker-board-3 + - asus,rk3566-tinker-board-3s + - const: rockchip,rk3566 + - description: Beelink A1 items: - const: azw,beelink-a1Please see my delayed response in the v2. [1] I think that would be a better approach.
Quoted 2 lines
[1] https://lore.kernel.org/linux-rockchip/[email protected]/
Your reviews are not helpful. You nitpick irrelevant things and propose solutions which later reverse leading to wasted effort on contributors side.
Michael implemented what you asked here:
https://lore.kernel.org/linux-rockchip/[email protected]/
This patch implements exactly what you wanted. On v4 you will ask to reverse back to v1?
Now you claim that you want back v2. Really, you are NOT HELPING. It is clear you do not understand what you are proposing and this is not helping ion the process. Please refrain from such confusing reviews.
Best regards,
Krzysztof
Re: [PATCH v3 1/2] dt-bindings: arm: rockchip: Add Asus Tinker Board 3/3S
Hello Krzysztof,
Quoted 45 lines · Krzysztof Kozlowski
Quoted 44 lines · Dragan Simic
Quoted 29 lines · Michael Opdenacker
Document the compatible strings for Asus Tinker Board 3 [1] and 3S [2], which are SBCs based on the Rockchip 3566 SoC.
The "3S" version ("S" for "storage") just adds a 16 GB eMMC and a "mask ROM" DIP switch to the "3" version.
[1] https://tinker-board.asus.com/series/tinker-board-3.html
[2] https://tinker-board.asus.com/series/tinker-board-3s.htmlSigned-off-by Michael Opdenacker <[email protected]>---
Changes in V3:
- Remove this Acked-by as the binding code changed substantially:
--- Documentation/devicetree/bindings/arm/rockchip.yaml | 7 +++++++ 1 file changed, 7 insertions(+)Documentation/devicetree/bindings/arm/rockchip.yaml +0
-0@@ -86,6 +86,13 @@ properties: - const: asus,rk3288-tinker-s - const: rockchip,rk3288Documentation/devicetree/bindings/arm/rockchip.yaml properties: · line 98
Quoted 10 lines
Documentation/devicetree/bindings/arm/rockchip.yaml +7
-0+ - description: Asus Tinker Board 3/3S + items: + - enum: + - asus,rk3566-tinker-board-3 + - asus,rk3566-tinker-board-3s + - const: rockchip,rk3566 + - description: Beelink A1 items: - const: azw,beelink-a1Please see my delayed response in the v2. [1] I think that would be a better approach.
Quoted 8 lines
Quoted 1 line
[1] https://lore.kernel.org/linux-rockchip/[email protected]/
Your reviews are not helpful. You nitpick irrelevant things and propose solutions which later reverse leading to wasted effort on contributors side.
Michael implemented what you asked here:
Not exactly, because I didn't ask for any compatibles to be removed from the new board dts files.
In this case, we could also say that it was Michael's fault not to give enough time for the reviewers to respond.
Quoted 2 lines
This patch implements exactly what you wanted. On v4 you will ask to reverse back to v1?
No, I will not, and please note this version doesn't exactly implement what I suggested, as already explained above.
Quoted 3 lines
Now you claim that you want back v2. Really, you are NOT HELPING. It is clear you do not understand what you are proposing and this is not helping ion the process. Please refrain from such confusing reviews.
No, I'm not suggesting that the series goes back to v2, but Michael failed to give me enough time to respond. If that were the case, the v3 would've been in nicer shape, with, from my point of view, no need for further adjustments.
Re: [PATCH v3 1/2] dt-bindings: arm: rockchip: Add Asus Tinker Board 3/3S
Quoted 53 lines · Dragan Simic
Hello Krzysztof,
Quoted 50 lines · Krzysztof Kozlowski
Quoted 44 lines · Dragan Simic
Quoted 29 lines · Michael Opdenacker
Document the compatible strings for Asus Tinker Board 3 [1] and 3S [2], which are SBCs based on the Rockchip 3566 SoC.
The "3S" version ("S" for "storage") just adds a 16 GB eMMC and a "mask ROM" DIP switch to the "3" version.
[1] https://tinker-board.asus.com/series/tinker-board-3.html
[2] https://tinker-board.asus.com/series/tinker-board-3s.htmlSigned-off-by Michael Opdenacker <[email protected]>---
Changes in V3:
- Remove this Acked-by as the binding code changed substantially:
--- Documentation/devicetree/bindings/arm/rockchip.yaml | 7 +++++++ 1 file changed, 7 insertions(+)Documentation/devicetree/bindings/arm/rockchip.yaml +0
-0@@ -86,6 +86,13 @@ properties: - const: asus,rk3288-tinker-s - const: rockchip,rk3288Documentation/devicetree/bindings/arm/rockchip.yaml properties: · line 98
Quoted 10 lines
Documentation/devicetree/bindings/arm/rockchip.yaml +7
-0+ - description: Asus Tinker Board 3/3S + items: + - enum: + - asus,rk3566-tinker-board-3 + - asus,rk3566-tinker-board-3s + - const: rockchip,rk3566 + - description: Beelink A1 items: - const: azw,beelink-a1Please see my delayed response in the v2. [1] I think that would be a better approach.
Quoted 1 line
[1] https://lore.kernel.org/linux-rockchip/[email protected]/
Your reviews are not helpful. You nitpick irrelevant things and propose solutions which later reverse leading to wasted effort on contributors side.
Quoted 6 lines
Quoted 3 lines
Michael implemented what you asked here:
Not exactly, because I didn't ask for any compatibles to be removed from the new board dts files.
Read your answer again. You wanted ENTIRE bindings, to be like this:
- description: Asus Tinker Board 3/3S
items:
- enum:
- asus,rk3566-tinker-board-3
- asus,rk3566-tinker-board-3s
- const: rockchip,rk3566
(skipping obvious indentation fixup)
There are exactly like this.
Quoted 3 lines
In this case, we could also say that it was Michael's fault not to give enough time for the reviewers to respond.
Michael implemented EXACTLY what you asked. Now, you ask to change it to what Michael did BEFORE.
Your reviews are completely irresponsible and incorrect.
Best regards,
Krzysztof
Re: [PATCH v3 1/2] dt-bindings: arm: rockchip: Add Asus Tinker Board 3/3S
Quoted 72 lines · Krzysztof Kozlowski
Quoted 51 lines · Dragan Simic
Quoted 50 lines · Krzysztof Kozlowski
Quoted 44 lines · Dragan Simic
Quoted 29 lines · Michael Opdenacker
Document the compatible strings for Asus Tinker Board 3 [1] and 3S [2], which are SBCs based on the Rockchip 3566 SoC.
The "3S" version ("S" for "storage") just adds a 16 GB eMMC and a "mask ROM" DIP switch to the "3" version.
[1] https://tinker-board.asus.com/series/tinker-board-3.html
[2] https://tinker-board.asus.com/series/tinker-board-3s.htmlSigned-off-by Michael Opdenacker <[email protected]>---
Changes in V3:
- Remove this Acked-by as the binding code changed substantially:
--- Documentation/devicetree/bindings/arm/rockchip.yaml | 7 +++++++ 1 file changed, 7 insertions(+)Documentation/devicetree/bindings/arm/rockchip.yaml +0
-0@@ -86,6 +86,13 @@ properties: - const: asus,rk3288-tinker-s - const: rockchip,rk3288Documentation/devicetree/bindings/arm/rockchip.yaml properties: · line 98
Quoted 10 lines
Documentation/devicetree/bindings/arm/rockchip.yaml +7
-0+ - description: Asus Tinker Board 3/3S + items: + - enum: + - asus,rk3566-tinker-board-3 + - asus,rk3566-tinker-board-3s + - const: rockchip,rk3566 + - description: Beelink A1 items: - const: azw,beelink-a1Please see my delayed response in the v2. [1] I think that would be a better approach.
Quoted 1 line
[1] https://lore.kernel.org/linux-rockchip/[email protected]/
Your reviews are not helpful. You nitpick irrelevant things and propose solutions which later reverse leading to wasted effort on contributors side.
Quoted 6 lines
Quoted 3 lines
Michael implemented what you asked here:
Not exactly, because I didn't ask for any compatibles to be removed from the new board dts files.
Read your answer again. You wanted ENTIRE bindings, to be like this:
- description: Asus Tinker Board 3/3S
items:
- enum:
- asus,rk3566-tinker-board-3
- asus,rk3566-tinker-board-3s
- const: rockchip,rk3566(skipping obvious indentation fixup)
There are exactly like this.Quoted 1 line
Quoted 5 lines
Quoted 2 lines
In this case, we could also say that it was Michael's fault not to give enough time for the reviewers to respond.
Michael implemented EXACTLY what you asked. Now, you ask to change it to what Michael did BEFORE.
Not really, because it wasn't some kind of a request from my side, but merely a suggestion that was intended to be discussed further so the best possible solution is reached before v3 is submitted.
Quoted 1 line
Your reviews are completely irresponsible and incorrect.
Calling my reviews irresponsible hurts me a lot, really, but I'm unfortunately already used to hear hurtful things from your side.
Re: [PATCH v3 1/2] dt-bindings: arm: rockchip: Add Asus Tinker Board 3/3S
Quoted 79 lines · Dragan Simic
Quoted 72 lines · Krzysztof Kozlowski
Quoted 51 lines · Dragan Simic
Quoted 50 lines · Krzysztof Kozlowski
Quoted 44 lines · Dragan Simic
Quoted 29 lines · Michael Opdenacker
Document the compatible strings for Asus Tinker Board 3 [1] and 3S [2], which are SBCs based on the Rockchip 3566 SoC.
The "3S" version ("S" for "storage") just adds a 16 GB eMMC and a "mask ROM" DIP switch to the "3" version.
[1] https://tinker-board.asus.com/series/tinker-board-3.html
[2] https://tinker-board.asus.com/series/tinker-board-3s.htmlSigned-off-by Michael Opdenacker <[email protected]>---
Changes in V3:
- Remove this Acked-by as the binding code changed substantially:
--- Documentation/devicetree/bindings/arm/rockchip.yaml | 7 +++++++ 1 file changed, 7 insertions(+)Documentation/devicetree/bindings/arm/rockchip.yaml +0
-0@@ -86,6 +86,13 @@ properties: - const: asus,rk3288-tinker-s - const: rockchip,rk3288Documentation/devicetree/bindings/arm/rockchip.yaml properties: · line 98
Quoted 10 lines
Documentation/devicetree/bindings/arm/rockchip.yaml +7
-0+ - description: Asus Tinker Board 3/3S + items: + - enum: + - asus,rk3566-tinker-board-3 + - asus,rk3566-tinker-board-3s + - const: rockchip,rk3566 + - description: Beelink A1 items: - const: azw,beelink-a1Please see my delayed response in the v2. [1] I think that would be a better approach.
Quoted 1 line
[1] https://lore.kernel.org/linux-rockchip/[email protected]/
Your reviews are not helpful. You nitpick irrelevant things and propose solutions which later reverse leading to wasted effort on contributors side.
Quoted 6 lines
Quoted 3 lines
Michael implemented what you asked here:
Not exactly, because I didn't ask for any compatibles to be removed from the new board dts files.
Read your answer again. You wanted ENTIRE bindings, to be like this:
- description: Asus Tinker Board 3/3S
items:
- enum:
- asus,rk3566-tinker-board-3
- asus,rk3566-tinker-board-3s
- const: rockchip,rk3566(skipping obvious indentation fixup)
There are exactly like this.Quoted 1 line
Quoted 5 lines
Quoted 2 lines
In this case, we could also say that it was Michael's fault not to give enough time for the reviewers to respond.
Michael implemented EXACTLY what you asked. Now, you ask to change it to what Michael did BEFORE.
Quoted 8 lines
Not really, because it wasn't some kind of a request from my side, but merely a suggestion that was intended to be discussed further so the best possible solution is reached before v3 is submitted.
Quoted 1 line
Your reviews are completely irresponsible and incorrect.
Calling my reviews irresponsible hurts me a lot, really, but I'm unfortunately already used to hear hurtful things from your side.
You do not bear the cost of your reviews, so maybe that's why you think nitpicking, poking around, pin pointing irrelevant things and adding 2 cents is okay, but that leads to additional effort on contributors and reviewers. And not respecting total effort is irresponsible.
Best regards,
Krzysztof
Re: [PATCH v3 1/2] dt-bindings: arm: rockchip: Add Asus Tinker Board 3/3S
Quoted 38 lines · Krzysztof Kozlowski
Quoted 37 lines · Dragan Simic
Quoted 21 lines · Krzysztof Kozlowski
Quoted 10 lines · Dragan Simic
Quoted 6 lines · Krzysztof Kozlowski
Your reviews are not helpful. You nitpick irrelevant things and propose solutions which later reverse leading to wasted effort on contributors side.
Michael implemented what you asked here:
Not exactly, because I didn't ask for any compatibles to be removed from the new board dts files.
Read your answer again. You wanted ENTIRE bindings, to be like this:
- description: Asus Tinker Board 3/3S
items:
- enum:
- asus,rk3566-tinker-board-3
- asus,rk3566-tinker-board-3s
- const: rockchip,rk3566Quoted 8 lines
(skipping obvious indentation fixup)
There are exactly like this.Quoted 3 lines
In this case, we could also say that it was Michael's fault not to give enough time for the reviewers to respond.
Michael implemented EXACTLY what you asked. Now, you ask to change it to what Michael did BEFORE.
Not really, because it wasn't some kind of a request from my side, but merely a suggestion that was intended to be discussed further so the best possible solution is reached before v3 is submitted.
Quoted 1 line
Your reviews are completely irresponsible and incorrect.
Quoted 7 lines
Quoted 2 lines
Calling my reviews irresponsible hurts me a lot, really, but I'm unfortunately already used to hear hurtful things from your side.
You do not bear the cost of your reviews, so maybe that's why you think nitpicking, poking around, pin pointing irrelevant things and adding 2 cents is okay, but that leads to additional effort on contributors and reviewers. And not respecting total effort is irresponsible.
Thank you very much for finding additional ways to hurt my feelings. However, please think about how your unfriendly approach may or may not contribute to the overall effort.
Re: [PATCH v3 1/2] dt-bindings: arm: rockchip: Add Asus Tinker Board 3/3S
In reply to Dragan SimicQuoted 4 lines · Dragan Simic
No, I'm not suggesting that the series goes back to v2, but Michael failed to give me enough time to respond. If that were the case, the v3 would've been in nicer shape, with, from my point of view, no need for further adjustments.
I'm sorry if I caused trouble.
I agree I didn't leave you much time to react to my reply to your review. What happens is that I'm new to this subsystem and I was feeling some pressure to avoid missing the launch window for 6.19, which I don't know exactly when it will be.
Michael.
Signature · 4 lines
Michael Opdenacker Root Commit Yocto Project and OpenEmbedded Training course - Learn by doing: https://rootcommit.com/training/yocto/
Re: [PATCH v3 1/2] dt-bindings: arm: rockchip: Add Asus Tinker Board 3/3S
In reply to Krzysztof KozlowskiQuoted 6 lines · Krzysztof Kozlowski
Now you claim that you want back v2. Really, you are NOT HELPING. It is clear you do not understand what you are proposing and this is not helping ion the process. Please refrain from such confusing reviews.
Best regards,
Krzysztof
Oh, i forgot to mention that it certainly may be that I don't know everything when it comes to DT bindings and definitions, but you also may not know how to handle communication with people in a polite and friendly way.
Thus, I'd suggest that you replace "Best regards" in your signature with "No regards".
PATCH v3 2/2 arm64: dts: rockchip: Add Asus Tinker Board 3 and 3S device tree
In reply to Michael OpdenackerAdd initial device tree support for Asus Tinker Board 3 [1] and 3S [2], which are SBCs based on the Rockchip 3566 SoC.
The "3S" version ("S" for "storage") just adds a 16 GB eMMC and a "mask ROM" DIP switch (to mask the eMMC and enter "Mask ROM" mode for recovery) to the "3" version.
This adds support for:
- Debug UART (/dev/ttyS2)
- SD card (/dev/mmcblk1)
- eMMC (/dev/mmcblk0, only on Tinker Board 3S)
- I2C:
- i2c0 (internal bus with a PMIC and regulators)
- i2c2 (internal bus with an at24 eeprom and an RTC device)
- USB 2.0 ports
- 2 GPIO LEDS
[1] https://tinker-board.asus.com/series/tinker-board-3.html
[2] https://tinker-board.asus.com/series/tinker-board-3s.html
--- arch/arm64/boot/dts/rockchip/Makefile | 2 + .../boot/dts/rockchip/rk3566-tinker-board-3.dts | 14 ++ .../boot/dts/rockchip/rk3566-tinker-board-3.dtsi | 280 +++++++++++++++++++++ .../boot/dts/rockchip/rk3566-tinker-board-3s.dts | 30 +++ 4 files changed, 326 insertions(+)
arch/arm64/boot/dts/rockchip/Makefile +2 -0
@@ -130,6 +130,8 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-lubancat-1.dtb dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-nanopi-r3s.dtb dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-bigtreetech-cb2-manta.dtb dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-bigtreetech-pi2.dtb +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-tinker-board-3.dtb +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-tinker-board-3s.dtb dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-bpi-r2-pro.dtb dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-evb1-v10.dtb dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-fastrhino-r66s.dtb
arch/arm64/boot/dts/rockchip/rk3566-tinker-board-3.dts new file +14 -0
@@ -0,0 +1,14 @@ +// SPDX-License-Identifier: (GPL-2.0 OR MIT) +/* + * Copyright (C) 2025 Michael Opdenacker <[email protected]> + */ + +/dts-v1/; + +#include "rk3566-tinker-board-3.dtsi" + +/ { + model = "Asus Tinker Board 3"; + compatible = "asus,rk3566-tinker-board-3", "rockchip,rk3566"; +}; +
arch/arm64/boot/dts/rockchip/rk3566-tinker-board-3.dtsi new file +280 -0
280 lines not on this page · raw message
arch/arm64/boot/dts/rockchip/rk3566-tinker-board-3s.dts new file +30 -0
@@ -0,0 +1,30 @@ +// SPDX-License-Identifier: (GPL-2.0 OR MIT) +/* + * Copyright (C) 2025 Michael Opdenacker <[email protected]> + */ + +/dts-v1/; + +#include "rk3566-tinker-board-3.dtsi" + +/ { + model = "Asus Tinker Board 3S"; + compatible = "asus,rk3566-tinker-board-3s", "rockchip,rk3566"; + + aliases { + mmc0 = &sdhci; + }; +}; + +&sdhci { + bus-width = <8>; + cap-mmc-highspeed; + max-frequency = <200000000>; + mmc-hs200-1_8v; + non-removable; + pinctrl-names = "default"; + pinctrl-0 = <&emmc_bus8 &emmc_clk &emmc_cmd &emmc_datastrobe>; + vmmc-supply = <&vcc_3v3>; + vqmmc-supply = <&vcc_1v8>; + status = "okay"; +};
Signature · 1 line
2.43.0
Quoted 8 lines · Michael Opdenacker
Add initial device tree support for Asus Tinker Board 3 [1] and 3S [2], which are SBCs based on the Rockchip 3566 SoC.
The "3S" version ("S" for "storage") is just a regular Tinker Board 3 fitted with a 16 GB eMMC and a "mask ROM" DIP switch
(to mask the eMMC and enter "Mask ROM" mode for recovery).[...]
Applied, thanks!
[1/2] dt-bindings: arm: rockchip: Add Asus Tinker Board 3/3S
commit: f4e81d0b95f3257a2fcfdbfaa2d8ed41015c621b
[2/2] arm64: dts: rockchip: Add Asus Tinker Board 3 and 3S device tree
commit: 9f80b3952318d7ef18573a5010f06118602f992eChanged the property sorting of the RTC and also migrated all the pinctrl names to match the schematics.
When creating pinctrl entries, please always _try_ to use the names found in the device schematics. This makes it way easier in the future to find one from the other :-)
Best regards,
Signature · 1 line
Heiko Stuebner <[email protected]>