Add Qualcomm Technologies, Inc. Talos EVK SMARC support
v7 cover Add Qualcomm Technologies, Inc. Talos EVK SMARC support
Hi all,
This patch series adds device tree binding and board support for the Qualcomm Technologies, Inc. Talos EVK SMARC platform based on the QCS615 SoC.
The first patch introduces the DT binding entry for the Talos EVK SMARC board, and the second patch adds the corresponding DTS files for the platform.
Note:USB(usb_1_dwc3) supports host-only mode based on the switch SW1 on the SoM, which is purely a hardware controlled as USB-ID and USB-VBUS is not connected the switching cannot be handled from SW. Hence from SW Host-only mode is supported on Linux boot up.
Changes in v7:
- Added i2c clock frequency for i2c5 node.
- Moved adv7535 controller section to talos-evk.dts file.
- Reorder the usb nodes.
- GPI_DMA nodes added in the device tree files.
- No functional change in bindings file.
Changes in v6:
- Clarified description of talos-evk-cb.dtsi to explain that it defines common carrier board interfaces shared between HDMI and LVDS variants, And It’s a single carrier board. HDMI and LVDS share the same DSI interface, and only one can be active at a time depending on a DIP switch.
- Added missing newlines before 'status' and between the last property and subnode (suggested by Konrad).
- Updated commit messages for clarity.
Changes in v5:
- Updated commit message. (suggested by Krzysztof)
- Introduced generic node name for can, dp, hdmi-bridge. (suggested by Krzysztof)
- Introduced talos-evk-cb.dtsi, which has common carrier board interfaces.
- No functional change in bindings file.
Changes in v4:
- Updated product name to full form per Krzysztof’s feedback in dt-binding comment.
- Hook up the ADV7535 DSI-to-HDMI bridge to base DTS file.
- Add DP connector node and MDSS DisplayPort controller.
- Added USB note in the cover letter for maintainers' awareness.
Changes in v3:
- Addressed comments from Dmitry regarding USB1 dr_mode and added a DTS comment.
- No functional change in bindings file.
Changes in v2:
- Renamed compatible to "qcom,talos-evk" (suggested by Dmitry/Bjorn)
- Merged enum entry with existing qcs615-ride block (Krzysztof)
- Fixed subject and commit message to use imperative mood.
Thanks,
Sudarshan
Sudarshan Shetty (2):
dt-bindings: arm: qcom: talos-evk: Add QCS615 Talos EVK SMARC platform
arm64: dts: qcom: talos-evk: Add support for QCS615 talos evk board
.../devicetree/bindings/arm/qcom.yaml | 1 + arch/arm64/boot/dts/qcom/Makefile | 1 + arch/arm64/boot/dts/qcom/talos-evk-cb.dtsi | 56 +++ arch/arm64/boot/dts/qcom/talos-evk-som.dtsi | 447 ++++++++++++++++++ arch/arm64/boot/dts/qcom/talos-evk.dts | 94 ++++ 5 files changed, 599 insertions(+) create mode 100644 arch/arm64/boot/dts/qcom/talos-evk-cb.dtsi create mode 100644 arch/arm64/boot/dts/qcom/talos-evk-som.dtsi create mode 100644 arch/arm64/boot/dts/qcom/talos-evk.dts
Signature · 1 line
2.34.1
PATCH v7 1/2 dt-bindings: arm: qcom: talos-evk: Add QCS615 Talos EVK SMARC platform
Add binding support for the Qualcomm Technologies, Inc. Talos EVK SMARC platform based on the QCS615 SoC.
--- Documentation/devicetree/bindings/arm/qcom.yaml | 1 + 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/arm/qcom.yaml +1 -0
@@ -862,6 +862,7 @@ properties: - items: - enum: - qcom,qcs615-ride + - qcom,talos-evk - const: qcom,qcs615 - const: qcom,sm6150
Signature · 1 line
2.34.1
PATCH v7 2/2 arm64: dts: qcom: talos-evk: Add support for QCS615 talos evk board
In reply to Sudarshan ShettyAdd the device tree for the QCS615-based Talos EVK platform. The platform is composed of a System-on-Module following the SMARC standard, and a Carrier Board.
The Carrier Board supports several display configurations, HDMI and LVDS. Both configurations use the same base hardware, with the display selection controlled by a DIP switch.
To avoid duplication, use an include file, talos-evk-cb.dtsi, which defines the interfaces and peripherals common to both display variants. Two additional DTs (e.g. talos-evk and talos-evk-lvds) can describe the selected display configuration.
The initial device tree includes support for:
- CPU and memory
- UART
- GPIOs
- Regulators
- PMIC
- Early console
- AT24MAC602 EEPROM
- MCP2515 SPI to CAN
- ADV7535 DSI-to-HDMI bridge
- DisplayPort interface
--- arch/arm64/boot/dts/qcom/Makefile | 1 + arch/arm64/boot/dts/qcom/talos-evk-cb.dtsi | 56 +++ arch/arm64/boot/dts/qcom/talos-evk-som.dtsi | 447 ++++++++++++++++++++ arch/arm64/boot/dts/qcom/talos-evk.dts | 94 ++++ 4 files changed, 598 insertions(+) create mode 100644 arch/arm64/boot/dts/qcom/talos-evk-cb.dtsi create mode 100644 arch/arm64/boot/dts/qcom/talos-evk-som.dtsi create mode 100644 arch/arm64/boot/dts/qcom/talos-evk.dts
arch/arm64/boot/dts/qcom/Makefile +1 -0
@@ -305,6 +305,7 @@ dtb-$(CONFIG_ARCH_QCOM) += sm8650-mtp.dtb dtb-$(CONFIG_ARCH_QCOM) += sm8650-qrd.dtb dtb-$(CONFIG_ARCH_QCOM) += sm8750-mtp.dtb dtb-$(CONFIG_ARCH_QCOM) += sm8750-qrd.dtb +dtb-$(CONFIG_ARCH_QCOM) += talos-evk.dtb x1e001de-devkit-el2-dtbs := x1e001de-devkit.dtb x1-el2.dtbo dtb-$(CONFIG_ARCH_QCOM) += x1e001de-devkit.dtb x1e001de-devkit-el2.dtb x1e78100-lenovo-thinkpad-t14s-el2-dtbs := x1e78100-lenovo-thinkpad-t14s.dtb x1-el2.dtbo
arch/arm64/boot/dts/qcom/talos-evk-cb.dtsi new file +55 -0
55 lines not on this page · raw message
arch/arm64/boot/dts/qcom/talos-evk-som.dtsi new file +447 -0
447 lines not on this page · raw message
arch/arm64/boot/dts/qcom/talos-evk.dts new file +94 -0
94 lines not on this page · raw message
Signature · 1 line
2.34.1
Bjorn Andersson
maintainerRe: [PATCH v7 2/2] arm64: dts: qcom: talos-evk: Add support for QCS615 talos evk board
arch/arm64/boot/dts/qcom/talos-evk-cb.dtsi
Quoted 49 lines · Sudarshan Shetty
Add the device tree for the QCS615-based Talos EVK platform. The platform is composed of a System-on-Module following the SMARC standard, and a Carrier Board.
The Carrier Board supports several display configurations, HDMI and LVDS. Both configurations use the same base hardware, with the display selection controlled by a DIP switch.
To avoid duplication, use an include file,
talos-evk-cb.dtsi, which defines the interfaces and peripherals common to both display variants. Two additional DTs (e.g. talos-evk and talos-evk-lvds) can describe the selected display configuration.The initial device tree includes support for:
- CPU and memory
- UART
- GPIOs
- Regulators
- PMIC
- Early console
- AT24MAC602 EEPROM
- MCP2515 SPI to CAN
- ADV7535 DSI-to-HDMI bridge
- DisplayPort interfaceSigned-off-by Sudarshan Shetty <[email protected]>--- arch/arm64/boot/dts/qcom/Makefile | 1 + arch/arm64/boot/dts/qcom/talos-evk-cb.dtsi | 56 +++ arch/arm64/boot/dts/qcom/talos-evk-som.dtsi | 447 ++++++++++++++++++++ arch/arm64/boot/dts/qcom/talos-evk.dts | 94 ++++ 4 files changed, 598 insertions(+) create mode 100644 arch/arm64/boot/dts/qcom/talos-evk-cb.dtsi create mode 100644 arch/arm64/boot/dts/qcom/talos-evk-som.dtsi create mode 100644 arch/arm64/boot/dts/qcom/talos-evk.dtsarch/arm64/boot/dts/qcom/Makefile +1
-0@@ -305,6 +305,7 @@ dtb-$(CONFIG_ARCH_QCOM) += sm8650-mtp.dtb dtb-$(CONFIG_ARCH_QCOM) += sm8650-qrd.dtb dtb-$(CONFIG_ARCH_QCOM) += sm8750-mtp.dtb dtb-$(CONFIG_ARCH_QCOM) += sm8750-qrd.dtb +dtb-$(CONFIG_ARCH_QCOM) += talos-evk.dtb x1e001de-devkit-el2-dtbs := x1e001de-devkit.dtb x1-el2.dtbo dtb-$(CONFIG_ARCH_QCOM) += x1e001de-devkit.dtb x1e001de-devkit-el2.dtb x1e78100-lenovo-thinkpad-t14s-el2-dtbs := x1e78100-lenovo-thinkpad-t14s.dtb x1-el2.dtboarch/arm64/boot/dts/qcom/talos-evk-cb.dtsi +0
-0
I might have missed where you replied to any of my questions. But I still believe this file represents the Talos EVK - that is, the "Talos SOM" + the "Talos EVK Carrier board".
arch/arm64/boot/dts/qcom/talos-evk-cb.dtsi line 7
Quoted 12 lines
new file mode 100644
index 000000000000..81d15ee4f366arch/arm64/boot/dts/qcom/talos-evk-cb.dtsi new file +7
-0@@ -0,0 +1,55 @@ +// SPDX-License-Identifier: BSD-3-Clause +/* + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. + */ +/dts-v1/; + +#include "talos-evk-som.dtsi"
Here this file stops being just a definition of the "carrier board", it's now the whole EVK.
As such, this file should be called "talos-evk".
We now have two options:
1) talos-som.dtsi + talos-evk.dts + talos-evk-lvds-auo,g133han01.dtso
We describe the SOM, we describe the "standard configuration" of the EVK, and we have an overlay example that disabled the HDMI portions and adds LVDS and the specific panel.
2) talos-som.dtsi + talos-evk.dtsi + talos-evk-hdmi.dts + talos-evk-lvds.dts + talos-evk-lvds-auo,g133han01.dtso
We avoid describing HDMI, just to remove it again in the overlay.
#2 would scale better if we have a lot of these boards, but unless we expect a lot of different boards/combinations I don't think there's much value in it.
Please let me know if my assumptions are wrong, but for now I think #1 is the correct choice.
In either case, you should include the LVDS support in this same patch series, so that we have all the parts that we're discussing in front of us.
Quoted 6 lines
arch/arm64/boot/dts/qcom/talos-evk-cb.dtsi new file +6
-0+ +/ { + model = "Qualcomm QCS615 IQ 615 EVK"; + compatible = "qcom,talos-evk", "qcom,qcs615", "qcom,sm6150"; + chassis-type = "embedded"; +
[..]
Quoted 1 line
arch/arm64/boot/dts/qcom/talos-evk-som.dtsi +0
-0
[..]
arch/arm64/boot/dts/qcom/talos-evk-som.dtsi line 258
Quoted 3 lines
+&mdss_dp0_out {
arch/arm64/boot/dts/qcom/talos-evk-som.dtsi +2
-0+ link-frequencies = /bits/ 64 <1620000000 2700000000 5400000000>; + remote-endpoint = <&dp0_connector_in>;
Don't we need/want a data-lanes property here as well?
arch/arm64/boot/dts/qcom/talos-evk-som.dtsi
Quoted 2 lines
arch/arm64/boot/dts/qcom/talos-evk-som.dtsi +2
-0+}; +
The rest of the patch looks good to me.
Regards,
Bjorn
Re: [PATCH v7 2/2] arm64: dts: qcom: talos-evk: Add support for QCS615 talos evk board
Quoted 46 lines · Bjorn Andersson
Quoted 45 lines · Sudarshan Shetty
Add the device tree for the QCS615-based Talos EVK platform. The platform is composed of a System-on-Module following the SMARC standard, and a Carrier Board.
The Carrier Board supports several display configurations, HDMI and LVDS. Both configurations use the same base hardware, with the display selection controlled by a DIP switch.
To avoid duplication, use an include file,
talos-evk-cb.dtsi, which defines the interfaces and peripherals common to both display variants. Two additional DTs (e.g. talos-evk and talos-evk-lvds) can describe the selected display configuration.The initial device tree includes support for:
- CPU and memory
- UART
- GPIOs
- Regulators
- PMIC
- Early console
- AT24MAC602 EEPROM
- MCP2515 SPI to CAN
- ADV7535 DSI-to-HDMI bridge
- DisplayPort interfaceSigned-off-by Sudarshan Shetty <[email protected]>--- arch/arm64/boot/dts/qcom/Makefile | 1 + arch/arm64/boot/dts/qcom/talos-evk-cb.dtsi | 56 +++ arch/arm64/boot/dts/qcom/talos-evk-som.dtsi | 447 ++++++++++++++++++++ arch/arm64/boot/dts/qcom/talos-evk.dts | 94 ++++ 4 files changed, 598 insertions(+) create mode 100644 arch/arm64/boot/dts/qcom/talos-evk-cb.dtsi create mode 100644 arch/arm64/boot/dts/qcom/talos-evk-som.dtsi create mode 100644 arch/arm64/boot/dts/qcom/talos-evk.dtsarch/arm64/boot/dts/qcom/Makefile +1
-0@@ -305,6 +305,7 @@ dtb-$(CONFIG_ARCH_QCOM) += sm8650-mtp.dtb dtb-$(CONFIG_ARCH_QCOM) += sm8650-qrd.dtb dtb-$(CONFIG_ARCH_QCOM) += sm8750-mtp.dtb dtb-$(CONFIG_ARCH_QCOM) += sm8750-qrd.dtb +dtb-$(CONFIG_ARCH_QCOM) += talos-evk.dtb
Quoted 9 lines
arch/arm64/boot/dts/qcom/talos-evk-cb.dtsi
Quoted 4 lines
arch/arm64/boot/dts/qcom/Makefile +0
-0x1e001de-devkit-el2-dtbs := x1e001de-devkit.dtb x1-el2.dtbo dtb-$(CONFIG_ARCH_QCOM) += x1e001de-devkit.dtb x1e001de-devkit-el2.dtb x1e78100-lenovo-thinkpad-t14s-el2-dtbs := x1e78100-lenovo-thinkpad-t14s.dtb x1-el2.dtboarch/arm64/boot/dts/qcom/talos-evk-cb.dtsi +0
-0I might have missed where you replied to any of my questions. But I still believe this file represents the Talos EVK - that is, the "Talos SOM" + the "Talos EVK Carrier board".
Yes. This file represents "Talos SOM" + the "Talos EVK Carrier board".
Quoted 38 lines
arch/arm64/boot/dts/qcom/talos-evk-cb.dtsi line 7
Quoted 12 lines
new file mode 100644
index 000000000000..81d15ee4f366arch/arm64/boot/dts/qcom/talos-evk-cb.dtsi new file +7
-0@@ -0,0 +1,55 @@ +// SPDX-License-Identifier: BSD-3-Clause +/* + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. + */ +/dts-v1/; + +#include "talos-evk-som.dtsi"Here this file stops being just a definition of the "carrier board", it's now the whole EVK.
As such, this file should be called "talos-evk".
We now have two options:
1)
talos-som.dtsi+talos-evk.dts+ talos-evk-lvds-auo,g133han01.dtsoWe describe the SOM, we describe the "standard configuration" of the EVK, and we have an overlay example that disabled the HDMI portions and adds LVDS and the specific panel.
2)
talos-som.dtsi+talos-evk.dtsi+talos-evk-hdmi.dts+talos-evk-lvds.dts+ talos-evk-lvds-auo,g133han01.dtsoWe avoid describing HDMI, just to remove it again in the overlay.
#2 would scale better if we have a lot of these boards, but unless we expect a lot of different boards/combinations I don't think there's much value in it.
Quoted 7 lines
Please let me know if my assumptions are wrong, but for now I think #1 is the correct choice.
In either case, you should include the LVDS support in this same patch series, so that we have all the parts that we're discussing in front of us.
Will proceed with option #1 by creating three files, i.e., talos-som.dtsi + talos-evk.dts + talos-evk-lvds-auo,g133han01.dtso The file "talos-evk-lvds-auo,g133han01.dtso" include the overlay to disable HDMI and adds the LVDS-related on top of the base EVK DTS file.
Quoted 7 lines
Quoted 6 lines
arch/arm64/boot/dts/qcom/talos-evk-cb.dtsi new file +6
-0+ +/ { + model = "Qualcomm QCS615 IQ 615 EVK"; + compatible = "qcom,talos-evk", "qcom,qcs615", "qcom,sm6150"; + chassis-type = "embedded"; +[..]
Quoted 8 lines
Quoted 1 line
arch/arm64/boot/dts/qcom/talos-evk-som.dtsi +0
-0[..]
arch/arm64/boot/dts/qcom/talos-evk-som.dtsi line 258
Quoted 3 lines
+&mdss_dp0_out {
arch/arm64/boot/dts/qcom/talos-evk-som.dtsi +2
-0+ link-frequencies = /bits/ 64 <1620000000 2700000000 5400000000>; + remote-endpoint = <&dp0_connector_in>;Don't we need/want a data-lanes property here as well?
Not required. Data-lane property is already defined in "talos.dtsi". >> +};
Quoted 6 lines
Quoted 1 line
+
The rest of the patch looks good to me.
Regards,
Bjorn
Re: [PATCH v7 2/2] arm64: dts: qcom: talos-evk: Add support for QCS615 talos evk board
In reply to Sudarshan ShettyQuoted 13 lines · Sudarshan Shetty
Add the device tree for the QCS615-based Talos EVK platform. The platform is composed of a System-on-Module following the SMARC standard, and a Carrier Board.
The Carrier Board supports several display configurations, HDMI and LVDS. Both configurations use the same base hardware, with the display selection controlled by a DIP switch.
To avoid duplication, use an include file,
talos-evk-cb.dtsi, which defines the interfaces and peripherals common to both display variants. Two additional DTs (e.g. talos-evk and talos-evk-lvds) can describe the selected display configuration.
Quoted 11 lines
The initial device tree includes support for:
- CPU and memory
- UART
- GPIOs
- Regulators
- PMIC
- Early console
- AT24MAC602 EEPROM
- MCP2515 SPI to CAN
- ADV7535 DSI-to-HDMI bridge
- DisplayPort interface
You got the question for v6, responded there but didn't update commit message. What is not enabled here? E.g. why isn't venus enabled?
Quoted 11 lines
Signed-off-by Sudarshan Shetty <[email protected]>--- arch/arm64/boot/dts/qcom/Makefile | 1 + arch/arm64/boot/dts/qcom/talos-evk-cb.dtsi | 56 +++ arch/arm64/boot/dts/qcom/talos-evk-som.dtsi | 447 ++++++++++++++++++++ arch/arm64/boot/dts/qcom/talos-evk.dts | 94 ++++ 4 files changed, 598 insertions(+) create mode 100644 arch/arm64/boot/dts/qcom/talos-evk-cb.dtsi create mode 100644 arch/arm64/boot/dts/qcom/talos-evk-som.dtsi create mode 100644 arch/arm64/boot/dts/qcom/talos-evk.dts
Signature · 2 lines
With best wishes Dmitry
Re: [PATCH v7 2/2] arm64: dts: qcom: talos-evk: Add support for QCS615 talos evk board
Quoted 26 lines · Dmitry Baryshkov
Quoted 13 lines · Sudarshan Shetty
Add the device tree for the QCS615-based Talos EVK platform. The platform is composed of a System-on-Module following the SMARC standard, and a Carrier Board.
The Carrier Board supports several display configurations, HDMI and LVDS. Both configurations use the same base hardware, with the display selection controlled by a DIP switch.
To avoid duplication, use an include file,
talos-evk-cb.dtsi, which defines the interfaces and peripherals common to both display variants. Two additional DTs (e.g. talos-evk and talos-evk-lvds) can describe the selected display configuration.Quoted 11 lines
The initial device tree includes support for:
- CPU and memory
- UART
- GPIOs
- Regulators
- PMIC
- Early console
- AT24MAC602 EEPROM
- MCP2515 SPI to CAN
- ADV7535 DSI-to-HDMI bridge
- DisplayPort interface
Quoted 2 lines
You got the question for v6, responded there but didn't update commit message. What is not enabled here? E.g. why isn't venus enabled?
In earlier patch, we have added 'Wi-Fi/BT and ethernet is not supported'as a commit message. Later,based on Krzysztof Kozlowski’s review comments, we removed the same. Please find the below review comment for your reference.
https://lore.kernel.org/all/[email protected]/T/#mda58996a7abac13780f8ce2cd49b84c32d4c50a6
We are not clear whether 'Wi-Fi/BT and ethernet is not supported' should be added back to the commit message or not. Could you please confirm your preference?
Venus is enabled in this patch.
Quoted 13 lines
Quoted 12 lines
Signed-off-by Sudarshan Shetty <[email protected]>--- arch/arm64/boot/dts/qcom/Makefile | 1 + arch/arm64/boot/dts/qcom/talos-evk-cb.dtsi | 56 +++ arch/arm64/boot/dts/qcom/talos-evk-som.dtsi | 447 ++++++++++++++++++++ arch/arm64/boot/dts/qcom/talos-evk.dts | 94 ++++ 4 files changed, 598 insertions(+) create mode 100644 arch/arm64/boot/dts/qcom/talos-evk-cb.dtsi create mode 100644 arch/arm64/boot/dts/qcom/talos-evk-som.dtsi create mode 100644 arch/arm64/boot/dts/qcom/talos-evk.dts
Re: [PATCH v7 2/2] arm64: dts: qcom: talos-evk: Add support for QCS615 talos evk board
Quoted 38 lines · On Thu, Nov 20, 2025 at 01:02:39PM +0530, [email protected] wrote:
Quoted 26 lines · Dmitry Baryshkov
Quoted 13 lines · Sudarshan Shetty
Add the device tree for the QCS615-based Talos EVK platform. The platform is composed of a System-on-Module following the SMARC standard, and a Carrier Board.
The Carrier Board supports several display configurations, HDMI and LVDS. Both configurations use the same base hardware, with the display selection controlled by a DIP switch.
To avoid duplication, use an include file,
talos-evk-cb.dtsi, which defines the interfaces and peripherals common to both display variants. Two additional DTs (e.g. talos-evk and talos-evk-lvds) can describe the selected display configuration.Quoted 11 lines
The initial device tree includes support for:
- CPU and memory
- UART
- GPIOs
- Regulators
- PMIC
- Early console
- AT24MAC602 EEPROM
- MCP2515 SPI to CAN
- ADV7535 DSI-to-HDMI bridge
- DisplayPort interfaceQuoted 2 lines
You got the question for v6, responded there but didn't update commit message. What is not enabled here? E.g. why isn't venus enabled?
In earlier patch, we have added 'Wi-Fi/BT and ethernet is not supported'as a commit message. Later,based on Krzysztof Kozlowski’s review comments, we removed the same. Please find the below review comment for your reference.
https://lore.kernel.org/all/[email protected]/T/#mda58996a7abac13780f8ce2cd49b84c32d4c50a6
Quoted 3 lines
We are not clear whether 'Wi-Fi/BT and ethernet is not supported' should be added back to the commit message or not. Could you please confirm your preference?
If you are unsure, you can add this info to the cover letter. Or you can write something like 'Ethernet and WiFi/BT are not (yet) supported.'.
Quoted 2 lines
Venus is enabled in this patch.
Ack, excuse me.
Quoted 14 lines
Quoted 13 lines
Quoted 12 lines
Signed-off-by Sudarshan Shetty <[email protected]>--- arch/arm64/boot/dts/qcom/Makefile | 1 + arch/arm64/boot/dts/qcom/talos-evk-cb.dtsi | 56 +++ arch/arm64/boot/dts/qcom/talos-evk-som.dtsi | 447 ++++++++++++++++++++ arch/arm64/boot/dts/qcom/talos-evk.dts | 94 ++++ 4 files changed, 598 insertions(+) create mode 100644 arch/arm64/boot/dts/qcom/talos-evk-cb.dtsi create mode 100644 arch/arm64/boot/dts/qcom/talos-evk-som.dtsi create mode 100644 arch/arm64/boot/dts/qcom/talos-evk.dts
Signature · 2 lines
With best wishes Dmitry
Re: [PATCH v7 2/2] arm64: dts: qcom: talos-evk: Add support for QCS615 talos evk board
Quoted 39 lines · Dmitry Baryshkov
Quoted 38 lines · On Thu, Nov 20, 2025 at 01:02:39PM +0530, [email protected] wrote:
Quoted 26 lines · Dmitry Baryshkov
Quoted 13 lines · Sudarshan Shetty
Add the device tree for the QCS615-based Talos EVK platform. The platform is composed of a System-on-Module following the SMARC standard, and a Carrier Board.
The Carrier Board supports several display configurations, HDMI and LVDS. Both configurations use the same base hardware, with the display selection controlled by a DIP switch.
To avoid duplication, use an include file,
talos-evk-cb.dtsi, which defines the interfaces and peripherals common to both display variants. Two additional DTs (e.g. talos-evk and talos-evk-lvds) can describe the selected display configuration.Quoted 11 lines
The initial device tree includes support for:
- CPU and memory
- UART
- GPIOs
- Regulators
- PMIC
- Early console
- AT24MAC602 EEPROM
- MCP2515 SPI to CAN
- ADV7535 DSI-to-HDMI bridge
- DisplayPort interfaceQuoted 2 lines
You got the question for v6, responded there but didn't update commit message. What is not enabled here? E.g. why isn't venus enabled?
In earlier patch, we have added 'Wi-Fi/BT and ethernet is not supported'as a commit message. Later,based on Krzysztof Kozlowski’s review comments, we removed the same. Please find the below review comment for your reference.
https://lore.kernel.org/all/[email protected]/T/#mda58996a7abac13780f8ce2cd49b84c32d4c50a6
Quoted 6 lines
Quoted 3 lines
We are not clear whether 'Wi-Fi/BT and ethernet is not supported' should be added back to the commit message or not. Could you please confirm your preference?
If you are unsure, you can add this info to the cover letter. Or you can write something like 'Ethernet and WiFi/BT are not (yet) supported.'.
Okay, we will add the info 'Ethernet and WiFi/BT are not (yet) supported' to the cover letter.
Quoted 21 lines
Quoted 3 lines
Venus is enabled in this patch.
Ack, excuse me.
Quoted 14 lines
Quoted 13 lines
Quoted 12 lines
Signed-off-by Sudarshan Shetty <[email protected]>--- arch/arm64/boot/dts/qcom/Makefile | 1 + arch/arm64/boot/dts/qcom/talos-evk-cb.dtsi | 56 +++ arch/arm64/boot/dts/qcom/talos-evk-som.dtsi | 447 ++++++++++++++++++++ arch/arm64/boot/dts/qcom/talos-evk.dts | 94 ++++ 4 files changed, 598 insertions(+) create mode 100644 arch/arm64/boot/dts/qcom/talos-evk-cb.dtsi create mode 100644 arch/arm64/boot/dts/qcom/talos-evk-som.dtsi create mode 100644 arch/arm64/boot/dts/qcom/talos-evk.dts