Skip to contentSkip to conversation

local.conf.sample: do not set PACKAGE_CLASSES as it is matching oe-core's default

PATCH New Alexander Kanavin 1 participant 2 messages Nov 18, 2025

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 local.conf.sample: do not set PACKAGE_CLASSES as it is matching oe-core's default

From: Alexander Kanavin <[email protected]>

This setting isn't necessary as it matches what is set in oe-core already. It may also interfere with settings on other places such as distro files or fragments.

---
 meta/conf/templates/default/local.conf.sample | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
meta/conf/templates/default/local.conf.sample +2 -2
index 9bb6601eb19..2639be3ddf1 100644
@@ -85,8 +85,8 @@ MACHINE ??= "qemux86-64"
 #  - 'package_ipk' for ipk files are used by opkg (a debian style embedded package manager)
 #  - 'package_rpm' for rpm style packages
 # E.g.: PACKAGE_CLASSES ?= "package_rpm package_deb package_ipk"
-# We default to ipk:
-PACKAGE_CLASSES ?= "package_ipk"
+# We default to ipk (via meta/conf/distro/defaultsetup.conf included in meta/conf/bitbake.conf):
+#PACKAGE_CLASSES ?= "package_ipk"
 
 #
 # SDK target architecture
Signature · 1 line
2.39.5
#1 lore raw

PATCH 2/2 local.conf.sample: comment out the root-with-empty-password setting

From: Alexander Kanavin <[email protected]>

This was not a good default; the autobuilder relied on it, but this has been fixed, there's now a separate fragment as well, and testimage has a check for the needed image features. Let's take this out and be more secure by default everywhere.

---
 meta/conf/templates/default/local.conf.sample | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
meta/conf/templates/default/local.conf.sample +4 -2
index 2639be3ddf1..fb6ed2c3bf2 100644
@@ -122,8 +122,10 @@ MACHINE ??= "qemux86-64"
 # There are other features that can be used here too, see
 # meta/classes-recipe/image.bbclass and
 # meta/classes-recipe/core-image.bbclass for more details.
-# We default to allowing root login without a password for convenience.
-EXTRA_IMAGE_FEATURES ?= "allow-empty-password empty-root-password allow-root-login"
+#
+# The following will allow root login without a password for convenience.
+# Use with care, and never in product builds.
+#EXTRA_IMAGE_FEATURES ?= "allow-empty-password empty-root-password allow-root-login"
 
 #
 # Additional image features
Signature · 1 line
2.39.5