tracing: Fix WARN_ON in tracing_buffers_mmap_close for split VMAs
PATCH 1/1 tracing: Fix WARN_ON in tracing_buffers_mmap_close for split VMAs
When a VMA is split (e.g., by partial munmap or MAP_FIXED), the kernel calls vm_ops->close on each portion. For trace buffer mappings, this results in ring_buffer_unmap() being called multiple times while ring_buffer_map() was only called once.
This causes ring_buffer_unmap() to return -ENODEV on subsequent calls because user_mapped is already 0, triggering a WARN_ON.
Trace buffer mappings cannot support partial mappings because the ring buffer structure requires the complete buffer including the meta page.
Fix this by adding a may_split callback that returns -EINVAL to prevent VMA splits entirely.
Tested-by [email protected]
Reported-by [email protected]
Signed-off-by Deepanshu Kartikey <[email protected]>
--- kernel/trace/trace.c | 10 ++++++++++ 1 file changed, 10 insertions(+)
kernel/trace/trace.c +10 -0
@@ -8781,8 +8781,18 @@ static void tracing_buffers_mmap_close(struct vm_area_struct *vma)put_snapshot_map (iter->tr); } +static int tracing_buffers_may_split (struct vm_area_struct *vma,unsigned long addr) +{ +/* +* Trace buffer mappings require the complete buffer including +* the meta page. Partial mappings are not supported. +*/ +return -EINVAL ; +} +static const struct vm_operations_struct tracing_buffers_vmops = { .close = tracing_buffers_mmap_close, + .may_split = tracing_buffers_may_split, };static int tracing_buffers_mmap (struct file *filp,struct vm_area_struct *vma)
Signature · 1 line
2.43.0