Skip to contentSkip to conversation

selftest-mm-fix-pointer-comparison-in-mremap_test.patch removed from -mm tree

merged mm-stable Andrew Morton 1 participant 1 message Nov 20, 2025

lore
Share & tools
lore

Andrew Morton

author tree notice Applied
#0 lore raw

The quilt patch titled
Subject: selftest/mm: fix pointer comparison in mremap_test
has been removed from the -mm tree. Its filename was
selftest-mm-fix-pointer-comparison-in-mremap_test.patch

This patch was dropped because it was merged into the mm-stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm

------------------------------------------------------
From: Ankit Khushwaha <[email protected]>
Subject: selftest/mm: fix pointer comparison in mremap_test
Date: Sat, 8 Nov 2025 21:48:29 +0530

Pointer arthemitic with 'void * addr' and 'ulong dest_alignment' triggers following warning:

mremap_test.c:1035:31: warning: pointer comparison always evaluates to false [-Wtautological-compare]
1035 | if (addr + c.dest_alignment < addr) {
| ^

this warning is raised from clang version 20.1.8 (Fedora 20.1.8-4.fc42).

use 'void *tmp_addr' to do the pointer arthemitic.

---

 tools/testing/selftests/mm/mremap_test.c |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
tools/testing/selftests/mm/mremap_test.c renamed from tools/testing/selftests/mm/mremap_test.c~selftest-mm-fix-pointer-comparison-in-mremap_test +3 -2
@@ -994,7 +994,7 @@ static void mremap_move_multi_invalid_vm
 static long long remap_region(struct config c, unsigned int threshold_mb,
 			      char *rand_addr)
 {
-	void *addr, *src_addr, *dest_addr, *dest_preamble_addr = NULL;
+	void *addr, *tmp_addr, *src_addr, *dest_addr, *dest_preamble_addr = NULL;
 	unsigned long long t, d;
 	struct timespec t_start = {0, 0}, t_end = {0, 0};
 	long long  start_ns, end_ns, align_mask, ret, offset;
@@ -1032,7 +1032,8 @@ static long long remap_region(struct con
 	/* Don't destroy existing mappings unless expected to overlap */
 	while (!is_remap_region_valid(addr, c.region_size) && !c.overlapping) {
 		/* Check for unsigned overflow */
-		if (addr + c.dest_alignment < addr) {
+		tmp_addr = addr + c.dest_alignment;
+		if (tmp_addr < addr) {
 			ksft_print_msg("Couldn't find a valid region to remap to\n");
 			ret = -1;
 			goto clean_up_src;

_

Patches currently in -mm which might be from [email protected] are