Skip to contentSkip to conversation

pic64gx clk kconfig/binding changes

PATCH Superseded Conor Dooley 3 participants 11 messages Nov 21, 2025 – Jan 9

Subsystems (4)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

v2 cover pic64gx clk kconfig/binding changes

From: Conor Dooley <[email protected]>

Mostly this is stuff that PH did last year, but rebased on top of current work, now that the clock driver rework patches have been applied.

v2: fix the binding, d'oh

CC Conor Dooley <[email protected]>
CC Daire McNamara <[email protected]>
CC Michael Turquette <[email protected]>
CC Stephen Boyd <[email protected]>
CC Rob Herring <[email protected]>
CC Krzysztof Kozlowski <[email protected]>
CC Claudiu Beznea <[email protected]>

Conor Dooley (1):
clk: microchip: drop POLARFIRE from ARCH_MICROCHIP_POLARFIRE

Pierre-Henry Moussay (2):
dt-bindings: clock: mpfs-ccc: Add pic64gx compatibility
dt-bindings: clock: mpfs-clkcfg: Add pic64gx compatibility

 .../bindings/clock/microchip,mpfs-ccc.yaml       |  6 +++++-
 .../bindings/clock/microchip,mpfs-clkcfg.yaml    | 16 +++++++++++++++-
 drivers/clk/microchip/Kconfig                    |  4 ++--
 3 files changed, 22 insertions(+), 4 deletions(-)
Signature · 1 line
2.51.0
#1 lore raw

PATCH v2 1/3 clk: microchip: drop POLARFIRE from ARCH_MICROCHIP_POLARFIRE

From: Conor Dooley <[email protected]>

This driver is used by non-polarfire devices now, and the ARCH_MICROCHIP symbol has been defined for some time on RISCV so drop it without any functional change.

---
 drivers/clk/microchip/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/clk/microchip/Kconfig +2 -2
index cab9a909893b..a0ef14310417 100644
@@ -5,8 +5,8 @@ config COMMON_CLK_PIC32
 
 config MCHP_CLK_MPFS
 	bool "Clk driver for PolarFire SoC"
-	depends on ARCH_MICROCHIP_POLARFIRE || COMPILE_TEST
-	default ARCH_MICROCHIP_POLARFIRE
+	depends on ARCH_MICROCHIP || COMPILE_TEST
+	default y
 	depends on MFD_SYSCON
 	select AUXILIARY_BUS
 	select COMMON_CLK_DIVIDER_REGMAP
Signature · 1 line
2.51.0
#2 lore raw

Re: [PATCH v2 1/3] clk: microchip: drop POLARFIRE from ARCH_MICROCHIP_POLARFIRE

Quoted 16 lines · Conor Dooley

From: Conor Dooley <[email protected]>

This driver is used by non-polarfire devices now, and the ARCH_MICROCHIP symbol has been defined for some time on RISCV so drop it without any functional change.

---
 drivers/clk/microchip/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/clk/microchip/Kconfig +0 -0
index cab9a909893b..a0ef14310417 100644

drivers/clk/microchip/Kconfig config COMMON_CLK_PIC32 · line 12

Quoted 10 lines
drivers/clk/microchip/Kconfig +2 -2
@@ -5,8 +5,8 @@ config COMMON_CLK_PIC32
 
 config MCHP_CLK_MPFS
 	bool "Clk driver for PolarFire SoC"
-	depends on ARCH_MICROCHIP_POLARFIRE || COMPILE_TEST
-	default ARCH_MICROCHIP_POLARFIRE
+	depends on ARCH_MICROCHIP || COMPILE_TEST
+	default y
 	depends on MFD_SYSCON
 	select AUXILIARY_BUS
 	select COMMON_CLK_DIVIDER_REGMAP

OK, I found v2 in my inbox. Same symptom here. It doesn't apply on top of the current at91-next either.

Thank you,
Claudiu

#3 lore raw

Re: [PATCH v2 1/3] clk: microchip: drop POLARFIRE from ARCH_MICROCHIP_POLARFIRE

Quoted 20 lines · Claudiu Beznea
Quoted 17 lines · Conor Dooley

From: Conor Dooley <[email protected]>

This driver is used by non-polarfire devices now, and the ARCH_MICROCHIP symbol has been defined for some time on RISCV so drop it without any functional change.

---
 drivers/clk/microchip/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/clk/microchip/Kconfig +0 -0
index cab9a909893b..a0ef14310417 100644
@@ -5,8 +5,8 @@ config COMMON_CLK_PIC32
 
Quoted 12 lines

drivers/clk/microchip/Kconfig config COMMON_CLK_PIC32 · line 12

Quoted 9 lines
drivers/clk/microchip/Kconfig +2 -2
 config MCHP_CLK_MPFS
 	bool "Clk driver for PolarFire SoC"
-	depends on ARCH_MICROCHIP_POLARFIRE || COMPILE_TEST
-	default ARCH_MICROCHIP_POLARFIRE
+	depends on ARCH_MICROCHIP || COMPILE_TEST
+	default y
 	depends on MFD_SYSCON
 	select AUXILIARY_BUS
 	select COMMON_CLK_DIVIDER_REGMAP

OK, I found v2 in my inbox. Same symptom here. It doesn't apply on top of the current at91-next either.

I think this should sort itself out after -rc1, but I'll resend if it doesn't.

#4 lore raw

Re: [PATCH v2 1/3] clk: microchip: drop POLARFIRE from ARCH_MICROCHIP_POLARFIRE

Quoted 34 lines · Conor Dooley
Quoted 20 lines · Claudiu Beznea
Quoted 17 lines · Conor Dooley

From: Conor Dooley <[email protected]>

This driver is used by non-polarfire devices now, and the ARCH_MICROCHIP symbol has been defined for some time on RISCV so drop it without any functional change.

---
  drivers/clk/microchip/Kconfig | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
drivers/clk/microchip/Kconfig +0 -0
index cab9a909893b..a0ef14310417 100644
@@ -5,8 +5,8 @@ config COMMON_CLK_PIC32
 
Quoted 12 lines

drivers/clk/microchip/Kconfig config COMMON_CLK_PIC32 · line 12

Quoted 9 lines
drivers/clk/microchip/Kconfig +2 -2
  config MCHP_CLK_MPFS
  	bool "Clk driver for PolarFire SoC"
-	depends on ARCH_MICROCHIP_POLARFIRE || COMPILE_TEST
-	default ARCH_MICROCHIP_POLARFIRE
+	depends on ARCH_MICROCHIP || COMPILE_TEST
+	default y
  	depends on MFD_SYSCON
  	select AUXILIARY_BUS
  	select COMMON_CLK_DIVIDER_REGMAP

OK, I found v2 in my inbox. Same symptom here. It doesn't apply on top of the current at91-next either.

Quoted 2 lines

I think this should sort itself out after -rc1, but I'll resend if it doesn't.

Still doesn't apply. It conflicts at least with
commit c6f2dddfa7f9 ("clk: microchip: mpfs: use regmap for clocks")

Thank you,
Claudiu

#5 lore raw

Re: [PATCH v2 1/3] clk: microchip: drop POLARFIRE from ARCH_MICROCHIP_POLARFIRE

Quoted 36 lines · claudiu beznea
Quoted 33 lines · Conor Dooley
Quoted 31 lines · Claudiu Beznea
Quoted 16 lines · Conor Dooley

From: Conor Dooley <[email protected]>

This driver is used by non-polarfire devices now, and the ARCH_MICROCHIP symbol has been defined for some time on RISCV so drop it without any functional change.

---
  drivers/clk/microchip/Kconfig | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
drivers/clk/microchip/Kconfig +0 -0
index cab9a909893b..a0ef14310417 100644

drivers/clk/microchip/Kconfig config COMMON_CLK_PIC32 · line 11

Quoted 9 lines
drivers/clk/microchip/Kconfig +2 -2
@@ -5,8 +5,8 @@ config COMMON_CLK_PIC32
  config MCHP_CLK_MPFS
  	bool "Clk driver for PolarFire SoC"
-	depends on ARCH_MICROCHIP_POLARFIRE || COMPILE_TEST
-	default ARCH_MICROCHIP_POLARFIRE
+	depends on ARCH_MICROCHIP || COMPILE_TEST
+	default y
  	depends on MFD_SYSCON
  	select AUXILIARY_BUS
  	select COMMON_CLK_DIVIDER_REGMAP

OK, I found v2 in my inbox. Same symptom here. It doesn't apply on top of the current at91-next either.

Quoted 5 lines
Quoted 2 lines

I think this should sort itself out after -rc1, but I'll resend if it doesn't.

Still doesn't apply. It conflicts at least with
commit c6f2dddfa7f9 ("clk: microchip: mpfs: use regmap for clocks")

Right, I'll resend. Thought it was based on the aforementioned patch tbh!

#6 lore raw

PATCH v2 2/3 dt-bindings: clock: mpfs-ccc: Add pic64gx compatibility

In reply to Conor Dooley

From: Pierre-Henry Moussay <[email protected]>

pic64gx SoC Clock Conditioning Circuitry is compatibles with the Polarfire SoC

---
 .../devicetree/bindings/clock/microchip,mpfs-ccc.yaml       | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/clock/microchip,mpfs-ccc.yaml +5 -1
index f1770360798f..9a6b50527c42 100644
@@ -17,7 +17,11 @@ description: |
 
 properties:
   compatible:
-    const: microchip,mpfs-ccc
+    oneOf:
+      - items:
+          - const: microchip,pic64gx-ccc
+          - const: microchip,mpfs-ccc
+      - const: microchip,mpfs-ccc
 
   reg:
     items:
Signature · 1 line
2.51.0
Reviewed-by on v2 2/3
#7 lore raw

Re: [PATCH v2 2/3] dt-bindings: clock: mpfs-ccc: Add pic64gx compatibility

Quoted 8 lines · Conor Dooley

From: Pierre-Henry Moussay <[email protected]>

pic64gx SoC Clock Conditioning Circuitry is compatibles with the Polarfire SoC

Quoted 21 lines
---
 .../devicetree/bindings/clock/microchip,mpfs-ccc.yaml       | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/clock/microchip,mpfs-ccc.yaml +5 -1
index f1770360798f..9a6b50527c42 100644
@@ -17,7 +17,11 @@ description: |
 
 properties:
   compatible:
-    const: microchip,mpfs-ccc
+    oneOf:
+      - items:
+          - const: microchip,pic64gx-ccc
+          - const: microchip,mpfs-ccc
+      - const: microchip,mpfs-ccc
 
   reg:
     items:
#8 lore raw

PATCH v2 3/3 dt-bindings: clock: mpfs-clkcfg: Add pic64gx compatibility

In reply to Conor Dooley

From: Pierre-Henry Moussay <[email protected]>

pic64gx has a clock controller compatible with mpfs-clkcfg. Don't permit the deprecated configuration that was never supported for this SoC.

---
 .../bindings/clock/microchip,mpfs-clkcfg.yaml    | 16 +++++++++++++++-
 1 file changed, 15 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/clock/microchip,mpfs-clkcfg.yaml +15 -1
index ee4f31596d97..a23703c281d1 100644
@@ -19,7 +19,11 @@ description: |
 
 properties:
   compatible:
-    const: microchip,mpfs-clkcfg
+    oneOf:
+      - items:
+          - const: microchip,pic64gx-clkcfg
+          - const: microchip,mpfs-clkcfg
+      - const: microchip,mpfs-clkcfg
 
   reg:
     oneOf:
@@ -69,6 +73,16 @@ required:
   - clocks
   - '#clock-cells'
 
+if:
+  properties:
+    compatible:
+      contains:
+        const: microchip,pic64gx-clkcfg
+then:
+  properties:
+    reg:
+      maxItems: 1
+
 additionalProperties: false
 
 examples:
Signature · 1 line
2.51.0
Acked-by on v2 3/3
#9 lore raw

Re: [PATCH v2 3/3] dt-bindings: clock: mpfs-clkcfg: Add pic64gx compatibility

Quoted 11 lines · Conor Dooley

From: Pierre-Henry Moussay <[email protected]>

pic64gx has a clock controller compatible with mpfs-clkcfg. Don't permit the deprecated configuration that was never supported for this SoC.

---
 .../bindings/clock/microchip,mpfs-clkcfg.yaml    | 16 +++++++++++++++-
 1 file changed, 15 insertions(+), 1 deletion(-)

Best regards,
Krzysztof

Reviewed-by on v2 3/3
#10 lore raw

Re: [PATCH v2 3/3] dt-bindings: clock: mpfs-clkcfg: Add pic64gx compatibility

In reply to Conor Dooley
Quoted 8 lines · Conor Dooley

From: Pierre-Henry Moussay <[email protected]>

pic64gx has a clock controller compatible with mpfs-clkcfg. Don't permit the deprecated configuration that was never supported for this SoC.