Skip to contentSkip to conversation

ASoC: codec: rt274: Use devm_request_threaded_irq to manage IRQ lifetime and fix smatch warning

PATCH Superseded [email protected] 2 participants 2 messages Nov 21, 2025 – Dec 15, 2025

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: codec: rt274: Use devm_request_threaded_irq to manage IRQ lifetime and fix smatch warning

From: HariKrishna Sagala <[email protected]>

Replace manual "request_threaded_irq()" with the device managed "devm_request_threaded_irq" to manage the IRQ lifetime and also it removes the smatch reported warning.
Remove the manual "free_irq()" in the "remove" function as free_irq is tied to device teardown.

---
Hello All,

This patch replaces the manual management of IRQ with the device managed IRQ API. Also, it removes the smatch reported warning. sound/soc/codecs/rt274.c:1204 rt274_i2c_probe() warn:
'rt274->i2c->irq' from request_threaded_irq() not released on lines: 1204.

Removed the "remove" function as IRQ is managed automatically. Runtime testing is requested to see no regressions.
Please report any failures or unexpected behaviour, I will support in updating the patch accordingly.

Similar warning is present in the codecs rt286 & rt298. If you are ok for updating those, will update them.

Thank you.

 sound/soc/codecs/rt274.c | 12 +-----------
 1 file changed, 1 insertion(+), 11 deletions(-)
sound/soc/codecs/rt274.c +1 -11
index 2c055c45111f..d441851dee8c 100644
@@ -1188,7 +1188,7 @@ static int rt274_i2c_probe(struct i2c_client *i2c)
 	regmap_write(rt274->regmap, RT274_UNSOLICITED_MIC, 0x82);
 
 	if (rt274->i2c->irq) {
-		ret = request_threaded_irq(rt274->i2c->irq, NULL, rt274_irq,
+		ret = devm_request_threaded_irq(&rt274->i2c->dev, rt274->i2c->irq, NULL, rt274_irq,
 			IRQF_TRIGGER_HIGH | IRQF_ONESHOT, "rt274", rt274);
 		if (ret != 0) {
 			dev_err(&i2c->dev,
@@ -1204,15 +1204,6 @@ static int rt274_i2c_probe(struct i2c_client *i2c)
 	return ret;
 }
 
-static void rt274_i2c_remove(struct i2c_client *i2c)
-{
-	struct rt274_priv *rt274 = i2c_get_clientdata(i2c);
-
-	if (i2c->irq)
-		free_irq(i2c->irq, rt274);
-}
-
-
 static struct i2c_driver rt274_i2c_driver = {
 	.driver = {
 		   .name = "rt274",
@@ -1222,7 +1213,6 @@ static struct i2c_driver rt274_i2c_driver = {
 #endif
 		   },
 	.probe = rt274_i2c_probe,
-	.remove = rt274_i2c_remove,
 	.id_table = rt274_i2c_id,
 };
 

base-commit: 24172e0d79900908cf5ebf366600616d29c9b417

Signature · 1 line
2.43.0
maintainer
#1 lore raw
Quoted 8 lines · On Fri, 21 Nov 2025 19:39:43 +0530, [email protected] wrote:

Replace manual "request_threaded_irq()" with the device managed "devm_request_threaded_irq" to manage the IRQ lifetime and also it removes the smatch reported warning.
Remove the manual "free_irq()" in the "remove" function as free_irq is tied to device teardown.

[...]

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: codec: rt274: Use devm_request_threaded_irq to manage IRQ lifetime and fix smatch warning

      commit: d00e80606e76233f4ae03486a9809c9edfe8b27e

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark