Skip to contentSkip to conversation

cpuidle: Update header inclusion

PATCH Applied Andy Shevchenko 2 participants 2 messages Nov 24, 2025 – Nov 25, 2025 CPU idle time management framework

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 cpuidle: Update header inclusion

While cleaning up some headers, I got a build error on this file:

drivers/cpuidle/poll_state.c:52:2: error: call to undeclared library function 'snprintf' with type 'int (char *restrict, unsigned long, const char *restrict, ...)'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]

Update header inclusions to follow IWYU (Include What You Use) principle.

---
 drivers/cpuidle/poll_state.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/cpuidle/poll_state.c +4 -0
index 9b6d90a72601..c7524e4c522a 100644
@@ -4,9 +4,13 @@
  */
 
 #include <linux/cpuidle.h>
+#include <linux/export.h>
+#include <linux/irqflags.h>
 #include <linux/sched.h>
 #include <linux/sched/clock.h>
 #include <linux/sched/idle.h>
+#include <linux/sprintf.h>
+#include <linux/types.h>
 
 #define POLL_IDLE_RELAX_COUNT	200
 
Signature · 1 line
2.50.1
maintainer Applied
#1 lore raw
Quoted 22 lines · Andy Shevchenko

While cleaning up some headers, I got a build error on this file:

drivers/cpuidle/poll_state.c:52:2: error: call to undeclared library function 'snprintf' with type 'int (char *restrict, unsigned long, const char *restrict, ...)'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]

Update header inclusions to follow IWYU (Include What You Use) principle.

---
 drivers/cpuidle/poll_state.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/cpuidle/poll_state.c +1 -0
index 9b6d90a72601..c7524e4c522a 100644
@@ -4,9 +4,13 @@
  */
 
 #include <linux/cpuidle.h>
+#include <linux/export.h>

drivers/cpuidle/poll_state.c

Quoted 10 lines
drivers/cpuidle/poll_state.c +3 -1
+#include <linux/irqflags.h>
 #include <linux/sched.h>
 #include <linux/sched/clock.h>
 #include <linux/sched/idle.h>
+#include <linux/sprintf.h>
+#include <linux/types.h>
 
 #define POLL_IDLE_RELAX_COUNT  200
 
--

Applied as 6.19 material, thanks!