eth: fbnic: Fix counter roll-over issue
Subsystems (3)
PATCH 1/1 eth: fbnic: Fix counter roll-over issue
Fix a potential counter roll-over issue in fbnic_mbx_alloc_rx_msgs() when calculating descriptor slots. The issue occurs when head - tail results in a large positive value (unsigned) and the compiler interprets head - tail - 1 as a signed value.
Since FBNIC_IPC_MBX_DESC_LEN is a power of two, use a masking operation, which is a common way of avoiding this problem when dealing with these sort of ring space calculations.
--- drivers/net/ethernet/meta/fbnic/fbnic_fw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/meta/fbnic/fbnic_fw.c +1 -1
@@ -201,7 +201,7 @@ static int fbnic_mbx_alloc_rx_msgs(struct fbnic_dev *fbd)return -ENODEV ;/* Fill all but 1 unused descriptors in the Rx queue. */ - count = (head - tail -1 ) %FBNIC_IPC_MBX_DESC_LEN ; + count = (head - tail -1 ) & (FBNIC_IPC_MBX_DESC_LEN -1 );while (!err && count--) {struct fbnic_tlv_msg *msg;
Signature · 1 line
2.47.3
This patch was applied to netdev/net.git (main) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <[email protected]>:
Quoted 10 lines · On Tue, 25 Nov 2025 13:17:04 -0800 you wrote:
Fix a potential counter roll-over issue in
fbnic_mbx_alloc_rx_msgs()when calculating descriptor slots. The issue occurs when head - tail results in a large positive value (unsigned) and the compiler interprets head - tail - 1 as a signed value.Since
FBNIC_IPC_MBX_DESC_LENis a power of two, use a masking operation, which is a common way of avoiding this problem when dealing with these sort of ring space calculations.[...]
Here is the summary with links:
- [net] eth: fbnic: Fix counter roll-over issue
https://git.kernel.org/netdev/net/c/6d66e093e074
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html