arm64: dts: qcom: talos: Correct UFS clocks ordering
PATCH 1/1 arm64: dts: qcom: talos: Correct UFS clocks ordering
The current UFS clocks does not align with their respective names, causing the ref_clk to be set to an incorrect frequency as below, which results in command timeouts.
ufshcd-qcom 1d84000.ufshc: invalid ref_clk setting = 300000000
This commit fixes the issue by properly reordering the UFS clocks to match their names.
--- arch/arm64/boot/dts/qcom/talos.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm64/boot/dts/qcom/talos.dtsi +2 -2
@@ -1399,10 +1399,10 @@ <&gcc GCC_AGGRE_UFS_PHY_AXI_CLK>, <&gcc GCC_UFS_PHY_AHB_CLK>, <&gcc GCC_UFS_PHY_UNIPRO_CORE_CLK>, - <&gcc GCC_UFS_PHY_ICE_CORE_CLK>, <&rpmhcc RPMH_CXO_CLK>, <&gcc GCC_UFS_PHY_TX_SYMBOL_0_CLK>, - <&gcc GCC_UFS_PHY_RX_SYMBOL_0_CLK>; + <&gcc GCC_UFS_PHY_RX_SYMBOL_0_CLK>, + <&gcc GCC_UFS_PHY_ICE_CORE_CLK>; clock-names = "core_clk", "bus_aggr_clk", "iface_clk",
Signature · 1 line
2.17.1
Quoted 9 lines · Pradeep P V K
The current UFS clocks does not align with their respective names, causing the
ref_clkto be set to an incorrect frequency as below, which results in command timeouts.ufshcd-qcom 1d84000.ufshc: invalid
ref_clksetting = 300000000This commit fixes the issue by properly reordering the UFS clocks to match their names.
Quoted 7 lines
Fixes ea172f61f4fd ("arm64: dts: qcom: qcs615: Fix up UFS clocks")Signed-off-by Pradeep P V K <[email protected]>--- arch/arm64/boot/dts/qcom/talos.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Signature · 2 lines
With best wishes Dmitry
Quoted 10 lines · Pradeep P V K
The current UFS clocks does not align with their respective names, causing the
ref_clkto be set to an incorrect frequency as below, which results in command timeouts.ufshcd-qcom 1d84000.ufshc: invalid
ref_clksetting = 300000000This commit fixes the issue by properly reordering the UFS clocks to match their names.
[...]
Applied, thanks!
[1/1] arm64: dts: qcom: talos: Correct UFS clocks ordering
commit: 8bb3754909cde5df4f8c1012bde220b97d8ee3bc
Best regards,
Signature · 1 line
Bjorn Andersson <[email protected]>