Skip to contentSkip to conversation

staging: fluke_gpib: use kzalloc instead of kmalloc + memset

PATCH In review Tomasz Sadowski 3 participants 4 messages Nov 25, 2025 – Nov 26, 2025 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: fluke_gpib: use kzalloc instead of kmalloc + memset

---
 drivers/staging/gpib/eastwood/fluke_gpib.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/staging/gpib/eastwood/fluke_gpib.c +1 -2
index 3ae848e3f738..2b6ba7882dba 100644
@@ -853,11 +853,10 @@ static int fluke_allocate_private(struct gpib_board *board)
 {
 	struct fluke_priv *priv;
 
-	board->private_data = kmalloc(sizeof(struct fluke_priv), GFP_KERNEL);
+	board->private_data = kzalloc(sizeof(*board->private_data), GFP_KERNEL);
 	if (!board->private_data)
 		return -ENOMEM;
 	priv = board->private_data;
-	memset(priv, 0, sizeof(struct fluke_priv));
 	init_nec7210_private(&priv->nec7210_priv);
 	priv->dma_buffer_size = 0x7ff;
 	priv->dma_buffer = kmalloc(priv->dma_buffer_size, GFP_KERNEL);
Signature · 1 line
2.52.0
#1 lore raw
Quoted 26 lines · Tomasz Sadowski
---
 drivers/staging/gpib/eastwood/fluke_gpib.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/staging/gpib/eastwood/fluke_gpib.c +1 -2
index 3ae848e3f738..2b6ba7882dba 100644
@@ -853,11 +853,10 @@ static int fluke_allocate_private(struct gpib_board *board)
 {
 	struct fluke_priv *priv;
 
-	board->private_data = kmalloc(sizeof(struct fluke_priv), GFP_KERNEL);
+	board->private_data = kzalloc(sizeof(*board->private_data), GFP_KERNEL);
 	if (!board->private_data)
 		return -ENOMEM;
 	priv = board->private_data;
-	memset(priv, 0, sizeof(struct fluke_priv));
 	init_nec7210_private(&priv->nec7210_priv);
 	priv->dma_buffer_size = 0x7ff;
 	priv->dma_buffer = kmalloc(priv->dma_buffer_size, GFP_KERNEL);
Signature · 1 line
2.52.0

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree.

You are receiving this message because of the following common error(s) as indicated below:

- You did not specify a description of why the patch is needed, or possibly, any description at all, in the email body. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/process/submitting-patches.rst for what is needed in order to properly describe the change.

If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers.

thanks,

greg k-h's patch email bot

#2 lore raw

PATCH 1/1 staging: fluke_gpib: use kzalloc instead of kmalloc + memset

Quoted 2 lines

You did not specify a description of why the patch is needed, or possibly, any description at all, in the email body. [...]

Thanks, the commit message now includes a proper description. The patch itself has not changed.

I also realized that the previous subject line might have been incorrect. The correct subject should be:

staging: gpib: eastwood: use kzalloc instead of kmalloc + memset

Use kzalloc() instead of kmalloc() + memset() to simplify memory allocation.

Also use sizeof(*board->private_data) instead of repeating the struct name. This avoids duplication and keeps the code correct if the struct name changes in the future.

---
 drivers/staging/gpib/eastwood/fluke_gpib.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/staging/gpib/eastwood/fluke_gpib.c +1 -2
index 3ae848e3f738..2b6ba7882dba 100644
@@ -853,11 +853,10 @@ static int fluke_allocate_private(struct gpib_board *board)
 {
 	struct fluke_priv *priv;
 
-	board->private_data = kmalloc(sizeof(struct fluke_priv), GFP_KERNEL);
+	board->private_data = kzalloc(sizeof(*board->private_data), GFP_KERNEL);
 	if (!board->private_data)
 		return -ENOMEM;
 	priv = board->private_data;
-	memset(priv, 0, sizeof(struct fluke_priv));
 	init_nec7210_private(&priv->nec7210_priv);
 	priv->dma_buffer_size = 0x7ff;
 	priv->dma_buffer = kmalloc(priv->dma_buffer_size, GFP_KERNEL);
Signature · 1 line
2.52.0
#3 lore raw
Quoted 11 lines · Tomasz Sadowski
Quoted 2 lines

You did not specify a description of why the patch is needed, or possibly, any description at all, in the email body. [...]

Thanks, the commit message now includes a proper description. The patch itself has not changed.

I also realized that the previous subject line might have been incorrect. The correct subject should be:

staging: gpib: eastwood: use kzalloc instead of kmalloc + memset

All this is weird commentary to put into a patch...

Quoted 8 lines

Use kzalloc() instead of kmalloc() + memset() to simplify memory allocation.

Also use sizeof(*board->private_data) instead of repeating the struct name. This avoids duplication and keeps the code correct if the struct name changes in the future.

---

This isn't how to send a v2 patch.

https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/

regards,
dan carpenter