Skip to contentSkip to conversation

net: gso: fix MTU validation of BIG TCP jumbograms

PATCH Superseded Mariusz Klimek 2 participants 12 messages Nov 27, 2025 – Jan 6

Subsystems (4)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

cover net: gso: fix MTU validation of BIG TCP jumbograms

This series fixes the MTU validation of BIG TCP jumbograms and removes the existing IP6SKB_FAKEJUMBO work-around that only fixes the issue in one location.

For GSO packets, the length that matters for MTU validation is the segment length, not the total length of the packet. skb_gso_network_seglen is used by skb_gso_validate_network_len to calculate the segment length including the network and transport headers and to then verify that the segment length is below the MTU.

skb_gso_network_seglen assumes that the headers of the segments are identical to those of the unsegmented packet, but that assumption is incorrect for BIG TCP jumbograms which have an added HBH header that is removed upon segmentation. The calculated segment length ends up being 8 bytes more than the actual segment length.

The actual segment length is set according to the MSS, so the segment length calculated by skb_gso_network_seglen is greater than the MTU, causing the skb_gso_validate_network_len check to fail despite the fact that the actual segment length is lower than the MTU.

There is currently a work-around that fixes this bug in some cases:
ip6_xmit sets the IP6SKB_FAKEJUMBO flag for BIG TCP jumbograms, which causes the MTU validation in ip6_finish_output_gso to be skipped (intentionally). However, this work-around doesn't apply to MTU validations performed in other places such as in ip6_forward. BIG TCP jumbograms don't pass the MTU validation when forwarded locally and are therefore dropped, unless the MTU of the originating interface is lower than the MTUs of the rest of the interfaces the packets are forwarded through.

Mariusz Klimek (3):
net: gso: do not include jumbogram HBH header in seglen calculation
ipv6: remove IP6SKB_FAKEJUMBO flag
selftests/net: remove unnecessary MTU config in big_tcp.sh

 include/linux/ipv6.h                   | 1 -
 net/core/gso.c                         | 4 ++++
 net/ipv6/ip6_output.c                  | 4 +---
 tools/testing/selftests/net/big_tcp.sh | 1 -
 4 files changed, 5 insertions(+), 5 deletions(-)
Signature · 1 line
2.47.3
#1 lore raw

PATCH 1/3 net: gso: do not include jumbogram HBH header in seglen calculation

This patch fixes an issue in skb_gso_network_seglen where the calculated segment length includes the HBH headers of BIG TCP jumbograms despite these headers being removed before segmentation. These headers are added by GRO or by ip6_xmit for BIG TCP packets and are later removed by GSO. This bug causes MTU validation of BIG TCP jumbograms to fail.

---
 net/core/gso.c | 4 ++++
 1 file changed, 4 insertions(+)
net/core/gso.c +4 -0
index bcd156372f4d..251a49181031 100644
@@ -180,6 +180,10 @@ static unsigned int skb_gso_network_seglen(const struct sk_buff *skb)
 	unsigned int hdr_len = skb_transport_header(skb) -
 			       skb_network_header(skb);
 
+	/* Jumbogram HBH header is removed upon segmentation. */
+	if (skb->protocol == htons(ETH_P_IPV6) && skb->len > IPV6_MAXPLEN)
+		hdr_len -= sizeof(struct hop_jumbo_hdr);
+
 	return hdr_len + skb_gso_transport_seglen(skb);
 }
 
Signature · 1 line
2.47.3
maintainer
#2 lore raw

Re: [PATCH net-next 1/3] net: gso: do not include jumbogram HBH header in seglen calculation

Quoted 16 lines · Mariusz Klimek

This patch fixes an issue in skb_gso_network_seglen where the calculated segment length includes the HBH headers of BIG TCP jumbograms despite these headers being removed before segmentation. These headers are added by GRO or by ip6_xmit for BIG TCP packets and are later removed by GSO. This bug causes MTU validation of BIG TCP jumbograms to fail.

---
 net/core/gso.c | 4 ++++
 1 file changed, 4 insertions(+)
net/core/gso.c +0 -0
index bcd156372f4d..251a49181031 100644

net/core/gso.c static unsigned int skb_gso_network_seglen(const struct sk_buff *skb) · line 185

Quoted 6 lines
net/core/gso.c +3 -0
@@ -180,6 +180,10 @@ static unsigned int skb_gso_network_seglen(const struct sk_buff *skb)
 	unsigned int hdr_len = skb_transport_header(skb) -
 			       skb_network_header(skb);
 
+	/* Jumbogram HBH header is removed upon segmentation. */
+	if (skb->protocol == htons(ETH_P_IPV6) && skb->len > IPV6_MAXPLEN)
+		hdr_len -= sizeof(struct hop_jumbo_hdr);

Isn't the above condition a bit too course-grain? Specifically, can UDP-encapsulated GSO packets wrongly hit it?

/P

maintainer
#3 lore raw

Re: [PATCH net-next 1/3] net: gso: do not include jumbogram HBH header in seglen calculation

Quoted 20 lines · Paolo Abeni
Quoted 19 lines · Mariusz Klimek

This patch fixes an issue in skb_gso_network_seglen where the calculated segment length includes the HBH headers of BIG TCP jumbograms despite these headers being removed before segmentation. These headers are added by GRO or by ip6_xmit for BIG TCP packets and are later removed by GSO. This bug causes MTU validation of BIG TCP jumbograms to fail.

---
 net/core/gso.c | 4 ++++
 1 file changed, 4 insertions(+)
net/core/gso.c +0 -0
index bcd156372f4d..251a49181031 100644
@@ -180,6 +180,10 @@ static unsigned int skb_gso_network_seglen(const struct sk_buff *skb)
 	unsigned int hdr_len = skb_transport_header(skb) -
 			       skb_network_header(skb);
 
Quoted 6 lines

net/core/gso.c static unsigned int skb_gso_network_seglen(const struct sk_buff *skb) · line 185

Quoted 3 lines
net/core/gso.c +3 -0
+	/* Jumbogram HBH header is removed upon segmentation. */
+	if (skb->protocol == htons(ETH_P_IPV6) && skb->len > IPV6_MAXPLEN)
+		hdr_len -= sizeof(struct hop_jumbo_hdr);

Isn't the above condition a bit too course-grain? Specifically, can UDP-encapsulated GSO packets wrongly hit it?

I forgot to mention that AI review noted the above check should be placed in skb_gso_mac_seglen(), too:

https://netdev-ai.bots.linux.dev/ai-review.html?id=bed04a62-0239-4392-a9a3-2399fee27630

AFAICS, it the OVS forwarding path should be impacted.

/P

#4 lore raw

Re: [PATCH net-next 1/3] net: gso: do not include jumbogram HBH header in seglen calculation

Quoted 28 lines · Paolo Abeni
Quoted 20 lines · Paolo Abeni
Quoted 19 lines · Mariusz Klimek

This patch fixes an issue in skb_gso_network_seglen where the calculated segment length includes the HBH headers of BIG TCP jumbograms despite these headers being removed before segmentation. These headers are added by GRO or by ip6_xmit for BIG TCP packets and are later removed by GSO. This bug causes MTU validation of BIG TCP jumbograms to fail.

---
 net/core/gso.c | 4 ++++
 1 file changed, 4 insertions(+)
net/core/gso.c +0 -0
index bcd156372f4d..251a49181031 100644
@@ -180,6 +180,10 @@ static unsigned int skb_gso_network_seglen(const struct sk_buff *skb)
 	unsigned int hdr_len = skb_transport_header(skb) -
 			       skb_network_header(skb);
 
Quoted 6 lines

net/core/gso.c static unsigned int skb_gso_network_seglen(const struct sk_buff *skb) · line 185

Quoted 3 lines
net/core/gso.c +3 -0
+	/* Jumbogram HBH header is removed upon segmentation. */
+	if (skb->protocol == htons(ETH_P_IPV6) && skb->len > IPV6_MAXPLEN)
+		hdr_len -= sizeof(struct hop_jumbo_hdr);

Isn't the above condition a bit too course-grain? Specifically, can UDP-encapsulated GSO packets wrongly hit it?

Quoted 9 lines

I forgot to mention that AI review noted the above check should be placed in skb_gso_mac_seglen(), too:

https://netdev-ai.bots.linux.dev/ai-review.html?id=bed04a62-0239-4392-a9a3-2399fee27630

AFAICS, it the OVS forwarding path should be impacted.

/P

Right. I'll add a helper function.

Signature · 1 line
Mariusz K.
#5 lore raw

Re: [PATCH net-next 1/3] net: gso: do not include jumbogram HBH header in seglen calculation

In reply to Paolo Abeni
Quoted 20 lines · Paolo Abeni
Quoted 19 lines · Mariusz Klimek

This patch fixes an issue in skb_gso_network_seglen where the calculated segment length includes the HBH headers of BIG TCP jumbograms despite these headers being removed before segmentation. These headers are added by GRO or by ip6_xmit for BIG TCP packets and are later removed by GSO. This bug causes MTU validation of BIG TCP jumbograms to fail.

---
 net/core/gso.c | 4 ++++
 1 file changed, 4 insertions(+)
net/core/gso.c +0 -0
index bcd156372f4d..251a49181031 100644
@@ -180,6 +180,10 @@ static unsigned int skb_gso_network_seglen(const struct sk_buff *skb)
 	unsigned int hdr_len = skb_transport_header(skb) -
 			       skb_network_header(skb);
 
Quoted 9 lines

net/core/gso.c static unsigned int skb_gso_network_seglen(const struct sk_buff *skb) · line 185

Quoted 3 lines
net/core/gso.c +3 -0
+	/* Jumbogram HBH header is removed upon segmentation. */
+	if (skb->protocol == htons(ETH_P_IPV6) && skb->len > IPV6_MAXPLEN)
+		hdr_len -= sizeof(struct hop_jumbo_hdr);

Isn't the above condition a bit too course-grain? Specifically, can UDP-encapsulated GSO packets wrongly hit it?

/P

You're right. Also, It should actually be skb->len - nhdr_len where nhdr_len is the length from the beginning of the packet up to right after the network header.

Should I send a new version or wait for net-next to re-open?

Signature · 1 line
Mariusz K.
maintainer
#6 lore raw

Re: [PATCH net-next 1/3] net: gso: do not include jumbogram HBH header in seglen calculation

Quoted 28 lines · Mariusz Klimek
Quoted 20 lines · Paolo Abeni
Quoted 19 lines · Mariusz Klimek

This patch fixes an issue in skb_gso_network_seglen where the calculated segment length includes the HBH headers of BIG TCP jumbograms despite these headers being removed before segmentation. These headers are added by GRO or by ip6_xmit for BIG TCP packets and are later removed by GSO. This bug causes MTU validation of BIG TCP jumbograms to fail.

---
 net/core/gso.c | 4 ++++
 1 file changed, 4 insertions(+)
net/core/gso.c +0 -0
index bcd156372f4d..251a49181031 100644
@@ -180,6 +180,10 @@ static unsigned int skb_gso_network_seglen(const struct sk_buff *skb)
 	unsigned int hdr_len = skb_transport_header(skb) -
 			       skb_network_header(skb);
 
Quoted 6 lines

net/core/gso.c static unsigned int skb_gso_network_seglen(const struct sk_buff *skb) · line 185

Quoted 3 lines
net/core/gso.c +3 -0
+	/* Jumbogram HBH header is removed upon segmentation. */
+	if (skb->protocol == htons(ETH_P_IPV6) && skb->len > IPV6_MAXPLEN)
+		hdr_len -= sizeof(struct hop_jumbo_hdr);

Isn't the above condition a bit too course-grain? Specifically, can UDP-encapsulated GSO packets wrongly hit it?

Quoted 4 lines

You're right. Also, It should actually be skb->len - nhdr_len where nhdr_len is the length from the beginning of the packet up to right after the network header.

Should I send a new version or wait for net-next to re-open?

You need to wait for net-next to re-open. Please note that due to the unfortunated calendar (conferences and EoY) this could be longer than usual.

All the information will be shared on the ML, as usual.

/P

#7 lore raw

PATCH 2/3 ipv6: remove IP6SKB_FAKEJUMBO flag

In reply to Mariusz Klimek

This patch removes the IP6SKB_FAKEJUMBO flag that is used as a work-around to bypass MTU validation of BIG TCP jumbograms due to a bug in skb_gso_network_seglen. This work-around is no longer required now that the bug is fixed.

---
 include/linux/ipv6.h  | 1 -
 net/ipv6/ip6_output.c | 4 +---
 2 files changed, 1 insertion(+), 4 deletions(-)
include/linux/ipv6.h +0 -1
index 7294e4e89b79..9f076171106e 100644
@@ -155,7 +155,6 @@ struct inet6_skb_parm {
 #define IP6SKB_L3SLAVE         64
 #define IP6SKB_JUMBOGRAM      128
 #define IP6SKB_SEG6	      256
-#define IP6SKB_FAKEJUMBO      512
 #define IP6SKB_MULTIPATH      1024
 #define IP6SKB_MCROUTE        2048
 };
net/ipv6/ip6_output.c +1 -3
index f904739e99b9..9af9ec6bdb8c 100644
@@ -179,8 +179,7 @@ ip6_finish_output_gso_slowpath_drop(struct net *net, struct sock *sk,
 static int ip6_finish_output_gso(struct net *net, struct sock *sk,
 				 struct sk_buff *skb, unsigned int mtu)
 {
-	if (!(IP6CB(skb)->flags & IP6SKB_FAKEJUMBO) &&
-	    !skb_gso_validate_network_len(skb, mtu))
+	if (!skb_gso_validate_network_len(skb, mtu))
 		return ip6_finish_output_gso_slowpath_drop(net, sk, skb, mtu);
 
 	return ip6_finish_output2(net, sk, skb);
@@ -323,7 +322,6 @@ int ip6_xmit(const struct sock *sk, struct sk_buff *skb, struct flowi6 *fl6,
 
 		proto = IPPROTO_HOPOPTS;
 		seg_len = 0;
-		IP6CB(skb)->flags |= IP6SKB_FAKEJUMBO;
 	}
 
 	skb_push(skb, sizeof(struct ipv6hdr));
Signature · 1 line
2.47.3
#8 lore raw

PATCH 3/3 selftests/net: remove unnecessary MTU config in big_tcp.sh

In reply to Mariusz Klimek

This patch removes the manual lowering of the client MTU in big_tcp.sh. The MTU lowering was previously required as a work-around due to a bug in the MTU validation of BIG TCP jumbograms. The MTU was lowered to 1442, but note that 1492 (1500 - 8) would of worked just as well. Now that the bug has been fixed, the manual client MTU modification can be removed entirely.

---
 tools/testing/selftests/net/big_tcp.sh | 1 -
 1 file changed, 1 deletion(-)
tools/testing/selftests/net/big_tcp.sh +0 -1
index 2db9d15cd45f..b5d9145296d3 100755
@@ -32,7 +32,6 @@ setup() {
 	ip -net $ROUTER_NS link add link2 type veth peer name link3 netns $SERVER_NS
 
 	ip -net $CLIENT_NS link set link0 up
-	ip -net $CLIENT_NS link set link0 mtu 1442
 	ip -net $CLIENT_NS addr add $CLIENT_IP4/24 dev link0
 	ip -net $CLIENT_NS addr add $CLIENT_IP6/64 dev link0 nodad
 	ip -net $CLIENT_NS route add $SERVER_IP4 dev link0 via $CLIENT_GW4
Signature · 1 line
2.47.3
maintainer
#9 lore raw

Re: [PATCH net-next 3/3] selftests/net: remove unnecessary MTU config in big_tcp.sh

Quoted 7 lines · Mariusz Klimek

This patch removes the manual lowering of the client MTU in big_tcp.sh. The MTU lowering was previously required as a work-around due to a bug in the MTU validation of BIG TCP jumbograms. The MTU was lowered to 1442, but note that 1492 (1500 - 8) would of worked just as well. Now that the bug has been fixed, the manual client MTU modification can be removed entirely.

While touching this self-tests, I think it would be nice to additionally add the 'negative' case, i.e. egress mtu lower than ingress and bit tcp segmentation taking place.

/P

#10 lore raw

Re: [PATCH net-next 3/3] selftests/net: remove unnecessary MTU config in big_tcp.sh

Quoted 7 lines · Paolo Abeni
Quoted 6 lines · Mariusz Klimek

This patch removes the manual lowering of the client MTU in big_tcp.sh. The MTU lowering was previously required as a work-around due to a bug in the MTU validation of BIG TCP jumbograms. The MTU was lowered to 1442, but note that 1492 (1500 - 8) would of worked just as well. Now that the bug has been fixed, the manual client MTU modification can be removed entirely.

Quoted 8 lines
Quoted 1 line

While touching this self-tests, I think it would be nice to additionally add the 'negative' case, i.e. egress mtu lower than ingress and bit tcp segmentation taking place.

/P

Good idea. I'll update the tests.

Signature · 1 line
Mariusz K.
#11 lore raw

Re: [PATCH net-next 3/3] selftests/net: remove unnecessary MTU config in big_tcp.sh

Quoted 10 lines · Mariusz Klimek
Quoted 9 lines · Paolo Abeni
Quoted 7 lines · Mariusz Klimek

This patch removes the manual lowering of the client MTU in big_tcp.sh. The MTU lowering was previously required as a work-around due to a bug in the MTU validation of BIG TCP jumbograms. The MTU was lowered to 1442, but note that 1492 (1500 - 8) would of worked just as well. Now that the bug has been fixed, the manual client MTU modification can be removed entirely.

Quoted 9 lines
Quoted 6 lines

While touching this self-tests, I think it would be nice to additionally add the 'negative' case, i.e. egress mtu lower than ingress and bit tcp segmentation taking place.

/P

Good idea. I'll update the tests.

Actually, this idea doesn't really work. When lowering the egress MTU, the MSS is also lowered, so no segmentation will (or should) occur, and so the negative case will never fail.

Signature · 1 line
Mariusz K.