Skip to contentSkip to conversation

hwmon: (max6697) fix regmap leak on probe failure

PATCH Applied Johan Hovold 2 participants 2 messages Nov 27, 2025

Subsystems (2)
Stable branch Hardware monitoring
lore
Share & tools
lore

Johan Hovold

author
#0 lore raw

PATCH 1/1 hwmon: (max6697) fix regmap leak on probe failure

The i2c regmap allocated during probe is never freed.

Switch to using the device managed allocator so that the regmap is released on probe failures (e.g. probe deferral) and on driver unbind.

Fixes 3a2a8cc3fe24 ("hwmon: (max6697) Convert to use regmap")
Cc [email protected] # 6.12
Cc Guenter Roeck <[email protected]>
Signed-off-by Johan Hovold <[email protected]>
---
 drivers/hwmon/max6697.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/hwmon/max6697.c +1 -1
index 0735a1d2c20f..6926d787b5ad 100644
@@ -548,7 +548,7 @@ static int max6697_probe(struct i2c_client *client)
 	struct regmap *regmap;
 	int err;
 
-	regmap = regmap_init_i2c(client, &max6697_regmap_config);
+	regmap = devm_regmap_init_i2c(client, &max6697_regmap_config);
 	if (IS_ERR(regmap))
 		return PTR_ERR(regmap);
Signature · 1 line
2.51.2
maintainer Applied
#1 lore raw
Quoted 9 lines · Johan Hovold

The i2c regmap allocated during probe is never freed.

Switch to using the device managed allocator so that the regmap is released on probe failures (e.g. probe deferral) and on driver unbind.

Fixes 3a2a8cc3fe24 ("hwmon: (max6697) Convert to use regmap")
Cc [email protected] # 6.12
Cc Guenter Roeck <[email protected]>
Signed-off-by Johan Hovold <[email protected]>

Applied.

Thanks,
Guenter